From nobody Thu Apr 2 06:27:21 2026 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85A412E92A2 for ; Wed, 25 Feb 2026 18:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772043835; cv=none; b=dm8geW1mkm5cJ9ceca/MAIYdkExeyTU3XJMeay7rIkt+mguEALEH9L+2PHQpuwbAcPo/1J2XzjEPVsmqnV00n8MfCuV1BZpfZbrV1lSmBdOqeCi+bnBcfFK3SODsFyruly9Ge3/eWk8Tw+0B5m+DrASQUjZw3UdHIcviE6sipls= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772043835; c=relaxed/simple; bh=LLwOPS1L8RnAB7NK+B/I+dxxQWLv04xJfccMGdGZtME=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=mufkoMoJ0bW4hsgtglN3baQZ+HFKvbKZeYpyDDoII37Q5dd4TqOc2C2pFcaKpSzTfHKgT8Dt8c0PVciQYAtLtzE8XiKvP/Mk0en2Aw+Wn6XKU9v3JKkoXWusygOr4BsNe9hFuhmP1vrE0vL08Vhi9K7tzW75wD7bPSaDJSh5lBI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--joshwash.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=UxvMjtP2; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--joshwash.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UxvMjtP2" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c70ea2f7d1bso759359a12.2 for ; Wed, 25 Feb 2026 10:23:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772043834; x=1772648634; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=3tIPlETo+nW7/9bKJG0AVKHGPCMoVCLC4Z+gTp5I97A=; b=UxvMjtP2TZkMDzVtX9nGv+9GM2cynt8F8VUxqsVcO4TS93xJc4O08BXOdx4Ji/pLDx BdHGMytvVKabFCGq1/rOImAyfYMC4c31ytokufBnb3N5hHjWvOrhMfxblk0y7aEK990K xdTgqe82BiWzVo68e+4TOdw+b4QsOzHGKmblg9IeqTAb0lVBv1c+ZocNDdg3D6c1e12G ecnGDyh8CJEfprAfA7tsA113oNxnIgRQG5eXoLgf55cYjI4FnxG/R/t/caE9HttbQM3Z z53SaQu58Rm/OfqrWUXL1FQovd+9HNtfK1h7P5z9YfkI2Nff4y8idwUXtkgL1HX//i1o Z/zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772043834; x=1772648634; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3tIPlETo+nW7/9bKJG0AVKHGPCMoVCLC4Z+gTp5I97A=; b=Jn+q4MEoFR4cRLCysNT6Bmoc0Xufqf7BwXeQNYpkGuB0MAHxnmi7Z95mlK2xvVJQTe gxSgCC6gVEvmgkzCmSZjRDTg0u0W4iG5kZh+qauuPU+s4nYhGx6HYi/kaW5HYZbVKnIB /GhT0He3IOnBB2C1i5eFaKD/EooVPNI0ZlqLdy3kZMR+5EZQPndOCsc4Yh6bPXmjIzwg gIwuT2W3bNGWwW//pSoeJiaxdS8CvC2U73QjgEurQBFAE3v2I4tzuH1clyvAPjpjvBoJ 0P3B9tin4ZI/EAfh/WWFzLqzmUk09965bSQAf125OiWhwtdSqXxZE9CqrrCWIMLr/+W7 r3CA== X-Forwarded-Encrypted: i=1; AJvYcCWZxADy/usct0X6winzsCAM5kIUGJM8yOVYbdezbRlkc5wrExyzEnRlx3vCUU5odw97AkdSEv4MupfOQ1s=@vger.kernel.org X-Gm-Message-State: AOJu0YyC1YxKv5je+wkJ+5i/y25AD5GCII1t3oGy4gdVhBS+sskKEv9I KJvfPHjP2dwAiY+GI6/8niBk3zI2nKdMc2ckYfko3yEgWiYg4EJP+u/azHeGCh6KbUQWc9bLm1z HIbnu3M2iGA/w0w== X-Received: from pghp21.prod.google.com ([2002:a63:fe15:0:b0:c65:c5fc:1707]) (user=joshwash job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:958e:b0:34e:be9b:b67f with SMTP id adf61e73a8af0-39545f8794bmr13973218637.49.1772043833725; Wed, 25 Feb 2026 10:23:53 -0800 (PST) Date: Wed, 25 Feb 2026 10:23:42 -0800 In-Reply-To: <20260225182342.1049816-1-joshwash@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260225182342.1049816-1-joshwash@google.com> X-Mailer: git-send-email 2.53.0.414.gf7e9f6c205-goog Message-ID: <20260225182342.1049816-3-joshwash@google.com> Subject: [PATCH net-next v2 2/2] gve: Enable reading max ring size from the device in DQO-QPL mode From: Joshua Washington To: netdev@vger.kernel.org Cc: Joshua Washington , Harshitha Ramamurthy , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , Jordan Rhee , John Fraker , Ziwei Xiao , Matt Olson , Praveen Kaligineedi , Bailey Forrest , Tim Hostetler , linux-kernel@vger.kernel.org, Max Yuan Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Matt Olson The gVNIC device indicates a device option (MODIFY_RING) to the driver, which presents a range of ring sizes from which the user is allowed to select. But in DQO-QPL queue format, the driver ignores the "max" of this range and instead allows the user to configure the ring size in the range [min, default]. This was done because increasing the ring size could result in the number of registered pages being higher than the max allowed by the device. In order to support large ring sizes, stop ignoring the "max" of the range presented in the MODIFY_RING option. Signed-off-by: Matt Olson Signed-off-by: Max Yuan Reviewed-by: Jordan Rhee Reviewed-by: Harshitha Ramamurthy Reviewed-by: Praveen Kaligineedi Signed-off-by: Joshua Washington --- drivers/net/ethernet/google/gve/gve_adminq.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/google/gve/gve_adminq.c b/drivers/net/eth= ernet/google/gve/gve_adminq.c index b1983f97..08587bf4 100644 --- a/drivers/net/ethernet/google/gve/gve_adminq.c +++ b/drivers/net/ethernet/google/gve/gve_adminq.c @@ -989,12 +989,10 @@ static void gve_enable_supported_features(struct gve_= priv *priv, if (dev_op_modify_ring && (supported_features_mask & GVE_SUP_MODIFY_RING_MASK)) { priv->modify_ring_size_enabled =3D true; - - /* max ring size for DQO QPL should not be overwritten because of device= limit */ - if (priv->queue_format !=3D GVE_DQO_QPL_FORMAT) { - priv->max_rx_desc_cnt =3D be16_to_cpu(dev_op_modify_ring->max_rx_ring_s= ize); - priv->max_tx_desc_cnt =3D be16_to_cpu(dev_op_modify_ring->max_tx_ring_s= ize); - } + priv->max_rx_desc_cnt =3D + be16_to_cpu(dev_op_modify_ring->max_rx_ring_size); + priv->max_tx_desc_cnt =3D + be16_to_cpu(dev_op_modify_ring->max_tx_ring_size); if (priv->default_min_ring_size) { /* If device hasn't provided minimums, use default minimums */ priv->min_tx_desc_cnt =3D GVE_DEFAULT_MIN_TX_RING_SIZE; -- 2.53.0.273.g2a3d683680-goog