From nobody Tue Apr 7 12:22:56 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36ABE3D5258; Wed, 25 Feb 2026 15:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772032038; cv=none; b=SGcxTFv5a2kaKYuu8sTopr9JkrMWgMyQYw3tNUtQF8Qdd5BbaHv9YO356DnKw6faCFeAHsU+vhaFVbVHnumWv8rfa99/CG6x0Ig/4l0YSy4K8svd2+SJ3M3Y/Jr/1igu07uVXmAPbgs8/jd8LBf9434z5BgGvPD6wFo47CrCmxU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772032038; c=relaxed/simple; bh=3Wle/4NMS9dUvTddlrz8Abwbv3sDB98Hc0n3VxHRZJY=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CU2SPeUnxgJ478Ya7fYyes+7YYtzsIGkcAJ2oS6cYBAGHkrZ+TLrTWIehujtXJfr6QyO0LT2YxZgK+wCMppPxfaz0zgMgY0cKFgcpC1I3i4zf3YkAaO5GaP+cRq2LeF2qlFHrDMc7sUhxIXf4nEkNXH9XEtwwJ2uWv6yzqdEO1s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=cU3W9Zzp; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="cU3W9Zzp" Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61PAZ2N6818460; Wed, 25 Feb 2026 10:06:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=Q5Z8f rijDJjPhMFrkOlOcb/yCuimb5QOM2qOM5uGcg4=; b=cU3W9ZzpWoE3Lha9Jyydg C964b0ANIt35tRhHe/9fwymRXsnKuGWl30EW8NvuE5uOQ6SC/6FpeSpGKtnG6YbA /XT2LQgtWQhfAsGPP3AQq7joXQ1t0qd77QX0Ii9Gfylhhsui4vzh+DDXVyc0KwG7 GyrS+7PmN/JDjmTQKAHxiRCFzUQHsc95ean9Et7PUau3n4lpmGGTJNd7jvuIdXhD WQN9BYInQD7G2juwNf2H+qY2WRGRRzmQGiGbM7RsDC9Fxr+jl80xJqpTVulAhBG0 pSOAMcrBLYgnOjp0zNLDlYz6YmHKBtiJ+UwOKJoymtzkHh3wynU4o1PXvgo29KJM w== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cg7p0d54v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Feb 2026 10:06:49 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61PF6m4K024632 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 25 Feb 2026 10:06:48 -0500 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Wed, 25 Feb 2026 10:06:47 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Wed, 25 Feb 2026 10:06:47 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Wed, 25 Feb 2026 10:06:47 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61PF6Ynp006794; Wed, 25 Feb 2026 10:06:44 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v3 1/6] iio: frequency: adrf6780: add dev variable and use dev_err_probe Date: Wed, 25 Feb 2026 17:05:47 +0200 Message-ID: <20260225150615.274078-2-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260225150615.274078-1-antoniu.miclaus@analog.com> References: <20260225150615.274078-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-ORIG-GUID: 3Tzh2P8q-tq0lsN-O0w58kd6JZwh7zRu X-Proofpoint-GUID: 3Tzh2P8q-tq0lsN-O0w58kd6JZwh7zRu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI1MDE0NSBTYWx0ZWRfXzo5Pb8JYtfHc wm4LgvYvxtaoBSFq/fj8i1pdGvmYY0ncWsEvnTURWyWd7wj1450w4uioUjqmsrJ4Y35IIlevdd6 a0he2KyuRlC/OZz1gmfWWx5jhi+e1gdrq1ZBFCLvm/xcmTKuXwkgw7IbmstPJcLfy1EL6UyhxtN w3Z2OpZCInYDyzghnTRlvxRNbZ9TEz2e86KnJOc/aWxZHCCbRC5NsSQoMS4/Qgk5uTM4NuV0u9N lATiDYa48eyebeb6vutIKxft+AN3WbYauJEZfN3fB4haYcFXx2IIhqPxqm2+doXjhk5CZwaYzxZ 3yhF/mrQAv0n22qPDz4n4ssneF1zam2iKK/qmrENe4Bvw7fuY+A78KjeUMIBCd1RRObSes0OK8j RA4PW76Po2p/+LyPVXjPJuqc+bBWRC4GF3nuyQLXvq78C3xl8TUJfwTGPzsrs42U7RjmvMoa8OD hdqf+S9ovhw3RfAfoow== X-Authority-Analysis: v=2.4 cv=Fq4IPmrq c=1 sm=1 tr=0 ts=699f1009 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=Z0pTeXoby7EwIRygza74:22 a=gAnH3GRIAAAA:8 a=bMEtPg1WnvWC4BS4PrsA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_01,2026-02-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 impostorscore=0 phishscore=0 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602250145 Content-Type: text/plain; charset="utf-8" Introduce a struct device *dev local variable and replace dev_err() + return with dev_err_probe() in functions that use devm_ managed resources. This simplifies error handling and ensures proper logging of deferred probes. Drop 'SPI' from error messages since the bus type is evident from the device hierarchy. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/adrf6780.c | 60 +++++++++++++++----------------- 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/drivers/iio/frequency/adrf6780.c b/drivers/iio/frequency/adrf6= 780.c index a7a21f929970..be8838ab10fb 100644 --- a/drivers/iio/frequency/adrf6780.c +++ b/drivers/iio/frequency/adrf6780.c @@ -346,23 +346,21 @@ static const struct iio_chan_spec adrf6780_channels[]= =3D { static int adrf6780_reset(struct adrf6780_state *st) { int ret; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; =20 ret =3D __adrf6780_spi_update_bits(st, ADRF6780_REG_CONTROL, ADRF6780_SOFT_RESET_MSK, FIELD_PREP(ADRF6780_SOFT_RESET_MSK, 1)); - if (ret) { - dev_err(&spi->dev, "ADRF6780 SPI software reset failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADRF6780 software reset failed.\n"); =20 ret =3D __adrf6780_spi_update_bits(st, ADRF6780_REG_CONTROL, ADRF6780_SOFT_RESET_MSK, FIELD_PREP(ADRF6780_SOFT_RESET_MSK, 0)); - if (ret) { - dev_err(&spi->dev, "ADRF6780 SPI software reset disable failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADRF6780 software reset disable failed.\n"); =20 return 0; } @@ -371,7 +369,7 @@ static int adrf6780_init(struct adrf6780_state *st) { int ret; unsigned int chip_id, enable_reg, enable_reg_msk; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; =20 /* Perform a software reset */ ret =3D adrf6780_reset(st); @@ -383,10 +381,9 @@ static int adrf6780_init(struct adrf6780_state *st) return ret; =20 chip_id =3D FIELD_GET(ADRF6780_CHIP_ID_MSK, chip_id); - if (chip_id !=3D ADRF6780_CHIP_ID) { - dev_err(&spi->dev, "ADRF6780 Invalid Chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D ADRF6780_CHIP_ID) + return dev_err_probe(dev, -EINVAL, + "ADRF6780 Invalid Chip ID.\n"); =20 enable_reg_msk =3D ADRF6780_VGA_BUFFER_EN_MSK | ADRF6780_DETECTOR_EN_MSK | @@ -426,18 +423,18 @@ static int adrf6780_init(struct adrf6780_state *st) =20 static void adrf6780_properties_parse(struct adrf6780_state *st) { - struct spi_device *spi =3D st->spi; - - st->vga_buff_en =3D device_property_read_bool(&spi->dev, "adi,vga-buff-en= "); - st->lo_buff_en =3D device_property_read_bool(&spi->dev, "adi,lo-buff-en"); - st->if_mode_en =3D device_property_read_bool(&spi->dev, "adi,if-mode-en"); - st->iq_mode_en =3D device_property_read_bool(&spi->dev, "adi,iq-mode-en"); - st->lo_x2_en =3D device_property_read_bool(&spi->dev, "adi,lo-x2-en"); - st->lo_ppf_en =3D device_property_read_bool(&spi->dev, "adi,lo-ppf-en"); - st->lo_en =3D device_property_read_bool(&spi->dev, "adi,lo-en"); - st->uc_bias_en =3D device_property_read_bool(&spi->dev, "adi,uc-bias-en"); - st->lo_sideband =3D device_property_read_bool(&spi->dev, "adi,lo-sideband= "); - st->vdet_out_en =3D device_property_read_bool(&spi->dev, "adi,vdet-out-en= "); + struct device *dev =3D &st->spi->dev; + + st->vga_buff_en =3D device_property_read_bool(dev, "adi,vga-buff-en"); + st->lo_buff_en =3D device_property_read_bool(dev, "adi,lo-buff-en"); + st->if_mode_en =3D device_property_read_bool(dev, "adi,if-mode-en"); + st->iq_mode_en =3D device_property_read_bool(dev, "adi,iq-mode-en"); + st->lo_x2_en =3D device_property_read_bool(dev, "adi,lo-x2-en"); + st->lo_ppf_en =3D device_property_read_bool(dev, "adi,lo-ppf-en"); + st->lo_en =3D device_property_read_bool(dev, "adi,lo-en"); + st->uc_bias_en =3D device_property_read_bool(dev, "adi,uc-bias-en"); + st->lo_sideband =3D device_property_read_bool(dev, "adi,lo-sideband"); + st->vdet_out_en =3D device_property_read_bool(dev, "adi,vdet-out-en"); } =20 static void adrf6780_powerdown(void *data) @@ -450,9 +447,10 @@ static int adrf6780_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct adrf6780_state *st; + struct device *dev =3D &spi->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -467,9 +465,9 @@ static int adrf6780_probe(struct spi_device *spi) =20 adrf6780_properties_parse(st); =20 - st->clkin =3D devm_clk_get_enabled(&spi->dev, "lo_in"); + st->clkin =3D devm_clk_get_enabled(dev, "lo_in"); if (IS_ERR(st->clkin)) - return dev_err_probe(&spi->dev, PTR_ERR(st->clkin), + return dev_err_probe(dev, PTR_ERR(st->clkin), "failed to get the LO input clock\n"); =20 mutex_init(&st->lock); @@ -478,11 +476,11 @@ static int adrf6780_probe(struct spi_device *spi) if (ret) return ret; =20 - ret =3D devm_add_action_or_reset(&spi->dev, adrf6780_powerdown, st); + ret =3D devm_add_action_or_reset(dev, adrf6780_powerdown, st); if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id adrf6780_id[] =3D { --=20 2.43.0 From nobody Tue Apr 7 12:22:56 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 521343D522B; Wed, 25 Feb 2026 15:07:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772032037; cv=none; b=KSGQyKwQm5bfawPEWf8zM/+kGJ2WNoPEQKHO5GwI2GqpCnEW3ugfZQuLjZTJMfNT5X2HJbfqJeaF9AwAXVDoMfdUsaF8bIZA1MCf2Bp1Ygp003UZeTVMx5zXDA9FpGZEKw8YqhnIUKYYUTXTO1MxTmYuRhGXeFx0NK78vZhtKFc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772032037; c=relaxed/simple; bh=eRUTVBAO2hokbiuOibV3C7ozM+5NoYaH93/SNwkV4IE=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EeKBNL6F/YJ4XIZbfakpuOyjb04cw6kZiyKa0zUpeiYXv/9Yb3otPbfHKY+QDTYsqD3P1JwkkxpqFN+GZ3sXuMG5gavPikNTCKKxzGHdq1jqcRlrrPBrpLzfZbkVSOGg/S6+cxHMqkhDWeknDa+2RH0VG6Qr145rQt4IPL6GRtY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=dhfw90A8; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="dhfw90A8" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61PAjRdH1742992; Wed, 25 Feb 2026 10:06:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=dEkzG tQZ0dQ4FBtz49U4nu2kDZLPaWhyqtUCRe2Z25w=; b=dhfw90A85/WtQY7mK06hO JbqIUCmItkRN9hKtW8ZIABrpQ/ed3snQhgc1Mn1eq28fc5vdgnJ68i7DelVgWOzO ZZZfNDQvUwxhWWvm5L/OiHb5JUrPPJEFgdtg/y2dAhAalxuaICb51iqFbZW9b/W/ z+4iR+8n9FeNxLDaYF68ueErSGO0qFwnD9CrCqPrL+30m3l75MQ9gJjH+hcwFvw5 ubNZhzrfhFz3/EAicHL/A5tCsqqNZbIsJLpVeoxjrk3aPrTK4yBzmOhB2ZWJt7T6 HmIFuGwpmQTw0sGYP11CWyO8xMqopoQikcENbMiHKfjkzxKcoV65hZqcfLuKWoRE A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cg7p4wa9c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Feb 2026 10:06:53 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61PF6qsW024644 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 25 Feb 2026 10:06:52 -0500 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Wed, 25 Feb 2026 10:06:52 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Wed, 25 Feb 2026 10:06:52 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Wed, 25 Feb 2026 10:06:52 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61PF6Ynq006794; Wed, 25 Feb 2026 10:06:46 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v3 2/6] iio: frequency: admv1014: add dev variable and use dev_err_probe Date: Wed, 25 Feb 2026 17:05:48 +0200 Message-ID: <20260225150615.274078-3-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260225150615.274078-1-antoniu.miclaus@analog.com> References: <20260225150615.274078-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI1MDE0NSBTYWx0ZWRfXxXfnWxqdZ+XW p2lHo+a3Jcz6mcCivcnhj5Cxbqtn+zapfXhq+Ts5bIw8k4GonhtQBePieZd2WFDtrhAaWuygi3d wsux7b7Icn+fkPZbJsBF8/B4IfVBqoUrJSwKACoOPNJ6LzyUBvqft6STqRjoAw+iUxJkR7E5Shh qQ6/AdAQG/jr0r/+EuhWElOj/LfK8GxrVVUQb/H0xVwmK7ripIBOoojG5fp39oEevwfZ4GaCrd0 UDfGK//zTljTUoBrPGX6YX0VBRcFC8iWI/vk8+qzDY9D9uAJ3+NGofTVoKVLz/g8iiuqzb0U9U4 b2Qrq/B4uIvhUMWQ8/zzGhTH5pSuIKGAXq1s5cncD07terTreMVEubwRxcatJc8ai/OIVVbVEbt z6/QU0o2AzrMC9RHGT0VBBbljwYwP/elLrBN/Y+VWVkZog+49RkAJ1W38eNQNgrY3OwFLxUnPvX Ip9VxHmYdh+LKrEx8Cg== X-Proofpoint-ORIG-GUID: hYv9m2f7sBg-2vo4OSO_WkC9x2pT4Byn X-Authority-Analysis: v=2.4 cv=LfgxKzfi c=1 sm=1 tr=0 ts=699f100d cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=gAnH3GRIAAAA:8 a=3cO7uaoVlvYoWMCBlHYA:9 X-Proofpoint-GUID: hYv9m2f7sBg-2vo4OSO_WkC9x2pT4Byn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_01,2026-02-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 spamscore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602250145 Content-Type: text/plain; charset="utf-8" Introduce a struct device *dev local variable and replace dev_err() + return with dev_err_probe() in functions that use devm_ managed resources. This simplifies error handling and ensures proper logging of deferred probes. Drop 'SPI' from error messages since the bus type is evident from the device hierarchy. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/admv1014.c | 94 +++++++++++++++----------------- 1 file changed, 43 insertions(+), 51 deletions(-) diff --git a/drivers/iio/frequency/admv1014.c b/drivers/iio/frequency/admv1= 014.c index 7a8f92ec80a2..eeb01cfb799f 100644 --- a/drivers/iio/frequency/admv1014.c +++ b/drivers/iio/frequency/admv1014.c @@ -609,16 +609,15 @@ static void admv1014_powerdown(void *data) static int admv1014_init(struct admv1014_state *st) { unsigned int chip_id, enable_reg, enable_reg_msk; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; int ret; =20 ret =3D regulator_bulk_enable(ADMV1014_NUM_REGULATORS, st->regulators); - if (ret) { - dev_err(&spi->dev, "Failed to enable regulators"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to enable regulators"); =20 - ret =3D devm_add_action_or_reset(&spi->dev, admv1014_reg_disable, st->reg= ulators); + ret =3D devm_add_action_or_reset(dev, admv1014_reg_disable, st->regulator= s); if (ret) return ret; =20 @@ -626,16 +625,16 @@ static int admv1014_init(struct admv1014_state *st) if (ret) return ret; =20 - ret =3D devm_add_action_or_reset(&spi->dev, admv1014_clk_disable, st->clk= in); + ret =3D devm_add_action_or_reset(dev, admv1014_clk_disable, st->clkin); if (ret) return ret; =20 st->nb.notifier_call =3D admv1014_freq_change; - ret =3D devm_clk_notifier_register(&spi->dev, st->clkin, &st->nb); + ret =3D devm_clk_notifier_register(dev, st->clkin, &st->nb); if (ret) return ret; =20 - ret =3D devm_add_action_or_reset(&spi->dev, admv1014_powerdown, st); + ret =3D devm_add_action_or_reset(dev, admv1014_powerdown, st); if (ret) return ret; =20 @@ -643,55 +642,48 @@ static int admv1014_init(struct admv1014_state *st) ret =3D __admv1014_spi_update_bits(st, ADMV1014_REG_SPI_CONTROL, ADMV1014_SPI_SOFT_RESET_MSK, FIELD_PREP(ADMV1014_SPI_SOFT_RESET_MSK, 1)); - if (ret) { - dev_err(&spi->dev, "ADMV1014 SPI software reset failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADMV1014 software reset failed.\n"); =20 ret =3D __admv1014_spi_update_bits(st, ADMV1014_REG_SPI_CONTROL, ADMV1014_SPI_SOFT_RESET_MSK, FIELD_PREP(ADMV1014_SPI_SOFT_RESET_MSK, 0)); - if (ret) { - dev_err(&spi->dev, "ADMV1014 SPI software reset disable failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADMV1014 software reset disable failed.\n"); =20 ret =3D __admv1014_spi_write(st, ADMV1014_REG_VVA_TEMP_COMP, 0x727C); - if (ret) { - dev_err(&spi->dev, "Writing default Temperature Compensation value faile= d.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Writing default Temperature Compensation value failed.\n"); =20 ret =3D __admv1014_spi_read(st, ADMV1014_REG_SPI_CONTROL, &chip_id); if (ret) return ret; =20 chip_id =3D FIELD_GET(ADMV1014_CHIP_ID_MSK, chip_id); - if (chip_id !=3D ADMV1014_CHIP_ID) { - dev_err(&spi->dev, "Invalid Chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D ADMV1014_CHIP_ID) + return dev_err_probe(dev, -EINVAL, + "Invalid Chip ID.\n"); =20 ret =3D __admv1014_spi_update_bits(st, ADMV1014_REG_QUAD, ADMV1014_QUAD_SE_MODE_MSK, FIELD_PREP(ADMV1014_QUAD_SE_MODE_MSK, st->quad_se_mode)); - if (ret) { - dev_err(&spi->dev, "Writing Quad SE Mode failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Writing Quad SE Mode failed.\n"); =20 ret =3D admv1014_update_quad_filters(st); - if (ret) { - dev_err(&spi->dev, "Update Quad Filters failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Update Quad Filters failed.\n"); =20 ret =3D admv1014_update_vcm_settings(st); - if (ret) { - dev_err(&spi->dev, "Update VCM Settings failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Update VCM Settings failed.\n"); =20 enable_reg_msk =3D ADMV1014_P1DB_COMPENSATION_MSK | ADMV1014_IF_AMP_PD_MSK | @@ -711,14 +703,14 @@ static int admv1014_init(struct admv1014_state *st) static int admv1014_properties_parse(struct admv1014_state *st) { unsigned int i; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; int ret; =20 - st->det_en =3D device_property_read_bool(&spi->dev, "adi,detector-enable"= ); + st->det_en =3D device_property_read_bool(dev, "adi,detector-enable"); =20 - st->p1db_comp =3D device_property_read_bool(&spi->dev, "adi,p1db-compensa= tion-enable"); + st->p1db_comp =3D device_property_read_bool(dev, "adi,p1db-compensation-e= nable"); =20 - ret =3D device_property_match_property_string(&spi->dev, "adi,input-mode", + ret =3D device_property_match_property_string(dev, "adi,input-mode", input_mode_names, ARRAY_SIZE(input_mode_names)); if (ret >=3D 0) @@ -726,7 +718,7 @@ static int admv1014_properties_parse(struct admv1014_st= ate *st) else st->input_mode =3D ADMV1014_IQ_MODE; =20 - ret =3D device_property_match_property_string(&spi->dev, "adi,quad-se-mod= e", + ret =3D device_property_match_property_string(dev, "adi,quad-se-mode", quad_se_mode_names, ARRAY_SIZE(quad_se_mode_names)); if (ret >=3D 0) @@ -737,16 +729,15 @@ static int admv1014_properties_parse(struct admv1014_= state *st) for (i =3D 0; i < ADMV1014_NUM_REGULATORS; ++i) st->regulators[i].supply =3D admv1014_reg_name[i]; =20 - ret =3D devm_regulator_bulk_get(&st->spi->dev, ADMV1014_NUM_REGULATORS, + ret =3D devm_regulator_bulk_get(dev, ADMV1014_NUM_REGULATORS, st->regulators); - if (ret) { - dev_err(&spi->dev, "Failed to request regulators"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to request regulators"); =20 - st->clkin =3D devm_clk_get(&spi->dev, "lo_in"); + st->clkin =3D devm_clk_get(dev, "lo_in"); if (IS_ERR(st->clkin)) - return dev_err_probe(&spi->dev, PTR_ERR(st->clkin), + return dev_err_probe(dev, PTR_ERR(st->clkin), "failed to get the LO input clock\n"); =20 return 0; @@ -756,9 +747,10 @@ static int admv1014_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct admv1014_state *st; + struct device *dev =3D &spi->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -787,7 +779,7 @@ static int admv1014_probe(struct spi_device *spi) if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id admv1014_id[] =3D { --=20 2.43.0 From nobody Tue Apr 7 12:22:56 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59F9B3D5231; Wed, 25 Feb 2026 15:07:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772032037; cv=none; b=IHqb/chHZSMNdyR+hHesKPugFBt5gL7XZ3ehjERsXC66n9+73/nmo6H6GyyocKIDWVo3bdhhw80cU/O/i7rMtHT1IvI8YCfMiBludcyaymy9GZtFW2PgApCS55KP24sVgeGsM0xvRQxgzi0ooYJXUDtA8qIrXFMbx55LjsFF0FI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772032037; c=relaxed/simple; bh=ZR0KwPCwIiL37jfKWpqreO7Iid9IKiyi7GAUfuwZJmk=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZDqwGdf726jvkh6LflwLBMVZzF594CAEOckaBGTXFizgJH67jonPjaqKLGpXDG1CdX0HKZjpaLGOmxiBDg0ZqugFeYFi67ZxYOBQaFnCA0ymJhO7nqbfU0UrMQJTo1NumavyHGaftX4BMQpxPtXq6chYwjVgJ+0Mg+ef4Sucj0s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=ovtR4uYg; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="ovtR4uYg" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61PE3KW51869023; Wed, 25 Feb 2026 10:06:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=KuqtH SIjAMKZLvlieHrOWkpsrzcLd6TG35gZF77967M=; b=ovtR4uYgCk4HyfyOeMqBy dB1B60TP0iuuEA35iWBd52Lu5VJGdeAAtbN0WmFIHFdmTGuenpdV5Fpq3LR4opEp 3p02el1rFeslCobW4s7xjmk4AFI8/vNdvnQFFpQv7gVAJt4PjA8UnkSzVzUgBpvL Ucaab91J0jEbJIQF2dOiRUqjgcgQQVPgOWrOg47WULP70hRzed4QyDI2teCQKCSp Ej0wXuakjZ0wZsJjWMPd6AnKmvdG35VF0H4iTvuZCgrGzbJviaOgow7lO1dMxTKs HlLS9IdiCfbXfDQj2N3XacIbnh7Po6c9lWzTuryT1fZSi8dzN18usd95ZdBJEfeB A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4chvwg1gj0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Feb 2026 10:06:54 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61PF6rpY024647 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 25 Feb 2026 10:06:53 -0500 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Wed, 25 Feb 2026 10:06:53 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Wed, 25 Feb 2026 10:06:52 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Wed, 25 Feb 2026 10:06:52 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61PF6Ynr006794; Wed, 25 Feb 2026 10:06:48 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v3 3/6] iio: frequency: admv1013: add dev variable and use dev_err_probe Date: Wed, 25 Feb 2026 17:05:49 +0200 Message-ID: <20260225150615.274078-4-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260225150615.274078-1-antoniu.miclaus@analog.com> References: <20260225150615.274078-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=Dcgaa/tW c=1 sm=1 tr=0 ts=699f100e cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=uXIjobp8t2wMuQ0fPvqm:22 a=gAnH3GRIAAAA:8 a=O8djgtFz8mmoGGuIiJcA:9 X-Proofpoint-GUID: oBB7CXPyGwX8x5VF6ITb5B3r1l3C_y3c X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI1MDE0NSBTYWx0ZWRfX+bDauF0e1DaR RGwNJxyHj86WjIlnxt52bg+4BPoeeUPOu8k/8ms1jY2pYHl3yK4fOxyP+rtE1qPJezAvOpe3LaQ 9hvzkr3kux20DXBGtwKvFIZW08mrGHcdwxy7ZDYmqn7V4Qjqsqu94Pk2W8k9KuIMKrGGnoFsSwd /NS4s99NCzQtV3vod1KnnEdhXWoc2DgVJ6TVLMQgVtdVffvFDqTpuTq/7nA3XhkqbDlSil13NKy fCycsQV4odthRbGfa/Omq2AVa5a9nlO7+c97BoETgWhtczIYwdVNAnCtJK3Tt8kwlrdTLcV/h4v 0Q3C7N4WC4dgE/GPDPA5EJW6dq6A7bOhmYlibL3dOR4vS7SrPS0CTy+C9l3T6ePG51T1b/BlppS gb6rtpEt3D8R1oHUIz7FVlAykWP8XAM4zmTzvaugfcz6wHnWmWwyXvoFf5yF+Cc+dkbdidm7TjN Dp+G7Eg7y1hNdJofDPA== X-Proofpoint-ORIG-GUID: oBB7CXPyGwX8x5VF6ITb5B3r1l3C_y3c X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_01,2026-02-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 priorityscore=1501 impostorscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602250145 Content-Type: text/plain; charset="utf-8" Introduce a struct device *dev local variable and replace dev_err() + return with dev_err_probe() in functions that use devm_ managed resources. This simplifies error handling and ensures proper logging of deferred probes. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/admv1013.c | 51 +++++++++++++++----------------- 1 file changed, 24 insertions(+), 27 deletions(-) diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1= 013.c index d8e8d541990f..514cf9f8eacb 100644 --- a/drivers/iio/frequency/admv1013.c +++ b/drivers/iio/frequency/admv1013.c @@ -441,7 +441,7 @@ static int admv1013_init(struct admv1013_state *st, int= vcm_uv) { int ret; unsigned int data; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; =20 /* Perform a software reset */ ret =3D __admv1013_spi_update_bits(st, ADMV1013_REG_SPI_CONTROL, @@ -461,10 +461,9 @@ static int admv1013_init(struct admv1013_state *st, in= t vcm_uv) return ret; =20 data =3D FIELD_GET(ADMV1013_CHIP_ID_MSK, data); - if (data !=3D ADMV1013_CHIP_ID) { - dev_err(&spi->dev, "Invalid Chip ID.\n"); - return -EINVAL; - } + if (data !=3D ADMV1013_CHIP_ID) + return dev_err_probe(dev, -EINVAL, + "Invalid Chip ID.\n"); =20 ret =3D __admv1013_spi_write(st, ADMV1013_REG_VVA_TEMP_COMP, 0xE700); if (ret) @@ -518,11 +517,11 @@ static int admv1013_properties_parse(struct admv1013_= state *st) { int ret; const char *str; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; =20 - st->det_en =3D device_property_read_bool(&spi->dev, "adi,detector-enable"= ); + st->det_en =3D device_property_read_bool(dev, "adi,detector-enable"); =20 - ret =3D device_property_read_string(&spi->dev, "adi,input-mode", &str); + ret =3D device_property_read_string(dev, "adi,input-mode", &str); if (ret) st->input_mode =3D ADMV1013_IQ_MODE; =20 @@ -533,7 +532,7 @@ static int admv1013_properties_parse(struct admv1013_st= ate *st) else return -EINVAL; =20 - ret =3D device_property_read_string(&spi->dev, "adi,quad-se-mode", &str); + ret =3D device_property_read_string(dev, "adi,quad-se-mode", &str); if (ret) st->quad_se_mode =3D ADMV1013_SE_MODE_DIFF; =20 @@ -546,14 +545,12 @@ static int admv1013_properties_parse(struct admv1013_= state *st) else return -EINVAL; =20 - ret =3D devm_regulator_bulk_get_enable(&st->spi->dev, + ret =3D devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(admv1013_vcc_regs), admv1013_vcc_regs); - if (ret) { - dev_err_probe(&spi->dev, ret, - "Failed to request VCC regulators\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to request VCC regulators\n"); =20 return 0; } @@ -562,9 +559,10 @@ static int admv1013_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct admv1013_state *st; + struct device *dev =3D &spi->dev; int ret, vcm_uv; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -581,36 +579,35 @@ static int admv1013_probe(struct spi_device *spi) if (ret) return ret; =20 - ret =3D devm_regulator_get_enable_read_voltage(&spi->dev, "vcm"); + ret =3D devm_regulator_get_enable_read_voltage(dev, "vcm"); if (ret < 0) - return dev_err_probe(&spi->dev, ret, + return dev_err_probe(dev, ret, "failed to get the common-mode voltage\n"); =20 vcm_uv =3D ret; =20 - st->clkin =3D devm_clk_get_enabled(&spi->dev, "lo_in"); + st->clkin =3D devm_clk_get_enabled(dev, "lo_in"); if (IS_ERR(st->clkin)) - return dev_err_probe(&spi->dev, PTR_ERR(st->clkin), + return dev_err_probe(dev, PTR_ERR(st->clkin), "failed to get the LO input clock\n"); =20 st->nb.notifier_call =3D admv1013_freq_change; - ret =3D devm_clk_notifier_register(&spi->dev, st->clkin, &st->nb); + ret =3D devm_clk_notifier_register(dev, st->clkin, &st->nb); if (ret) return ret; =20 mutex_init(&st->lock); =20 ret =3D admv1013_init(st, vcm_uv); - if (ret) { - dev_err(&spi->dev, "admv1013 init failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "admv1013 init failed\n"); =20 - ret =3D devm_add_action_or_reset(&spi->dev, admv1013_powerdown, st); + ret =3D devm_add_action_or_reset(dev, admv1013_powerdown, st); if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id admv1013_id[] =3D { --=20 2.43.0 From nobody Tue Apr 7 12:22:56 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 460B82765DF; Wed, 25 Feb 2026 15:07:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772032038; cv=none; b=EPH1QDzM3uD/I4Hp4NMvuJCyVXY1wJPF947mx0ksDqZyn0nr5YO2fTi44Cgab/oWu0vmEyVnGOPN9qIcmVvRrW7qPkbAbO9Rh/N975u04S3zwYBCym3L62x7NYvmGpQsZFVYI4j+tbRYJNy2TqN9H4yP67p+RT+OAsTNfeBMGZI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772032038; c=relaxed/simple; bh=muWTidDgZC9sIL7qemOOCo7YhSW6CaNju3U8ammyWOE=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kdVq1nxXQX41MTrFk6xFa0NyC27ziC9wf9CaC4LgIF/e5v5WosOdocNCp/WAIxafOJgNYhuz/w/Ruwcb7KjRoUHd6KFxWOwOOuxv37Tu2sWsKwSEuJpHqSuTOQIbXIBKeNJ7jygbLoZsmJ3KR7qWi3vH2bwQUD2ygp7fud+8f9I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=kLMxj7Sz; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="kLMxj7Sz" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61PAYBs11743439; Wed, 25 Feb 2026 10:06:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=HY/Y6 MCC31p81tbU6zX5VsnJe+qJaILepGq8elcs/Lo=; b=kLMxj7SzP5/HW4xuakfJx bJuqPyBCnR8r3d8Egz6zdhwnRnrf+pT49fjOVKcQzve41DTIowvFIXIuwKtDXorF lxDujHV4X2DObiTAiPkQEDSbTPYm+NNFmxBD8lU2gp5IuderV3WM3lb5n/4Xq7b9 ncJw/6ERm9ubNZzf3CXRRge+gKiZIYi1CGz734/oWUoKcrWcNN8t12m6PlcewdWJ 7R/gSFowvCESRlD8neGgmv2XyNJGJotN8tOwLcWr0bBzKYQxcWkSlfdLGECwqaZe fxYYJboYM+E/qK1b526aizK086Ip9HDNio/n+lyD1Fo4lKKz78LkBR1J51AFn99y Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cg7p4wa9f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Feb 2026 10:06:56 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61PF6tKL024656 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 25 Feb 2026 10:06:55 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Wed, 25 Feb 2026 10:06:55 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Wed, 25 Feb 2026 10:06:55 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61PF6Yns006794; Wed, 25 Feb 2026 10:06:51 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v3 4/6] iio: frequency: adf4377: add dev variable and use dev_err_probe Date: Wed, 25 Feb 2026 17:05:50 +0200 Message-ID: <20260225150615.274078-5-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260225150615.274078-1-antoniu.miclaus@analog.com> References: <20260225150615.274078-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI1MDE0NSBTYWx0ZWRfXyTxIIjVazScK xOIIbeTEOtvsU0X4On2RBl2Q9bdjc+SLcfOw6o27EhPdmZkapD5IlAs47l1m/55ZED2yIyPaEjB BOK323L8045Du32BawKbe2mt+T3gH++ZQny96+/ZeZOahAYExZGh+iEnevsC2SZwHGvEb/4gdPE G+UnGhdJf6YyK0Esn7NR/ngupfPyJQOYGUnWLleotJEIprHDK75HjjJI22hQleDkH7GFDwF6Tkj tt9wQ5o1/iDSwAPao1smujOnBdAIZ6UAKZ+9YPN2qfBIvb2rcbhwzuTOXB51UQt1G0wV7+czAjH J1uGQxlafibhJAyYdh40E1i2DVFOhbi2zHXNTF3c6Vaq9+7YRmVSEh/n5cSv+fBV4CInUOA4j6M NfWtoMGmEgnay5Cf9TO7BRDlIF61lFq1/FyGMzWTBUoUf8w0CgttXtNMKxXSF0uugW+xCoxrbAj PcG4KAeyzyPxxIqaMDg== X-Proofpoint-ORIG-GUID: Gf9ZHZKfoPtOwFwFa3od8LSJf_sW0t2y X-Authority-Analysis: v=2.4 cv=LfgxKzfi c=1 sm=1 tr=0 ts=699f1010 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=gAnH3GRIAAAA:8 a=bMEtPg1WnvWC4BS4PrsA:9 X-Proofpoint-GUID: Gf9ZHZKfoPtOwFwFa3od8LSJf_sW0t2y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_01,2026-02-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 spamscore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602250145 Content-Type: text/plain; charset="utf-8" Introduce a struct device *dev local variable and replace dev_err() + return with dev_err_probe() in functions that use devm_ managed resources. This simplifies error handling and ensures proper logging of deferred probes. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/adf4377.c | 57 ++++++++++++++++----------------- 1 file changed, 27 insertions(+), 30 deletions(-) diff --git a/drivers/iio/frequency/adf4377.c b/drivers/iio/frequency/adf437= 7.c index fa686f785fa4..cfc0c524c4a4 100644 --- a/drivers/iio/frequency/adf4377.c +++ b/drivers/iio/frequency/adf4377.c @@ -706,23 +706,21 @@ static void adf4377_gpio_init(struct adf4377_state *s= t) =20 static int adf4377_init(struct adf4377_state *st) { - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; int ret; =20 adf4377_gpio_init(st); =20 ret =3D adf4377_soft_reset(st); - if (ret) { - dev_err(&spi->dev, "Failed to soft reset.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to soft reset.\n"); =20 ret =3D regmap_multi_reg_write(st->regmap, adf4377_reg_defaults, ARRAY_SIZE(adf4377_reg_defaults)); - if (ret) { - dev_err(&spi->dev, "Failed to set default registers.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to set default registers.\n"); =20 ret =3D regmap_update_bits(st->regmap, 0x00, ADF4377_0000_SDO_ACTIVE_MSK | ADF4377_0000_SDO_ACTIVE_R_MSK, @@ -730,10 +728,9 @@ static int adf4377_init(struct adf4377_state *st) ADF4377_0000_SDO_ACTIVE_SPI_4W) | FIELD_PREP(ADF4377_0000_SDO_ACTIVE_R_MSK, ADF4377_0000_SDO_ACTIVE_SPI_4W)); - if (ret) { - dev_err(&spi->dev, "Failed to set 4-Wire Operation.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to set 4-Wire Operation.\n"); =20 st->clkin_freq =3D clk_get_rate(st->clkin); =20 @@ -747,10 +744,9 @@ static int adf4377_init(struct adf4377_state *st) FIELD_PREP(ADF4377_001A_PD_PFDCP_MSK, 0) | FIELD_PREP(ADF4377_001A_PD_CLKOUT1_MSK, 0) | FIELD_PREP(ADF4377_001A_PD_CLKOUT2_MSK, 0)); - if (ret) { - dev_err(&spi->dev, "Failed to set power down registers.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to set power down registers.\n"); =20 /* Set Mux Output */ ret =3D regmap_update_bits(st->regmap, 0x1D, @@ -882,35 +878,35 @@ static const struct iio_chan_spec adf4377_channels[] = =3D { =20 static int adf4377_properties_parse(struct adf4377_state *st) { - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; int ret; =20 - st->clkin =3D devm_clk_get_enabled(&spi->dev, "ref_in"); + st->clkin =3D devm_clk_get_enabled(dev, "ref_in"); if (IS_ERR(st->clkin)) - return dev_err_probe(&spi->dev, PTR_ERR(st->clkin), + return dev_err_probe(dev, PTR_ERR(st->clkin), "failed to get the reference input clock\n"); =20 - st->gpio_ce =3D devm_gpiod_get_optional(&st->spi->dev, "chip-enable", + st->gpio_ce =3D devm_gpiod_get_optional(dev, "chip-enable", GPIOD_OUT_LOW); if (IS_ERR(st->gpio_ce)) - return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_ce), + return dev_err_probe(dev, PTR_ERR(st->gpio_ce), "failed to get the CE GPIO\n"); =20 - st->gpio_enclk1 =3D devm_gpiod_get_optional(&st->spi->dev, "clk1-enable", + st->gpio_enclk1 =3D devm_gpiod_get_optional(dev, "clk1-enable", GPIOD_OUT_LOW); if (IS_ERR(st->gpio_enclk1)) - return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_enclk1), + return dev_err_probe(dev, PTR_ERR(st->gpio_enclk1), "failed to get the CE GPIO\n"); =20 if (st->chip_info->has_gpio_enclk2) { - st->gpio_enclk2 =3D devm_gpiod_get_optional(&st->spi->dev, "clk2-enable", + st->gpio_enclk2 =3D devm_gpiod_get_optional(dev, "clk2-enable", GPIOD_OUT_LOW); if (IS_ERR(st->gpio_enclk2)) - return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_enclk2), + return dev_err_probe(dev, PTR_ERR(st->gpio_enclk2), "failed to get the CE GPIO\n"); } =20 - ret =3D device_property_match_property_string(&spi->dev, "adi,muxout-sele= ct", + ret =3D device_property_match_property_string(dev, "adi,muxout-select", adf4377_muxout_modes, ARRAY_SIZE(adf4377_muxout_modes)); if (ret >=3D 0) @@ -1055,9 +1051,10 @@ static int adf4377_probe(struct spi_device *spi) struct iio_dev *indio_dev; struct regmap *regmap; struct adf4377_state *st; + struct device *dev =3D &spi->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -1080,7 +1077,7 @@ static int adf4377_probe(struct spi_device *spi) return ret; =20 st->nb.notifier_call =3D adf4377_freq_change; - ret =3D devm_clk_notifier_register(&spi->dev, st->clkin, &st->nb); + ret =3D devm_clk_notifier_register(dev, st->clkin, &st->nb); if (ret) return ret; =20 @@ -1097,7 +1094,7 @@ static int adf4377_probe(struct spi_device *spi) indio_dev->num_channels =3D ARRAY_SIZE(adf4377_channels); } =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id adf4377_id[] =3D { --=20 2.43.0 From nobody Tue Apr 7 12:22:56 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 618863D3D1D; Wed, 25 Feb 2026 15:07:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772032036; cv=none; b=bTUkEdsGKuVTKpW4m526J1OUPslggmIX/846X+NtZDsQblfi2LVmtPJ7rzpSjfcFswPNhTiFONEi+0Al3aPyZoJ3PynUYM23J0WFFei3alJZMbzyr3BCMKugigOjUSlByYwM/aaDvJpz9042+WpCmT/xknD5rRmw/Q481MF3OqM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772032036; c=relaxed/simple; bh=KRDNRb2BAHdXtY0aDAMnW8b/HaBxSBxAG/fC1JMttKk=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=doC3bm9lKyYKMTcHg961ru9LuTXrO4YbZwfUGsirJHIdMXK5hKnHWU6ityHcj2JStstCp05oQnqwApVbnBdcqSTd4bpw7ZR6kndrTneO45yCVa6tjJrZl1AgFSRVwIx3ISb9TwB7BxSzzzJN6BClYQiEwQwOOBDm/ufKoECavXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=BWBvRr1h; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="BWBvRr1h" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61PDbllg1869414; Wed, 25 Feb 2026 10:07:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=5u/z2 X2L+n4xOsvqMLSOQ/NAvDV17Wr6dYVILyZ10kU=; b=BWBvRr1hXABxRadUnmYeQ 9B15AsCxL6myu1YN0gV9CPlNdUJxWyPb3597HpWcSKci6Giu/aucAjs0QeCZJ4M9 iXjI3H9eUpFO3cOJV/3tiySX9xLnRlBodlqyrPc+EL+SyShrVH/VVrTqs43NGoBS QfFbBNvJFU6LmcClpsR2FrWGZxVVqV9Af34diFonnHUgBd4KyEZpZPR8WdNBYnZ7 +xuBh9v67NjiZTo3D+GmqHZCcJPsSxFJHOLeauijiNtiRX1Aw9JOiQPeFXIsN+em 8PSS+OlwxlsmRf44fXGs00MnvHuNQ/10C17mVjJhCGe8/hEIb8Um4TPxrGmrVqYT A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4chvwg1gjc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Feb 2026 10:06:59 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61PF6wdq024663 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 25 Feb 2026 10:06:58 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Wed, 25 Feb 2026 10:06:58 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Wed, 25 Feb 2026 10:06:58 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61PF6Ynt006794; Wed, 25 Feb 2026 10:06:54 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v3 5/6] iio: dac: ad7293: add dev variable and use dev_err_probe Date: Wed, 25 Feb 2026 17:05:51 +0200 Message-ID: <20260225150615.274078-6-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260225150615.274078-1-antoniu.miclaus@analog.com> References: <20260225150615.274078-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=Dcgaa/tW c=1 sm=1 tr=0 ts=699f1013 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=uXIjobp8t2wMuQ0fPvqm:22 a=gAnH3GRIAAAA:8 a=BWbAnXfCx2Sueti_qTsA:9 X-Proofpoint-GUID: pLdgnEeI89VbP8rSix6R1EYEXnPzeYcO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI1MDE0NSBTYWx0ZWRfX/XM20VjPW9VH JtslpJDH98PkI6qXYwz3fbc94g6YojurHwAb/++KKKixoIX7yu7ilCbykljSHKADFDd9HDO0EyU 6QFC2ba83zBU8ExKe7VBTrP8ChAOmUpM2ztp2ZBkGXxwjoFKH9ylZtsJLvDglOONE18ydyNpoi5 PeK15bar0DW06klRjoJrk5PLodN37wnYNPr6xE45DoB1VdEvVJb3euSu3VwkRg0nTeJYUomEQp9 gO2BlBW9fU0xsvpBq1MGJsp7mimOYrfAe8H2omwc7aMaWBDP174fcLXB8ex3hrn37+ZHR27E/C5 WUfDa72PlA2JUqxZVMsDYWRADddnRqxz3XuhXtP/Sc1eZ3lSep1xlE8HgkSAaSN+LNReh8lCZi4 mUHCSW7tO/d0wP2AyaCHMi09hUZFTYnOyt249eBl5h6uv37uIIFmreQMYaU8wnBZq8s5Gz0lFhJ zWHB8OdXfRXURYh5+vg== X-Proofpoint-ORIG-GUID: pLdgnEeI89VbP8rSix6R1EYEXnPzeYcO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_01,2026-02-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 priorityscore=1501 impostorscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602250145 Content-Type: text/plain; charset="utf-8" Introduce a struct device *dev local variable and replace dev_err() + return with dev_err_probe() in functions that use devm_ managed resources. This simplifies error handling and ensures proper logging of deferred probes. Signed-off-by: Antoniu Miclaus --- drivers/iio/dac/ad7293.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/iio/dac/ad7293.c b/drivers/iio/dac/ad7293.c index c3797e40cdd9..e26cc36e9270 100644 --- a/drivers/iio/dac/ad7293.c +++ b/drivers/iio/dac/ad7293.c @@ -776,27 +776,27 @@ static int ad7293_reset(struct ad7293_state *st) =20 static int ad7293_properties_parse(struct ad7293_state *st) { - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; int ret; =20 - ret =3D devm_regulator_get_enable(&spi->dev, "avdd"); + ret =3D devm_regulator_get_enable(dev, "avdd"); if (ret) - return dev_err_probe(&spi->dev, ret, "failed to enable AVDD\n"); + return dev_err_probe(dev, ret, "failed to enable AVDD\n"); =20 - ret =3D devm_regulator_get_enable(&spi->dev, "vdrive"); + ret =3D devm_regulator_get_enable(dev, "vdrive"); if (ret) - return dev_err_probe(&spi->dev, ret, "failed to enable VDRIVE\n"); + return dev_err_probe(dev, ret, "failed to enable VDRIVE\n"); =20 - ret =3D devm_regulator_get_enable_optional(&spi->dev, "vrefin"); + ret =3D devm_regulator_get_enable_optional(dev, "vrefin"); if (ret < 0 && ret !=3D -ENODEV) - return dev_err_probe(&spi->dev, ret, "failed to enable VREFIN\n"); + return dev_err_probe(dev, ret, "failed to enable VREFIN\n"); =20 st->vrefin_en =3D ret !=3D -ENODEV; =20 - st->gpio_reset =3D devm_gpiod_get_optional(&st->spi->dev, "reset", + st->gpio_reset =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(st->gpio_reset)) - return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_reset), + return dev_err_probe(dev, PTR_ERR(st->gpio_reset), "failed to get the reset GPIO\n"); =20 return 0; @@ -806,7 +806,7 @@ static int ad7293_init(struct ad7293_state *st) { int ret; u16 chip_id; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; =20 ret =3D ad7293_properties_parse(st); if (ret) @@ -821,10 +821,9 @@ static int ad7293_init(struct ad7293_state *st) if (ret) return ret; =20 - if (chip_id !=3D AD7293_CHIP_ID) { - dev_err(&spi->dev, "Invalid Chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D AD7293_CHIP_ID) + return dev_err_probe(dev, -EINVAL, + "Invalid Chip ID.\n"); =20 if (!st->vrefin_en) return __ad7293_spi_update_bits(st, AD7293_REG_GENERAL, @@ -845,9 +844,10 @@ static int ad7293_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct ad7293_state *st; + struct device *dev =3D &spi->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -867,7 +867,7 @@ static int ad7293_probe(struct spi_device *spi) if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id ad7293_id[] =3D { --=20 2.43.0 From nobody Tue Apr 7 12:22:56 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8227F3D6483; Wed, 25 Feb 2026 15:07:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772032040; cv=none; b=Qb7Fi63AS2CRH8fpfMUOiHyjguBPiD/JUhc1DkG/aBd5tP7LIgl11XvmtbNuhRHa8lTj+HNfIqLC+CwP0RbqwLQu7/Xboe0f5SYm69Od0OFNrq6KSql9HllSMin84ieJ+uS0Yui+Y+3Pc6Hu0L2hmn1jTY1cFx0rtVTpsmCvAXc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772032040; c=relaxed/simple; bh=cs5pJiU5q3s9zOlQcOh/aWtHbo+8avXU6Qjt1rfHXdI=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=A55y72Rs6nH9Dqr+Mg63PfBz42LHm4ue9h9EZ7oChIopiOeYA/V0pfVs+DiBXImm/4sPquFzz0wPS5qYzE5ciqoTgCOPI4Tk63jqEVao9WwLYlA8LA1vSKP13pOFBD/IZuASquZKhUHxeH93UURx/isrr7Sj2m2BXcXRYl6ugUA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=r5Qkb0em; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="r5Qkb0em" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61PD2KpC1743183; Wed, 25 Feb 2026 10:07:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=y2xcN WnE2Z1j/e5V2J6AOlQ1whJL/c9R1EDYSbBLEl4=; b=r5Qkb0emr7INcnM1szKXS 7V3CtM/Atu4wYgSYYV+fii1d4THXPFO0wdG6sD/kK7V/jXd+wDFoB/XmQlvNZMMv 7cp/TlliihpluYSxisrsioVTZ+ux9JDl6CyXK+0OT1MN+z5YD3UJKXUdd5Apf2bH RMXMp7yXP2QkIrC/9bh0o+LbgB1x+AO8/JOm7ID92Aa8HfOsgD3/7yJeMzwwxQjV 9Qi6LzIboHAvOfb4O6zLhqZmR8K/i4q5wkeIY1VuOzV7ka96Yi9tpWQrc2Es+ktl jvxVxolYHZqFNsoRWNWleAom6/836Qg/oFlyPAV/3Vmd/XbLN3n3bcUGrSSkdpIb w== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cg7p4wa9q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Feb 2026 10:07:01 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61PF70NZ024681 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 25 Feb 2026 10:07:00 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Wed, 25 Feb 2026 10:07:00 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Wed, 25 Feb 2026 10:07:00 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61PF6Ynu006794; Wed, 25 Feb 2026 10:06:57 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH v3 6/6] iio: filter: admv8818: add dev variable and use dev_err_probe Date: Wed, 25 Feb 2026 17:05:52 +0200 Message-ID: <20260225150615.274078-7-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260225150615.274078-1-antoniu.miclaus@analog.com> References: <20260225150615.274078-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI1MDE0NSBTYWx0ZWRfXwOGK8bwpo14k kd5oQRTbsYTPXbIp609550QyOjCks/Or7YOUWeaTZYwkOwi8Wu7szgJy05oFv0o2KYMr/VDk5Gq 8gbVuxAkJFsm5d7Wz3TGeTkjz7bfwBe5yT01txkTdqTytoQ/dORr5M+ldM0gxRJNPNMcpusGIzm Y2dVVkvrm4mRLu/aMe5j+Him1qEZL9lflgHssGCXSEjeoUGFENG4MfbnS6voFFYiofDud5vFnWq 00Noia84+ccNowKPRGJD54VxmLNfkbx0AQYoykMvgL2gP857CswaXSCkUMgZBK37BSWDy4hHgGV l6yvd4AVHSS4UY23HkJPclkI84uUhAVfvhWQU1yRZsAqXuhK5npsYFW2O4DOM3uWef1PzwBfaGN ++8jjm18XWxEdp9cHuHNVTCzORgmtiIxLhcGkWhIX1UGR/JAy2QtuvcWqpocgQY18lohzCAo4+G nXFJEmWdEy3OWN0tcyg== X-Proofpoint-ORIG-GUID: 706xqVMYizuji3sczWnkxQLMmmdkQ0Ti X-Authority-Analysis: v=2.4 cv=LfgxKzfi c=1 sm=1 tr=0 ts=699f1016 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=gAnH3GRIAAAA:8 a=O8djgtFz8mmoGGuIiJcA:9 X-Proofpoint-GUID: 706xqVMYizuji3sczWnkxQLMmmdkQ0Ti X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_01,2026-02-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 spamscore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602250145 Content-Type: text/plain; charset="utf-8" Introduce a struct device *dev local variable and replace dev_err() + return with dev_err_probe() in functions that use devm_ managed resources. This simplifies error handling and ensures proper logging of deferred probes. Signed-off-by: Antoniu Miclaus --- drivers/iio/filter/admv8818.c | 61 +++++++++++++++++------------------ 1 file changed, 29 insertions(+), 32 deletions(-) diff --git a/drivers/iio/filter/admv8818.c b/drivers/iio/filter/admv8818.c index 19f823446cda..a4c127d12882 100644 --- a/drivers/iio/filter/admv8818.c +++ b/drivers/iio/filter/admv8818.c @@ -657,41 +657,36 @@ static void admv8818_clk_disable(void *data) static int admv8818_init(struct admv8818_state *st) { int ret; - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; unsigned int chip_id; =20 ret =3D regmap_write(st->regmap, ADMV8818_REG_SPI_CONFIG_A, ADMV8818_SOFTRESET_N_MSK | ADMV8818_SOFTRESET_MSK); - if (ret) { - dev_err(&spi->dev, "ADMV8818 Soft Reset failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADMV8818 Soft Reset failed.\n"); =20 ret =3D regmap_write(st->regmap, ADMV8818_REG_SPI_CONFIG_A, ADMV8818_SDOACTIVE_N_MSK | ADMV8818_SDOACTIVE_MSK); - if (ret) { - dev_err(&spi->dev, "ADMV8818 SDO Enable failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADMV8818 SDO Enable failed.\n"); =20 ret =3D regmap_read(st->regmap, ADMV8818_REG_CHIPTYPE, &chip_id); - if (ret) { - dev_err(&spi->dev, "ADMV8818 Chip ID read failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADMV8818 Chip ID read failed.\n"); =20 - if (chip_id !=3D 0x1) { - dev_err(&spi->dev, "ADMV8818 Invalid Chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D 0x1) + return dev_err_probe(dev, -EINVAL, + "ADMV8818 Invalid Chip ID.\n"); =20 ret =3D regmap_update_bits(st->regmap, ADMV8818_REG_SPI_CONFIG_B, ADMV8818_SINGLE_INSTRUCTION_MSK, FIELD_PREP(ADMV8818_SINGLE_INSTRUCTION_MSK, 1)); - if (ret) { - dev_err(&spi->dev, "ADMV8818 Single Instruction failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "ADMV8818 Single Instruction failed.\n"); =20 if (st->clkin) return admv8818_rfin_band_select(st); @@ -701,12 +696,12 @@ static int admv8818_init(struct admv8818_state *st) =20 static int admv8818_clk_setup(struct admv8818_state *st) { - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; int ret; =20 - st->clkin =3D devm_clk_get_optional(&spi->dev, "rf_in"); + st->clkin =3D devm_clk_get_optional(dev, "rf_in"); if (IS_ERR(st->clkin)) - return dev_err_probe(&spi->dev, PTR_ERR(st->clkin), + return dev_err_probe(dev, PTR_ERR(st->clkin), "failed to get the input clock\n"); else if (!st->clkin) return 0; @@ -715,7 +710,7 @@ static int admv8818_clk_setup(struct admv8818_state *st) if (ret) return ret; =20 - ret =3D devm_add_action_or_reset(&spi->dev, admv8818_clk_disable, st); + ret =3D devm_add_action_or_reset(dev, admv8818_clk_disable, st); if (ret) return ret; =20 @@ -724,16 +719,16 @@ static int admv8818_clk_setup(struct admv8818_state *= st) if (ret < 0) return ret; =20 - return devm_add_action_or_reset(&spi->dev, admv8818_clk_notifier_unreg, s= t); + return devm_add_action_or_reset(dev, admv8818_clk_notifier_unreg, st); } =20 static int admv8818_read_properties(struct admv8818_state *st) { - struct spi_device *spi =3D st->spi; + struct device *dev =3D &st->spi->dev; u32 mhz; int ret; =20 - ret =3D device_property_read_u32(&spi->dev, "adi,lpf-margin-mhz", &mhz); + ret =3D device_property_read_u32(dev, "adi,lpf-margin-mhz", &mhz); if (ret =3D=3D 0) st->lpf_margin_hz =3D (u64)mhz * HZ_PER_MHZ; else if (ret =3D=3D -EINVAL) @@ -742,7 +737,7 @@ static int admv8818_read_properties(struct admv8818_sta= te *st) return ret; =20 =20 - ret =3D device_property_read_u32(&spi->dev, "adi,hpf-margin-mhz", &mhz); + ret =3D device_property_read_u32(dev, "adi,hpf-margin-mhz", &mhz); if (ret =3D=3D 0) st->hpf_margin_hz =3D (u64)mhz * HZ_PER_MHZ; else if (ret =3D=3D -EINVAL) @@ -758,15 +753,17 @@ static int admv8818_probe(struct spi_device *spi) struct iio_dev *indio_dev; struct regmap *regmap; struct admv8818_state *st; + struct device *dev =3D &spi->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 regmap =3D devm_regmap_init_spi(spi, &admv8818_regmap_config); if (IS_ERR(regmap)) - return PTR_ERR(regmap); + return dev_err_probe(dev, PTR_ERR(regmap), + "Failed to initialize regmap\n"); =20 st =3D iio_priv(indio_dev); st->regmap =3D regmap; @@ -792,7 +789,7 @@ static int admv8818_probe(struct spi_device *spi) if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id admv8818_id[] =3D { --=20 2.43.0