From nobody Tue Apr 7 12:38:51 2026 Received: from smtpbg150.qq.com (smtpbg150.qq.com [18.132.163.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C55983203A0 for ; Wed, 25 Feb 2026 14:53:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.132.163.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772031206; cv=none; b=tSr1+3oYhKFFjxRAe96FyLmcuD+Vf/sRDv+YiYsllS4KhgrUaI8L3NJZZg7K1w55ngcEJC0Q+2AJv+Ap2/u0JCKygz0dNkUMneaymy/jmpsTTTN/+SuoFdeto5pWYKQFOGMxiK9KJbCYSnTCH5LlkzHgGPxiXPaKR2ATA/ZM7Y8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772031206; c=relaxed/simple; bh=opwUYNH38scw+UmNhElFi9TNwz9MwggV9L7fvYqLQrM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nfJw22bWYCPZuAf5Nb2ngajt7ZApkITz2S/818PKWT1pUyrDS23ACgXK6s/jbuApptZxxcObO753z3FSjPI4tPISTZSdzlIIghswDruQ4SS1/7IxRAuU1rQMTrtgeocv8oA4zQ0RiaFmHJhtFtkSuvkdXPCuR8hgGuBZFEiw06s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=smail.nju.edu.cn; spf=pass smtp.mailfrom=smail.nju.edu.cn; dkim=pass (1024-bit key) header.d=smail.nju.edu.cn header.i=@smail.nju.edu.cn header.b=5cteETRY; arc=none smtp.client-ip=18.132.163.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=smail.nju.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=smail.nju.edu.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=smail.nju.edu.cn header.i=@smail.nju.edu.cn header.b="5cteETRY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smail.nju.edu.cn; s=iohv2404; t=1772031125; bh=EaLjfNINaEIan7dIiuFrul+vjYsQXQhbKE6yTcVjiKY=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=5cteETRYoZ8LW7MRowGrc2v8Cr0TLuyyinA+gBixzAaoZRVDVdt9OxTW4qecVQVoV zGQPPsOgRj/aaVA4jSoVPLW0YXXQYyLiXYztXuxxDAmp+cTRymt2+D9ItpU1hbcLy8 Yrztvna1rUh4leURQnYacxGtE9UcJpl+llQLedT8= X-QQ-mid: zesmtpgz3t1772031124t812d4778 X-QQ-Originating-IP: 9cUJV9iOSMYlGSDt0yiEffx30v+BwPEEEuERR4z3tzc= Received: from localhost.localdomain ( [116.172.93.199]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 25 Feb 2026 22:52:02 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 9594701865739000727 EX-QQ-RecipientCnt: 12 From: Kexin Sun To: davem@davemloft.net Cc: edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, julia.lawall@inria.fr, xutong.ma@inria.fr, yunbolyu@smu.edu.sg, ratnadiraw@smu.edu.sg, Kexin Sun Subject: [PATCH net-next v2] net/hsr: update outdated comments Date: Wed, 25 Feb 2026 22:51:59 +0800 Message-Id: <20260225145159.2953-1-kexinsun@smail.nju.edu.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpgz:smail.nju.edu.cn:qybglogicsvrgz:qybglogicsvrgz5b-0 X-QQ-XMAILINFO: Mq15iU9R3yoVaCNg60ILAU8T/LNhoHWxUyJWjkVupFrRi7wFzbznunhG 5VYzW6vwpvijR+yOpEOLPMjfn7xB/cn69EZeDjL0GDwfYFykgNy1UZZaDRThqzKL72+85Lg G+0Rw2PclmLlhB6E8+P5iGlfqKtdlRGP1FcmNofwF4wa2lWVsqEQrKToy6+gAlbljxwniKC JiSyH6wKQ4SsQm809ENt8NEchNbC2Nx80yXjahDT8x4/kHfXJ9qkibd74m7hzZT4nNy0d7s /8FSe1yBrkJIADTc8Dau4q5+84HvqbkDnHDAVD8hqoTrXYjFBrrqDpv6jse6bMULRdWYuZj X5lZLMbPz0mtc0NrFBqzAiWPpDpnEE8TG9Mz80caYIAjy/DGsBzRfWjXza6V+fEnMNSwbeo UaWTctI9iEoLhCAEZlbFsFH/BQKlUcAyAzHLpwpBTg/utcv+9MP2mJBqtqBm17DhW+kgFeE R90tyOX+lJ5UQ9WuGvzgDc9eVnpT5dh8DibFhQSV/Xmr0fkgcJmI3Diy05opq9kuKy6gzoY kEUABP88BWx6zABAgqfzK4SmTTDHv+6UoOPaJ7kF46U6XL+4XZO98AUhnNXrvEdewHk8SYF CKTlmQ6iuzTG+oVQQjH8nakLIyXy/0S1e7F7QwNQ6FPeBVhIUTrkmuwWlt9SJDd1DUFpOR2 fBDsnIizqtSJmkiii7WFhBanS1YXfvcxWKsexzkNI5WOysvU5wbove9jrG06kCexcmUhi6+ 2H6snKS1Z23U6h2oVUYZ+TcBw9QG+BaTU3jgRPe+fxZCtZt9Sn2pLjock6KRrrIS+l2osOz Sta79aTVSChqfH9JUPK4rfHuFoOcbvDgO8lURsytk68Vt3QfcfwlYVU50joouQYDupDOoo8 U1aDGlmo7YR9T4BBdgtgU/iBsyLCm4qAVmrgSkaZ8RSCHiVX1Ioh2+v6dENZsVb2icIfhv7 VdpNWRxvDfO8EzlFr28ycKRQgl5YZ7EXYIc34YfYzOu2n/7cA6eG5tzvLKVBKyakp/ROSQM FzX7IJ3itpLubTVerwx+QELkEgdrjZr1urIlngnMH/IhRe3RM2MptJfG24u0/SZjnthdQZV tBfMpJHbXmTsnCB7g9JvZq8s9pzLz8vqfP3lKEy1hH7 X-QQ-XMRINFO: OWPUhxQsoeAVwkVaQIEGSKwwgKCxK/fD5g== X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" The function hsr_rcv() was renamed hsr_handle_frame() and moved to net/hsr/hsr_slave.c by commit 81ba6afd6e64 ("net/hsr: Switch from dev_add_pack() to netdev_rx_handler_register()"). Update all remaining references in the comments accordingly. Signed-off-by: Kexin Sun Reviewed-by: Simon Horman --- Hi Simon, Regarding your question about how these were found: we are building a=20 research prototype for identifying and fixing dangling method references=20 in comments. Generally, we use Coccinelle to check for dangling references=20 and DeepSeek-V3.2 to generate the fixes.=20 Since it is still a work-in-progress, we haven't settled on a proper tool=20 name yet. Therefore, I chose to omit the `Assisted-by:` tag in this v2=20 patch for now. Do you have any suggestions on what would be appropriate=20 to use in this situation? net/hsr/hsr_device.c | 2 +- net/hsr/hsr_framereg.c | 4 ++-- net/hsr/hsr_main.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c index d1bfc49b5f01..5c3eca2235ce 100644 --- a/net/hsr/hsr_device.c +++ b/net/hsr/hsr_device.c @@ -742,7 +742,7 @@ int hsr_dev_finalize(struct net_device *hsr_dev, struct= net_device *slave[2], hsr->proto_ops =3D &hsr_ops; } =20 - /* Make sure we recognize frames from ourselves in hsr_rcv() */ + /* Make sure we recognize frames from ourselves in hsr_handle_frame() */ res =3D hsr_create_self_node(hsr, hsr_dev->dev_addr, slave[1]->dev_addr); if (res < 0) diff --git a/net/hsr/hsr_framereg.c b/net/hsr/hsr_framereg.c index 50996f4de7f9..577fb588bc2f 100644 --- a/net/hsr/hsr_framereg.c +++ b/net/hsr/hsr_framereg.c @@ -71,8 +71,8 @@ bool hsr_is_node_in_db(struct list_head *node_db, return !!find_node_by_addr_A(node_db, addr); } =20 -/* Helper for device init; the self_node is used in hsr_rcv() to recognize - * frames from self that's been looped over the HSR ring. +/* Helper for device init; the self_node is used in hsr_handle_frame() to + * recognize frames from self that's been looped over the HSR ring. */ int hsr_create_self_node(struct hsr_priv *hsr, const unsigned char addr_a[ETH_ALEN], diff --git a/net/hsr/hsr_main.c b/net/hsr/hsr_main.c index bc94b07101d8..33951d9bd3c5 100644 --- a/net/hsr/hsr_main.c +++ b/net/hsr/hsr_main.c @@ -89,7 +89,7 @@ static int hsr_netdev_notify(struct notifier_block *nb, u= nsigned long event, } } =20 - /* Make sure we recognize frames from ourselves in hsr_rcv() */ + /* Make sure we recognize frames from ourselves in hsr_handle_frame() */ port =3D hsr_port_get_hsr(hsr, HSR_PT_SLAVE_B); res =3D hsr_create_self_node(hsr, master->dev->dev_addr, --=20 2.25.1