From nobody Tue Apr 7 12:22:56 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F2133B8D48 for ; Wed, 25 Feb 2026 13:28:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772026096; cv=none; b=KVbqRy5J18Tufd7J1Bk3vqdpspzfoP/Hrs6xNNraZh5ZiTwZjBt2Emyt+i27eS/73QS2OZLvLH2ojANejfIedZmm4xapodwQTxcw4kO9linhsvZnToOepYiGN/xyO4nWaMwc9NulDeXY6+hVNYyCXNJ6teWqwrXmJ+hPw6qUHcw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772026096; c=relaxed/simple; bh=xRRjy3veOaCbWL+KPQCuz6nqQMwyYwm747YQfaGDlEw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=heFBrxhGACVCaqF5Yz2r1niLPQLEMg7MtgKSfP29Vg9pp5P1Muj6kmXVqA+XONnPO6Tj6WjXLXxGs4xiwmW835jWBZVv/JChAMVuNHECczU85CMcxW52SUj74p6A0RGilUm4/LeLdLIRAS5MZcni3V/2Ma+dKirchJWMdJ0RK7g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OZRRRZp2; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OZRRRZp2" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ab46931cf1so5746105ad.0 for ; Wed, 25 Feb 2026 05:28:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772026094; x=1772630894; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=X4gY9ENXOOQCpnDpsjGMdFNmPdFyocZAizDByCQ4qGg=; b=OZRRRZp2gFfzT7yi/jgdGgT4gJXmqsHJfdzQ/QqCXhvup5f/XYROVpVWfZWUfSJFPh 3f1I3ZFIt1aW7GY+eaWIw2tUUe3CG1+OJIMA+Iewp5NuaIBf69cES+fNv7CnNIpy1jYl EpYRXW1XIP1PRTUpi2YCSa3kaxyAuyL40OaNld8kY4ao2oe1KG3maDQbVrw85eDcVZCk uQTTG5vjXBq0vLCHxslz6vi5oLQqp4Rya7X3zrEnx52wMKbs1iKepM9UY4ad093II50Q I0D95KJg/eIModQZwDhgnD+LenZwrUe+35XnDzTgabaDYQgO6bfFNwP2dPHOnEEXhNMK 8VsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772026094; x=1772630894; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X4gY9ENXOOQCpnDpsjGMdFNmPdFyocZAizDByCQ4qGg=; b=eS/kwDAc0fcW9BAFn9iL0pBB0qoOtOxRSnAMws9787hjQZKGTc7aVuaaam3QOMZvLd 2E9PQKaztWHpAdW8BpTkt7523yiseSqqZ+ObqhZ/azeXwXl9LjumbHGrTf3Nj+gosb0s IEL/PUEo5s7lD2siZuOmlS4tHhYy8TWGs/LAyOimFSd1Py9qjPfjxZxG40/iCyCIoiRL qcHThXxb6zf8PjNOYI0Vl7gfo98XDyP2GI0HsuqX/L7geXKBwTVba25MmTdIKZ26OaVv hTj8hQg5PhKUFuiehNHU1LUdaYuPgvvPkBhXJawf0ok9dh/g+9HL1ItU965TStuGJF0F q2dg== X-Forwarded-Encrypted: i=1; AJvYcCX1bf5EJuRcg2HvgzYPzJRLP2ueMKV0776DktB1gA02kMVaWK2fHcLpzuocCtJwjE+8+pYw9KWxUoF1T4A=@vger.kernel.org X-Gm-Message-State: AOJu0YwPd6LORWBQ+TMxe0gNE5rb2PWQz3PVRoPkw1Vvk+ON/qnqxBKP 49FQJqahug1b9WtZtxlHoJE5KHHCfoBF26qjrZ6XKBLzw2rLTIdUoNCR32IzW3gl X-Gm-Gg: ATEYQzzevitYHF9tofGMAfP3GtjJV6Fs8pjy7QNARpvpfOQEIgOUgHXSh0VIbguMqxk +pQPbuUbq5CHmBGu+rEY0w/OUHEqyYNzg9rAIpKNiGrkUEvkxY0ipMHRWYzc9J450fIUNeGG5b3 w4K8S5O9JfH3EKEvX8DT3EBYECrCfNI8MOzeFpfxy6eGqxzR/5We9dW3b1sge0/7xKdcXc/Y+gt SHFS+uvQKVm7F6XjJdufcZdwhMPx1SonVt18yMW6vrP74GAhvRRXqKocMuhZAN928BbWZ9GS9gl U4cuKpXYUfT/MzeCQAa4Xj/2dOlT0KExKg3JsJH3paS37Fdg/3j38fNQcggcNswhAr7Lzcgw2cm oav9CPQfsicIuOBY8Zirc0yra+2YMF5hpuuPceAvNHmrXQ4R05xORmmUMScSuEjRzzHfcidQPsp s5NiXthQmDUbzIIfC0zV80mn6P X-Received: by 2002:a17:902:e5c8:b0:2a0:c92e:a378 with SMTP id d9443c01a7336-2adbdc6b962mr38059985ad.7.1772026093769; Wed, 25 Feb 2026 05:28:13 -0800 (PST) Received: from lgs.. ([36.255.193.30]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad75052e9asm142759875ad.88.2026.02.25.05.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 05:28:13 -0800 (PST) From: Guangshuo Li To: Greg Kroah-Hartman , Yaxing Guo , linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] uio: uio_pci_generic_sva: fix double free of devm_kzalloc() memory Date: Wed, 25 Feb 2026 21:27:36 +0800 Message-ID: <20260225132737.4176605-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" uio_pci_sva allocates struct uio_pci_sva_dev with devm_kzalloc() in probe()= , but then calls kfree(udev) both on the probe() error path (label out_free= ) and again in remove(). Because devm_kzalloc() allocations are devres-managed and are freed automat= ically when the device is detached, which also happens after a failing prob= e() and during driver unbind, the explicit kfree() can result in a double f= ree. If probe() fails after devm_kzalloc(), the error path kfree(udev) free= s the object, and devres cleanup will free it again when the core unwinds t= he partially bound device. On normal driver removal, remove() explicitly fr= ees udev, and devres will free it again when the device is detached. Fix by removing the manual kfree() calls and dropping the now-unused label. Fixes: 3397c3cd859a2 ("uio: Add SVA support for PCI devices via uio_pci_gen= eric_sva.c") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/uio/uio_pci_generic_sva.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/uio/uio_pci_generic_sva.c b/drivers/uio/uio_pci_generi= c_sva.c index 4a46acd994a8..152201047334 100644 --- a/drivers/uio/uio_pci_generic_sva.c +++ b/drivers/uio/uio_pci_generic_sva.c @@ -129,15 +129,13 @@ static int probe(struct pci_dev *pdev, const struct p= ci_device_id *id) ret =3D devm_uio_register_device(&pdev->dev, &udev->info); if (ret) { dev_err(&pdev->dev, "Failed to register uio device\n"); - goto out_free; + goto out_disable; } =20 pci_set_drvdata(pdev, udev); =20 return 0; =20 -out_free: - kfree(udev); out_disable: pci_disable_device(pdev); =20 @@ -150,7 +148,6 @@ static void remove(struct pci_dev *pdev) =20 pci_release_regions(pdev); pci_disable_device(pdev); - kfree(udev); } =20 static ssize_t pasid_show(struct device *dev, --=20 2.43.0