From nobody Fri Apr 3 10:56:14 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD401318EDC for ; Wed, 25 Feb 2026 12:46:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772023578; cv=none; b=U+1TixywpsJIZPEt/i/Mn/S5zTPwiIf0M7wskFvIwK1G+zJG2QJnRy1pmWIHdeA1TQM7aJ9+ZfS6lt3qV2pPhTQxFKvSWKPdV+QtjGVKy9f25yMOtC10b2ItixtOa+ThEoz6I6BC4HZRIiJVrcTz+HI8M3SmZogGg/679IZsxnc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772023578; c=relaxed/simple; bh=hPRqyNgo+2m/qSoiOkEDXqTHjY7Iod2zZmHDupkVvaU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fAd/u23PHDqQ4Ah+pE8dNT59QQNmZeE4oQWrP+kalwZt/DTn83yyMubMDr7F5IpKLJwF6GxDoLv2nQjVu2dnv3HHXLOXWgE0/SDVueVUek++FEHO6KQFyfA26qQgvuqx/gK1WBNjOySmJtGnNHrSpqf7FuEQpv5qpcoypiVk7Uo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XMGBZvUB; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XMGBZvUB" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4834826e5a0so81950925e9.2 for ; Wed, 25 Feb 2026 04:46:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772023575; x=1772628375; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d+KQvjhscMe6Lv4Y64pMFon0ThUQ6wiTUNs+4/NtON0=; b=XMGBZvUBkS0FuEE4nXrItOtVtPmWuhCS/0ZiqPV1qQSVeGHPOBnqNSFmkhRmbxinUo GauW+ECaNA/p7/6/tDvJEjLoes1t/0YzjOaOlGapyfbFV411V4nVcd0CAWbKApRsT5TJ DAj/4JfsoH9lqVfv1yA+rBkICYT5vLZ0KpFbG6KKscytis0fXBc2gMyn0THKrrAsThIK mcm5vWS5gTTcs0qO/wa7h/EQf1qaHIHlN6C1mFwqMWEGiiqwBxkaEsWi1JVG78r8qYEG KHM93gNkIyqmSXamjYZZGc9u/2pIqKo0+jyWh5+Q7pqPG0LcKHpJ2gdisdBb0XJmcU69 7AKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772023575; x=1772628375; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=d+KQvjhscMe6Lv4Y64pMFon0ThUQ6wiTUNs+4/NtON0=; b=VwKZD/mg1dHbAxfezcukMn3so1dFEHQpv6XRkHUjxR2SME4ansx3OmCk6xYKtDyVFl quqTf9nmwIs09ckDNw9WKCADmOFrfmxI+kDGEm5dFwR34d58DhmXNy3T80DixPYc/OV1 GxcI/SnvQWYuUSXIreYR7y4J9IPthL20xVY1zjaJH+9qDAdwp6IwT9P4wDc5LTKrHTyr 8mXyffxmx97d2kBF0VDInkHfmlM+7/Wpbi457psA+a2TK1tEH75tSAmaX40RJDjieugZ +f77ZYllmVedwKWA4hUyMkpXyh7S62KDoimSpkdq91Q+4STgunHw7rIVyGI1CYAD6z86 LFIA== X-Forwarded-Encrypted: i=1; AJvYcCW+bj8s8p7P/ztiqnVR6twU3pzh/bHneuBmJzrZ4eTs708/ZTVRUr0Sqrj1X6sROdrKelALxTsG4c3gWxU=@vger.kernel.org X-Gm-Message-State: AOJu0YzSGHM+LyeRXax56np4T1hAvmoUB+oyoyBfAWnqvAxx2X3r4vkd gBhNhqyI/+mSdHwCnqdpv67btbxyYRoxPL188C8lXU74zdAJzfA2gZ4J X-Gm-Gg: ATEYQzznAWjKRrPsMVpd+I2LJ2XHOiRACVu8/msYWUMfsqVHv31G7gzdcMGBIKR0D5Q 4HxkkRxXZ5PcpLZfdFBJ4TgkiXd0x77vroQcQ8KUFjtoJq0x2haM27idCehyLBT/Y2F+waMCUQF lcnggYdWjkVaSL8hJExr4+j1ylGqUZJ78a9YfrsYUvidG/NplzYdLAXnoeImWZX/fgwpJNhf41C OExype6NTx24tAMukRuQTvrHQlHfiMcKBi6wz1xFR42JnSCehc8CUWkt+DJcoWRz2kz/87/aXqr Erskr2CGvKKzLE1+G9YftvcJ0YehopJfPjhtRN3AYc5JJ+d7KJA+ldU/lmmKSiswd0MVZhDm/8Q BV/ItA2GkwuiW93o1WmPTXLYDf22ZS0uRsmpQIgeprCrQP7oroGi4Jewz/zIoxAAtxLyBcA3rQs rRIdpRIW39HevFnHk07LZ+jLLwYsc78slLqHnWGT9vD7/ahxrdWKH5+HKdz2a6XA9DwdgX X-Received: by 2002:a05:600d:8450:20b0:483:b505:9db4 with SMTP id 5b1f17b1804b1-483b5059e2dmr123888355e9.31.1772023575009; Wed, 25 Feb 2026 04:46:15 -0800 (PST) Received: from Arch-Spectre.dur.ac.uk ([129.234.0.168]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfcb9b97sm18419995e9.7.2026.02.25.04.46.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 04:46:14 -0800 (PST) From: Yicong Hui To: christian.koenig@amd.com, michel.daenzer@mailbox.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, Yicong Hui Subject: [RFC PATCH v3 1/3] drm/syncobj: Add flag DRM_SYNCOBJ_QUERY_FLAGS_ERROR to query errors Date: Wed, 25 Feb 2026 12:46:07 +0000 Message-ID: <20260225124609.968505-2-yiconghui@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260225124609.968505-1-yiconghui@gmail.com> References: <20260225124609.968505-1-yiconghui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Add flag DRM_SYNCOBJ_QUERY_FLAGS_ERROR to make the DRM_IOCTL_SYNCOBJ_QUERY ioctl fill out the handles array with the error code of the first fence found per syncobj and 0 if one is not found and maintain the normal return value in points. Suggested-by: Christian K=C3=B6nig Suggested-by: Michel D=C3=A4nzer Signed-off-by: Yicong Hui --- Changes in v3: * Fixed inline comments by converting to multi-line comments in accordance to kernel style guidelines. * No longer using a separate superfluous function to walk the fence chain, and instead queries the last signaled fence in in the chain for its error code * Fixed types for error and handles array. drivers/gpu/drm/drm_syncobj.c | 22 ++++++++++++++++++++-- include/uapi/drm/drm.h | 5 +++++ 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 2d4ab745fdad..b74e491f9d8b 100644 --- a/drivers/gpu/drm/drm_syncobj.c +++ b/drivers/gpu/drm/drm_syncobj.c @@ -1654,14 +1654,17 @@ int drm_syncobj_query_ioctl(struct drm_device *dev,= void *data, { struct drm_syncobj_timeline_array *args =3D data; struct drm_syncobj **syncobjs; + unsigned int valid_flags =3D DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED | + DRM_SYNCOBJ_QUERY_FLAGS_ERROR; uint64_t __user *points =3D u64_to_user_ptr(args->points); + uint32_t __user *handles =3D u64_to_user_ptr(args->handles); uint32_t i; - int ret; + int ret, error; =20 if (!drm_core_check_feature(dev, DRIVER_SYNCOBJ_TIMELINE)) return -EOPNOTSUPP; =20 - if (args->flags & ~DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED) + if (args->flags & ~valid_flags) return -EINVAL; =20 if (args->count_handles =3D=3D 0) @@ -1681,6 +1684,7 @@ int drm_syncobj_query_ioctl(struct drm_device *dev, v= oid *data, =20 fence =3D drm_syncobj_fence_get(syncobjs[i]); chain =3D to_dma_fence_chain(fence); + if (chain) { struct dma_fence *iter, *last_signaled =3D dma_fence_get(fence); @@ -1688,6 +1692,8 @@ int drm_syncobj_query_ioctl(struct drm_device *dev, v= oid *data, if (args->flags & DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED) { point =3D fence->seqno; + error =3D dma_fence_get_status(fence); + } else { dma_fence_chain_for_each(iter, fence) { if (iter->context !=3D fence->context) { @@ -1702,16 +1708,28 @@ int drm_syncobj_query_ioctl(struct drm_device *dev,= void *data, point =3D dma_fence_is_signaled(last_signaled) ? last_signaled->seqno : to_dma_fence_chain(last_signaled)->prev_seqno; + + error =3D dma_fence_get_status(last_signaled); } dma_fence_put(last_signaled); } else { point =3D 0; + error =3D fence ? dma_fence_get_status(fence) : 0; } dma_fence_put(fence); + ret =3D copy_to_user(&points[i], &point, sizeof(uint64_t)); ret =3D ret ? -EFAULT : 0; if (ret) break; + + if (args->flags & DRM_SYNCOBJ_QUERY_FLAGS_ERROR) { + ret =3D copy_to_user(&handles[i], &error, sizeof(*handles)); + + ret =3D ret ? -EFAULT : 0; + if (ret) + break; + } } drm_syncobj_array_free(syncobjs, args->count_handles); =20 diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 27cc159c1d27..213b4dc9b612 100644 --- a/include/uapi/drm/drm.h +++ b/include/uapi/drm/drm.h @@ -1044,6 +1044,11 @@ struct drm_syncobj_array { }; =20 #define DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED (1 << 0) /* last available = point on timeline syncobj */ +/* + * Copy the status of the fence as output into the handles array. + * The handles array is overwritten by that. + */ +#define DRM_SYNCOBJ_QUERY_FLAGS_ERROR (1 << 1) struct drm_syncobj_timeline_array { __u64 handles; __u64 points; --=20 2.53.0