From nobody Fri Apr 3 10:57:45 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD401318EDC for ; Wed, 25 Feb 2026 12:46:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772023578; cv=none; b=U+1TixywpsJIZPEt/i/Mn/S5zTPwiIf0M7wskFvIwK1G+zJG2QJnRy1pmWIHdeA1TQM7aJ9+ZfS6lt3qV2pPhTQxFKvSWKPdV+QtjGVKy9f25yMOtC10b2ItixtOa+ThEoz6I6BC4HZRIiJVrcTz+HI8M3SmZogGg/679IZsxnc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772023578; c=relaxed/simple; bh=hPRqyNgo+2m/qSoiOkEDXqTHjY7Iod2zZmHDupkVvaU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fAd/u23PHDqQ4Ah+pE8dNT59QQNmZeE4oQWrP+kalwZt/DTn83yyMubMDr7F5IpKLJwF6GxDoLv2nQjVu2dnv3HHXLOXWgE0/SDVueVUek++FEHO6KQFyfA26qQgvuqx/gK1WBNjOySmJtGnNHrSpqf7FuEQpv5qpcoypiVk7Uo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XMGBZvUB; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XMGBZvUB" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4834826e5a0so81950925e9.2 for ; Wed, 25 Feb 2026 04:46:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772023575; x=1772628375; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d+KQvjhscMe6Lv4Y64pMFon0ThUQ6wiTUNs+4/NtON0=; b=XMGBZvUBkS0FuEE4nXrItOtVtPmWuhCS/0ZiqPV1qQSVeGHPOBnqNSFmkhRmbxinUo GauW+ECaNA/p7/6/tDvJEjLoes1t/0YzjOaOlGapyfbFV411V4nVcd0CAWbKApRsT5TJ DAj/4JfsoH9lqVfv1yA+rBkICYT5vLZ0KpFbG6KKscytis0fXBc2gMyn0THKrrAsThIK mcm5vWS5gTTcs0qO/wa7h/EQf1qaHIHlN6C1mFwqMWEGiiqwBxkaEsWi1JVG78r8qYEG KHM93gNkIyqmSXamjYZZGc9u/2pIqKo0+jyWh5+Q7pqPG0LcKHpJ2gdisdBb0XJmcU69 7AKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772023575; x=1772628375; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=d+KQvjhscMe6Lv4Y64pMFon0ThUQ6wiTUNs+4/NtON0=; b=VwKZD/mg1dHbAxfezcukMn3so1dFEHQpv6XRkHUjxR2SME4ansx3OmCk6xYKtDyVFl quqTf9nmwIs09ckDNw9WKCADmOFrfmxI+kDGEm5dFwR34d58DhmXNy3T80DixPYc/OV1 GxcI/SnvQWYuUSXIreYR7y4J9IPthL20xVY1zjaJH+9qDAdwp6IwT9P4wDc5LTKrHTyr 8mXyffxmx97d2kBF0VDInkHfmlM+7/Wpbi457psA+a2TK1tEH75tSAmaX40RJDjieugZ +f77ZYllmVedwKWA4hUyMkpXyh7S62KDoimSpkdq91Q+4STgunHw7rIVyGI1CYAD6z86 LFIA== X-Forwarded-Encrypted: i=1; AJvYcCW+bj8s8p7P/ztiqnVR6twU3pzh/bHneuBmJzrZ4eTs708/ZTVRUr0Sqrj1X6sROdrKelALxTsG4c3gWxU=@vger.kernel.org X-Gm-Message-State: AOJu0YzSGHM+LyeRXax56np4T1hAvmoUB+oyoyBfAWnqvAxx2X3r4vkd gBhNhqyI/+mSdHwCnqdpv67btbxyYRoxPL188C8lXU74zdAJzfA2gZ4J X-Gm-Gg: ATEYQzznAWjKRrPsMVpd+I2LJ2XHOiRACVu8/msYWUMfsqVHv31G7gzdcMGBIKR0D5Q 4HxkkRxXZ5PcpLZfdFBJ4TgkiXd0x77vroQcQ8KUFjtoJq0x2haM27idCehyLBT/Y2F+waMCUQF lcnggYdWjkVaSL8hJExr4+j1ylGqUZJ78a9YfrsYUvidG/NplzYdLAXnoeImWZX/fgwpJNhf41C OExype6NTx24tAMukRuQTvrHQlHfiMcKBi6wz1xFR42JnSCehc8CUWkt+DJcoWRz2kz/87/aXqr Erskr2CGvKKzLE1+G9YftvcJ0YehopJfPjhtRN3AYc5JJ+d7KJA+ldU/lmmKSiswd0MVZhDm/8Q BV/ItA2GkwuiW93o1WmPTXLYDf22ZS0uRsmpQIgeprCrQP7oroGi4Jewz/zIoxAAtxLyBcA3rQs rRIdpRIW39HevFnHk07LZ+jLLwYsc78slLqHnWGT9vD7/ahxrdWKH5+HKdz2a6XA9DwdgX X-Received: by 2002:a05:600d:8450:20b0:483:b505:9db4 with SMTP id 5b1f17b1804b1-483b5059e2dmr123888355e9.31.1772023575009; Wed, 25 Feb 2026 04:46:15 -0800 (PST) Received: from Arch-Spectre.dur.ac.uk ([129.234.0.168]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfcb9b97sm18419995e9.7.2026.02.25.04.46.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 04:46:14 -0800 (PST) From: Yicong Hui To: christian.koenig@amd.com, michel.daenzer@mailbox.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, Yicong Hui Subject: [RFC PATCH v3 1/3] drm/syncobj: Add flag DRM_SYNCOBJ_QUERY_FLAGS_ERROR to query errors Date: Wed, 25 Feb 2026 12:46:07 +0000 Message-ID: <20260225124609.968505-2-yiconghui@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260225124609.968505-1-yiconghui@gmail.com> References: <20260225124609.968505-1-yiconghui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Add flag DRM_SYNCOBJ_QUERY_FLAGS_ERROR to make the DRM_IOCTL_SYNCOBJ_QUERY ioctl fill out the handles array with the error code of the first fence found per syncobj and 0 if one is not found and maintain the normal return value in points. Suggested-by: Christian K=C3=B6nig Suggested-by: Michel D=C3=A4nzer Signed-off-by: Yicong Hui --- Changes in v3: * Fixed inline comments by converting to multi-line comments in accordance to kernel style guidelines. * No longer using a separate superfluous function to walk the fence chain, and instead queries the last signaled fence in in the chain for its error code * Fixed types for error and handles array. drivers/gpu/drm/drm_syncobj.c | 22 ++++++++++++++++++++-- include/uapi/drm/drm.h | 5 +++++ 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 2d4ab745fdad..b74e491f9d8b 100644 --- a/drivers/gpu/drm/drm_syncobj.c +++ b/drivers/gpu/drm/drm_syncobj.c @@ -1654,14 +1654,17 @@ int drm_syncobj_query_ioctl(struct drm_device *dev,= void *data, { struct drm_syncobj_timeline_array *args =3D data; struct drm_syncobj **syncobjs; + unsigned int valid_flags =3D DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED | + DRM_SYNCOBJ_QUERY_FLAGS_ERROR; uint64_t __user *points =3D u64_to_user_ptr(args->points); + uint32_t __user *handles =3D u64_to_user_ptr(args->handles); uint32_t i; - int ret; + int ret, error; =20 if (!drm_core_check_feature(dev, DRIVER_SYNCOBJ_TIMELINE)) return -EOPNOTSUPP; =20 - if (args->flags & ~DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED) + if (args->flags & ~valid_flags) return -EINVAL; =20 if (args->count_handles =3D=3D 0) @@ -1681,6 +1684,7 @@ int drm_syncobj_query_ioctl(struct drm_device *dev, v= oid *data, =20 fence =3D drm_syncobj_fence_get(syncobjs[i]); chain =3D to_dma_fence_chain(fence); + if (chain) { struct dma_fence *iter, *last_signaled =3D dma_fence_get(fence); @@ -1688,6 +1692,8 @@ int drm_syncobj_query_ioctl(struct drm_device *dev, v= oid *data, if (args->flags & DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED) { point =3D fence->seqno; + error =3D dma_fence_get_status(fence); + } else { dma_fence_chain_for_each(iter, fence) { if (iter->context !=3D fence->context) { @@ -1702,16 +1708,28 @@ int drm_syncobj_query_ioctl(struct drm_device *dev,= void *data, point =3D dma_fence_is_signaled(last_signaled) ? last_signaled->seqno : to_dma_fence_chain(last_signaled)->prev_seqno; + + error =3D dma_fence_get_status(last_signaled); } dma_fence_put(last_signaled); } else { point =3D 0; + error =3D fence ? dma_fence_get_status(fence) : 0; } dma_fence_put(fence); + ret =3D copy_to_user(&points[i], &point, sizeof(uint64_t)); ret =3D ret ? -EFAULT : 0; if (ret) break; + + if (args->flags & DRM_SYNCOBJ_QUERY_FLAGS_ERROR) { + ret =3D copy_to_user(&handles[i], &error, sizeof(*handles)); + + ret =3D ret ? -EFAULT : 0; + if (ret) + break; + } } drm_syncobj_array_free(syncobjs, args->count_handles); =20 diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 27cc159c1d27..213b4dc9b612 100644 --- a/include/uapi/drm/drm.h +++ b/include/uapi/drm/drm.h @@ -1044,6 +1044,11 @@ struct drm_syncobj_array { }; =20 #define DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED (1 << 0) /* last available = point on timeline syncobj */ +/* + * Copy the status of the fence as output into the handles array. + * The handles array is overwritten by that. + */ +#define DRM_SYNCOBJ_QUERY_FLAGS_ERROR (1 << 1) struct drm_syncobj_timeline_array { __u64 handles; __u64 points; --=20 2.53.0 From nobody Fri Apr 3 10:57:45 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53EC23921D2 for ; Wed, 25 Feb 2026 12:46:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772023578; cv=none; b=j2foXwPLsWgqPZLJziU9+uc+xptOz/jvl40NqLwzLno/t4nhg9c/xN8CAZSQnDl6iIA37e4df4ohBACo80mZ7fS/AFftKc+jLnG4ycKEZyxz/3wvkT99cpMaU7As3F0wOi5NX58hnXR1z56mbKthBK5qkXtpVOlDKKgMvBR290E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772023578; c=relaxed/simple; bh=hOix4V1pd2Hvn+oW5lBTHNEtcWhJXZUb9vL3WrcFgvs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OYBaf9/xCeBMbu1oWqSEKjyyRSTqPcni1nAU+zqDbdvXa9797y6PYGr7oxwPEH3ABowRYxQJURajfyiu/ULHQ+aCttzpJU42pm/yt3iAiVE7IB9gAPQSqwXhUTtx0kuKj9FcfL+aRblx5tbkjy5Ip+I14t7Tlf7MiAo1LBHWBnk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dw+GfYYE; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dw+GfYYE" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48378136adcso39926315e9.1 for ; Wed, 25 Feb 2026 04:46:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772023576; x=1772628376; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q97leBUZ6iXO6Mof7p/W19wcP1ASx9yxVnD9x21iO8o=; b=dw+GfYYEe3xyjJ9SNqOGf40jSbsn8q1rnjky0EinJ6u6hbkkwJ6PbjvA1N8HdxOvpE AQqzDF9YOy3oTgvibEvuWgoqkPXR+wNXRc3P6YELepk6+7wvC53yFEcXEgHzpIcLHHty 7Fq2HkCIkcAL5psJHt3ol7xT53YFDYtgouw14OGxlcgbKHvSi3cv83J3QL2/i9zN+r3I 2uSDSXTeLplDUCY41ChP0vYLl67HgCE53holhdb7TFuG6RhYQsz2BC8BUs5DM2Mrqpaf VcGr0QUJNSFWKsk4vlK2js0MPNfxzX6c8YYF8uACLz+Y/96N9/DbEPT0dpDdtJvAPdzB N+kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772023576; x=1772628376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=q97leBUZ6iXO6Mof7p/W19wcP1ASx9yxVnD9x21iO8o=; b=xQXv1W77HSNw8Ibo8/1kLPzjWpJcjOSC0bYpU+0f3FJzVbPc/0nX6CafN6mJv7TS01 i67flojdEZfprGmzPAu6T6FCovsfXPQt4q4ViKUKKEeiNg0pqA6qDuoWz1LSXL5rRWG4 8DB/4L3mH/y9Ov+DGd5tjM9PuRsng0cDlCpUTp1JpArMiYWea11GFhC8LD40HfrpIvJN FfJf/AFis+fL7c0pmK1eyqeT2AEpWZUqjlOhObcEe179usWNX7sqoENecuZnVXCKE9pE x5AeyHDShAWdM97oiw197EUkYXI+gpkklEVAuTmy+zzSJtKXg2CzLv5S5Ta0NVt7gFPg fl4Q== X-Forwarded-Encrypted: i=1; AJvYcCXFf0GnPD2a5VDhqU/tz4XSn7JqkNDQXRLIRX6DrLiyQU2AA/Fi1QTob6myQ+uVqUwUXcK6WMzRWWs/9us=@vger.kernel.org X-Gm-Message-State: AOJu0YztbXPaBIAPRpMLZEx282XQwYM0tFwobiG/+CuwdHoi9W6f3TIM OGo431iDoWtiaLx/027f03XsX5XJZwiRVxi8bHNX9eOgVeOpBps+qbeQUJMgc124 X-Gm-Gg: ATEYQzzdDXq4eYclgIdyVJ9CEBKoBfcl+7t0dPFvShEFbV7Wevhi6mvPI/CxD1OjLz8 GX9oOHzdsfYGxLDhWEDc4m2lmkU8j2e9maD8nZd32YIctF4haZ44HV4T6FgZYN1W94KLGd7qEMS HMSg/qJhWTmUIfUaBcQUxZlga//vbXwMKqhGZrAupuG6XP2cTP8K1xV1IRjHkBwPRuZsSA8mqh3 lIKBo6abRLPhg0Z/YDkM5a1X3xnGUDhgcaDzu+f72FRbp8uIkJDgqzkrnTaCFdA5Hs3r35Tcs61 e8ViFBuyBZ0LKDXZ9lgT88TfiyPrC5g/QSrhWfrtWAmzlYD+8JtiQsRhpZlvddLA2mrlq3rZx/c MY56UstxLkaFa286CGsSKQAeCbsHrAszvG3DGXTpiiHgFIhCPfZ683l7l2ARWSlLqZaiw7BM4ga XoIASJ808n5vKed+AoBEDYkuaEeXOwSodjKpTLN8LeS8bFc8sWtvaU+/uDwdHn7ij7RPgb X-Received: by 2002:a05:600c:1381:b0:483:7783:5373 with SMTP id 5b1f17b1804b1-483c21a5835mr4391115e9.23.1772023575661; Wed, 25 Feb 2026 04:46:15 -0800 (PST) Received: from Arch-Spectre.dur.ac.uk ([129.234.0.168]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfcb9b97sm18419995e9.7.2026.02.25.04.46.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 04:46:15 -0800 (PST) From: Yicong Hui To: christian.koenig@amd.com, michel.daenzer@mailbox.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, Yicong Hui Subject: [RFC PATCH v3 2/3] drm/syncobj: Add DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR ioctl flag Date: Wed, 25 Feb 2026 12:46:08 +0000 Message-ID: <20260225124609.968505-3-yiconghui@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260225124609.968505-1-yiconghui@gmail.com> References: <20260225124609.968505-1-yiconghui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Add DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR ioctl flag for the ioctls DRM_IOCTL_SYNCOBJ_WAIT and DRM_IOCTL_SYNCOBJ_TIMELINE_WAIT, which will make them abort their wait and return the error code and its associated syncobj. Suggested-by: Christian K=C3=B6nig Suggested-by: Michel D=C3=A4nzer Signed-off-by: Yicong Hui --- Changes in v3: * Fixed inline comments by converting to multi-line comments in accordance to kernel style guidelines. * Used dma_fence_get_status to query error instead of getting it directly. drivers/gpu/drm/drm_syncobj.c | 27 +++++++++++++++++++++++---- include/uapi/drm/drm.h | 6 ++++++ 2 files changed, 29 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index b74e491f9d8b..2b23f638c1cc 100644 --- a/drivers/gpu/drm/drm_syncobj.c +++ b/drivers/gpu/drm/drm_syncobj.c @@ -1042,6 +1042,7 @@ static signed long drm_syncobj_array_wait_timeout(str= uct drm_syncobj **syncobjs, struct dma_fence *fence; uint64_t *points; uint32_t signaled_count, i; + int status; =20 if (flags & (DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT | DRM_SYNCOBJ_WAIT_FLAGS_WAIT_AVAILABLE)) { @@ -1139,6 +1140,14 @@ static signed long drm_syncobj_array_wait_timeout(st= ruct drm_syncobj **syncobjs, if (!fence) continue; =20 + status =3D dma_fence_get_status(fence); + if ((flags & DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR) && status < 0) { + if (idx) + *idx =3D i; + timeout =3D status; + goto done_waiting; + } + if ((flags & DRM_SYNCOBJ_WAIT_FLAGS_WAIT_AVAILABLE) || dma_fence_is_signaled(fence) || (!entries[i].fence_cb.func && @@ -1242,8 +1251,12 @@ static int drm_syncobj_array_wait(struct drm_device = *dev, wait->flags, timeout, &first, deadline); - if (timeout < 0) + if (timeout < 0) { + if (wait->flags & DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR) + wait->first_signaled =3D first; + return timeout; + } wait->first_signaled =3D first; } else { timeout =3D drm_timeout_abs_to_jiffies(timeline_wait->timeout_nsec); @@ -1253,8 +1266,12 @@ static int drm_syncobj_array_wait(struct drm_device = *dev, timeline_wait->flags, timeout, &first, deadline); - if (timeout < 0) + if (timeout < 0) { + if (timeline_wait->flags & DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR) + timeline_wait->first_signaled =3D first; + return timeout; + } timeline_wait->first_signaled =3D first; } return 0; @@ -1332,7 +1349,8 @@ drm_syncobj_wait_ioctl(struct drm_device *dev, void *= data, =20 possible_flags =3D DRM_SYNCOBJ_WAIT_FLAGS_WAIT_ALL | DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT | - DRM_SYNCOBJ_WAIT_FLAGS_WAIT_DEADLINE; + DRM_SYNCOBJ_WAIT_FLAGS_WAIT_DEADLINE | + DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR; =20 if (args->flags & ~possible_flags) return -EINVAL; @@ -1376,7 +1394,8 @@ drm_syncobj_timeline_wait_ioctl(struct drm_device *de= v, void *data, possible_flags =3D DRM_SYNCOBJ_WAIT_FLAGS_WAIT_ALL | DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT | DRM_SYNCOBJ_WAIT_FLAGS_WAIT_AVAILABLE | - DRM_SYNCOBJ_WAIT_FLAGS_WAIT_DEADLINE; + DRM_SYNCOBJ_WAIT_FLAGS_WAIT_DEADLINE | + DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR; =20 if (args->flags & ~possible_flags) return -EINVAL; diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 213b4dc9b612..e998d9351525 100644 --- a/include/uapi/drm/drm.h +++ b/include/uapi/drm/drm.h @@ -977,6 +977,12 @@ struct drm_syncobj_transfer { #define DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT (1 << 1) #define DRM_SYNCOBJ_WAIT_FLAGS_WAIT_AVAILABLE (1 << 2) /* wait for time po= int to become available */ #define DRM_SYNCOBJ_WAIT_FLAGS_WAIT_DEADLINE (1 << 3) /* set fence deadlin= e to deadline_nsec */ +/* + * As soon as any of the fences in the set have an error, + * abort waiting and return its error code. Index of this + * first failed fence is returned in first_signaled. + */ +#define DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR (1 << 4) struct drm_syncobj_wait { __u64 handles; /* absolute timeout */ --=20 2.53.0 From nobody Fri Apr 3 10:57:45 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AC7C31195B for ; Wed, 25 Feb 2026 12:46:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772023579; cv=none; b=cg6107W5e9OZURsCiek9u4bam/UA/XXJNqfyDHAcn4LAIUUasH60j5ga8IO87/4RBtlG90r/uzpz1vXYOWRSbF8IyFhwYxj9wIV87aub6/oo2Jmu41Y+S4R6wwve3FwZCLB7HqBMlQG2qmyAizimUgDpH4IPTd3Lg6ioNNcFxh0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772023579; c=relaxed/simple; bh=Inke+v9G8UVsM7i6besl6qC4FRL7yMHSFy+fqcBsMbY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZkLoqjSD8P6GoYFrU7dlunvLwF52Q7uRxEeNmAkz9L+Cr5YMVGgbQoZLwN09fgPWLrXgWX4KssB3rQLcqr/b4zpWsKNXRuL0Gkei3JglfcdyTpn79/NQf8QXHP7tkJMjefA5AKufHBGyULrnbKqYkBIO8xvcK43UTgKAaA2UtJk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WGq3ngDo; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WGq3ngDo" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-4398d9a12c6so788327f8f.2 for ; Wed, 25 Feb 2026 04:46:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772023577; x=1772628377; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i143R6oTYaMRVTgVRJMuG7Fi9AjA6YkMNWJRTVzxJWI=; b=WGq3ngDocFXVQ/0Bl9ZbUlAQOrKCZFXar8U3KixG7rQ8pSQZzkzFnFmV8H5epAZ3c4 C51XDO6B/F0p9bBzDb2s5d69bK1+fKgXroKKP6ng+XTANxw4vYaMB3JGgL+mSJhyWcsL +fRHwYi+1fT8MKGO/788TtuwIE6JwX+ml85G7gQIzXWzA2dG6NPqeA+nIBW7IyZc4obc cFdnBr7BIYHyB7MxmqRakfIw8L048XXVScRi/u4+/vUsTFyF1L8UYor84x3/st16GUZn qpwy3vxwMn5YdrDpvT+SORz+aRb+8GW1+f+DjOm6KLgLuCaKwElCtltM02MdBm/oFd7+ Mp6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772023577; x=1772628377; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=i143R6oTYaMRVTgVRJMuG7Fi9AjA6YkMNWJRTVzxJWI=; b=vufBv2J5US1VnqxcqXwa5+DBMElyXlYteUEJSmQwX/XkPBSRcMPScyCpNaN09orcbF 2E/2GBYtTOxiO3GhEV6FsmPUjtRXaHquAOfG44yB/0lRu8KkL4jE/9zKQ0Un9Ztgq3+P /8lv825kDDnkfcJYNgPTzPAyVA6N69HjxiCwb+7Gt2N2msYIA1fNNdYbnKzbNVTPUrQV C+GRLvm2XcEUmt0zVQcQJc+/ucvOeZ1XWJYP3VeOb2gHNokxsNiS6oP76319rHy6MR8e Jnl65yYLhaz0/T88YM1heaW2Xt/kDbaLba3vxQg5gwzKI8su6GpWnBoErIPEkOBvpdS6 K5ig== X-Forwarded-Encrypted: i=1; AJvYcCUVmgY4Q7UoL5xQ6mjk8paeGJ5sXeN/FgGFkzfytEQnizV0AdG5BZ+kFZF6mh8XBOfnP85gSKKdixqoUF0=@vger.kernel.org X-Gm-Message-State: AOJu0YxD3EgOTu/l5Z69UuYjTJI6o8kvuG+gWCMHLUFcqw1r4824nTmS iy5UY4i8fiLe6hubEEA2rX1zlzYPCckCICD3IXewfQaqIizGwsb2Wt0c X-Gm-Gg: ATEYQzwn+hk3H8tS94Wr2fO/m5ZJJmGi+9TMbl71OENeaLPeWJlkKYFtIcqwadjqkbp SPy353mn6Ak9Vtk1jhtkcB3xKo+5Yv0CPrmUjpdGMEw+t9ZpHPM9zeLnWHMsj2guonHx3/osC54 TKbMB0oST2wv5yhlpN8xlU1wJs8B+rljWn61VtYkDve5LqyxV/RYiR0TJVLMhXLqsYCfk/CpDqC V4tHAqIl/bmuSLfFXF6S15lqD5aFJBBw52oIgZmw9WH0uIs8hKO1Tk/pmmhcNLXoM5X63ZvbCvx cmF+xfEv2+aVHVgt//WZrsVlb4nSYrTI0jlTXgS44FS6nqCo0/jlYHzl9DTU++/bhxoBoKkPd2N 1LiTh4j5MUYRxoR7UF0nL0qhMcsJqKdzVe8/4C/hd1Mm0Ek9o3YoXA0HnzIf8nM/tRln5ZRk+xw Hx78+K7WAlL0gQnKPChM5+H3CK+trS0eC6gd6GtVfjR9nhn1N4wIxIUMKgS5sJyhS6YqMy X-Received: by 2002:a05:600c:4e94:b0:47a:810f:1d06 with SMTP id 5b1f17b1804b1-483a95b4b3cmr259672175e9.4.1772023576564; Wed, 25 Feb 2026 04:46:16 -0800 (PST) Received: from Arch-Spectre.dur.ac.uk ([129.234.0.168]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfcb9b97sm18419995e9.7.2026.02.25.04.46.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 04:46:16 -0800 (PST) From: Yicong Hui To: christian.koenig@amd.com, michel.daenzer@mailbox.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, Yicong Hui Subject: [RFC PATCH v3 3/3] drm/syncobj/doc: Remove starter task from todo list Date: Wed, 25 Feb 2026 12:46:09 +0000 Message-ID: <20260225124609.968505-4-yiconghui@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260225124609.968505-1-yiconghui@gmail.com> References: <20260225124609.968505-1-yiconghui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Remove the starter task for adding a way to query syncobjs error codes through an ioctl. Signed-off-by: Yicong Hui --- Documentation/gpu/todo.rst | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 520da44a04a6..8dcb1901142e 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -878,22 +878,6 @@ Contact: Javier Martinez Canillas =20 Level: Advanced =20 -Querying errors from drm_syncobj -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D - -The drm_syncobj container can be used by driver independent code to signal -complection of submission. - -One minor feature still missing is a generic DRM IOCTL to query the error -status of binary and timeline drm_syncobj. - -This should probably be improved by implementing the necessary kernel inte= rface -and adding support for that in the userspace stack. - -Contact: Christian K=C3=B6nig - -Level: Starter - DRM GPU Scheduler =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 --=20 2.53.0