From nobody Tue Apr 7 12:23:27 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57FCC33EAE7 for ; Wed, 25 Feb 2026 11:31:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772019114; cv=none; b=jMvvxuwRkL6OUCJgC8OfJaHJOBBmJr6j8sgC5tPHaJprZRo5t6ahf8jUcFzigWACO+Z2Z88eAf/Nj2r8CZbhNzmirB+tMR0r6eWJbjgTGLTr2qcyjxGhOdgeGCW9iiYIofhFrYAXxAmtH+Qav9KF6LO1ZdIoidHlagr93ssQcq8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772019114; c=relaxed/simple; bh=tyP0nDNjBIEMVKo4YhOLZyC/BQFAGdwA9TSDuFF6Dp4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=hm/2IFhPplwm7GuuAZPhzz8c0WzJO8nc8daa7va95Fpq1f0hP4n6tddkOhZXBZ7Dx+LbymK5BayC6gmQwnEqd33F9DL5V5DfgNx0aRqqEToG4+FB2r8RapNxGAuP1jpwRGohoKMDp5H2W+mKrWnmjkJG1jNTOYnQR7TyPUsaOzE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N0yYwmge; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N0yYwmge" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4806fd9033bso9432065e9.3 for ; Wed, 25 Feb 2026 03:31:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772019111; x=1772623911; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CBdnPip5pL49c6+gEunsZLiIHbCIze9L65pv92ooJx4=; b=N0yYwmgecqz4T3IyphiGxbs98zldqGTTUWJo/UQiYLmfjTSTBsUwEKMM04x9Jh+7tS GJHjYbJYuUV4eZN9W4bLR7olijWMr312HYUa367vp1P1BcaqkbJlyryJncyVLVrTK1oN y5I2RtZFpIbEtEn/FDekwJ8YUsSS6NTgd1GcxdrRzNAo694x2dqKhdXohH6hBENpTP67 C+2e/7pshxIhPC2CLNrQ7Z/PHz00MeNubzYCUQ+2olN2I8jlhf1hBU/Iqjj2lUG3N3zZ wHafPhgLirnhLVtMuhxhlcB1FGLlufuSqfWv2sf8gUaNo+Nj4/74bJUSFErpvpYwWCKh celw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772019111; x=1772623911; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CBdnPip5pL49c6+gEunsZLiIHbCIze9L65pv92ooJx4=; b=CDtI3KIEgMPY5g2/PVUeJIKUzgWYNIWUs+E+cqlWU6zapuMDzwVKxRIhmMPmchwJY8 xXwPvQ06CmKvmARo5ZnMAMRcqc4faVsMcsY18bIJ80Vz7MSlSRgbEJBIp9tqnsMvho6N 03oTbugRK3tGmgbutFUJdX1/miZD7ga1iclrFFXgCycLnkPn0mQnrS7/yZv9UPZ0a3h5 v6HyD+7wp7UCEWgg6YE4i3TZh+on0ZZ9RSe3/N1htLdDM8KZIlqEzRWVu+5rz2jhR+Ti fewD+ouu+hTN7qQEF/K6kldg8QQ1W13tqy1rCe8W4x/9hqrxr4QR+8fx6ShLrtyp10zx lCmQ== X-Forwarded-Encrypted: i=1; AJvYcCUvMgtdEqBnmDWdQp2w0xYpHOEHhFn1nvP6RAqaSQ0KAlMF+Q1UdbVIgtu55ZvJirdZd/TFNo9S6q1kI9k=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6ceRuzTHxBRiykt6IGraMUGTHcBl3Dgjv9Wg2dYgWyk6zsGHx FtHwRAd59Y0Db+198ceYTzH3ul0qIpRcA7OOLTk4JiQEBc+v/te23+y3 X-Gm-Gg: ATEYQzxNfbRcSnyydtPhzLsP2B9ANNr1Fe2NC2zJEd4kszri0oI+aYXspE2J9ZQQZBb jv9qgnPetNFM/6bQHxR1WifHiTJgCX1SNwFDhvY4/6vEtVAnwbmSDXbzjuU5N6leu0C7Twbh+V7 3JrpEw3TxVBKIuxuqBP2oUO0qp/RlCdOAcAMFNtwtCRurPrqXNyBydwcNxoToF6RapCj9VHzL59 oExTzXjDDkY8i3vZDQVPTG8OhN+5jo0gtz2oEgK5L8VpkXHXM0EeBjMgP5yaUBpqD05NvqyA+HR Iut7HNvrX+z3F0M6NftRCmugAKO5ZpwmUiEXvtYurz9lL1M+Joeu2QIW6oF3acWn6dqy2+Lih2y Ad+vU30+h2qMaW31QriZx9zP3HClGVZ63mN0GaxlzcgiDF+rGK7MWsyRd8ks11Jv/zQ16ZJz4TR i9WZE2pp54qERiqXR6FFoduEK7Q098RkqmQZLq9w7sEjaQvXiwdClAxjX4kUDJ6DvbzXntlX71w ktRUNU7OhwTCyw/xiMJ3jDEJ6+Bcp63MvVZqQJbKRYEHwtHZFVc X-Received: by 2002:a05:600c:8183:b0:477:5b01:7d42 with SMTP id 5b1f17b1804b1-483a95e42admr140167735e9.5.1772019110306; Wed, 25 Feb 2026 03:31:50 -0800 (PST) Received: from fedora ([149.3.87.76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bffc17dasm17006135e9.2.2026.02.25.03.31.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 03:31:49 -0800 (PST) From: Giorgi Tchankvetadze To: antoniu.miclaus@analog.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Giorgi Tchankvetadze Subject: [PATCH RFC] iio: adc: ad4030: fix calibscale read/write unit mismatch Date: Wed, 25 Feb 2026 15:30:39 +0400 Message-ID: <20260225113102.84568-2-giorgitchankvetadze1997@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The read path returns calibscale in IIO_VAL_INT_PLUS_NANO but the write path treats it as MICRO. Since no write_raw_get_fmt is provided, the IIO core defaults to MICRO when parsing userspace input. This means reading calibscale and writing it back results in a ~1000x gain error. Change the read path and available range to use MICRO to match the write path. Fixes: 0cb8b324852f ("iio: adc: ad4030: add driver for ad4030-24") Signed-off-by: Giorgi Tchankvetadze --- drivers/iio/adc/ad4030.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/ad4030.c b/drivers/iio/adc/ad4030.c index def3e1d01ceb..3d823648371d 100644 --- a/drivers/iio/adc/ad4030.c +++ b/drivers/iio/adc/ad4030.c @@ -423,10 +423,10 @@ static int ad4030_get_chan_calibscale(struct iio_dev = *indio_dev, =20 /* From datasheet: multiplied output =3D input =C3=97 gain word/0x8000 */ *val =3D gain / AD4030_GAIN_MIDLE_POINT; - *val2 =3D mul_u64_u32_div(gain % AD4030_GAIN_MIDLE_POINT, NANO, + *val2 =3D mul_u64_u32_div(gain % AD4030_GAIN_MIDLE_POINT, MICRO, AD4030_GAIN_MIDLE_POINT); =20 - return IIO_VAL_INT_PLUS_NANO; + return IIO_VAL_INT_PLUS_MICRO; } =20 /* Returns the offset where 1 LSB =3D (VREF/2^precision_bits - 1)/gain */ @@ -720,8 +720,8 @@ static irqreturn_t ad4030_trigger_handler(int irq, void= *p) =20 static const int ad4030_gain_avail[3][2] =3D { { 0, 0 }, - { 0, 30518 }, - { 1, 999969482 }, + { 0, 30 }, + { 1, 999969 }, }; =20 static int ad4030_read_avail(struct iio_dev *indio_dev, @@ -739,7 +739,7 @@ static int ad4030_read_avail(struct iio_dev *indio_dev, =20 case IIO_CHAN_INFO_CALIBSCALE: *vals =3D (void *)ad4030_gain_avail; - *type =3D IIO_VAL_INT_PLUS_NANO; + *type =3D IIO_VAL_INT_PLUS_MICRO; return IIO_AVAIL_RANGE; =20 case IIO_CHAN_INFO_OVERSAMPLING_RATIO: --=20 2.52.0