From nobody Thu Apr 16 22:34:02 2026 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77482246788 for ; Wed, 25 Feb 2026 06:43:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772001795; cv=none; b=VnrymAAX4maFdQ2Q6NMFwfUZ9SFeQwo1mD9Ao5YyhECzAT3ITkw5R5RTTe2tFaR9LfdAbGRJtj89p1bwqEQaDsho0nGfeuhNg1MIGKGtHJJr5I6c0qNsqw60w9Bn60Z8tNrS4ZjQ8fGpWnLda4+LzL7a50ShEYoshqKaksB2trw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772001795; c=relaxed/simple; bh=dGJkN6SnVshmKW6KFF4UVx9o8lSkn1Lt8gx8YuivxlU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QaTSguQWfdfZfnVnatWXs9JBEx2bbDDJSceYhgFaATfTgonta/8YcfN5uxjP7QeZnCNQLLjSfxP9pr3xcFl4KHIW/hF1VtclVEzYWgQFe/pjMXkvBtS4r2lRM5yJjRJXEGQZSki5rE5HqmbH/Q/aYtq91jGsxOhBHTqpfkWhzJY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TAXANip5; arc=none smtp.client-ip=209.85.221.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TAXANip5" Received: by mail-wr1-f65.google.com with SMTP id ffacd0b85a97d-436e8758b91so4341853f8f.0 for ; Tue, 24 Feb 2026 22:43:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772001793; x=1772606593; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1j2htuqmQpTTkLQ6035xROAKmDGpEfPVgSnXewPmtLo=; b=TAXANip539EJa5cTLIFPeinn+cIjUHCMCNoq4l21gl+9a7ZGhyXTDWWaYvQOPkpTiC rhXOpZYgzs0817cpO+27SzJ4PF0+8cm0P6gEO5SNg54Q/s6md8m2ww+UNghYXXCYaHK2 +qdJkQPHfOoRxTZ/n2dH+ZLMHBaRiIkkRiigFzJIwEmMxvEIsth6+AW0PJ2r3YXXKazo oNXdgMv/q1gT4deJhU1YQRqt5nXkuta3rRFHreEy49/YJwEirrNBqBoiwCA6+dhjBsxQ /r9m3ng1qrLCVXovA9k29IsiX2eWR8bVgV36+ndRZPg1Rt8LPl92M9rY1KD42CMCxbnY bazA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772001793; x=1772606593; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1j2htuqmQpTTkLQ6035xROAKmDGpEfPVgSnXewPmtLo=; b=jxeI2GDjvhipDc2fjoah8OaorPbHvbgXk/CnvGpuf04rH3E1aJH863q7d8vJZe+c7+ reAQ7pxuWMVT8PpJrMXmB/MddOZ63aO19emI4Z5Jp06oUwtXIY5n+N6XcMhAkq9/759R rBrqqa4DNeV0tnK7aFAMxRgyIUlh9RW7foH6+Fpw/GYxQvoAxV+HARLD1nxUzq3dHo4F p8D651CmYFsChhhnaqnOywFGYfgTRyXh8Orxsi0gK3NCMGCfDMVy7jBjuuOA41aQ6uPs J1Bd5cf8lCYUigUDVmMGw4IPFR6rAbJFK3Ck9rvFPuP29vzYowlYeiLZf0LX4INVGCtk NKJQ== X-Forwarded-Encrypted: i=1; AJvYcCWyV1aPErvML4rbE5N+zupKw69P0ULqGGFQN8clQRr9Uv03iRGAdQmVNXLSeM/9QwunTZ52NLiIcy4yb/Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwIg+drGt2XsOkKGWYN/YQw3xbLcMJ7cKCE7MrHNkTmWDyUL8PE ThAXO5iWafSIUOA49pNYulh08myh22bs9IY+9yDwOQyUv7O7gDh4H5kW X-Gm-Gg: ATEYQzwjwPQPFvzGIrrNgd/fLzYqSZ3AcdfBZIlF0fsnzbNjxIUXRkceSUmzsHt1olG GiJ4gPJlBvppAxCPEo5a0NR9d4wvUmnx9YB5fF0TfYfK3BKJ1nEA4pTNzj8ZPkS3KBpFHLy/M7U MLFhHGXtPnA5cIKtHrdURbauSL4fFW3wNP81wBbCcTX9f3oj9lyUd9pKbe3uqsH7No+F8zDjnBA gvcjvtbn7l2zroWX2rjFZbnCZdZsffFOBAvAQ4iFGDB5aQmkl7s6Mu1an7qgCfqf+AwOCc0m5Gy qZG6OyFjk7Zul9F02RZ8zPzfiLIkGZfVSm6tYY2gGSJgWb8S4z+sq9bOom34ShN862B4glkfgz7 aqvHL8IqcqxfBiwqZSA9GRCI0u9gvTuVQH8SuPMlvue3mpWXV3GlLN5UVnU3tndQoOMIqQy55cK gXpquLBpC3yKl4LpVKTA35c/PbgxbSE2wvl9vQdOF8bs7iNu4RWRs8aVudCNWQPS1tIKy4 X-Received: by 2002:a05:6000:26c6:b0:437:7168:af4f with SMTP id ffacd0b85a97d-4398faf1376mr1688051f8f.27.1772001792676; Tue, 24 Feb 2026 22:43:12 -0800 (PST) Received: from zeeshan-Standard-PC-Q35-ICH9-2009.. ([110.93.227.54]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43987f3ed03sm10954287f8f.16.2026.02.24.22.43.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 22:43:12 -0800 (PST) From: Zeeshan Ahmad To: Thinh Nguyen , Greg Kroah-Hartman Cc: Dan Carpenter , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Zeeshan Ahmad Subject: [PATCH v2] usb: dwc3: qcom: simplify error check in dwc3_qcom_find_num_ports() Date: Wed, 25 Feb 2026 11:42:45 +0500 Message-ID: <20260225064245.8833-1-zeeshanahmad022019@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260225001036.gg2ghnayekrhbcxh@synopsys.com> References: <20260225001036.gg2ghnayekrhbcxh@synopsys.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The platform_get_irq_byname_optional() function returns a non-zero IRQ number on success and a negative error code on failure. It never returns zero. The current implementation in the modern dwc3-qcom driver checks for a return value less than or equal to zero. Since zero is not a valid return value, simplify the check to only look for negative error codes. This aligns the logic with the standard return contract of the platform IRQ APIs. Signed-off-by: Zeeshan Ahmad --- drivers/usb/dwc3/dwc3-qcom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index 9ac75547820d..f43f73ac36ff 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -526,14 +526,14 @@ static int dwc3_qcom_find_num_ports(struct platform_d= evice *pdev) int irq; =20 irq =3D platform_get_irq_byname_optional(pdev, "dp_hs_phy_1"); - if (irq <=3D 0) + if (irq < 0) return 1; =20 for (port_num =3D 2; port_num <=3D DWC3_QCOM_MAX_PORTS; port_num++) { sprintf(irq_name, "dp_hs_phy_%d", port_num); =20 irq =3D platform_get_irq_byname_optional(pdev, irq_name); - if (irq <=3D 0) + if (irq < 0) return port_num - 1; } =20 --=20 2.43.0