From nobody Fri Apr 17 00:23:19 2026 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012056.outbound.protection.outlook.com [40.107.200.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86AC1433B3 for ; Wed, 25 Feb 2026 03:14:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.56 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771989272; cv=fail; b=udHZ0JLwayrPTHYXZ1saIRghwp2Qcyizd1uimLuPsi+GdlDFa4RizwC95oe3LLR+wJSQLF0bDCYmFxY0s9LA4dh8joo2tRGuEL0zipppQfRBurg3YTIqzKTuWqER6SjrsPofQa+ak4B6obPAwr2ebrcUSwBPzUrE+jPos64LsTw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771989272; c=relaxed/simple; bh=yeNXPOvvu0ID8byB2QbNuy2Hk4x620SM5zjZKz0RH1E=; h=From:To:Cc:Subject:Date:Message-ID:Content-Type:MIME-Version; b=cawfHIHzIsBl3a7RtpoHV84A0q+Mdo0ARcvpIG5zLFk9hlTNsDMdL3NMOJ9bCQW5CHbVt5lmTiek+KLYpt+O6yrwVfIGwBfcHBtJgMjrBmfKFODQnqaHJqD0NLPCfPcyMwHBwmWBJpkcML0Z9gaZg7IXiHJqOIbYxh/FVreJhcY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=PXamBTxf; arc=fail smtp.client-ip=40.107.200.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="PXamBTxf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uKMtTZoig90QOCyGR7e/B78sOlaPbCeOJQvZR9s1kAxzyZqsDp/OA0hGruoT7YDUAfni9vJSDeD3POqXLoXrl//HkGbUioE16R4MyrtR06r/dZlEHd6SlRkIWvlQy3YHIsTtCMIDW8esHx0tpNdX3sF3r5xLYCeiUty19oxuus+L35GbFR/CSwzqzq6bpXcK7gJjp2eLTt7IISumiVZzs+q4XAm43Mb9jm6gVfvvJet6gcfAkhix2rtXeh22pXY7rgqTGATQ0o1nhPoTXDyg/1U8Z1BSbXwK0JoyD3QXwT6DMZSimdoy3ezkQR2Q0qWZzyzmc8m4sa5JHjGes3D1mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/GW9x/Fk4H2UxY7sgyPwLLANKW0qoXwW/ht/j414AGM=; b=s5uGXhJu0sDEktz5Vp0VZH5WaE5O7di576v9qncGHjvpQeat+N7YMPZa2sQ/IE/BJOA/ZgQbrSjmzW6nRS41yTxmciLbaRR0LSY3zoeNUiHgVVlEI64xl9nHauLTJIxZCYV++4XdTpUpvfgFOv6FF7lncIucSvQG9SoJ1SXr0+8fHzEftMOKGpGZ7evxL7G87G/abS0SdoC2N8cBuDsnc1Du/L/FpPRJ3daWgNbOSNhDPY4Qp9Xmc4FBpX14UzQKCg9627yKj3J5WdHYzH2D9K7mKSrNxR0tbTkD5E6cliuDRCwJFcF8SKLYaV0tx/BXeV5ZTsqypmniuqDQ15Ocug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/GW9x/Fk4H2UxY7sgyPwLLANKW0qoXwW/ht/j414AGM=; b=PXamBTxfSSBt1r+26Rbc1b1izLNDLahK77u10rMPulMD9JR1hCmx+6J46EOihDGMsmS2YHmjPj39XcCr36tF+31SuQg1rmZaKTr+qR4olx8nOf4hN2OfMmwQCCllidErkmbhN0Xyx5WU52aBb8ex8HYH3rsQr5iezzLD2zTafFDBA0rNQhT8U/XTtgIrMl+Fr1+BENa3cycaozopM7qz+C9aHsn2Dyw2k2vSa3TpoHHYbYZFTl93A2S6GvWS9VABgg8oOaXxBtMgSqvIvCKuHidKlWqmVWIUc7Ad1bUTnEX6Qy2xyJ+JrJ7w2GYpUzH4iyk21tIe6vo+cI0ryah7NQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by SN7PR12MB6912.namprd12.prod.outlook.com (2603:10b6:806:26d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.22; Wed, 25 Feb 2026 03:14:27 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9632.017; Wed, 25 Feb 2026 03:14:27 +0000 From: Zi Yan To: Andrew Morton Cc: David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kefeng Wang , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, SeongJae Park , Ron Economos Subject: [PATCH v3] mm/cma: move put_page_testzero() out of VM_WARN_ON in cma_release() Date: Tue, 24 Feb 2026 22:12:31 -0500 Message-ID: <20260225031231.2352011-1-ziy@nvidia.com> X-Mailer: git-send-email 2.51.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1P222CA0012.NAMP222.PROD.OUTLOOK.COM (2603:10b6:208:2c7::17) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|SN7PR12MB6912:EE_ X-MS-Office365-Filtering-Correlation-Id: 629ad36a-ce25-4280-8cd0-08de741bfc02 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?q3hD6cAeJdF/kaDDK1lnmiZ+/hH9hPzNITWeCPhD6TokTSoVK8VsENABf5fa?= =?us-ascii?Q?ZM1SE1nNTZLbz9frqDEXnuCdCqrB1Ix3MkdzRRzsBfIV9CsXM6WNYrtiU4P6?= =?us-ascii?Q?lFO4zTtJ1Hfgr0S5D+wuxPBgpLJj/1GZmQFaDzuimFcztECXpE3gmw9ixtQK?= =?us-ascii?Q?sdZA8O80TZTtTo5iK6Wgb0Ha7Uag261ZtWc2JQ8LZxNYchxhmTn5Hw5RhsRV?= =?us-ascii?Q?jW2w+23sG6JshAdIK1PnVpnnAYt1kCmpYaDzQvaUWogFxGOVs43aAgF8W614?= =?us-ascii?Q?rDSTgVyoAWETGY63ASPSSvqAbEpHsdMF54mpKkKBruBCOrO1iGSdu05a9X5P?= =?us-ascii?Q?vAFO2EpjqldSWtEBVNfZD000mOSGfIt3Y3eRt0TnNTAPjTQIfdIzpWxv+Uyk?= =?us-ascii?Q?QzfpibIS7ewbHzzMLpoLNoSMF0MRx6LZjN0RHQAyQuBJhrB/S02Dip7IJ19C?= =?us-ascii?Q?R0vzAWts2jede8PRLD3z3PVHIdyHlg8ptQQtW0A0VqNjpnK8znfSwOlWZer/?= =?us-ascii?Q?O7MGBmRDzB23Eo/zH8w9GdX9VFWHqy2NDCdRNAPhOHGJ6J7/wXHIX8/JFSgK?= =?us-ascii?Q?5ZvQXciCQ1Zdm/uuzm017/Lx3lVTOkQCWPZdwapLuZZ7+S64mOBMSiTG+pVL?= =?us-ascii?Q?JORllXR8uOS90ggpy0VLJfSfkn8FSWJ1wkSKaZ4bsDdaK7PtCHKyfHNQH/25?= =?us-ascii?Q?NPPnIwcQo/68dCsJ676wxL/deSKhRxWmz3rWMOiWKo5Un9wWlLYoq5DucC3J?= =?us-ascii?Q?SK6x9yGMf7qnmPSVkHwhGWN6E7PXOonkKhStofpMwr3/vVUEhy18fmRIUcfu?= =?us-ascii?Q?i/c1mAJP0usODhyr6JlFySWRLFJYDtXF8e5iCtS8M05OvJi/Wj+LwNWpw/wf?= =?us-ascii?Q?i298LhvTsZYMfk3peM3PREbjFsKKrJHV37mS25XUu+8pxP7jbBxXHHu9qxFL?= =?us-ascii?Q?zZs5UYzBvamfqTJZFbwhJcr0KU2K7f3CqhmlolLZZalAb/Voh6kOO98l5mwF?= =?us-ascii?Q?EqUAye8OuX5tc1YWFIGHKlz/ww8Yjp7mKEQJABigPuYjM3TDNgfwpwISHqtW?= =?us-ascii?Q?LUZYa91juT3aAh2bSvxlCIiXRX4EZwgCVlw3+nYOUZuIjUneA2Laqrw6FOo8?= =?us-ascii?Q?lMwB6EgI7wBdIxumdORGeeLLeweelp4BzA72InnY1lsSzzMvUKB7WYyEzU2U?= =?us-ascii?Q?iFdaWMxrBRA7TA0tB4m2XHQU4mMdkOdoDWsK3wbnsR0+tdhDSmVTTm32QUJa?= =?us-ascii?Q?sXIpyCdZFUVqxylShDGPd8e+b0fPeNPdjnaZDw+PZgN3YnJ12FXyzMQJ2W7X?= =?us-ascii?Q?gKOxwidJJzCjfQxaDiqJesWTMAw5L8NPBn9ZcyvYklRwMudr06Q/Ow6Wxmrc?= =?us-ascii?Q?Nlp3lqKjfqRcOX846nDcr+eZNUVQFRTOj9D2V0fLOPU7Ucbk4VnwQNQNaLuE?= =?us-ascii?Q?gfCLp6e/hOdaxI+fypQ6Rk3fGEaceCB3/doHw35o/INhi7tYlUqk3oniZirv?= =?us-ascii?Q?P2ItN5mnIOpITMPlSI5JXKwEan0bs66GSkHWKmtgyRpICwx0gvgyUBfR1da7?= =?us-ascii?Q?Y2okXpwRxEtutwxeAYI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dD82BxeAWJqmhYtnCnBwU7atUj7mGTEXQcsLD+TU/hg3e9QjEP/HqsybWXcw?= =?us-ascii?Q?yvjJoaI+ai4kJCxtHyLiNIdIC+HL6nElzV1qqcafQnj+50L31jWBc+AWPMa0?= =?us-ascii?Q?1dUliVgM9dmpnqEvHAnOJa0vIugfDjIf/ILyeBXZ23y4ZGwsB35L9n0RMqkD?= =?us-ascii?Q?Ej7blZFL3VN8Lyutbzy/3iFFc8FcUorfEiLCF3FcW/ENbwqYYv+SBLlIOXrc?= =?us-ascii?Q?hSrOErVPfHrdWYb3mzsiXDJzjzK+qbRIcIDmdWe+5ZEogFcU3xuUr3c5aP9l?= =?us-ascii?Q?AfrfHP1OmrkjNn0afCiFJWGSyVsT4mDMbTEiR+B+51uM/iraM9m8TQOx/QYF?= =?us-ascii?Q?3L9KC7TzQzO0xUgNX88tYhU8yU3uv9ZGcmezR3HR/p+OFvz1Po0G2TCmzZFp?= =?us-ascii?Q?5D+eLW/vxyENFQ34gMuJFWdkDkatE+oxz1uaYnOVffU+Ft2P8V8+AYAEXORv?= =?us-ascii?Q?C8ytiNg/WfFXUkROAns9kz2aDTOyFInpzV5hSZbnResb8paoEi8eXrGIn9OC?= =?us-ascii?Q?gCp28XFI8YGXFZOp2dHKGHkr/e3QaEHsKKfG9dJVQ6cYq0u5tSaxr/tCmkdP?= =?us-ascii?Q?loY81uiT0jeJ4qhViRsRDXlpuZxVVTNWOsKsnQ5gjot5+HlYTf+/kVFg3zJu?= =?us-ascii?Q?lOh2fm9A+4dcJtvw2OL0E6mnJ/tE/jHeGt6HANLYwXPO7iALBTyNf75oWYR7?= =?us-ascii?Q?OyXu+IjKAZFHbrMdSNM2twoHBTzRm29tVIYt/h5U0CQ8mGHGT8xUIWF853bO?= =?us-ascii?Q?TKhZTDxOJsejlOXmZt83/2s/B3dJb7YbM+k8d2J3L0ebhlgrMtiM9MsS3VrT?= =?us-ascii?Q?LwDK1EYBSfOKbbQZFklpIOSHYHgSrMj4xKX6nfL+1s2C4zJFNih51ng2/4/A?= =?us-ascii?Q?ut4dqmFaNywwl4E2GbVbkCdQcmGxEQQJ8YY5rLDG7DIC72LDFrMXY1Yy7IBv?= =?us-ascii?Q?PyeuHEb7Ykj/T+OPpBGpEl3Q5H0oijsWH/k8hePl11QawI222WA0B4xEO6SZ?= =?us-ascii?Q?cRUmCJMhrcygTHKdF7Udy24wy9Pyx/9YTJolzEH6CjPDrVoQLKW6lcFZoAMW?= =?us-ascii?Q?CqgqECsko0L1zO51PkjOrbmbKNCC/X9y9POWpsWps1Ibxv5BJxNbm2TWQ/mV?= =?us-ascii?Q?8HX+yljXTB1a00O01Uyr8oJ1r05/J7Pu6zCK163zn6f+8ZU4X9v3xn2NEP49?= =?us-ascii?Q?DyqZD0Gifi2doUU9wgSoSAbRsBDpY7E2KZrxyB8cOicl74hgG4acXBeK2LqP?= =?us-ascii?Q?nwtpE9LkyCa1uBskGrMo1AIywD/5K6L2HUjgoxbc6+eUyc9wCO8iunGHtoTy?= =?us-ascii?Q?8/trz8vf0uNk5DCB/QAF+P1A7YnYVGk+YYO9e8TEQVzpbWY63xZ5KQGwbhVX?= =?us-ascii?Q?0tGaA+/ksPJNAMn3ZMNK1TdBpMLWgqhwgmoV+Tp8dr//k3TTsbHVsr9dI6Ly?= =?us-ascii?Q?xOqP099nMOgYEroKam+tJwYlvY/7U94fBhgU6YHG9I07ukR4gctQ1mBrstNO?= =?us-ascii?Q?r3Ehp/6T220PvU2dUDzAP/dlTxlNBfQGGnvrtFVTNRRHCK3rXWXpbKElY5vg?= =?us-ascii?Q?rVOcqU4rRfVLslFSk8hm4hbsh5Qf01LGg4VBcEUWdEMiLRb0qJQnW2Djp9LS?= =?us-ascii?Q?N/PJhsbwOoSzrV0MxY9bE5SwqlcNr/A+c2kPj7SyxjaSBpxT5MP+N6SMZM7J?= =?us-ascii?Q?xB4FFIFz4+WhorZJxpe8AmNumIUCr+HYRtGhHEMkPvuhVdhf?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 629ad36a-ce25-4280-8cd0-08de741bfc02 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2026 03:14:27.5433 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Dyx5YSnPRo26I1EmYTHHpHTwCfJ+heO55gSFPy2JHa0FWRzZro/FFBZSlJ7eMfMJ X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6912 Content-Type: text/plain; charset="utf-8" When CONFIG_DEBUG_VM is not set, VM_WARN_ON is a NOP. Putting any statement with side effect inside it is incorrect. Collect all !put_page_testzero() results and check the sum using WARN instead after the loop. It restores the same check in free_contig_range() before commit e0c1326779cc ("mm: page_alloc: add alloc_contig_frozen_{range,pages}()"), the commit prior to the Fixes one. Fixes: 9bda131c6093 ("mm: cma: add cma_alloc_frozen{_compound}()") Reported-by: Ron Economos Closes: https://lore.kernel.org/all/1b17c38f-30d3-4bb4-a7e1-e74b19ada885@w6= rz.net/ Suggested-by: Kefeng Wang Signed-off-by: Zi Yan Acked-by: David Hildenbrand (Arm) Reviewed-by: Anshuman Khandual Reviewed-by: Kefeng Wang Reviewed-by: SeongJae Park Reviewed-by: Vishal Moola (Oracle) Tested-by: Jon Hunter Tested-by: Ron Economos Tested-by: Ron Economos --- From V2: - Collect !put_page_testzero() to get the right result. From V1: - Collect all put_page_testzero() results and do a single WARN after the loop. mm/cma.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/cma.c b/mm/cma.c index 94b5da468a7d..15cc0ae76c8e 100644 --- a/mm/cma.c +++ b/mm/cma.c @@ -1013,6 +1013,7 @@ bool cma_release(struct cma *cma, const struct page *= pages, unsigned long count) { struct cma_memrange *cmr; + unsigned long ret =3D 0; unsigned long i, pfn; =20 cmr =3D find_cma_memrange(cma, pages, count); @@ -1021,7 +1022,9 @@ bool cma_release(struct cma *cma, const struct page *= pages, =20 pfn =3D page_to_pfn(pages); for (i =3D 0; i < count; i++, pfn++) - VM_WARN_ON(!put_page_testzero(pfn_to_page(pfn))); + ret +=3D !put_page_testzero(pfn_to_page(pfn)); + + WARN(ret, "%lu pages are still in use!\n", ret); =20 __cma_release_frozen(cma, cmr, pages, count); =20 --=20 2.51.0