From nobody Fri Apr 3 09:31:55 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E0A63AA1B5; Tue, 24 Feb 2026 19:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771960575; cv=none; b=cetw5XZGQvgbAV2QCFE4RAb423HgwyjVzDsMM/kuRkGpHvuiHZjweAycUBlv8Dxrut/p1Ll2T/vvZEcsReBPmD+9B82qg8tuh+cbhjUyooCwrCVtU5wS4+Q8MAVJnYPkuzsBW4/XUMN9qVz/McOZnsIK8xqxKBDQ5WL2JCevIt8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771960575; c=relaxed/simple; bh=GNR5y1jtsQHUa1hbRRRrnxXYag6TtwuZRR6bHbrXcMo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=G00Zg52lnd+ArdEbwNIrLUfw2f5taXeGSSfyryaHA/b0ZS+zmGtUzzbQ35scPw0FMbYl2FKgszU2DKDCE8Ah8/rpptDFiTsUxXU5JjpflgDUOBRYVkDexy8Obc8cqZ4QdNCGTXwvnP8HfeVPn/i8drW9WaUjzTRw+/nM3BvOqY8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=bBd2C17M; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="bBd2C17M" Received: from [127.0.0.1] (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 412C7264BB; Tue, 24 Feb 2026 20:16:13 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id vUyW9qIi-xKW; Tue, 24 Feb 2026 20:16:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1771960572; bh=GNR5y1jtsQHUa1hbRRRrnxXYag6TtwuZRR6bHbrXcMo=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=bBd2C17MHJkiIMCv0RTvrQIHsPRVi7eBgsvXVk6SF2QVrQh7OvQepFZbEohN5/jBb UWspsLdXOudWs1qT12EVTxUNWgRy6a+dchybD42HKK8rBRXn+6AceZVteCk/3fRP8s bAtdR3libd6O7w5K2cic6jHEQrI6csjJ5GIxsQZ4S/rUWAMDJJGh/YdRPoIyQYfMfb 5dJrznp1da1cT3AcLKFdZsq9jOnBgerhl/qtfxnsOhE3/h8dFhCyOCV+Rr21lllWwm u5mVLjpFb1FC8dgRBKMXXQxISF1G16xMbhrb970FvI6GMfG0nXnwXNcMDuaqBEILUh H1wJ884JhclZg== From: Kaustabh Chakraborty Date: Wed, 25 Feb 2026 00:45:10 +0530 Subject: [PATCH v3 08/13] mfd: sec: resolve PMIC revision in S2MU005 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260225-s2mu005-pmic-v3-8-b4afee947603@disroot.org> References: <20260225-s2mu005-pmic-v3-0-b4afee947603@disroot.org> In-Reply-To: <20260225-s2mu005-pmic-v3-0-b4afee947603@disroot.org> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , =?utf-8?q?Andr=C3=A9_Draszik?= , Alexandre Belloni , Jonathan Corbet , Shuah Khan , Nam Tran Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org, Kaustabh Chakraborty In devices other than S2MPG1X, the revision can be retrieved from the first register of the PMIC regmap. In S2MU005 however, the location is in offset 0x73. Introduce a switch-case block to allow selecting the REG_ID register. S2MU005 also has a field mask for the revision. Apply it using FIELD_GET() and get the extracted value. Signed-off-by: Kaustabh Chakraborty --- drivers/mfd/sec-common.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c index b3268516bf75e..230bee16d0690 100644 --- a/drivers/mfd/sec-common.c +++ b/drivers/mfd/sec-common.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -119,20 +120,27 @@ static const struct mfd_cell s2mu005_devs[] =3D { =20 static void sec_pmic_dump_rev(struct sec_pmic_dev *sec_pmic) { - unsigned int val; + unsigned int reg, mask, val; =20 - /* For s2mpg1x, the revision is in a different regmap */ switch (sec_pmic->device_type) { case S2MPG10: case S2MPG11: + /* For s2mpg1x, the revision is in a different regmap */ return; - default: + case S2MU005: + reg =3D S2MU005_REG_ID; + mask =3D S2MU005_ID_MASK; break; + default: + /* For other device types, REG_ID is always the first register. */ + reg =3D S2MPS11_REG_ID; + mask =3D ~0; } =20 - /* For each device type, the REG_ID is always the first register */ - if (!regmap_read(sec_pmic->regmap_pmic, S2MPS11_REG_ID, &val)) + if (!regmap_read(sec_pmic->regmap_pmic, reg, &val)) { + val =3D FIELD_GET(S2MU005_ID_MASK, val); dev_dbg(sec_pmic->dev, "Revision: 0x%x\n", val); + } } =20 static void sec_pmic_configure(struct sec_pmic_dev *sec_pmic) --=20 2.52.0