From nobody Tue Apr 7 12:20:32 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CC573D4103 for ; Wed, 25 Feb 2026 14:49:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772030948; cv=none; b=nhJ5ZNU/ux/X3zCrjo2U7wKuPogYO8uz50PNmvNRQvYwH5tQEE5j2UizbrIBmVCaVex/LMsb0snTyS1tuCPYIMJ8tRK6XL+oecFgwmGop0pTzYULo+u3R30bgisIrCgCxhtVYLYDOvUt6Ewsotj4PGw3LYa73dWEtI3cEAlORrE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772030948; c=relaxed/simple; bh=y75xazQSpSSksYn9QYcuRHGrtuGmpnatk6i9r44nA/I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=d0qKUUPdhmW2VYievACM0+JlbSdg1WAAce7OXTALhJ132mzKAz3Mv25XibmxOpErK8/R4KoAl4fm9P2a/gAYIvu/cWICHVkFcoS1M4Nq/z3tZrWmMxxb/iAODrd/x29Poqp3Ndgx3hy6h6XAv9KwVHmvDg5OiRUrmk1nuF1RnqI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O3gNcfVG; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O3gNcfVG" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c6e72d7a4d7so4285677a12.0 for ; Wed, 25 Feb 2026 06:49:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772030943; x=1772635743; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=MGCZKVS6wkPqnmAwoV6u7sPkAZjbMERA2jaYnvNC/3U=; b=O3gNcfVGbTNzeGsTnmWIYWxP3F1S90JV3BaBK08K9qmF52allswIZ6oeI27sPi2CxD o0iIKeWUm6wsudyqLUu4v40Ei6OazDubzyelvCjhiCaLK/pMRjQgyBQ4jhfnaYFuCBMI OuD/3dIDPV3vSVSDGxwbNSp1CO19ibGsd5LBZE3UC2uVhQ53MVwqKhiW1ihkOAX0D9uh pQuJfocgckwwyWuG9NqgtJebS1pegBtCV/oLn0BtaoMqGVAINrxxUnLw/bGYPPEWxe5T 29BxRvwrSFwGLDKaW7XNckOQGSX8GfQbicoz3PzlpnbHHr0nRAXMssYlAQ8fjhpgio6t BhvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772030943; x=1772635743; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MGCZKVS6wkPqnmAwoV6u7sPkAZjbMERA2jaYnvNC/3U=; b=v7zAe8q+x7YY+dBndfNEmwBBA0JoZ89Ldp5A40YXOPN1YjrkTEwy+WPMxQTPxd1DBF 7LwrZabfCQd6sKKv5qCwFa9NxJUz+rmDnclDhYvliCgxfr2s1zUImtHxaSzc59P1hJX7 BChNLwC4isGSwkIWDvbwqwmN9YQpRG33SqN9bn4F9tGfzVnmLqZhHApbhjpmRQdoWxEv XZDjnQGsOIb4fdf3td/t6SKI8S1zGrW2vTcR8pNHY06oxDQGOAhJZUq2DW2+VOZC9qDh kTb5Bw8I/a79C9ScEmaowkeGaxqIlSCvwPKcrvfq6D8bseqvs9VvlrsWsAn2dTEx8qiF j2gw== X-Forwarded-Encrypted: i=1; AJvYcCWCuC8HPUbu8Thwu39NecOGC6IsdDuXUCm5qDo5/q5ZguZaUalTPeIihEjijBCd4UdwIBSMEz5IwS/Dq+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzszWA2xEXkTD/xpnPfKJsgPKbJprl/W9/NOwhK8FhR3fwoAKk2 7TN8ppPZD5TTRp8dz0XO72r8e2FB13OhE+oN8dyNcigGw+ZbSRkX78Nu X-Gm-Gg: ATEYQzy18u/P6Kbr26iE5boaFwrp3iRrAoxpIxsBpI9dTY4EewqhmXJp9w0c+hsL4dX waXfHmdN4ntiwZE+/avNoRZu0zZvkDibHMadchAIsNI4tRtcjDc84nA4odxYfZrGqAe08eAFKFS ZID/YLyju9/0k3p2fQA2eyGitgEW1RxMABYVQ2AqlPJ11oExsWRfmlVSVH5txrW9carIPzAam0H 5pMOiGdR8zph+QegUv2zbpEYUKA4ePpehNhAQG5w5yoefVmY7lxH7pABBbsvop+znPa80RNCRwV oKe+OOCyRnjOg0uVYbehaEKqk6PrECmo7YfodUaxPgX7w7vv0lhPhtPkZDm9jBUjuZf/0s0PAXC dkfgIoyeKfaUs7grcJm3ZTfGkkFZ57Y+D2ZmJTmnLuf4q8fTNW3NqNXfg64hMQKIQ3gc2lVGLDg rQ/jWn6Km8OPpbqF+hNm8vd3WAV4fXVKT+c/mI X-Received: by 2002:a17:902:f68a:b0:2a9:2942:e15d with SMTP id d9443c01a7336-2ad743e2f1fmr159206845ad.5.1772030942982; Wed, 25 Feb 2026 06:49:02 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9009:3f2:55d9:d867:54ea:d951]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-826dd692a54sm14438355b3a.21.2026.02.25.06.48.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 06:49:02 -0800 (PST) From: Felix Gu Date: Wed, 25 Feb 2026 22:48:57 +0800 Subject: [PATCH v2] iio: dac: mcp47feb02: Fix mutex used before initialization Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260225-mcp47feb02-v2-1-4792dc3942d9@gmail.com> X-B4-Tracking: v=1; b=H4sIANgLn2kC/23MQQ7CIBCF4as0sxYDiLa68h6miw4M7SS2NGCIp uHuYtcu/5e8b4NEkSnBrdkgUubEYamhDw3YaVhGEuxqg5b6IrU+idmupvWEUguSSE61pK4dQj2 skTy/d+zR1544vUL87HZWv/Uvk5VQwijfSXSIaM73cR74ebRhhr6U8gWK6i3ypAAAAA== X-Change-ID: 20260223-mcp47feb02-e0bed17e198b To: Ariana Lazar , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772030939; l=1261; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=y75xazQSpSSksYn9QYcuRHGrtuGmpnatk6i9r44nA/I=; b=aYnQbCZO7YV825Ix6ADfbBTnqLhwMhXrii+LV87JbAJ7ZGSYDi2WW53CfbTqN/19/RjDInSJZ yGb7n//tGPwC4h8PGWil8Nb2Lx939yrlTSQYT3BRDoD78QA/ML0qVLq X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The mcp47feb02_parse_fw() function uses data->lock, but the mutex was initialized after this function in probe path. Since mcp47feb02_parse_fw() is only called from probe(), remove the lock. Fixes: bf394cc80369 ("iio: dac: adding support for Microchip MCP47FEB02") Signed-off-by: Felix Gu --- Changes in v2: - Remove the lock in mcp47feb02_parse_fw() suggested by Nuno S=C3=A1. - Link to v1: https://lore.kernel.org/r/20260223-mcp47feb02-v1-1-41f80bdbbb= 45@gmail.com --- drivers/iio/dac/mcp47feb02.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/iio/dac/mcp47feb02.c b/drivers/iio/dac/mcp47feb02.c index b218f0c3a0bd..08fb85359697 100644 --- a/drivers/iio/dac/mcp47feb02.c +++ b/drivers/iio/dac/mcp47feb02.c @@ -955,8 +955,6 @@ static int mcp47feb02_parse_fw(struct iio_dev *indio_de= v, u32 num_channels; u8 chan_idx =3D 0; =20 - guard(mutex)(&data->lock); - num_channels =3D device_get_child_node_count(dev); if (num_channels > chip_features->phys_channels) return dev_err_probe(dev, -EINVAL, "More channels than the chip supports= \n"); --- base-commit: d4906ae14a5f136ceb671bb14cedbf13fa560da6 change-id: 20260223-mcp47feb02-e0bed17e198b Best regards, --=20 Felix Gu