From nobody Tue Apr 7 14:04:56 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3E493191BB; Wed, 25 Feb 2026 22:07:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772057246; cv=none; b=h86SxET8qZBVot+xCoKKmm3J78mmmfk1UzpQHnyg+ULYAPpGLn6cwgAGbv/Z5Q9/BU+biFIPfL77o9v8W7KfZQGDzD+E/en9OnNtBDEAnCg1P6PbVyrmiqYY148etgRzP+GvBs3Xshvn8v4VKDStXJPhv2nMZGOH0CzBEHshig8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772057246; c=relaxed/simple; bh=ZVwDhq7sE+uH86Xby6Jav0733rfjRoZgwhfDqk+hdpY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=jnkXrCKuZHiZw+x8ZLnCocByFLsXKXUoiYM/4VFkf0mg92ALiip+JXybq04DICnITzmEXS+AH/z5N/jyEtXkORETBc52zMKowC1gb8cXzHG1utvFP8oqKzybgLNVfqwD/pT/Olc86N2nppdepHlilJMdaSNg8YRD9QGwffKdMEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DtIMGz/r; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DtIMGz/r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 401BEC116D0; Wed, 25 Feb 2026 22:07:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772057246; bh=ZVwDhq7sE+uH86Xby6Jav0733rfjRoZgwhfDqk+hdpY=; h=From:Date:Subject:To:Cc:From; b=DtIMGz/rjbh2EwrTBRlKgfiqmFUw4LbG+mETGxnrGWbk9P+QTxldgQAx8NzBaxyUw 360Mwglc4EoTf3MREGMLO6SaTB5jKXYt0xS7fCOgzuJBxzWHvdHmXQAUpAKF59b3eL Agam1q1z3vupxEESAP3IxzDjjiNtiJE91wwDcSei/coWZVBqv8k18g8XcDLkOduzw+ 5/dcaZ5P6XEgQpqbvXiguUbIkq79vlNCMsPfX96epD2bO8UcKwGkAtYC8Wkdu8D2Ap psyWJaRGgKzeQY7q/pvp/pJxYOwMWQKAsuApx85Mtci7zdxWkh+bTtabJA50ahn82n Z5rK8N6tDJUGQ== From: Nathan Chancellor Date: Wed, 25 Feb 2026 15:07:17 -0700 Subject: [PATCH] genksyms: Fix parsing a declarator with a preceding attribute Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260225-genksyms-fix-attribute-declarator-v1-1-1b21478663fb@kernel.org> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXNywrCQAyF4VcpWRuoUy3oq4iLzEys8TKVJBWl9 N0ddfnB4T8zGKuwwb6ZQfkpJmOpWK8aSGcqA6Pkaght6NsQNjhwudr7bniSF5K7SpycMXO6kZK PirvY5b6LtE1EUDsP5br9fRyOf9sUL5z8G4Zl+QDQjt9zhQAAAA== X-Change-ID: 20260224-genksyms-fix-attribute-declarator-9b3d63ba5caa To: Nathan Chancellor , Nicolas Schier Cc: Nick Desaulniers , Bill Wendling , Justin Stitt , Sun Jian , Florian Westphal , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=2642; i=nathan@kernel.org; h=from:subject:message-id; bh=ZVwDhq7sE+uH86Xby6Jav0733rfjRoZgwhfDqk+hdpY=; b=owGbwMvMwCUmm602sfCA1DTG02pJDJnzi2aXZ74NvvbH6R7fKn2VEPt1e5UWMs5lW1pr6iIk1 7pbbL1eRykLgxgXg6yYIkv1Y9XjhoZzzjLeODUJZg4rE8gQBi5OAZgIz0tGhmWu+212JYY27fro zXD7eWrT/xXXTc9v+PT7csjDfKe4AitGhulP3q0xD0g2vbbtttbOe0x/ioK0QqRFzlnkuAZzP6v aww8A X-Developer-Key: i=nathan@kernel.org; a=openpgp; fpr=2437CB76E544CB6AB3D9DFD399739260CB6CB716 After commit 07919126ecfc ("netfilter: annotate NAT helper hook pointers with __rcu"), genksyms fails to parse the __rcu annotation when building with CONFIG_DEBUG_INFO_BTF=3Dy, CONFIG_PAHOLE_HAS_BTF_TAG=3Dy, and a version of clang that supports btf_type_tag. $ clang --version | head -1 ClangBuiltLinux clang version 22.1.0 (https://github.com/llvm/llvm-projec= t.git 4434dabb69916856b824f68a64b029c67175e532) $ cat kernel/configs/repro.config CONFIG_BPF_SYSCALL=3Dy CONFIG_MODVERSIONS=3Dy # CONFIG_DEBUG_INFO_NONE is not set CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=3Dy CONFIG_DEBUG_INFO_BTF=3Dy $ make -skj"$(nproc)" ARCH=3Dx86_64 LLVM=3D1 mrproper defconfig repro.con= fig all WARNING: modpost: EXPORT symbol "nf_nat_ftp_hook" [vmlinux] version gener= ation failed, symbol will not be versioned. ... WARNING: modpost: EXPORT symbol "nf_nat_irc_hook" [vmlinux] version gener= ation failed, symbol will not be versioned. ... genksyms falls over parsing the __rcu attribute in the declarator: # Kernel reproducer $ make -skj"$(nproc)" ARCH=3Dx86_64 KCFLAGS=3D-D__GENKSYMS__ LLVM=3D1 net= /netfilter/nf_conntrack_ftp.i $ scripts/genksyms/genksyms -w :2: syntax error Optionally allow an attribute to precede a declarator to resolve this error and properly generate symbol versions. Fixes: 07919126ecfc ("netfilter: annotate NAT helper hook pointers with __r= cu") Signed-off-by: Nathan Chancellor Reviewed-by: Nicolas Schier Tested-by: Nicolas Schier --- I plan to take this via the Kbuild tree for 7.0. --- scripts/genksyms/parse.y | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/genksyms/parse.y b/scripts/genksyms/parse.y index efdcf07c4eb6..cabcd146f3aa 100644 --- a/scripts/genksyms/parse.y +++ b/scripts/genksyms/parse.y @@ -325,8 +325,8 @@ direct_declarator: { $$ =3D $4; } | direct_declarator BRACKET_PHRASE { $$ =3D $2; } - | '(' declarator ')' - { $$ =3D $3; } + | '(' attribute_opt declarator ')' + { $$ =3D $4; } ; =20 /* Nested declarators differ from regular declarators in that they do --- base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f change-id: 20260224-genksyms-fix-attribute-declarator-9b3d63ba5caa Best regards, -- =20 Nathan Chancellor