From nobody Tue Apr 7 12:38:51 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B7952F60A7 for ; Wed, 25 Feb 2026 10:12:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772014359; cv=none; b=NcisXeqvh7Tibsb1tsQhRaybD6y3kSCEPzJ4zj7G+2CnqYDAz/xq/ZG+67y0G4o/xbcMrxS/Mfo0xm+RE/LGns/Ul/JPKsA6ka8DueZqiOEdrzkkGD2S/Uzkd1w37+9Hf0YBqXjpmhARqzLsujGXHGWs6WYxTFv1M7Tc1N1xdJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772014359; c=relaxed/simple; bh=Y22JRh9xvQfJncGH7gL+X+J/7Dt0gtPhEvqzsi3dp5c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=aB/8uUesUIJiMYwP10jcp/a2OMNY5fanExsFCYCvR1viqxHY9Q0e4/b2nWJWT2hyY7COdK2LwjxLTNSLs1WmMA21owRVs3s9sTR5AcyIusjUxSAS3ij66WMphzzBF7gEd8ie3rrbrCc5EnIGSNPjsLiw3jhrSsIkCupWjMRLPrI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Pb9Dig/0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=B6VQ4sho; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Pb9Dig/0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="B6VQ4sho" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61P9S3YG3057168 for ; Wed, 25 Feb 2026 10:12:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=sZiX6+x00Prlmosf5CSqBN 8ltuHXD+PUom5YlTd56Cw=; b=Pb9Dig/0Rl1g0zOx+eNcao7++MrN2j9aGpqt96 mwZP3zNonSLuwgxJy2RTVqwtckwMNZqjqpsDMgPMNtUZF9w7WJW94TkOVizP/3gu e/5tXQN7OHVbw6j5sJtj2rbUtGwZaUTb4ksUtGu8K62vpsqLZ9ELoRFT18FK/WPV qKRqX+zqL4m9KbbR383cnFTK5BlP9FrGY5KwFEvZmnVDM/e5GirgE0OWTxoSt2/C vHbqFHCZnJzNPStRpZYEuXwoz8FeY2zzYZciXdVOdKQ3v8zzM50nGnpoOYrHGBeb oPXBjmHgB3RhmjGev+09T9gHlQ76JTVJoNx/RqRWe4ZDai/Q== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4chx39g90b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Feb 2026 10:12:37 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-899b4ce513cso52262826d6.3 for ; Wed, 25 Feb 2026 02:12:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772014356; x=1772619156; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=sZiX6+x00Prlmosf5CSqBN8ltuHXD+PUom5YlTd56Cw=; b=B6VQ4shoRmWDPJS/FaKZB+WABYAGN7bpK4QKFml/OyxULtO3BQkN9hhYuYZm3+6u7V 0GmMaIYK+JZ1z2BUt6mPe9mlhsr0Wt2g5y8C/9Cv8UWapD7pNkBbPzeiAjF8r6X5N5Ii lUUOMUf7/v0K5wOV12NRZe30UYxbKP7xi7toSH5DGmMZkvDkS59NBTmdqaJAZs0Gk9QW gYh/GWITimRlwTzQHzNXcOQNMXAcI3q30utw8wqt4xvQN0swbiWtSnzeoZ/r2LMFsF3z mv03SAElg4fK+o5JXOZRc6Y77EGukAXsvbB0z8itrWBhn6G9gjcjX7IGeagu7jA2CJSv BpsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772014356; x=1772619156; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sZiX6+x00Prlmosf5CSqBN8ltuHXD+PUom5YlTd56Cw=; b=GuEdX/E/cnu+i6Adwz+bwLKxlKIy8hWTA037bgDzVKQ95Ua69S7PFWy/lO740s8iyG haZYIZjbNYEOtkbRKQCFC+mVJQMPh6sg30Nqcx4vJEKStkvgRM3qAMg1bJ9EbeKwDgU2 rBhUiP6M2v9LbXx9V5Q2Y75so9WWsSHt8rIe8thsG4FiycUI0B0uEhP3y59cGW08rlMR tSaC3DQLhRgAAH23Tewcn5eCl+gYq9PmIhNOuxCgdV1y5IlBiiHpY9GF2yGX87+t/Hji 7eUFyoI9lBHi6UaFqEz4ABXWRnTj7e3ZXG91+xchV1TiJa9n56djBXtmpWPrhz5wXC1X +7pw== X-Forwarded-Encrypted: i=1; AJvYcCU0cA/r8Pi35udMGmEA/arIrjbNtX4b0ngrWCAMM39GznfcdmGauguP0Yi6/ZTVtfZqFt8lWrG9Q0JHtA0=@vger.kernel.org X-Gm-Message-State: AOJu0YxMDDvl1HMVRCkYVm+aJlvk/OtF1gt8YuJNHX0UJ2qVqkirjkdx G8NqEPj3tIwMGS/2YrYr0uwK0NPhX82dcLmLVCCKK6Dh/UMim22FZBafpTya4g83AQ0N7YUkQxC B3TviqwqpBx0xdKBIDTW4Pu6LhhSYnnxqOzEwOVcmjXo305BXZshU2KdnGO+TeaAZH70= X-Gm-Gg: ATEYQzyAQSOzolF2UOSu3swrvjKTHAFmFTW7ZUrMrHdu5tqanOGy1gZOpDJPQeZagJ6 L+txcaCkL6r90aizFngI7VVU+wkEWs/1dHgXT3FHDtNZApw4Gb1Ykh9czzFkFq5ryZ8SGSOnK0b QG0XfTVZn+oN+7v9u+fmteE9KWjwh5qXEQVTaiEskXG1/Q38SwE4C8q1jM1lHk0tNE1+BA57cEP pLmQOtImUBvmMiNGL6XG8rC/CgfH0njwVoaY6ox3XgYMWs4aFSI4xcdYflSCtWEo9BEUXiyUWa2 is+YffD+IT+xK5di/jCvqgMbXVKE19fh9DX+6F71PRFhHaGZKVhKV2oKu3UH6RmwseVE1AMaZ+4 zNAmRMs6kvHRt0bLev6vLf/0uSdFZqj/lna27uuzI+R3U7GAytC0= X-Received: by 2002:a05:620a:44c3:b0:8cb:4543:c5a8 with SMTP id af79cd13be357-8cb8c9fad83mr1971177185a.21.1772014356511; Wed, 25 Feb 2026 02:12:36 -0800 (PST) X-Received: by 2002:a05:620a:44c3:b0:8cb:4543:c5a8 with SMTP id af79cd13be357-8cb8c9fad83mr1971172885a.21.1772014355971; Wed, 25 Feb 2026 02:12:35 -0800 (PST) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:44ca:6a2e:7fc:1024]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d5463dsm30382107f8f.34.2026.02.25.02.12.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 02:12:35 -0800 (PST) From: Bartosz Golaszewski Date: Wed, 25 Feb 2026 11:12:25 +0100 Subject: [PATCH v3] gpiolib: match secondary fwnode too in gpio_device_find_by_fwnode() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260225-device-match-secondary-fwnode-v3-1-a7152054135a@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAAnLnmkC/43NQQ7CIBAF0KsY1tIARWpdeQ/jgg5TS2JBoaJN0 7tLu3JhoptJ/uTn/YlEDBYjOWwmEjDZaL3LodxuCHTaXZBakzMRTCgmeE1NLgHSXg/Q0YjgndF hpO3TeYNUAnBVIsgKkWTjFrC1r9U/nXPubBx8GNe5xJfvv3LilFGtJO6NrHaygaOPsbg/9BV83 xf5kGUgiQ9UlL9QkdFaKWAMakRsvqDzPL8B7tKUHiYBAAA= X-Change-ID: 20260219-device-match-secondary-fwnode-4cc163ec47ee To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown Cc: driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@kernel.org, linux-acpi@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2381; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=Y22JRh9xvQfJncGH7gL+X+J/7Dt0gtPhEvqzsi3dp5c=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBpnssO1FWU86yfB6AvLyJgHK+Yze00jlHC3FlRh WgPHa+9Oi+JAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaZ7LDgAKCRAFnS7L/zaE w5lvD/9yAI5DHGZ/FJImETfgbSKTxLD3sxZaQ1Oc2FzDPzkUpOvD8pQNgFoIegRVODiLCMMWJOE 0Ohz/IYd6IlVs6yAM1DUxRWJN5IyLghlqlFGspHTdAIKTPYHMooT1TKLGQ4Q+T+XM2lDyaWisij xOvbyjuYZBEf//oMlVysPN2JfhOO094nevRGtt9CmYsmzKrg15Ua12xcuMFNzXbuVmPqdDDfh4f fro2wxPaktgRmQQtIORDr5bquasCx9ZSIp1Va6CJFmXkngp616A7Bqv+FeNRO3GSK1yx7ZSRFN9 5RdgTF8+AuVUTsO8kPQUvOwBgY4PdXCnkqzln/3qbWyB3Cm8472KGzW6Tpelp3In2jghXxAjaQt HrC8N7dM3r3repoLQpcHpXByVlwFXKDwMiYXO3k+3g8Up1Dpgz/2UyEt5hkkVFJyp31LjjaoPkR GvoJZt0ldhXrocSLN67fC1D1LtyfFZr5RWunoi2+gZXIGe9BcSBDbpGM6Of/htih1/3W8owsD1G eFhywPLvub7LFMwoPL/FBnaT4gsVcPYF2WFpolGzUjMfu23V0J8E42nLGoCj2HEEuxOiUNcVDlP JOAwbsYjkQi1a8YBcgUj1Gtrt3YeJvhsDmj4xHioybF7cFIMMJOp3E/sZ97TaGK+XTGaux9UIZs rl1iAEdc/hbcWxw== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI1MDA5OSBTYWx0ZWRfX8jra0EbSqcvS NT9u+N2cIYPqNAF8iDRHH0rsfFTzPAGPk+VJi/8ryBmpzzoyK5rR+01xiPLCFK1bfkR1/LXF9Rj c8nx+vmYpU6mBaEUivsoO5Shy6FBAOEH124dTZDxRC0r5eTxXhPvPwMy0mKA4pUSqG5Ts68Sj6+ cDMJi/oAb+h7w+ALI5NZmtgK9rlJvyJ0h0DZUxNko6HH3as9cO9fuumSDgq1CvWZ+KkSAajpKyB EEoEATfWga9X14p7FIZOoMehDScvGMAWPx7cycSdjz6T0kmQazzARVouCg/wnftcEea40a8j2hU ela057uI2KgnhpK5y7p61Lb+S9z0nFI5x6rVjBQYvdr7B9rCk+dI6/KP6fHTHRRvHoF4Q4idOXy GuPkhX488B5cwuLuIyLGbvlSpaiHQYXHnNwV6w3abaGE9ddrvFLDP+NKU+WBFdvBKkRc3Ya74po oNTZOwXeFgWDI6o+/Ew== X-Authority-Analysis: v=2.4 cv=FvoIPmrq c=1 sm=1 tr=0 ts=699ecb15 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=1XWaLZrsAAAA:8 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=GosmCm27k2yXtJg_9XwA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-GUID: y32KKi9MAfrYfk-9-I1gahSqS122p-va X-Proofpoint-ORIG-GUID: y32KKi9MAfrYfk-9-I1gahSqS122p-va X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-24_03,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602250099 In GPIOLIB, during fwnode lookup, after having resolved the consumer's reference to a specific fwnode, we only match it against the primary node of the controllers. Let's extend that to also the secondary node by reworking gpio_chip_match_by_fwnode() Suggested-by: Dmitry Torokhov Reviewed-by: Danilo Krummrich Reviewed-by: Rafael J. Wysocki (Intel) Reviewed-by: Linus Walleij Signed-off-by: Bartosz Golaszewski --- Link: https://lore.kernel.org/all/aZUIFiOYt6GOlDQx@google.com/ --- Changes in v3: - Remove the controversial patch 1/2 in favor of hand-coding its functionality in patch 2/2 - Link to v2: https://patch.msgid.link/20260223-device-match-secondary-fwno= de-v2-0-966c00c9eeeb@oss.qualcomm.com Changes in v2: - Fold the code initially put into driver code into GPIOLIB as advised by Rafael - Rework the logic as suggested by Andy - To that end: make fwnode_is_primary() public - Link to v1: https://patch.msgid.link/20260219-device-match-secondary-fwno= de-v1-0-a64e8d4754bc@oss.qualcomm.com --- drivers/gpio/gpiolib.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index c52200eaaaff82b12f22dd1ee8459bdd8ec10d81..0182603de368f2125baf174fcf5= f1e893917c154 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -1395,7 +1396,16 @@ EXPORT_SYMBOL_GPL(gpio_device_find_by_label); =20 static int gpio_chip_match_by_fwnode(struct gpio_chip *gc, const void *fwn= ode) { - return device_match_fwnode(&gc->gpiodev->dev, fwnode); + struct device *dev =3D &gc->gpiodev->dev; + struct fwnode_handle *node =3D dev_fwnode(dev); + + if (IS_ERR(fwnode)) + return 0; + + if (device_match_fwnode(dev, fwnode)) + return 1; + + return node && !IS_ERR(node->secondary) && node->secondary =3D=3D fwnode; } =20 /** --- base-commit: 50f68cc7be0a2cbf54d8f6aaf17df32fb01acc3f change-id: 20260219-device-match-secondary-fwnode-4cc163ec47ee Best regards, --=20 Bartosz Golaszewski