From nobody Fri Apr 17 00:18:28 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E9453612F9 for ; Tue, 24 Feb 2026 23:14:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771974879; cv=none; b=dOdpgnVhRUT7VRDM5/Suh0wHyOgdHbbLJNi3d7zc0cYS8wRreKIlLQUi1OPvam+wvQ/ECT8GaKhYNDAhBk3lh+8KMmdbZma8GZ42w0DDaarpWQoO4pYuK3jom2Sl3Hefe6yJRTSXsZBk9DmXwj2gxnQkH5SRJgBhjezHDbdyLkU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771974879; c=relaxed/simple; bh=ts4y1LSDqSm8xzbqqKhGJ+vKB4CEPxtkpC8uTT/eNoc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=LxnVcN2PG1DsFABq9Mv9qBjene0QvjdDJZqReKal8+/PhSCKuasbh9YklZy7FPfXTsfmDlbbUbWUILyYpzY0E0yWty1a2xXgw0xtW/qxpQJZMdNx+U+aioT5yrzTjsy27kwQjtO9iZ/tNPHGCjNe6wfiIykBEDbVdYkXPb4rnNU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IvcP+ZFS; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IvcP+ZFS" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-358ed696623so492537a91.0 for ; Tue, 24 Feb 2026 15:14:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771974878; x=1772579678; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=p34qi6n0TBfPz0KJzPBXeXgql7kmsqZRDFsgeZgUqEs=; b=IvcP+ZFSmcpahoYCH9GQP/MZP8I5hcDdWnGooiZoLNeoXYKhhI1gQM6/TXCl+Ttqxl iyFJjXhqqQPDZtCmNHmzG56gx6+opOpTd+iuL177yc442N2+Q7SPkIDOxHwds+7z28TQ 4PzvA/ZI3p0loT1nEzlJcQOkm8HAgvjwctdqJWNqb0//TAYBkaMF7oOFG1U55m4WTCEn a9G99PJ5JnETbBmqFmS7o1t2iHlNZXiFpYikfjQ9iVRP4xKU5rxqxtMyZncp0n1/u2XP k298we+eZfdFNIAln80yH5woOZhhtU6duAmuLbO0IrHQWHwnzKwWgFeQpLBgB8QnZdcr dBXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771974878; x=1772579678; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p34qi6n0TBfPz0KJzPBXeXgql7kmsqZRDFsgeZgUqEs=; b=tI/wqVSBd3O5HsAgqvcofXVi1Qbq+IWQsgMOXk+4yWSpHM0NBv9RNsJQg9Q4lZVnRQ SE4tTjdBPZySZ0ZPz3AEdTnnH+4I2IdjHoi8cVINRR4cY8CA4ZpaxCDj6E0XWQdl0qpG nS62YTYFTBsKiBuTT9SPPzT726S7+2J6Xyej6HAU6YnYi8X3RN61QVamt9LnlBiDD+Qz j1Be5KRRI4lRH5bf6TzCaTR1Poiv1IWwvkbPc2ySlCt1qqeoUwhTuM4aHldDkLKNUht8 AtALCNkeaRc9WS4zXjXaTflOQbEdgx8ZpZ7Wmnu3hPgaPJF9qBEMGLpC99P12tAhWtlu z8eg== X-Forwarded-Encrypted: i=1; AJvYcCVBPXPRGYqKbFbCTiCk1nr8eXa8vfqrkIqPukPl09KtjXXo73RkcWVpl8uSruzNnkG99NG2XgIXA8W9CIc=@vger.kernel.org X-Gm-Message-State: AOJu0YwfJKk42zX81x/p3C9kX+VPpMbTwKOvNSp9VYhDHWJdQPeFfjVD osDydCglOkHCXeiJ4oCCn74A7lE6bxtiJ7FY06ScRUm4dAY90+1vlXN/ X-Gm-Gg: ATEYQzwxeXrjkBwpLApLjLckbLxUmeDRM6Bg9gXopGYcmSrfsdV3lgqs35Dv95+yrHZ K3LtorNde8ZumdswZU/pk8Eybq407aDTDt1Dw3gl5sC/lIGDJ0Ikz+th/Z4vvlbUmQ6zBtK+Qya YHBeAusq76wGN8J3ynW+gAitxBOyGz0Ekp3oGCgoy6cus8bV9HqkXb9Gs2X3AxNgYrf3Cgd1rrw EidXLMozZSAU4vbnVG9WbBiQ7T+cDZQNcskEgiy7pbEjXLzUueTZ3uBMnqYOYJugTchFUGpIrR9 KIShuJ9HHj49jdRPWJ5lC6NE9bE6pDzPhiUvof9xrxpFZn3NpoNlJNAMy1RFRtu0W5C9Egwhzl4 zmKllA4NYpIBcyRT0dWvzB3M738MQvuurCYN0QLOWodZT9s3gpevOC2B0oX0butVaAso/QC+ozE JyFGimQea9MuNMtEIYYwaRNkJ2aAgNQl2ib6V/KvEWd3+3fyhgPuEO8IR6evcSQooEDVo= X-Received: by 2002:a17:90b:5847:b0:358:ee2d:df2d with SMTP id 98e67ed59e1d1-3590f069d87mr298702a91.8.1771974877587; Tue, 24 Feb 2026 15:14:37 -0800 (PST) Received: from deepanshu.. ([103.171.98.78]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70b72434e3sm11917667a12.18.2026.02.24.15.14.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 15:14:37 -0800 (PST) From: Deepanshu Kartikey To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Deepanshu Kartikey , syzbot+fb32afec111a7d61b939@syzkaller.appspotmail.com Subject: [PATCH] ext4: add bounds check in ext4_xattr_ibody_get() to prevent out-of-bounds access Date: Wed, 25 Feb 2026 04:44:29 +0530 Message-Id: <20260224231429.31361-1-kartikey406@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When mounting a corrupted ext4 filesystem, the inode's i_extra_isize can be set to a value that leaves insufficient space in the inode for the inline xattr header and entries. While ext4_iget() validates that i_extra_isize fits within the inode size, it does not account for the additional sizeof(ext4_xattr_ibody_header) needed by IHDR/IFIRST. This results in IFIRST(header) pointing at or beyond ITAIL(raw_inode), leaving no room for even the 4-byte terminator entry. When xattr_find_entry() is subsequently called, IS_LAST_ENTRY() reads 4 bytes from this out-of-bounds pointer, triggering a use-after-free. For example, with EXT4_INODE_SIZE=3D256 and i_extra_isize=3D124: - ext4_iget() check: 128 + 124 =3D 252 <=3D 256, passes - IFIRST =3D offset 252 + 4 (xattr header) =3D 256 - ITAIL =3D 256 - IS_LAST_ENTRY() reads 4 bytes at offset 256, past the inode buffer Fix this by validating in ext4_xattr_ibody_get() that there is enough space between IFIRST(header) and ITAIL for at least a 4-byte read before calling xattr_find_entry(). Return -EFSCORRUPTED if the inline xattr region is too small. Reported-by: syzbot+fb32afec111a7d61b939@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3Dfb32afec111a7d61b939 Tested-by: syzbot+fb32afec111a7d61b939@syzkaller.appspotmail.com Signed-off-by: Deepanshu Kartikey --- fs/ext4/xattr.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 7bf9ba19a89d..5080ec44228a 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -652,6 +652,13 @@ ext4_xattr_ibody_get(struct inode *inode, int name_ind= ex, const char *name, header =3D IHDR(inode, raw_inode); end =3D ITAIL(inode, raw_inode); entry =3D IFIRST(header); + + if ((void *)entry + sizeof(__u32) > end) { + EXT4_ERROR_INODE(inode, "inline xattr region overflow"); + error =3D -EFSCORRUPTED; + goto cleanup; + } + error =3D xattr_find_entry(inode, &entry, end, name_index, name, 0); if (error) goto cleanup; --=20 2.34.1