From nobody Fri Apr 17 00:23:51 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012068.outbound.protection.outlook.com [52.101.43.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D28E234D4FA; Tue, 24 Feb 2026 22:53:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973622; cv=fail; b=jjALC8W6sDrvxib0SjTMwAM1F0f+uBulX0+FL3DOjdv2aGu0bWknj/WclZO7mhZmdYk5m05bOI65nt8t1wOTYV0qAyGQ0S7WS3to2gNW0tJY8Mz9eE5XHLdg6jHTQiPXBCrEcqlP5Uai6Td/wUh5wcgrcdC/+aGUkl21tK9DzQQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973622; c=relaxed/simple; bh=uDqLNDhBfacP8I9KD4Sjft86O+uIXahLy/vwm5OvYWc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=tIcCLs0205bvOanLFsw7VajA+K/DuNzKTtfwrJzMBAyfO4m5tCaaWwP++6O9Y7ZBA0OKPJ+cbTB3I+Tw92HgstQGf8bSY2BOj9MgyP6ZwlkfCTspOvj6yVD3+4fZtf6G7vncw2Kj2bn223Ep98AdZINuT/sBJQzDL0CAqBE8tmg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=J4HjSStp; arc=fail smtp.client-ip=52.101.43.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="J4HjSStp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=T/sNX7Z3LB8hlYK8eISNOBXAN+wg8dbQ9ayYJ56XynnrO+5FzyPkcngV3Si/R2bm4/flpdXtN2vTrSXJsTEWJ4OlI3mjolqzfHNb0qiOTl0ZhVWEB0P6+rhAP7crzw9Nbiqe4hgmTqIIV6Z1zpSv4QaCdS5L0wjt9dod43yErA4FczkVtH28MSXhxcWSI2+9WVzSjgthstaTxRPhrWRzdogYQgepMO+Te28U4Xn3dgz/iK2Yhmwtxev/U3uT/HAPYZyR40DaMKrOot+fK/qaJNGIDgoWVyrLiWM2GphDgdNtcIvBZxICFESHoZyZNo/mr4iAknze1gX9y7Ndfnh4qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v8Gf71f1+HF14bhLysIpw4Ntoz2jJyjAr3DBKm3rwow=; b=pNxraH3A2ITuFp0ampU/qwWlvIQoWTjY8RhGNpnkAyrzom757TVVb6ZxockNPcxd2dPMp3GaNx5lkyaQyijaLNpmk35T3535VXwCbEicjUCvbgbL4/YxdDmeVrN1CRt/TTMZrPhd+zLBLXZ2/x9jQyIA3+9tABfTUSaVRb29pXSr2eZu75SntCgxfPMOz65wJhaq8G+7i7YfH7z1tjzqYR85zjCIp2Q5WkTzPuYQagMC5IW/1CH/+HAg0z8aGRfCPn+KTEqeqNw50WsXPL18SsVm2XvVkoe6c6XArC0gUeMzp4KKNuA7Q68Wz42XhcVNVd3fdcAg3652zOF4H1F80Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v8Gf71f1+HF14bhLysIpw4Ntoz2jJyjAr3DBKm3rwow=; b=J4HjSStpg1ATZMLLTKYaju5Df9xxtCyRY2zIgmWHpEETVUaXG5F88WM0VQ7+1RpYNVYHwlQ4nMFAQwik8ibvg/YBoah/xYSJNvokoMamW4sJTsgLLUYsNjV+X0igDo8NkjtxOHsTfsRyKDYwdgjkbaadEV2I0hk8mmwdKwO0HSYRwrZvJVIEuFPdVKS9U8nCH1XZmogETs3a0LpBfl2e1Y1W+7B/WgAQ1zZrkt/J/fYHgOvkco3iNxbrxJim6keIPjrUsZOzf8Z+hP18n+tbTvXYIZSkfoJH6Tsv5MR1x2wcqLQbTmAW0PqLZPQoSxIVYlj8Vsnt+2kTt630gwwKfg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:53:35 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:53:35 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 01/25] gpu: nova-core: Select GPU_BUDDY for VRAM allocation Date: Tue, 24 Feb 2026 17:52:59 -0500 Message-Id: <20260224225323.3312204-2-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1PR13CA0165.namprd13.prod.outlook.com (2603:10b6:208:2bd::20) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 5800146e-dedf-4273-caf6-08de73f78a8c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FDwuKcMi+biysWAEmN/7QL8stirF/1LQeW480LL8dijlaH4EEsoajIaPn6CE?= =?us-ascii?Q?4EvxUlwKN9zXCpsiseq8D8R/saRn1ijk4qOkcUZAQoOt1HTuuhB/7D56rlI3?= =?us-ascii?Q?nVlNc/xvyPAWGi4eEAkXIpaZPRy/ik9VQGDh+loN1MGTwhx6WOxpjIrNxlY0?= =?us-ascii?Q?QeXgdQwAp63sypS4J6dR9PXPBlryaZiWPcSkBi0AH2ULvOBOiOOddUhqRUOp?= =?us-ascii?Q?CytHv/Tar65Cw+usGVJ9108DSTLDUBhb3ZimI71rPppDj7bRoAjtAvy4vAS8?= =?us-ascii?Q?YFML9RqhXKi3HecdqE1tHgLV00j3MNsohVEBNkRVMWS+K2zH+kmdyKNnHBsW?= =?us-ascii?Q?tfmFtwnVdvzy+pEw8tE81D9C2ur4vSV0TiJtSXfhQ82MRXTv5x/lVHxFas1s?= =?us-ascii?Q?4a+ONrg7PivvNMdAJ/rVD6FgMIQIsQfoTf9kLmRqGn+8IFr3+2Y66K3pEsi1?= =?us-ascii?Q?3Bs4cnrWYinjoVJOx9f9sjtj6H9jtidSQvtNprL5GrnPC3QIVa1oHY0V319H?= =?us-ascii?Q?ApwCC5jVJtTUZ7cmcBFB0D4kui7/oaseNCz/UwNr+7YQrnV7KRgeQjMLNM4g?= =?us-ascii?Q?TdDt5j0tjvzqECt/ykBeho9vEcW9xfbhNaZ10lOPTbjgaE5+MZ/ydCt+pmF/?= =?us-ascii?Q?/5jXAVJAVyHHT6/tA8Up/S/NXYiJGfEPC/56Yws6etAqWIBOeOnco9GXeye4?= =?us-ascii?Q?4F56dFKi/YbTnrNVZ5kRFL2t1bjXjhobMTSoSTCvF6dDOCKfufce1rG+nu+x?= =?us-ascii?Q?c9X9Vv3nyPxv+7TLtW7yaDz7/90jUsWrlVN+RCdNm2m+0dNwX56CUOibNBP7?= =?us-ascii?Q?Cj1LdsImorPLxsPkulbor/jspnlRoAWgq0WI9QJgE0MlGBoQt1KzRRQ9N1C7?= =?us-ascii?Q?gU5IBL+AJmfymt1hIGaWO4JGkOXk6aYC+2Y8ghpEWfoRlAbRFO8/huJ0Strs?= =?us-ascii?Q?+Y8pq/wvp2fykf9KxWdNLEN2j8xhGHc7tKPOxdazU23FtLNQQcaVc6ttahJ8?= =?us-ascii?Q?l0meCl8v0yolAYDA1iSFejlxh7BckBBk7CL/3eGEEjkMXAqRpfOEkNaLP1iw?= =?us-ascii?Q?IWOSJGgCNvDRYFLkxE896lcYnuoj/hngO1ZaZxZCHP4DU0h8m0B8XrdAlkka?= =?us-ascii?Q?MUd9GwqhdI/NT1BT0OKn9EBbCm9JyCBuHuy2kUITjkGVh65e1EBJLmWcMJNC?= =?us-ascii?Q?kzfwhcJCgsVWFf/GbwW/Uh7o7KZ8kjN8GSonvV/Yx+nH10DvRIjPGNYb62TJ?= =?us-ascii?Q?u4LBsj+KuRM8OWrXRc9zydw6p2lUtYiYix4NTBctIejLZhg0vzjTM2feDpgK?= =?us-ascii?Q?XnC/aMarvpFUdA6ANodtZK0IInPmiY7nS88qBKQwQzxinVDgtgaU4ESLWYj0?= =?us-ascii?Q?5R3z9P7bRl0kCGR0jd39eb1Xd9ewb8BXkGzm3G/wtlo8djyTxCN0gPfHKKWA?= =?us-ascii?Q?Nh8JPg9gs26QlZlIdwkrGTulKaIKd8AlCOg/pB1KGe6oa1uyERv2Hs3D5fmh?= =?us-ascii?Q?YGiAB8W9Y/WGXTInvQsc1TNWxVizYIqfsdzH0y7nq/fgid1bx1AYa1s2U9fb?= =?us-ascii?Q?Kb4ZJhynrzHhCpYxab0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Vy4MgQ6662HftR3K1JrmE050RIia2hpADovpfsd1IAEuCnDTfQ7J8xI8y83z?= =?us-ascii?Q?R2+r54ca2Iz7lzTUwmrcsz2Ugh/anwrLkerrYTP5fPuKLjcaFswPqz2jE8DG?= =?us-ascii?Q?p5KS8nvj6vi/7+bxtm26TZZ96tJ4U1Mw3CosUq6ZoBi1H3jGjEmCJsUObQxY?= =?us-ascii?Q?PE4T89ySBtGJiLI+7Ji60x0x2OGWfaNnjd7gBK2o5A97a5kSqUvXiy9X00AU?= =?us-ascii?Q?D/VmWaaVPyoxS+92HdG9SF3lSABuW3gmuGQ9j2TQkT9jGLRP+LAD0d9ZK8In?= =?us-ascii?Q?MJ0sGiElTWl48Cyjl+u50tbr7VjO9vB2o3o5cWLfo/Gj+mg8mu/DJOmUa8fh?= =?us-ascii?Q?IRpy3veKDuIXRgk7ugmV1rmNydA7qBohyAEh/vCrWzvAX6du0f8rhtTaldQJ?= =?us-ascii?Q?FvlK68l8Lv+uYyBPGFZ1vf/rjV9jbgnLR9aRsLiwTPK++JN6JquVjhFjp/rC?= =?us-ascii?Q?99b9LgvmC8UC1zLPrPJ3y8K3Hvyo7TgYvTRQYIqqrWOvxrTUBDSS9xYG6zpg?= =?us-ascii?Q?ElkB+B6Lk3YHjUVHYnLKFto+uDNZdJfhE4oVyezqWo9tJtItBY3DFwUJOUeH?= =?us-ascii?Q?N1XJf1nkq5HyzP+NYVimHWBx6V87ajNqFG/4r73RYiZEgSg0QoGrT9b9akZS?= =?us-ascii?Q?eCaknZp5cPyZ9tOS9UhIhl0yPdAbBy6JFjHB7rVE53jIIHKYrhbXvb3Ticd5?= =?us-ascii?Q?yOFBr35XxUlVQNrG7nvvGwKN6BHWSKNBttZo3iKDD7gSjgqnuDhfKNXqBKy+?= =?us-ascii?Q?j0ADg8SA2ifjUsdKPlUu5vhhKZAN0fCjnRtoFxY0jhtXHnNfI5AS3Rm5/TAk?= =?us-ascii?Q?gICmoEB906SiiNQ+Fk4+kH6JpcLucTv9uHKdevo1D1DDdVGl9dfZA8xaXEC5?= =?us-ascii?Q?fkF/B/cPYexS+7hAGYIkqUlXHbonyXgZvhnb2gS8zUxHwDZeYgYc1vsC39xy?= =?us-ascii?Q?OPhT2iGTnYBxb9dHjwmPBBglBW7sLDR7zljDDhWbmbpogWUewUxvBaD2HjxC?= =?us-ascii?Q?s2gPSnX8ogFtGiEf9vpHYcNzEQ2SkN5oT8rBZ2kMLlpQqa69YE8TcswpCAPN?= =?us-ascii?Q?6sMa9qN8U6MSNqaGcQmpKnImiJ70RyGO9hikpaHphBkYnEQncgUG8kCreAoR?= =?us-ascii?Q?LnRmd+aK09LDXMbGdojeeSQK/Z7TWKkXrGaAGwcgERq/D5yvvKIpA3ixWX4T?= =?us-ascii?Q?C0F7G2lR+LYxGxVAVxLL4zbf9gsudzWXbXpoSQ7qutkbiSYW54KVCirPEnIp?= =?us-ascii?Q?gB7XCmLHqsPLqTH8tM82OuPkd1WaD+AxUsWehEm1G18tTj7NDwW6y+aSV/T5?= =?us-ascii?Q?yE4M+ILC6uucDUzKO90WPt//APbJpW2kTr9J3w+znFT7S/bv7SHy31VSyt/N?= =?us-ascii?Q?pE1r9k43TWRHm6pZayzktsXnFCBn7/vY3zeSQJiy249a0s4F6hvFZ+L4SG8v?= =?us-ascii?Q?iLHcww+NXdhzHP15lYCYfP+En1N6TLFbBiuItJcGn+NmoxRXnzeV4zzo98I9?= =?us-ascii?Q?zeH3bDOpvCEWhSwH1rU4HdhB/7CG5Ak7JexjKz8WQc8bFwQqlqtX1odQnPTs?= =?us-ascii?Q?T/KFj1CVz7R0ArBLzdSA87x2k3ghkj7xx08B566VLeiVKWUe7KyknQLkdtbw?= =?us-ascii?Q?4JcSVSF1dSYK3oYxGSANGOwCoOoVQbi3Ap4+kUEO74duO7hIjZt1dN6+Bc7Z?= =?us-ascii?Q?NHA8E4ebECwh1wqmLEp3XGOv1ulvXcrHR2W8O1Yg6vn8KiLsgxpJzqfdn/FA?= =?us-ascii?Q?sLBlNfKyYw=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5800146e-dedf-4273-caf6-08de73f78a8c X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:35.3896 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RKuwYYkoAVjXiIyfjhZAVbT2cdJydWWumnABhCZOhTypddZICBuF3CMjyblj6svNHcK6fG8JXyZzZHxLe6bqFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" nova-core will use the GPU buddy allocator for physical VRAM management. Enable it in Kconfig. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/nova-core/Kconfig b/drivers/gpu/nova-core/Kconfig index 527920f9c4d3..809485167aff 100644 --- a/drivers/gpu/nova-core/Kconfig +++ b/drivers/gpu/nova-core/Kconfig @@ -5,6 +5,7 @@ config NOVA_CORE depends on RUST select RUST_FW_LOADER_ABSTRACTIONS select AUXILIARY_BUS + select GPU_BUDDY default n help Choose this if you want to build the Nova Core driver for Nvidia --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012068.outbound.protection.outlook.com [52.101.43.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B53734EF12; Tue, 24 Feb 2026 22:53:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973623; cv=fail; b=bNSYy8cWn0qVRpUWTTKPjvbbedK8g15hoNlj5baDr0OAnfMzrmGfHiIwC2L2Ge2N/vnKQk5mK0PUYzC1NDpaWhndu7KuDd2HM3Y2YtvsUSt7UXUaNDaexw9J53/AQ0shRQOrRyV+apC3KZnE2V1yGBpwzhLG99y6gEJ/fSAcVPg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973623; c=relaxed/simple; bh=7KQhGU4aN9IrQZPWp6oAwclX9Y6tXggmUJVKcC+jV5I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=KMJtF5LzcvNm8KkqURj2epiuOWSkE/L2tZcpZnMQQJyWh0qOj6QepXF/iuOpj0YBdy5OnrhsipBMLtQZXK29GlefQUXAjn6Eu/oPGOBizUNRgI2i4ZKhkp1qhHRR10BLAWuYkSprYeAWRZutE1Q+92dfg7Hy3U0698g+I36N+MA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=RHY2S/wV; arc=fail smtp.client-ip=52.101.43.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="RHY2S/wV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ATiTd+hxWw+9EnaZUm2w3v2JN8/qlMD7nRAKxnGRpEJaCHdPPRjCh8OBoetJ2dwQ1uygePMJmPJ9WTHG5axVveuyXWo1Y+Qp/UaR1eFLsJS300IgVIuuzaonr1OL4WtzTRJmAorhsx7zwe811t4Kw/w+0sqiN4dPRPB6iKC/HsyIKrEiIJje5lefdD+9jbW3eIFbLV4qU+3E1oATZEmDApbbqLQbq0MQBYW6ErslAZfYwpSl+9YCGlgeZD0Cu3lOtiQfVk1aD4Cf3YFmI0Z5McDRS2/apeJm1So7UZzcLRirm2yMorvQYySOnZ20AjQBzMDdIwqne9nETe4KIJh3Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qxuC+zfhLe5Q7zewzUbI0fSaDTYjR+lExDd5j90/3Gw=; b=rBhIwYWD0YI7+OBMFc+3R15LNlOhdbFAgCODZI7Ht9YtQZKRJZslsWHDpXf8t9yZRb0xRYFebb8wRk6svSbljK6y+0MyiSksPGniiDHpXoMMLumjZ2MfcglC1+S+A+ZtDKa5Fg8Rnj1ftIMyD0QZ3kwTKXk3CRFfQAJ4sVo5bmJ2JEw/OJcvUnEBU0ug3/kfiCtv8kZJUJTibreICPdnslXhN/CONi1Ot2TIT8iy8u+8mo8CI4D/rR/VqmwxGowj93enWSlmPPV6VTHerEE3jKwS9J2yTyTjEJicQofi546fHA9OCjZJXzg4MVdE1b4QPNw5iJ9hoRvTp3p7chNbbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qxuC+zfhLe5Q7zewzUbI0fSaDTYjR+lExDd5j90/3Gw=; b=RHY2S/wVCAgA+yEDjJBpqXkTveI9VM3zUd4nYBZH7luGW0Qp6NWSQrFeWe/B8Del4iIKVYLeEX0Dqh6eyzERsP9XYFwIrkjktzG3v/fNf5Go42F5F+gxyqykiBJNLCN+ecTR/+QP4mzUJ5pAB0QJg74dv/sEmUDgCVLq2aKXCJehB91asyqWS7Tpsfyc9qgQ0F/+OrrYv/XV0Fq5MwLA06ZB5P2sErS/Ys6OwZPmHv1WpoJkc7pJ4VuPghRKB6OITFCNw3ddSMz2vfuFPZnhogw1gPt5Kz0AG7lCKRZyUt4/FutF3x8DhCO5un4YhMlC1bsmYF5NFCe0Prbu2vt1Ag== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:53:37 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:53:37 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 02/25] gpu: nova-core: Kconfig: Sort select statements alphabetically Date: Tue, 24 Feb 2026 17:53:00 -0500 Message-Id: <20260224225323.3312204-3-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL0PR02CA0005.namprd02.prod.outlook.com (2603:10b6:207:3c::18) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c20dd8f-48c8-4589-718f-08de73f78ba3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?lxCU1UPSJYMLdxmc7L5VZmtq871ZZayAbawmwAmKyvpu02hIlVBvy1Xi/ZwG?= =?us-ascii?Q?8zXbAlgR2LxxfkMpxyTlTPFdhSHsHO9TG+ji4SqfuwJh3UUE8LDfdCkLtv50?= =?us-ascii?Q?l3Jusa0kz6TiFI72c0XSKtvgJr0N3RWViCSom0n2rtivK5jL1gajNeji3JY1?= =?us-ascii?Q?6vjHlF4rofM0HTXH11hyij6hNEUzdjTWjSZ5FyNboaRXf4L5DMPP2VTLS2+m?= =?us-ascii?Q?RNmuJrAhNm09RyTfm6h0OVDkm+OrpNneXr/77s2trhK1aYSCZUvtgijEgSex?= =?us-ascii?Q?p50d4tWEM+72HR6DzKvtbv3MnxGizZ0BN3CG4SvID8OiuygR/zCekXqwdRg7?= =?us-ascii?Q?FDuHrwqN7o1jNwD0k+JHzgngU4Eu2xIf7LFm26FWrhvwW6/euo8mfj5Pf3Gd?= =?us-ascii?Q?0FuE9aL5I3zh19luismS2Uf1I6406gNmkCV6fBTIV96DKOJ8w0ctWKPBNwF3?= =?us-ascii?Q?aw7zJExG6uigZ6YGVcH2mIZnHCqUsYgKXbObZGbw0PO2Mg/q1wDfplporb9u?= =?us-ascii?Q?ZJUT6KWL/evmAmyjMQTAijC4XoUe9g32FRelTxGFCbePkNx64XSzXxhfW69c?= =?us-ascii?Q?uxk7lqFY0pD8wdVZlbuQWf2WzulW6Sy0Wv7bCsPcgx3gGmCsuvtlCEKHIYvn?= =?us-ascii?Q?pHQ+V1LV0o6m522QmsslJSspsn01TfnHZxPKVjkoNg6la245J9Pr/IdPOJHW?= =?us-ascii?Q?fqCiPA73RAn/LpLP7mOdQCkSQeNG2vZ/toc87Aejvv/eQJXNc2vLmtFWVspN?= =?us-ascii?Q?F/Z/8cFPGAt71ndCw2/tnRe31+Kp35/WpZY2FQxIuSwK+FYvSbRAnAGqc3O6?= =?us-ascii?Q?t12yKKT1yrPZBgPhE0Sgmf903jokP9cAFpHUaIdhDKYtzFjleH0znBxKl55S?= =?us-ascii?Q?wTjwUqSu0L7d+pCh6A7gfzDfT6GlxvkWXUlo9pQi7HkcJtblB/FTHuMLNIw1?= =?us-ascii?Q?KghYpjVXucirr1xYhgeA7g2cJApO2RWdfBv4JtkK4xzb7dLWztE4unOduUdM?= =?us-ascii?Q?78Lc4Jz27y1k+QCMsMP25daFWtYFP2lV4rFKA8oiyxRxESAQaBdmKaXdX2xD?= =?us-ascii?Q?bH3SaR7A1eQsN16T/Kp5xie+Bjuk5OFHy/8lwtd306Iq18635s2xDis4Bu3z?= =?us-ascii?Q?sjjsopNetwtwiQYUxUjpxP9Ggdtz4nTY04SH3t6aG2MkHDcH7eaxoKivSZIr?= =?us-ascii?Q?i5CaKY8UwUEmek51SvAiWvmd57UxL+/Ve8FINhIGhUUrvfBs8+11l+JAfC0x?= =?us-ascii?Q?RO8l7QTtjZC6gjhSvXhOk0rxzScHjRkrtSKf80W9ry2bKHfjA84DemxnEjzL?= =?us-ascii?Q?C+OmMN+IDlQR4VcZXn4anRmzsxkoPUzwHPZV/lTawYoolmBekkfLedfcLaFK?= =?us-ascii?Q?6CE0gwZIQj/dhZu6HYlVQZ3b6iEVKHHk8goM7nP/Wd88jwf4tq3ly4euYNwa?= =?us-ascii?Q?u7NeXI5WJIyFOAFxUluwa7nnmcOogzHERK/i4nrYfqiRvrgt3S9Mv7hIjCRM?= =?us-ascii?Q?8o+G7ifACyFbV/t7INu+qjti2k7zExewiSJXaeLWcYmMAOpmJ1MGZ4PFhczf?= =?us-ascii?Q?wTTmFo6UQFBs7yJvHCg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?93tqVbYiYkR4YFou8a5g+/xD0hTS+ywuVqyyAqWfKPRt9K22tC9AoyNF2bnT?= =?us-ascii?Q?Dd89em3zrEBw36XjeU8M/qX6alw/6Wi7oZvyEDME5row8D1g65lBxg0FffSz?= =?us-ascii?Q?EbiEwjiUmHA9S4diEvvJOt21cqsGF4HeBQwgeLz2u6RUJRa3LbMlQKjcWSHr?= =?us-ascii?Q?LM9vWLrzTjvDLSl4tzZbu7E2oKV9cY7MUbTqQrCPuQvsior5OA8qSthmOMlX?= =?us-ascii?Q?do9thw5mc7LaWuxJdCAG+0+Q6Rth1M9d5J//YqI3ygKx5Ypi+lI0ACogrr+0?= =?us-ascii?Q?lIiKYJ8TS+73D5RDzG/6ikSlzNk63mNJHUV8nmoHTbCCTfNVYFvrJlX/xFrl?= =?us-ascii?Q?DmoU0NLIt16ABPZ9I2zqGFPtEt+nFKQkKVmZcB1kcyC+hfkDZqlwEQudRPGe?= =?us-ascii?Q?t7CHmvTwJx2CIzR+lQUhrb16WEM1bzR8RQieeOceavXDSbC9BdqTw82Uu44/?= =?us-ascii?Q?zXr2i24v5K45SpHtAvNeXopcDqTqpZaLZpKfaedFzd/Xs62Le53DA74mE2fy?= =?us-ascii?Q?R5LcU4sn43uLPQv8P2LZWnfM3HyWzKXDPnEKQ98dhXk0AIZzHc2VL7bD3J/n?= =?us-ascii?Q?iBwWvpfzmtHoqZ+PG11Zrqp2cxkt8Ok0hQafrbrpSBq6C9TqUHl8OEZi5K4W?= =?us-ascii?Q?7t+hTw8VwFu0RAN7BcnWQ9n3W9hpSv0WNAS9+8dbUuIoF7scimPRSa/VQ5kg?= =?us-ascii?Q?QtPC7oJnqYLyesd3kXdpL1k+1xV3K5gx9FLKtTUPr+8yBQAejZdiv4g26BeE?= =?us-ascii?Q?1UXJHGJ3eNbenWWGpGXFyqzftq/5zLOIsiS9k2cd4qbP9uTG3K8iuFzcQ3Hu?= =?us-ascii?Q?N8/ibfFshnBx2mWEnWdxQNyIHGL3/8XxCEa2nPyyr1+9y7MufCk18SkN1NVC?= =?us-ascii?Q?uzVSlMJxcby9yQvLKR/3MlVtR476BL4s1BGIfs/gTU/Dqg9rwTwB2zAIQ5qJ?= =?us-ascii?Q?H6q5EwAoiuBycssWC/dJfn9yy3Jh8n0X9SX3GAVChjYXxk2MjXWqRTWu8h0/?= =?us-ascii?Q?sfN2yP3QoxzfSsKey6jK7dJl5yaewVhFLQ30fqnBOZEb4wh6vblZH5h0qAfh?= =?us-ascii?Q?rrxZXl9X4/4IiD+nB4trOXJo9BoLU7grDkNvpYFDe4G1VYvxlDhT0J7vnpIK?= =?us-ascii?Q?WmuBx1r60SfC77ZnnIrWrIYQltwNXB5jgB5S1GVzqNBtKvXjP/f2iwhBmkcO?= =?us-ascii?Q?INmBJivSgVXCo9gPVhVk4v0IxXFqBQodREYKvqhJjMkH6GMKnUUtwSEMwYvc?= =?us-ascii?Q?UhDJRqsweFeUzeXIOslLo+fbnk3GS7Jcf6z6nN9vtpFcD/0HIwwNjti/cU/6?= =?us-ascii?Q?oFhpL26eqIyL5nxIuomkoLaoThZA1mRMQMgg4YM9S8dyFeiNkQiJAmsOP67H?= =?us-ascii?Q?vCfZswRKjIeOKDtIYsQz2Ux+6lbDQFgBqw4VYF9eEpuY3oOxFk7zjgZWC/ND?= =?us-ascii?Q?2wIvK4rqDe8s9OoLq5ksmEwFgHjUrgfsrhSYlFBVGrGT7tuol9GiWrgQilwx?= =?us-ascii?Q?WdbWAU+IcKabW+OS4GbrnH8zRjQTSNt+N5PEPmPiq18WvKLAcn7AVjYkv31k?= =?us-ascii?Q?SB2yCHSrqID78vNwppbTu3woxcHS4yMSR0WoRHBuzDEqn2Pr/u6nyWdZ9w7p?= =?us-ascii?Q?HHldh8ZMbA5w2RFgbQRjDVsAsST0zAzsiUTF510o1cHCye0Me7OVVKCGbJWE?= =?us-ascii?Q?Bs/9ZKXf5tINl05bKp1YAaLWatzNw+qbyeWdru58us+t13F2jX7Of8z1dCCJ?= =?us-ascii?Q?rgGT3l/rnQ=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c20dd8f-48c8-4589-718f-08de73f78ba3 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:37.2626 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GKpVX76hb102/6czrf/QzwZFi+/+MC8DuZWzcJ1vuUtluN+qdK7knn5RmezDM8JJjoOntKTEJeP8TS7yv0PEBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Reorder the select statements in NOVA_CORE Kconfig to be in alphabetical order. Suggested-by: Danilo Krummrich Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/Kconfig b/drivers/gpu/nova-core/Kconfig index 809485167aff..6513007bf66f 100644 --- a/drivers/gpu/nova-core/Kconfig +++ b/drivers/gpu/nova-core/Kconfig @@ -3,9 +3,9 @@ config NOVA_CORE depends on 64BIT depends on PCI depends on RUST - select RUST_FW_LOADER_ABSTRACTIONS select AUXILIARY_BUS select GPU_BUDDY + select RUST_FW_LOADER_ABSTRACTIONS default n help Choose this if you want to build the Nova Core driver for Nvidia --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012068.outbound.protection.outlook.com [52.101.43.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7879634EEED; Tue, 24 Feb 2026 22:53:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973624; cv=fail; b=oA+QPGpuNgZCZdfLQ0+yid0oyD6/DRCWVbPb+fyyA+/2luIzVnmAohYc6ZLSDjPzA5KsfwFL9hDvB8RiWslxKM8ZvURWnoaqZqVPCpad+65dfxqdIsUXRn/aodSt2X364iXTNmn8FHFZru2alQ4/EcuMbxmfCG+2IEw9ran1VYo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973624; c=relaxed/simple; bh=c2UTffl4/lDWv3SMDys86AxrZJRaLxxvbj+RPFpbYMU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=eMIk3RbLdJc+rsLzRBLRb+Xib3HI+Qx6q9Vc1Ln9WaC/i7zR4KQn++Llyp6wlY3UQk6+7G7EKw5wtCnjM7t+vCGCPL/3WEmET76R8sGvl6ZClz07BT60ukEG03sx/+hI6+O+WHwgyT1q8ewkhdOIJHkANyzcKtlPcQEqw8ANhjc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=VSsisazm; arc=fail smtp.client-ip=52.101.43.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="VSsisazm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=B0+9nCDP6qEkguO+riegyaO72EkxVcFufaGpPT/MgYP/b6uf7yEe3hTOD1xuy5doQpRulKAQ4whhdwjWHIbQYJjhFurdLno71peVQqoDzaIgiTN9wDqVznvvYLcx9gbJl2FjUy9j+wwjVqgUtL2jl7mMtKNxfOCJ9Votr9Jc2EuiUMUu9J6rM/5sfWAdHLUn7c7w2Yeag+voKk/TG9HgCZyp7dzSZ0kevtvQi5d1pYRvRIGdkzhYIV974rENd3Rrub0A9M6sVsCoLJiCNKl7HfIjyo9pY3ukla1jyDZ0K+OVtxfFUQyxJ+1twOFLOz9PE5hRUz/81AK32KGgpB3qDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=66e5ni57tNSkTAcGTU+uRVMn1FyZZCrVv9Ht98+fr8Q=; b=LrBxTvDb0oZPWjxqKQKD4/9ZF9BDVhBhc2P9ALwkH3qg85HAQxP9vTQG33WEEqXBg0O4ANy/N1eQMvkD27kgAL1gHBq0g+LAI8avyBrpYzd3KLna+nV3uCzgkamePsuzSXcMpPgtFtby4s0M7pVwcX1fL1/bMwQzXN73GaQIyDeIMU2ZI8MBoeIulqLdf0wzeP1RM9VSx87UpQ8X/GYr0dZ7a0cJIPoIwMxU3UtUQOs2yTb9YwGtyLcGUiRSkxyTM1IvmUoRDS2Y2IgYdmT/B+LHI69oIPeIAu7OOKAervCCfYrgJni6gBA4uhzHa07AZm5657HFzaqiIaoCd/zu8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=66e5ni57tNSkTAcGTU+uRVMn1FyZZCrVv9Ht98+fr8Q=; b=VSsisazm7Wf1M5Y+2CHNKILG/IcaZOBTL25vs5dXuIYV2hS8JJsMIlaxraO3oqCQj32uWbOMZBZTNaDg/+Dh58L5ObxrMKG76kJOeEg6Ke84OzulVkf+x/DbU/2eO7Po6gAPDiUMr0RGfkXM1/DIwgNcLOJwN3aZ/xq6Ld/f0vw61iqPA6ZUHNiNh6unIYYAyo16tRp2ifAjUzHqiHtGwK4xz7UAGlJxi4mg5akQdWlrQ4BoyAQ3cbQ4kIQKKmXiWPFasH9MwpRyFvkwO8FQpsVuO2wg9lqtJLBxgnLnAUTTYNzJsbsEYD4PHk59b6pkaaaBUPJeO7rklC6bTCA6mA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:53:38 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:53:38 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 03/25] gpu: nova-core: gsp: Return GspStaticInfo and FbLayout from boot() Date: Tue, 24 Feb 2026 17:53:01 -0500 Message-Id: <20260224225323.3312204-4-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BLAPR03CA0036.namprd03.prod.outlook.com (2603:10b6:208:32d::11) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: c58778f5-1f99-4680-baec-08de73f78c7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0SQ72sU0ad5pPMOp64aQ1wH4VOTuxCVbXk/XeT+kLK11XQmSC3K/KFWd54Ec?= =?us-ascii?Q?XmXUwCiis//nfEyNvrGp8sA9CTZbRWbgStjFsDUkEINBdCbsH/dbeJi+CKpS?= =?us-ascii?Q?V6NRqQzxL5SCJ682zxJKK6jBIFqK2h5J+0tByFfGxaBICEi6RnMedsoPbki6?= =?us-ascii?Q?rsDhix1xni+SCLBjVTqeajNywIzp2l3+qzoKQz/fwc+y6NQea+ddyRvZ2+7d?= =?us-ascii?Q?PcC69+sxCkyUfflWuU65uCYL5QCy6TRWoENkmjvmD21fUyabcUYiOZjYoGEp?= =?us-ascii?Q?sWRmExE/biZHwXrBmO3Mn0L8E0TMbpUrEjSmBnIgK123zyJX9PirSWuHJm/g?= =?us-ascii?Q?E5J8r7Nlg3ruthKQMPXVsPx8Oxo+HDgA5FX8AGIaCFxtJ+42+jLQCfs8dlqe?= =?us-ascii?Q?KjLwaT19IDXVnIvtxK8unRQPqkogA1wx05Z23zES1/zjLw0l1HVMCwwIKB/Y?= =?us-ascii?Q?VwUW/XOsWI5Z+XcFfBbv2BczzvmQ/xu0LhTAoqHaBUaRVVh9ZDBY7pT0kqzC?= =?us-ascii?Q?c7Zb/k83ZrJlIkL5XHJFPPtpOOeQ7XY66CW384ZsyeOQ+WS0Wlkw2oQV4t5d?= =?us-ascii?Q?wr1yU9qxcvFNek4l/y2vPgFFZN6mE42XZp7tpWMpTQsr0ynbhdE4SKS0XbGv?= =?us-ascii?Q?XKoNQo+XdUDX2Bee8ZulVm9O20X1bnoqVaIOczI9A2EfMYBuqY/tI5zwHIZv?= =?us-ascii?Q?uXl8i7thibmiA564qnxGzWyTkSCAYhYJBDuW0X6u4Wulqa/rkMIzI2Ah1av+?= =?us-ascii?Q?ErXAGqmvusLytra8vVJrql6o2VdYDpTuYKditkefwxI+d6AAXyC34lNDsrjV?= =?us-ascii?Q?HoQYFqugoeUnqhNkycNslztq8GTf1Lanj32LDmUWYoeESjBG+EeIFuCElFKr?= =?us-ascii?Q?wClNy6cjEhYjHgp+hPtW5okxuxVmAPbBXbQSkU5a+PnwwkKCDBrHiY1CV0vZ?= =?us-ascii?Q?OdTLz052wWW7Qiqowr2KPtnrdl3SzNK+GPD3EsZDl+L9lssFPaY1N6zhO33x?= =?us-ascii?Q?PhNrHweH33jqDlW/P2DON9BcTMT3pMNzFT0LOHdpkTko3ekvBuaMFz5/vgEi?= =?us-ascii?Q?hJEsIuMDUA+1JtXTZug+CHwzSUBlLuy2gYXEkrxERo1ZMpl7ksRcXVA8olZH?= =?us-ascii?Q?0KvEmBwJDLr9O4ekmEzvxqxT5mz8FnsjTQNTBiC3vl3klpqJOGrqyZG3rSEb?= =?us-ascii?Q?0jI/G4fHgAgQPovv7cNTN6uPV+hp4aekqwk8wDw64VgHe/G9e2vnUbuaafXc?= =?us-ascii?Q?+ctym4thnQnjPSo93GwgtKRxicfR1W4my8EFyYLhFDcUDka7j9lyoaLAeSJY?= =?us-ascii?Q?gfWIOmT5YPQ/cnaVMdozFENpavSLhGdbRekr/C3lWpNJHgCM9AXuDJi76H3a?= =?us-ascii?Q?fmkJoHOEP82gLQdgdyAziB3r8jNFKZq1elw272oClwN3kt8kTgQpWgsiMY3X?= =?us-ascii?Q?iHbuHhkoGYtunQcy+Nf8VZdW9BafDh7X5Hg+PkDpX8jTVaejh/g/LthtVmuV?= =?us-ascii?Q?nDBlMpjkKHaR71K+aBrBkRck2437tU054y7224lwnf4FdyO2j8CR5toPPZIo?= =?us-ascii?Q?3I5so0pSOpKFsr2vGqk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LSxo5ny7KUdr6JiXu0kZ6puN/RubpiC8wa75eZ+pTGSm1c2+i1NWXJnocoyG?= =?us-ascii?Q?EfGJNrccXd/yGy3OfGlCKHfFg2I/sPWYrSKALuLCNaqJexuW4KTZVd6iV6Fw?= =?us-ascii?Q?fQTyraPQ2NESphRArUZWIV3lupH2Hbfm9A80se1QZUxZaEk8UssaZbYV+plQ?= =?us-ascii?Q?OV2lN9Sg70uRxzv+uBWDw3LNPTLKuAJ4y32EXBfXMEBeB7G9obv4oD44KquY?= =?us-ascii?Q?qPhe4PcrZAkZYTPxfakNvduXXS9r9ZWvXgYs4dFJkfcpYwUV6Kt17CB7nStv?= =?us-ascii?Q?E16SK9lQjYSbtjobmGa1xYrsTewl26NU/8ctXez0Y9HizUDLO1McmMvTgStI?= =?us-ascii?Q?1OATFwIuW/s050k2+S2YWFuAbuYlUg0gWb17wcXAOuiZ5nzl2tpqxQhT+fy0?= =?us-ascii?Q?OrY/EdpoDmuJTM/9vT6mcnCdHmxIS8VBFKIgrJdsATVb8zmpaR4/vlOQ7EKP?= =?us-ascii?Q?7zR9qlFAUSfoZKQZJO8rUeRYzIngFZLuEWnqme4AQvsJ5qB4l1aep5GhbwbY?= =?us-ascii?Q?O839L1ewVLOY1V8Q0VdJzyIsvePSehPuiMiLR3Bn+48SEsB7qXxubQTd0AQM?= =?us-ascii?Q?u4mBuJajqvty/GejGMYlr+clPrICYbw8Iq7Srg5AaqyELgnhvlMgSIMbvbxF?= =?us-ascii?Q?uE9Dy7Myo8pCbEtPcOUZEOhdQ6bAWpV1lzRw8sbRS1OwKEs6QdyKRTsbsk2X?= =?us-ascii?Q?3Y8KPvs3iykIpP0aLTAHegV8istI48R/K+eRFAIHNaFn/fBAwleszhbiRCcj?= =?us-ascii?Q?hNrtuChb6q+yZWPXLBEyWfGdAAikH1siQL3VgHm7xK1R2yQm8m/NWxY/leTF?= =?us-ascii?Q?e86mX4wlokPTdKcZeb2Coo/uCGJ9eqVA4tVXfuwdc94VIeuoOJodSeZvTFFX?= =?us-ascii?Q?WGqZJwZLgq3mqg0zSs+JqVSYfo5BGgMdYHBZzmwiLKSUPcDhAY7sSiQpYw/Q?= =?us-ascii?Q?MtJGZiqWx7umxEm7nbf2UMwnl2HrzT86Ale321rfXJgjdsSngvDG2g+onsKy?= =?us-ascii?Q?X7ydrP5OCV1uWkglqRK5GJikGkX0QfOz29pWOLiojzOXOVQ3mHrojw6Xn2ay?= =?us-ascii?Q?l7ngvsXckw3JEHFkH9c0MNDoB/HLnpNUCu0MTrk9uwtXF1aKC4FTb/0sQFH0?= =?us-ascii?Q?IMlbXvDiRcJKsnwSHq6k8RkqpymAR0O+kaqB18YVRhHyer4ox/7J7a7Ecl3U?= =?us-ascii?Q?kEvulye3S799/KhGArguXCHUcYY0Y8ufiYK1bbCyXaw1Il5W4ytK9gZ7R0uX?= =?us-ascii?Q?Qrnd8km1PJECxqRa+GRgXa1xj/bXQuIFl+iURB+keIGXQ4SDlx9KLYdD4cGJ?= =?us-ascii?Q?aa6QaEx/e/PYjRovJrjZZwbb7KkSGXZSyuLpDFfs6Yf+c9ApLrQF3mu63FvV?= =?us-ascii?Q?2bNIW053AyPzYgbVTnmRinQvDcI2q7u/e8pXD6zePuj63aiEwMOhlrIKRrap?= =?us-ascii?Q?9D84JUEREpl2LFVvGBYrrkXeTiDssk8iZBvw2e5jkp5J6S4z3MG7WlBkpDyB?= =?us-ascii?Q?Ni6muhQkaEgCqCVudv3CcY88JVUgKYZ3iEuBeprqr4pFHq+is3np2VNUyLX/?= =?us-ascii?Q?9ehmDGioKfBgVaxQp3IIxO/odgf//p2MPZUD+MtocE/M4gufZZuFF2xK5oSu?= =?us-ascii?Q?cMtNOeCsMUibjF74TVfZzxs1KxyLWUDO1N60fj/o6BgxSGYN3TaINmIRuG6L?= =?us-ascii?Q?Ldq9+Z6FxewDuFx8nDgJa7Zzgp6BrHfZ5p9qm+JHq1yf/WoV8vxc8SJAdcLb?= =?us-ascii?Q?RNKMxM2FTA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c58778f5-1f99-4680-baec-08de73f78c7e X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:38.6151 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eg2IdSJdwkuSJ2AzQ/nmxK+jg+WUx76OuyjdOXh+g8kS5SZoINyFbF9D+NZ/CenTt5WGLVXmSYvs8xwOUVZHXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Refactor the GSP boot function to return the GspStaticInfo and FbLayout. This enables access required for memory management initialization to: - bar1_pde_base: BAR1 page directory base. - bar2_pde_base: BAR2 page directory base. - usable memory regions in vidmem. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/gpu.rs | 9 +++++++-- drivers/gpu/nova-core/gsp/boot.rs | 15 ++++++++++++--- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index 9b042ef1a308..5e084ec7c926 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -18,7 +18,10 @@ }, fb::SysmemFlush, gfw, - gsp::Gsp, + gsp::{ + commands::GetGspStaticInfoReply, + Gsp, // + }, regs, }; =20 @@ -252,6 +255,8 @@ pub(crate) struct Gpu { /// GSP runtime data. Temporarily an empty placeholder. #[pin] gsp: Gsp, + /// Static GPU information from GSP. + gsp_static_info: GetGspStaticInfoReply, } =20 impl Gpu { @@ -283,7 +288,7 @@ pub(crate) fn new<'a>( =20 gsp <- Gsp::new(pdev), =20 - _: { gsp.boot(pdev, bar, spec.chipset, gsp_falcon, sec2_falcon= )? }, + gsp_static_info: { gsp.boot(pdev, bar, spec.chipset, gsp_falco= n, sec2_falcon)?.0 }, =20 bar: devres_bar, }) diff --git a/drivers/gpu/nova-core/gsp/boot.rs b/drivers/gpu/nova-core/gsp/= boot.rs index be427fe26a58..7a4a0c759267 100644 --- a/drivers/gpu/nova-core/gsp/boot.rs +++ b/drivers/gpu/nova-core/gsp/boot.rs @@ -32,7 +32,10 @@ }, gpu::Chipset, gsp::{ - commands, + commands::{ + self, + GetGspStaticInfoReply, // + }, sequencer::{ GspSequencer, GspSequencerParams, // @@ -127,6 +130,12 @@ fn run_fwsec_frts( /// structures that the GSP will use at runtime. /// /// Upon return, the GSP is up and running, and its runtime object giv= en as return value. + /// + /// Returns a tuple containing: + /// - [`GetGspStaticInfoReply`]: Static GPU information from GSP, incl= uding the BAR1 page + /// directory base address needed for memory management. + /// - [`FbLayout`]: Frame buffer layout computed during boot, containi= ng memory regions + /// required for [`GpuMm`] initialization. pub(crate) fn boot( mut self: Pin<&mut Self>, pdev: &pci::Device, @@ -134,7 +143,7 @@ pub(crate) fn boot( chipset: Chipset, gsp_falcon: &Falcon, sec2_falcon: &Falcon, - ) -> Result { + ) -> Result<(GetGspStaticInfoReply, FbLayout)> { let dev =3D pdev.as_ref(); =20 let bios =3D Vbios::new(dev, bar)?; @@ -243,6 +252,6 @@ pub(crate) fn boot( Err(e) =3D> dev_warn!(pdev.as_ref(), "GPU name unavailable: {:= ?}\n", e), } =20 - Ok(()) + Ok((info, fb_layout)) } } --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012068.outbound.protection.outlook.com [52.101.43.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 022DF3563D2; Tue, 24 Feb 2026 22:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973629; cv=fail; b=BxJyQ2MGJlypqOV0D2AgaRT17sj/w6ePnfpUPOchOU7yFCz8X/lp086k5T8Fkh9Fqhcu2XDtCWOoJ3lO4seQFYR3i8FRACmzyAlwsYCRy60n5n682JIg4DK+NwZv0ckYaHYx7EiF49QySbHeOQ2J58+R3abwFIFiCVdB6soLrBs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973629; c=relaxed/simple; bh=Kv++bqVCUuXTVfjHmpRdBJs8QZz7yac6QRRBLKmDmnQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=MMxwX3+GbEoxgS2J5fY8QFAga1TpzTVRGAMjzreTtRQSQj/aeioTI4nbCgOBvaHV/DCtOIXVECjjY35+2nHOo54wCu4IPXCAuN2ax1B3WBNG7yMAQgJgZNsHF5XLWyUi3fSGWIwoTqwlAXIpAWSADqvJbvCH7PFVVHtjsQC+qXY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=kVzvo9r1; arc=fail smtp.client-ip=52.101.43.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="kVzvo9r1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ogyAHJ4pVHyxBK8Vf+Hy5/vjQliSnVGSR3EbS8dtThovovEIUKK310/UzMasQOnli7KaZVW7Rtxc6sENsONgTxR/nWdUJ2ewCvzScZblJgfyC10QCA+vAIm75qtdBeE/YzeA69/UBmJ9OEkpTBBPsdZUEykpL3E/aLiquNxyAiSbgRagFJRYGPK6WOBrCAApqA/gdPWyZ/rWJFuIHfnvol3fMDJtPw1ekiZeZM7gGXberAZEFqY03HtPQJiDxGLt9PWJ0HB9id2yi/9VMvxOg/Gns+IWrzTLcXkpDyvGzKssJ8qs2rjWKpE7tyEzkNlTBGjgwO3MstcJWAYwAc+N6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nIPO62UBoPZsLYF1jBq+R5jm6AP8aJGKwfopDKgT9mA=; b=n/KDOl66wFKsvoc0/nV/NuX4HtMk30CBUg9Cqi+Jvts/25r2on2o/R1YzlMxTDPp8mRpAqKBiHxBRK5qrfbVNtLYr0t05tGVhpGcV8cdiEKcZdLOMgPCNa4d/WEa8M/N0icZWHVLsGmslXoPuRXmmzBhzfntmuXjGMamTEs42UvOyKL1y5HJ9tZq4KcewOV5oAECQI0g4al8ypWdadMNBKri7sh8/Waj8P1RNMJSLVgaC59rcvKWVWAOVWCOZuhlN5VTZyZ6s2ukJnzrYQbzPGTUrDsxXgdFic0Z3yzQSW8y1Y9dIQhRZQk2TaclV6XZTG4ty1qWNJ1mThuxWvXYoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nIPO62UBoPZsLYF1jBq+R5jm6AP8aJGKwfopDKgT9mA=; b=kVzvo9r1ZAYk5tD9OrDKN1uL5l1RLzH8QSaOhnPFdnKaIL6EGnAYEu3P+nwHzwfPIsY3LhMlHil3P4NeSUQrhjheyTzxK6mWl4LA+MFFbDjaX48zhkkhl54y9dJMLl+3j5uCtC7Sg7VBHDugbjvS/6KCoV+S2v1GrjWLPD2w3FzFDLSlh2Ox+QrivvDtYlt0mzbb8/FwtEVpWWA8JNQGwoGz7difProYz+pwtE+zV21nWqzL6GQTtcoAOw0aMf3liXWaIp+nNCXptGhYThnKJ6BOeqjhBx7IU4xo5EPUjm1uHf+eSc2k9tAtSTuDtwm/gpbhzC9RMP9f7Pi62f20oA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:53:40 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:53:40 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 04/25] gpu: nova-core: gsp: Extract usable FB region from GSP Date: Tue, 24 Feb 2026 17:53:02 -0500 Message-Id: <20260224225323.3312204-5-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BLAPR03CA0030.namprd03.prod.outlook.com (2603:10b6:208:32b::35) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: aa24b52c-f70c-42e5-d7b7-08de73f78d67 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/53F9L56urGmhnp0R9A8y9m+Daq8Jh8rEDU+KS+S2YI7619zbrTp4xnqEs0P?= =?us-ascii?Q?uWA38RpAgq69CkYl85a1wLOwR5WaRW2MK6XrAsghoFiKbh++vRL7M5QDEvYR?= =?us-ascii?Q?dIUezJGSVYDwQ6kERv0DkOg653fw66ApWNak3K4yTQ3fmRyNjZ1S7iMPsRc2?= =?us-ascii?Q?wTjL3w5KT+6qt9DzxrWYw0xwUPFQ3peITncpk1A3ueYNU0AJa8Hp4dkR7JIl?= =?us-ascii?Q?vMVInz2J+uy3cg6J2wmlkDJ+0iW9gDK+UTY79N8BeIYtVVo8rYTm9Q/N1ikN?= =?us-ascii?Q?bG4cmxFfCYYhpDFEtjh+jWCx8kHE2ltKoMdl97DgBRnoozs8bsmjeMV++ij9?= =?us-ascii?Q?qmlMdu1vJQnrfwmgJ6eaEz0P0RTuAW5I7O5MBxW9oYzLf++XaZBXxx7Kp8CD?= =?us-ascii?Q?d3DxjYYwrIXoklRQxUXROwyxOqoPVVQka30MB2woX0cAR/TgjctHjK1k6gV3?= =?us-ascii?Q?COh0q4Wz0Ac7ZVk2SSKB5m9RjQbxhiDg+zkzk8timljzbgRFIVpFpCQDFF4q?= =?us-ascii?Q?2IirpANpE+k6oJaffOt+SScLkGpkyqS2zzeEDNbO2iuZTNkdJl6QwRh3/lu9?= =?us-ascii?Q?b+6ujtV2g5Rxh+PDxrsCBVYc5Y2q641JwXoEZZqXD4T0UzcqbBe8KUxulKc3?= =?us-ascii?Q?jfXncoGjpDFXGdxs422kMI4T2F2oCmHN1adeppyAQl6QMiGA3Qvql4JeaHqJ?= =?us-ascii?Q?YusabN/c/g1Q3i33/g0JcLOxlNoBgvCFf/BPdg1sN4+VMHrJHL0ciNQZ5DYx?= =?us-ascii?Q?bYmR5IF6zNhzzZQQjg2nsDY75BINweAdrQmGgau19dj+TPDeUDxbiIm99XPv?= =?us-ascii?Q?ZWO8exadcKjj87KaF0ryqT3jgwZeMFwjQp4CvpHxsLrMg4mcHpBg6TsRGiV5?= =?us-ascii?Q?bJ9C0zm5UIJJj/zRrV6QaLBvqpSItYEHPBqy73OtKkXBwAxFXNWSgISsE/LL?= =?us-ascii?Q?MxIGCv8cgZaxgQCu89gwT2I5aBEmOb/vd8umhX0icQPYrgVC7C3101Y+3+VD?= =?us-ascii?Q?BHvjQL9zF0d9z7MjpY5PJCa7eQXGReOUBJr6dc0GrNZ4SanJa2bVWsrnYxFV?= =?us-ascii?Q?MrmVw9bMfDEkG1qmWnm8Lqlp3hBvEwTxyOkVBPq9RoQhRVaEznJBqHRgWl6n?= =?us-ascii?Q?f2vvdYGoM0MeKhkyCEkokNpasXyj6+bcXz3TmdRBfkvhzkZHUFWN/8bSF9dG?= =?us-ascii?Q?pKbgipdNMY/tCmeOy2cJsctydyFu442im8ExIbdYFeiuwNlLK9HLWBqYkF8N?= =?us-ascii?Q?drLG6QIxEjPy/2WSVZBP5WHniiPA4vmjmMLEsj4Gqut7QpVbaLfKYS6Nba18?= =?us-ascii?Q?eOklNyAgy5ONNxYPtGHPO21GwTsmVgR9rabUqpdNt89x7pbS/wj8ssui5n/s?= =?us-ascii?Q?XrszEFV/z9qxcuJNeEJsKT5NGOGooOJRdKqow1YUy+sXb3VK8p51QhQaiSw0?= =?us-ascii?Q?nnMh7D/yXO68D84pFC5dCFn9qEQBa8QwfFMzfgtl2CfzxzC4fH3ZN8hK+Ceq?= =?us-ascii?Q?OdXJLb9bOu20jKJ1QS+XMwB4WGbMvzuoxSyUWgRGKnh74gZ8pVhqMAdYsemq?= =?us-ascii?Q?HglVCyHCfVIPeMoiDIk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v9LK7eOiIm2Oa0grHmNJxlSw4tjiuzAYsGqBFrvLURl4ryFvp3yHYFTUu4QG?= =?us-ascii?Q?IC0oFohzPifzyoetGxZdT6Shbki/uqBBroXwK40pg8ngt89Fddffwrlzyv91?= =?us-ascii?Q?mjPGaK6fFjbuIQWP/TBzfzatUb4ZI3epkqxIHX5hYrH3Q1DHy9i4otvTzJIl?= =?us-ascii?Q?CmAmTpyu1e8se4XChQgq9rnN5N0fzQm/Oig1WMi4/iIKtzAs5PhkdmPb5ZN0?= =?us-ascii?Q?Nj2EDBzVq7aIG1fWa/Ios1udwZeqmuE8r5CM2a6edbnbcHnaatLQgdrkKzxF?= =?us-ascii?Q?MqXxGFINb90TFFclNvI1S2K0izjzW1uYKV1p2vgxAzLo+Z1C5onoUjOCUt1B?= =?us-ascii?Q?E+2reZxwZUSXNPRaP7zrCW4RlOiO5/NhTWJq8u2bs0WXwShclYVlGPPWjOmQ?= =?us-ascii?Q?RijBoynb6hmmxfXXtuj+ushCG5X9JkvelwDEueIu/GXV2Gn+ioEHKK0R8uZV?= =?us-ascii?Q?/ee3EW0jrMl/BndpMUoxbk8FhVwPyIw2/1dWrKYcWniv2U1SaMes6TJCItJ+?= =?us-ascii?Q?pq7QdCkNXscDoorvIjV0XBKJnwqxJGbg5JMTlJ1s5L/4lm2xgfiqy4WUF6R6?= =?us-ascii?Q?B96nmxzBsCu26dS1JSK6o4wfm4cg3yJYn3dF+D4B27NuAXDwCTXls/zXqogI?= =?us-ascii?Q?NW2+LSgnLRKqlttESuJuzHrIeMf5D2pIOsV0Ny72/k2zNSnckrAPzIY9WAqr?= =?us-ascii?Q?oSKsncRB4uQnipHk8070B765NPGD98CV7mZmOB+zWFIIJBaZgv5q+d3GiSII?= =?us-ascii?Q?ASH6SdnSEeMrTfR6X1SKHx4QlSSinDAeN0ncQUH+tZ/ponQFdkIVNLaurfD+?= =?us-ascii?Q?vBJiSqRgPQQNeYYrYlLz8InbEFznFjRZevi5JRv85GsqvR8wLPNTly3YgR/i?= =?us-ascii?Q?QdM3S8lIGH7FM+/Ugy1FGoDxomWL1KQltjfJhJukoto88m9oNIWJdmzInxtq?= =?us-ascii?Q?JHwnXkauv+fflUW47g3vC3VgBw3DeJXEo9rfvfCF6nmI4yfelki/5DLwSvUH?= =?us-ascii?Q?oj3D2xff6iO6+U+Qf4BG2HMeB0+bazCQUZaw4bctXRcN9SuXXXl5wa/o+B0N?= =?us-ascii?Q?n/YPq83lAx5shicBevGc4FUjpWP0qfZ3rR8y/D4scfJ+98SM/+UA71jj6aRe?= =?us-ascii?Q?xlreeeMPyAYIWPsuv4+sR542GMmTmUPVmXLQTTWv8dyKLx0TkvKjPq+MevyB?= =?us-ascii?Q?8NQ5AjFiNE+XlAD7qRr7kxg1o9Y1jCR5e29O0Aa11eu80HomX3JYMXUhnbtg?= =?us-ascii?Q?Vu9pyQ2y1KIvvAOo2YXuZo8sqS2uu185HC31GDttoLgYzg/djXTxFU4VzCk4?= =?us-ascii?Q?eR43Xgc0dNOx/8li1rRtAQ6deF2j55hcIr9UxC58QnVv/JdU3q3HAcEEdq4f?= =?us-ascii?Q?PTi0n18xV9+/hogR6LwWlOFEsqmumrfe498HaVuiGhKgSH3cCrcA5KSwmpr8?= =?us-ascii?Q?rMe1oyuodeQtfvONPb1oWT8CbW9ldJrKn13+X1VCETHHpZW1dI/WGuD6ve10?= =?us-ascii?Q?1cnE6QDaLnKoN5XkvuiRumYqWbR0ELzw3lRxmg9QARKBSisRkyLLTCbG41DL?= =?us-ascii?Q?4fQy2sekUIMgQvAFc7yLnPyl8tChLxmaX4F5a5W2iNY/qdWpKu4ubXZ7HW1P?= =?us-ascii?Q?UH3nt6BbOj7pDjF5IHtUdMGDF0cEfn5MpM35u4DXRHbMMPo6MwLcpvHPjywF?= =?us-ascii?Q?tD0mRk9VLzNoX/Y+OxyHJVOuaV2EF+P5f5tw6x88oz4Rw53EwF30PZAr6Thh?= =?us-ascii?Q?RqkQLfxxHg=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa24b52c-f70c-42e5-d7b7-08de73f78d67 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:40.1623 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hz0NY7Kf8993DeleufGM6So8i7S/JWb3d0iUV+/20OKwW6QVw/NYe3vQN0ZqCz9fT+7x9X+unzsT1k2gRmIGpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add first_usable_fb_region() to GspStaticConfigInfo to extract the first usable FB region from GSP's fbRegionInfoParams. Usable regions are those that are not reserved or protected. The extracted region is stored in GetGspStaticInfoReply and exposed via usable_fb_region() API for use by the memory subsystem. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/gsp/commands.rs | 12 ++++++++- drivers/gpu/nova-core/gsp/fw/commands.rs | 32 ++++++++++++++++++++++++ 2 files changed, 43 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/gsp/commands.rs b/drivers/gpu/nova-core/= gsp/commands.rs index 8f270eca33be..c31046df3acf 100644 --- a/drivers/gpu/nova-core/gsp/commands.rs +++ b/drivers/gpu/nova-core/gsp/commands.rs @@ -186,9 +186,11 @@ fn init(&self) -> impl Init { } } =20 -/// The reply from the GSP to the [`GetGspInfo`] command. +/// The reply from the GSP to the [`GetGspStaticInfo`] command. pub(crate) struct GetGspStaticInfoReply { gpu_name: [u8; 64], + /// First usable FB region `(base, size)` for memory allocation. + usable_fb_region: Option<(u64, u64)>, } =20 impl MessageFromGsp for GetGspStaticInfoReply { @@ -202,6 +204,7 @@ fn read( ) -> Result { Ok(GetGspStaticInfoReply { gpu_name: msg.gpu_name_str(), + usable_fb_region: msg.first_usable_fb_region(), }) } } @@ -228,6 +231,13 @@ pub(crate) fn gpu_name(&self) -> core::result::Result<= &str, GpuNameError> { .to_str() .map_err(GpuNameError::InvalidUtf8) } + + /// Returns the usable FB region `(base, size)` for driver allocation = which is + /// already retrieved from the GSP. + #[expect(dead_code)] + pub(crate) fn usable_fb_region(&self) -> Option<(u64, u64)> { + self.usable_fb_region + } } =20 /// Send the [`GetGspInfo`] command and awaits for its reply. diff --git a/drivers/gpu/nova-core/gsp/fw/commands.rs b/drivers/gpu/nova-co= re/gsp/fw/commands.rs index 21be44199693..ff771a4aba4f 100644 --- a/drivers/gpu/nova-core/gsp/fw/commands.rs +++ b/drivers/gpu/nova-core/gsp/fw/commands.rs @@ -5,6 +5,7 @@ use kernel::{device, pci}; =20 use crate::gsp::GSP_PAGE_SIZE; +use crate::num::IntoSafeCast; =20 use super::bindings; =20 @@ -114,6 +115,37 @@ impl GspStaticConfigInfo { pub(crate) fn gpu_name_str(&self) -> [u8; 64] { self.0.gpuNameString } + + /// Extract the first usable FB region from GSP firmware data. + /// + /// Returns the first region suitable for driver memory allocation as = a `(base, size)` tuple. + /// Usable regions are those that: + /// - Are not reserved for firmware internal use. + /// - Are not protected (hardware-enforced access restrictions). + /// - Support compression (can use GPU memory compression for bandwidt= h). + /// - Support ISO (isochronous memory for display requiring guaranteed= bandwidth). + pub(crate) fn first_usable_fb_region(&self) -> Option<(u64, u64)> { + let fb_info =3D &self.0.fbRegionInfoParams; + for i in 0..fb_info.numFBRegions.into_safe_cast() { + if let Some(reg) =3D fb_info.fbRegion.get(i) { + // Skip malformed regions where limit < base. + if reg.limit < reg.base { + continue; + } + + // Filter: not reserved, not protected, supports compressi= on and ISO. + if reg.reserved =3D=3D 0 + && reg.bProtected =3D=3D 0 + && reg.supportCompressed !=3D 0 + && reg.supportISO !=3D 0 + { + let size =3D reg.limit - reg.base + 1; + return Some((reg.base, size)); + } + } + } + None + } } =20 // SAFETY: Padding is explicit and will not contain uninitialized data. --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012068.outbound.protection.outlook.com [52.101.43.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B189C352C29; Tue, 24 Feb 2026 22:53:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973636; cv=fail; b=B8WBC4fJGekACgYYqpvpjuxkbUMX5511Gy1P6yx1Ht+Ymb4sg6KkQogKS5wqvEuEgAy2ZdNDnV3Dmk0PzINCnZpg9Zyxusm2P6iiZ6pSS9dZmkyCNKHFDve8LQHHm+j34EjCJgTyryFPrgw+Suot/zQgMRSTsF1k77if0xbq62M= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973636; c=relaxed/simple; bh=xmBZSqVu7FP+Wh8h+HfggLAt2exd0XNr2EZ5ZM68wU8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=BAPG3jSV0UeJYlpjkWMZo32q+v5vNR2Z2kDD6E7q4VyTjhhwNYTcwZw/wPQjhKxgKPGBqXPjBPQm7LiYXYwRHBoIb2JiVVtQY/X4GJin8yFuyI858P++DLVw57jfyMDTwv6zYtlo+YtNOGtom6tpzUPTXKrsV8bIIEzFZ2Yo8uU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=H0fvtBsh; arc=fail smtp.client-ip=52.101.43.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="H0fvtBsh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ts9iGhrA0Sr+Oaz2j+N5mRpf6JVMVum7I4vxifRLdLzLmLR6NhSGdY0uRgY0FVUbUu8JYKaY4pe3Ajke+Hww70+jtwRw+3B5ruN94LfICRNVw/oCVdkR8wKKwdXzlMJrvEvSCXmozI1XqRvOyK7LivXIKw0tT16Xi9FXa1ekgIZBJBSA1RKII+fbGfIaRnpSzWQw4hbBBZGL4uoUX4iUKYe1qAgexqLn6hGrZcDcIfBujKfMR6fhhGkdT9HuVfM6mDkiMRl0t+1jdB+Fi79r4S3npNioHXGrwcCJLWhiSNt+5pDIikb/h4DJ5TnP6nOObX3sGADxYdTAbKONe7MMng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5LnvUzMJZ5UwmXtWlM5z1ltDRIxnT/1ctW1IEGuLbM8=; b=Utt7fwfocuXJ2vQx5POei8vEo2OtbT5PzJ2pRhYh0xMDKNDcuSKOebXCoOCPkAF+TnjSyQjLkZ4azKk6YmP52xz8QwA9pNRtE/EbtHiJ4YsVLeeolprD//gTm6XgxroJdIVvHHJarKvplnEWZNahKpB56FYq+KB2d/8j/0V9cjCoT9sBy3puFK7sUHVOLg0wGx1Rmob6/tzF5KZbXiijvQZ6CbjmnkDdfr2eZUGTXNRVl/CoyUcTmc3JbMX+DDJ08Px3j2mvnVY0/FJ6oWpRJvkZBlBDbhucWT+jCMcfi73LS1s/d76e76z8dEjjWrn3ruYcNd239+NNB6pxWdBn9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5LnvUzMJZ5UwmXtWlM5z1ltDRIxnT/1ctW1IEGuLbM8=; b=H0fvtBshsJma4zEuGVtO8HkaJfWotyqLHO95RJvrgRVDyOLnVenCXIPCyyF/oruinLsF+ca0rCsBP60mRBkz0achRTjiUQOK33Kg9a84wBpl27i5lKV5WIES8j6I46VL/aytqQ9DEBILCdGVonPTnpyWN4PA7bR9ym2bQfaBLPDqWOUSPaloUBhD2I/KcrG/dJEpfMiXGViZNDXf8rNvMyCB2spea+g6CjrfPp1cUM5z09wV0pr0BAI4c6lK6st6mLnfSEwBZwCvAwB3JVqVUDeD9s+szeDA2xXuLb039x7H1ZX5166yu54TTXvtw4X/HGGXIWD0Vkg3MKLZDqHFAQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:53:41 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:53:41 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 05/25] gpu: nova-core: fb: Add usable_vram field to FbLayout Date: Tue, 24 Feb 2026 17:53:03 -0500 Message-Id: <20260224225323.3312204-6-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR18CA0007.namprd18.prod.outlook.com (2603:10b6:208:23c::12) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 66fb8f91-2132-4a24-c042-08de73f78e46 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?WbBeGvhdBgN0qNyC00gcNdhVsez+MK3OK5VFvuGDu+2nBNu892xaY0Mk6OD8?= =?us-ascii?Q?/mlTEu12/CECuJhGA7flnfde2Uc/NDOJxHUyOMXFXHihwfcrGzI7Vwj5KoIo?= =?us-ascii?Q?DxxjJUAi4aoeOQLaLseDavFsnlsqZiPpOqLO5gbELwqfHSWCWPWWL2UoluNm?= =?us-ascii?Q?p+5j2PY07EheuAhNmblFb2DlsPKJnqsZ697OXyGCURUcDNa7x3MgCePOZucH?= =?us-ascii?Q?aaKRThIvSmHBFaDGZ9+boFOw4O9WvHuMxT6DT+zFranU5qXgoy7jbMiPSPUY?= =?us-ascii?Q?AOM7lsom0rIM5LZEaO3U5xVD0xrg+58450X53Kv12o/6aS/q5o/2mEKc7K3a?= =?us-ascii?Q?Nn6c+G65DvqcCqm1Pd/uKeWAOQBh5PYyhYZG9uzXfRL0+Rq3Ejll3AcnFR27?= =?us-ascii?Q?JVIVEtS5ClQnaFixGctm5P47gG+4mOzD8+X0BXQRME58HpOcMDVYQUJHl3v+?= =?us-ascii?Q?hxF/3NmQKuVFae8TzcrCtecW6ImfWma38Tg0cbM1Wywx8Px6VvRTTBPHE+4A?= =?us-ascii?Q?azKStrTZFYD6b6MuF1t8KUBy75tOipOJq3ABbmrMAyvwt67ycxlzjmAaqL9M?= =?us-ascii?Q?MI1FhicVZBdEy6XrcxZNpc2avlDZP8BzUNIy1cmkS4BgezmMwDQBhzZjcQzd?= =?us-ascii?Q?xiFm6IdqhtTQCbCuYHix2WK155EPbBn91OhmUSkMuGHgud/VEG/kkB2CLvnb?= =?us-ascii?Q?gP+9n+vBiMEef70rNu1XCZ+FWwjFVs2mEU1p/dh6VQRlK9KcrWJvHq+Z9PE3?= =?us-ascii?Q?m8TLURfPQy8jfnBTnbqh1ToMGzBnr5S0fL9KlaRf7S0Ewoynb+pTW3at5WW+?= =?us-ascii?Q?ut58+nM+rSfiZCZD6zi5g/UERaDmy13KtZy0/bcD5PfVkD8x6Bo4NWGs5dAQ?= =?us-ascii?Q?5XJ1/ImTX+czuyziBHm8v5fOU7XRgMKLqHuPuG0FAXuX1DK6B9U7RICT5BNW?= =?us-ascii?Q?4gS3rvt8JO8AjkMfDv0+hmMXrhvWyg3OV0S+FdJS26uCcy0PLz+TrIIY/pBc?= =?us-ascii?Q?26J+c9MasN+ivZyqcLJzQO44Zwrek0dseIHPrdZ7tWTybtrG/G1ZaWEOFSpp?= =?us-ascii?Q?oTrc7AWJ8AWKCqBlLhLtdDoD7XUR58vmUnh+1yWRbvwvU8RvQTHY8eWkV0OA?= =?us-ascii?Q?GRndnfxBGkAd0KAUADCwmtaOlVYksZGNmmkS3a/bQorxO5fc7ArCsv4Hcrgx?= =?us-ascii?Q?t8FhDzjFAYjZKC1wYi2HIatJG3By0aoPEvxi749ZCXPeDacvVZpq9+lgyjpr?= =?us-ascii?Q?T9ooC1w/fhsl6DhEWXLWs6aW8fZvz57fNFyfPPAu3gpGXZwsHBu6yIqPOsAZ?= =?us-ascii?Q?64QCM2cUfqz0dQO+x8gkJlh4nthZuyek71hEDHUpjQ4AxlbWQALbt1JxAkUs?= =?us-ascii?Q?H3LC4xfU/lCgp1t0n0K3k7ZdP9UtVJyIiB0qSHOM53fTdUu9zGPjWo3T1KlW?= =?us-ascii?Q?3gKz9975M+pZdP3/fkUgbpEQCWfqEySXBqr689+37YkMSxO2+vFKmCJAtH4m?= =?us-ascii?Q?tbLjgizs04KNuj9kJarms7lWTK5Wnni5aYCAptuqEbVeVF1P8fVG5LWFqoz1?= =?us-ascii?Q?rIGfA22PAZ57l2fdUF4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0xtMHVzcbV93mlQ9b/iWNSf+RSfzRvSelWyBTtThdEiQF6iWuoLgEXvi1phz?= =?us-ascii?Q?EJPvNsY+vdglensgBoyj4CwvoeSxc65wMYm8dR1GC6cP5U9FL9GIn0uA8D40?= =?us-ascii?Q?dZB+jQRIpwJDLL4MeJSxTS5x9emeuq8hxSeADl0KuHCVBTSh7fAsfPpJdwNM?= =?us-ascii?Q?XPrgTewKHdvr3o9OfYjzYJZmopaVeR88R44q51bWKix1lALk9Cf9FBHxx46b?= =?us-ascii?Q?dIcDtz3l32sHTPBNLMyKpBniqJmNu/eYQw7qqbixmBUAswAa7FE6qYKSZNtq?= =?us-ascii?Q?j/st4doI9InL7VMf2gV+d3xou9amKKQa9qxc+zx4fcaUYA3V6zZeXffs8GX0?= =?us-ascii?Q?bGuCnmoH0jr5DJtb3xwmFVCCgej4EIU0R5T+dGesoq+NzyW23NqdjJRYS+Gr?= =?us-ascii?Q?4WebogE5kWR3KvNcBQblm9qET91U921RxnYBWZYzq/l3nWjd4Ai+COVhzdkh?= =?us-ascii?Q?RwA8sd7leOrrxO4plh5SdejNOR1TCHekulGpXCh8HU1pV9GMnDuQX1hq7P1G?= =?us-ascii?Q?GmuwiVXmU2OEhF6Qm8VJOUi1mxH9h+UueQC1JoR7frdZm2xeVJRi8jKeDYNb?= =?us-ascii?Q?a0I8hrGVrkS5NR3CUyQIAuLKEDB4yRKt07DZpMxsVu2fIgoy8LFIU4dW3ECO?= =?us-ascii?Q?Ev1HhghjluYLQeM1gfXpUH8bblmzoQUvqflqWwx80p7BT+gk/0pVS+itDWcb?= =?us-ascii?Q?uYvIiRrieWysHQuC4DZ1MaSD8u9vwtWRspUag+lyRP7eeaMuv5aamUqnohs4?= =?us-ascii?Q?grhYVwz3RomtP2xwaeQpBsnnTxc0xnXlm2ycW3CkhyORXY9gTV8rkrTslRXN?= =?us-ascii?Q?vrNoSrlbuVJT282iF9kEZodUnMmrbjyRSGBwCM/FUz70NsEF7T26s3HTYNPe?= =?us-ascii?Q?AivrDaSEByLBgpLLsgix/IEb6s1G1wyJ7NdZA/5tNUtmbJyOuQpUdRHMD83c?= =?us-ascii?Q?aof7poVZu9BEm4uWEPXLrd66ElTS3mfjBIpvAtPVzdY/OD5Ng/+7CHjfg4Oy?= =?us-ascii?Q?Qx6sW+mr78F8/+4XvkrXhLkKmR0SDsdNHid3AulX22i/bWD6qGomwE0Pyuom?= =?us-ascii?Q?E/qmeXujSJQ1QMXqPncCa4GikWoJ/rKfsNtSz8vVuojBD5IDQ1FC/mjlTa5u?= =?us-ascii?Q?2zNrrYX0NMQQPdofdXjIIkBEOXp5philDExZDf9WGd4dBSufC+NfB2c+tABt?= =?us-ascii?Q?IU7Pwc0/Vl7VTWMbksVQPZ8ASiQnyUhVjorFqdXGGfYHstF2yv3oIMsoiJWs?= =?us-ascii?Q?PY9ISb/rV7FqbEDB0D3jPFjgXaw02h0feItjRZsFx/bNCHkeKYP1Lp2y+2Oa?= =?us-ascii?Q?icrRLS46wrKhCKbJwyT6402/biXOJljD06eouviMhDZC1/5yrK8RlnlSUbck?= =?us-ascii?Q?5AySSdXtrmUamjCI0DNiuNHMDNdTG1R9eHWbHja2xsa+Hg1FknHxTor8RyCt?= =?us-ascii?Q?zD9f2bjmF8pWpr8uIwbN77Ihx/eqChwJixrSUpw9aIRfHGAqcrVYEic95XPn?= =?us-ascii?Q?7QZEGThbaWv0GsQ7Vm0wwn+Fl6FCk/zbuI2HZXe1sIuDWJpOwEjSf2SW8vsE?= =?us-ascii?Q?8tpGcicY6L7JSHFgAolsaoS38cB3KGORWibxN9xbBzNswjp2j0EF5BRt7se5?= =?us-ascii?Q?PRhzOnZj//HdY8J4Bf4fEHny5ZvzYy1CkVrBxIZERinCD89B8QBBZLDL9dEl?= =?us-ascii?Q?3Fo5/1qpOadfV8UXyYbnis/p/2NMWKS52JfZIjLIrr+VNGHmPI0ACKOtIPg6?= =?us-ascii?Q?kTPuSBoXvw=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66fb8f91-2132-4a24-c042-08de73f78e46 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:41.5956 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ug/dJPfJuBKJbrIhmsfg9VZqLyD7IJ9ueLgE7iGdrxiUJ57usxk7TJeN/8cXxfiNhfSdQVH78UWFzexhelZTtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add usable_vram field to FbLayout to store the usable VRAM region for driver allocations. This is populated after GSP boot with the region extracted from GSP's fbRegionInfoParams. FbLayout is now a two-phase structure: 1. new() computes firmware layout from hardware 2. set_usable_vram() populates usable region from GSP The new usable_vram field represents the actual usable VRAM region (~23.7GB on a 24GB GPU GA102 Ampere GPU). Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/fb.rs | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/fb.rs b/drivers/gpu/nova-core/fb.rs index c62abcaed547..d4d0f50d7afd 100644 --- a/drivers/gpu/nova-core/fb.rs +++ b/drivers/gpu/nova-core/fb.rs @@ -97,6 +97,10 @@ pub(crate) fn unregister(&self, bar: &Bar0) { /// Layout of the GPU framebuffer memory. /// /// Contains ranges of GPU memory reserved for a given purpose during the = GSP boot process. +/// +/// This structure is populated in 2 steps: +/// 1. [`FbLayout::new()`] computes firmware layout from hardware. +/// 2. [`FbLayout::set_usable_vram()`] populates usable region from GSP re= sponse. #[derive(Debug)] pub(crate) struct FbLayout { /// Range of the framebuffer. Starts at `0`. @@ -111,10 +115,16 @@ pub(crate) struct FbLayout { pub(crate) elf: Range, /// WPR2 heap. pub(crate) wpr2_heap: Range, - /// WPR2 region range, starting with an instance of `GspFwWprMeta`. + /// WPR2 region range, starting with an instance of [`GspFwWprMeta`]. pub(crate) wpr2: Range, + /// Non-WPR heap carved before WPR2, used by GSP firmware. pub(crate) heap: Range, pub(crate) vf_partition_count: u8, + /// Usable VRAM region for driver allocations (from GSP `fbRegionInfoP= arams`). + /// + /// Initially [`None`], populated after GSP boot with usable region in= fo. + #[allow(dead_code)] + pub(crate) usable_vram: Option>, } =20 impl FbLayout { @@ -212,6 +222,20 @@ pub(crate) fn new(chipset: Chipset, bar: &Bar0, gsp_fw= : &GspFirmware) -> Result< wpr2, heap, vf_partition_count: 0, + usable_vram: None, }) } + + /// Set the usable VRAM region from GSP response. + /// + /// Called after GSP boot with the first usable region extracted from + /// GSP's `fbRegionInfoParams`. Usable regions are those that: + /// - Are not reserved for firmware internal use. + /// - Are not protected (hardware-enforced access restrictions). + /// - Support compression (can use GPU memory compression for bandwidt= h). + /// - Support ISO (isochronous memory for display requiring guaranteed= bandwidth). + #[allow(dead_code)] + pub(crate) fn set_usable_vram(&mut self, base: u64, size: u64) { + self.usable_vram =3D Some(base..base.saturating_add(size)); + } } --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012068.outbound.protection.outlook.com [52.101.43.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 631A73502B3; Tue, 24 Feb 2026 22:53:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973638; cv=fail; b=U1a2LBWr7O6VwWB+TfcfhQB8Y/MJsApujKr0ULSj29FlKTqahvim6+89uFfmvBJuTc5iuQ65Q9QvF8J4M3XRnm+nIgto+8N9oN9sslg/jP0d1BHDlwYiyc52+/Fg70yK4tGwLxfM7dGZXBTtW4zgf0Pc39U8Q9PzJmLleYRrFWk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973638; c=relaxed/simple; bh=+zxIHAcI/CX+8QJ/173OhOWRwYlEbhzSNzLILhSIbF4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=oDuao4zWcgkgvTLopaytKFZbAkolt6atNAPbeF2V6+rTkJKEH0nX3NW1M6+gXyNvyTBvEWBsFIHoNxoWAMvW1NTbZQpKIGfGYhaO0gfujU2TSHqm1e4YmnZ7D7S1wzqOMniMWNrLjAiFjfIUZZhgl8bj7DtvG2pXP0Uzp8f3s3M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=TLGnnpvV; arc=fail smtp.client-ip=52.101.43.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="TLGnnpvV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ntJ1dXfeQ7cSve17v/fmtonkfBlFsa6W54x8+9psKG/s0nuIr+W8/ySd1HIGiXUoUoR9AFILZI2mFVvrk7m6uzPLGkwJkcfGSCsVUIL1wIMbcsn3qdmctX2gowbeM7DvFhsdUogU7NuixOPaQ2Qp+/eZByTUL2yYvOhDI3TusPe5/2/CMHM0ffZo68+Fg8ZuRkRAaIOVQLOfAQgWUmX2vf6iwnZO1j8XcuUPb/kZ9DZoxpLcAJgv8m8FayVeg4hZ2gOYlEOkWPuzo+6DkZHENyMoqDdMxtSjhwcup71sEm1+Omp0mi9Vr7nuvk798xPl/s7RjWSaQVTHbVQnzIKGmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oS35ffwLIUKN0sCbhJ9Szs+fyzN29YQTxRT2bYXvTI8=; b=PKA48oX9mnmi5mA7Ejope36l+r1fdj2aeS+FVyB13EAMoGsN/rs38VgJrhiUn4ULQnxqe8rS7xvGwRXrdx4QwQyqlSMrWO5g4sIi6/CALyKyFFK58XokT+Iv10dHasGPk7yWYKxu1+Nzp7ZvDT4eMb1qZSEu7vL4oMtfy9iNrDFRBqel19nkCeW9XeK34pLJWxesT7ob4t/1gEyzOexVV7TzYCxbljdEx3edcK5GlI44E2SUm1sacw9pRkhy/qmpC5fMrOEM1Bo1/OCZaNmFXUkZW8mz5sS3Ut/w2V9nq9AtqCuUlZS+u5JSnoA4gVqIZ3wNktZB/6OhbxBAgYKRJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oS35ffwLIUKN0sCbhJ9Szs+fyzN29YQTxRT2bYXvTI8=; b=TLGnnpvVMgrpVu3GQ5oS3fnEOHqTVZd6M1B22pVb6Lv9517a15fs+oOYIkVJSDrl7noxykb9GEVi4HnYFk6Pw2ItySVA65zY360KcwMm9XnvFkxA4OFeCLDq8fwQXAWdKLsGSjtjHwVS/PJxTZ97NourvQqgHBOSv7GbH6bZmOZIjyw3vUhcYCXZ5LeLyPbzANcJz4d3ooOqbUQqxYV9YKKCjdCPSCFZn9awjZJ95Wmn9uIZeROckebnOBxDW1qvOuJVNZR8+gNlJxU+i/wFxNZMMKU8EUrrvdir7zaPEMciaaad4zHn//rAXgg1JY43hZ4qMCDj8+tQ6SzAjjoDJQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:53:43 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:53:43 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 06/25] gpu: nova-core: mm: Add support to use PRAMIN windows to write to VRAM Date: Tue, 24 Feb 2026 17:53:04 -0500 Message-Id: <20260224225323.3312204-7-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: IA4P220CA0001.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:558::14) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 6109dac6-f7ed-4fc9-a1b6-08de73f78f2b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?R+irCHOG/qkXTb951yB61jwSJovlDPwv+TUGOD3Bud+ER+GQhVxS4nj8ZQd0?= =?us-ascii?Q?yQG9FydrK17POepsVrDkLfX7ZkUjuTbG7o6Fpzqxq5LBhmOpumfkrq4Fwj71?= =?us-ascii?Q?KI0EiDQRAI/DLdmXBm8I43YIxh5hIvc1RZPziQTLL1+ZC9G0StW+pDrqtzVL?= =?us-ascii?Q?ds101YS65qDdE/Jsim3PQZb5cf/Oa5JVnDTd2Nbt7c4DsgNCwIt4iRWYcd9y?= =?us-ascii?Q?Sh7R7xCKTiFeMygK1wrxFakca24XzOl+dhfBxeAKcOKQsqAckUImE02RI6Do?= =?us-ascii?Q?95Z2jQsyPz7BX1f2JLGUwQNAu7uNDL6AQd1MpK+LMfRo8rbyhzDZvvcwrrT8?= =?us-ascii?Q?0J5TM7InDJbgNJg4PZYUuQSGl09ruaNnni23/d6VdPtf1UnV1Cgkw+bOUm6j?= =?us-ascii?Q?vtEP6c444v33UpG6c/6IesPUBEzCJaUDLHjoysnvtEW07VTCVTB0QusHCLNv?= =?us-ascii?Q?1P3peX1Wt+XTMX6QA73FBZfMyhnX/qGypxkZtwj+t+1/Zt5gci2NYIps2V3X?= =?us-ascii?Q?sXsTZShYIV4RJedRHp0cUSgFaSPaxM9m8wZ2Mwrn4uLmrjuaV4rOYY88ufYa?= =?us-ascii?Q?W5FohXF8ypF1WgE4skvTQxDkb804oZkTivbkM4ACnXjVJBel7Gs+523HqVtZ?= =?us-ascii?Q?bufUfS+VRAhZiAve8vPIvnyYWpG4hUgphPPov9g1+NAzq6O6aw5FEEEbmm5e?= =?us-ascii?Q?PuSTKfyKgyi02t5UqdxM/5F9RH+EiEpN2qw8lsc+mOlM9qOFWbFjKAlX3+Mj?= =?us-ascii?Q?+9uHhGjlbg6OBjuI1tbZLJi93c/BHRH0JvJ7L5VOye0r7koQW+2FRGHkt4by?= =?us-ascii?Q?Vnv4cbmSUOAFeUI2rSRmrM4BM5bu8qScweGQyO7DaIY6Mfk+dVGJgIZrIy9P?= =?us-ascii?Q?r+b+RlYWtZak59c2vNTg5ZlozpZrwQ/aJvvU5XK72+g2QlgrtoY2lk90EAcH?= =?us-ascii?Q?nYfCbAPaXVBanEGAks7w3ZLnXeXyU6AzO477QDvFUhXHExkM/zpEuOQpXRXy?= =?us-ascii?Q?MqqdkTx9LrXfhj4PGJ1DyCyysIrHRNcwmbFg4pCqJhbl/K9P5O4yEqyE8dx/?= =?us-ascii?Q?QtBTdnZS0x/ppQKHcm0IKQ+lhoYm1R1TEjTxgLrgCPoGTcIep7LFzRzN3BEw?= =?us-ascii?Q?0CuslXs23j6wQq35sl0OCNaXq+r+oljzpIUhgXE3yjrJf9ifqdgAaFxVj8V4?= =?us-ascii?Q?PlF09/UDQdecc2mOH34MDxfCWlkHzKRcqh0rpeNxJ1LXmhwUQ/USiQpMvWBz?= =?us-ascii?Q?9/LrWLQHoOc66EAW7bZrrAoMdalmG5au8FTsYe5ZpelP5SoCmHcaSnPB6A0S?= =?us-ascii?Q?zJ0tyyeJ9O/PyhbyfJLUougxYLNhtCIvd8pS7S6KC9A0atpRX4scke9PeE2y?= =?us-ascii?Q?6qICMUe7rl5snM+Z4we68gBpxRDEvgUpZMWhgS5zjsOqC72G/8I+1VgB/bT2?= =?us-ascii?Q?o4sRn5TVcsdxV2ApZLhecupRWo4JhrAj4yTKTKZi+J/CnvA4ZFrj8LFR4Rkd?= =?us-ascii?Q?Z6jTJgZ9kH35GtbYKofN1nbWrDkW0XMpfT0+f7UIsJGsGN6L1C7lfbfI6bm+?= =?us-ascii?Q?fRvD4yEz1KaRY/FsVLw=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kyNuptF6YydKBs1nKm/zmhrlkQbZALAE70lXIXvTPIFNubdTq+O0Vg0A3xbV?= =?us-ascii?Q?3cMNNKZd7N+9zRbvwwsCRUeFgOeLc2kEOcO4fBNLIeLbUoi0Bk1wtryA/mNr?= =?us-ascii?Q?Nxn1rBZyW13l9U0AfZXR1DAaN1P0+d4oI89fQby0LLr/QeJwXl3yxDOFHb8U?= =?us-ascii?Q?fIbCiLIb9Dk05K0NXFQXTT3lBLdaY84j2tuxUT8k2jl1hWDiZFj5tL+MVo4t?= =?us-ascii?Q?WpKv4SOPks3jaat7m3rAnVl+m4v/Ey5+FOLYyf6ZJ9+M+60VTu6AAscudiAf?= =?us-ascii?Q?rM7pN9lxczfXCBel8lEJZzyzZWH9vhSLnkzFvDHOyRXq9HzCsdLoCtZAIrdP?= =?us-ascii?Q?IWxmzWCYydXtd+0Cnfk16h+WgNfLXeUf//nSfg+fo8it6b36zJfI4s/cAzUA?= =?us-ascii?Q?YP4mBLAM1z+Tae0QcWF1eihG2Z3djFpLZDrvOEXhqZa14n3VElpXns1aLTlj?= =?us-ascii?Q?N6L+q55KSGvvPEnRfVBzhofrAAL0BsGvWhD4LtTEqIZB0VAddF0Kg3q2YSdZ?= =?us-ascii?Q?ywo/uc5+YEHRtDTLZ/sdTG6mpm2fdvPkoLjEsNWVLGa5MMd3UyUFjYQTS4XH?= =?us-ascii?Q?fKetFNABfi6Xu7SCnRmNI4vfvPE7xI/LiMQcWJbTYcUtOvCiH5k6SmApUgvk?= =?us-ascii?Q?nCSHvsIxQPKfmNf61JntPumesfYivrqCz/cElIAoWGYpEhP0/kKKwPMuuZ/t?= =?us-ascii?Q?q2zJVo0ykD04xNvYCSsKCBpE6EvzR7XmZivJtH+A3nk1Ibg+o23+d5c6CJqJ?= =?us-ascii?Q?j1WF8BNZr/yjS1lH9Owy2j9+2cvzIl65y2rmShBro+lQO9vB6dgJtDSIRuLo?= =?us-ascii?Q?87rioiG0zfQ2CZcfisePPKZXeJD7n46rlpiRU0JYrR1qA+EpCF1+ETuhK53O?= =?us-ascii?Q?4xk6MfpX4lK7uPq2ixAenfopmMBm8LyecKBzoJQSSSuFixDHENWMxRncr/FF?= =?us-ascii?Q?XJGzLODdwr1LdUTf5zPgWgPLWup3IUZRkGaI+TYm4U9Jct+JsiCaYDc88F6R?= =?us-ascii?Q?2ezCvRoD5aaAGBF3RReYv6R4qIk3KecjX9OARf29c6jKrzJfmqhl2z9zQD5G?= =?us-ascii?Q?PVvzcMw5iUFvZFiqRMpAHXvV67+Awn3A6IqIXkZXxzsNaOfpCLAw7016jcUV?= =?us-ascii?Q?1ehxu1cg4XbUs59z9UTNZR5ZyfReu5hF7XZrrp1sT2sSXV6UPPva2HpYnabc?= =?us-ascii?Q?sxXOCU+2O10qKCAgJEGf5k8dUZagn/LrhfmoCNeOuS1wV115Hlpwa5JYA6xS?= =?us-ascii?Q?IKjxy3qGEAiXSCAJ/L4vRRk/yY7tSDCNgXP8L6EdpHweiqnAShY1vPa8ZjsA?= =?us-ascii?Q?XcACrEd/zPkjgJnJlKTtr0Kkzs3G5Eycwsin2wYWxsUoVUYDA5vD2MqsIFqh?= =?us-ascii?Q?DEa09f/XDf8EBhlD208rSlN5OhTpDEYczonLsJoHsFuc5vs31QU03Ki1K8Az?= =?us-ascii?Q?HYntohDQnnpAJ984fuB7D6pWo2xJ6uW4cN/sRc9f9zpRTQyERoC3fkv+K6a+?= =?us-ascii?Q?BivacJsiDlETXOh8UYGvmTMwe3z555mpGgIZlw7NHqbM4mtHu8sHMBXvR+4V?= =?us-ascii?Q?RbP0upMci9ihxwR7lECQcSzbOMaCaGWIhtu9Y7fQUudBIFRjWb4C8rxaTYQT?= =?us-ascii?Q?1R0cBcZSz21PIpC0zjKOpKCLKzyMErdBX0w3zIX42tDfF+oR2LemHtFUZvdQ?= =?us-ascii?Q?piPKm3JgMIf+exPTGfrKqKTNBDwlSN4YRU7I2Ua5uD6k16wkwIoyAHczhV5t?= =?us-ascii?Q?fOVq46pw8w=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6109dac6-f7ed-4fc9-a1b6-08de73f78f2b X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:43.2239 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pnsCAnEfv0vGpz1lLQPD3+Vml500mhM81YoiLoOYAwVJQZTU7eXLlpsidMV+ritW74C6Yf/7nqs5mruNK9cf3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" PRAMIN apertures are a crucial mechanism to direct read/write to VRAM. Add support for the same. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/mm.rs | 5 + drivers/gpu/nova-core/mm/pramin.rs | 292 +++++++++++++++++++++++++++++ drivers/gpu/nova-core/nova_core.rs | 1 + drivers/gpu/nova-core/regs.rs | 5 + 4 files changed, 303 insertions(+) create mode 100644 drivers/gpu/nova-core/mm.rs create mode 100644 drivers/gpu/nova-core/mm/pramin.rs diff --git a/drivers/gpu/nova-core/mm.rs b/drivers/gpu/nova-core/mm.rs new file mode 100644 index 000000000000..7a5dd4220c67 --- /dev/null +++ b/drivers/gpu/nova-core/mm.rs @@ -0,0 +1,5 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Memory management subsystems for nova-core. + +pub(crate) mod pramin; diff --git a/drivers/gpu/nova-core/mm/pramin.rs b/drivers/gpu/nova-core/mm/= pramin.rs new file mode 100644 index 000000000000..04b652d3ee4f --- /dev/null +++ b/drivers/gpu/nova-core/mm/pramin.rs @@ -0,0 +1,292 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Direct VRAM access through the PRAMIN aperture. +//! +//! PRAMIN provides a 1MB sliding window into VRAM through BAR0, allowing = the CPU to access +//! video memory directly. Access is managed through a two-level API: +//! +//! - [`Pramin`]: The parent object that owns the BAR0 reference and synch= ronization lock. +//! - [`PraminWindow`]: A guard object that holds exclusive PRAMIN access = for its lifetime. +//! +//! The PRAMIN aperture is a 1MB region at BAR0 + 0x700000 for all GPUs. T= he window base is +//! controlled by the `NV_PBUS_BAR0_WINDOW` register and must be 64KB alig= ned. +//! +//! # Examples +//! +//! ## Basic read/write +//! +//! ```no_run +//! use crate::driver::Bar0; +//! use crate::mm::pramin; +//! use kernel::devres::Devres; +//! use kernel::prelude::*; +//! use kernel::sync::Arc; +//! +//! fn example(devres_bar: Arc>) -> Result<()> { +//! let pramin =3D Arc::pin_init(pramin::Pramin::new(devres_bar)?, GFP= _KERNEL)?; +//! let mut window =3D pramin.window()?; +//! +//! // Write and read back. +//! window.try_write32(0x100, 0xDEADBEEF)?; +//! let val =3D window.try_read32(0x100)?; +//! assert_eq!(val, 0xDEADBEEF); +//! +//! Ok(()) +//! // Original window position restored on drop. +//! } +//! ``` +//! +//! ## Auto-repositioning across VRAM regions +//! +//! ```no_run +//! use crate::driver::Bar0; +//! use crate::mm::pramin; +//! use kernel::devres::Devres; +//! use kernel::prelude::*; +//! use kernel::sync::Arc; +//! +//! fn example(devres_bar: Arc>) -> Result<()> { +//! let pramin =3D Arc::pin_init(pramin::Pramin::new(devres_bar)?, GFP= _KERNEL)?; +//! let mut window =3D pramin.window()?; +//! +//! // Access first 1MB region. +//! window.try_write32(0x100, 0x11111111)?; +//! +//! // Access at 2MB - window auto-repositions. +//! window.try_write32(0x200000, 0x22222222)?; +//! +//! // Back to first region - window repositions again. +//! let val =3D window.try_read32(0x100)?; +//! assert_eq!(val, 0x11111111); +//! +//! Ok(()) +//! } +//! ``` + +#![expect(unused)] + +use crate::{ + driver::Bar0, + num::u64_as_usize, + regs, // +}; + +use kernel::bits::genmask_u64; +use kernel::devres::Devres; +use kernel::io::Io; +use kernel::new_mutex; +use kernel::prelude::*; +use kernel::ptr::{ + Alignable, + Alignment, // +}; +use kernel::sizes::{ + SZ_1M, + SZ_64K, // +}; +use kernel::sync::{ + lock::mutex::MutexGuard, + Arc, + Mutex, // +}; + +/// PRAMIN aperture base offset in BAR0. +const PRAMIN_BASE: usize =3D 0x700000; + +/// PRAMIN aperture size (1MB). +const PRAMIN_SIZE: usize =3D SZ_1M; + +/// 64KB alignment for window base. +const WINDOW_ALIGN: Alignment =3D Alignment::new::(); + +/// Maximum addressable VRAM offset (40-bit address space). +/// +/// The `NV_PBUS_BAR0_WINDOW` register has a 24-bit `window_base` field (b= its 23:0) that stores +/// bits [39:16] of the target VRAM address. This limits the addressable s= pace to 2^40 bytes. +const MAX_VRAM_OFFSET: usize =3D u64_as_usize(genmask_u64(0..=3D39)); + +/// Generate a PRAMIN read accessor. +macro_rules! define_pramin_read { + ($name:ident, $ty:ty) =3D> { + #[doc =3D concat!("Read a `", stringify!($ty), "` from VRAM at the= given offset.")] + pub(crate) fn $name(&mut self, vram_offset: usize) -> Result<$ty> { + // Compute window parameters without bar reference. + let (bar_offset, new_base) =3D + self.compute_window(vram_offset, ::core::mem::size_of::<$t= y>())?; + + // Update window base if needed and perform read. + let bar =3D self.bar.try_access().ok_or(ENODEV)?; + if let Some(base) =3D new_base { + Self::write_window_base(&bar, base); + self.state.current_base =3D base; + } + bar.$name(bar_offset) + } + }; +} + +/// Generate a PRAMIN write accessor. +macro_rules! define_pramin_write { + ($name:ident, $ty:ty) =3D> { + #[doc =3D concat!("Write a `", stringify!($ty), "` to VRAM at the = given offset.")] + pub(crate) fn $name(&mut self, vram_offset: usize, value: $ty) -> = Result { + // Compute window parameters without bar reference. + let (bar_offset, new_base) =3D + self.compute_window(vram_offset, ::core::mem::size_of::<$t= y>())?; + + // Update window base if needed and perform write. + let bar =3D self.bar.try_access().ok_or(ENODEV)?; + if let Some(base) =3D new_base { + Self::write_window_base(&bar, base); + self.state.current_base =3D base; + } + bar.$name(value, bar_offset) + } + }; +} + +/// PRAMIN state protected by mutex. +struct PraminState { + current_base: usize, +} + +/// PRAMIN aperture manager. +/// +/// Call [`Pramin::window()`] to acquire exclusive PRAMIN access. +#[pin_data] +pub(crate) struct Pramin { + bar: Arc>, + /// PRAMIN aperture state, protected by a mutex. + /// + /// # Safety + /// + /// This lock is acquired during the DMA fence signalling critical pat= h. + /// It must NEVER be held across any reclaimable CPU memory / allocati= ons + /// (`GFP_KERNEL`), because the memory reclaim path can call + /// `dma_fence_wait()`, which would deadlock with this lock held. + #[pin] + state: Mutex, +} + +impl Pramin { + /// Create a pin-initializer for PRAMIN. + pub(crate) fn new(bar: Arc>) -> Result= > { + let bar_access =3D bar.try_access().ok_or(ENODEV)?; + let current_base =3D Self::try_read_window_base(&bar_access)?; + + Ok(pin_init!(Self { + bar, + state <- new_mutex!(PraminState { current_base }, "pramin_stat= e"), + })) + } + + /// Acquire exclusive PRAMIN access. + /// + /// Returns a [`PraminWindow`] guard that provides VRAM read/write acc= essors. + /// The [`PraminWindow`] is exclusive and only one can exist at a time. + pub(crate) fn window(&self) -> Result> { + let state =3D self.state.lock(); + let saved_base =3D state.current_base; + Ok(PraminWindow { + bar: self.bar.clone(), + state, + saved_base, + }) + } + + /// Read the current window base from the BAR0_WINDOW register. + fn try_read_window_base(bar: &Bar0) -> Result { + let reg =3D regs::NV_PBUS_BAR0_WINDOW::read(bar); + let base =3D u64::from(reg.window_base()); + let shifted =3D base.checked_shl(16).ok_or(EOVERFLOW)?; + shifted.try_into().map_err(|_| EOVERFLOW) + } +} + +/// PRAMIN window guard for direct VRAM access. +/// +/// This guard holds exclusive access to the PRAMIN aperture. The window a= uto-repositions +/// when accessing VRAM offsets outside the current 1MB range. Original wi= ndow position +/// is saved on creation and restored on drop. +/// +/// Only one [`PraminWindow`] can exist at a time per [`Pramin`] instance = (enforced by the +/// internal `MutexGuard`). +pub(crate) struct PraminWindow<'a> { + bar: Arc>, + state: MutexGuard<'a, PraminState>, + saved_base: usize, +} + +impl PraminWindow<'_> { + /// Write a new window base to the BAR0_WINDOW register. + fn write_window_base(bar: &Bar0, base: usize) { + // CAST: + // - We have guaranteed that the base is within the addressable ra= nge (40-bits). + // - After >> 16, a 40-bit aligned base becomes 24 bits, which fit= s in u32. + regs::NV_PBUS_BAR0_WINDOW::default() + .set_window_base((base >> 16) as u32) + .write(bar); + } + + /// Compute window parameters for a VRAM access. + /// + /// Returns (`bar_offset`, `new_base`) where: + /// - `bar_offset`: The BAR0 offset to use for the access. + /// - `new_base`: `Some(base)` if window needs repositioning, `None` o= therwise. + fn compute_window( + &self, + vram_offset: usize, + access_size: usize, + ) -> Result<(usize, Option)> { + // Validate VRAM offset is within addressable range (40-bit addres= s space). + let end_offset =3D vram_offset.checked_add(access_size).ok_or(EINV= AL)?; + if end_offset > MAX_VRAM_OFFSET + 1 { + return Err(EINVAL); + } + + // Calculate which 64KB-aligned base we need. + let needed_base =3D vram_offset.align_down(WINDOW_ALIGN); + + // Calculate offset within the window. + let offset_in_window =3D vram_offset - needed_base; + + // Check if access fits in 1MB window from this base. + if offset_in_window + access_size > PRAMIN_SIZE { + return Err(EINVAL); + } + + // Return bar offset and whether window needs repositioning. + let new_base =3D if self.state.current_base !=3D needed_base { + Some(needed_base) + } else { + None + }; + + Ok((PRAMIN_BASE + offset_in_window, new_base)) + } + + define_pramin_read!(try_read8, u8); + define_pramin_read!(try_read16, u16); + define_pramin_read!(try_read32, u32); + define_pramin_read!(try_read64, u64); + + define_pramin_write!(try_write8, u8); + define_pramin_write!(try_write16, u16); + define_pramin_write!(try_write32, u32); + define_pramin_write!(try_write64, u64); +} + +impl Drop for PraminWindow<'_> { + fn drop(&mut self) { + // Restore the original window base if it changed. + if self.state.current_base !=3D self.saved_base { + if let Some(bar) =3D self.bar.try_access() { + Self::write_window_base(&bar, self.saved_base); + + // Update state to reflect the restored base. + self.state.current_base =3D self.saved_base; + } + } + // MutexGuard drops automatically, releasing the lock. + } +} diff --git a/drivers/gpu/nova-core/nova_core.rs b/drivers/gpu/nova-core/nov= a_core.rs index c1121e7c64c5..3de00db3279e 100644 --- a/drivers/gpu/nova-core/nova_core.rs +++ b/drivers/gpu/nova-core/nova_core.rs @@ -13,6 +13,7 @@ mod gfw; mod gpu; mod gsp; +mod mm; mod num; mod regs; mod sbuffer; diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs index ea0d32f5396c..d0982e346f74 100644 --- a/drivers/gpu/nova-core/regs.rs +++ b/drivers/gpu/nova-core/regs.rs @@ -102,6 +102,11 @@ fn fmt(&self, f: &mut kernel::fmt::Formatter<'_>) -> k= ernel::fmt::Result { 31:16 frts_err_code as u16; }); =20 +register!(NV_PBUS_BAR0_WINDOW @ 0x00001700, "BAR0 window control for PRAMI= N access" { + 25:24 target as u8, "Target memory (0=3DVRAM, 1=3DSYS_MEM_COH, 2=3DS= YS_MEM_NONCOH)"; + 23:0 window_base as u32, "Window base address (bits 39:16 of FB add= r)"; +}); + // PFB =20 // The following two registers together hold the physical system memory ad= dress that is used by the --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012068.outbound.protection.outlook.com [52.101.43.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1408A35B137; Tue, 24 Feb 2026 22:53:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973640; cv=fail; b=Quj6nnJHKmcwy+nH1YBv4pAbW3pfYBNVoI04tD4/xoklX05wfPEghtZo2GzudSKvwSmMSNQTBjkBbLv8M39+FIFrxmTLZ+ODhVpOzwKCGJmO8p1hF/AS4uttNYVi63xOR63xAblkbwXLbkwqsD3d1Fs1oImv8qEaK9dCsabtKaU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973640; c=relaxed/simple; bh=n1hqeGjbdx5mSIk4s+W7Nrr/aMPkJT1rKKGQRkTEh4s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=bU8CKxbEsXzsAfGSBD5p8JQKxfgn7hnhsvYGOnW4iMwH3RUzUVOEVbeYQ3Xfq/QKvgQRDqtWc/cB8Bb1Ff6jQO0QQT8X8cmHxLUJzP7iKcCW7LijGgSR2mnBtPp7McuIgQd74UvexPMH3+zcVmawSaEEEiZ3jtuJseqP7i2iqYo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=LzMtjjcM; arc=fail smtp.client-ip=52.101.43.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="LzMtjjcM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bl/h7cmr/qFkKyF4Dckvx/jZWE3p0giAP2kX86d6tiwtNG1aKHiy2CByyKTL3pHR6QC0OhBgn2atHX2i0Y8vpe5nlOaNOpUVg/nk+2tlgIcSyZiZSk6Z5gfiG7MMB1WoGX2TH6Ph8/DhBiWKDYNoyamykEbl+W67NotuifSRz4bWrFPKQYPKimKz5/GlHt4aEX0xZ4xrWKtk3y863FsWbxIZzRRYq9oOlX7LfKl4lVVKMwN6aMWrx5M73N2+kMpyrGXwaLLTpZitS/DhZgjs4NFSc1uk0qfF1dVsXSUyOSSWgr2YoWPo+g5Jtox4jC3q/SfLGCfH+4qapPEFyGTliQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F49cACl3HIGmeiyHiHJIq2FrsVqFrqeo3rTN1RQXi6c=; b=v2GCnoDkC/1D7J/m3ZM6NqTlGlOuEEcZC6mAt1FlQ1FMLXTX4YKvV9NOIlV9QeqNcysn1SyqjB1TJ4/5rs4tUwvBZ4qtOrbFMz5+zPf1Nl7MvlTwnn0RKAQppvJNT19eaEv3pf/nOWxFW79LNpvVB1ue9sVvjVDMJ9BGB5seceivzgqdU7xLfjr/IoIRYTG1pXXCP7QsNsC4MVl6k50eBjDpbE5IP7ZhoHVx2e+g7UJjD5F8YoTGoQw2we3D/2bCB4GnMEp8rejHQ+yBD1X31ZZMrnUCoeTgcl/NBjNDak2LGL3+ldQRfO8y5CwmIrhjrc8kXf1JmuIerF/LxSdWyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F49cACl3HIGmeiyHiHJIq2FrsVqFrqeo3rTN1RQXi6c=; b=LzMtjjcM6OW/FcnyUEF1RRynCAJ5N5mPYGU4l/wSuwJLYAFn9LIAVsBF0Fib57JkC/gr4o4pFhgRsZWqKipKPYKTwHbvuVd7iDff2jGOhP2aAJYM2kGucRF4y30Vg7t3B7yD5F7P6pXonQ58KBPxJZj3pddIs008bdRm+7E6WP5+EncMFvdw/xEUxRR3WttsfrnoAJDUjrh3UNKn0IynEBcqgulJY4OuV/vNrSh4FggVbgtn1Y2VEMTh13POx36aP7pGZOHUtGzW3kxQsTLoRnTQrichXtecuGPXW86g5Mb+RALCun82AcphRnNISL9oly2CUB5Aq+T2j+USBOuCJw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:53:44 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:53:44 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 07/25] docs: gpu: nova-core: Document the PRAMIN aperture mechanism Date: Tue, 24 Feb 2026 17:53:05 -0500 Message-Id: <20260224225323.3312204-8-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BLAPR03CA0119.namprd03.prod.outlook.com (2603:10b6:208:32a::34) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 3cdd46c5-ec6c-4f78-c745-08de73f7901a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?v7pMrKD5CkHBlMaq2YHIFtSFYRHMMt3Uobsy9nqhC1pB5oXA2HLQ84lH1zIM?= =?us-ascii?Q?H4KvR6BLDJd+wQOADamsNMaCWZoWWSOKqaXy5KJxcgkiLXXHnUQ0C7gudEkz?= =?us-ascii?Q?6/mMkGzeVdnm0Cq/rkJJy7dWcb0Rm+uQZjI5Ug1IFaAGXj0o9clOCDxmRvkH?= =?us-ascii?Q?wE8cqUpIxbYupUGYTSDw94+PPuYzdcKnX8o/4dugjRyJS7CjEB5pyaAQqGBz?= =?us-ascii?Q?Nfy6WAtodbva4C1OyjWOrTVUdzBva/K9pJ8O25D+KRTwQ3+0ZXaGvQ+ZvQRn?= =?us-ascii?Q?/PGT2Ksb8xVS8akF4lJIGkDBtFYUtjOrMUEbtD2ITy0Lmtr4lLIefcmjHGjY?= =?us-ascii?Q?5kAcGgSfsKVTUStqsqD+kVcYX6AjuinswU+anVvjmakdIX6HfGjoNRJFTOfB?= =?us-ascii?Q?c57C8KlwNvAQRB84aWiSkC641eUdyFlflFJ2IIoE/JUslAOg4wRD+BKvvpuY?= =?us-ascii?Q?r5lHyqko/bCls+U8+swaYdBl7imskvAo3t1UUPZ4NDsNCXGRs/GUuyq1FgQQ?= =?us-ascii?Q?LruXQ0P/nLSJZ/h4UfVrFvdPL29ZWax0l12zs+v2lvX5IIgkuYUEDkkqSEQg?= =?us-ascii?Q?NlfusmJRzkjMuuNG+1aqOueqrNcaoiF8nO6Juu3aiYsW/0w1VvM0DWyg8OAV?= =?us-ascii?Q?IOL3OQLI+7dxrlAOKp8iIbiabDDaRO+05Vc5aVy/TuZ8RHm3yYQkbkYztf48?= =?us-ascii?Q?SiP0T0NbCf+5Sqn1BYZsgKum/mVHguY0/zeUihuySgDNABGGFnIPbQwK1S00?= =?us-ascii?Q?eR3+ORibS+O73V2ilmrcGPcM93USmABOdQxsJFE0a0eYOJdgXutINU8Vtmdm?= =?us-ascii?Q?GWWPjqZevlVstW+LWzWyJLaIxBr+0ariNCEZEANHpbVAkfoHly7DQ0z7YxP+?= =?us-ascii?Q?An6EGXS12d7yHc9Me6RbjSu8WM9Xx1bXLLP7nDZV/FqDY/aolJxZJ4g7BpqA?= =?us-ascii?Q?9iEqgxlt69lg5cstpszaWxEMCenP1qWtRncSVZ1C5QY1d6y/o8iiZY1KVfzb?= =?us-ascii?Q?5kJxw9GDol9qaP7aPI9drn6u2CsTpQdY7ldi93pi5FIl4tLdZRMG2XH6hEY7?= =?us-ascii?Q?SpSmdzhGx+M3OWrds/F3+uS7z1R7hVVl86xiPlCcNwyBtWyLHrjLIdLuiWgB?= =?us-ascii?Q?o6ochc/cTa3+T37btMr5pwwSM9scV/uet1rmZzZfJW+dzc1jXOgDhutpAPmH?= =?us-ascii?Q?5l+A0qGf1V+E3bc3uXriMAThShhCNMqZ/MyqMryHbUgcTK7sK9UMmm+Uq3Wy?= =?us-ascii?Q?G/LRtu1JZ3qQhfFLhoNk7uDjk+NWIYhu/39UWm0nWWsRh2On2rp3gzJ+Rorc?= =?us-ascii?Q?lC15uSrBv9TAL9tQM4O2jk/4J7U9mPspItbUtw7X/9Oks2epfZjQHOKosETM?= =?us-ascii?Q?7zC5uAWHGI0btD7IzD3xkwu2oaz5KB8MaHpjEqHCbn4TRRtxcFhzbkR+FcWj?= =?us-ascii?Q?OId0C4w3nFsIhEoMsTbFUOUUfK2ixjCvOWFiBozfNAEB6jq29/GFObpNURxC?= =?us-ascii?Q?E82uowSB2B5v2wLalvhCHnz/HdBAqI/c1FYYLwd50u/SqVMyYCqurx+AE4b3?= =?us-ascii?Q?Br5lrfuSHdJuwD7zpTE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FA2AkK2bLVK/tuGDXoR5PGW1Qo6tFbhkpLvvpDVd8C98ktj4aqqPBh0JsqgG?= =?us-ascii?Q?sTjo1uzDahy1ZB9ealZY/nfm1ErHBR8u7CmWoQo4vmeJUd9yCePqlskWRe5Y?= =?us-ascii?Q?lLLSaIhsdSnX79SHC0FfbLFpOPjlanJxvtK+pPb7WqXirUWQ/VEUeIT9GP5V?= =?us-ascii?Q?dhZ8nl+x7VWPEPp5sAEK/8ZmFurnJD+bZN+ZHNfgQNKtVf9CbehXl1Nv3Dt6?= =?us-ascii?Q?wc4EgAnJwMG/6u/b7CjBMCX985lohLgGm9Yzlg1hyCSq+Y83vXBv8fHROC8k?= =?us-ascii?Q?J9kuCJd9jFoo3gn+q1kJ/XF/7h5+wfAJbWLlQFPzeVO05ItHu7BNUhjha1u1?= =?us-ascii?Q?0vLGXAq6XPCiUnd+I3rCaVSU3Iai0fiLcMDW7Olodq84usX8v9jHOXqikPGw?= =?us-ascii?Q?wCoA0TWeEqo3YM0w0lIIdeTYuVxet9cFSyHmETHABpysPusyDv99JhBUL6zA?= =?us-ascii?Q?eYrSCvEUDcNPCTdtVIWaBHaeNDyONqtb7LoYSXlUr7sf3MCOBuJoeLELrxjO?= =?us-ascii?Q?Yrta1owaVERMWzpaBsnD2vanBDIWy8mK9zJqHf8QbqB3CSWolFT1viwlfDTw?= =?us-ascii?Q?SqwwskN4WOyBmOCJ+uLD+stomP0Ae3aHgn6NP46omKmddF0hPTYlgdlzByHU?= =?us-ascii?Q?vn2m3D/9m4f6tvTSJ+ug9B/3AYbfJSUtGBmFFnaVzS+XFQEYYX24xes125z7?= =?us-ascii?Q?PkHV/1C2S9qipwuBzfgNtg1Byh8cX/4oYhutsV/AQhrgSXop8wxntWknFzBI?= =?us-ascii?Q?Y4stHOosFcdwb0Xg5eivlScSNehSHxUOMUwqniipuiQMLpCTmrFcFHntGW/k?= =?us-ascii?Q?7h44unp0pqXMjdqGld2kQPx2w1EFry6j5rzN/Us3DndoOkEExHPqymuD95un?= =?us-ascii?Q?rytX2Kkb0nnU1YXMGwlw6+qVgmAR5MSToprtIPEVEZljPE/8CxHDNPkyR3Rw?= =?us-ascii?Q?3BJlFH/YG2SW6U3lZ5F3jvHkxN2Toty0Ik+soy2jmYdSn14t+IE6v/X7yWIH?= =?us-ascii?Q?JotUp93lfeEX6dYKvfl2B6PHuav9OwU7j4g9HMdHxgTEEPl0TvZHnTbQoQgW?= =?us-ascii?Q?Uegx6EAh4pVg/ph6CdCxbJ5HgshmFDH5tt695jpG0pPY23d9OjpEtj5g+8kX?= =?us-ascii?Q?+61PVSPnvBs0Z2DyFWAwsmseWR27xuvc9AEoN++jtjwvmBRILJbaSuoLzq0K?= =?us-ascii?Q?e3lvsFDw/QotJuRU/arWhXQbSLHgtXFkiGYjbBRZaH6r8KDQlCdl8l3/JEcP?= =?us-ascii?Q?M6gLZHVsjp0R0Z3/q77Bw8ShkONxyYYU0NbiX/rId98iqZlFUxlTNySVzYCJ?= =?us-ascii?Q?45I/4vQmNOs/TkdhFm9Ei13xN62GJFwud53ZlOy3lsGuzMSJISMfcIJFX4kj?= =?us-ascii?Q?GiA1m7WfSFQgo1EWLh3S5aZ9mFjMJP/xbYHpJI7HluAGJbaTJh0F1M1OecJP?= =?us-ascii?Q?tUYeCoYtMZf6YQCfivntrTm2jYhttd3ZMt0nM8sUNvvQ+oIo9WALlPPErt6f?= =?us-ascii?Q?AiRSE3LHJHSmtcPYI2+IH99l00ButGPTgT2awHARtQJHF8mEbKnRXnMoktwn?= =?us-ascii?Q?VUP8KdxEWtRlnz3FtuySHwhwE5TNI0fdQOaU/CZ0wDiHyQAAtVOT0+lrOEbo?= =?us-ascii?Q?6H433FEBpu4QSVKoEHTFqRIGP7SeJy61OHi00tY2PCpb3asQJld9OwhKlQdS?= =?us-ascii?Q?TJofySpsWoeoFNX1qeUFFew2zOY+iFQS+70BsJ6qJeM+zW0CihaRfSy/rUBi?= =?us-ascii?Q?aLFHhlrp/g=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3cdd46c5-ec6c-4f78-c745-08de73f7901a X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:44.6920 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bsnGqCazWxWgySMwlnn8Ib0ow27jLWpJcT8fmcP/kAmnZY028MLV1Lvto6ys8mq4uvjX/poPuxXar1mgsSIDPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add documentation for the PRAMIN aperture mechanism used by nova-core for direct VRAM access. Nova only uses TARGET=3DVID_MEM for VRAM access. The SYS_MEM target values are documented for completeness but not used by the driver. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- Documentation/gpu/nova/core/pramin.rst | 125 +++++++++++++++++++++++++ Documentation/gpu/nova/index.rst | 1 + 2 files changed, 126 insertions(+) create mode 100644 Documentation/gpu/nova/core/pramin.rst diff --git a/Documentation/gpu/nova/core/pramin.rst b/Documentation/gpu/nov= a/core/pramin.rst new file mode 100644 index 000000000000..55ec9d920629 --- /dev/null +++ b/Documentation/gpu/nova/core/pramin.rst @@ -0,0 +1,125 @@ +.. SPDX-License-Identifier: GPL-2.0 + +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D +PRAMIN aperture mechanism +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D + +.. note:: + The following description is approximate and current as of the Ampere f= amily. + It may change for future generations and is intended to assist in under= standing + the driver code. + +Introduction +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +PRAMIN is a hardware aperture mechanism that provides CPU access to GPU Vi= deo RAM (VRAM) before +the GPU's Memory Management Unit (MMU) and page tables are initialized. Th= is 1MB sliding window, +located at a fixed offset within BAR0, is essential for setting up page ta= bles and other critical +GPU data structures without relying on the GPU's MMU. + +Architecture Overview +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +The PRAMIN aperture mechanism is logically implemented by the GPU's PBUS (= PCIe Bus Controller Unit) +and provides a CPU-accessible window into VRAM through the PCIe interface:: + + +-----------------+ PCIe +------------------------------+ + | CPU |<----------->| GPU | + +-----------------+ | | + | +----------------------+ | + | | PBUS | | + | | (Bus Controller) | | + | | | | + | | +--------------+<------------ (w= indow starts at + | | | PRAMIN | | | B= AR0 + 0x700000) + | | | Window | | | + | | | (1MB) | | | + | | +--------------+ | | + | | | | | + | +---------|------------+ | + | | | + | v | + | +----------------------+<----------= -- (Program PRAMIN to any + | | VRAM | | 64= KB-aligned VRAM boundary) + | | (Several GBs) | | + | | | | + | | FB[0x000000000000] | | + | | ... | | + | | FB[0x7FFFFFFFFFF] | | + | +----------------------+ | + +------------------------------+ + +PBUS (PCIe Bus Controller) is responsible for, among other things, handlin= g MMIO +accesses to the BAR registers. + +PRAMIN Window Operation +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +The PRAMIN window provides a 1MB sliding aperture that can be repositioned= over +the entire VRAM address space using the ``NV_PBUS_BAR0_WINDOW`` register. + +Window Control Mechanism +------------------------- + +The window position is controlled via the PBUS ``BAR0_WINDOW`` register:: + + NV_PBUS_BAR0_WINDOW Register (0x1700): + +-------+--------+--------------------------------------+ + | 31:26 | 25:24 | 23:0 | + | RSVD | TARGET | BASE_ADDR | + | | | (bits 39:16 of VRAM address) | + +-------+--------+--------------------------------------+ + + BASE_ADDR field (bits 23:0): + - Contains bits [39:16] of the target VRAM address + - Provides 40-bit (1TB) address space coverage + - Must be programmed with 64KB-aligned addresses + + TARGET field (bits 25:24): + - 0x0: VRAM (Video Memory) + - 0x1: SYS_MEM_COH (Coherent System Memory) + - 0x2: SYS_MEM_NONCOH (Non-coherent System Memory) + - 0x3: Reserved + + .. note:: + Nova only uses TARGET=3DVRAM (0x0) for video memory access. The SYS= _MEM + target values are documented here for hardware completeness but are + not used by the driver. + +64KB Alignment Requirement +--------------------------- + +The PRAMIN window must be aligned to 64KB boundaries in VRAM. This is enfo= rced +by the ``BASE_ADDR`` field representing bits [39:16] of the target address= :: + + VRAM Address Calculation: + actual_vram_addr =3D (BASE_ADDR << 16) + pramin_offset + Where: + - BASE_ADDR: 24-bit value from NV_PBUS_BAR0_WINDOW[23:0] + - pramin_offset: 20-bit offset within the PRAMIN window [0x00000-0xFFF= FF] + + Example Window Positioning: + +---------------------------------------------------------+ + | VRAM Space | + | | + | 0x000000000 +-----------------+ <-- 64KB aligned | + | | PRAMIN Window | | + | | (1MB) | | + | 0x0000FFFFF +-----------------+ | + | | + | | ^ | + | | | Window can slide | + | v | to any 64KB-aligned boundary | + | | + | 0x123400000 +-----------------+ <-- 64KB aligned | + | | PRAMIN Window | | + | | (1MB) | | + | 0x1234FFFFF +-----------------+ | + | | + | ... | + | | + | 0x7FFFF0000 +-----------------+ <-- 64KB aligned | + | | PRAMIN Window | | + | | (1MB) | | + | 0x7FFFFFFFF +-----------------+ | + +---------------------------------------------------------+ diff --git a/Documentation/gpu/nova/index.rst b/Documentation/gpu/nova/inde= x.rst index e39cb3163581..b8254b1ffe2a 100644 --- a/Documentation/gpu/nova/index.rst +++ b/Documentation/gpu/nova/index.rst @@ -32,3 +32,4 @@ vGPU manager VFIO driver and the nova-drm driver. core/devinit core/fwsec core/falcon + core/pramin --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012068.outbound.protection.outlook.com [52.101.43.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6AA435C1B6; Tue, 24 Feb 2026 22:54:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973642; cv=fail; b=seYB4oQKP2DLh8EP9cSxWsETVZXUk3uPzF1DgHStI0QX5OXpO82NqkFOY9v943LqMX1Kpms/AMbQdSroQxvdSTKswwTmOkTmH45PWE+kMlijGX4J7zi11e3CpNggyvXEZOMazC0idSgGMO1X3bhjQgJ5e8RTIxc2c27HJurz0YI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973642; c=relaxed/simple; bh=brG2ukR0yY8Xg655mEM4/sMIcvp+7ubb8LkxpY9l1IQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=u06LrWEV6l5EDcPN3hJzYwBOEDLRXZ1eCyDj4BMOpTiW8NrWyaKC/menu6zZY6i/6jIe8WKK4mnUCp3iY9+gcBUVr5y+C1vAg2NbETDTSB/wLRHIWThb3tnPZbzBD4ntOnbX1B6NtnVv5e1tV0x/waMBcSgzxm2Ae8PBjsfYMk4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=LU17rnwE; arc=fail smtp.client-ip=52.101.43.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="LU17rnwE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AA44LE7glNme9gwlmRWlP6zmkOK6jcnnjp47ppdP9bH1rz7T23inzVgAG3tuhFjHxSoMZq6Dyf2LVujjrOeFeB1oBF5ZLi2Zhx8pLaxef3RiAFNT6BWzkzNvG25zNzvKqkUFaRXBxosCPSrCcRFIVjZZInCm3LqC6wQp9+jyTQ+kI8+nOuIoaJPQe5BAKODsYOarz22nbM1jBUYGJgwzTp4WGXumZvG5IoBPZ3qbIP82pu7L9/xAvuRoBPNG9TiaAZkXEnsMPqiB6wj5EPksBzL6qC0zpg3gdkL5Q5BdvoaqX9sDzfs710/+sRBtR7VaeDeJzMVgn8qEJdFhigtITg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c9le9zPmfGGE54JcHse8SBISSPbKA3QFpZI2evo42hs=; b=cpdV+6e9n6CfsMlAEbcTVHhoh9zR++hCq9EsaF2kwjTt1ZOb4Y+7OP5ZwzB8KUOM8/qyUedANGo9DjdOaeGcwjSNLd+9IrPPl2CM/4oBZzWzd81FJEZtb/yGwHu7512NRDBE2V4Xm7N3APbrPZZUsJ2r7Nr3ulxR5I7Med/kQCtu2I5bdGGb8Tz1CaNgEZg1YC/tEhMmnAUj5hGJ5RWlegeADSLaalY9EC7F+ha5D4R4fLSVhNbHUp5CWY34KblWBlsP6GK26GMSCF3pWkdejCX0tbe+pHy83BDSya73QLY1+q8qoo7X6V5GjcNQ9OU4LX3qW/zjgMLKwHDyFfQYjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c9le9zPmfGGE54JcHse8SBISSPbKA3QFpZI2evo42hs=; b=LU17rnwE8LGH2f3/J611OEOWRZWKQoAriE5iAfIhY1VsXk13xNrwMVgRkJ2ua8pwt7dpuicU37WlxXBDZ20zF+IszEDUfoCr5cO4SrB8z1pMX2Vk342hRyYOUu1fX6WKBEPWs4G6siKkZGBveyzdOKIC4NI0evqL4S7BFkdasorFLVlPA6JhciJU+ZyWV+BywLM4+2bQox6da4ueLzME7U1sw8NBm8x+SeypRuoPYyqVMJsg69IgRjC/A7ZTYIlhfZutvNCLQfUxqejPTBH6AiEXafcZxRo/R8jZZNIk08BGXd0b04IwSIzYyJUI0FWUL5fqQi8EKjGwTqWqa+NILg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:53:46 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:53:46 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 08/25] gpu: nova-core: mm: Add common memory management types Date: Tue, 24 Feb 2026 17:53:06 -0500 Message-Id: <20260224225323.3312204-9-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: IA1P220CA0022.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:464::11) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 91b23abe-cfd7-4132-2b78-08de73f790f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?J6SfvEsXhJ1c/MZGm3T1IDcdFROETZa47t5vUbWze3CnotMjeZ6eGu7hmZgK?= =?us-ascii?Q?FBXr+3myWQu0i0XzeJ2ecGuAIi8I9B5z8+6ZDUsF3TY7t/IpfiQVtbwVznEp?= =?us-ascii?Q?AoYGTY6+ZWrmuJpASAYZLv1cNDLqXEL7xwkHkwPUXaInVlLQUWUpIq09i/sP?= =?us-ascii?Q?QIG22dRizJ8N4MyAkhsnyl0248hysO9lCyFhPBTUs+FpOEGLTqDLc29abm9m?= =?us-ascii?Q?KK5lnzbMZTNDm5Py4ZRmlnBIEMD/aBR7F/Hw0JNVOvTWyYDzKU3lTduZs6Ue?= =?us-ascii?Q?kn1zmlz4ubxfiCxsS5orZdtaultxb2V5wy6QgbC3WtbhsJ4D52/pDovoPjT4?= =?us-ascii?Q?y2Y8GRJQ3MomhW7C3FbZoy9H8R7J1ZaKGG6ef7tBkG9nWJG+EFpOJZEsrf7Q?= =?us-ascii?Q?HAyX3BzmuLrm0iyWQpz+D5m5IPKXzdps/AqBsbtsTxSN2W1RBTo8NtQn/0A9?= =?us-ascii?Q?5cXyrSfVHdeMUkxet72rh+woTfqJ9ifSR8Hmb8pDfjsDERX9yOADQsoAblEO?= =?us-ascii?Q?QhPbCFaSUvL11PrK5N7CaTlY3I49qywLAY7XK0Gw+Rairs3raQoXvk1eFk/b?= =?us-ascii?Q?dieLlkkEaXjO0jY4A8E3n11++sNDLsilbwh0vGtw9b/Hc1xne9JstPVIElni?= =?us-ascii?Q?ShqocuAjs+N0OXdBGMY7P6a+GwH/u6lE85FoBTjoV/CVsWTx7UFUEChZWglh?= =?us-ascii?Q?XWPhSmPZTS3KEqd5znAH1Y3jiy0tb/JYA/Hn0jcXyqtL9iuRC6sKb3J2nuZc?= =?us-ascii?Q?APuOetD4x9+JxvxfDF9lz3v7brn5xLAV4UBY/wh5Pp6blTSRV2LOzXBefnz3?= =?us-ascii?Q?thooOlZdC2xT654VnBa9wJeAG9fTe1FAqNOPER8DHuGRlfip4U2acEUER4K2?= =?us-ascii?Q?7bqh9ZZvhzWKnAmpO7Y5TSqJ1TS3uZR2hGa1SHqjh03wbJZyr9Vr37Da5GVh?= =?us-ascii?Q?2K0n5Ax7FGcLGG+6Fyt2bOT+fztrQ7jhTMKfA9eX0MXtMCo3Awe3uOC6cl81?= =?us-ascii?Q?h3Y3EtnWoC00IgobA6jhSnW++iXCo9vq7mhO4ulm/0PVg61k9t8ntScxaD/9?= =?us-ascii?Q?BNUdzUcmSHZeyMGb0q0H0Vr613gWc9PZyGffu7SKZ3p7TnUgge5iyDaWw8AP?= =?us-ascii?Q?LjUhji7K34uUVYF8enkW5TtQSYNqZ50gmhmbOlClCpCDREZqc+//BG1hyd8w?= =?us-ascii?Q?RPMACof0yOHVXyJb7vZIgUkcvG68qAVfqZVCIjJBYOBJqjDPIbmsbNTPbeZn?= =?us-ascii?Q?waI2znjcFB0ELRArgvG2bT7J5IsONai0xZb+hWdJT7f/i1oCQzMOfqRnN0Mh?= =?us-ascii?Q?UmBAVbKJrTubDK0WJ1XVFwpN8M95n47tN5LY3mm1BmDruM3r0Scovv3/AJQ2?= =?us-ascii?Q?yT6wkhsmuKkOczedpbUWIeCiVcPZX3UbvULIFfzUCGwj5KR9EgezIEjuq/j/?= =?us-ascii?Q?XCRg1QL2tUBykx/on8Tuh6aDwmlI7elQuJ6ztBMVOTj0592woAp3NnjmF2lN?= =?us-ascii?Q?7rvUrNjp8BIsczPUqmL0Xzg4POzOScj2zcjlXfJmbrPaPAXqNGD6MdYDBVYF?= =?us-ascii?Q?MEHKW5SEBIM76m4FrSs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?p8TmyLjshuVpHZdQSb11zVGxxk0hLEKhUshw1gm2zS0T7CRQ4OO1qb52ecHW?= =?us-ascii?Q?3ncLZZhTPALwX0gAnmuaZykPFBxrf06XSbV+DZf2uNrXeeIxoPAbN0rknuBm?= =?us-ascii?Q?gF2YfpsAh0J+zz8p/hEf/VUWrSzDw+gSpd3+XO7y8meaAR6TumruAZxHhGrT?= =?us-ascii?Q?zbDKLW+NniAqlxspXjNp7fYriMYKZxNZZi2eUyjd/pGr/LOv2j4jjOjiiA4e?= =?us-ascii?Q?4oWlIOFzUiGiwto8fhRFq3REReZ5uToGJkCm1mtLRrf/N/YHn4R0KRVRGpbh?= =?us-ascii?Q?eXX+rZIo3zlsbOpDX1Rs7lUmEZ0oJUEv86LTRbdmxl41CCdfNiLrcm1vLfdI?= =?us-ascii?Q?zIXTy3ogFrSKk2pXY1g6Bkn/zrNRLDwl9auGjU+JTeKOl9ZMosKfV0aYWLYw?= =?us-ascii?Q?FxsMC2/y1nVJw5uQ3mpW6KgYY0WoC/ZeD1ROTHOihm7L3vda016tDJ8HiL0/?= =?us-ascii?Q?PLzpBwW4ITsJa1Pqfo7X0EkZQEH5DdBRD980XNN+mo9So5hGgoauHtV0KxwO?= =?us-ascii?Q?4UAkmPoTD2qdj/8gpIOy5W6pdQfYyI8yJBM26WiK6FSk0kLdZ3C5MqnV/2QP?= =?us-ascii?Q?+czVsjAU3NqcKKttyVmir3tJs7WY6ydHg6nJG4Xbsy0vo7pxN9K5F/6NPVZg?= =?us-ascii?Q?wHdBO2ypM9XiHjC6YODSYU/s6VRpaoSOMy8+Yh5tokAzL/a71Q346AAN0zHT?= =?us-ascii?Q?ul19Yh3nArov+DHKj6/zyL1j4jR85C1MAmeIsN8jgSt0xJB3ERrpIZrT5PYx?= =?us-ascii?Q?OimMrzZJNju6uieRJsipvifDIiaYz9ouzGG368T7xrV+GBCg7YDLJ5eyk938?= =?us-ascii?Q?7Tpdt2TY1jz+eh3y2gOTDsJAEz5pZquu+poM4bHpiv25JJND2hX5I0LF3d7c?= =?us-ascii?Q?uW7+T1lH5MQPQFZ+d9fjQbcBqNHYQ4okFrbpi+35FlkyGlK3FqVGUyQjibtB?= =?us-ascii?Q?sdjuXcH1jGZF65zDkJvpc191IqyvIRW5yA+KbNH2SAB4dG0Ptu0N+Rw4gh8y?= =?us-ascii?Q?R8mklyatR9uPdpZ/iuhbC9xBpUznVFseJQKaPCcZT4nsr31uVyM5e+gqOD/L?= =?us-ascii?Q?yNMzG6pN3gRSkCuhf6mbh9dSjc1SlSM/nce6ZowfvxoL+gbOjmRyfPAet69W?= =?us-ascii?Q?5pQpgQ2QmypRHI6JtzpV26ljHgs074r6gQpdO3NHjAIhCL2pyFmlt5F/SzEA?= =?us-ascii?Q?Dv7KAF4tjZRzUTg7YArhDwg2f87lppdbecZ0PPgaXygMeBDILw9ZH8Y9Zt2I?= =?us-ascii?Q?nCM0oPot2xhSD6zx72L4HPKWddVexBqF7qqLsVc1i/wpy1KyXDd5sLU46c/U?= =?us-ascii?Q?5iLNbQYdTbRLons8jBSR3Gx5OUrgDYd4SaTFInaCRfEs12MD5r9+QgqQXzm+?= =?us-ascii?Q?KzR+wXWKuvzKjngV58fMZ/O2UXIlkEZSUrHzvmdk45zp03GI1Nlg7GPssVrI?= =?us-ascii?Q?kXssCsnyJ2TFfuB9FACTmkkraEPysYjiNaQLLZBacaldHcjn8C5go7S7Sdxz?= =?us-ascii?Q?U9DPTiw6sehtgY/KJVKaK+MJxSiJk8B1UbL4yuRzUJgFU8yNPJ73YH9oNvF4?= =?us-ascii?Q?trjEDp8Ztbl0PuurryuYu4okh3SZKcTN66ugqHI1DLMyM8SYjKQozY49aaMO?= =?us-ascii?Q?iOmmmayMloCZXNiuxHDm//myDmZJNVQsFYIiwyLpaOU9kGc9UAbpvJkTMwof?= =?us-ascii?Q?EDp6D86L6gkkLZu8uepBch5pF+SEt5JIdyVslaDgN+R8Bco2PqxU8Xti/O3o?= =?us-ascii?Q?pitkzLnemA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91b23abe-cfd7-4132-2b78-08de73f790f2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:46.0404 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jwM6NEAkcbbhlNgBgHIpDqcippdYZXghMG9ptmKTv0qoY87Y0k0uZ5e2H1ITcg0Nqr4IU5KUAnP1j2DZspD81A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add foundational types for GPU memory management. These types are used throughout the nova memory management subsystem for page table operations, address translation, and memory allocation. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/mm.rs | 174 ++++++++++++++++++++++++++++++++++++ 1 file changed, 174 insertions(+) diff --git a/drivers/gpu/nova-core/mm.rs b/drivers/gpu/nova-core/mm.rs index 7a5dd4220c67..a8b2e1870566 100644 --- a/drivers/gpu/nova-core/mm.rs +++ b/drivers/gpu/nova-core/mm.rs @@ -2,4 +2,178 @@ =20 //! Memory management subsystems for nova-core. =20 +#![expect(dead_code)] + pub(crate) mod pramin; + +use kernel::sizes::SZ_4K; + +use crate::num::u64_as_usize; + +/// Page size in bytes (4 KiB). +pub(crate) const PAGE_SIZE: usize =3D SZ_4K; + +bitfield! { + pub(crate) struct VramAddress(u64), "Physical VRAM address in GPU vide= o memory" { + 11:0 offset as u64, "Offset within 4KB page"; + 63:12 frame_number as u64 =3D> Pfn, "Physical frame number"; + } +} + +impl VramAddress { + /// Create a new VRAM address from a raw value. + pub(crate) const fn new(addr: u64) -> Self { + Self(addr) + } + + /// Get the raw address value as `usize` (useful for MMIO offsets). + pub(crate) const fn raw(&self) -> usize { + u64_as_usize(self.0) + } + + /// Get the raw address value as `u64`. + pub(crate) const fn raw_u64(&self) -> u64 { + self.0 + } +} + +impl PartialEq for VramAddress { + fn eq(&self, other: &Self) -> bool { + self.0 =3D=3D other.0 + } +} + +impl Eq for VramAddress {} + +impl PartialOrd for VramAddress { + fn partial_cmp(&self, other: &Self) -> Option { + Some(self.cmp(other)) + } +} + +impl Ord for VramAddress { + fn cmp(&self, other: &Self) -> core::cmp::Ordering { + self.0.cmp(&other.0) + } +} + +impl From for VramAddress { + fn from(pfn: Pfn) -> Self { + Self::default().set_frame_number(pfn) + } +} + +bitfield! { + pub(crate) struct VirtualAddress(u64), "Virtual address in GPU address= space" { + 11:0 offset as u64, "Offset within 4KB page"; + 20:12 l4_index as u64, "Level 4 index (PTE)"; + 29:21 l3_index as u64, "Level 3 index (Dual PDE)"; + 38:30 l2_index as u64, "Level 2 index"; + 47:39 l1_index as u64, "Level 1 index"; + 56:48 l0_index as u64, "Level 0 index (PDB)"; + 63:12 frame_number as u64 =3D> Vfn, "Virtual frame number"; + } +} + +impl VirtualAddress { + /// Create a new virtual address from a raw value. + #[expect(dead_code)] + pub(crate) const fn new(addr: u64) -> Self { + Self(addr) + } + + /// Get the page table index for a given level (0-5). + pub(crate) fn level_index(&self, level: u64) -> u64 { + match level { + 0 =3D> self.l0_index(), + 1 =3D> self.l1_index(), + 2 =3D> self.l2_index(), + 3 =3D> self.l3_index(), + 4 =3D> self.l4_index(), + + // L5 is only used by MMU v3 (PTE level). + 5 =3D> self.l4_index(), + _ =3D> 0, + } + } +} + +impl From for VirtualAddress { + fn from(vfn: Vfn) -> Self { + Self::default().set_frame_number(vfn) + } +} + +/// Physical Frame Number. +/// +/// Represents a physical page in VRAM. +#[repr(transparent)] +#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)] +pub(crate) struct Pfn(u64); + +impl Pfn { + /// Create a new PFN from a frame number. + pub(crate) const fn new(frame_number: u64) -> Self { + Self(frame_number) + } + + /// Get the raw frame number. + pub(crate) const fn raw(self) -> u64 { + self.0 + } +} + +impl From for Pfn { + fn from(addr: VramAddress) -> Self { + addr.frame_number() + } +} + +impl From for Pfn { + fn from(val: u64) -> Self { + Self(val) + } +} + +impl From for u64 { + fn from(pfn: Pfn) -> Self { + pfn.0 + } +} + +/// Virtual Frame Number. +/// +/// Represents a virtual page in GPU address space. +#[repr(transparent)] +#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)] +pub(crate) struct Vfn(u64); + +impl Vfn { + /// Create a new VFN from a frame number. + pub(crate) const fn new(frame_number: u64) -> Self { + Self(frame_number) + } + + /// Get the raw frame number. + pub(crate) const fn raw(self) -> u64 { + self.0 + } +} + +impl From for Vfn { + fn from(addr: VirtualAddress) -> Self { + addr.frame_number() + } +} + +impl From for Vfn { + fn from(val: u64) -> Self { + Self(val) + } +} + +impl From for u64 { + fn from(vfn: Vfn) -> Self { + vfn.0 + } +} --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012068.outbound.protection.outlook.com [52.101.43.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32D7034DB60; Tue, 24 Feb 2026 22:54:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973643; cv=fail; b=cGREOPkWf2Ymn81ovBGDWjShFKNV5GUMxoFz+1dIizWlL2NRIqN9Zrm71JmohNtzpn6FcWRoLcPDRJrSs8WOZEpvgM3v/eD4oR9F02Uxa0sg7NrQNSDasunFZUmG0G+gejyoKC7/kfIl7nunajfX2oNwZeGDC+QIjlLtYxcxg9M= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973643; c=relaxed/simple; bh=y6mEhLlpOntpVwPpq9uRpoPvVQisJzck7QBYx1uMSRg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=KryjIW2lE+lC7qUQMGzBCWYnW+XtBCK9a2zimVtwmVBQFkkB6lj8eIM1XX3VnTdSCn7PrcBGvaCfEziI3ytgTwSKIWKNTw3CxoV7BAvqxyll8JwCQIot7stJmmWnBlf/j9c7+V2zQ4fVV0TAWGCr9z8wY9f8efKdP4c/hMZc0yM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=VrETmeih; arc=fail smtp.client-ip=52.101.43.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="VrETmeih" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yiR0bLwTm/Yw7A/0NoiWP0VPREn7DdSdAzNCjY3e9WiSI1QjWjSnr6vMNhclI19KHpCtQFIvSWDnOIJgZR9ROUVYkoW5N9vcnz4LZbMsk9kCnUUywWbker8hySw3pfiJ2bltxpJeqJOjsYBbl0Io7RooCfMzHN0c6GPA5fxs9IQG+//0TU8flG7Pu1kkgvvHNJ/sf3bl38j3qDWGT1tP6FIXKtLirn4JOp8/8Vl2as2YkFIR56mT7S0WEHEOjK+Ra6H02iet6BKo5Jqza25oorcvd64bt471SLBuYIJqtLKS7eSBoVOYVvZV+JLckzDuhghA0xIwGbTC8ysKhiLPEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7zKgDPmVZNfWiDtJ9vzaaR7u4t5UNgcAKdjFKBA03YE=; b=nH4p6FSNbFvTdnDJ9arCnW2lGsRXnVXQrVZCFcC991+7KrUtQDg8jwKk+tqlABfv9pl8KeMuPYgg6QBAsD8nHhwo/tedkeiOK5ULqSHjJ08K77tyTDoSFPSuL8zl5C3Tqft//e4Gi51u2V/Uuf0F4NMQSVa9rEh7W0LPblczXL/Gf+iTmSu9fljQH9SMEgfaTFh/2QYNUySR3J0uBj2Rf5HodNFY5TOvDHoyRDs6Rz+fG3RHhDzOLdlViUmxvAJBO7h28oaaydNj4N6n2WIWEwovKQZsTBf54OLNt3aep+POZZf4KRImnc5IViEDdlDjKxElNvxPEv0DGZgP08GVwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7zKgDPmVZNfWiDtJ9vzaaR7u4t5UNgcAKdjFKBA03YE=; b=VrETmeihb1CinumvqinF9Up8Zw3TzdaKaUdVbQQa/g3uz4YKURlFRNAEFcUOtpaPrdpdIyPZ2uknTDH73jnDB5rkl3Zwv1X5fGmcSUkMbnqpQg84wZ45UqTxXdsXoN8XPzlubWO1bZmF+iehz1RCy7aS4yJQHTyL403xMiZORbwGa4PnoqetMJJPw1DEbHDR69F0KqWkeTpGdq1RvmVR2XZyy185AdBl8jl/VbgmQIbJqlMG6ZZMreR+LSwUi1HusDK6CPcN4roBLw0uimhHvPHyOT4f0d6qzFBsYXs44zvmWPhVoIK/i5QoXlW20i9rh/Db3d7w2/6NxTQrQegXrQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:53:47 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:53:47 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 09/25] gpu: nova-core: mm: Add TLB flush support Date: Tue, 24 Feb 2026 17:53:07 -0500 Message-Id: <20260224225323.3312204-10-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1PR13CA0340.namprd13.prod.outlook.com (2603:10b6:208:2c6::15) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: b96afbfb-f868-46b7-c2e2-08de73f791e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?K6JTZiAOiIHgz43T6Sj34CuBRyzmUC+ipiQXtqiCLuzF9c0xa/KmAxbP92Gy?= =?us-ascii?Q?Y785giZpAteYq2dN5xtSrdYlX9CtmFnY7NOE2JMXlfcZ1dknJHZRRHkZySgK?= =?us-ascii?Q?phl6GNKRCXaRKw66vtKye7VnNF88SRndzn3oPFkkYNRyOrKW4Zt4/rbfmwM/?= =?us-ascii?Q?5A/jEvYxS+i3IZLSUdGid9JVABK+Jhc+wnSA26zGDRmfll49YSTG0jdvn6DU?= =?us-ascii?Q?xrYpOjUj75h/MFEXsL0AUtvfBNw8V5cG0sCHKTWSBZx+Xp/6HJ5gb6r8U/hs?= =?us-ascii?Q?RmeGbidK/+p7wrJVjy9rlymqgM0IW5mbX2iXgtLTApoAItdsqgL55y62xDYb?= =?us-ascii?Q?+syuewSxfBArajaYzj3Q5Mr+JJGNveb2CBYlItAf1DBK6p+OBXLcerVHiT7Y?= =?us-ascii?Q?Ln0B8HOQq19IW50zoJB9C5TtKo0GeSDE9UGeSybaBXjZf6Yf1zOi7jg9LV8R?= =?us-ascii?Q?cB/c2KCmYHAEzm+0OPPK4jRJD/yGD64FCl8m/MaPOgQUVg6Ziubtc6JkiMWk?= =?us-ascii?Q?4Eog5fnw604JhUNJLQDEzG07v98S+4CpbF3j7/MnjMLF0vJWeF5GyCPyMIB0?= =?us-ascii?Q?ZEBY5kjpl89BlIbC/dIDkmh1UT72uw2OYsgvBQKslo4pj8fH0IOPTHTWGrqN?= =?us-ascii?Q?q/JCydO6FOe6gNnd/yJBS6XT44hoLwWyIHXqZPvyGHsuQ06SsplPT63d5DFx?= =?us-ascii?Q?g3SG9gX+6iM8p1bUbDAuTpq8a0f2fypuMOHeNFCft/Js4e/5jlpNA3qbGPs2?= =?us-ascii?Q?SHf8iA7nRrakzP9wYL2ijqPxEdSxIWML3poDBp6FQclmSBJRDzZoN39IMMAd?= =?us-ascii?Q?XCLiy6AwYrrHfFTsiUjLVUpkQXCCOftJRQHK53f0SLj9/Bfl7qumL7E8V634?= =?us-ascii?Q?N54gpx7LfcpA5nr19Zx+pVcSrJ0b2pKgzWORdeh/M9JfoOye2W87/IdkZVvT?= =?us-ascii?Q?QYdIzQxdfES0Pa2/0QJb6qibhcifyYxNhneZxi+ixiftimFNRgndXV5kl86I?= =?us-ascii?Q?hd/gxgJZ4wqp8ISuXiZMQVH5JgCDxVRzsX+QfZMOaa6NWMYSw4HHFan1vq9e?= =?us-ascii?Q?jTo+hVQqWExjOAJKRks1+P57faOCn/ImeNLbflcb2cmTWSVpbQBixiPsLGv8?= =?us-ascii?Q?3cms6D+UEAtGbTqe3y0jtj9QyBIiqDZFqKPluXcnHvUSngYJXNr39zosuBJ4?= =?us-ascii?Q?kuh0xSZEu5fbnKRoejBNaMkrOD7IZ6GLv4B+C2/L5IUdc/zkmP225Kjm23an?= =?us-ascii?Q?4k81ydeFYHjJ38SGFqUjNu1YhkyGmrQv2/gvyP3jeotla06Yu91S8r+FqGbk?= =?us-ascii?Q?v2dfu38Y5m38e/GXYBAV/sBqW1oJhZimtu3a9KSxVZFvNGddImyrxF/IFF9l?= =?us-ascii?Q?OUAoB45oTAWRM68ojMgcWj4rqJAIy91NjLWUlEFtdGYK0IwKqeYipRZ2cB75?= =?us-ascii?Q?fo53k2YdgSnAs6gEeOblnjursRZFe7InhCyysIzqWwCQaTFnELZmA1rks/fi?= =?us-ascii?Q?orR0/tSnnbbdFbNyUCRm0zzzU363pMa1aePErdnRCvJKbki+/2OIInOr+z1B?= =?us-ascii?Q?5AGbdUG3p3ECXuxtYzg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ky2dG+tkFkkRIGJsdVhswKHQGJlpp0Aqz9qXaHHHmLt4Pky3+2ulDUcPLdmI?= =?us-ascii?Q?8Z+aliZlGIMSnTyrU3JtxEYsPmoMrkJSAOWGTXWOo78guZ1DX7PKvuLBCnpu?= =?us-ascii?Q?8mshcvq/mfGfyzUe70caAEHAqFT9Ks3ZqYuJZFcQQoaksoluLg9ZrpPJFyuP?= =?us-ascii?Q?Czq+5yr98gUCh9xSV/pyonk9JEA+tqLM8TaqJFJCWWj0Nwlk8bTiq/fK5sT2?= =?us-ascii?Q?O6zLr5CR64zrCEG4DSaJSFPE84+mPni0G0LCc1TBNDsX7WZkV0zMjxU8zgwn?= =?us-ascii?Q?Mhg4ZIg6ZuWpJqJVFO5p6bxzY+JRTsCZmwnD7fT2G2SJYO3zjlFwZKMTfN9R?= =?us-ascii?Q?XF2LWho8kt6+G71avv0v1ixjdI4iDWJmwJ+uZcp0XDvpCM7gp1AyMOX/SzL4?= =?us-ascii?Q?CdLNwhcAXyzsKoqTc5mYqpYQ62j0vwmMv/1YpMKrsJrYDnN6FhNXO3rixXga?= =?us-ascii?Q?IvRnmWCfExDihb56wcQJ3PV0tSennPMp1AqfaufKFJqeapKJDQyctqkPE50i?= =?us-ascii?Q?6HVZFT8YA2hb40sREoEL8XcokGN8zdQSPQiBrmi2yRxHVbC+Zbi+j1y0jnlE?= =?us-ascii?Q?r4SQbdmfg11us3Mb2Ij28gu2APELu0M9LObhVbhnMA2oSjVqKadqTPW0qFiY?= =?us-ascii?Q?Do9J2g3pJQ859SPao44k78O77HRXUjBV5UklDqB7OUVZZ6Kk0mOKxQyulk3Q?= =?us-ascii?Q?A+cfy11d6TCZZ0RXckBKe3iZBwJ0WEZ1hWnPl0zHhXr51bpAmUZlqGdgWW66?= =?us-ascii?Q?3iKZQbZWcs5MYIqb+bmRkpsEvVAYOsoWukEbQytPIKAZ/Y4YcImoDEGouMGy?= =?us-ascii?Q?kXUn7XNvjbgf6B09WTKfe+E+8Qgl0V+x4t9FcbrJ7fRx+K7T5U2gXrkb5Aj1?= =?us-ascii?Q?GQTNPuyOFzeZO1v8i7nVr/IwUsdaoyX/WznuVfoe4vXxEXxeuCPOVc+s+UHx?= =?us-ascii?Q?b3q0ysALwzFPgqlS0HdNGLF8bpun8HaJ5MGxPnMP8VFUnUpECu9wIf0br5am?= =?us-ascii?Q?4onPR92DuLhQZGgTcYn7LHJGGoFQpz3KJHe5os58gpePv7AK2S+xUbkhrcVQ?= =?us-ascii?Q?+PcrXxaIWIkYh1GFVJH5iBwe1LS5/UTgXIhCq09aJB48AvzpeulQ7kdLYtY5?= =?us-ascii?Q?blN9PKDnRPcTFyYjAMnsFJLqSAsk302iQVfZ6kIqnLyA5BGAmV2XEzbmPUcs?= =?us-ascii?Q?C/eHuuCTnoM2Ufdp28Nry4gcHA6klYXHKHMozPHy2iWIICGzo6fF6WK5mNA5?= =?us-ascii?Q?aIUx6Khu2zbWoS2EbQpjCNvD6YirBOB3HaUEMyvCOg5chc2gnIT84ZN6O2OL?= =?us-ascii?Q?snDa6LeLUOraDv0rXtIXuMtm+LsZKv4CqrO9Ke3B1LHW+ARtQGfXijaiQODb?= =?us-ascii?Q?FUfJwgt9CyBqR4mQeEtvsMbTnDr3EciVKudoad0KFQB0JYhedIchAh8yMNW5?= =?us-ascii?Q?EXBFUvAM/C1gjIhToRImkLU0j2IyQkeGivrryWzf3dNwIm8rMk1cKDe9qdUF?= =?us-ascii?Q?B9X4+YcidR0HL1M1hWwvxFYFs460ZUFB91CxTsE8V2K8wqyiFDTtmmAteg9v?= =?us-ascii?Q?r0WMIOQK/S3bBtxa939xcnNPg0E8rudsIUXMGqKhsrc0LvR6J5lQw/JFQ+T8?= =?us-ascii?Q?T7GvgfPNUk/Ja2DPfjwwM3viryRQqPFWINZQvVmNFFSJAvKInhmAeCI+lqqC?= =?us-ascii?Q?lsLK5X7jDc0J/r5ax3MPXZW8yP37bRJBtO7ET6BuFxhfJlNk08KVVzF48heu?= =?us-ascii?Q?pYjRgeF2GQ=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b96afbfb-f868-46b7-c2e2-08de73f791e8 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:47.6559 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JUJkvzhdtCL10Txw+Cl9Z1wkNWPdHElfzcSSiWsBP4qQhfJByRZ2nWvCZNHtRzp+qxAdpiygCULH25T+eCU4HA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add TLB (Translation Lookaside Buffer) flush support for GPU MMU. After modifying page table entries, the GPU's TLB must be invalidated to ensure the new mappings take effect. The Tlb struct provides flush functionality through BAR0 registers. The flush operation writes the page directory base address and triggers an invalidation, polling for completion with a 2 second timeout matching the Nouveau driver. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/mm.rs | 1 + drivers/gpu/nova-core/mm/tlb.rs | 90 +++++++++++++++++++++++++++++++++ drivers/gpu/nova-core/regs.rs | 33 ++++++++++++ 3 files changed, 124 insertions(+) create mode 100644 drivers/gpu/nova-core/mm/tlb.rs diff --git a/drivers/gpu/nova-core/mm.rs b/drivers/gpu/nova-core/mm.rs index a8b2e1870566..ca685b5a44f3 100644 --- a/drivers/gpu/nova-core/mm.rs +++ b/drivers/gpu/nova-core/mm.rs @@ -5,6 +5,7 @@ #![expect(dead_code)] =20 pub(crate) mod pramin; +pub(crate) mod tlb; =20 use kernel::sizes::SZ_4K; =20 diff --git a/drivers/gpu/nova-core/mm/tlb.rs b/drivers/gpu/nova-core/mm/tlb= .rs new file mode 100644 index 000000000000..23458395511d --- /dev/null +++ b/drivers/gpu/nova-core/mm/tlb.rs @@ -0,0 +1,90 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! TLB (Translation Lookaside Buffer) flush support for GPU MMU. +//! +//! After modifying page table entries, the GPU's TLB must be flushed to +//! ensure the new mappings take effect. This module provides TLB flush +//! functionality for virtual memory managers. +//! +//! # Example +//! +//! ```ignore +//! use crate::mm::tlb::Tlb; +//! +//! fn page_table_update(tlb: &Tlb, pdb_addr: VramAddress) -> Result<()> { +//! // ... modify page tables ... +//! +//! // Flush TLB to make changes visible (polls for completion). +//! tlb.flush(pdb_addr)?; +//! +//! Ok(()) +//! } +//! ``` + +use kernel::{ + devres::Devres, + io::poll::read_poll_timeout, + new_mutex, + prelude::*, + sync::{Arc, Mutex}, + time::Delta, // +}; + +use crate::{ + driver::Bar0, + mm::VramAddress, + regs, // +}; + +/// TLB manager for GPU translation buffer operations. +#[pin_data] +pub(crate) struct Tlb { + bar: Arc>, + /// TLB flush serialization lock: This lock is acquired during the + /// DMA fence signalling critical path. It must NEVER be held across a= ny + /// reclaimable CPU memory allocations because the memory reclaim path= can + /// call `dma_fence_wait()`, which would deadlock with this lock held. + #[pin] + lock: Mutex<()>, +} + +impl Tlb { + /// Create a new TLB manager. + pub(super) fn new(bar: Arc>) -> impl PinInit { + pin_init!(Self { + bar, + lock <- new_mutex!((), "tlb_flush"), + }) + } + + /// Flush the GPU TLB for a specific page directory base. + /// + /// This invalidates all TLB entries associated with the given PDB add= ress. + /// Must be called after modifying page table entries to ensure the GP= U sees + /// the updated mappings. + pub(crate) fn flush(&self, pdb_addr: VramAddress) -> Result { + let _guard =3D self.lock.lock(); + + let bar =3D self.bar.try_access().ok_or(ENODEV)?; + + // Write PDB address. + regs::NV_TLB_FLUSH_PDB_LO::from_pdb_addr(pdb_addr.raw_u64()).write= (&*bar); + regs::NV_TLB_FLUSH_PDB_HI::from_pdb_addr(pdb_addr.raw_u64()).write= (&*bar); + + // Trigger flush: invalidate all pages and enable. + regs::NV_TLB_FLUSH_CTRL::default() + .set_page_all(true) + .set_enable(true) + .write(&*bar); + + // Poll for completion - enable bit clears when flush is done. + read_poll_timeout( + || Ok(regs::NV_TLB_FLUSH_CTRL::read(&*bar)), + |ctrl| !ctrl.enable(), + Delta::ZERO, + Delta::from_secs(2), + )?; + + Ok(()) + } +} diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs index d0982e346f74..c948f961f307 100644 --- a/drivers/gpu/nova-core/regs.rs +++ b/drivers/gpu/nova-core/regs.rs @@ -454,3 +454,36 @@ pub(crate) mod ga100 { 0:0 display_disabled as bool; }); } + +// MMU TLB + +register!(NV_TLB_FLUSH_PDB_LO @ 0x00b830a0, "TLB flush register: PDB addre= ss bits [39:8]" { + 31:0 pdb_lo as u32, "PDB address bits [39:8]"; +}); + +impl NV_TLB_FLUSH_PDB_LO { + /// Create a register value from a PDB address. + /// + /// Extracts bits [39:8] of the address and shifts it right by 8 bits. + pub(crate) fn from_pdb_addr(addr: u64) -> Self { + Self::default().set_pdb_lo(((addr >> 8) & 0xFFFF_FFFF) as u32) + } +} + +register!(NV_TLB_FLUSH_PDB_HI @ 0x00b830a4, "TLB flush register: PDB addre= ss bits [47:40]" { + 7:0 pdb_hi as u8, "PDB address bits [47:40]"; +}); + +impl NV_TLB_FLUSH_PDB_HI { + /// Create a register value from a PDB address. + /// + /// Extracts bits [47:40] of the address and shifts it right by 40 bit= s. + pub(crate) fn from_pdb_addr(addr: u64) -> Self { + Self::default().set_pdb_hi(((addr >> 40) & 0xFF) as u8) + } +} + +register!(NV_TLB_FLUSH_CTRL @ 0x00b830b0, "TLB flush control register" { + 0:0 page_all as bool, "Invalidate all pages"; + 31:31 enable as bool, "Enable/trigger flush (clears when flush compl= etes)"; +}); --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010042.outbound.protection.outlook.com [52.101.193.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AFAD361640; Tue, 24 Feb 2026 22:54:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973644; cv=fail; b=WvLhbON309zr5TWRf+N8UTyzRgZAAD2yMXRQXeYX70BkGKAF2tPze4GLVp7R5N+n0VO7pac8bCjZ9+4AacDznZ0sB3QCUlt5uKnD46ixy5mkXcDFemSCCheYqycdUU2uQqr7yYoAZe3POhQbOeZqlHM/FJ7FwsWh/t597ASuQkY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973644; c=relaxed/simple; bh=dfSXlRAcWBzZOb25h2GNuOjoXJcH3LroshVs4Tf5Ey4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=GSBDyrttKu0lvC8Zin+t0PbBLP4sOxr87NgamFzCy7k9M0QIDh6Vc8Yyd/SeEEjKB7EtlJ4rrY4RALdTQnTjDOKKZIHCcgw6kAYcpKh1fhv4N2lKFxIVo/D2AFxDjcP+TI6nG6cdzMGUUBrcfoWblNKdntEFwlRLbisOt8U4GA0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=i1lSiRmN; arc=fail smtp.client-ip=52.101.193.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="i1lSiRmN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PfP14TIh1XulSp7dcf7fyuvjptcrJDK47CoU45pzVeE6zhtQv8j09smZEuIkK9wmg+/4C/Op04rc4MN16iexQ7sn9wkxI5WYroBH4wAMcTzED2jLtsbBDbIz9/CtcvYo4HYDpgnZiU/D/M02WZJaFndU29E+4ryYqXb4P6B/WQwAmFJ9rv0A7c1LQecku+HvnzEvKdXEpIuxXpm0Y07uMBJEqLfzoxyqMUEYJ3jSD5m4eXb60NOAv4nf1JlTXn+vpkVjUpCzvcSmOvNeMENg4pfAJTFDv9K5YD7oRu7oqOnL9xlc/2m2HOS4tRGJtKIxXQSlBBnGmsTtqepAUY+Lbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YI3om+J+g5Njey+T40Z5xsmfkXWDiRTHCKW15V8Xgb8=; b=Y5B4wrFXZLJfa54CQP5YjWCwMbI8mAc1iX2eJApBdYHy83HOJpUAMWygkT+ac0MlDtMCd0tWneGSGNBkl+rz/44NSRm7BOFUUiUowXNG+/QWCmz4oemKPQq4ZfJPSCMkdy3AVA//33wFwVLmaT2GtLF+TS0t0JCxxxD/OiD02grUgp+yUBkyq4ui2zW5LigQMTjoyoB476Cy+FHdWOng9ZoZ2r+aFaOkStQCDdduf5jPqoBB3WMVr8hdOMkhstxVTZ7ItZCvp+CkYM4f3YN7aSNzpSyUkp4reoCeVkwa+i8On0uECKQHYXilLIGn7EF642ZxrrmsQmq/sDU0r6cPSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YI3om+J+g5Njey+T40Z5xsmfkXWDiRTHCKW15V8Xgb8=; b=i1lSiRmNznCqL/RsuomKPggXnpudKZHS7JTtSfJMY7wajcF8WGgbeVlm2ZauGHhH8riyYHykZkAJXR47FJ2LLvbM5KfMkJqlqIj70Ac2tkR2/nzFKHgsipb6f5MYdiKDVj8bRMySl6rfk1lXVT5xdBmY8RWCi66bAbusESZH0EzqL6gmAQA4CoqV6HGpqhrcCsouipnOQJzEeAEnIjIy7uAIbwecLNXt09BW39bKxxlG1agrjLhdxCECRUMS1nBnMl8gFe9bAjsCNSzm9XJkb3l3juK5faf/uim1GxOV0BsWknAgboeNDW1oFX9aUJNzv8/eBUC0puK8Xg2KF4QdZw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:53:49 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:53:49 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 10/25] gpu: nova-core: mm: Add GpuMm centralized memory manager Date: Tue, 24 Feb 2026 17:53:08 -0500 Message-Id: <20260224225323.3312204-11-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1PR13CA0346.namprd13.prod.outlook.com (2603:10b6:208:2c6::21) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 100a094f-42c0-4288-2e1a-08de73f792b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?sa4089Z1PTOcG04yHXiyHjzjdB1Wl9Th8EW1oOj3orMMpqnOapNE78npkk5Z?= =?us-ascii?Q?lQaP0lDBtziJGTD9FoY7XeqWPhl4qBfR6j+6/nEIOF2TOXodac1535vcwmRn?= =?us-ascii?Q?oQ7Uv3agsPGQeXQbzxvDArFyQbsrqr1BYXsinfaHHeVJ9cH5KNLPkv0yYoeh?= =?us-ascii?Q?kQnkZPmLxtCj6IuKXcfPoyBeh22lVXy8bwMv8tgJIcJixyuNHJ/agNs1OvPp?= =?us-ascii?Q?CK32ffAlCkJSnBklEb6QAJ/LBwWPPTEmgQo5S9I9MMwV2/XWd7+UUOdYlk8V?= =?us-ascii?Q?bZPXVXbNNHsnoZwxtkl53rUltUVx1wkj+rYMRYWq/M+FTljwSjHQUTljqlOh?= =?us-ascii?Q?KErEFnkOq6g4l/615GH+ugyxqknfHvJYwCvBgIOUf6FXAt4XFewo3T9j4EqN?= =?us-ascii?Q?rGuD554y2J50za4/CNtugvlzq+sehPKz4KKGXqfOLl5l2908SDDrGvTY+HpY?= =?us-ascii?Q?jj0vq54fDwMq0XjQ8HGGsMaNNuvih9DLhjKEaOqgD7d08kgz0rKrY7WEtJyF?= =?us-ascii?Q?bZMGsnvoqnqElNacXtIUbeZFaHZ++Zj0Wi5v0EEQYaPhDUmMctGgmogiAXBT?= =?us-ascii?Q?UaNSETdw45BmZdzfPLz940s1i+jzFlvw2ry4hTwVM6nw+44BXH3ZwHtKuWHu?= =?us-ascii?Q?qoquwo4r5MIzX2TbLEvNAzYPMMNZBl95zQwo0xU1Vz3SwhW9lGS9xNNDmzYf?= =?us-ascii?Q?Ec44nmR9K1BRDuCmvWTjS1KLCb39On4BjSJj4HFgzi+99LM8B32gpAJJMkLG?= =?us-ascii?Q?9iRDP3yiZPuPZ9JmtbP5YnUJCe6S3kkJVOH4nsvsuc5zNvD6+bpmyotUCaIZ?= =?us-ascii?Q?F5ckFv9judtHPTSAddbsg0GFOPpuzdTLOn8p/lV7z00QuOuwp8rjt7Ooda6M?= =?us-ascii?Q?GPSrKUXG3PXb4VbCnIoEQyD6WzYaGSFBnl/o+giF9j825CRtetm3oBFiVsq5?= =?us-ascii?Q?6YGeh+mvfr3NOCUto/WGf84PrK81lVnE7rAhUxYUDgdY7uA0VLYyWv7d/nbU?= =?us-ascii?Q?XmfvvjDcdc+sJU2/gSTKcm3xDNhUwlSDNmkkUtYSCU1n5W5QIc6Klvy/je05?= =?us-ascii?Q?dB3Zju6mZ83kPuehghL7cIYwUPB1IFdUmKLM+VUMOsf7L4XbtAIjlVJoc19F?= =?us-ascii?Q?xRaynkI/iH2SkmPwd4Mb+WpiCNQqgmi16Chd3i4BmjW+QdDolwZAH48C+RLx?= =?us-ascii?Q?Snreq4TG8wFwbJcsNt6dihK+2gp+N0+r6fk2A339cv4/htuPg/1h2V7ByP/M?= =?us-ascii?Q?CK0vhZUMx27Hl63N7LIW1AACgmhIvFE/XhTOVlG1hK12PEYheiL6xI4yOztg?= =?us-ascii?Q?EBzhKyBVjT9zxQwWiCOUYDrAJll8elwi751u584nqCXt0GUc/P6I4GjGqyzy?= =?us-ascii?Q?1hDaXt93wpUx5UbElgL8GaheCbCjtTr3tbr31rnOQXdRxbVlx4uBg7zyRsHz?= =?us-ascii?Q?NJ6Pg0AsTR+50B9yQN3M4H+tbKQyHySebHv42jgeRH41i04gKWyRXN0YZBQV?= =?us-ascii?Q?FfDQK04r0UD9ZGSYkdWFDVTlGPRG7s6xF4GdiVxXkm2xy8PsaJjLxCmyYw9q?= =?us-ascii?Q?sIwMCajCanM9/SGT694=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1hnSoMaNpwVsvOW3nUJlse9/aEgS/wsqq0cPCJRRI2v376/lCt9oMQAWZasg?= =?us-ascii?Q?DtZFl/qCU+tga3A0bgcfl5jB5R/6CxJi5mWXNb2HQkc5gaarDHn5JnqS5Jli?= =?us-ascii?Q?nc1LTDaFbJgr3HArmz+9s6Gzw7ihR9WmdPYGZziEbfx1tPeVo2hm8VaBSDBc?= =?us-ascii?Q?fsdvzQq2qmS8eA2W2NR8JZ7bii3cqwfpVLZYagNDm8qMtlblTXNDlRF1BKdA?= =?us-ascii?Q?5K3yhSmXsYI9x8nCD+AA1uhxIldTY5G3l+OSuTr3LUxyp+SpONs4wyk/53Bh?= =?us-ascii?Q?TTr6aRcl5vH6Zz3myLC/e6mMN15UZbpas/vyEoT8f8pkw853JlT/7KUYsxwv?= =?us-ascii?Q?d5fUGSfxmqdDtGjDOdC1avLBUDD1I5wmWgE5QYyn7ky8i/bnThTrYhvsSQZj?= =?us-ascii?Q?ZrO0+Rc3l6k8rymVnYPiMCE3WHW5SUJ2vpFLE9yIxH1QfWu42C1Cj5JWyUMx?= =?us-ascii?Q?dL6WBdmMrp8SiK7x0WNcQ0atkyWjCEfbCKYwSDZgdY+1EqJ4F9nlC8cvGdlX?= =?us-ascii?Q?SzGiePd6oxN7S16E+ii8AzLWKSkFuXYDh5Rtxumy+doCvez2WHlk1dyt+dJz?= =?us-ascii?Q?vk22Xpt1yKL215imtDGY9kWEKOTxzaXrL+9BD7lINrhmrepMD9n/SmGJxDqv?= =?us-ascii?Q?VbRxYTKk4pHk8VBqyZSuAMrNEs+CHiL9ldOYgDPS9r5BnD6GNljajX+iv6Zr?= =?us-ascii?Q?6VHIL6ezc7o/5ND0xeUbhoHhytnQhHXF3yGdawU+fb8e3Wmi9pRJYF4Le3gI?= =?us-ascii?Q?xB67ffiIcRsZXnU6UzcVZUdV+EJ6tocMNxPGYLxV3D8+jtrv5qYeAtD1tPu6?= =?us-ascii?Q?x1riXnC844+P6SZ53O5GHqEXsOY6PcXIwnilPGqLduXbEp7MbfRZJlyHs2ho?= =?us-ascii?Q?io0XP0/EhtR7cBKRJs8Ym6KGEnVGcYPpDVCN+i7nEjiL/hzSY+I6nl0ZcDa+?= =?us-ascii?Q?dObqDB/iPF6uMi34sfPTWo4BbDu90b2AqDIppgxuFSbhBwW/zorFosQdQAWl?= =?us-ascii?Q?yM/zUQ9si1Xh1Dh3ZzKYrRTttTggzMJVXwaxBE21fwi+T/qmhVjIcWNutfwF?= =?us-ascii?Q?R1HP0U553fI4NPvdXK2BHY7bkz005PHYz+w5w9dOvIxgI+ragq4uqYb8drSn?= =?us-ascii?Q?GIQkaRMyiN3NMu/3cD5AXlGgbPpmjGCs4dynN7jkKfG1wFS5DICWGJ/3ZV+O?= =?us-ascii?Q?aiCBFnK5wVHJZghFcAmZrIRazfycjbNScX2NQpwwjwu0wu9ukMNZMSJ8SiHt?= =?us-ascii?Q?oOWMxgtqroDKVep+FjZQFwbNIEJwJosvAW1h8USMAFI57N0P3jJNu25bMf63?= =?us-ascii?Q?yjuqN/fCLTMSVdZTf0hOeockPXT+cV38Q/FFt8ssc0MfPn8k6p0sb8cON/Xo?= =?us-ascii?Q?kMvBMqeHJywudtb4gZ7n8r/lbPrHWMOp2UDK/Beu8fGp0FLftcWJINVU7w5c?= =?us-ascii?Q?42TR1xU3XalzNFdFvDuKNmsrYN/5Dr501hrHDMcTNutV5cpVJG3ukVF81IKv?= =?us-ascii?Q?pFlyg+hP4SAKbGSY+LmPzbWpiGODNcfpia6o4Ony8C42iobT3CRtUS4kQA7o?= =?us-ascii?Q?jQLtv9HGHbCFx2JoTWicxcHkfgjkPyLdo2Fmp+0V8qbNY13BLF+bgVzQXkUe?= =?us-ascii?Q?4Rqet9dJUuuDuHqgZXym2eE3flJBmnm0aWqovXFDsQsWMtctf17N1osn3yVz?= =?us-ascii?Q?CC1acwzm2MszhLQn/dz/mOZkyVfdz0Vvwrz4Tb4K0J0cyARZx6QJlNeVlun1?= =?us-ascii?Q?cn9CuTXlKw=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 100a094f-42c0-4288-2e1a-08de73f792b6 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:48.9926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W1CdcaMbMlR8JLPwLOWhVR525VrB6eFcbwSCEPXhKgaIy2fSiGf0jvBBIlr4+ehLaoKvAecBPQWNo312Ux10UQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Introduce GpuMm as the centralized GPU memory manager that owns: - Buddy allocator for VRAM allocation. - PRAMIN window for direct VRAM access. - TLB manager for translation buffer operations. This provides clean ownership model where GpuMm provides accessor methods for its components that can be used for memory management operations. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/gpu.rs | 18 ++++++++++ drivers/gpu/nova-core/mm.rs | 66 ++++++++++++++++++++++++++++++++++-- 2 files changed, 82 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index 5e084ec7c926..ed6c5f63b249 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -4,8 +4,13 @@ device, devres::Devres, fmt, + gpu::buddy::GpuBuddyParams, pci, prelude::*, + sizes::{ + SZ_1M, + SZ_4K, // + }, sync::Arc, // }; =20 @@ -22,6 +27,7 @@ commands::GetGspStaticInfoReply, Gsp, // }, + mm::GpuMm, regs, }; =20 @@ -252,6 +258,9 @@ pub(crate) struct Gpu { gsp_falcon: Falcon, /// SEC2 falcon instance, used for GSP boot up and cleanup. sec2_falcon: Falcon, + /// GPU memory manager owning memory management resources. + #[pin] + mm: GpuMm, /// GSP runtime data. Temporarily an empty placeholder. #[pin] gsp: Gsp, @@ -286,6 +295,15 @@ pub(crate) fn new<'a>( =20 sec2_falcon: Falcon::new(pdev.as_ref(), spec.chipset)?, =20 + // Create GPU memory manager owning memory management resource= s. + // This will be initialized with the usable VRAM region from G= SP in a later + // patch. For now, we use a placeholder of 1MB. + mm <- GpuMm::new(devres_bar.clone(), GpuBuddyParams { + base_offset_bytes: 0, + physical_memory_size_bytes: SZ_1M as u64, + chunk_size_bytes: SZ_4K as u64, + })?, + gsp <- Gsp::new(pdev), =20 gsp_static_info: { gsp.boot(pdev, bar, spec.chipset, gsp_falco= n, sec2_falcon)?.0 }, diff --git a/drivers/gpu/nova-core/mm.rs b/drivers/gpu/nova-core/mm.rs index ca685b5a44f3..a3c84738bac0 100644 --- a/drivers/gpu/nova-core/mm.rs +++ b/drivers/gpu/nova-core/mm.rs @@ -7,9 +7,71 @@ pub(crate) mod pramin; pub(crate) mod tlb; =20 -use kernel::sizes::SZ_4K; +use kernel::{ + devres::Devres, + gpu::buddy::{ + GpuBuddy, + GpuBuddyParams, // + }, + prelude::*, + sizes::SZ_4K, + sync::Arc, // +}; =20 -use crate::num::u64_as_usize; +use crate::{ + driver::Bar0, + num::u64_as_usize, // +}; + +pub(crate) use tlb::Tlb; + +/// GPU Memory Manager - owns all core MM components. +/// +/// Provides centralized ownership of memory management resources: +/// - [`GpuBuddy`] allocator for VRAM page table allocation. +/// - [`pramin::Pramin`] for direct VRAM access. +/// - [`Tlb`] manager for translation buffer flush operations. +#[pin_data] +pub(crate) struct GpuMm { + buddy: GpuBuddy, + #[pin] + pramin: pramin::Pramin, + #[pin] + tlb: Tlb, +} + +impl GpuMm { + /// Create a pin-initializer for `GpuMm`. + pub(crate) fn new( + bar: Arc>, + buddy_params: GpuBuddyParams, + ) -> Result> { + let buddy =3D GpuBuddy::new(buddy_params)?; + let tlb_init =3D Tlb::new(bar.clone()); + let pramin_init =3D pramin::Pramin::new(bar)?; + + Ok(pin_init!(Self { + buddy, + pramin <- pramin_init, + tlb <- tlb_init, + })) + } + + /// Access the [`GpuBuddy`] allocator. + pub(crate) fn buddy(&self) -> &GpuBuddy { + &self.buddy + } + + /// Access the [`pramin::Pramin`]. + pub(crate) fn pramin(&self) -> &pramin::Pramin { + &self.pramin + } + + /// Access the [`Tlb`] manager. + pub(crate) fn tlb(&self) -> &Tlb { + &self.tlb + } +} =20 /// Page size in bytes (4 KiB). pub(crate) const PAGE_SIZE: usize =3D SZ_4K; --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012068.outbound.protection.outlook.com [52.101.43.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2C0D36165D; Tue, 24 Feb 2026 22:54:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973645; cv=fail; b=CyGxlOTSG+QUkzlTHgT3POowTgoUkqHD5zsgGxplL8n7WZepsmnAXXgysI9VB0R6IrVVCcgsWoySFKI1WelOPUZkLu5rhMC1hLNUFjHXCtfcMAk9jub1hyDdxpkzQVe9zI28HsWPF+lgvm8zpxLFcVvmyBeNDS11i17CVrBhJ5c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973645; c=relaxed/simple; bh=ZCBFTkQCTwPg0wcPwZ6vCzYGAGCz0K0p5w9yaRSOkqM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=KvlXI1o71EaxSy/Gy86UJ1xjaCWTgU+9YNnN6whAjyLAaBuQqbKbg2o/5qNTj3Il0T0Fcj8w26GndD4jSovZykosFE+aWk5u7xXfvkT5ispHC5fFhSiKhduDEpj4NIIrv08pxB4xZn3WeVEfRPtJVy74c+Stp3yzoG4gTEjudyw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=YfDTY0C0; arc=fail smtp.client-ip=52.101.43.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="YfDTY0C0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=op3MK24ozoShy5WzLOD4UUgLvCyRPAp8D9nJeAgDJFCAYhWekiAc73r0+8GNyOpMV+Aah50RvZE4flpTotAeo7FlQUsB4+eAoOgsLh/19hh899qoshLCk+ElswWHj6MvoZOEI4OdBbHxaNu0nmNbTfaSNRGaUQ1LJ5g0vUXiM8YWf8u4yVV4Od+oeGxSjr85eWz5dEiVUPDJ3AzU9Yux+w2E+JSfAjihXBS3OhEyipyTgDfCkvMJl+gMLrnJMkvZnxlwZz/GEH6sHrzjhsrWuMUBbLO4czQgvVcxRDhrcBNJ5sKJi9WoPrnuP1swXFXUUtQK3xP1+diq2dG7NO7i+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gaZGsToBemDutnVDRVR63UF4u2CUHT1Lwlg3rbjh36Y=; b=RDPV89OMljGj7P+1CZJgfqoBqPLwNU+x+gLk5BgjC24Y/vIeMFv4WpUj1idKfvAbqPmNjdbNqXslX3tHRqgSjZ0LGrlpPHoR5gDoALunwmNPk2wRIWDUF3zdmA4N/gBZquHDMSt951gfvSjJSmhTmJfNmNhd+OYKMb5vzOd/F4anw9OOufJESj9sX0N4haVzFkfuff/OF9hyRnUTAH0iYP7E3rOFo5iDp9tDWsCt4Y7k0j2G7bs2QmShurv9ZkWVhlcWxtYmAUn0OTdGRGJ8UgowHDgU25jAe68g/wZnlvg8BP62/u9Eg3JAKtn5b0BAAEHOELEHhKbSLRLc2AnF0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gaZGsToBemDutnVDRVR63UF4u2CUHT1Lwlg3rbjh36Y=; b=YfDTY0C02FgaPfnvYSLGQdG6b+cqlJElu31dE9pY2fpM0+yRyb8/yqZqxD9lG4koAbYGe7ssqClszQCwyaEFIVC2qllXG+R62LVRuRMMH8dPM/lmVewDfAU8dy9OLid4e12ArAGrpi5cKub2AC1HZJmqyym0i9KxtksAi9FclSboVrQkSmoH9Gy2Wf4enR9ngGWrHSbbB15bKMnIRieDUw5+FeimZZSFbMdYWzA7MdUBtEC/qnKZAf8590MoT2MeIQbXadpt/pPUdLESj+2EFsgPQL4c0nhv3Nw7vBIq6lVh7keharaO7nYcWOgyf3WD/pg29rKBsvyGRhknGbQygg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:53:50 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:53:50 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 11/25] gpu: nova-core: mm: Use usable VRAM region for buddy allocator Date: Tue, 24 Feb 2026 17:53:09 -0500 Message-Id: <20260224225323.3312204-12-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR15CA0039.namprd15.prod.outlook.com (2603:10b6:208:237::8) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 3bd9b7f4-b7ba-43e4-f9bf-08de73f79378 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?p9C326EMI3q1sC2VDoDPBCQYiIZoyvIM5Hi9AVTUVDZTUXyPJxjGwlQjfKbN?= =?us-ascii?Q?+NxuoLzY60PAKBBUAywBHW1v4gA3GlcmQkAXKf/wLlFs1OddM10cPT7ml0fa?= =?us-ascii?Q?wrC6DwNVtVNLtC50YRdX0ospKLt7BGtxdDJ1YJPZwA8wmB9V9zjLi3FxQc39?= =?us-ascii?Q?PImvUA8CLKFobBVeug3tCm1F+QSUFEfTdMj5KzbN7IqGhxgzG/vAq9NqGQo6?= =?us-ascii?Q?en+C62ZliQuul8jKvdoUQBShB7zIfhbq2negUwAJ2yVhWLXeVdKIcJksnGYM?= =?us-ascii?Q?nVv2/l0kPFJFZMGY3d7jmrKDX3isPBOX9sh+fuNwfWGMprd94ydwr88YAuTC?= =?us-ascii?Q?UrYllTK72eRw1GD5UncqxDM39wz9jffLh19jhIc4qt1GHKVJ0uBOS8mFpfCJ?= =?us-ascii?Q?YP+nBBKCUHEex2fG69CBG9M9ve2W/NHSTwna6cZT9tKVUCF9FUNPH6V2h/9y?= =?us-ascii?Q?e1FbB6gd716qaJxFCZF1p2QrTtcrGnpZ0RB8EYvZ/48LlvHICcf3I7kkSI2u?= =?us-ascii?Q?U0MoM9QX1SnLRwKx61KB93OES8gSp8a/VZuTO5PSP3BOcXWZzGx87sqK/ywD?= =?us-ascii?Q?yNyJRp8KA+3XUuD3y/Jx1uoUtT89LhqU0DAzc22zxFlrVwHPAT1it/nwe9cX?= =?us-ascii?Q?8++oYLP+NIVNfCUDA49sDv+QhyTq3Q/ut3kdj3TSxMUzptboRdl2nMeSm5dW?= =?us-ascii?Q?m+xk6sABXFn2YK7CMMHMjCAlvHuKLY0bCi0SN+OHZ+KSMqGH74eC8eoQ6SH8?= =?us-ascii?Q?+stbLEPnKskTdLnfUr/mnS6z5NSEhQESektoNF8B9veYbRYWI2DChdxBRA9e?= =?us-ascii?Q?eV79sNMDiHIntnECvIwbPCTGya/KlZH4/A7/WBO7KllNWRKvYuFKINzzhgGp?= =?us-ascii?Q?kTAW+q1FrYdmBtbF0C1v8Y/I/zn3AV7zIH8I7OwOTIXUZ4YCoOWQgOH/Kivc?= =?us-ascii?Q?aEvhPjjK9ubl1zJdSP6Z0PSLrofb7MFrt+Idp/sV1mZumydTZvHHb3N2WZIv?= =?us-ascii?Q?xuIQkbQnd2GzJX3P6rcz2ci6XBxbRjRoKch4H1+D6lNY90DUpEc2191pakNV?= =?us-ascii?Q?yk0aevOnVYn2MCXW8BxgCGiSd0BGkqaNhmNTUqa5kksgjDASZKNatefow2r4?= =?us-ascii?Q?P6tiXgfp955KGyrujhQ5nh9kOxjM0tM2kVGQBpPcvQE0nHXykp23O0i/5iHG?= =?us-ascii?Q?bym6Tl0veciQ/mA/dPM5ti5oP14ncOTwEc2tbheacnqtYkpLVPCMrGfSaQ5n?= =?us-ascii?Q?diCrsphb+4ztWjK7s19EWE2nlmMc27TBCw3+H8WH47cdOaipNA/A2bpcLeYS?= =?us-ascii?Q?lIqwC0pphZIw9DM9C0GQntyxyr4fxbpxHsPNurGdAd79fBPAxkoVPCuTF3uo?= =?us-ascii?Q?KHQ84XjKr1jo5G1nDeVDp99oTsa81UQLbn5HBxqlI5H1iq08pV2C4mCMdZFG?= =?us-ascii?Q?BAbed2KOfeeU70SygTGWxHb4+u5WBqYOdOP56VvyzHq6j3YVHXu8v9f414Ci?= =?us-ascii?Q?kaUgbiNbik0fuhY5Koyk2dxrxR5AOv5l/apWexBI0SfP+4S+ASApSq+m8NWt?= =?us-ascii?Q?j5snvAIpP+tWuuQJs0Q=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6E0Xyz9XyBac8A8KQrPqaA8QIuWn6cOWcxEDDw1gfI7SHYoantZNbQlzU4lc?= =?us-ascii?Q?SRsdbjhTDvzK+M63NG0DFlxNj6loO4szr+Fnx9R7DeJ9qUp+xtRdl5YF9j6g?= =?us-ascii?Q?jeItXq1XcA2ZYdyeonIkGXN/rtonUFQJOcE+tEbRZQJg8fLbAkFtbTpPiarD?= =?us-ascii?Q?qWX70ZwtET9EsQ4YVl3XZDxSwyUJOEeUsDsF9GpvBCLRHcoCI+M6S4pHTF/u?= =?us-ascii?Q?m7jvUKxNVz3SJKuyvnGAfi7d6b5W6HylAVxMBgw//7cwCOr8G/g/6x4ipOUz?= =?us-ascii?Q?rglKt/sypdx0SKqq7MIN8kV1rC/6NWNa757pD2RxwFC0WrfqiFre0tboxf6U?= =?us-ascii?Q?iZYXMuhvBx7oj7F0OqfjU8Xa70c5WeaOVSmbv84c7muR/DHIeZjp1ToF+/bm?= =?us-ascii?Q?RXrHO5kqjwLNmtJeVwAIQVK8qWRaOYu5q/o912eJqS4/lUnci5bCRlOUqQis?= =?us-ascii?Q?OwSQ+lYKwGrCCFDe4yYfydQ8Agn94rklDmT20ARvP1T326mOKEBDHPZWfAtA?= =?us-ascii?Q?Q8XmYiNNXnlz2adtkWakrtFjUPgG0xcz9jdOXeN3TSXFaTqi66Q4x0pa1JG3?= =?us-ascii?Q?J30PbWzbu5tbm9uw8oSvl/scgnCCUhUsDfYivDgURV687Z66xAXSJtuOXmoZ?= =?us-ascii?Q?csg9MRyZgIS+3L7OuIoWFuVFEoTU2aqmUrCkB/zmnT5ZstAWdQmUk16fm47h?= =?us-ascii?Q?KIyI9A8U6V28fLLIPuGzjz2gV/04Sho8pEwpFlAPI8e9KHr+Vm8yuGB0X3nt?= =?us-ascii?Q?dl0DG4uL6qkU7a0RV/rqC1NOtDvwHwcfygck8G3zddnLx7f04yxWKCC/xK0p?= =?us-ascii?Q?aSqfFQMdcZgqfTKZ7N5/S+v3AQSuCeS2IVkulyquebBHSPN+Mf/qPtIR5wLN?= =?us-ascii?Q?wJCyEtkZ0aBXevinCFtFYfimGx+jubnhnSj0o22w/6hprdcRtlxOYYS2szlt?= =?us-ascii?Q?03iRhuTZpBxh3ybeozT+NJ9RPy3NUqd1kDcRj1HLK3hyErgbhW+Kb2ao2KFr?= =?us-ascii?Q?rmFx0B0W8BUHAwAA+j0/apYB2Sf5KX0oX2uKHghbX0ws+gp/lHXpxQ1DYn/q?= =?us-ascii?Q?8Vuo17iDi5WlOpvV01pQfAk+zJPHXhnwJGqtcd4kmvQrLFI7vs2g2o2q5IXM?= =?us-ascii?Q?jzGhtiGTZbPATT5pa2dqDhXIJ0Yl8XFh6jOWP9UhNMqvYz4zEbWzVMeF9XPh?= =?us-ascii?Q?xEvH7T5eXSiS8+JSt9nS4eWFjmjadIPuWxrFIVwkGap9tnxDQ+jnWNbvEbno?= =?us-ascii?Q?gFD9hd3kIUh/Ac0ZLMD5/izFZRos5pdzOab3LkdlhlkO3BcXyvM3YrFN3QFq?= =?us-ascii?Q?mbCV2fx/HON/D/4eaqOYPGMghjy457J7R94yYMWObO/+kxfSErkly8BPO3Wx?= =?us-ascii?Q?ULOu1dTvE0CStYDNtFA6d4K9gHE8hh5xudVqZLfMLEZsFY1X0pjp5MKl2TBq?= =?us-ascii?Q?VN0lWop14sTza/HkDp4zbkvtsUIBq8rqN4TFLU5cyLtpd5gDZHLPi1wPKFCk?= =?us-ascii?Q?do7D4YbFsuQZ2dCIuhA962qPqHV1+v7TKWq8XmJHc2340Vb0KlTK2QiDRMtD?= =?us-ascii?Q?YFakV9mNIyNySXiqMfaBoQXhxS8DPkcuulEw9TQG6uE0p1H+pMWuKWmo0AQ1?= =?us-ascii?Q?UPpOrExVv0khiAnHliewl094AyGzJp20oV9DppZTdxU2PDfbp/Ci+sbAyff2?= =?us-ascii?Q?WM0tTNpx+4LZbNVB9/Ey/Ui/bkjFxgAfwEwPUWAPchW3vMSQefpJLKW0P+dK?= =?us-ascii?Q?9uKwrfKRGg=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3bd9b7f4-b7ba-43e4-f9bf-08de73f79378 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:50.3399 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v4sNCeLzGYVV/d07LUHWiTvTLHIClsjKrf1llMEofAM7+MDBuwV5f70w6KKd65zQEgcakLanJDPKSUXQ1EpwqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" The buddy allocator manages the actual usable VRAM. On my GA102 Ampere with 24GB video memory, that is ~23.7GB on a 24GB GPU enabling proper GPU memory allocation for driver use. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/gpu.rs | 66 +++++++++++++++++++++------ drivers/gpu/nova-core/gsp/boot.rs | 7 ++- drivers/gpu/nova-core/gsp/commands.rs | 1 - 3 files changed, 58 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index ed6c5f63b249..ba769de2f984 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -1,5 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 =20 +use core::cell::Cell; + use kernel::{ device, devres::Devres, @@ -7,10 +9,7 @@ gpu::buddy::GpuBuddyParams, pci, prelude::*, - sizes::{ - SZ_1M, - SZ_4K, // - }, + sizes::SZ_4K, sync::Arc, // }; =20 @@ -28,9 +27,17 @@ Gsp, // }, mm::GpuMm, + num::IntoSafeCast, regs, }; =20 +/// Parameters extracted from GSP boot for initializing memory subsystems. +#[derive(Clone, Copy)] +struct BootParams { + usable_vram_start: u64, + usable_vram_size: u64, +} + macro_rules! define_chipset { ({ $($variant:ident =3D $value:expr),* $(,)* }) =3D> { @@ -274,6 +281,13 @@ pub(crate) fn new<'a>( devres_bar: Arc>, bar: &'a Bar0, ) -> impl PinInit + 'a { + // Cell to share boot parameters between GSP boot and subsequent i= nitializations. + // Contains usable VRAM region from FbLayout for use by the buddy = allocator. + let boot_params: Cell =3D Cell::new(BootParams { + usable_vram_start: 0, + usable_vram_size: 0, + }); + try_pin_init!(Self { spec: Spec::new(pdev.as_ref(), bar).inspect(|spec| { dev_info!(pdev.as_ref(),"NVIDIA ({})\n", spec); @@ -295,18 +309,42 @@ pub(crate) fn new<'a>( =20 sec2_falcon: Falcon::new(pdev.as_ref(), spec.chipset)?, =20 - // Create GPU memory manager owning memory management resource= s. - // This will be initialized with the usable VRAM region from G= SP in a later - // patch. For now, we use a placeholder of 1MB. - mm <- GpuMm::new(devres_bar.clone(), GpuBuddyParams { - base_offset_bytes: 0, - physical_memory_size_bytes: SZ_1M as u64, - chunk_size_bytes: SZ_4K as u64, - })?, - gsp <- Gsp::new(pdev), =20 - gsp_static_info: { gsp.boot(pdev, bar, spec.chipset, gsp_falco= n, sec2_falcon)?.0 }, + // Boot GSP and extract usable VRAM region for buddy allocator. + gsp_static_info: { + let (info, fb_layout) =3D gsp.boot(pdev, bar, spec.chipset= , gsp_falcon, sec2_falcon)?; + + let usable_vram =3D fb_layout.usable_vram.as_ref().ok_or_e= lse(|| { + dev_err!(pdev.as_ref(), "No usable FB regions found fr= om GSP\n"); + ENODEV + })?; + + dev_info!( + pdev.as_ref(), + "Using FB region: {:#x}..{:#x}\n", + usable_vram.start, + usable_vram.end + ); + + boot_params.set(BootParams { + usable_vram_start: usable_vram.start, + usable_vram_size: usable_vram.end - usable_vram.start, + }); + + info + }, + + // Create GPU memory manager owning memory management resource= s. + // Uses the usable VRAM region from GSP for buddy allocator. + mm <- { + let params =3D boot_params.get(); + GpuMm::new(devres_bar.clone(), GpuBuddyParams { + base_offset_bytes: params.usable_vram_start, + physical_memory_size_bytes: params.usable_vram_size, + chunk_size_bytes: SZ_4K.into_safe_cast(), + })? + }, =20 bar: devres_bar, }) diff --git a/drivers/gpu/nova-core/gsp/boot.rs b/drivers/gpu/nova-core/gsp/= boot.rs index 7a4a0c759267..bc4446282613 100644 --- a/drivers/gpu/nova-core/gsp/boot.rs +++ b/drivers/gpu/nova-core/gsp/boot.rs @@ -150,7 +150,7 @@ pub(crate) fn boot( =20 let gsp_fw =3D KBox::pin_init(GspFirmware::new(dev, chipset, FIRMW= ARE_VERSION), GFP_KERNEL)?; =20 - let fb_layout =3D FbLayout::new(chipset, bar, &gsp_fw)?; + let mut fb_layout =3D FbLayout::new(chipset, bar, &gsp_fw)?; dev_dbg!(dev, "{:#x?}\n", fb_layout); =20 Self::run_fwsec_frts(dev, gsp_falcon, bar, &bios, &fb_layout)?; @@ -252,6 +252,11 @@ pub(crate) fn boot( Err(e) =3D> dev_warn!(pdev.as_ref(), "GPU name unavailable: {:= ?}\n", e), } =20 + // Populate usable VRAM from GSP response. + if let Some((base, size)) =3D info.usable_fb_region() { + fb_layout.set_usable_vram(base, size); + } + Ok((info, fb_layout)) } } diff --git a/drivers/gpu/nova-core/gsp/commands.rs b/drivers/gpu/nova-core/= gsp/commands.rs index c31046df3acf..fc9ba08f9f8d 100644 --- a/drivers/gpu/nova-core/gsp/commands.rs +++ b/drivers/gpu/nova-core/gsp/commands.rs @@ -234,7 +234,6 @@ pub(crate) fn gpu_name(&self) -> core::result::Result<&= str, GpuNameError> { =20 /// Returns the usable FB region `(base, size)` for driver allocation = which is /// already retrieved from the GSP. - #[expect(dead_code)] pub(crate) fn usable_fb_region(&self) -> Option<(u64, u64)> { self.usable_fb_region } --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010042.outbound.protection.outlook.com [52.101.193.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C07E361DA9; Tue, 24 Feb 2026 22:54:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973646; cv=fail; b=i5Ahl3FQXfWSUvKqDyi9KNn3p6OZEaP5pNlcK3NaUvRkS3kMyiL6YXVcmST0fK71wpI83+agVUM+5BSw5NHFIVBYGxHynmeZVL90hyrXXUK2nn6kBrh1Bg9bjIST7dA85Zz7wVNpokdvRqAc89jkj4agPLtLd4U76P9W472ct7s= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973646; c=relaxed/simple; bh=PbVgTvfqM3Pf9XL7kPKnqNNpM7Z6h+ro5F4a2l3OpfU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=hRUnKlN3F5O8fo4yuNGMbzES4eojT0zDmxhOgB5UF8mtmMHUq2XGFiBeV5lzfhIme1/9oEWqVv0SJnSwgAOUuzqIxsSIJw7fhh39eOcz3BwEyYD6dXOjp3kvGZzLmFfPV0X7KH7mza38NGuVo69blAis+GBLi6zDRHO87S86SWc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=tG0MN+QT; arc=fail smtp.client-ip=52.101.193.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="tG0MN+QT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WD2O+/UTUJzql2Ce56wmnwc5zE3hX9oecKrmqOkVFrENbsi64Y79WKeaUE5OAuKB0n+U3oL5VsZchgWN8+nAaDkpY6xEODkK3M7nouqaxTY7F8kkh53MRAK+DmspCw15YS0UgpCt2U44IVzg7XmOrPURmecOGbrR94bgyyaT+ymll3k2E62D0z2j7Llrhrk9fyAp8ZztrSxXxHKBlvWO9KuWxU6ff5Gq+gIeaa2A4jSUckIcEF3cK9J33JS+CX54uoPxBnNul3ESni6PTH29KF8oxJO0CECHEY6+VPDCW20h7rKwB3bPe+Hqwn2oG/GDW3wTNynaEwNhKUt5yCz8bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rv2O5IFUWnJS0FMgeuRik4bdtWoi9KSDBpZammhvhB8=; b=DMcjNnNydxAWkgdmv/ie/hPzzkbRrIbC5F3w3PB60SSOXt5a6SrDFarkccPMwAVjwXrvGCQBRyGHm0cdD4GgdlrMKvSqjzK83CfAY8dlD8X/8J9yH4+Bc+EztVARbRATvUvdjKNgtHG0fEscoYAJWG8dZcyk5M0rtj1no6YlrHM7TMqKa48bCGCbCxYeniop8dYq6uvQ0K9tL6wSOtxXUcDFbTwTGF/BKcqrC7jt0K0zWHfOGKBzEfJiZozSwOdKjNoIsUV0JUC0SFl12hCGZKlj+xZBhThw/ep+chr6jVBcdQ4CzCmtF3OW5Thu+sQxqjG+me2v+k+rPKwT/kEymg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rv2O5IFUWnJS0FMgeuRik4bdtWoi9KSDBpZammhvhB8=; b=tG0MN+QTG2hPjggHeAvXuR4ktvmG0a8X1DxzrA+1pEkYrdVEesI3cVH1vm5ygiQvSI33mPLnxFwOeKUDrtjEY2CRsJ79PZmF+kVIC1pYV5zndGiCE5oKQKe3Ys3ENm4gYwgirMTgbYMXnWwhdFYysZMQs4Vt8NgJV2FqooWLi2673bsxBEHCT9tiPletSuvGwE+/k3uS/hz6bkB7YuAxoTZ1/HxlMGPcLa3cycuDzIfy81W1AMnuJk4wNyfhLKNSwWCwQvsZNbmehvRcLHsHoGcEt3Pkch6b47oahpxqontZWa4ds079okAJhMyLJYIdevWpk8GjAVgiF6lD0w5Wfw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:53:51 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:53:51 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 12/25] gpu: nova-core: mm: Add common types for all page table formats Date: Tue, 24 Feb 2026 17:53:10 -0500 Message-Id: <20260224225323.3312204-13-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN0P221CA0001.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:52a::7) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 55f8cafd-ce83-4cfb-59f3-08de73f7944d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?dz6xIyj4HqGKPwQwQt9xdyA77afimb5/YYmzIsyoXni9EbBimddz6OZsUY1h?= =?us-ascii?Q?rl9gwN4mPkZzMpKOky8mOelZnN1Bt6uIJIJRTIZ34qEEZROYNP265Lwwuv7P?= =?us-ascii?Q?BJDBHIa1Zqz7mP97RIDd1/7K2OCVaODfHCp5L/vj0xuZgP5dF7mNrLmlQ/iW?= =?us-ascii?Q?/fi/iFH7s01/nq/oCo45DGaFplMhtp5MzL1KhoaxLlEADTm2VgjNNKxU1YAj?= =?us-ascii?Q?GQ2AjeB+fpyWjFtfW1luSnJ/EX9hSqsG9P0uVPXdPVz/+iBMmvq+ewYd2emf?= =?us-ascii?Q?y6o6I45WjY/jFfWL8pvyJSbjuMNbvtqq92xk8hi46qreJyS8z4PfTZJrVkuf?= =?us-ascii?Q?8Gn058nhlbvCrlpYOyfcnShFs6omw6x0N+mgK3V8tlaxpa9DQQQPfCc7fC5I?= =?us-ascii?Q?EX16GTU13uJgByxNwl8VyKp12wNHv1eUczd4Pj/oNmX05TkFH3kjqRp/Hstn?= =?us-ascii?Q?X+T38jRiv+pk+mmEckQYqHcuIWgEUqZxzaOgavCtNc9ILm8sDIMvKOwkyOht?= =?us-ascii?Q?boEJ+pd9aeR4LHiRk2epawpOD4geW5pqSzV3hHMCif7LLFGBZA1OIabZXcno?= =?us-ascii?Q?Uxt2+FyDtLQydBlQe3xEMAPrwf2ia5DXZD6KbrZNJvkwsY2Mow/N9+QQQfFs?= =?us-ascii?Q?dok/spu5NbfGsck76A0hingd0mO9nUBDs5KzY7dqBJdx3WNuSj1UKn1qtaFz?= =?us-ascii?Q?AyngSF0Or3G3XpjOvv8SwM5csztB2Ved46f6TyRxltqIar8uZClWtd30co7Z?= =?us-ascii?Q?4UH9ITMxMEKI8elStLBQFRHhYgz/skFOtqKoruzhxJDVGwBDud5UPV+LoO3X?= =?us-ascii?Q?miaGNsy/dXP2euoJJKgtS6ydGI1yR7tC3Wfq9N8QX0ydhxtSIr2TuvYvEcQT?= =?us-ascii?Q?4YGIKJqtq/wTjC/zNb7eMDxts2PBR/gUBMd+EhF7zL8JCfRFxpMjDzQJY/aR?= =?us-ascii?Q?jFGEYQJddpPsoGZW2uG9IqA2nV9AIXIkO5+MOpjbaq+/2IDqaNv6C6NcIaP6?= =?us-ascii?Q?3b83fH90xyJNudK/A0j3fY2qbQmnKeV7lMdC22QaMWg7Blf5Sukwoy6OCS+g?= =?us-ascii?Q?DGE1pQbum1x6/2KpCggqfQI2n9YCjP+sVe5Ka3GBYVelrVXBlqFvjnsIBXql?= =?us-ascii?Q?/UjcZo1+smwcwBksVY3iu0SgBmSWLOlgkgvCxDbAQkNmuxXLzM/4Kd/j3keJ?= =?us-ascii?Q?J38yL3ygH6eQjzv3pOvrEdlOGntVe+lddCwNrVqKbmXElnZMhew22MHZ0nlw?= =?us-ascii?Q?G/1Kyzb2O38W8YRS9+y9wD692JMvFO+oFfU3nrEXg++Ypak5DTEgSbIY7koI?= =?us-ascii?Q?VYyPUE5WquEPluQqmSLZnfyOvT9mlW2I+yFbUxZj2bj7FpkcWiFNZ51fWw+v?= =?us-ascii?Q?RSolUPZRmxow+5DbBboxo1gW0a25GZLiqBTpH+RW3bpI5RxiopTDFeMKzGYB?= =?us-ascii?Q?YLoYVENOCmdE5eucgJcRxM7L6VOMpp9ZyTLX7PANLFvDjf2E+LtqCE3lk2du?= =?us-ascii?Q?kAzvabpx5olt6Med4w1tU1+82FfnxYHUyQK37Tf6fQsuFbuwCLDhTR8M3pAL?= =?us-ascii?Q?V+LjXuO5y3SK+zjKIGo=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uNs5ucwtsn+8Fuy4oXG9NbdSpZW25oa5JK0mXI7PtJo2yvG1GYVA2V5c9fFQ?= =?us-ascii?Q?ijcbrrNBv3k7OW+oWccbPtKrlNQnJDH6czNpBOgvOj7xA/HYIPpzbJB5Nexh?= =?us-ascii?Q?WlD04NgOpYP4W/bq5fbLjRNMdS8Q3Yyc3izeONiP2EoEeP83xTlsrHaALLG4?= =?us-ascii?Q?/+62LWkJp0HEoyuTGQKOF22m43CJbdU4pgp7Zv/Xt36Jf1l1h77szv6DYIYj?= =?us-ascii?Q?CqsISn6zXI+l/PaKIz7ThL0Mds7aqjnY6WlLcFZ3TFQ5sWv9dElm9iGL5X1e?= =?us-ascii?Q?PvqAMsjNBi6Am4gPVWyadw1HhoEDFU+uRdC5ddUP/XHvmkwunqQn2mQmnS8Q?= =?us-ascii?Q?+zSAp19FKtv7AQm9yxHsoJAKGD1MA6/z9pE7QZsQ305QXMix15MdviHIZnX0?= =?us-ascii?Q?vKVBho7LQPLn2RUtzWnLGr+NO/tke49UAx5vEasfoa1Q3CQpx58R1JD0Jy5J?= =?us-ascii?Q?4Ay90n4+XsdIDCIKwGvCvAGIB9eY3EWvDFxlOG7i0ZgWINeQCJ4LAf9fWMvk?= =?us-ascii?Q?NFsSkwzuOXgqAMKQPaZaFGTx+wPsy6sBrCt8N4IeT7JdgO4IT7tVm4zTsagk?= =?us-ascii?Q?TSIyIXC/voVsWxv43sPIR70YMaHSPpZizC6IIMNToanngeTV5NPWEQzNSAkM?= =?us-ascii?Q?7dhGHeprggaD4vhiukcUXGpORVp5c5bPJwUd5UemPz4Csk9MT132XW3mrcwB?= =?us-ascii?Q?lWBPASBH64syRv9ltC7Z5sBv+KMQiPYH7zQvZpRqlTzvesjWWxtoPoQQe03l?= =?us-ascii?Q?p5nVdH8HLV4R4Erip1ljdWcuZd2lfrX9fRe4afMPGe+CpNrVYsA5e2UY/KHk?= =?us-ascii?Q?aAadeLMcC7pobJNBpjbW4H0lt28OiAGm366LpOF0c/7D7KC4TX5AxTrIyasF?= =?us-ascii?Q?iq4GaK5xEUKH4FxfSqZneldWEI0VH7Vrx1lYJdHH1ZNuUZH9H9ZNKm3jyAx6?= =?us-ascii?Q?mHkE6+PfZbDud1lOeR155NLGxz9zsxbdLYltlWvp89737yecbpYeRT4yskL5?= =?us-ascii?Q?Bk7CJNCdyTbzHEnMTflb/1Z2rjHTL76UpNGTtXjcbnk0UpJgYBfCl9oYsimv?= =?us-ascii?Q?QMu67+48gJMklNUPW7d9EywdqfFEWtNn/lrKdGaQj98OAib1Qj8RZM+ghvIU?= =?us-ascii?Q?TBcZketlmkS8C1Ez/AF5DPxszji0EOk8OmMHtDkq2Eq5bsEqQAmanfdxC3ez?= =?us-ascii?Q?SQ4y/SUQuWjAuEqrnQpoZxL/ozKuwk9FZHgoCZXYbxbOvFLTamsgIHPiZMA1?= =?us-ascii?Q?GDe9rHy0lZtKj/Q5RE+rhJxQ5HCciv4Rz/My6D7bKQiPfNSFj0UFWs0pm56h?= =?us-ascii?Q?LvPNIvcOIWV2+2Z6K/OZou6G7kXQSKa+w3Cr/NKchSN5p5QTDTuifHms8sVD?= =?us-ascii?Q?jRuywNhHX96Nt2BOxJs5UWZMcQ3mtP2TRUKVvH2MLDP9phSNZPN7HPKGKtzT?= =?us-ascii?Q?ZmxvPQZpz9TBThMpa0OPQVWi1TLUIofV2OYKvqFeJyiLngWWktC2/CKD/tJi?= =?us-ascii?Q?CWgCeKRnindVAXiT4GXYYsDJ97xNy86JY09bekx4R4V6rl5VwwWfPcJGfayJ?= =?us-ascii?Q?VSdV11hTdTUmwPyfj0AvmUn5+5YgM01Ty7tSckn16LtDIFZW7JLRQkj8wMye?= =?us-ascii?Q?/pygL0fi+AlR9rbaE5pHvjzHEB266/OWtlBS37heyOVEyQ/SHWlQXYWsJ0D6?= =?us-ascii?Q?VPpiD98He9iCFnl6m2zc70WUhrwogTYnRkqdyr1lmnmNbh8QNNQoFjST74Nv?= =?us-ascii?Q?fwOVAHw0BQ=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55f8cafd-ce83-4cfb-59f3-08de73f7944d X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:51.6674 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WRTtShDl0WRb7POIeIYl4CsUDmbUk1k5lhtFaqY18LMOXrnWFNgaRKVrX0jzmHl0S5/cTNHi9THllJZ42gvBwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add common page table types shared between MMU v2 and v3. These types are hardware-agnostic and used by both MMU versions. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/mm.rs | 1 + drivers/gpu/nova-core/mm/pagetable.rs | 149 ++++++++++++++++++++++++++ 2 files changed, 150 insertions(+) create mode 100644 drivers/gpu/nova-core/mm/pagetable.rs diff --git a/drivers/gpu/nova-core/mm.rs b/drivers/gpu/nova-core/mm.rs index a3c84738bac0..7a76af313d53 100644 --- a/drivers/gpu/nova-core/mm.rs +++ b/drivers/gpu/nova-core/mm.rs @@ -4,6 +4,7 @@ =20 #![expect(dead_code)] =20 +pub(crate) mod pagetable; pub(crate) mod pramin; pub(crate) mod tlb; =20 diff --git a/drivers/gpu/nova-core/mm/pagetable.rs b/drivers/gpu/nova-core/= mm/pagetable.rs new file mode 100644 index 000000000000..aea06e5da4ff --- /dev/null +++ b/drivers/gpu/nova-core/mm/pagetable.rs @@ -0,0 +1,149 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Common page table types shared between MMU v2 and v3. +//! +//! This module provides foundational types used by both MMU versions: +//! - Page table level hierarchy +//! - Memory aperture types for PDEs and PTEs + +#![expect(dead_code)] + +use crate::gpu::Architecture; + +/// MMU version enumeration. +#[derive(Debug, Clone, Copy, PartialEq, Eq)] +pub(crate) enum MmuVersion { + /// MMU v2 for Turing/Ampere/Ada. + V2, + /// MMU v3 for Hopper and later. + V3, +} + +impl From for MmuVersion { + fn from(arch: Architecture) -> Self { + match arch { + Architecture::Turing | Architecture::Ampere | Architecture::Ad= a =3D> Self::V2, + // In the future, uncomment: + // _ =3D> Self::V3, + } + } +} + +/// Page Table Level hierarchy for MMU v2/v3. +#[derive(Debug, Clone, Copy, PartialEq, Eq)] +pub(crate) enum PageTableLevel { + /// Level 0 - Page Directory Base (root). + Pdb, + /// Level 1 - Intermediate page directory. + L1, + /// Level 2 - Intermediate page directory. + L2, + /// Level 3 - Intermediate page directory or dual PDE (version-depende= nt). + L3, + /// Level 4 - PTE level for v2, intermediate page directory for v3. + L4, + /// Level 5 - PTE level used for MMU v3 only. + L5, +} + +impl PageTableLevel { + /// Number of entries per page table (512 for 4KB pages). + pub(crate) const ENTRIES_PER_TABLE: usize =3D 512; + + /// Get the next level in the hierarchy. + pub(crate) const fn next(&self) -> Option { + match self { + Self::Pdb =3D> Some(Self::L1), + Self::L1 =3D> Some(Self::L2), + Self::L2 =3D> Some(Self::L3), + Self::L3 =3D> Some(Self::L4), + Self::L4 =3D> Some(Self::L5), + Self::L5 =3D> None, + } + } + + /// Convert level to index. + pub(crate) const fn as_index(&self) -> u64 { + match self { + Self::Pdb =3D> 0, + Self::L1 =3D> 1, + Self::L2 =3D> 2, + Self::L3 =3D> 3, + Self::L4 =3D> 4, + Self::L5 =3D> 5, + } + } +} + +/// Memory aperture for Page Table Entries (`PTE`s). +/// +/// Determines which memory region the `PTE` points to. +#[repr(u8)] +#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)] +pub(crate) enum AperturePte { + /// Local video memory (VRAM). + #[default] + VideoMemory =3D 0, + /// Peer GPU's video memory. + PeerMemory =3D 1, + /// System memory with cache coherence. + SystemCoherent =3D 2, + /// System memory without cache coherence. + SystemNonCoherent =3D 3, +} + +// TODO[FPRI]: Replace with `#[derive(FromPrimitive)]` when available. +impl From for AperturePte { + fn from(val: u8) -> Self { + match val { + 0 =3D> Self::VideoMemory, + 1 =3D> Self::PeerMemory, + 2 =3D> Self::SystemCoherent, + 3 =3D> Self::SystemNonCoherent, + _ =3D> Self::VideoMemory, + } + } +} + +// TODO[FPRI]: Replace with `#[derive(ToPrimitive)]` when available. +impl From for u8 { + fn from(val: AperturePte) -> Self { + val as u8 + } +} + +/// Memory aperture for Page Directory Entries (`PDE`s). +/// +/// Note: For `PDE`s, `Invalid` (0) means the entry is not valid. +#[repr(u8)] +#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)] +pub(crate) enum AperturePde { + /// Invalid/unused entry. + #[default] + Invalid =3D 0, + /// Page table is in video memory. + VideoMemory =3D 1, + /// Page table is in system memory with coherence. + SystemCoherent =3D 2, + /// Page table is in system memory without coherence. + SystemNonCoherent =3D 3, +} + +// TODO[FPRI]: Replace with `#[derive(FromPrimitive)]` when available. +impl From for AperturePde { + fn from(val: u8) -> Self { + match val { + 1 =3D> Self::VideoMemory, + 2 =3D> Self::SystemCoherent, + 3 =3D> Self::SystemNonCoherent, + _ =3D> Self::Invalid, + } + } +} + +// TODO[FPRI]: Replace with `#[derive(ToPrimitive)]` when available. +impl From for u8 { + fn from(val: AperturePde) -> Self { + val as u8 + } +} --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012068.outbound.protection.outlook.com [52.101.43.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8474361662; Tue, 24 Feb 2026 22:54:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973647; cv=fail; b=JVmq0BXEoCbyFCvi5z9W+sBLrRDQgWkHIRZtJo1Ag4phuhUrHwGrpmFk+9v8MIncXTi0xdbkpgsW7nHkWefUepHQxatn8vCNdGXdNU4lPwIh583mHqToCFzR+AIpgIVFac1PncLjTpb7bkYwBV7uzwgCV667bVGjBG3MTs1Ja24= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973647; c=relaxed/simple; bh=xemayrneFFGJIWCVAU+W9IeCeBf7UHP4ReLtMEfL4+o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Qhzp827xuaZ7Pg/hTgmzWhjQgmicb31YBjbxi96eyslHhdoGDPXClqIzVCx30EwZx0qsyHQXY3pdsGOO6BABJxSzTkVQGWtFkLUuikDnaRBogHYmmg5KySrhkz5sHqxsWml0Hx1VOFYDq3CztR1sPIsIAGHpj6hnig9+l4iWjfA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=WMpfvFIh; arc=fail smtp.client-ip=52.101.43.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="WMpfvFIh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DwNs9KLWzaLYu2sYzu4r9ipFQ2AnLnO2HdfxYf0LspYKYph1i892jnQwqxXtbGLySh5/DKe2HSg/27FdPTOp7D/Avrn23hOVzjCSvxRwtM2FuwRsYOi5jQJs2cDYgPsJjp2xyqzKdQK3DtZTjPBx2UgapNlReZW6Ads33uzJcwPf/zLLc9v8rjQXUI3FIVJ43YvSwK/SfumUt7aQiDhufmxPg0P/Iw6z5uwLbo6uNT/Q3sC4hykxOHiNiBU06S3e9DeR40I0f9ASZsqdq/i0y2gNNKoHK2x9U3U1v/MnlBK/GfY/FRW9eHyo4rw+IiB5pwdT24/nexe8O+oW0McMJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+lBa+2JhwIy6vutK1Sf5Rc6RIUX8XIfnNRUDWYL7oKY=; b=ae9dgon/f0YnOkV/9UyExknSNjkNEnapdWvoOGg4Wh1ehsWXsk2dIr/EH+EAxm+vsfRHOIgoneW4bP9sDnFYlC+WtJV/52rUnzgmWVILp9wzu0avGLizciCl9XyE0Fdomsskf41eKRwDyqIl5mdudPu0Pvsqy0THr4nOYa/aZBp9Yba/Mjdd0VPMVGC5t0AWz2fZVjqSpH7n1UdeChMC+y9KTLdej3xii3M8ij2F3q2q883sJaPli18Zu7Cb13cHBIEeH2tq/dUYxy0ctKSxl6/CZvjSGt3EkXupzCUggrD5+D8q/GFb64gaBRLNQKWkfe7uOLPqN97ZkTSjTvQ3nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+lBa+2JhwIy6vutK1Sf5Rc6RIUX8XIfnNRUDWYL7oKY=; b=WMpfvFIhzBvQ1gCCKtjAVDbTvx3xhDdd0OfZOKqVElfzeAMsoP8YQPvWu1MK+zZtW4r7k2g6lM+Q4VThwSSXOhmrfAAPvt0ax85Ub2AD36xV2FLkkhgSwze3WaXqZe7tii+8HqwYqJ8JBA7P0HB9AhXtfIzVpmYgf6E5HKZ2xla8ySBqKWFN9YUuWaN4MFUUsdpiOc27/SknC+n6bwaV8DOxLMhiiE6SCfjud45JqgGRV9Ls38+61nOEGPPtFe+RcC9iJND+jvgIOUtgFfSofcyREkWzfKwwyBGzCFhKPc2kt9YKreq3y5RoQLfduIxRDeqomVvTOVQBOJAwuc1Eww== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:53:53 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:53:53 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 13/25] gpu: nova-core: mm: Add MMU v2 page table types Date: Tue, 24 Feb 2026 17:53:11 -0500 Message-Id: <20260224225323.3312204-14-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1PR13CA0074.namprd13.prod.outlook.com (2603:10b6:208:2b8::19) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 600ed1eb-fbfe-413a-de52-08de73f7952d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5jIAoIMdpZudIbWa9O51jToBsB/wVhFoAUGg4uQivwnhlkozI5yhKkQYRFTE?= =?us-ascii?Q?lKq2S+tZ4DGZ5vbcttk4XNwJi7Clxk4mS7YJUPSKle6J1aMsjas4NKBxg2pn?= =?us-ascii?Q?zrT0/ns+AxNIRndxz28ombW0Ul6keAmqjvcNsdWYU0RnYl7OG/NRvCUBG41l?= =?us-ascii?Q?mLFHuH9S0y6FeU8WnlkhvdCvRf2vhsp6SQrNWXmmxtK749cO1yMMkRiFlg+i?= =?us-ascii?Q?spZwA5CN8926og67oBi7neAYALk5SpOhkTJYV4+kTGZKs0hWBuQkLdNfzO0t?= =?us-ascii?Q?oCb3tXhPToa0/UMNToKEyWYlGURkmKr5DeThzDoIrFZnM+rs93z7nSq28zaj?= =?us-ascii?Q?mCvFoFDpaGpRtI/AqSL1fj4YsSbicon4d4J6VwrleTPE6s6ELWEGccs9O0wv?= =?us-ascii?Q?p0u5Vp7FUkiMp4EQJBTm9kFL/1n95O7/L/O2cnIboP+Y7AM9S8vhbQkYw8o2?= =?us-ascii?Q?zbx+R3WBvDOzvsgiOhK5cuHpd5LYpRZyJCibwIK5pfWMqXtZ53ppFRtd6UVE?= =?us-ascii?Q?dCKhHJx9tqcNscP+xJnsWjWuz0fV3v7HUl7wRgyINoFG0dj20y5E+C+iyiRG?= =?us-ascii?Q?gaPpKRJ+b9zFDA+AZ+meuQ6qLTGAUPqapdGmA2J2QdGBK8RHdqzeMGwOre2E?= =?us-ascii?Q?aS8Sa/8ZEALvX2/KDUf43CJeKdpSiUuWqGQ1AHi7O3uixAhsa+ABRrFf9yCd?= =?us-ascii?Q?h0f4DN4nJMipw83dNxL4uprIpyfYcPqgDMHBUuWq36nTDlxwUjzcC/ZGgsXn?= =?us-ascii?Q?DU0A8AaoCPkWMuPR39dmyKe7vVb4azr6ryK/yO1+KMVo2ef1NV8stWAXV9Sl?= =?us-ascii?Q?B1oJGM8Yv3uZsqa9Yy+FDPVgBZ/8tkwdLHeAvR0f9lnBirufWgHYZsB+vDoU?= =?us-ascii?Q?fdij7rG/GNfnsOzeGuw0e7KxZNYcWdyAIJjRM9HgWI7FDUPXOvS38sIlDrqf?= =?us-ascii?Q?R6yyxiHWkDQtAGxopvMRxneSq9WR++bjLc5rvXlz8Ji2os5ed09IqLm+zaXE?= =?us-ascii?Q?yUwgbxWSXqLb0muVOzl9PqARzy86ZuwBZxDihe79tVlcjFAA/PY1h59IqLD4?= =?us-ascii?Q?V46AxlbyFIyyRvdlA/qs+Rs+h6XJpFtuKHe2nBG/LQGuMvIU/X+0d6Ere9dL?= =?us-ascii?Q?I/jZOqothntNAyeJ/6aP8dVAEIoCVmzaI754071zNqHEQ12AfyZL3S6Va0pi?= =?us-ascii?Q?cmCA/0LoAsUC0ixYFfb/KrPOKEXm7bmO8MGU9lRKWdxWt0tdoR/G/p4Z6/Fv?= =?us-ascii?Q?1R3ygYQr7DtV6JIDXfs4/vc3pfWxBEF0mQ072F1oA6bT1oXBtQ2+BlOt/XrB?= =?us-ascii?Q?l68vXI4Je7+IUCP8nXUMeXOubhqCpRiJPdosYUMkyaT3rnKbcavHyrYlWkKs?= =?us-ascii?Q?ny05QrP4o9DsuIqytdaz7ig9/MdvXi3XOCotOywfKRLmjjBKfyYAYXkveOSo?= =?us-ascii?Q?ZPmfTlXu9KPSE2AYoxkdjvEqv+vz047tpFFEMtYzOIJ3ZM0vz9Bm9+LYRm8Y?= =?us-ascii?Q?UUuOF4XBZdzvwRf9MaFDq3Qsu869SGVWL0My7bNA9vdqsbtVZcDraQy5L8er?= =?us-ascii?Q?u3gUJmiGYiY7ZU1vyww=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8hgcB+YOr3soGf4Bc3Wp0f1E4s+DWrDEx8I8UeY9mT7RhcZ6il5WmmoM3blT?= =?us-ascii?Q?1NDv0SscPX9/JZNoDg5IdHd/apfeaMtK9WISPtfHYZ/bl7xtzGb0gbGGzMLz?= =?us-ascii?Q?TuU2+mVLG6St7Jn6nal2kHsir6kViYVmiTTjn9te6lXt01u5dU/tFT5smuyF?= =?us-ascii?Q?g7hN3YVsOpivZ6alRrQKncI/d4gpai498SDQ4zs2Y51J8mj/fzGeZHZoF1fP?= =?us-ascii?Q?nfnDIItTBj/ron4h1b/IWZ8SSXUPpzm+VPDzNbrnaiob0dFoT72BGnBtiTay?= =?us-ascii?Q?3AyTY6bUT5DfTH0cifzTmVyzuojU3s7KunerVxNZUIOgasQYrBNqB9HvwT3d?= =?us-ascii?Q?pgzdO9uKHm1HwsG234Gl+y0doNi79TBuxkMWArDnZ7GUPMMT8MsY3uxwq/dh?= =?us-ascii?Q?l6k/eCuCY9PoOABvzTnEHzP7evejUeD/sHp/uyq/h/7mI2SZoMQDpgL2QuHI?= =?us-ascii?Q?poIVzSnnRJ2j6pAke2R7+cpSkLqlNSIhOpJEW18soykpNRzDPw9jnfxz5AZ0?= =?us-ascii?Q?B8yoYItmOPrvNMhd+rk2fR3Lm3FIX/XVG+yWdUfMOlwo2l9C3Y/XZv5YNsCA?= =?us-ascii?Q?9r5ctl0xK3F+TxA1JcYk3jRULOwN1IffwJzyGN37+uiE73nFBi76Zccn7vR3?= =?us-ascii?Q?UOE0rtLceMRyMlguGRNa1Zw1Xaeg9eoLjrudIediuYbttrMDPOWPA/3JX1Cb?= =?us-ascii?Q?2q8cmGFJ/gxgJxY62LaRIVfzUdwtPXISXBKwNY6yQ1jra2uJ8f93pefUoETO?= =?us-ascii?Q?YSHOsCQQNhCk2FhegBYiAToSnkB1NW0zvb31yV3oi2ArZLzCzTqYtGBsrcEH?= =?us-ascii?Q?Qz3t6YrID3XOuFcdlU6cLQLLFyGE8UF1G43R8/z6q2zKOplEDcWFsA/rCcRd?= =?us-ascii?Q?2f1YE/YdaVXHChL2dwBt7RDpq95mh/+OWqNvQ57NhEuPH4JFoyNKrkbuDBSP?= =?us-ascii?Q?SmBVNRuuRo5NCtwDjDndG5hrJVMq/DQuBwfyH69g/1TMVyKUH/ebp1I6Cgrj?= =?us-ascii?Q?wfFvJg1wXW5Pypl6gAcoDz3SYIYiMrw1OkGKccUjjAO1nppRKFr0Sjo9TaTZ?= =?us-ascii?Q?00wV8Gq/YBnXd58HFTeifCnFEu1Wy4m2YluHC88nUSAmAfrTB9xO5QR1sG9m?= =?us-ascii?Q?BZIymL0Eqn9rGeRVZV6BbyF4hyp7LJYk6mDOZWrNOtGYdFSfmuRkx5YY5TVM?= =?us-ascii?Q?qXtbhtP7OrJnYQLmz9j4kf8qfTvsl9jIjSCuu5brI2Uh3QwBvR5V5HN0QkYK?= =?us-ascii?Q?0gYyBKmPcTQFh/bIezhWDmpdXphJyCkkzk3FS5JcSZ9ZXpzSh1TxxUt4sWO5?= =?us-ascii?Q?vi7HIAbUdPNmBDsdqQd0qMoaKIfjvXlcNgONMtqX4CzxkF7ypC1RsTbIlS2B?= =?us-ascii?Q?wjz6ruUFJoNvBnk+ako0rmb70vySY9NC/w2fTRrzzoccsa7bQJTkjLJ5rbz2?= =?us-ascii?Q?JjLiYtzH4MxINsDa/OPRhukkhaNmRrDbKF2HiDLsxU41/2yOleLHFqVZTR1q?= =?us-ascii?Q?1CD1En8REwF0rBArQz8Hpgpd56Jv855G6oTm/gupTtNPBXPWDNEStRxFrmYW?= =?us-ascii?Q?YGukbKIWvbj6VzunhBqUh2ny4JgahZQ8cZ1Jff0JDKM1OS++BIw26LfE0dFF?= =?us-ascii?Q?OzqoHa7NN9mRoHtiO9acZvb8iFC5RSFZSOu9PeCXoFD5uWMSmqRMbMKG3hs3?= =?us-ascii?Q?el/0KNbv+u9NLl2Ajw4k8j8RfLAHkTOG0TvAFP0rOlJ2O+14gu8EPOEMA+aA?= =?us-ascii?Q?Ll1tTBne5Q=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 600ed1eb-fbfe-413a-de52-08de73f7952d X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:53.1363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l+btezFR6isGp/yeI5+/Km1JQdjuypTv7+mQLBSQdkR5FU1q10/ItVN9HEBEKmbFlUkNNApU/ngfTpGbGu6FUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add page table entry and directory structures for MMU version 2 used by Turing/Ampere/Ada GPUs. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/mm/pagetable.rs | 1 + drivers/gpu/nova-core/mm/pagetable/ver2.rs | 199 +++++++++++++++++++++ 2 files changed, 200 insertions(+) create mode 100644 drivers/gpu/nova-core/mm/pagetable/ver2.rs diff --git a/drivers/gpu/nova-core/mm/pagetable.rs b/drivers/gpu/nova-core/= mm/pagetable.rs index aea06e5da4ff..925063fde45d 100644 --- a/drivers/gpu/nova-core/mm/pagetable.rs +++ b/drivers/gpu/nova-core/mm/pagetable.rs @@ -7,6 +7,7 @@ //! - Memory aperture types for PDEs and PTEs =20 #![expect(dead_code)] +pub(crate) mod ver2; =20 use crate::gpu::Architecture; =20 diff --git a/drivers/gpu/nova-core/mm/pagetable/ver2.rs b/drivers/gpu/nova-= core/mm/pagetable/ver2.rs new file mode 100644 index 000000000000..d30a9a8bddbd --- /dev/null +++ b/drivers/gpu/nova-core/mm/pagetable/ver2.rs @@ -0,0 +1,199 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! MMU v2 page table types for Turing and Ampere GPUs. +//! +//! This module defines MMU version 2 specific types (Turing, Ampere and A= da GPUs). +//! +//! Bit field layouts derived from the NVIDIA OpenRM documentation: +//! `open-gpu-kernel-modules/src/common/inc/swref/published/turing/tu102/d= ev_mmu.h` + +#![expect(dead_code)] + +use super::{ + AperturePde, + AperturePte, + PageTableLevel, // +}; +use crate::mm::{ + Pfn, + VramAddress, // +}; + +/// PDE levels for MMU v2 (5-level hierarchy: PDB -> L1 -> L2 -> L3 -> L4). +pub(crate) const PDE_LEVELS: &[PageTableLevel] =3D &[ + PageTableLevel::Pdb, + PageTableLevel::L1, + PageTableLevel::L2, + PageTableLevel::L3, +]; + +/// PTE level for MMU v2. +pub(crate) const PTE_LEVEL: PageTableLevel =3D PageTableLevel::L4; + +/// Dual PDE level for MMU v2 (128-bit entries). +pub(crate) const DUAL_PDE_LEVEL: PageTableLevel =3D PageTableLevel::L3; + +// Page Table Entry (PTE) for MMU v2 - 64-bit entry at level 4. +bitfield! { + pub(crate) struct Pte(u64), "Page Table Entry for MMU v2" { + 0:0 valid as bool, "Entry is valid"; + 2:1 aperture as u8 =3D> AperturePte, "Memory apertu= re type"; + 3:3 volatile as bool, "Volatile (bypass L2 cache)"; + 4:4 encrypted as bool, "Encryption enabled (Confiden= tial Computing)"; + 5:5 privilege as bool, "Privileged access only"; + 6:6 read_only as bool, "Write protection"; + 7:7 atomic_disable as bool, "Atomic operations disabled"; + 53:8 frame_number_sys as u64 =3D> Pfn, "Frame number for sys= tem memory"; + 32:8 frame_number_vid as u64 =3D> Pfn, "Frame number for vid= eo memory"; + 35:33 peer_id as u8, "Peer GPU ID for peer memory (0= -7)"; + 53:36 comptagline as u32, "Compression tag line bits"; + 63:56 kind as u8, "Surface kind/format"; + } +} + +impl Pte { + /// Create a PTE from a `u64` value. + pub(crate) fn new(val: u64) -> Self { + Self(val) + } + + /// Create a valid PTE for video memory. + pub(crate) fn new_vram(pfn: Pfn, writable: bool) -> Self { + Self::default() + .set_valid(true) + .set_aperture(AperturePte::VideoMemory) + .set_frame_number_vid(pfn) + .set_read_only(!writable) + } + + /// Create an invalid PTE. + pub(crate) fn invalid() -> Self { + Self::default() + } + + /// Get the frame number based on aperture type. + pub(crate) fn frame_number(&self) -> Pfn { + match self.aperture() { + AperturePte::VideoMemory =3D> self.frame_number_vid(), + _ =3D> self.frame_number_sys(), + } + } + + /// Get the raw `u64` value. + pub(crate) fn raw_u64(&self) -> u64 { + self.0 + } +} + +// Page Directory Entry (PDE) for MMU v2 - 64-bit entry at levels 0-2. +bitfield! { + pub(crate) struct Pde(u64), "Page Directory Entry for MMU v2" { + 0:0 valid_inverted as bool, "Valid bit (inverted logic)"; + 2:1 aperture as u8 =3D> AperturePde, "Memory apertu= re type"; + 3:3 volatile as bool, "Volatile (bypass L2 cache)"; + 5:5 no_ats as bool, "Disable Address Translation = Services"; + 53:8 table_frame_sys as u64 =3D> Pfn, "Table frame number f= or system memory"; + 32:8 table_frame_vid as u64 =3D> Pfn, "Table frame number f= or video memory"; + 35:33 peer_id as u8, "Peer GPU ID (0-7)"; + } +} + +impl Pde { + /// Create a PDE from a `u64` value. + pub(crate) fn new(val: u64) -> Self { + Self(val) + } + + /// Create a valid PDE pointing to a page table in video memory. + pub(crate) fn new_vram(table_pfn: Pfn) -> Self { + Self::default() + .set_valid_inverted(false) // 0 =3D valid + .set_aperture(AperturePde::VideoMemory) + .set_table_frame_vid(table_pfn) + } + + /// Create an invalid PDE. + pub(crate) fn invalid() -> Self { + Self::default() + .set_valid_inverted(true) + .set_aperture(AperturePde::Invalid) + } + + /// Check if this PDE is valid. + pub(crate) fn is_valid(&self) -> bool { + !self.valid_inverted() && self.aperture() !=3D AperturePde::Invalid + } + + /// Get the table frame number based on aperture type. + pub(crate) fn table_frame(&self) -> Pfn { + match self.aperture() { + AperturePde::VideoMemory =3D> self.table_frame_vid(), + _ =3D> self.table_frame_sys(), + } + } + + /// Get the VRAM address of the page table. + pub(crate) fn table_vram_address(&self) -> VramAddress { + debug_assert!( + self.aperture() =3D=3D AperturePde::VideoMemory, + "table_vram_address called on non-VRAM PDE (aperture: {:?})", + self.aperture() + ); + VramAddress::from(self.table_frame_vid()) + } + + /// Get the raw `u64` value of the PDE. + pub(crate) fn raw_u64(&self) -> u64 { + self.0 + } +} + +/// Dual PDE at Level 3 - 128-bit entry of Large/Small Page Table pointers. +/// +/// The dual PDE supports both large (64KB) and small (4KB) page tables. +#[repr(C)] +#[derive(Debug, Clone, Copy, Default)] +pub(crate) struct DualPde { + /// Large/Big Page Table pointer (lower 64 bits). + pub big: Pde, + /// Small Page Table pointer (upper 64 bits). + pub small: Pde, +} + +impl DualPde { + /// Create a dual PDE from raw 128-bit value (two `u64`s). + pub(crate) fn new(big: u64, small: u64) -> Self { + Self { + big: Pde::new(big), + small: Pde::new(small), + } + } + + /// Create a dual PDE with only the small page table pointer set. + /// + /// Note: The big (LPT) portion is set to 0, not `Pde::invalid()`. + /// According to hardware documentation, clearing bit 0 of the 128-bit + /// entry makes the PDE behave as a "normal" PDE. Using `Pde::invalid(= )` + /// would set bit 0 (valid_inverted), which breaks page table walking. + pub(crate) fn new_small(table_pfn: Pfn) -> Self { + Self { + big: Pde::new(0), + small: Pde::new_vram(table_pfn), + } + } + + /// Check if the small page table pointer is valid. + pub(crate) fn has_small(&self) -> bool { + self.small.is_valid() + } + + /// Check if the big page table pointer is valid. + pub(crate) fn has_big(&self) -> bool { + self.big.is_valid() + } + + /// Get the small page table PFN. + pub(crate) fn small_pfn(&self) -> Pfn { + self.small.table_frame() + } +} --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010042.outbound.protection.outlook.com [52.101.193.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 072B0362130; Tue, 24 Feb 2026 22:54:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973648; cv=fail; b=Xbx1WfNyRf+qd2sEHKynhx2LoMGyXFCn26bleLuFJGMqwGrw9QuqqIeCwGrLL9P5ZFCma79xB8CCM3nMzUbUk+oMbd8Nux3P66/zLHsK3WdxKz9uaf98UdGl6OmMZpS1zUN0kNz8Rm10zf0i/uydypfqvBVo/OB7ePgeUywTsGg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973648; c=relaxed/simple; bh=dA3OVhft9IcLCWwcrS6LuXFMl2YAviRFe6pxsUvnHhE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=N/xmO15ajd0LCDHtZIpkUIDTRs9f0B6rUP0JjTJT2gopX851Sm/DOb6HYDNk0NmRxsmDa5x7hyTKiVqosnCR/ZP/MdhUmM52zclbDdSDghyjupBhqKJZV1kD3rRf198OOKBICz3SJpKlqg/DFCQ35Ddm9xIJqdi7zF+t+v4G6rM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=FqrAzTA7; arc=fail smtp.client-ip=52.101.193.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="FqrAzTA7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P1iD2VAqwHUteTZFzvvGp7r3W7PvyLuH2m243dND3VrDhanIF9lAPTM8SWvTYw2kZKfbcZGpuxSOuGZUPv0xQyg8NmZhHHCAxrYbrfeJ5SUPRJmTeFCcYJKkc+/wzYDWpUwGJY7i17kHaJjqAO2Onf3y9fIQ3aMAG2hINvZr2Bt14qGC3e7xGRgW6TktiD/RzhVuOFnS4D+VmH4hBHBxPdAyTDhcqmMk0LfIbhweFjoLZrr3z3dYCex4ABEVjBUHiENsQZyhEhzeNqmMNdxIN+TldsS+nOVxdWBwUlwRZ9s3IJMWaj+5cE9Eepmv2H2bnTCf3tadVwzxTuOA+7UIIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4S57JpeJs65/3H8jlcBj2YaerLEf2e0KiBqH6rwJzhs=; b=Z4EQpfjYCnLwIQOz+L9hMtKsW2avdsHUqE2CUhM3kV1W+joMr8fBRAijgeYK2O4GQgh6tnXy+PIOM5HX/IIEn/bRGKDW6m1Utcq9wxirXjTiqmsGhK6WLtLqFPW4vU9m9CNmb6RHNk5KOMCpu3oqgE5U7Y/SWBn42gAxBk1bjTBrbVRRHqPFJdfmLKKd086UHvq5FzRvSqs2VTWy71xV9gPebnFCnjhE2dhU5NbeH0AQByKt2vfOBb7ebTjBxpRjc8rkrUWQ0TGAK9lQLdNLOPfd0VMqPz8dpMzLMrbWxTpJ8bhKyQR8kGkukM4D4dtnpoOU2Yxuojr82LT+0Uigbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4S57JpeJs65/3H8jlcBj2YaerLEf2e0KiBqH6rwJzhs=; b=FqrAzTA70PnMshX3nd+1XWSsk+SAY88wPFjpnVsHG5c1J1/dQ3IR8VuEJw2ezGhWGca7BGK2zAGCWNEwx6Ic5Vg/OzXZeBg3En6SMMKMUd8I3mkTfLxzH7VugFiHb6h0Q5X/ifmE7mBy7YHLDsmindP8LmyQiE7ktVwLCHZfvB86Wkxd9jvF+pk7BE178ChwkH5gL1nDoSOkTWHHM+wMjAuPsWFVDsUZBWK0qh4gJbQtv5ygOkHL5AAZAqiyg0OscKBD8BjTuE2qwYXnR5rnOUShk/3apbAN8T2r8Qnr5EcfaT6m2lPkUCyaG6/dcgC7hFoy6l5ubyxZMAN2x74PYw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:53:55 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:53:55 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 14/25] gpu: nova-core: mm: Add MMU v3 page table types Date: Tue, 24 Feb 2026 17:53:12 -0500 Message-Id: <20260224225323.3312204-15-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL0PR01CA0001.prod.exchangelabs.com (2603:10b6:208:71::14) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 962f0cd9-a1de-4b32-38be-08de73f795fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?uIRRznhFVUlnDjlsD3dwMSr5QibDKITAMOa7sYukzwq5ZAR+n0JTeS0YocXw?= =?us-ascii?Q?oFyrEYy+x2cYTC46hCQu4xsK3prPbPGVUbWLANCg7+uWKcsEs4lrd/DUkBHV?= =?us-ascii?Q?bujzWv95rP78TSd4luxrgwRY3hHB8tq2NJVFFG7SXwxSH2R8RgWLRA3bkLve?= =?us-ascii?Q?HH2Gsy8I+s5KianxZ34F0kwD2CgpZlhmdE3viWCqqMTOG5CA/7C4HViXlK0k?= =?us-ascii?Q?z4WOQGTAFr/NvCG2Kihvsq1Ui/F/Ks5WSqA8FFDQebc0TMcdwyEOee6ldPa8?= =?us-ascii?Q?JIDHGBIcupDeVfNjBmY8MisZnqE4F8xXv3gyiPnZ4FY4Jwtqx5hyOg9qTXwv?= =?us-ascii?Q?9bZLutDcm7HL5G39022LW09oqmJi5+E5FxvjL0+KbND4N178onjNHz8ePcbJ?= =?us-ascii?Q?UBNpAa6fQCdN4elTt94Zp0lbIub2qQ8IzkRL6phhJy3CKgsm5tk3Bli27ose?= =?us-ascii?Q?2tdh6RRGQtRb0J4gMGb1GyieyJ2UguItCeE/K1zLDixvl/Pkp04rN2377S3n?= =?us-ascii?Q?KaC1x4I7pjuHVxnHUDbJtOWHkEvdPdIJ7vZbq2p/SXdYUvO7TUKgzGfHnHbK?= =?us-ascii?Q?9X52Dg2Fp+lkZCCso1TrrnUt2HrAw2m4Biqnntx19xYBzx9WRQj8wepcbHSy?= =?us-ascii?Q?WQym+TGcJvYPK4hW5jA/+jbFMPjCxkJ6sQoLUzb7TLeNndR+VXcvMt0+kjvj?= =?us-ascii?Q?G2aq69vc6gvthiU0a5yzeagMMJtiVNNmHhPq8DW19lLCGdz8yaz+kd0Kv5/d?= =?us-ascii?Q?Y4DoB09trhKfuzVHRiiix+pH3pYqeaBDm+3SBmmHRv5Ls2N9ZTAj7IacugNX?= =?us-ascii?Q?af9BQQRcuazkwdnV9lG/Eo9c60cFPybYvW6fQUDm4WA0X229h3ea30uVoDsf?= =?us-ascii?Q?oWMB8bMkofB+gQ4n0hRMQfkS7dyWp2dT5uYuDLwLuPahNV97KUnF1PeZB9n5?= =?us-ascii?Q?ZMspqw7tzBfgqqllkFM6FfRCoo6A3NX+cmBEnxAUPkCI2OL0zBECfDzYaLXO?= =?us-ascii?Q?t0FpfuP7Nb4g5wVuUodut5ccNQTelgAZiHWGqcIAf5T8rUf383VvGID05ZtN?= =?us-ascii?Q?twcQt8PrAx5/iIVbnGrak5ihF7pCLm+YPQG6BCIk2bMbQFqO+KkMn6sw90jb?= =?us-ascii?Q?X8PzDbfR/lsUddfm8zXYEqW6jQl/5W9mXzvQYR0Pxn91UWdRMTBEH3cKlOVV?= =?us-ascii?Q?D5dJMPgE352F6rIJLvIsQxl/wgcGjjNTlg5lZwjDji/ULuar/yPZsjnz4zyt?= =?us-ascii?Q?JczESyyzPRIz8PCSQWRe/Fsu4kSi7PqKqxrZRTziDeEA5hPSQG14xnJ1IzMg?= =?us-ascii?Q?wn969PI6UGRsq4jzaw4bRPm1AydMlSwS/AMFWC8sEv//2qVlX4bbRo8EH/eE?= =?us-ascii?Q?w8Uvue77SJfaWGzlMDbiHiHbpc/Uxtxwib/J/EGrQ9oRjt/kTszvOVUtX+fS?= =?us-ascii?Q?jWzXYj81mWu4aInw0mNdcfTytu/jTm7Q11TmZQ/xxjq+1QGG+xg2FI8pkOQG?= =?us-ascii?Q?Rc/v+9cO3JRo+OdEyhNJFZs4Lh0Sb7duRD4Qs4WfjK0ZTQJMQpwJnsl6YRBb?= =?us-ascii?Q?muDuY/B9/A167NRXyoM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dhFC2qNd6+n8PDrDMdbTK1+HWOgHGCE8drpCPfrCz02F7E0vNZ604xGOKiwO?= =?us-ascii?Q?c8A6JvUP6g50piV9EtWpqW5X8UbViAUJbQhP9rNZGd+nE93pz0+V8eS5e2i8?= =?us-ascii?Q?fAJOneBLZ1MzcooO9YnCT4eW22xIRjtlQOJcBnVdnKg8xvuCNQLBYx5uQXoR?= =?us-ascii?Q?oFOFZWAVpItgcmeoOC/h8buRsaPXQCWcbS85+WO3LB2REHiTAa+LwdjDuiYO?= =?us-ascii?Q?qJYajoSKL1F2oxASvUE+XEfrN9orkfdFENg6hYQ0r6GGWZlDrgybtQZ9rtMQ?= =?us-ascii?Q?qQY4fuu5IStaayCLGgTyWKkzM7aqsHVRPILycfN5CneDrbqoooyKKWeg1LN1?= =?us-ascii?Q?VA6IrWmVkMu61Pm4PcTFVjDkLwW+FpiK5CAZL6IBO8onV/L73Oj9ARI2pM2e?= =?us-ascii?Q?hSMRiEeRoeXY6TyUYtzBOEKhkL892fZPqfqZRUFU6aowvEYgksI1YauHYU8Y?= =?us-ascii?Q?lZZbK7VDpSaNsRN4HCtcNsMUHo2Q7UrdKHFWbqAvKSO/C5CqjVrftEqfz4vi?= =?us-ascii?Q?xsswHgSjFtmMlzND0PHgpXhZm5e3lPOaP+JXX2FQMxy/PX4NKhuAYOYfiBzV?= =?us-ascii?Q?j1ko0w/mM1Aa5A5tOZMHulp9WOfTWlQpJHobB3lKY7gay+UX9E7dJJHB74Aw?= =?us-ascii?Q?vc651m7ilwSOqknXTD+z4k+coOiid6ZUNOTVh/5MlZcTc7WrTyKUKoL1YWQk?= =?us-ascii?Q?K8H0swD5N1x48nccmUilOO4ECXFMJtZvt8qlFBc8VyEZotrTf88NvsegFs/B?= =?us-ascii?Q?T1kpHbtT+0V6zLONPDY1IfnDofIA1yt7V82+YMdCbd7VBX994FTjHpFz2/lc?= =?us-ascii?Q?ESsybop49jLOwgQkyOYYFeA/TDFSM1M8EWPQIF3Q3sMvzn8poQDWOe9YdPZf?= =?us-ascii?Q?IfvniUN9/+h3RMHkfWxg6/PAZ82RJlR++/rOTvjGlrGdA7sFrVYwbUmfPfbw?= =?us-ascii?Q?CgAYmAL8OWF/dn3nsctY6nYBfxMYVonsDzgF7lghSCIwIcEvrT+fglarwDUl?= =?us-ascii?Q?z+9CXRbE4ZI0RA4e5WG9RyCiSgAig5aURMU3YPMbJQZo5hGwA9MICY4cddqd?= =?us-ascii?Q?V2oIvzMkdVFsthfyr/4XJd696S8eoC72gq1aDL2xmXl5rxt8quO42hFAYl3M?= =?us-ascii?Q?cZTXIPcYmMkSx8U4J5/Yz+q/dZ32QSLw76iiiTr8fRc+ss2vexyWui9mD4Cf?= =?us-ascii?Q?JmQosMP+QfVCby5jokE8YWYWQlzWfp+xd+HlDi3xhCgGrOk4m1arbLejSBVn?= =?us-ascii?Q?q1P2ueRgFBj50MuTCyxLWjJ0EXnXp+huJM9kuL0Kv3PKe4ZQcr/+0hpqxW4/?= =?us-ascii?Q?R4ICE+ckkssCSeD6uvq2vvJGTXxKh6RizOCoIbFntOCJbMCGGswsGo9+jToG?= =?us-ascii?Q?ReJFfD3uHAYAt+kThxDRR0Ql12laUZ1Fife3YWE1Bpj3KD2vt253CeobmXBN?= =?us-ascii?Q?pjcGI16geEW6hqJRsE+ZTDYM3XVtV8McOhqzbZe4XmTKnV18nXnMbDmCT8Qj?= =?us-ascii?Q?dNAprJwIoUhSErbc21vjtn2Fq0o4VCToMSTTT67emaWi5gVfaF6WiDvKuLcY?= =?us-ascii?Q?WRFj0DIv2O69tC+z0nyPHat7OF3rUa5WoTOzg0QB1LOLULRTg3mQYlz79buu?= =?us-ascii?Q?/4z8GfPBNQoRYz46dgc3j2rSb7mMzPMOdftMC2xeFMoPKrVb/tXD/kzHYwp/?= =?us-ascii?Q?zwK7JdzkpP6bR7X6gnjkRsZ00QSHtu5t4JGsTxeBYiTqgSTg06zSK6NoGgA7?= =?us-ascii?Q?OxguQRImWA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 962f0cd9-a1de-4b32-38be-08de73f795fc X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:54.4851 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wgbROh65U/FJpVb2vMOj6mRgema/5ZfQSflhZTWStkXAt54nBPicihYIfRZw+zFQDa87DC2TJWM9YhpXDA0NbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add page table entry and directory structures for MMU version 3 used by Hopper and later GPUs. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/mm/pagetable.rs | 1 + drivers/gpu/nova-core/mm/pagetable/ver3.rs | 302 +++++++++++++++++++++ 2 files changed, 303 insertions(+) create mode 100644 drivers/gpu/nova-core/mm/pagetable/ver3.rs diff --git a/drivers/gpu/nova-core/mm/pagetable.rs b/drivers/gpu/nova-core/= mm/pagetable.rs index 925063fde45d..5263a8f56529 100644 --- a/drivers/gpu/nova-core/mm/pagetable.rs +++ b/drivers/gpu/nova-core/mm/pagetable.rs @@ -8,6 +8,7 @@ =20 #![expect(dead_code)] pub(crate) mod ver2; +pub(crate) mod ver3; =20 use crate::gpu::Architecture; =20 diff --git a/drivers/gpu/nova-core/mm/pagetable/ver3.rs b/drivers/gpu/nova-= core/mm/pagetable/ver3.rs new file mode 100644 index 000000000000..e6cab2fe7d33 --- /dev/null +++ b/drivers/gpu/nova-core/mm/pagetable/ver3.rs @@ -0,0 +1,302 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! MMU v3 page table types for Hopper and later GPUs. +//! +//! This module defines MMU version 3 specific types (Hopper and later GPU= s). +//! +//! Key differences from MMU v2: +//! - Unified 40-bit address field for all apertures (v2 had separate sys/= vid fields). +//! - PCF (Page Classification Field) replaces separate privilege/RO/atomi= c/cache bits. +//! - KIND field is 4 bits (not 8). +//! - IS_PTE bit in PDE to support large pages directly. +//! - No COMPTAGLINE field (compression handled differently in v3). +//! - No separate ENCRYPTED bit. +//! +//! Bit field layouts derived from the NVIDIA OpenRM documentation: +//! `open-gpu-kernel-modules/src/common/inc/swref/published/hopper/gh100/d= ev_mmu.h` + +#![expect(dead_code)] + +use super::{ + AperturePde, + AperturePte, + PageTableLevel, // +}; +use crate::mm::{ + Pfn, + VramAddress, // +}; +use kernel::prelude::*; + +/// PDE levels for MMU v3 (6-level hierarchy). +pub(crate) const PDE_LEVELS: &[PageTableLevel] =3D &[ + PageTableLevel::Pdb, + PageTableLevel::L1, + PageTableLevel::L2, + PageTableLevel::L3, + PageTableLevel::L4, +]; + +/// PTE level for MMU v3. +pub(crate) const PTE_LEVEL: PageTableLevel =3D PageTableLevel::L5; + +/// Dual PDE level for MMU v3 (128-bit entries). +pub(crate) const DUAL_PDE_LEVEL: PageTableLevel =3D PageTableLevel::L4; + +// Page Classification Field (PCF) - 5 bits for PTEs in MMU v3. +bitfield! { + pub(crate) struct PtePcf(u8), "Page Classification Field for PTEs" { + 0:0 uncached as bool, "Bypass L2 cache (0=3Dcached, 1=3Dbyp= ass)"; + 1:1 acd as bool, "Access counting disabled (0=3Denable= d, 1=3Ddisabled)"; + 2:2 read_only as bool, "Read-only access (0=3Dread-write, 1= =3Dread-only)"; + 3:3 no_atomic as bool, "Atomics disabled (0=3Denabled, 1=3Dd= isabled)"; + 4:4 privileged as bool, "Privileged access only (0=3Dregular,= 1=3Dprivileged)"; + } +} + +impl PtePcf { + /// Create PCF for read-write mapping (cached, no atomics, regular mod= e). + pub(crate) fn rw() -> Self { + Self::default().set_no_atomic(true) + } + + /// Create PCF for read-only mapping (cached, no atomics, regular mode= ). + pub(crate) fn ro() -> Self { + Self::default().set_read_only(true).set_no_atomic(true) + } + + /// Get the raw `u8` value. + pub(crate) fn raw_u8(&self) -> u8 { + self.0 + } +} + +impl From for PtePcf { + fn from(val: u8) -> Self { + Self(val) + } +} + +// Page Classification Field (PCF) - 3 bits for PDEs in MMU v3. +// Controls Address Translation Services (ATS) and caching. +bitfield! { + pub(crate) struct PdePcf(u8), "Page Classification Field for PDEs" { + 0:0 uncached as bool, "Bypass L2 cache (0=3Dcached, 1=3Dbyp= ass)"; + 1:1 no_ats as bool, "Address Translation Services disable= d (0=3Denabled, 1=3Ddisabled)"; + } +} + +impl PdePcf { + /// Create PCF for cached mapping with ATS enabled (default). + pub(crate) fn cached() -> Self { + Self::default() + } + + /// Get the raw `u8` value. + pub(crate) fn raw_u8(&self) -> u8 { + self.0 + } +} + +impl From for PdePcf { + fn from(val: u8) -> Self { + Self(val) + } +} + +// Page Table Entry (PTE) for MMU v3. +bitfield! { + pub(crate) struct Pte(u64), "Page Table Entry for MMU v3" { + 0:0 valid as bool, "Entry is valid"; + 2:1 aperture as u8 =3D> AperturePte, "Memory aperture t= ype"; + 7:3 pcf as u8 =3D> PtePcf, "Page Classification Fi= eld"; + 11:8 kind as u8, "Surface kind (4 bits, 0x0=3Dpitch,= 0xF=3Dinvalid)"; + 51:12 frame_number as u64 =3D> Pfn, "Physical frame number (f= or all apertures)"; + 63:61 peer_id as u8, "Peer GPU ID for peer memory (0-7)"; + } +} + +impl Pte { + /// Create a PTE from a `u64` value. + pub(crate) fn new(val: u64) -> Self { + Self(val) + } + + /// Create a valid PTE for video memory. + pub(crate) fn new_vram(frame: Pfn, writable: bool) -> Self { + let pcf =3D if writable { PtePcf::rw() } else { PtePcf::ro() }; + Self::default() + .set_valid(true) + .set_aperture(AperturePte::VideoMemory) + .set_pcf(pcf) + .set_frame_number(frame) + } + + /// Create an invalid PTE. + pub(crate) fn invalid() -> Self { + Self::default() + } + + /// Get the raw `u64` value. + pub(crate) fn raw_u64(&self) -> u64 { + self.0 + } +} + +// Page Directory Entry (PDE) for MMU v3. +// +// Note: v3 uses a unified 40-bit address field (v2 had separate sys/vid a= ddress fields). +bitfield! { + pub(crate) struct Pde(u64), "Page Directory Entry for MMU v3 (Hopper+)= " { + 0:0 is_pte as bool, "Entry is a PTE (0=3DPDE, 1=3Dlarge p= age PTE)"; + 2:1 aperture as u8 =3D> AperturePde, "Memory aperture (0=3D= invalid, 1=3Dvidmem, 2=3Dcoherent, 3=3Dnon-coherent)"; + 5:3 pcf as u8 =3D> PdePcf, "Page Classification Field = (3 bits for PDE)"; + 51:12 table_frame as u64 =3D> Pfn, "Table frame number (40-bit u= nified address)"; + } +} + +impl Pde { + /// Create a PDE from a `u64` value. + pub(crate) fn new(val: u64) -> Self { + Self(val) + } + + /// Create a valid PDE pointing to a page table in video memory. + pub(crate) fn new_vram(table_pfn: Pfn) -> Self { + Self::default() + .set_is_pte(false) + .set_aperture(AperturePde::VideoMemory) + .set_table_frame(table_pfn) + } + + /// Create an invalid PDE. + pub(crate) fn invalid() -> Self { + Self::default().set_aperture(AperturePde::Invalid) + } + + /// Check if this PDE is valid. + pub(crate) fn is_valid(&self) -> bool { + self.aperture() !=3D AperturePde::Invalid + } + + /// Get the VRAM address of the page table. + pub(crate) fn table_vram_address(&self) -> VramAddress { + debug_assert!( + self.aperture() =3D=3D AperturePde::VideoMemory, + "table_vram_address called on non-VRAM PDE (aperture: {:?})", + self.aperture() + ); + VramAddress::from(self.table_frame()) + } + + /// Get the raw `u64` value. + pub(crate) fn raw_u64(&self) -> u64 { + self.0 + } +} + +// Big Page Table pointer for Dual PDE - 64-bit lower word of the 128-bit = Dual PDE. +bitfield! { + pub(crate) struct DualPdeBig(u64), "Big Page Table pointer in Dual PDE= (MMU v3)" { + 0:0 is_pte as bool, "Entry is a PTE (for large pages)"; + 2:1 aperture as u8 =3D> AperturePde, "Memory aperture type"; + 5:3 pcf as u8 =3D> PdePcf, "Page Classification Field"; + 51:8 table_frame as u64, "Table frame (table address 256-byte a= ligned)"; + } +} + +impl DualPdeBig { + /// Create a big page table pointer from a `u64` value. + pub(crate) fn new(val: u64) -> Self { + Self(val) + } + + /// Create an invalid big page table pointer. + pub(crate) fn invalid() -> Self { + Self::default().set_aperture(AperturePde::Invalid) + } + + /// Create a valid big PDE pointing to a page table in video memory. + pub(crate) fn new_vram(table_addr: VramAddress) -> Result { + // Big page table addresses must be 256-byte aligned (shift 8). + if table_addr.raw_u64() & 0xFF !=3D 0 { + return Err(EINVAL); + } + + let table_frame =3D table_addr.raw_u64() >> 8; + Ok(Self::default() + .set_is_pte(false) + .set_aperture(AperturePde::VideoMemory) + .set_table_frame(table_frame)) + } + + /// Check if this big PDE is valid. + pub(crate) fn is_valid(&self) -> bool { + self.aperture() !=3D AperturePde::Invalid + } + + /// Get the VRAM address of the big page table. + pub(crate) fn table_vram_address(&self) -> VramAddress { + debug_assert!( + self.aperture() =3D=3D AperturePde::VideoMemory, + "table_vram_address called on non-VRAM DualPdeBig (aperture: {= :?})", + self.aperture() + ); + VramAddress::new(self.table_frame() << 8) + } + + /// Get the raw `u64` value. + pub(crate) fn raw_u64(&self) -> u64 { + self.0 + } +} + +/// Dual PDE at Level 4 for MMU v3 - 128-bit entry. +/// +/// Contains both big (64KB) and small (4KB) page table pointers: +/// - Lower 64 bits: Big Page Table pointer. +/// - Upper 64 bits: Small Page Table pointer. +/// +/// ## Note +/// +/// The big and small page table pointers have different address layouts: +/// - Big address =3D field value << 8 (256-byte alignment). +/// - Small address =3D field value << 12 (4KB alignment). +/// +/// This is why `DualPdeBig` is a separate type from `Pde`. +#[repr(C)] +#[derive(Debug, Clone, Copy, Default)] +pub(crate) struct DualPde { + /// Big Page Table pointer. + pub big: DualPdeBig, + /// Small Page Table pointer. + pub small: Pde, +} + +impl DualPde { + /// Create a dual PDE from raw 128-bit value (two `u64`s). + pub(crate) fn new(big: u64, small: u64) -> Self { + Self { + big: DualPdeBig::new(big), + small: Pde::new(small), + } + } + + /// Create a dual PDE with only the small page table pointer set. + pub(crate) fn new_small(table_pfn: Pfn) -> Self { + Self { + big: DualPdeBig::invalid(), + small: Pde::new_vram(table_pfn), + } + } + + /// Check if the small page table pointer is valid. + pub(crate) fn has_small(&self) -> bool { + self.small.is_valid() + } + + /// Check if the big page table pointer is valid. + pub(crate) fn has_big(&self) -> bool { + self.big.is_valid() + } +} --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010042.outbound.protection.outlook.com [52.101.193.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9636363C7D; Tue, 24 Feb 2026 22:54:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973655; cv=fail; b=btxAGFCnwZ9FV+hQAVRNsD4opzVAi9vlCLJfBNMewtHSYLvd62aCw6vREpOmW8SV3ztxjlzd9fGjaYMTRIDCisb2rKVgGL605pfdXGY2X2FO9Y0RjtiqIHYFMvP/X2ofpHlp7BHkHKJp9aPFDvbAksAFYRMr3h5+h7u8aqetAJk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973655; c=relaxed/simple; bh=Izptq4Gr62wBTncuhf8Qg+ZRC7Urylgj/c5VkKv8rgA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=JYqkDk2s/RSU8xU1Bx60F0dYKI1CjcUiP1lgYF/aav2X5dG9ZwcQa0A/84JTVAyOw4FjWOy7xPiglCbVaErheU9KfX/SuNEuiCpWuZi85BL+YA86AxnqqFvG4AK5bGMdCTuBfckXGtwAY56fuDDB2CTyC4O33gBQ4bzeqyd8K8w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=NhyiBT3a; arc=fail smtp.client-ip=52.101.193.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="NhyiBT3a" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ls22ViGBvsK653UdTcOiz2NXyOqao8h93IDLzeACNP3al7yN14xl5ogmGq7HrqfhJddD3o7X6FMwqN2Caq1Pnn7YFRRKV1/wnr6SboCgWPkQNz5+BGcWLO/hBJGIyCFcjBdcIyuHZe/m+Q6ZVkBKTwovbnW7LhD/+GNYAAQ+I1ZhePZ/3ylZy9q2OrIHnBKYVVCJ/TJaGiTwAYdIq14+Z9q5MXJ676IvigOwr/fSN6fsbCFC2rOhTzqCbZSWa4zZPRTUX3uEE/D/ghe3cm6xPF8+pJIvEfVON8kEBDgHCaqt2UYdcaYHTyR6DaxrCa4+mkfETN58oTyyalT8qmP5uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HFw+WNHc8Av9B2RbCFxOS840z/XHizG8MRocBJ7NORo=; b=PmEfWy1dGImQKFutVq6RFBqe/SQORlqD34Ysu4CwU/QjkqTfyShhz3Fb2KV1V0PntjquW8esz9+J3X1nYIluGejyXejH62biZ0u2J496f+N1pHN5OXPaMU7nBSY3gUp9Eieh3h0Yv/XCSoS48Bd1MeQCox6qbH0jRqyfP2siy6986iFrPErqrGmcSH41K1k/xlyms4q7i6onKD8vFXGe2XVunmw3xpHSJ6PEuimRV3v8CNtNIfcy485ROJP4YLpXXZh28TNnH6QL8zzBdE9NrwhS/BoM6jfKV9jp4IaumMl2W3FpwTv9R5Z9RSbY0w40u0AZZO5kgIsRLu6sWqIUWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HFw+WNHc8Av9B2RbCFxOS840z/XHizG8MRocBJ7NORo=; b=NhyiBT3anAU4S9Wm5HaRpLli9d15c6rRM+7U3Yv4pQg+F3/wrHHytuN9MLels1W7UcM1w4yRJW/Bpgk6s5a1nw9kabH9kjIKofmPJ6cSam1gOso46HnjmYqMQr10u8bRv8aKqrR3pU05/gZteGSfVyIQKaIiGz+IV1xpNCDS/Q/JSM6nBd2mT4ZuZcxG6wQ/5TAmYE+t5ZRf6JdbJeYkB8yiGMofMmwZ8wSWURfguvfiaDsEoj8N+tYBzNCzHrTBx8cjXf4m+DB8P3U+b8hNxZOOEpQB/Dgdh+s9kkqGRb4AYH9JcLaoz+Rf4RSsC9xH2U+Kz7FxGMlzuug4vKtV1A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:53:56 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:53:56 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 15/25] gpu: nova-core: mm: Add unified page table entry wrapper enums Date: Tue, 24 Feb 2026 17:53:13 -0500 Message-Id: <20260224225323.3312204-16-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR16CA0042.namprd16.prod.outlook.com (2603:10b6:208:234::11) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 263199bd-54a3-4dee-f0f4-08de73f796e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?yRkMkfcTK+C+XXSnqwAeS3gGIb/5X/UfswL9XHAmJ5psN4yEgoEDOAKcQQTp?= =?us-ascii?Q?HvMBTDOcCjPR6Xlr5jOQKhPlpc2IQMBK2maHbdUKNMrRZnFcHV58FadC3pF4?= =?us-ascii?Q?xoljgt6ebWiTurhgYcN/NGZAkO81hqP5S17TZkgWB1orZxnCZ4M1QTGuy/8o?= =?us-ascii?Q?DyR7XxaXF+udJgr8AuzLbpyFCzRUh4DPgmcNMrUo9xoHdY79dab9A2dCj/Dz?= =?us-ascii?Q?h01eioh08oYFwJadzLBzUmFfHGmxicWQIlD8I6kcoQ6OpRYPEAmQOCiGYIk5?= =?us-ascii?Q?QGs97gIz5L+z9xm9hXTrtug1ZSRXuQw5vlwwN60IqN5O6oNq17rXHWUAqkC4?= =?us-ascii?Q?8RcO+ifpWZNdElF3MSp4cDwTdpPOfs7m6wGJ7ZehpMtYLbIk9KeID2+9YjhU?= =?us-ascii?Q?v4ssvTZ5CpkR7uyYS+v0iK8eeBa/sKOCdorx2fTRpEtINg/bClni1Gxio88F?= =?us-ascii?Q?U2PkdjI1712TRO6/Fgx4njdSLB5OTRfM2ja3jxV3r/a84uwIuLKOkKYtjA49?= =?us-ascii?Q?/hAUFfD6j1C+5LnlIRcYHpzm0kuGU2HRvZKxw5SybDeFp/egGOsatc8OjG+0?= =?us-ascii?Q?oQ9UCFPzCAWqfg5KqUbTxkhBGlyEFbgwW7pkhZwM5xd2j9gMAAj7Y7ex/QJg?= =?us-ascii?Q?m04pqfhHyevrcks21prY5Grxk1okXQeguybuYP4V5g0YYZZdsy/F4z0FcDsm?= =?us-ascii?Q?Xa/cYqpTgUERP9l+Mv5SkW/EDqXHmOpRSnbCLmHxn3tdV0ETTgUqs9fUSUL4?= =?us-ascii?Q?ufveCRVE/xiUjSUcpaXAf08VnTZAf3IXUQaahPhvkTwC0kocOXjRxyQ6Jjce?= =?us-ascii?Q?laIiXwbi5JW755227WZUOjzxhLRp21iIh5TXQLTLiL3QTfs9IXGU/mgFD84z?= =?us-ascii?Q?6sO72tpaHKf6j+5XxiV1KULyKNCP6qb73eJyFQg03gVulBGOy89JVtAM8G5I?= =?us-ascii?Q?Unclv+bKdmWnL3Uc5FB2ZjvVjLrZbSnu8ufUPhHXA4trOyaX0GOukwdl5fjk?= =?us-ascii?Q?fzcJsO6f66tpuHNajOI/KRl8dozPnoKRGM3MhjyiFOsDZK3JmGKco3Ipeq5J?= =?us-ascii?Q?qTpO2mDF9sKjRkNiof004Tm21bDsIayA4oSjtBBMbspRdJi6AFICeDcTpwHJ?= =?us-ascii?Q?sz2A8EgZGxYu87nSyT61G53KkL9cWV9qkQkyvRLyv2uLlbdfn4KBYt3b8u+q?= =?us-ascii?Q?rvGjMRDfwxDsgHSs5TFCoKmmBVmAQoIiJ1ca6xojQSOOamgAWPbnO7pZr2bC?= =?us-ascii?Q?CQXg78AUJnUzrEE5x2XIsVmyfU9ilxxMt+u9p05ZWAyIL9l37Mxaka2z1Rkl?= =?us-ascii?Q?1OiNK+UqtZsSAR0cqJKSFfky3H8tKAbKMHVvIy5OdlVSrKm7YzWV0O/37GoZ?= =?us-ascii?Q?cp/4vi5pyrClmqtpPQ+DuupK8cGCtNWcUO7o0ASucbhTY9vZIn0prc6RmXsE?= =?us-ascii?Q?eCVyORHyjD0nYXnpn5yxfnc/Z0ajVG5hgH82vDkdu9qq3nzltYJkLQVHDEP3?= =?us-ascii?Q?3XI6I5TKHisNHSM6CjkACTr/z85ANbtJLJf87cyB4UeoibParlYDFXNMQuiv?= =?us-ascii?Q?vsQVsIPOtg3GC3/mcX8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tvVCKEksd6Hjvn2prUB8IMhC+SpCvhhMO39o+cJVW+RjH5fLXx3VLqdj3v0x?= =?us-ascii?Q?FCbzfiVRe4WyrV2V+/fpX50Lq+nZt45LWBjHN94N8w+9wBywus3p/lWzb8kM?= =?us-ascii?Q?kfUQLBARHfO0ZulJrPgZ0VH95tMNTRy7SG/bUXHz8R5rx3k/Oqj0OGqbkyqN?= =?us-ascii?Q?Zt46Jl5Ziav42p3Ry+Fcj9NJcNqRhrguBdVEWcpPurb6Up2EYH0HciQG7Zfn?= =?us-ascii?Q?ffmpVK7AK7ToKblfmXYG3zXfcdh/DMYS5tCO3s6+ordO2RJe3rnKN3QCjjl3?= =?us-ascii?Q?F22xZP3UV7nVG8kx8NwW15Ww5BCYS7YLycQUDkIY18kbX4Bm5Ri/FohFdMLa?= =?us-ascii?Q?kjk32VDecHOgLXHafSzp3NgTuA+V1F18pNlSFWq96zlGf3EHkh/Zt93wVpqq?= =?us-ascii?Q?Pf0oHh5NI1ttBHkm3k+i2Oung2p7rMxKO5s0fMbXMzcV4/7MlEUN6fLFCmQe?= =?us-ascii?Q?5gHsNnctFszNX4VwopXSOIYf3yiEfGmpXI3ADAyyT9covKhCrXDA2Yg+dKfW?= =?us-ascii?Q?SGXG5H8Ya+gVKtX0OS6VNStXZKnG0YjhyTIDxgWwHxdUWHA07Mtr5GFWB4ED?= =?us-ascii?Q?ut9reQ5QyIUxY6BNBJzZ5JdC5apDXCXD27YlG57nPqPn17dRX4GeclweYcT1?= =?us-ascii?Q?kNnAgC6nRvX6hTHcrBIqT9QnbmIof948GBnCBXHTYDMj16fZPBLqfCIKFV4h?= =?us-ascii?Q?Um704CRiEYAC8jSSGGk1/xZaaqTTOc+2CC+Hm62vU3yaIErgy6H9DiIdElDE?= =?us-ascii?Q?XIZoapG9JABzF69eYX2cBL76JGvPWf60gvn9TvDxVhr3wAVZ/3C8P3JxeDdN?= =?us-ascii?Q?1DWXFLC+JezhkwcHO83DQcRJsUxNW1gASZsKd/x2sW+NP0EdBeFRNq0lsbip?= =?us-ascii?Q?xNkbKzuCNBsSgVsrRgY24BeBKopOgPuGeCR6oy2U2FLcTcOylSyNX0uUJUwE?= =?us-ascii?Q?EE0j3JnXYiRbExST/cb4dUY1rMv4q3e4L6bzl0MCo3aWeX3GQ7xdf7BkF8yV?= =?us-ascii?Q?Y03fu3znPqR0C4QPBNnvawTQB910L4+lc+9mK9fgtOXrntRZvgNbCNxHdzVZ?= =?us-ascii?Q?HNY8R+nNvUb0anLX6HAqFWCxxOTTNDLy4sJ18HgRrN0n6t6yJQxNNUVaTfaI?= =?us-ascii?Q?X2q5PQNOifiwTOzWR7WfR6Vxg65ssMTp6Vaecc+fINpYolqLdvPGClFt+1VN?= =?us-ascii?Q?veb5lYSbBwq71cvq6Ct7lESHY3WO65T3gxuu5azPLecsdkwT5vzurZSr7lhO?= =?us-ascii?Q?TMKnLgNVtqD7WRHTVaENEZ1UkqvvEOfrUO8hXPewNZ4c+9x2rQnkHAfgqBzH?= =?us-ascii?Q?TfYUnkPk/+2LQ7awGsSgvkgn2beaQHxYpSN74ZnmcUMN/6RFZdbJido8yzDw?= =?us-ascii?Q?dAgloyJchIcYKXUme71rc20fV++rmeZE2uzkp7PVvjnP553nnNVk5RkCSvzq?= =?us-ascii?Q?vsxAag+zONvCA0Ejcyw5qjwRSdWfER4xU8rNeGUKhFbtvmFpv6cS7cgpVt3G?= =?us-ascii?Q?AIdSAPDvIBLYowdNyrfACGjzP/mLhNKGOxrk/dFxpb9cMPKr/7jIyYGroBGU?= =?us-ascii?Q?qc8duH+ozstF6yoYcroMxFU32aHvr4lVuln6GBeSYpr2PftvEVLbXmk+1/Z7?= =?us-ascii?Q?FNQkZpUGYzLIcuEuH5xNIFOKvtibQen47lYty5Lv77c2JsW5RX1eEmY4kJcO?= =?us-ascii?Q?idD6LI2137iZhQm8MjWQZuMZLfPnZ24mvRjm2+J4KYRHRQUKdZjZtJtzvela?= =?us-ascii?Q?VwZM7etxaw=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 263199bd-54a3-4dee-f0f4-08de73f796e0 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:56.0222 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pHkPj7/WOQgQEorSRnfsHXCMW+TQwAH81Nl45LIJbk/d961VTlYK45S53SGhKeFgp95Lr0a8BqVy6VkRJamt3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add unified Pte, Pde, and DualPde wrapper enums that abstract over MMU v2 and v3 page table entry formats. These enums allow the page table walker and VMM to work with both MMU versions. Each unified type: - Takes MmuVersion parameter in constructors - Wraps both ver2 and ver3 variants - Delegates method calls to the appropriate variant This enables version-agnostic page table operations while keeping version-specific implementation details encapsulated in the ver2 and ver3 modules. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/mm/pagetable.rs | 301 ++++++++++++++++++++++++++ 1 file changed, 301 insertions(+) diff --git a/drivers/gpu/nova-core/mm/pagetable.rs b/drivers/gpu/nova-core/= mm/pagetable.rs index 5263a8f56529..33acb7053fbe 100644 --- a/drivers/gpu/nova-core/mm/pagetable.rs +++ b/drivers/gpu/nova-core/mm/pagetable.rs @@ -10,6 +10,14 @@ pub(crate) mod ver2; pub(crate) mod ver3; =20 +use kernel::prelude::*; + +use super::{ + pramin, + Pfn, + VramAddress, + PAGE_SIZE, // +}; use crate::gpu::Architecture; =20 /// MMU version enumeration. @@ -77,6 +85,74 @@ pub(crate) const fn as_index(&self) -> u64 { } } =20 +impl MmuVersion { + /// Get the `PDE` levels (excluding PTE level) for page table walking. + pub(crate) fn pde_levels(&self) -> &'static [PageTableLevel] { + match self { + Self::V2 =3D> ver2::PDE_LEVELS, + Self::V3 =3D> ver3::PDE_LEVELS, + } + } + + /// Get the PTE level for this MMU version. + pub(crate) fn pte_level(&self) -> PageTableLevel { + match self { + Self::V2 =3D> ver2::PTE_LEVEL, + Self::V3 =3D> ver3::PTE_LEVEL, + } + } + + /// Get the dual PDE level (128-bit entries) for this MMU version. + pub(crate) fn dual_pde_level(&self) -> PageTableLevel { + match self { + Self::V2 =3D> ver2::DUAL_PDE_LEVEL, + Self::V3 =3D> ver3::DUAL_PDE_LEVEL, + } + } + + /// Get the number of PDE levels for this MMU version. + pub(crate) fn pde_level_count(&self) -> usize { + self.pde_levels().len() + } + + /// Get the entry size in bytes for a given level. + pub(crate) fn entry_size(&self, level: PageTableLevel) -> usize { + if level =3D=3D self.dual_pde_level() { + 16 // 128-bit dual PDE + } else { + 8 // 64-bit PDE/PTE + } + } + + /// Get the number of entries per page table page for a given level. + pub(crate) fn entries_per_page(&self, level: PageTableLevel) -> usize { + PAGE_SIZE / self.entry_size(level) + } + + /// Compute upper bound on page table pages needed for `num_virt_pages= `. + /// + /// Walks from PTE level up through PDE levels, accumulating the tree. + pub(crate) fn pt_pages_upper_bound(&self, num_virt_pages: usize) -> us= ize { + let mut total =3D 0; + + // PTE pages at the leaf level. + let pte_epp =3D self.entries_per_page(self.pte_level()); + let mut pages_at_level =3D num_virt_pages.div_ceil(pte_epp); + total +=3D pages_at_level; + + // Walk PDE levels bottom-up (reverse of pde_levels()). + for &level in self.pde_levels().iter().rev() { + let epp =3D self.entries_per_page(level); + // How many pages at this level do we need to point to + // the previous pages_at_level? + pages_at_level =3D pages_at_level.div_ceil(epp); + total +=3D pages_at_level; + } + + total + } +} + /// Memory aperture for Page Table Entries (`PTE`s). /// /// Determines which memory region the `PTE` points to. @@ -149,3 +225,228 @@ fn from(val: AperturePde) -> Self { val as u8 } } + +/// Unified Page Table Entry wrapper for both MMU v2 and v3 `PTE` +/// types, allowing the walker to work with either format. +#[derive(Debug, Clone, Copy)] +pub(crate) enum Pte { + /// MMU v2 `PTE` (Turing/Ampere/Ada). + V2(ver2::Pte), + /// MMU v3 `PTE` (Hopper+). + V3(ver3::Pte), +} + +impl Pte { + /// Create a `PTE` from a raw `u64` value for the given MMU version. + pub(crate) fn new(version: MmuVersion, val: u64) -> Self { + match version { + MmuVersion::V2 =3D> Self::V2(ver2::Pte::new(val)), + MmuVersion::V3 =3D> Self::V3(ver3::Pte::new(val)), + } + } + + /// Create an invalid `PTE` for the given MMU version. + pub(crate) fn invalid(version: MmuVersion) -> Self { + match version { + MmuVersion::V2 =3D> Self::V2(ver2::Pte::invalid()), + MmuVersion::V3 =3D> Self::V3(ver3::Pte::invalid()), + } + } + + /// Create a valid `PTE` for video memory. + pub(crate) fn new_vram(version: MmuVersion, pfn: Pfn, writable: bool) = -> Self { + match version { + MmuVersion::V2 =3D> Self::V2(ver2::Pte::new_vram(pfn, writable= )), + MmuVersion::V3 =3D> Self::V3(ver3::Pte::new_vram(pfn, writable= )), + } + } + + /// Check if this `PTE` is valid. + pub(crate) fn is_valid(&self) -> bool { + match self { + Self::V2(p) =3D> p.valid(), + Self::V3(p) =3D> p.valid(), + } + } + + /// Get the physical frame number. + pub(crate) fn frame_number(&self) -> Pfn { + match self { + Self::V2(p) =3D> p.frame_number(), + Self::V3(p) =3D> p.frame_number(), + } + } + + /// Get the raw `u64` value. + pub(crate) fn raw_u64(&self) -> u64 { + match self { + Self::V2(p) =3D> p.raw_u64(), + Self::V3(p) =3D> p.raw_u64(), + } + } + + /// Read a `PTE` from VRAM. + pub(crate) fn read( + window: &mut pramin::PraminWindow<'_>, + addr: VramAddress, + mmu_version: MmuVersion, + ) -> Result { + let val =3D window.try_read64(addr.raw())?; + Ok(Self::new(mmu_version, val)) + } + + /// Write this `PTE` to VRAM. + pub(crate) fn write(&self, window: &mut pramin::PraminWindow<'_>, addr= : VramAddress) -> Result { + window.try_write64(addr.raw(), self.raw_u64()) + } +} + +/// Unified Page Directory Entry wrapper for both MMU v2 and v3 `PDE`. +#[derive(Debug, Clone, Copy)] +pub(crate) enum Pde { + /// MMU v2 `PDE` (Turing/Ampere/Ada). + V2(ver2::Pde), + /// MMU v3 `PDE` (Hopper+). + V3(ver3::Pde), +} + +impl Pde { + /// Create a `PDE` from a raw `u64` value for the given MMU version. + pub(crate) fn new(version: MmuVersion, val: u64) -> Self { + match version { + MmuVersion::V2 =3D> Self::V2(ver2::Pde::new(val)), + MmuVersion::V3 =3D> Self::V3(ver3::Pde::new(val)), + } + } + + /// Create a valid `PDE` pointing to a page table in video memory. + pub(crate) fn new_vram(version: MmuVersion, table_pfn: Pfn) -> Self { + match version { + MmuVersion::V2 =3D> Self::V2(ver2::Pde::new_vram(table_pfn)), + MmuVersion::V3 =3D> Self::V3(ver3::Pde::new_vram(table_pfn)), + } + } + + /// Create an invalid `PDE` for the given MMU version. + pub(crate) fn invalid(version: MmuVersion) -> Self { + match version { + MmuVersion::V2 =3D> Self::V2(ver2::Pde::invalid()), + MmuVersion::V3 =3D> Self::V3(ver3::Pde::invalid()), + } + } + + /// Check if this `PDE` is valid. + pub(crate) fn is_valid(&self) -> bool { + match self { + Self::V2(p) =3D> p.is_valid(), + Self::V3(p) =3D> p.is_valid(), + } + } + + /// Get the VRAM address of the page table. + pub(crate) fn table_vram_address(&self) -> VramAddress { + match self { + Self::V2(p) =3D> p.table_vram_address(), + Self::V3(p) =3D> p.table_vram_address(), + } + } + + /// Get the raw `u64` value. + pub(crate) fn raw_u64(&self) -> u64 { + match self { + Self::V2(p) =3D> p.raw_u64(), + Self::V3(p) =3D> p.raw_u64(), + } + } + + /// Read a `PDE` from VRAM. + pub(crate) fn read( + window: &mut pramin::PraminWindow<'_>, + addr: VramAddress, + mmu_version: MmuVersion, + ) -> Result { + let val =3D window.try_read64(addr.raw())?; + Ok(Self::new(mmu_version, val)) + } + + /// Write this `PDE` to VRAM. + pub(crate) fn write(&self, window: &mut pramin::PraminWindow<'_>, addr= : VramAddress) -> Result { + window.try_write64(addr.raw(), self.raw_u64()) + } +} + +/// Unified Dual Page Directory Entry wrapper for both MMU v2 and v3 [`Dua= lPde`]. +#[derive(Debug, Clone, Copy)] +pub(crate) enum DualPde { + /// MMU v2 [`DualPde`] (Turing/Ampere/Ada). + V2(ver2::DualPde), + /// MMU v3 [`DualPde`] (Hopper+). + V3(ver3::DualPde), +} + +impl DualPde { + /// Create a [`DualPde`] from raw 128-bit value (two `u64`s) for the g= iven MMU version. + pub(crate) fn new(version: MmuVersion, big: u64, small: u64) -> Self { + match version { + MmuVersion::V2 =3D> Self::V2(ver2::DualPde::new(big, small)), + MmuVersion::V3 =3D> Self::V3(ver3::DualPde::new(big, small)), + } + } + + /// Create a [`DualPde`] with only the small page table pointer set. + pub(crate) fn new_small(version: MmuVersion, table_pfn: Pfn) -> Self { + match version { + MmuVersion::V2 =3D> Self::V2(ver2::DualPde::new_small(table_pf= n)), + MmuVersion::V3 =3D> Self::V3(ver3::DualPde::new_small(table_pf= n)), + } + } + + /// Check if the small page table pointer is valid. + pub(crate) fn has_small(&self) -> bool { + match self { + Self::V2(d) =3D> d.has_small(), + Self::V3(d) =3D> d.has_small(), + } + } + + /// Get the small page table VRAM address. + pub(crate) fn small_vram_address(&self) -> VramAddress { + match self { + Self::V2(d) =3D> d.small.table_vram_address(), + Self::V3(d) =3D> d.small.table_vram_address(), + } + } + + /// Get the raw `u64` value of the big PDE. + pub(crate) fn big_raw_u64(&self) -> u64 { + match self { + Self::V2(d) =3D> d.big.raw_u64(), + Self::V3(d) =3D> d.big.raw_u64(), + } + } + + /// Get the raw `u64` value of the small PDE. + pub(crate) fn small_raw_u64(&self) -> u64 { + match self { + Self::V2(d) =3D> d.small.raw_u64(), + Self::V3(d) =3D> d.small.raw_u64(), + } + } + + /// Read a dual PDE (128-bit) from VRAM. + pub(crate) fn read( + window: &mut pramin::PraminWindow<'_>, + addr: VramAddress, + mmu_version: MmuVersion, + ) -> Result { + let lo =3D window.try_read64(addr.raw())?; + let hi =3D window.try_read64(addr.raw() + 8)?; + Ok(Self::new(mmu_version, lo, hi)) + } + + /// Write this dual PDE (128-bit) to VRAM. + pub(crate) fn write(&self, window: &mut pramin::PraminWindow<'_>, addr= : VramAddress) -> Result { + window.try_write64(addr.raw(), self.big_raw_u64())?; + window.try_write64(addr.raw() + 8, self.small_raw_u64()) + } +} --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010042.outbound.protection.outlook.com [52.101.193.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09F82363C5D; Tue, 24 Feb 2026 22:54:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973653; cv=fail; b=gCh3lwLVFkQ8MIR4y00sY+LOYlPAzE0iKGTAGPDBVWVeGzCV+VO7Z0PmxLEKhwEhYx5AsJMWS0/fmFXztS1iNa25fxvH8THFkvYsunFqb/lKgtmNa1YPAt9HStWQif2Tha18epC4pukJySeMZTuEsRiz+R75tDii4u++KiciFVo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973653; c=relaxed/simple; bh=eVIS6DvFkhcKSbJfyXKqpELuF0488jXw4dBEFEw65nA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=CQMI2MFfVB/8te/jN7IO7Ugl5O17tTh9wJdnEu81MaGAqErroqB8zVeyHonAJGUyqBJ2/3bhgTFMlLNXUF/u/Z5EYYbln7oTrXqDlJKjk6ufSsmyyLscTPo9AdbYg/ieaptN8doGeQ0yst3xibMjvmMYZoLkJh+s4rIuKGS5MF8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=JqzD3T2o; arc=fail smtp.client-ip=52.101.193.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="JqzD3T2o" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W1ExxxsWQJFbjGB8uZn5QFN1lSrFY+iNBOoGz+7XPn6V6Hgfd5UQoOoVOj1MsRpGYSo35zXE0/uoAD3W0LbcvZT4ZTUurJmbqbK/oL4n0emPRzE1v2rx0MDlZTbNe7m+uP6gxrWqWXLP6+UwXfVeKrfmYPDiJCABDfGzgQQz841rHb+qywSV0aDAoxJV19DKAxBBVT2Ki+IdxHRwWClzmjBmyyio19MhgZWfjKaT1at+2fugelMQBTplN32ziERHyI72XmUuFGwG+aPtHcK3jz/dByRewFZUUr8vGIKovePQB8zlJZncKQtlRE/4PU+PpXvo9HWAK52r3rcUMmEq4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zjZlGVk0YUn8kEJoKw2b/0gO2H+7pm7reeSqNEgmikk=; b=FtoY2yHnPIKY2+vACNAKRVbEB36KCmViIhjTVwDKbIx6TC13KFlGIs7gFlKTN3QMP158DK8WGkFJLWSEqWvtXsEQLJXGHh1y99YY/gQMecOOhEeVTWK00M9x+exko9vTcvOUjHTw01+4YrJXGywKnr5zAD81jux94s1/Dbhceef8Z64Cg0qh4WTRxsKDh25x4PTbLRDIY2AtrDHVKyeZL+BkfZAMt1+MnSySvWMnNwUvDRwWY/9ueL4OkuEXiZaKIjFj71SHgsE/uYFU6hF/EToXY3lyrTA0WU3RCjKQCkMWwqayX9FsWayBiYcPXnjqBDXqwJqRWWbTZgmyh5WjEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zjZlGVk0YUn8kEJoKw2b/0gO2H+7pm7reeSqNEgmikk=; b=JqzD3T2o4zD7ARWil0REMIAH17huB3GDU77IIPtd4u+AC/cDBKIE8HFtge6j8s2W84ELUaWrwzg0ULiK6Enk6saQeQj3Wn2LLgUaUn9uL1ewwttYbzw95ClTQDgfXMD6Ke8wQVEZYhbSq2tJjPBQamoJIJO3tJ7uauCL99fzQWqsgbDutEp/AUzSarDckVsndYWO2ljp83TaqWZE1XoyZAMyEU/my77NIjBwKmW4T3PurLrUmHs/02+Fm84LwYHCAwG4vB+KcLaKLim69xeEdKIJnRXbpI9ydrsTkHhad8vXgnHqrGHajLUG7RJcaihW3bBb5F5++gLUpj06RCSpIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:54:00 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:54:00 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 16/25] gpu: nova-core: mm: Add page table walker for MMU v2/v3 Date: Tue, 24 Feb 2026 17:53:14 -0500 Message-Id: <20260224225323.3312204-17-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL0PR01CA0003.prod.exchangelabs.com (2603:10b6:208:71::16) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 5048f266-ea32-4310-8c2a-08de73f797a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4FhG0r65jDIZ6XBWusmWJDgLGsqOF5b8S7Yogxz1ZdBp4DGkilpQSzl0xU7f?= =?us-ascii?Q?26VCmK8ElIYcwX8F+XncJuDHjrAwZoSV99dyIjTrcO+GxQr5GUHFIL6BtFjV?= =?us-ascii?Q?8c/c4nr4zziOuRafmX9lRpio59Qd1M/jwsRFm01mlmCTa4E+QQt76GV6rJom?= =?us-ascii?Q?JN6+SVX3VrCyVQc/esg3Tf5X/ZSSmXR0TOoPaMIuuHXqeFJcHJnI6sGFdHTl?= =?us-ascii?Q?AZRdLzbbwfWlxN6bv5m0kQJnFzHdfWo3dvdso/XFxoUs60YZK0DWnX5xm3+E?= =?us-ascii?Q?YA8VyvKZywgikj6UOYx1txPiHUNmd7OdqKcXoP83AFwBkJqM4l0SfvNzwNfV?= =?us-ascii?Q?c1jU/2oXTWE8jqP3jtHgneCOPJJung1JExs+GGqYan3qIAvvSKnFxorJ5plh?= =?us-ascii?Q?bgSb/ahdPrJ7y0cDJeqJUL6qP87nv8rzNTSq8mEHT9Ui0jj4Y5mkS90pCEtC?= =?us-ascii?Q?5A8ZEuGoe7VzJomnrtV//bqe6xm7fCL7ERRGG0OsXVY1T6hTjmgiCo2iAk3V?= =?us-ascii?Q?R7/OKgpSWzI0UvtQh3cE0QxKDMLqWcceRTxia3oKBR0gYFA7RCSk+cfMl0ol?= =?us-ascii?Q?HiFHB6TLKKP/XQ9KewAGja7zmPzLUEofZ7w+ES6BWh5zgP3hVLdiN/VzbZa/?= =?us-ascii?Q?MGmuWBGR+WcvCmKJDAr1gz1x4kypGeWkYglT0qA8EX8Y4uAkxp0Gh+gO13Je?= =?us-ascii?Q?GvEmuxEbVGSK3jDz8soCGr9EB01ZvS3a6JIjXfWwePKoxMhxMP1ExcTxTxCt?= =?us-ascii?Q?REELRLY9ON5H9yE+cI74L9ncnTJ+iuGv8D/F5oeOIbMIjsa65j05WP4NYfvg?= =?us-ascii?Q?PssK1VFiIIgzzHxznZc+gjgzjObHAHzroieMQPLGJpl/rPYrhLekchQeDYy5?= =?us-ascii?Q?b54IFSzdjUI1Bn7PjBls/AD0kJmldCCtUoZYXTKGobnpkrlK+nPalsWKBzy7?= =?us-ascii?Q?se1O5WSxcRKxB0Mn2lKmMrMY0unD5/G13L8Ej8vMxexN1CUp1tZRkXDfognU?= =?us-ascii?Q?tRKINKDzyEadDqvSOrccWkIHwjuPrFN+y7kekudC8ssIq23AEsgKs+YjY6wp?= =?us-ascii?Q?/0NZHkqcPgpMKxjSqMqssF2Um/I8hu0aaMvc2xIarSksjWbzFq8yzUlF2kRw?= =?us-ascii?Q?RovJP2T/azPTPwngrJLWFgj6xMadiD7fHbQP0Ln73Yhjml1QzQkJUNs0cpiA?= =?us-ascii?Q?njfAm3dvo22g6lukqCOREYidc5bh0g91YaoFndhD6LUoF0EEvwUsHMU/wQVq?= =?us-ascii?Q?CuJyH0T5PGKbYbThlt0XtaoZzw96K5GHXznz6QYoMNfd1VsO6F4zGaumwave?= =?us-ascii?Q?Z6n+6eJOxDNfWb5mxtRUT1cZa2EPR49GOVms1ZoIyBkYfwgtSBBJYBs5EMVx?= =?us-ascii?Q?MFuUi3G6MRX3zSgr9zm+ujwxPRNWRabwDO8FtsTGgD8MATxYbi3RtYpeK7GO?= =?us-ascii?Q?gQBhcLETafmNlfRBIopvSQjqWWMQTl5Jj2xsobiWT5QQB+wfIlAwALNjAJQM?= =?us-ascii?Q?xDBumTYFjyUjHWYVGXtBnyVeVxDZztVVsfJ/yOMs9Yw+l65Y5Iw7JerfDxrL?= =?us-ascii?Q?kp7qvY5Cb8mVoOvN8aE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?amqUJt+j7WJV7liVFFWdHkRnyomTisfEOIIlzQU9egxJWYO0nFaU59c4OZNT?= =?us-ascii?Q?BRGZmUHQKlOqbv4KJJPMge8ipGxhhdNgkkEnQSHgqFyoa263QoWVA3N8V8Wh?= =?us-ascii?Q?f27Z/v7GDL7Ttp0YM1XC1FXLaR4LO/L2jru6wxvapc09UGKwO5X8HdZ6V+56?= =?us-ascii?Q?CTp9eU42lAvNZFVjWhXeQKKu6PjaWul9YyaBZBkthpLc21el19zl9mUh2WMk?= =?us-ascii?Q?oQUT/5zYjlRIdEz26alwcD1uX26luUnxcPZubvxw7p+2wZPsCP8cqB2C/5kU?= =?us-ascii?Q?ap+RRky1ZxP76qUe3RFPQ7fTGcAmCFnbK1E4yhWkM7PFO4mv65hXlS/T19TY?= =?us-ascii?Q?8xQjFx9GRehqhx+w8aUJ2iV2Drj1tj4j/FC0DM2Cykf0K0dFA4ikvtAO2QsF?= =?us-ascii?Q?PPaATJ7yqNVEd857M8lf+7LjqYWhLKWAsoKKY/mB9YLNkjekLD6rRTNBmpEs?= =?us-ascii?Q?n23RFbKmW11F2jetPytrXx+FoqmR5kGQ8c5pjdzOBMYSuPzHPJTjqtO1oq7P?= =?us-ascii?Q?rFE22Z54BPUz0rQ4dend6j5zWS8vCyJGPOTJ9Tdwmp3FwSP0MoUhCgOaLCRQ?= =?us-ascii?Q?GbZ/eUMVAS/pQV5zGksKsPvwFGlIvpxEW/3UPvPqFbxNv1lA9GennpayMmHU?= =?us-ascii?Q?73AUKxF6flHMDROsLY6IyAhqmwHojhL0w8bKm5DGEb5ZHvCiiFBrVj0JvZp3?= =?us-ascii?Q?n0FGbeFP+FIQQ835v+rxX+QcUTHYFQ3MXvgfJKSrES++oBI6DbzsQ+ISjDke?= =?us-ascii?Q?ApEbX3hM6QMwh3bkd/EGb9RCwoZbcHLBN9IXInmBMWgSG4hIo7KUEPVA8Vsn?= =?us-ascii?Q?k0ywy2PRW83jF3Jj/5ODsRY3F/zHyj2Tkd6SiF7YY/FDKoJqsp4womrZUvYL?= =?us-ascii?Q?ahsDs3vD/08ptOWhR6MmKfAZsTR0h2s0bGq5sQ9Lw//p6IzikmV5U7/pKv1M?= =?us-ascii?Q?vtwEOCd/gOPf9ZE6tGdcZjGKV5Uv6QuB7W90ELXMyzSHEg3FvECCKCYUptQq?= =?us-ascii?Q?jGDsP8wNwVumQcybW8fkdoZJgAwET9WI22wqiMv3fVbRh4fk28iYQnTXNYHa?= =?us-ascii?Q?w4OrNm6gJaqeRT149z/bQA6pJ63gnocvL2db5p3OLAmVd6CSl6d9qEMUE/DG?= =?us-ascii?Q?rrgmlGjvILmT6RyMGo1T2LvYYmsT49LUYlctVG6nEF5rhVWPVZe0UZaSHGdS?= =?us-ascii?Q?9jTbqylCWcwoH6eaYjNDmWZ+MS8AxziWAr5dYXzUystbhccIN7K1H+C01TkO?= =?us-ascii?Q?vrE6Uo3z7GrrIO9mG3SBVVIBh9o4dhUZR4PqzHA/VjH8e7vwjLJVwtawht/m?= =?us-ascii?Q?CaicrRDz8w2Hf84S0O+vhV552/Nrrx2SMWmKArv5oTKOROzMVsPIP8epX1/G?= =?us-ascii?Q?bS6bVNIGGo6QmXtIDulAvYznRrpjOvPauqsi1Kr0pDNSS0ieiCPxwYzvoEXj?= =?us-ascii?Q?bn5HmKBJFI04u4SV0uhNr4/u13CSwprYOI/Un+9Of3eycFRc9Feice/3iyPd?= =?us-ascii?Q?SdyqMXjH15S+0Mon3eSTvN/LcQYkJXnCng+TkIBJ2LBdqvoYO+o38KQbVSuz?= =?us-ascii?Q?Tf0qhHmCm4NhQWTYxA3aBodgrWsMgTpX4DXrFPzYmBmuGbOXawF+THxp9De9?= =?us-ascii?Q?Qe7FgWU9PoscVgtiYDJPI1nZLRkGYr9Q2WQu55IRYIpV4Vpk14EvFrsNOOH/?= =?us-ascii?Q?9zCGrp5k53i8HiGM+VqxFu5bjkG/dbmQhG1cEBd5xCfVqQ6kQeOwZj6SYOyO?= =?us-ascii?Q?ET6diAq8Hg=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5048f266-ea32-4310-8c2a-08de73f797a5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:57.2775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A4HsFxylrD6fMnVY15cjoImRF40+cJHt6Zl69fmkuItJJYQLKjXCVFIzks+yvFPISwgbBPGkFlf8NkbiDe5row== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add the page table walker implementation that traverses the page table hierarchy for both MMU v2 (5-level) and MMU v3 (6-level) to resolve virtual addresses to physical addresses or find PTE locations. Currently only v2 has been tested (nova-core currently boots pre-hopper) with some initial prepatory work done for v3. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/mm/pagetable.rs | 1 + drivers/gpu/nova-core/mm/pagetable/walk.rs | 218 +++++++++++++++++++++ 2 files changed, 219 insertions(+) create mode 100644 drivers/gpu/nova-core/mm/pagetable/walk.rs diff --git a/drivers/gpu/nova-core/mm/pagetable.rs b/drivers/gpu/nova-core/= mm/pagetable.rs index 33acb7053fbe..7ebea4cb8437 100644 --- a/drivers/gpu/nova-core/mm/pagetable.rs +++ b/drivers/gpu/nova-core/mm/pagetable.rs @@ -9,6 +9,7 @@ #![expect(dead_code)] pub(crate) mod ver2; pub(crate) mod ver3; +pub(crate) mod walk; =20 use kernel::prelude::*; =20 diff --git a/drivers/gpu/nova-core/mm/pagetable/walk.rs b/drivers/gpu/nova-= core/mm/pagetable/walk.rs new file mode 100644 index 000000000000..023226af8816 --- /dev/null +++ b/drivers/gpu/nova-core/mm/pagetable/walk.rs @@ -0,0 +1,218 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Page table walker implementation for NVIDIA GPUs. +//! +//! This module provides page table walking functionality for MMU v2 and v= 3. +//! The walker traverses the page table hierarchy to resolve virtual addre= sses +//! to physical addresses or to find PTE locations. +//! +//! # Page Table Hierarchy +//! +//! ## MMU v2 (Turing/Ampere/Ada) - 5 levels +//! +//! ```text +//! +-------+ +-------+ +-------+ +---------+ +-------+ +//! | PDB |---->| L1 |---->| L2 |---->| L3 Dual |---->| L4 | +//! | (L0) | | | | | | PDE | | (PTE) | +//! +-------+ +-------+ +-------+ +---------+ +-------+ +//! 64-bit 64-bit 64-bit 128-bit 64-bit +//! PDE PDE PDE (big+small) PTE +//! ``` +//! +//! ## MMU v3 (Hopper+) - 6 levels +//! +//! ```text +//! +-------+ +-------+ +-------+ +-------+ +---------= + +-------+ +//! | PDB |---->| L1 |---->| L2 |---->| L3 |---->| L4 Dual = |---->| L5 | +//! | (L0) | | | | | | | | PDE = | | (PTE) | +//! +-------+ +-------+ +-------+ +-------+ +---------= + +-------+ +//! 64-bit 64-bit 64-bit 64-bit 128-bit = 64-bit +//! PDE PDE PDE PDE (big+small= ) PTE +//! ``` +//! +//! # Result of a page table walk +//! +//! The walker returns a [`WalkResult`] indicating the outcome. + +use kernel::prelude::*; + +use super::{ + DualPde, + MmuVersion, + PageTableLevel, + Pde, + Pte, // +}; +use crate::{ + mm::{ + pramin, + GpuMm, + Pfn, + Vfn, + VirtualAddress, + VramAddress, // + }, + num::{ + IntoSafeCast, // + }, +}; + +/// Result of walking to a PTE. +#[derive(Debug, Clone, Copy)] +pub(crate) enum WalkResult { + /// Intermediate page tables are missing (only returned in lookup mode= ). + PageTableMissing, + /// PTE exists but is invalid (page not mapped). + Unmapped { pte_addr: VramAddress }, + /// PTE exists and is valid (page is mapped). + Mapped { pte_addr: VramAddress, pfn: Pfn }, +} + +/// Result of walking PDE levels only. +/// +/// Returned by [`PtWalk::walk_pde_levels()`] to indicate whether all PDE = levels +/// resolved or a PDE is missing. +#[derive(Debug, Clone, Copy)] +pub(crate) enum WalkPdeResult { + /// All PDE levels resolved -- returns PTE page table address. + Complete { + /// VRAM address of the PTE-level page table. + pte_table: VramAddress, + }, + /// A PDE is missing and no prepared page was provided by the closure. + Missing { + /// PDE slot address in the parent page table (where to install). + install_addr: VramAddress, + /// The page table level that is missing. + level: PageTableLevel, + }, +} + +/// Page table walker for NVIDIA GPUs. +/// +/// Walks the page table hierarchy (5 levels for v2, 6 for v3) to find PTE +/// locations or resolve virtual addresses. +pub(crate) struct PtWalk { + pdb_addr: VramAddress, + mmu_version: MmuVersion, +} + +impl PtWalk { + /// Calculate the VRAM address of an entry within a page table. + fn entry_addr( + table: VramAddress, + mmu_version: MmuVersion, + level: PageTableLevel, + index: u64, + ) -> VramAddress { + let entry_size: u64 =3D mmu_version.entry_size(level).into_safe_ca= st(); + VramAddress::new(table.raw_u64() + index * entry_size) + } + + /// Create a new page table walker. + pub(crate) fn new(pdb_addr: VramAddress, mmu_version: MmuVersion) -> S= elf { + Self { + pdb_addr, + mmu_version, + } + } + + /// Walk PDE levels with closure-based resolution for missing PDEs. + /// + /// Traverses all PDE levels for the MMU version. At each level, reads= the PDE. + /// If valid, extracts the child table address and continues. If missi= ng, calls + /// `resolve_prepared(install_addr)` to resolve the missing PDE. + pub(crate) fn walk_pde_levels( + &self, + window: &mut pramin::PraminWindow<'_>, + vfn: Vfn, + resolve_prepared: impl Fn(VramAddress) -> Option, + ) -> Result { + let va =3D VirtualAddress::from(vfn); + let mut cur_table =3D self.pdb_addr; + + for &level in self.mmu_version.pde_levels() { + let idx =3D va.level_index(level.as_index()); + let install_addr =3D Self::entry_addr(cur_table, self.mmu_vers= ion, level, idx); + + if level =3D=3D self.mmu_version.dual_pde_level() { + // 128-bit dual PDE with big+small page table pointers. + let dpde =3D DualPde::read(window, install_addr, self.mmu_= version)?; + if dpde.has_small() { + cur_table =3D dpde.small_vram_address(); + continue; + } + } else { + // Regular 64-bit PDE. + let pde =3D Pde::read(window, install_addr, self.mmu_versi= on)?; + if pde.is_valid() { + cur_table =3D pde.table_vram_address(); + continue; + } + } + + // PDE missing in HW. Ask caller for resolution. + if let Some(prepared_addr) =3D resolve_prepared(install_addr) { + cur_table =3D prepared_addr; + continue; + } + + return Ok(WalkPdeResult::Missing { + install_addr, + level, + }); + } + + Ok(WalkPdeResult::Complete { + pte_table: cur_table, + }) + } + + /// Walk to PTE for lookup only (no allocation). + /// + /// Returns [`WalkResult::PageTableMissing`] if intermediate tables do= n't exist. + pub(crate) fn walk_to_pte_lookup(&self, mm: &GpuMm, vfn: Vfn) -> Resul= t { + let mut window =3D mm.pramin().window()?; + self.walk_to_pte_lookup_with_window(&mut window, vfn) + } + + /// Walk to PTE using a caller-provided PRAMIN window (lookup only). + /// + /// Uses [`PtWalk::walk_pde_levels()`] for the PDE traversal, then rea= ds the PTE at + /// the leaf level. Useful when called for multiple VFNs with single P= RAMIN window + /// acquisition. Used by [`Vmm::execute_map()`] and [`Vmm::unmap_pages= ()`]. + pub(crate) fn walk_to_pte_lookup_with_window( + &self, + window: &mut pramin::PraminWindow<'_>, + vfn: Vfn, + ) -> Result { + match self.walk_pde_levels(window, vfn, |_| None)? { + WalkPdeResult::Complete { pte_table } =3D> { + Self::read_pte_at_level(window, vfn, pte_table, self.mmu_v= ersion) + } + WalkPdeResult::Missing { .. } =3D> Ok(WalkResult::PageTableMis= sing), + } + } + + /// Read the PTE at the PTE level given the PTE table address. + fn read_pte_at_level( + window: &mut pramin::PraminWindow<'_>, + vfn: Vfn, + pte_table: VramAddress, + mmu_version: MmuVersion, + ) -> Result { + let va =3D VirtualAddress::from(vfn); + let pte_level =3D mmu_version.pte_level(); + let pte_idx =3D va.level_index(pte_level.as_index()); + let pte_addr =3D Self::entry_addr(pte_table, mmu_version, pte_leve= l, pte_idx); + let pte =3D Pte::read(window, pte_addr, mmu_version)?; + + if pte.is_valid() { + return Ok(WalkResult::Mapped { + pte_addr, + pfn: pte.frame_number(), + }); + } + Ok(WalkResult::Unmapped { pte_addr }) + } +} --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010042.outbound.protection.outlook.com [52.101.193.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13C1E361DD5; Tue, 24 Feb 2026 22:54:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973651; cv=fail; b=bDKektBIO+ZmU4dV/fMgQu5MUCSXgezQTqFJtZdKu5z12+ynWnhOp5awTQhLn5W/HcV8irU9VlZyfh013Tyemf8vr/HuvuaaYcUIu6m2lfnX9e1AYWGOU55CEU5ihr+lKOL9q1gD/dKp1XrikZUtMozn0rbt+iFjJlEq6Wq4lPo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973651; c=relaxed/simple; bh=LvLCYIFbblV7Re3vySMK/2M8qU7/N4aAQv7MC6881Wc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=UOgEud/2jotKYZ1rrVY0sQqv9wESqFEl0U9rqILNV/nbMswfPJl/n0k1tLke5VVloYD5WgNfctNC2tFFso3vOGtKWzq/lXSBKmJ2dZ+JGr9SizRAAioCfguACx7UjAtMBFTKwGDVyPsPJwbyzntlqweLlM9aBXIL048ljNBnemo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=s5te/amN; arc=fail smtp.client-ip=52.101.193.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="s5te/amN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CY2WEriKJTp8hZ3ARYIJwRcq5lx0Qk8/qNLJs8KpAt51kpgxn6Ph8gvMDXyi3APWaAETH4MfvtL7VwQLzD+DFqbolcyazOvdkVpreXQnw75RbVXqwC2yoY0xTcVAaDL36CQOFcWSarOYs0MwIHDyu4vNzOE0hPkMSJ1qhDm7bLo3c5tLX6R9Uhi/bu3wl1v71nOJBySU8ACm1Z0R8O1ytR2+vg8aVWU13oS2K09SnnI3zz0xvDb5Um4GWZXK0Ta7CzzrclgqTQ6e07T+PO2D6ckS/XPkI5GXzXaItIwj43jiGx+eVoq6HipquWUkZ9dJNVsVtF3zMwtKDoXyMPSprw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dgOw+wd+nKjMfYqb5M9KNTkWu/50KdaaXd4EdDyQ0r4=; b=B3MaoYcITugRfKyU2cQRI4FyL467XPFDY03+z+P0U8GmiP5RkyMfswELDHvtGfab6dN2kFv0d/WuE+wL6SOzWV787TX9/QjOc9hTKxX4jy4pYs7ufWZ5XH9CYG66aneXwsbLLjZ/j9BYhYRbDDNDH56ZWFTVpbN7DaQSLAajqZ6FxJk1frG6XPKe8OTNbdVD2J4wFCTWxBTZqbebAYjDKTB0tuOuBfE1un7k/M1Wow35pjuIYBOi+I7oAP3uupv+8782Y3pWb/1+f6xa8g23vB+IRslhiKmO7FSHUzb2mx1OGHvzC5KOyqIOtOYlrrDUG++0iJ1DXOhTcCize49Fdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dgOw+wd+nKjMfYqb5M9KNTkWu/50KdaaXd4EdDyQ0r4=; b=s5te/amNOS9HIDCTaPA1Osu5VDUcCK/sUYnUGmtSvOF2uPwo4yoguqmuH46JCM0YU0XSXCf7uUk+lePLZn5qL2XE7dyeYCgMeuyzcGluLm2y5DCBLqeycImaa1mjD7taiVor3Vy9R8QFpIYlXtePQh3Uy5spLE++F5nJrd2Xnyvu6RxEDdf1c9V4GUG0Cq0mXx+tcKeAVoIV+1wGoFxYVoN+Z6+y25jvb9OJfmvkCoxCeIU0M0Kp9rXDkO2nHeXb/3Ue6IU1l1VtTli/hvoJAYJKgTTsNznZb1MlShm9ImtNHTRSFf2lM87zkuGA55gpvSDP5vz8G2qJDmGLOQHyNg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:54:01 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:54:01 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 17/25] gpu: nova-core: mm: Add Virtual Memory Manager Date: Tue, 24 Feb 2026 17:53:15 -0500 Message-Id: <20260224225323.3312204-18-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR16CA0053.namprd16.prod.outlook.com (2603:10b6:208:234::22) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 539501ac-efdb-4bd2-f857-08de73f7986d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?a0IvTvelzkude0DEs9OuShke+gpKaPJ7uR+/NpMXOjp6GZwTtusWk3pjTj6k?= =?us-ascii?Q?FiCFtfEY9zIovWeENTMDvq4dPi6CYxMp55oFM6vfJLqLq3Zc+99PT54lqo8X?= =?us-ascii?Q?voTPzU/H2jp4Mc6yf3/2edvkuNRMmytu5x6Du/da788027JuQnn6XITtvjfC?= =?us-ascii?Q?ciUntw4VdAaoBxo5NPNmxz/EKnnZmYlp+rcynZOQzZwKHNxxHxfAWnu0n8nv?= =?us-ascii?Q?rt46noOmlKQPCVZkelcsiJagUaQQh5GdY8IY3adJGuaqx/tDWOaGsd95IcK3?= =?us-ascii?Q?E8q8KdY5fRC4qWx/XFToNa2X6D0aKTNrRZ4oa7Xm/ATg9GmsooOIUWBlrITF?= =?us-ascii?Q?yFosf58Rv1vTTOR5mSahavq8FxNT9ZHqPGNl3LZmTsWbQyCKP/UsgQPK4d47?= =?us-ascii?Q?wq4Qukx7lZQu+vBK4o5o6BFFpBPYI7gybmUAXmL4im9FhMeke04j2zp7td7P?= =?us-ascii?Q?kTRj8v+9SGBxdPycD1sN+j0O3wUkAtQFecpbLxXO9m7ZWto7NPy4vYDvfrJh?= =?us-ascii?Q?JU1tCfxpYpcmdoXxp9e/ZJX9cESJ0Wo22m7yxadONMxq6Yu5bRE9fqMhL8Ky?= =?us-ascii?Q?L+91ohlmHyQcj9ps/KDSbl0Exao9GPkWttQRPtP488zXIWcU1NbRKu/NBIzt?= =?us-ascii?Q?w1o4Sp0g0IqvUUbbm8hI1I79JIUMrFlVzrZhDczsUZspoVRI1jiDiD7XTHKv?= =?us-ascii?Q?8m6zrAWS9fvCnnt0A32d2fmilSLAtPlScIsVE4PgQhn7oPkivT+RVsM6ZsA3?= =?us-ascii?Q?igrvnAaUH/Iu2a7JlorDiH/IGpZ62XIB37hedCbN374AdxH54PP51Tx0IURx?= =?us-ascii?Q?LBFkvEQiBR6QOpRvI+WSM/0DluWHbhp73DWirNa1vLybOtgwgUN98AVBiCiI?= =?us-ascii?Q?i4TImjEjZmuOadwCIoYY3flE+MZR8FA4Sva7QffKx43iCgpDuk3CD+3ciqyh?= =?us-ascii?Q?MuNJfH43q8hHOBlDw/EwRwHDF+6yzF/SNt2G4K+RxzlwayiL83k0gXzabvlZ?= =?us-ascii?Q?azmYuhJROjaWCxrgW0OaO0W+24LasOwRRmhbzaCtuqEc5zJJEwkd3igsVya2?= =?us-ascii?Q?OquVFlzYiwLth88MK/SJ0ehRoMHpBDg/7gPJdt5BY4AKiwArFctbZ0TYMfM+?= =?us-ascii?Q?iD2FqvvKhorSciOEQZgPojv2KoRYAV8pHxwiGm6Ou/Rkm5Pz67SVliH0Fy0Y?= =?us-ascii?Q?SXKmUOgNICtd/f7eAid2M1ZvuLJ4u4fLx4ONLZZZ4Apd1gyDu45IJo8C9kHm?= =?us-ascii?Q?w00a94P9rLF+X29XPiu1NxGM5TiDxvuLxR/Mi+i9AFyPL9DFEsm00AxmpYeI?= =?us-ascii?Q?XAxY8yIH+1S2q7oT1aR2PxHsE50CAZsfT3OXDPPe6yKblTWBpGU7NB5xcwZK?= =?us-ascii?Q?qMK8RjREdZr3119tD4pJDNum25JW6QA0xLscFanTvBLsEbXN3bEJl7QzAfoW?= =?us-ascii?Q?+MUIWkXUW5nnR6ukg3tXUlnjeKGhwixF3pwqcHz0A5EEJgItGlBKgNEdN6Ga?= =?us-ascii?Q?h1DxLs/DMohItGgj6oG+Teq5+ZqzoxftXrf0lSno5MMYTvDuOq9qGGA9tfct?= =?us-ascii?Q?rHZkGFRLwvQHH+mrHGw=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?i8LLL6vhyommBdBUnT/sXbA/HV9zIb9tGg602iYT77MCrqCWw70bR5E8xnX4?= =?us-ascii?Q?wB4+nk9iNLvEwOg30/Yx2culAVl594S6fj98pSX9XRW/n4IER8sb5e3GF2sG?= =?us-ascii?Q?pxj+PVecOxsbw6jf0hlPO2keatXyvR2cYvPuyq0j4NIlrnFjz3ihsb+w1cG7?= =?us-ascii?Q?kw9GDRoLiruawKTOX+KJ8R/13UsUX3GexqFcLJVv11ETRKg5c/kaWvKddeXU?= =?us-ascii?Q?n1lmgcUKLBNLa6yB7Xxe/t1nYFlP3jJGZDfmbMRAqpRRmDBMEFWzZrKvjYAz?= =?us-ascii?Q?nTwJisHj3s9jwnUex7wM2iyY/WeQYhLswF8s2kh29nc1z2S4CCU+Bmoe5u5W?= =?us-ascii?Q?QU5l6JLvF/X8pat0YkN/Sarf5e8ndXmtj4MVQsNeaT6XAqz+ri0IEy9kr/nV?= =?us-ascii?Q?MGrFs/7uuWSoY0P3QwjR2Avf1wuFUkAVp3iFywEahfrMde0JG4C0iT1BRO2I?= =?us-ascii?Q?bpJpO1lGw619Ac3fcM4xzQJslu4Hp8xNLGNnz9RXuJtYWX5Lg2T7TkfvElN7?= =?us-ascii?Q?oHfHQ2wc+zrXqykpR2hHmA8ohhsGUJzgGpm1auESsDY2zFiRI54JL1owwsNu?= =?us-ascii?Q?S4Lu/kebEasCGP9pYBuNbyGekyiawNRbu+WRBqbzyYRcwkgQ8YWRvCRVYyk2?= =?us-ascii?Q?A6fGHmAcpolgsZJ6Qa9MDzdPi6WwJFiRKsXm5PvhZCW+p7lkq0Ye1G3mRtPM?= =?us-ascii?Q?ey9X2ZBTc7IoFXjqC8nQydAyspcwJehl7leg5NVktcg9lf4WvDAflsT0ae3s?= =?us-ascii?Q?HdT/qnry3ZvyDUHFvqj2cyNNL5V+KC30LGskGeD1n+li/0qcvv+Bs9zio2ja?= =?us-ascii?Q?dTvFjask3UgeuGd1YmivAZqpTs6QPX2KTnhQN74+ibXFoi5VEKRNpX34xpxD?= =?us-ascii?Q?TSOqxEu1vNC3eOXfQZ7zE5mSkVbADCxQ27Idp1ZeaxcYdYSCIWKImnoZ++7l?= =?us-ascii?Q?Jni0peEBo2AH3x4AVfe0emGqPl/uPE5WtHTiroNayIquIuj295ty5VmUOmRB?= =?us-ascii?Q?Mj3LnKdXBRNqfikmrRzu/ZRsUr3mvAuTj0QSp6EdqnhR4UkokDeNvpTb3KQb?= =?us-ascii?Q?MLardu91Y9RpMJGB8QANKAHczUR1VQ4QbOG21luh4m4coF1PyokWyb2PY6fq?= =?us-ascii?Q?xaMpOb9s3WrzxqAvtIrSktYuUPRYALp54J5b87UTARxZw5Qf1uN7aPSeWRo2?= =?us-ascii?Q?WBByTCdb7L3zFjjw8qoUve+r6h/hZVuT2b6VNtPx5tlOXMs2rUjbZz8WjmSb?= =?us-ascii?Q?rIluqjR4LCAgRJWtQA2G7DOykazTUKaylC7+3/67XGENuNCJSkZlv3JDqjkU?= =?us-ascii?Q?NchQfPpEl7Bgc0oeaf+YeL5SzFWlUaYy/u94SY9bzr5RILQWy2iLyAyMzRfC?= =?us-ascii?Q?/KJSaM142T9r0C+pj8OOFkaKyCeH/bJ3IsYCGpJYgFPNCRQwUy0oZ8kKQckw?= =?us-ascii?Q?Ykw4UqaoYHwkOulteh5Z7N5uEc/47c76KLMha+Zr5W0pqSd9oQ7ra91dxtBw?= =?us-ascii?Q?iuPaWKLRuM53tHb0pvKGWcaT9JnVEaF8r2+6XweN0Ps5FjOrhKrdMJQzIxD1?= =?us-ascii?Q?iTfwg19jgTKmijkjVh1+kOarkyxXpTMbgvwJXw2h0f6DRX8DUN4xM4jo7ypE?= =?us-ascii?Q?h0eBcTF5/8y+8ONEm7ToN8RvlybicbaN91nrU7fRdgzn5fmoDzcLZJiqWvUc?= =?us-ascii?Q?16GMVvmeEZQN1ewVfsPnDTe/3coZombjwdsUqJxw/addTaeyU6uO2gKs2bYb?= =?us-ascii?Q?q8nNkOuILg=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 539501ac-efdb-4bd2-f857-08de73f7986d X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:58.5766 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LPGSiJTviaY1CVqTGsX+mCktGcJZ8ofm0PpUKRL+wQ7+GIZYQgnF9aYRWqsUprf5JilHQq6uynMCwIGvnSVZfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add the Virtual Memory Manager (VMM) infrastructure for GPU address space management. Each Vmm instance manages a single address space identified by its Page Directory Base (PDB) address, used for Channel, BAR1 and BAR2 mappings. Mapping APIs and virtual address range tracking are added in later commits. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/mm.rs | 1 + drivers/gpu/nova-core/mm/vmm.rs | 63 +++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+) create mode 100644 drivers/gpu/nova-core/mm/vmm.rs diff --git a/drivers/gpu/nova-core/mm.rs b/drivers/gpu/nova-core/mm.rs index 7a76af313d53..594ac93497aa 100644 --- a/drivers/gpu/nova-core/mm.rs +++ b/drivers/gpu/nova-core/mm.rs @@ -7,6 +7,7 @@ pub(crate) mod pagetable; pub(crate) mod pramin; pub(crate) mod tlb; +pub(crate) mod vmm; =20 use kernel::{ devres::Devres, diff --git a/drivers/gpu/nova-core/mm/vmm.rs b/drivers/gpu/nova-core/mm/vmm= .rs new file mode 100644 index 000000000000..0e1b0d668c57 --- /dev/null +++ b/drivers/gpu/nova-core/mm/vmm.rs @@ -0,0 +1,63 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Virtual Memory Manager for NVIDIA GPU page table management. +//! +//! The [`Vmm`] provides high-level page mapping and unmapping operations = for GPU +//! virtual address spaces (Channels, BAR1, BAR2). It wraps the page table= walker +//! and handles TLB flushing after modifications. + +#![allow(dead_code)] + +use kernel::{ + gpu::buddy::AllocatedBlocks, + prelude::*, // +}; + +use crate::mm::{ + pagetable::{ + walk::{PtWalk, WalkResult}, + MmuVersion, // + }, + GpuMm, + Pfn, + Vfn, + VramAddress, // +}; + +/// Virtual Memory Manager for a GPU address space. +/// +/// Each [`Vmm`] instance manages a single address space identified by its= Page +/// Directory Base (`PDB`) address. The [`Vmm`] is used for Channel, BAR1 = and +/// BAR2 mappings. +pub(crate) struct Vmm { + pub(crate) pdb_addr: VramAddress, + pub(crate) mmu_version: MmuVersion, + /// Page table allocations required for mappings. + page_table_allocs: KVec>>, +} + +impl Vmm { + /// Create a new [`Vmm`] for the given Page Directory Base address. + pub(crate) fn new(pdb_addr: VramAddress, mmu_version: MmuVersion) -> R= esult { + // Only MMU v2 is supported for now. + if mmu_version !=3D MmuVersion::V2 { + return Err(ENOTSUPP); + } + + Ok(Self { + pdb_addr, + mmu_version, + page_table_allocs: KVec::new(), + }) + } + + /// Read the [`Pfn`] for a mapped [`Vfn`] if one is mapped. + pub(crate) fn read_mapping(&self, mm: &GpuMm, vfn: Vfn) -> Result> { + let walker =3D PtWalk::new(self.pdb_addr, self.mmu_version); + + match walker.walk_to_pte_lookup(mm, vfn)? { + WalkResult::Mapped { pfn, .. } =3D> Ok(Some(pfn)), + WalkResult::Unmapped { .. } | WalkResult::PageTableMissing =3D= > Ok(None), + } + } +} --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012064.outbound.protection.outlook.com [40.107.209.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3834D363C70; Tue, 24 Feb 2026 22:54:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973654; cv=fail; b=mqNxOPLV8+CXJ4onFS6F/4vUpRSGbOIx+WU05C+snUWytjQjWISgU8XFQvHOxeBlAfba9XmFItk6WT/pvyIiLdawvSJOd4x20MF79NM7Q0jOIewKToU8Dk/lS9O9kWMF5MxXIl/tpK7qJFPQ/tl86W7Fk7X3Txsmb1BLUS9m6Qk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973654; c=relaxed/simple; bh=mGU2QkyMNAyHuTAILRqq64YBieXyspicPvppoHh4IwM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=AFIIvR3eeG4xMNm6+ZSNOvh+DzIVh4Q7RPyAWITxX35k66IezzIcuoeL25XlJXWx0LfgI4IZT7ImO3VcziI7WgnZT82EZSjpDhTMCrubPTTHN8d+EB/UKdb1TSHdsaGGYeE6VM2uQDPY3UmKxoO+nE7ImU0OwXUUjSwcHHhnkK4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=cYj1AvIe; arc=fail smtp.client-ip=40.107.209.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="cYj1AvIe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VOL020/PtSQagBacsFY1hzUA+IItLquEFMV65Q451nnnOB6LSdgYPlbD3z7yCZdRAxSwhHEqXoyYBKQQLjr2UxflRS9a81eQYvb2ZkT/Aykwk6p01A/5wEkPKwmhB+2DBsag+KI0ldHfbdHtA/HAjoqYJFGbCXloLf1pUtYXXuUwzMDc8Oc5zN+KiD8ARmAnMHkgp5cqvbj4TfB2wOSCdRFYaBs37Eq25FvfSwCY9TKA40Au1iGakq24hgHaR5xAUXtGAoDVOqYELCzdbOTLgTgP3C7or3RrGjhU4h+m9LSJqWDAJ/hpo0Mo6TsX9DQ+06gWMxDRwSSU2y6CafcpLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F+qUf2iboRMvazHpjdRBDOOgqdeDeqXtYy3LUB+lVVI=; b=mkh+we/XFAI4Et/2sY0h3mNDaIyGBk5f1xDq+14Ps/GrnxkHiCuFsL1Bx4c5cABmZAyZd+OYhJKsxKDKm1bsF0OA8XAimV5n1z7znQ248TqZi84GWboz5+UeDWsQbWKxyqgQk16wvJR3TEF47yxQtkDhA7Pwmiq2/ifbDjTJYF23CSE5HHjR4EjQ+5wCj21NOfEn7LU1xi9zIqumzUeOYkr8830mEjRukao/eM9mV9tn6PPBBD6Cc27SQ2cnf73S0T95EydTYuzzHUw9Lnk1h3rvMtEgIMF8zrk4HrHuVPiNIYP2Kkhw/qmqMQaXrPgnDWPNIw5EWWfOloJjc5BatA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F+qUf2iboRMvazHpjdRBDOOgqdeDeqXtYy3LUB+lVVI=; b=cYj1AvIezbBpZAZ1eSa39TC7EtUAOv++j1hl7LcHOHOXHnvR/DsryM2/FngQR0PxreuHE5teCWbZsllX6VBvX3KPw6vyQTHM843AYAby30Pdo5hYCjZiSOINVcO9mqF+Z4gLR7+yPauZWVDesRQOD7JKq1zO2VBAbj4M76pFo3HfXNXVswnHHebB8otBsdSwi64i+yED+2D9lBPgoq3NdnxyVTXcRhivIAwOIUG+/YzlZyx7Wg7SLLT7SU4cVG5wL2oWjAD3XOWgXH6QpYoSvyB+ATzB8Ik3QWkkfX6uP7z/yIKFRVvsFVtnU7TKlODPnNYDryZFLplRcQ6RXO6Zig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:54:01 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:54:01 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 18/25] gpu: nova-core: mm: Add virtual address range tracking to VMM Date: Tue, 24 Feb 2026 17:53:16 -0500 Message-Id: <20260224225323.3312204-19-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL0PR01CA0007.prod.exchangelabs.com (2603:10b6:208:71::20) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 9515fd78-d4d4-4507-0b3d-08de73f79923 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?igFpFTeOvjSgVx2/L/Cn45tFVjxCto6L9vk1Kt1LsTCPsUJzfoAl2ZXu6T9u?= =?us-ascii?Q?WCjf5ZoIngdYtvQmXYSCzYOK1QZiJ6jL7dRM7eFPTq87BqCBJxpK3QUFdfbp?= =?us-ascii?Q?hhg9VxLJRwcfjQbMngAFtr9j0A4Cdd+c2N90M6yXKbYWyx6ktg1lfcCzHN9a?= =?us-ascii?Q?yKVf909boD1IZoS/8RKPMcJN3ZMCTagW+OW5NFgN73xaBHHzKbspBWwXYouH?= =?us-ascii?Q?RgPoUevdw+n7d58YRGPmJNPJtLy38O8EiI5MUYmgwLJk4LkOdFkelqCfhMif?= =?us-ascii?Q?Tm7Lr81QasTA7uZ3Tl6LwcijaUNYBPyuFT2pyAa4EXqYvG08X+qtNaAA1ce7?= =?us-ascii?Q?NMkF/YFsnxEtqCwZEBBkf/oxQPog/OftRiKhmf+T6ovOx+FDzObUI4/owThj?= =?us-ascii?Q?tNPbSZdpYmRGlLTVYNdUR7BhAkwjPPn79o2pb5Wg9EJkPaQnkGOvHrxjaLVW?= =?us-ascii?Q?FxdbGwjdvl7YNXRVzr4RF1T2rSJkBzuN7KSNu7SxOatLKOfqQ1YlUjK60N6p?= =?us-ascii?Q?WIh1J2hMc60G1pX/8HedhfFfzEiSnjP1wIk2FxaAUnAQWgW+TrJFzn4E1Z8W?= =?us-ascii?Q?Z2uu0FoQ65i808kwkaq3NWFMGru6ARid+WppCK2qBbCQL0dlKk+EbQ1sg5m8?= =?us-ascii?Q?2KaktyMvb81/E5ijSIBTsnL2TOwnRTkqxyKoWa/8xCCqGDzmC89iyD4g1gwu?= =?us-ascii?Q?pZr9yga4HANnu/pDQnY/xGMOsr+IZClo21UsYoszzbjHSeR4nWkX6egP+r3F?= =?us-ascii?Q?2UfiNyON5PEwqBJ3cAlJRQ5lXTVpb1ocdSS6s7Ru03yPa1NFv5hzc3U4gJBL?= =?us-ascii?Q?FYN4F+GR2rihNMgW995d/GrDAdtlXC2gpQZS4fEE/8sE4moTjDtZKCpQkW78?= =?us-ascii?Q?HAqsuMeWwCDAW/SdXgdRqR7rgrIE2GQ7cnDRJQlfDM5W4Z31drwMGD7zO70G?= =?us-ascii?Q?t/0/Ufcz5/5gw+bXgxPO0sT0dP/WmHvmfDduxFbznzdulZonbv0L2oNOuUNb?= =?us-ascii?Q?8u67I/oscQOIRkEi49/dZguT1YpimZjzicyc8adhO+OQPfwzIEjzxzd4vDOS?= =?us-ascii?Q?7kxA5fwFumbcv6CE09CFzvTk0G39iGNsTJ00ExQwD0G2C3pyYPAblFEoCqSt?= =?us-ascii?Q?eKHd6n+vJXgKxuc8i2loaVRa1oqNOMoeLEDktPP4jwU4ij2+6jGGdb9YKykB?= =?us-ascii?Q?dORIz00TDJpPOHJaYXOVHfVsMWw1mkzcfEysZisAhY+gimLhLX4JxW3YOM4A?= =?us-ascii?Q?UePXPwrGv6V/1rPn4mSnuTWWQAAmCZFCJu1J1bbLPdrBq9O8VekG4SsxDce6?= =?us-ascii?Q?5hyTIROGbJxvvi+TjpDms+DkdZSi/toua20YDllpD8ROcaZTPMdPu4vB0Geg?= =?us-ascii?Q?TjzqSBGk8HRY2igMUwZn7ktSfHpM7BlRHIX2mQIwqX0i/RaCi3TtrEyGRgAU?= =?us-ascii?Q?tbagPZ3fbw2giKGG8wMlRD3dyDijuwLur66/hF5dRe9z8g5r8NmoA73jWKDL?= =?us-ascii?Q?bdc533h+seosbrxQcD5kcRMLkQiMjQK1QJV5cPv+PZtn15+vp/s3eelc9GuS?= =?us-ascii?Q?slHwrHJrElJJ7f9NEXk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ny9gxcdPOTDiK91gHDoyuSkVuLuxWWUD7tZzTeHqB8k+EdMqvAByrFLCUtPa?= =?us-ascii?Q?F9MHSIc7Ls5tgdOAEvP4gqHuIF+tm5hi2+NeQG/iD8uFI3BCVoJzkq13JZXj?= =?us-ascii?Q?dXGL8sVkJUxtce/OSCp36XrgeVKrhLOfAIOt59utc10XO3/lk/52CXc1Woar?= =?us-ascii?Q?1stF2rizSwynDJKiRc65y49GQMD/S+s6cLq/pityCiIgOAytZAqMYLXsQ7o4?= =?us-ascii?Q?YEHhcm0nRVGQ8HaDwbMld2r0EDpYjRviAm4a5n4FKc8SmMHIIJk1cxIM/APw?= =?us-ascii?Q?ONBo+TrnkFPoXP24CFsVpKMr2AZ7f2jv+254GNy5WMkGCwgzS9PgHHrmFZ/C?= =?us-ascii?Q?A5dB0qlE9CTJFyE1kZOGEeNCDlzyZ4DVwcYJm0YxWZAD8SqdvVaWjJe/vkgy?= =?us-ascii?Q?ck6CJsCmV2N5NjdYnuZsQtv9+9cKJX2jI0wWMPhiVKjYtN01bGtYuJkJjLLx?= =?us-ascii?Q?MiqMUbpKDYD9LlkJ0OGnCCW7O39/1Tj3TJwVL4vuB/TQSxKucWxnSczU32Z3?= =?us-ascii?Q?f3Wy8EL8RJLkAmvbzylk5Gp76LzxIz8TRAJxtRjfuGYI65ZlC2OeCVf2mWeK?= =?us-ascii?Q?QDqJhF5r/dwzN9Tp3KBjo+Kf5XiOpNUqKd5quBT/T/zWFINRxvISEZEgpdCa?= =?us-ascii?Q?j5aXEdEQBEdGwIqJXY9XyfvqkSI5D4BkqUVp00N0GhatjY34P7j5qZSugpi2?= =?us-ascii?Q?HfivPzypyPuj3IvdvvObzjNNrAHCf7nY48Q57IkgTGgCb1P4MhCfIlQhowHh?= =?us-ascii?Q?LanOXChpEB2dyvBfrnUtqhyU45LCjrrmHZ7gyWbuWvhZrClno3NHl4SmxYoT?= =?us-ascii?Q?DhknFg2OCt3pjqWfqxtlw96HbB9i0Q+aDvoKbJ1xozwQmgmg7mGEtcqDD7o9?= =?us-ascii?Q?Gv40pl6AB0bjLhBJVkxCAdFIgxVu3vrqDmX2A73fbS5bOyXFjAIA1MW8iP5r?= =?us-ascii?Q?YWyckEtAdxpvv+HKINTL/GSA8G/8TgKl301NR6rbImSZZXf1Ao9bvDjr1A2C?= =?us-ascii?Q?wdYVLf5oNU9N5R94IQEL2iVqJgAK/ZitRh67+X8MDeNlG+F7SBbZViP0/U26?= =?us-ascii?Q?S3tRA4sDc4uzxkbgMzdTDa7bigqoBahg6iacPFzAjLLF3N6LbBA0O6Rwxc5G?= =?us-ascii?Q?mxBfV6CH9f1uJaLj6t8HPaue3ZSWLgpJgHigwf8U4S9D3MPJ5WT5k+fmHjPb?= =?us-ascii?Q?dccZUHZPfupYxS4zJrMLvSU6OehKd9G4kvLyCWAp3j1Beyo2LH06ktEVYuam?= =?us-ascii?Q?KhGnEEuNjqh6jEX3BeFi8XoEBpzR3TEVN1VAPdZWZCApqOTSKy087ysaancl?= =?us-ascii?Q?Us/dANNKc4qsWALdIYsG5cyFu5+6lMh4SompcJ2jdnJQ2zKoGMux2lOW+wiO?= =?us-ascii?Q?zQXjasE2fnJS19rZ3dRvF6ha3eK4U5rs1CZPso3rwdblpzkew+ScDIdxsial?= =?us-ascii?Q?3Njn6WzKFggARqLHtvlrBUJulMFVlvEMJoGIjNJ2Z209QQnJL/gsSmAquHJz?= =?us-ascii?Q?KmXRkoFr311xtMIaNj8oeBcrPYLSSxtCv+R89ucQ/NLakIIaXTHK1POrpeVQ?= =?us-ascii?Q?hFWqF7qSaiqGv+7AJwOyOvN6TiYyHebhyPTeygreZQzcoyz89SazCTD9GnUA?= =?us-ascii?Q?2CCaA4dBuPIzjQNJ/RHjaDb/zZhdxCgmW3wr3gADIkI0P7mPdzYKtBY2xJwK?= =?us-ascii?Q?nVLrq66XRvygHyny0eOwRBR6XxBAObGK22ZgFkzt8xFwGu/7niXs84mPQmqP?= =?us-ascii?Q?BSjU62EGfg=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9515fd78-d4d4-4507-0b3d-08de73f79923 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:53:59.7685 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: igmq6zmteWLA/I9P1Hnq2H1EkATmXId1mFSKLaSeJ228sOiib9MBWoIKN97r6RH60N6hdHfCcVKcyOKUK9p1cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add virtual address range tracking to the VMM using a buddy allocator. This enables contiguous virtual address range allocation for mappings. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/mm/vmm.rs | 98 +++++++++++++++++++++++++++++---- 1 file changed, 87 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/nova-core/mm/vmm.rs b/drivers/gpu/nova-core/mm/vmm= .rs index 0e1b0d668c57..d17571db2e2d 100644 --- a/drivers/gpu/nova-core/mm/vmm.rs +++ b/drivers/gpu/nova-core/mm/vmm.rs @@ -9,19 +9,34 @@ #![allow(dead_code)] =20 use kernel::{ - gpu::buddy::AllocatedBlocks, - prelude::*, // + gpu::buddy::{ + AllocatedBlocks, + BuddyFlags, + GpuBuddy, + GpuBuddyAllocParams, + GpuBuddyParams, // + }, + prelude::*, + sizes::SZ_4K, // }; =20 -use crate::mm::{ - pagetable::{ - walk::{PtWalk, WalkResult}, - MmuVersion, // +use core::ops::Range; + +use crate::{ + mm::{ + pagetable::{ + walk::{PtWalk, WalkResult}, + MmuVersion, // + }, + GpuMm, + Pfn, + Vfn, + VramAddress, + PAGE_SIZE, // + }, + num::{ + IntoSafeCast, // }, - GpuMm, - Pfn, - Vfn, - VramAddress, // }; =20 /// Virtual Memory Manager for a GPU address space. @@ -34,23 +49,84 @@ pub(crate) struct Vmm { pub(crate) mmu_version: MmuVersion, /// Page table allocations required for mappings. page_table_allocs: KVec>>, + /// Buddy allocator for virtual address range tracking. + virt_buddy: GpuBuddy, } =20 impl Vmm { /// Create a new [`Vmm`] for the given Page Directory Base address. - pub(crate) fn new(pdb_addr: VramAddress, mmu_version: MmuVersion) -> R= esult { + /// + /// The [`Vmm`] will manage a virtual address space of `va_size` bytes. + pub(crate) fn new( + pdb_addr: VramAddress, + mmu_version: MmuVersion, + va_size: u64, + ) -> Result { // Only MMU v2 is supported for now. if mmu_version !=3D MmuVersion::V2 { return Err(ENOTSUPP); } =20 + let virt_buddy =3D GpuBuddy::new(GpuBuddyParams { + base_offset_bytes: 0, + physical_memory_size_bytes: va_size, + chunk_size_bytes: SZ_4K.into_safe_cast(), + })?; + Ok(Self { pdb_addr, mmu_version, page_table_allocs: KVec::new(), + virt_buddy, }) } =20 + /// Allocate a contiguous virtual frame number range. + /// + /// # Arguments + /// + /// - `num_pages`: Number of pages to allocate. + /// - `va_range`: `None` =3D allocate anywhere, `Some(range)` =3D cons= train allocation to the given + /// range. + pub(crate) fn alloc_vfn_range( + &self, + num_pages: usize, + va_range: Option>, + ) -> Result<(Vfn, Pin>)> { + let np: u64 =3D num_pages.into_safe_cast(); + let size_bytes: u64 =3D np + .checked_mul(PAGE_SIZE.into_safe_cast()) + .ok_or(EOVERFLOW)?; + + let (start, end) =3D match va_range { + Some(r) =3D> { + let range_size =3D r.end.checked_sub(r.start).ok_or(EOVERF= LOW)?; + if range_size !=3D size_bytes { + return Err(EINVAL); + } + (r.start, r.end) + } + None =3D> (0, 0), + }; + + let params =3D GpuBuddyAllocParams { + start_range_address: start, + end_range_address: end, + size_bytes, + min_block_size_bytes: SZ_4K.into_safe_cast(), + buddy_flags: BuddyFlags::try_new(BuddyFlags::CONTIGUOUS_ALLOCA= TION)?, + }; + + let alloc =3D KBox::pin_init(self.virt_buddy.alloc_blocks(¶ms)= , GFP_KERNEL)?; + + // Get the starting offset of the first block (only block as range= is contiguous). + let offset =3D alloc.iter().next().ok_or(ENOMEM)?.offset(); + let page_size: u64 =3D PAGE_SIZE.into_safe_cast(); + let vfn =3D Vfn::new(offset / page_size); + + Ok((vfn, alloc)) + } + /// Read the [`Pfn`] for a mapped [`Vfn`] if one is mapped. pub(crate) fn read_mapping(&self, mm: &GpuMm, vfn: Vfn) -> Result> { let walker =3D PtWalk::new(self.pdb_addr, self.mmu_version); --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010042.outbound.protection.outlook.com [52.101.193.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC0953644DB; Tue, 24 Feb 2026 22:54:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973658; cv=fail; b=qichnnLO07Z7Frr9U9sCWrPrjrFWFZ1Pvb8zYow49boIXP7OPjPL2eEfR4FOMfqdlmMRfAso57SeJRqk3tGfw2K8OVbkCXgsvUiachtX+mUtfdP3CQXTVS3Vqq53ZUfdyxDAb2intcMMn6SVSJpfxTfc0XNquF1GZ/jWwGRIkb8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973658; c=relaxed/simple; bh=OklWL0xXcgKyhzGD/FeBkjcIiC7dbh3HpokwYCU0YTk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=oR4yJJecXhz1MbU08c5FnkfhsQETtLfEW/m+N7QrQrCX91qrU6SqbYQjdqTT3tXxb4GBkydZ8MUOtYmj9VLOn3t3DfGPOkyY8+BSDDxIo2pW91calA4lpbTI3RNkSmB7nZHGoI8uo7ahpQk/+bnflLQ8MmHYoD6R9l7ZBPDveMU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=TSmEH7QQ; arc=fail smtp.client-ip=52.101.193.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="TSmEH7QQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TK0RfMqBtUwGL9DmggWr3A6jEWg3ZrCuOcWyhGNriMzBSbD8ZtBEKX1/RUyRuc7liC78EsaIxXvOGqnbbHqvIfDHWCtzRuU146HtwITae4rGqo8Kx8OVeIGOCTcO93xIB0U+HX1Rt2zUiI6KOQ9WkkBHAtRohIdNPRbi1SNJaVIAI4v2ZDkJB/Pb9ZQbxOt43Yvmc4liXY2I5CXgIJMC9TBldDL4bO3PnveCrhjQAzpE5pL0DIKAVSuBZbP9mTG48Y91+p9U6xc2IIrMfpsofNrgUGpZfFrOJy9Sw61Q6JmIe+DPWzMpmSsxU4z/7phSPQB13kwQyeLDAedeakhDtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tvoPuuAk4T08gQqfNr3gEr3D//32V6IP7NsXaKrdloc=; b=OnuAbHeYnO7pxPU7d0dTv/sxfZIUndO2EwNIjAtzCU/9FuF3j9eIis6dsHmndwb0RYuU98HYX5AzLRmc0yCTLDsfKIv+XNHXtzupeVp8RYBx4bQs03zh/PKXmB3iapISSVEUUaz654fjEulXFpE5eUnt1zCsD2UwQAoAI8oWt+SVhRzdi0T+X00n2aCNzaJnsL5oRUeO4pyRmO4KOcNZ8b1LqK2Y6xIVAtPrPLEC2DrxdtQKQF7M+kkJiJtkWUnJrqFmznOu4chDt5hReUC4m1fvnhVts/GE3aBmErtOzj0S8ePizXe6nWeidyokkvqksUozNM66TFNaYswaZoTU0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tvoPuuAk4T08gQqfNr3gEr3D//32V6IP7NsXaKrdloc=; b=TSmEH7QQfV5SOkMVIdx1uZdlaE2udI0KDxrJ2V3JUeI9k2t7GqEKwsFZqcQbT8dfE5y2v+HyMyN3xSVn9qymuikm6kRT8AnDd9TFPBG/T9as+pdFyHiFbTtEzPA0IikM2CWMW9iyuMo/3a/R47CGDzkPHEk8VbwpUbil7T1Q9P4XENRTNxwpkYfZ6KqVcw4z37rtjyMUzX2HXJK2V1n+XrScf0vbQKdUl9s/32jvDrcLl+SAlX6pus/RSc6eJ4oVIU7tMCSzbqBPiJskzMUqhEzJKX4C9QhrMyj+plMlXdUhRBlqm2B8qZZW42Xh0/TxdoPdukRTiIWiQg1xwyjoMg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:54:02 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:54:02 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 19/25] gpu: nova-core: mm: Add multi-page mapping API to VMM Date: Tue, 24 Feb 2026 17:53:17 -0500 Message-Id: <20260224225323.3312204-20-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR03CA0011.namprd03.prod.outlook.com (2603:10b6:208:23a::16) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 102bc7b0-2c9d-46e3-8d01-08de73f79a05 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?z1Ow82I+80kBHSPSmgNMag29BUCHusSzgbhUKjfR9YETUVcXNmAIwDSOvBf6?= =?us-ascii?Q?h3FEHAqn8PKRQZ18THsAdHiNbA6MfScoTLufPQNDaYkdysw1IYf+50tQtSsE?= =?us-ascii?Q?j2GbguDqlBmaGwZR77mMcLA/s04Rt0v9ncpQZ683JmZZTBCyaHWR/R65Jvph?= =?us-ascii?Q?6rPwFRmao78kky9bHR0xNmzRwbWaR2FWKDA88l5QYiyYUAOOBGJRgU8Y6ImW?= =?us-ascii?Q?6hXJfb7Wk0sVvcXiaPK0jmc8sqdehrEUpxsb2uSG+vETQ04u9Ap2sKcq9Pvv?= =?us-ascii?Q?k87Bl14566xSgGujHVclsQtfkQpjsg/sDa7wsJzF/4z6jqfoX+CMoOyz6XAf?= =?us-ascii?Q?XlYOi1A82Je0JQ2Wgq8CHW3O0Nd9XUUVCMqTiWREOc9mjcHXi4V4dUUbWtoP?= =?us-ascii?Q?zZkhXzFrqo/GwmT0AwgN2dtLQFLGEUnaYEQFbm4mviDvxzOtIATZoVvMXrbz?= =?us-ascii?Q?WX4QjsPjjNlSnepF/l2R8lLnNLWyPsKxRSB0DvYX3dj/SVhWfxcUKVPa5AWL?= =?us-ascii?Q?nf2vZ58mHTFM7XqX16fHREYvgTgSqzLke98vKIllzDe6ZZmtFugiVL/kypr/?= =?us-ascii?Q?lv+PD+huZuy//ReH/L0xsnYbXj+MENjyfpLVaT7quEvPmeNGXHVKk0wGM8n0?= =?us-ascii?Q?+3KLE74RsbqsRecN1MUsymxcjav5hdHbKvbdoVtC+uadBxgaFNLnrBFcid63?= =?us-ascii?Q?y+gXDwDFOv1fGhksFQtjGJCdrK7rkM6ZTKfJyd/fXLsv1uezDMTO6sZ4WZIQ?= =?us-ascii?Q?uYWUiIXhpTbczqdD3knxyGa0NmQq/g6yWzR0XpP7VzttqFpxeg37PkTgSmlG?= =?us-ascii?Q?+4rrIG4edmWhbBp+mWuJWCT6rQqQCkDc9d7D3tCa4LRtJBgsmM+iSKRgrOWf?= =?us-ascii?Q?PwSSdE7256PL5rnSXsJde1lnxl3818ju2JFw6V0gUlqfq0QEevEM1k6hQm0t?= =?us-ascii?Q?R80EDT4bmZHB8Dl5vOg9AN0CMjUogrEtxY9MWdFPEVre+kqjMQM9VnRgrGnK?= =?us-ascii?Q?E7sg+nZtPm8VxoU1r7O6mhuPDP3/64HfhipHnqpohflcsGQeC9l7X+yidad6?= =?us-ascii?Q?rTDj3LIYjAXZxr0c0PIYUtOYVU0+2qiUaLZrV8EMNj25gZ5cBSO2XWPY+4iG?= =?us-ascii?Q?vcwmTMqJ6Xo5tqMe//ACe9V+R0rtFxZQTX8m3u8NMwGLhKEHbU2gZG+EHx0d?= =?us-ascii?Q?PgrSc7qDlt18ibqG1q0bE+gZiRidHYc/Efz41qBUiP8vnZZlLi9yJEuiJNv3?= =?us-ascii?Q?UrZ6d5/MhTG6ASaFGSQnb1cuLqnvHRDjp0FcnAbAYWse/BvtS6uRkO3H/GW8?= =?us-ascii?Q?ZWkVOLrV7tOxHqAUrKJRDscoQj7lSrEEu0+Lv1hry6X0U8gV8w1lpuuSQsaJ?= =?us-ascii?Q?WL2z9MZE/kvZGayLUsagCKx7FiYe7QOeiCTDZF1MLYq4As6cPEk/QHnGL1Na?= =?us-ascii?Q?XpfAuwVfCQY7FO4fsakAiSEODTuZA64+Ufj1ywEkHbTwkOQPayvom1QKnNe9?= =?us-ascii?Q?tTc4pAO6bS5vtWQP37SaelIZwsyJSUdZgNiU4BC+k05RjErJwdB3dBC53Xgj?= =?us-ascii?Q?IQWD3XGksX/FbhKUVTc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Fk9YD8T9G9Xlzsw4iN2S03AQGKMxeurJ0fC8ET7qxafWRMUr7ktaffMd43ce?= =?us-ascii?Q?ft2+RqDDItDkssJOeM5REf0IPktjdKAc4egxeqhq6WrunU+4Rojxt9ygxGOw?= =?us-ascii?Q?a91VundvM1nwOgggIIfPCxeUNLTJwXKM8tpfgBgdB3QWQoRfUQlFFmKxV71u?= =?us-ascii?Q?ip11nxuQCFaqLGRECgk49an9fRaQGPaRw27nNt5S9LO5O0L1+OItbuKHqOsK?= =?us-ascii?Q?UKXVPYKWaVWk9Tfe3RFxQwVHu4WU5/FUtRjAd4jWJxjFiPsx05d4DUwSkrba?= =?us-ascii?Q?+eZjxFGIiC0QgUWHWl6r1hFsdRXBrHEH5oFwivh9C477Dmk3Ur3W4n7OldgF?= =?us-ascii?Q?mK+W0Hzh1OfLlc2rAQ7fK+8FQEO731CGw1PFdY++4y8irZky2KGBo0Quxg9Y?= =?us-ascii?Q?5bWSJhNRnQvYiZNqat/FT6u4bz+eVOuLJWA9XUMrBLTL48dPAnLmOspT/Zyd?= =?us-ascii?Q?oXpy041iCyenOXeTmZCbX+XdPJdWb0YhRfYAnulO+ZYMKBEdhmgyJy+zs6ND?= =?us-ascii?Q?CKfxmu/wW/j5veBAyZtXynSOgn5ZK+TIlGjHCy4/RMEwE9F/PI0xMu+zC0kJ?= =?us-ascii?Q?nwdCAF1jh6o3ZmjBcKg/E2XGUwIFAYL+37yKspGa5qU2Qq1zA3FtQ1HdzIqR?= =?us-ascii?Q?FRKDNK0uKppp+voWggoGoMDOondqd1uRPY4RMqjU58hQXNBMZKyDXsVXN0jF?= =?us-ascii?Q?W+vivT90BTTbzqlNZKN24jcNddTtBTLxBUBtk8la4SmpuIb4ktm4w0srthKP?= =?us-ascii?Q?WHyK/rjio9qiDrOs5khMsVyRAYRh3EeFrzcLSOxvJ44Xqn4IYGMKlvAqQnyX?= =?us-ascii?Q?pWY9zRxRebkKVzwmtpyXynJaDFv1ejWjLWRV4fvlRmiuzIBAs25wrGO42ay8?= =?us-ascii?Q?hLu1e018UmO3sieCobTSYo9OmmbBvizw2XxIMZu17bC5IAIsOXa9i6OcUWVX?= =?us-ascii?Q?a5DkXpssTNkgLFwSdth8P5T4AxNfbp5BefGGmBcn+JNK5DuHyiWAz0Y7ZPeS?= =?us-ascii?Q?5qKNDPwzWbBwmgn+TIdBczs78vcyK8U9TcNxfumpGpKxE6mIRIjSuuQglzTy?= =?us-ascii?Q?OyoMSL2LGSrMUIYQqaWVjOzCRHRay8HT9xwt8y0hXZZ3+d93fIsr9bTa8ck0?= =?us-ascii?Q?qj7zBkt++rlHZdv5oyLAfZq/tNsf0lF5B4hkdXemMRkdFNenl62PA4ICmEix?= =?us-ascii?Q?R4nYExOYWXkjd99gaQrg8J6d28RwtJISn2/joe6YHx9dxp9P9mSQLRzdQr2y?= =?us-ascii?Q?+JpqMJCpKaHOgdavpHeAnGeXBuDzjQCe7BUM+QbhYEBpKAuSAjfAHPFKN8t7?= =?us-ascii?Q?y8IYt9ckNkl0sPHzfWBml5oo3xMpLXvOe6X8dyNREWjBA6PBnNug1d/T5eKC?= =?us-ascii?Q?Xy3z+/7sbXfZkHx9HSla/dB5xPx6+UUIP5W3c1H4pJT4e2Py15QJMhHSfS/V?= =?us-ascii?Q?Nab+TUUcyeCUwr2cuy+3ASWZeUIVbiK+lkO5JHb16O5+7i48JKUCPeyPo1WJ?= =?us-ascii?Q?NWPCesPNeK1X9Yahj6wwo1QLMmxprhP4QGpfnEIo4/CXxIcSnAOQIiQmsaFI?= =?us-ascii?Q?oBZ20erGPZZbLHo4enA1BZJ9t/bMbnUvJ9HOtnxLLrkbaMf1eQA8LZgnqT0b?= =?us-ascii?Q?DUzPcE3TGr/6cdmlTUrtxxyJfFnTiC1kVpT6CSHzNy/DEEVU23A9jCBQvMKy?= =?us-ascii?Q?EfIKQ0PId5wElLo4T9nEjZjq4Hgss/sY4/eh5HKWT98I8XVdXM88bysS5S2Q?= =?us-ascii?Q?o4Zm0uonUA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 102bc7b0-2c9d-46e3-8d01-08de73f79a05 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:54:01.2716 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SEYe+ta6uIcOu5gXmg6F1hI7xE+UQolHaJ+EQ2seq0LetqQAuE6cYaV74IIcNxW7KSNs/pbALHabiT86r8hxBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add the page table mapping and unmapping API to the Virtual Memory Manager, implementing a two-phase prepare/execute model suitable for use both inside and outside the DMA fence signalling critical path. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/mm/vmm.rs | 359 +++++++++++++++++++++++++++++++- 1 file changed, 357 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/nova-core/mm/vmm.rs b/drivers/gpu/nova-core/mm/vmm= .rs index d17571db2e2d..c639e06c7d57 100644 --- a/drivers/gpu/nova-core/mm/vmm.rs +++ b/drivers/gpu/nova-core/mm/vmm.rs @@ -17,16 +17,26 @@ GpuBuddyParams, // }, prelude::*, + rbtree::{RBTree, RBTreeNode}, sizes::SZ_4K, // }; =20 +use core::cell::Cell; use core::ops::Range; =20 use crate::{ mm::{ pagetable::{ - walk::{PtWalk, WalkResult}, - MmuVersion, // + walk::{ + PtWalk, + WalkPdeResult, + WalkResult, // + }, + DualPde, + MmuVersion, + PageTableLevel, + Pde, + Pte, // }, GpuMm, Pfn, @@ -51,6 +61,74 @@ pub(crate) struct Vmm { page_table_allocs: KVec>>, /// Buddy allocator for virtual address range tracking. virt_buddy: GpuBuddy, + /// Prepared PT pages pending PDE installation, keyed by `install_addr= `. + /// + /// Populated by `Vmm` mapping prepare phase and drained in the execut= e phase. + /// Shared by all pending maps in the `Vmm`, thus preventing races whe= re 2 + /// maps might be trying to install the same page table/directory entr= y pointer. + pt_pages: RBTree, +} + +/// A pre-allocated and zeroed page table page. +/// +/// Created during the mapping prepare phase and consumed during the mappi= ng execute phase. +/// Stored in an [`RBTree`] keyed by the PDE slot address (`install_addr`). +struct PreparedPtPage { + /// The allocated and zeroed page table page. + alloc: Pin>, + /// Page table level -- needed to determine if this PT page is for a d= ual PDE. + level: PageTableLevel, +} + +/// Multi-page prepared mapping -- VA range allocated, ready for execute. +/// +/// Produced by [`Vmm::prepare_map()`], consumed by [`Vmm::execute_map()`]. +/// The struct owns the VA space allocation between prepare and execute ph= ases. +pub(crate) struct PreparedMapping { + vfn_start: Vfn, + num_pages: usize, + vfn_alloc: Pin>, +} + +/// Result of a mapping operation -- tracks the active mapped range. +/// +/// Returned by [`Vmm::execute_map()`] and [`Vmm::map_pages()`]. +/// Owns the VA allocation; the VA range is freed when this is dropped. +/// Callers must call [`Vmm::unmap_pages()`] before dropping to invalidate +/// PTEs (dropping only frees the VA range, not the PTE entries). +pub(crate) struct MappedRange { + pub(crate) vfn_start: Vfn, + pub(crate) num_pages: usize, + /// VA allocation -- freed when [`MappedRange`] is dropped. + _vfn_alloc: Pin>, + /// Logs a warning if dropped without unmapping. + _drop_guard: MustUnmapGuard, +} + +/// Guard that logs a warning once if a [`MappedRange`] is dropped without +/// calling [`Vmm::unmap_pages()`]. +struct MustUnmapGuard { + armed: Cell, +} + +impl MustUnmapGuard { + const fn new() -> Self { + Self { + armed: Cell::new(true), + } + } + + fn disarm(&self) { + self.armed.set(false); + } +} + +impl Drop for MustUnmapGuard { + fn drop(&mut self) { + if self.armed.get() { + kernel::pr_warn!("MappedRange dropped without calling unmap_pa= ges()\n"); + } + } } =20 impl Vmm { @@ -78,6 +156,7 @@ pub(crate) fn new( mmu_version, page_table_allocs: KVec::new(), virt_buddy, + pt_pages: RBTree::new(), }) } =20 @@ -136,4 +215,280 @@ pub(crate) fn read_mapping(&self, mm: &GpuMm, vfn: Vf= n) -> Result> { WalkResult::Unmapped { .. } | WalkResult::PageTableMissing =3D= > Ok(None), } } + + /// Allocate and zero a physical page table page for a specific PDE sl= ot. + /// Called during the map prepare phase. + fn alloc_and_zero_page_table( + &mut self, + mm: &GpuMm, + level: PageTableLevel, + ) -> Result { + let params =3D GpuBuddyAllocParams { + start_range_address: 0, + end_range_address: 0, + size_bytes: SZ_4K.into_safe_cast(), + min_block_size_bytes: SZ_4K.into_safe_cast(), + buddy_flags: BuddyFlags::try_new(0)?, + }; + let blocks =3D KBox::pin_init(mm.buddy().alloc_blocks(¶ms), GF= P_KERNEL)?; + + // Get page's VRAM address from the allocation. + let page_vram =3D VramAddress::new(blocks.iter().next().ok_or(ENOM= EM)?.offset()); + + // Zero via PRAMIN. + let mut window =3D mm.pramin().window()?; + let base =3D page_vram.raw(); + for off in (0..PAGE_SIZE).step_by(8) { + window.try_write64(base + off, 0)?; + } + + Ok(PreparedPtPage { + alloc: blocks, + level, + }) + } + + /// Ensure all intermediate page table pages are prepared for a [`Vfn`= ]. Just + /// finds out which PDE pages are missing, allocates pages for them, a= nd defers + /// installation to the execute phase. + /// + /// PRAMIN is released before each allocation and re-acquired after. M= emory + /// allocations outside of holding this lock to prevent deadlocks with= fence signalling + /// critical path. + fn ensure_pte_path(&mut self, mm: &GpuMm, vfn: Vfn) -> Result { + let walker =3D PtWalk::new(self.pdb_addr, self.mmu_version); + let max_iter =3D 2 * self.mmu_version.pde_level_count(); + + // Keep looping until all PDE levels are resolved. + for _ in 0..max_iter { + let mut window =3D mm.pramin().window()?; + + // Walk PDE levels. The closure checks self.pt_pages for prepa= red-but-uninstalled + // pages, letting the walker continue through them as if they = were installed in HW. + // The walker keeps calling the closure to get these "prepared= but not installed" pages. + let result =3D walker.walk_pde_levels(&mut window, vfn, |insta= ll_addr| { + self.pt_pages + .get(&install_addr) + .and_then(|p| Some(VramAddress::new(p.alloc.iter().nex= t()?.offset()))) + })?; + + match result { + WalkPdeResult::Complete { .. } =3D> { + // All PDE levels resolved. + return Ok(()); + } + WalkPdeResult::Missing { + install_addr, + level, + } =3D> { + // Drop PRAMIN before allocation. + drop(window); + let page =3D self.alloc_and_zero_page_table(mm, level)= ?; + let node =3D RBTreeNode::new(install_addr, page, GFP_K= ERNEL)?; + let old =3D self.pt_pages.insert(node); + if old.is_some() { + kernel::pr_warn_once!( + "VMM: duplicate install_addr in pt_pages (inte= rnal consistency error)\n" + ); + return Err(EIO); + } + // Loop: re-acquire PRAMIN and re-walk from root. + } + } + } + + kernel::pr_warn!( + "VMM: ensure_pte_path: loop exhausted after {} iters (VFN {:?}= )\n", + max_iter, + vfn + ); + Err(EIO) + } + + /// Prepare resources for mapping `num_pages` pages. + /// + /// Allocates a contiguous VA range, then walks the hierarchy per-VFN = to prepare pages + /// for all missing PDEs. Returns a [`PreparedMapping`] with the VA al= location. + /// + /// If `va_range` is not `None`, the VA range is constrained to the gi= ven range. Safe + /// to call outside the fence signalling critical path. + pub(crate) fn prepare_map( + &mut self, + mm: &GpuMm, + num_pages: usize, + va_range: Option>, + ) -> Result { + if num_pages =3D=3D 0 { + return Err(EINVAL); + } + + // Pre-reserve so execute_map() can use push_within_capacity (no a= lloc in + // fence signalling critical path). + // Upper bound on page table pages needed for the full tree (PTE p= ages + PDE + // pages at all levels). + let pt_upper_bound =3D self.mmu_version.pt_pages_upper_bound(num_p= ages); + self.page_table_allocs.reserve(pt_upper_bound, GFP_KERNEL)?; + + // Allocate contiguous VA range. + let (vfn_start, vfn_alloc) =3D self.alloc_vfn_range(num_pages, va_= range)?; + + // Walk the hierarchy per-VFN to prepare pages for all missing PDE= s. + for i in 0..num_pages { + let i_u64: u64 =3D i.into_safe_cast(); + let vfn =3D Vfn::new(vfn_start.raw() + i_u64); + self.ensure_pte_path(mm, vfn)?; + } + + Ok(PreparedMapping { + vfn_start, + num_pages, + vfn_alloc, + }) + } + + /// Execute a prepared multi-page mapping. + /// + /// Drain prepared PT pages and install PDEs followed by single TLB fl= ush. + pub(crate) fn execute_map( + &mut self, + mm: &GpuMm, + prepared: PreparedMapping, + pfns: &[Pfn], + writable: bool, + ) -> Result { + if pfns.len() !=3D prepared.num_pages { + return Err(EINVAL); + } + + let PreparedMapping { + vfn_start, + num_pages, + vfn_alloc, + } =3D prepared; + + let walker =3D PtWalk::new(self.pdb_addr, self.mmu_version); + let mut window =3D mm.pramin().window()?; + + // First, drain self.pt_pages, install all pending PDEs. + let mut cursor =3D self.pt_pages.cursor_front_mut(); + while let Some(c) =3D cursor { + let (next, node) =3D c.remove_current(); + let (install_addr, page) =3D node.to_key_value(); + let page_vram =3D VramAddress::new(page.alloc.iter().next().ok= _or(ENOMEM)?.offset()); + + if page.level =3D=3D self.mmu_version.dual_pde_level() { + let new_dpde =3D DualPde::new_small(self.mmu_version, Pfn:= :from(page_vram)); + new_dpde.write(&mut window, install_addr)?; + } else { + let new_pde =3D Pde::new_vram(self.mmu_version, Pfn::from(= page_vram)); + new_pde.write(&mut window, install_addr)?; + } + + // Track the allocated pages in the `Vmm`. + self.page_table_allocs + .push_within_capacity(page.alloc) + .map_err(|_| ENOMEM)?; + + cursor =3D next; + } + + // Next, write PTEs (all PDEs now installed in HW). + for (i, &pfn) in pfns.iter().enumerate() { + let i_u64: u64 =3D i.into_safe_cast(); + let vfn =3D Vfn::new(vfn_start.raw() + i_u64); + let result =3D walker.walk_to_pte_lookup_with_window(&mut wind= ow, vfn)?; + + match result { + WalkResult::Unmapped { pte_addr } | WalkResult::Mapped { p= te_addr, .. } =3D> { + let pte =3D Pte::new_vram(self.mmu_version, pfn, writa= ble); + pte.write(&mut window, pte_addr)?; + } + WalkResult::PageTableMissing =3D> { + kernel::pr_warn_once!("VMM: page table missing for VFN= {vfn:?}\n"); + return Err(EIO); + } + } + } + + drop(window); + + // Finally, flush the TLB. + mm.tlb().flush(self.pdb_addr)?; + + Ok(MappedRange { + vfn_start, + num_pages, + _vfn_alloc: vfn_alloc, + _drop_guard: MustUnmapGuard::new(), + }) + } + + /// Map pages doing prepare and execute in the same call. + /// + /// This is a convenience wrapper for callers outside the fence signal= ling critical + /// path (e.g., BAR mappings). For DRM usecases, [`Vmm::prepare_map()`= ] and + /// [`Vmm::execute_map()`] will be called separately. + pub(crate) fn map_pages( + &mut self, + mm: &GpuMm, + pfns: &[Pfn], + va_range: Option>, + writable: bool, + ) -> Result { + if pfns.is_empty() { + return Err(EINVAL); + } + + // Check if provided VA range is sufficient (if provided). + if let Some(ref range) =3D va_range { + let required: u64 =3D pfns + .len() + .checked_mul(PAGE_SIZE) + .ok_or(EOVERFLOW)? + .into_safe_cast(); + let available =3D range.end.checked_sub(range.start).ok_or(EIN= VAL)?; + if available < required { + return Err(EINVAL); + } + } + + let prepared =3D self.prepare_map(mm, pfns.len(), va_range)?; + self.execute_map(mm, prepared, pfns, writable) + } + + /// Unmap all pages in a [`MappedRange`] with a single TLB flush. + /// + /// Takes the range by value (consumes it), then invalidates PTEs for = the range, + /// flushes the TLB, then drops the range (freeing the VA). PRAMIN loc= k is held. + pub(crate) fn unmap_pages(&mut self, mm: &GpuMm, range: MappedRange) -= > Result { + let walker =3D PtWalk::new(self.pdb_addr, self.mmu_version); + let invalid_pte =3D Pte::invalid(self.mmu_version); + + let mut window =3D mm.pramin().window()?; + for i in 0..range.num_pages { + let i_u64: u64 =3D i.into_safe_cast(); + let vfn =3D Vfn::new(range.vfn_start.raw() + i_u64); + let result =3D walker.walk_to_pte_lookup_with_window(&mut wind= ow, vfn)?; + + match result { + WalkResult::Mapped { pte_addr, .. } | WalkResult::Unmapped= { pte_addr } =3D> { + invalid_pte.write(&mut window, pte_addr)?; + } + WalkResult::PageTableMissing =3D> { + continue; + } + } + } + drop(window); + + mm.tlb().flush(self.pdb_addr)?; + + // TODO: Internal page table pages (PDE, PTE pages) are still kept= around. + // This is by design as repeated maps/unmaps will be fast. As a fu= ture TODO, + // we can add a reclaimer here to reclaim if VRAM is short. For no= w, the PT + // pages are dropped once the `Vmm` is dropped. + + range._drop_guard.disarm(); // Unmap complete, Ok to drop MappedRa= nge. + Ok(()) + } } --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012064.outbound.protection.outlook.com [40.107.209.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04F26364056; Tue, 24 Feb 2026 22:54:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973656; cv=fail; b=kEqd29tDwatRCjlkzZQXqDq+TCf1JYQeugSVN9v0tsQeHqitB03Jt/NYVERsJowTypIvzUFEku1BHfCxWc453Ri20PX6yD7oZDhSzwuED5J92f/jG3mJJV4RftXIyVvuBig7uFq9U7gsHaV0eGtaIj1SOAXWuB1ZzGBJXjJD6rw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973656; c=relaxed/simple; bh=Mh71EpyX1s75Off9YNRm/JhfOmaEAkhijWu1IsONjqA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=ib2V5cN/PYk2KZAajm1znEmTYjv07tGu1zAsBwVjB3i43tCdUJVbYIorMMrdiOvczL+Y3Oh/8S8DsPbOhRRfGsrYuugFnBM1XvpJ4m+g49d3ivbNd1G+/VAxfX/oPwvoUkgcP+s8VyhmwWoNOiB675AXj2NSOGiNSeCJmuahf4E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Qt9aKpJG; arc=fail smtp.client-ip=40.107.209.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Qt9aKpJG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tL7OBOKeVCKJUFhVOYsKFr9RhzewEDC2J00CVdBLnYZPOqmvbQqgvAfju8IJ1ZOkEnaQg7ca7N7wcCKceCOokjk7mCJN38mCo8gSMzVLjfgpF9hXBZzIuWSIxVPGoAu/ovW8pH+8d2NWY783JeOiLOSfyBemGEMU0mn0oqQt2NjM4y+Emg3KlxNSEfQMAdBc70TiB9GnDzqC3PXUnOmXN1RlvdswkbjERtK3H5zCrb17VuLu/uw/jSHVkDfNIKF1ETUij6TpjatmzXyboYU0iVBk6uCKnstaUYnYh5fLofnILzv/1n9Bjnsf2fPlR0YG72lt0Q+dRXzX3BoDkNe9/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wRLvMC1d8ZGSqanoXwzTAst8Iwx3wmTxtQ+nr9leKHs=; b=eLvEwm2faO5x46Dmrxay/4qYVmvTuwYDh13saKO3V0Mz2jlwAnBfvkflVoadQ8hKD/QyKDn2lviXYO5/Q4p6FJlehKm66uL702X5ekx4iSBAf0DgqrlbTvsFq+KxqIW8s5AgQyem/vyHLypAXpq04iBBLeBNMHuCtIWIldyqenGa8umbeGKnk3p7LnFRqcZKmPDQfXEQsrMdc9YLfGDtXlN//geDzgPojX8iNt0asEHVmdzYuJgvkhSQjbBFcNysvQKaF65KUlx2vJ2nyjve2Cyk7YD9iWWhi71XCAgnRBxfAwUb5mEQRkf9uqrFtNlYQ3s+bM2P6WHc0AUjSFCqdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wRLvMC1d8ZGSqanoXwzTAst8Iwx3wmTxtQ+nr9leKHs=; b=Qt9aKpJGdzMRMN3UFkkjdJw3t7gs+lidM5/GvtCLMc/GbuhkLdgNVcvJkh3xpZY/NCtvo0bdVdEzawlEDsCf5apV15Czwjj+77TSO4ItKhJPZqtDIG9H8mh26VAmNeXOFqoR+zWUBPAJtjbGIr5fcR4L95IcOlajQac1o15EgtzWvp14xIIktaY+NqX3srWZhS2+GBsxL4C35NzqbvEghIf3rsB5haFrJXbG6h+K7gDzkrjHOrWS2twkWQU3ufVVm6ugQvUrWty4Qw5K0o2GyBxK5Omv7rAsJEaL2zOgeI3VkacslvL9VUjnRFGhYEAYtVDOH3UoDJwuFip3cVw2UA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:54:03 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:54:02 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 20/25] gpu: nova-core: Add BAR1 aperture type and size constant Date: Tue, 24 Feb 2026 17:53:18 -0500 Message-Id: <20260224225323.3312204-21-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1P223CA0031.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:5b6::6) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 2da57846-b251-45db-4f06-08de73f79ab7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?GaKtzA+g6LmnrDbSRmfOGPpjzEjSUAz3n3fN3OXVVhsMmsXP5K7bq59P9Z+h?= =?us-ascii?Q?PknJQhW15IeWnk3SYMGE0p5x3RzW31eJM/5g4Jgnq4LRdGGUZQZo7xkttMN7?= =?us-ascii?Q?WiVs5Xxr52Q4NO7fazV5PcZont/rRVtwsTZsbx5x34Q2Z/YanD09zRkq04ux?= =?us-ascii?Q?7VWUDaNFz+sf1/oUw5w5PyJKU0O5ll2giMZJEl94iQ+1Aoyob/Ip4NJzQRbc?= =?us-ascii?Q?qCcQlRe3cZwDxXfGEyWCrb/+C6qkCN14lZ8ewqCZmhE4DOBxT7C6o0GWzcj9?= =?us-ascii?Q?m01u9SPXoxajP8p5P5c/VcxqhIKc0JhsyEnviXeJerqyhArR2+gkiBfqo+kv?= =?us-ascii?Q?eYaRz8DbAPeQfwlZLIMuYVH0pGK6gN5hIquzbkdDeXekcBmNfLHs725w9meH?= =?us-ascii?Q?ZqwtXIqgz/wsVJLBx72HKtpUXrvNYN4eVyt6gpVPS7DJnHZ0KXvJTPAVT3mt?= =?us-ascii?Q?u+Z7TF7/ZicZ6i6+UvPk7ylX9P577/TBCb01lYYeJgSNp6VJcn4/MtZREv6t?= =?us-ascii?Q?+EiGQmjrDG3VXpiOcZ/Cg1W+lhcU0COgPxeAEXWm+nvcT6A4PqW0vcGCG5c0?= =?us-ascii?Q?HMz8tHcedXQSX3S93qLIVF3zKnZl346APxZiy27kTCpbb0TfEiFBvIwZY+yJ?= =?us-ascii?Q?JIqJtVo4Qdd7I58K2bvekQBUtC4vTjj0l7CA4M6vVamJxx4ecofeHedLbpvd?= =?us-ascii?Q?9XWGuOQBp8haSQXFvquLkqkL9i2SdVZLmHFUPUcB06L9RD2yUu8harYIYv3q?= =?us-ascii?Q?/OjdYahbHkMDYcTO9jAUX1pifNmbgYgz5XhVls9i8rENXdk+4HqzLaEWhH7L?= =?us-ascii?Q?UCnw90vTzPi/oZm+wPocgGzt6a6BGr/AVz0NuHKuPNRxU1YV33YuhvYwN9SB?= =?us-ascii?Q?ug0Wi5iwJCc03163FzLFZeL7EJWrFh+bU+zsNTnvIZEFJS62HV9XXI/VxdNB?= =?us-ascii?Q?XO8TzzZ6v0kTNI/InqYnkvXaal9Eo68QFVOe3dnuVMO7Wunh0nU7xzL0nEPh?= =?us-ascii?Q?gd0etkJN+D09yLcB9zJh8blydpMXJbsFSyMdnNyoNhLCr+jyWQTbcH9o/iLT?= =?us-ascii?Q?zZYOF50sEMKpp1ucgxRstM5tus+B0r323Uy8SVBEEbPeRHx75YUmT8h9x9LF?= =?us-ascii?Q?Kr4hvU1eeNbh5iIMIClOAfmumE+0w9LugbVMVsRb92cPDI+mOdaQebkUrG9M?= =?us-ascii?Q?HYzisEk+RIbocwaCgSsOm6R3E4hSrAj1JmKI4b1fG3ThFVr5FB268VjX5tJw?= =?us-ascii?Q?4SDxyq7Q8zuvfTIT3+xZE2uh84raxlm/ZN1AyQLpyZP6ZMOVWN/c3f6fa/N5?= =?us-ascii?Q?RzO2cIPo1W/M+f2eHlXN8IyKNusVGnm+CuTdhqps+6CzGqKq/mGKSO4HpkIl?= =?us-ascii?Q?QYs/C4op3l12l/rzlyilEiBBlyG24zswCuVZRLEYgXClO0ux5Ozfgng76YQM?= =?us-ascii?Q?9ybxKADnMbX2BwRx+Qj76RwsiHgXihintR6he9XaUk9lo4rB57vIYpx02xP2?= =?us-ascii?Q?x5p2Mbfq5IazL2revAQ5iN3EsQflEk6cKcla8IrUWo4PiN5NqRj2OYc06N/F?= =?us-ascii?Q?zVs4TPHF7zTE5z5LOh0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LsN9o7/RjSiBXz5K3Xo2gD5rneBQEdxXy9MomXUBUoOlI6/0Bt1wErO5pa7l?= =?us-ascii?Q?PXiEKiZchAQC2z1MbgXA0esWsu8DpnY2CoEOWTCaQ1TvXo5rCX0NBr2ByKJn?= =?us-ascii?Q?r3+8cTZGypc+NzvMnYLwQpjiDE9zOdoW4RHBhkQ1hZP9Zv/wVvq0gX5wrvu4?= =?us-ascii?Q?LDughhIoSBpOMkpJlUZY7Ub+IUmIHoKPG0NfVcvUANoIg9wyT8wKF0MDADzp?= =?us-ascii?Q?dJFEd/9yFZq0mCCYmUU3PBWVNJsxPvymyumAIBKJr8XJ47jhpYoGCNH9lvry?= =?us-ascii?Q?0b2HNlVuzyq7JRnM42apMzW9RGXVpo9T4QSRL7cor1vzbzyAIGai9ogGCX7q?= =?us-ascii?Q?vqKASbzVIvk9uMYmWVLFkgDKKvm5FepWdIPHLADbj+clOss9r096WFGijQ4/?= =?us-ascii?Q?f8jsFOFMwUH9SwGnWWkBBfwLCU1QPeKCU7aXK316XVTCkUnAgNmWxlfbVNtO?= =?us-ascii?Q?ZCSXVCe4mA7fnXsz+cw8eBKZFplRPibrk78uSkO0kZyLTZSanuNtsf9ndIon?= =?us-ascii?Q?ivBPZHfAc4c9VFh7d0Og0D9MXCD5uY8v0aXOollB7xsEWKKlgXoAGTI/rASW?= =?us-ascii?Q?VvZwkOAsSgs7ky5Rpip+1xIUasrHfM5T5tr3q75jkJ5QbJyGu0CigIAR/u8C?= =?us-ascii?Q?GePgsPe/X8P3U7U2LOxsnb8CgoZMatce90okW3mfcoWBb+M8WQzLj+q9oQKc?= =?us-ascii?Q?vHkFYrsULSeeufLbT1CbceBlfNXLGUBCQ91BMGXTrW1NRVkAbNnqZ6YFsH/h?= =?us-ascii?Q?l6wWuYsdSKRoDO9Q8Vl1WXqZvtCVZgvDWtFGqT8qfSJpiXLuTctDqoB9jsW4?= =?us-ascii?Q?m11f6i3wLPsA/fUFdPOlbmvCjgwzP/nzIKsHZSWd7YWO/1OxhszIk3qaHsKC?= =?us-ascii?Q?N2FJ5gjRaoJPUDcVjTKj34LdRDwnFGCTsZ7uDI3jPdbEzVxdlPd4OW/MNa6F?= =?us-ascii?Q?a9fKoO3vswNZvyfg3Ttwg8LjqL3rtcTrWbzHuRKVzn5xJr4rIyJC6m+7Gj7N?= =?us-ascii?Q?HhHYJlMKk/Jc9JNPTjm3ErC9mxykJgp7QNCmDyDlXUgOxkI2+9J/Q2lhYgOD?= =?us-ascii?Q?PUCWT/vPh2wuYwlGaG0YmrKsLbqiNYSNWxetWltgTtTARW7sLtsKNRlvaOAX?= =?us-ascii?Q?h6X/6OieOS98nAi4QCOfexAe+fm+B8Py94Gojo3KxcMbR6272dzp0KKRbDDF?= =?us-ascii?Q?MuHzRmlP56sA401lbPoX2MLlhmAAS2Vjh8wJn5mJlCzmtZTQEBlwcmk38OzT?= =?us-ascii?Q?6GjMnv0+qA6N/8dpgaAmwckSizkC8jLhfJd74qN6TO8Hv1k0sJWM0Qb0Bkpl?= =?us-ascii?Q?r8HNARVrji4Ftp+zCX66+txlsMwamsTf/ueD+S1qfVPw7c5ppyiu/9J7i863?= =?us-ascii?Q?oWV6VAPmcn856h2fC6e0u97ZYN4gLuMLIB2ssMbRlAiSHu9XM+6zcjYQHtUL?= =?us-ascii?Q?n6WcqnawiCV6GnB453z0YwdBBCupC+Nwcztw5NHdKtfesx/jcrQhYk8ay38g?= =?us-ascii?Q?P2RDofa8lFMFpTvGlmhHZXupG2oqtUkRn8Irgoe/vx1ZK/zjt/fA9bZ3Knnm?= =?us-ascii?Q?TeE7fJQyjZ8SI72wo0uAEiWydiD2u06SJZo+wyeJCUi3VA1U25dxDsR7Oc7Z?= =?us-ascii?Q?OgjuDrLZ+bsqFZqu6Vi239CU9mOn6wbC7/Iw2dhmlYni/SWUP1zi5qmi0GAl?= =?us-ascii?Q?WIi8aNXpeXHd2MZWBZmjqyk8WMvFz1jpzdcRp4QyusOTEVlt/wLICBDrYnQ+?= =?us-ascii?Q?cMFCqyH+qQ=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2da57846-b251-45db-4f06-08de73f79ab7 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:54:02.4123 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3AO3VF/Siwc9/0UmtmBQ3US4c3TB5mFruDNIasHs5uVaXJOWmSF+urnAvUH/F2pZST2oIHhkwzNUjqDGX66kRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add BAR1_SIZE constant and Bar1 type alias for the 256MB BAR1 aperture. These are prerequisites for BAR1 memory access functionality. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/driver.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/driver.rs b/drivers/gpu/nova-core/driver= .rs index 5a4cc047bcfc..f30ffa45cf13 100644 --- a/drivers/gpu/nova-core/driver.rs +++ b/drivers/gpu/nova-core/driver.rs @@ -13,7 +13,10 @@ Vendor, // }, prelude::*, - sizes::SZ_16M, + sizes::{ + SZ_16M, + SZ_256M, // + }, sync::Arc, // }; =20 @@ -28,6 +31,7 @@ pub(crate) struct NovaCore { } =20 const BAR0_SIZE: usize =3D SZ_16M; +pub(crate) const BAR1_SIZE: usize =3D SZ_256M; =20 // For now we only support Ampere which can use up to 47-bit DMA addresses. // @@ -38,6 +42,8 @@ pub(crate) struct NovaCore { const GPU_DMA_BITS: u32 =3D 47; =20 pub(crate) type Bar0 =3D pci::Bar; +#[expect(dead_code)] +pub(crate) type Bar1 =3D pci::Bar; =20 kernel::pci_device_table!( PCI_TABLE, --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012064.outbound.protection.outlook.com [40.107.209.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0B9E366069; Tue, 24 Feb 2026 22:54:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973658; cv=fail; b=d3zV3aoQerprVDgE465vPqM6gaMEVnDz9x7a+WYlwCPAmKkPJvUMn1NtBH7fa5wElIc7G8qAUKaEVnkBxYN5ksMvK4oJ7zEXd+fApbHOk0bqb8Mj1Sfc/novKB8bOdQgHqJaShZQqxZVY3Djw2JTAnWR8CvXIDv+SW9lIupgAXY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973658; c=relaxed/simple; bh=eqiZoz4R2QnOIcsEltfyJQMQ42xuEMFaAaF4RjykYJQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=K6KQd7k8cbhOv0DGrMQb7qL015szcMRyq1ajVFF1lKSuPvsdAs7tPrb6Wm2YicfEaq4ijZJMy1i8pgWgaXsiC/5Ly6lv/pRj/vIIFkSF3GW0HJlpCal6/iDWclPpcUc7b0PQzlpYwD+na+MCMbgPkMlJIBf364yf7y212HVO+nc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=MIoHxg2h; arc=fail smtp.client-ip=40.107.209.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="MIoHxg2h" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RAw2JPlY+GkINlThDXW4EtHQoi5P+IRAnrCOz4OTeyFo6NR1t5SRGQXcLl56WptcmwD8A2kBkOiugU4j2ud2OQQC2nF/c18TCAzq5sKJtn9eES2ifqbgW36oNvCsa9rbqakP36sVGGlbVPAjhaqgMtShychdkb0SExv8rRmvIEAnsSvC6cSUFT1s77rMf4ojR7B6zSDtyTAm3Gvzwe+cTsBaDK340BiLotZ6AuooC2m8BQWjW6lrANE/WvLBK0l4TW/oDVcO/8TGDMeGwVPQH/Qgy43F0lRkKOycyk/D14mbJn/Dp6Dr1Ro9CdtcDAmEUJejYk2CSkBKyfQ7uRI+Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KfK/pXk9gj7CZHYPuQ0xEvz+/6jE8AU0gSqiE0ShTwA=; b=mEZdsC2a4XKD650RxfwQylG12iwMpOuiAZdxxR+GgM3DtKB8co4KvgtB7EiTQYBo5MPUl1gQHF5kEAOk6MnYl1YWFafxc7kVLY78244wtAYWZDQ4GyditcK+TBVbvdEStu90zMMGyWQYx0mQ0Y3otJAd0JL28CX5pxJrpjFyL3qosm47ot0JzAoht0LcFQ1s9qDTQTjNC06MOwCCROXn6iEI06j4qoQCkLUbaN1Mw05g6fETC1ZI/ClYR8PCb9lbTMzE3gWXQrMS9aeITUtTTIm3YMpBaNXOlpfmHtcK4ZG0onx9F/5g3UeAlYQbzTDa9gexTo6b/s427sfmBv47pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KfK/pXk9gj7CZHYPuQ0xEvz+/6jE8AU0gSqiE0ShTwA=; b=MIoHxg2h3+4tWXiRcLN1Ub8ZLsAUO6ZH5EK8rOzsXIJrjagDAOZ2/utRii3O7wR39BXps2Qe7g/CrsT2ZlEoBaRfdvnWbqdQtmjISGqRwHnvrnZCphbkQ6QiSvbKuhnZZLMo+8Jdkof8sXPMnjF9l7DgkT5WYjRYKxroPkEGUvNgzcRsXxSIIVzoxmAriFPlqvXT/4XMnz4sYZZpzAfDuhPHWokW5/YVTyjzZrj7J3CVJwvoJVGRs+RtaRcjLGiGeL8Sg0gqLSrQxvDtcCwwjCt6zKVHVQnWKCc2oYWYJiYAmlWW1JCACXaOtHgR4KXTSps2JLSuQU2Eour0DzFfoA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:54:03 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:54:03 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 21/25] gpu: nova-core: gsp: Add BAR1 PDE base accessors Date: Tue, 24 Feb 2026 17:53:19 -0500 Message-Id: <20260224225323.3312204-22-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN0PR04CA0026.namprd04.prod.outlook.com (2603:10b6:208:52d::17) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 14187b71-6664-4d1b-a920-08de73f79b6d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?QEx/dwMIwscfeA0HCQ/X3GLOPAaVCm5vtrCvKqWREWlzAhEO3WLhqRS+K6b9?= =?us-ascii?Q?UZj7mINM2Po83YV5N1+P+6LNP5NonOc6ZxbfgviP6HS9geOQbA64ZQskXavl?= =?us-ascii?Q?hvwFBXTgWWOxMaf7TQ2UB1jgjBhNe1fmJolmpPS5l/0wra7Bt+SPjaTqNMtT?= =?us-ascii?Q?195+/2McWMJPo383T4iBoeLd3p/MIiKNxklZX1zf+yZbZzDYFa3c0VkI74xr?= =?us-ascii?Q?aquMQ/p3TvLqrQBXaAaYNZB/qWnarICX10UsHtsYiQM0jEgo0yukDB+/ylCc?= =?us-ascii?Q?U+U6xz5YH+9GuBpl14PKE/7DkMsjX3YnRPn1dDoRJMDXhpXcekEuMRyR/+Ug?= =?us-ascii?Q?iZTEX6fA7kz/Z5uWDIoZzlEVcVdlUCVqs5KfBMmJ7wl6+wpBkf0ZMcnM89Fy?= =?us-ascii?Q?MKUzT+HEdq816J3rIcseSR2sZAnHt960bECouxoGMNNkCHtiX/RqNPIjX4uI?= =?us-ascii?Q?IvLeURg5A0++gy+t3vKovb9qKWUn/O9jts3QJWEh0ZSfmX/GfREyswq33UI0?= =?us-ascii?Q?Hdlgx1K1bRB6e8rQf+aM0NzT7B2BO0qOKfqnM23Gcial+igVNxkBmQ5WVL0E?= =?us-ascii?Q?jSe5FWi9zlJh9Qs7WACPomiOh+nV/6uCxl4Uh4RjcpCCp1a6COX5/WkYYcH3?= =?us-ascii?Q?LJ7x65cqrKTD7OtKa6ER98sPziq+0/TxUMhu8WP+Lv+ztNo1yGfWFE4gL7VU?= =?us-ascii?Q?k4PddGbnK6d0va80f9j/j5deNXvaEKKb4sEQrLGTahFuXS4RSZNDoDx+37/h?= =?us-ascii?Q?acoMDSHH1y6pyhDwzLQ5EsBqjjcddp3Lm4NlUC2uK6EXpSqsRJw7P0seUW/u?= =?us-ascii?Q?WuYADeOQLZsdMqYfFyKO4spZ2kX1D91xl2dRtfHN1VaycaU+qdmNDcR0lEbq?= =?us-ascii?Q?0FGr4X0S5BDIG150ws1W+Puuv7K1CYisbvR86HbvaljnHkqAlq7SE8mSflLj?= =?us-ascii?Q?koNcA5VLVLGl+xyfZcsKV0yR5Al1mLz27a0dO5BFrePUHinRdNkTPeaSW+Bt?= =?us-ascii?Q?hWR5/R1lwHeDmVOT29yHEpaWjjp2hvDpLC4rdGlEU0B2oecQSMIfn5kgkI+a?= =?us-ascii?Q?AuLn2S/ZM2tjXXNruXfgh+UZ4nUZSJVZlYqPqcGj8dRYFIXmDBjMjth9s4lu?= =?us-ascii?Q?5V46hcRCNY/2oqq3lOW8RtjyS2RNRgGt2gcURxNYaLCWf45zViE/2DtCoHky?= =?us-ascii?Q?DzSdjcsKjntIDVc8/g5/IJ9seG5xMtetHrz9RG1THRGUl/aQOqYRJU86M/zg?= =?us-ascii?Q?p4bgkjBuv+/ZojTPJwEsE5dy7uDInPIpUux5igDeVEYePRE1CIZ//jVbXqJc?= =?us-ascii?Q?PPvE0T2/X19mFFF4/jvVFDOgUe0CBaKi5NCb+OgNu0HgTbxcQAsgoMhh5jl8?= =?us-ascii?Q?tgEeSCmSCWYHWPnAFm4Vv8O1PgClgA02vnS7k5zBZeINoLARFfUiGtx1LKAR?= =?us-ascii?Q?6sG+hpUIyAw+Rz4nP5XacScpRt64MVUOJBWh3eXyGyS1B109mUT3nR9Eoox3?= =?us-ascii?Q?hmg5Ftreg3DwrZpwNIODP73wlWqiUQhMyD5pzJRfkTy+ur2x1phs0PdeQCcG?= =?us-ascii?Q?EhWvTZH/+h8Lc8FmdaQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DsEkvB+38epr1FCf1/1jvoV+A8w7LzQy2iaKzn6/BhnEkPKLJaiRGShr0xUD?= =?us-ascii?Q?NLgIvouFuhO2PPgOV7kbo9GmOfFTZFemV2UVSBIohOhxGyyvm9empigdl1B7?= =?us-ascii?Q?azcqZqrHaP2UGxxMeTdIrOIkjokgrbO6L0R48xgwINxF2KHL/aUcDXgn8zlb?= =?us-ascii?Q?eZdNXumvw/nCTX5mNzCUMks5Wr97NInkdxIXIEQkE64KWAq4SLAcWFHKQLQM?= =?us-ascii?Q?ppscY+ybl4EtFAnJjKsEp+nDIiVg0qy8GUloGN7J4OPU24RImVxr3AEmy+ZT?= =?us-ascii?Q?oe5fzaPvdAMMId+k9SRwr3xGY51jylASy0DjACWdw1zB1/UO4WbOSDlUv2qK?= =?us-ascii?Q?am2+EZnsojCjCbeSqhuMZxzm/iKqDUx0f53ou3f7qcJNyk58svoDq1PCXAyE?= =?us-ascii?Q?xfJRfUKTg0kagZ0+4qQXsVmSAtwK3SrA/vKj8Vj0OGqjwY0or70AAm1USJ9r?= =?us-ascii?Q?aRSGSLZVqBM0eRBMQKPKElphf/byX+V/UvJQRlulmf2yPOBXtJoQP+jk5Vx9?= =?us-ascii?Q?wc8yWyhpkXcYzZVTvUcQfYmnfBeszORbIMXq6gKgUeGaxRIhOjG6Ll6uyIVN?= =?us-ascii?Q?YLE40JhxYl+nxWEFBjBkgWCvCn9TpSOKtLj2c7jultjBUguiabEVftQ5d/cz?= =?us-ascii?Q?zCKgk13vRT5jOAxzEnOTQBGjjx4GSWcwyuytwEsCLL0d0SOPFXuCYlau7SUm?= =?us-ascii?Q?5VqkMxzXE95AlJ3o5RQ3VL3H1TzTeotIDn2Ek2DsCt9gFA6T1FwdOIMRzK82?= =?us-ascii?Q?HT7T5M6ci9B4Uq5vLWThnWD2HjD+7zXM2xBb85Y9bw6xajHAsc8t0WGEJJjJ?= =?us-ascii?Q?rBIUPfO3K7flFKHiUHfzIzKswtlktAtE/gcvVIC102jG6pH53EXXbkgLjUXc?= =?us-ascii?Q?RY/ofUzfYaYLRWHxZfnl/pt4KdtHeaQyQz4I1lGAfOO2/wSLkTU1K1NvtTqh?= =?us-ascii?Q?P2Xnf/Qf6YoMVzr0xG9HxF+8f9e8LgKnPZNgcDwmEj3zXeISLPIhvfiU+foh?= =?us-ascii?Q?rHFA2uGL88ehOHaFb1ymplftXXDF4rf0IltKIP2a0ywFZDDRf3hPk3O2bjvw?= =?us-ascii?Q?SAe0GB2Jgnc7hqP+o/GwpVA8EowNuZfb9vzPudzrOS17Gu3lyPFtSpMfNGjq?= =?us-ascii?Q?y49V/OcUGuJCczgspq6wzrksKsC3PCSZoqvQ4IM7cSMzdiUu7IsQkB0dRdQo?= =?us-ascii?Q?hoHI+eZ90XMkl166GZNlIpOfYGvSlDHSwL4eASwkmiTbvZD642psf3Uh8F6I?= =?us-ascii?Q?tPcsqbuN33p6dJirEPgr14jct+CSRfz3vZtei4mA8AKt4xzK+hOobeIVtMk+?= =?us-ascii?Q?a0KvE6OyyAzEv9cxPArE5DucwY2hdgCbDY8ptQkPWDK+tDvSVAnOLy9W4I77?= =?us-ascii?Q?GsmbAJsp5kB32AuPO1gjEeb/nEBu0BKaTGNjZHuRQjh4ByZa4RmlltxNhoEX?= =?us-ascii?Q?l4QDwgi++hHdISGzfz5cuqk1H4Om7k0xf83eZO3eSXC2KXx35AuYGzgHrGZQ?= =?us-ascii?Q?AWCLFug8y53tvOvp3JWk7IBIN8LDGXjaXSEitwXkdT335iG588zwYoFrC7I4?= =?us-ascii?Q?RgKcoRzvTPndvuluhps2czc4bnAzG1kKOh0IcUUg/cybP5LlLELTdAqaD+sW?= =?us-ascii?Q?OGbaI87wg5NVmIsgNK6/4+H7+etwwcLOFMxn3ZLGVnqwlNLHpnI0ycuBGnJ8?= =?us-ascii?Q?IP4ax/8TZB2cXUNeBzNZp8DqT6k+3DQrNXKV2oIG/9a7F4ucH40ToOpfbH5U?= =?us-ascii?Q?2DRKOQ7Qlg=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14187b71-6664-4d1b-a920-08de73f79b6d X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:54:03.6113 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: apEPaet67p4PVsev5Di7GJeo5zjf2cCjrExVdPYJQ8/Ix616VoKzBRnZF1vSOe7y01IWWMshSAArLbZTNRK1kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add accessor methods to GspStaticConfigInfo for retrieving the BAR1 Page Directory Entry base addresses from GSP-RM firmware. These addresses point to the root page tables for BAR1 virtual memory space= s. The page tables are set up by GSP-RM during GPU initialization. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/gsp/commands.rs | 8 ++++++++ drivers/gpu/nova-core/gsp/fw/commands.rs | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/drivers/gpu/nova-core/gsp/commands.rs b/drivers/gpu/nova-core/= gsp/commands.rs index fc9ba08f9f8d..22bd61e2a67e 100644 --- a/drivers/gpu/nova-core/gsp/commands.rs +++ b/drivers/gpu/nova-core/gsp/commands.rs @@ -189,6 +189,7 @@ fn init(&self) -> impl Init { /// The reply from the GSP to the [`GetGspStaticInfo`] command. pub(crate) struct GetGspStaticInfoReply { gpu_name: [u8; 64], + bar1_pde_base: u64, /// First usable FB region `(base, size)` for memory allocation. usable_fb_region: Option<(u64, u64)>, } @@ -204,6 +205,7 @@ fn read( ) -> Result { Ok(GetGspStaticInfoReply { gpu_name: msg.gpu_name_str(), + bar1_pde_base: msg.bar1_pde_base(), usable_fb_region: msg.first_usable_fb_region(), }) } @@ -232,6 +234,12 @@ pub(crate) fn gpu_name(&self) -> core::result::Result<= &str, GpuNameError> { .map_err(GpuNameError::InvalidUtf8) } =20 + /// Returns the BAR1 Page Directory Entry base address. + #[expect(dead_code)] + pub(crate) fn bar1_pde_base(&self) -> u64 { + self.bar1_pde_base + } + /// Returns the usable FB region `(base, size)` for driver allocation = which is /// already retrieved from the GSP. pub(crate) fn usable_fb_region(&self) -> Option<(u64, u64)> { diff --git a/drivers/gpu/nova-core/gsp/fw/commands.rs b/drivers/gpu/nova-co= re/gsp/fw/commands.rs index ff771a4aba4f..307f48670e6d 100644 --- a/drivers/gpu/nova-core/gsp/fw/commands.rs +++ b/drivers/gpu/nova-core/gsp/fw/commands.rs @@ -116,6 +116,14 @@ impl GspStaticConfigInfo { self.0.gpuNameString } =20 + /// Returns the BAR1 Page Directory Entry base address. + /// + /// This is the root page table address for BAR1 virtual memory, + /// set up by GSP-RM firmware. + pub(crate) fn bar1_pde_base(&self) -> u64 { + self.0.bar1PdeBase + } + /// Extract the first usable FB region from GSP firmware data. /// /// Returns the first region suitable for driver memory allocation as = a `(base, size)` tuple. --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010042.outbound.protection.outlook.com [52.101.193.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D6F8364E80; Tue, 24 Feb 2026 22:54:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973661; cv=fail; b=Ju7gpXiOEpCA7NPCV+MogdYOCkjIwxKFM9Vg1eGsi53dh6SWsdFc640JWA2BZBiMyeokdXlbuvoS40sPjHAys46RiVYyhRjZNdha3Lab48DiFHdsp/WHPBF0Pimi0BzZWvHM2y5bfh2fwojd050GJnWOQWgG1fXTnALDMsCpH60= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973661; c=relaxed/simple; bh=9vPBcrf0bO9cBVDMM4IJq7qAEJSGsZT5RdfUeTH5ejs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=bQSLfazE65CT+1mWIxxZoA8Rb4XhYLHkDmjyk6ZydCSCjnS2wRoMZ2hF7g2e6hhYm+94J/WLLaoV0JT0xYKeNDYY0OqGztvrvexalQ51Nt3PTU/D14lhyVfj/g0Hu5h+uFdsbJZcRA+H0MbPyY6P7is3IJEI/yJXBXQn2ZQrzhQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=E/rWb8tt; arc=fail smtp.client-ip=52.101.193.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="E/rWb8tt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PqbDWcpzOGlGaWFvPG36IecYFL/qffRYzHDm0EY57hn7atdgDur2Gy3klVEtwygwhvbW965rkeuCbK4YI6+2RkrtbmT4K6TZdPs5lUFkD11VegoIsO7KoL6m4nznCfSDJqLx0f2vqPKgQD1EsOGL6JhY9y/6Qf9e6an9/EZWOJtsenC59ghx67FQhfOoFk+umQivoUDp8PcsV7y5j23sPyBA4hH7m5F52k9jT99jYhUfEDjLO2dYsvKUUwLcTbRy3SYm3McILeR3agrnUuDHWhq0f/hwk2p+Mnl7553+vZ+Ek2zGfkmVZmHRskUJ3NjrkRgs6zXDWbTp4lrQvyPQaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TrnoAiUIsvm6coLNvVvVHIUvBKqhWKnL7KDqeNGwLvw=; b=xyvkeXkWEgj1sMkj6nAomDPS3kZEj5VTo9jsMytuIUHxDiEk1YxR+/I03Wg2oCQyNMAhoSxNxdOvYmFMNXFTxh96xdnTVc+b0Dp7ZayaJSCCWfCb5mHQATq17q1dzpPFybqD2W6tv7RNftQMYzBC553/lqAsAxDBrt8Z4w2WYP2j3j1JBqThs7zMC+84xTjOBNypyrcvP8Xf3ua/obTamzzRJkXvzN35C660AYYDbUnnzBA6YaouCeAMe4jiIp1IepuYR0onDbVjclMgdxhe2CqB4NgrEsuYOLyk/6BHgPsiMFg5UWysfyMtLvk7u3uZaOE6djuKLotuKa9JTIweGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TrnoAiUIsvm6coLNvVvVHIUvBKqhWKnL7KDqeNGwLvw=; b=E/rWb8ttIdzGRBtCjwspN0VEeqp6Wkwnblx0pagP0Leh/0LrmaishSOSD4EieIzIuxSTCEKpD1r+z43atT2XPo8PkyrA9Hw8QHCHqldZ6TTRl3i++QwyGkGmuq/vQPwZxiyh++x0Ikuv1xhDsik/3+DBmvM3vwpdo9o0YUHSF3Cjl4ycmjwsmwUXoCK+A31zfozxvj6Lho770ONLp4XFiJ7+LHiLT2k+zUO/6HsRrk3uYcd99ChHhNvdPVSazFg0Bf9vGAbqCgRF/iBGwo8Dsd1fOqyY6sbGRQWpyW53MJ3652AIoiVQnnn5uNGzPHETTirXkqtolkjfbZaUqopyYQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:54:05 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:54:05 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 22/25] gpu: nova-core: mm: Add BAR1 user interface Date: Tue, 24 Feb 2026 17:53:20 -0500 Message-Id: <20260224225323.3312204-23-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN0PR04CA0012.namprd04.prod.outlook.com (2603:10b6:208:52d::31) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 16cec9c0-9e1b-4ee7-aaf7-08de73f79c69 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?NC5NpjVnNxDKV8oecfJz3cFrfIg/KD/iZqjny5Se/hHi2a31x+Nu7utqkVHy?= =?us-ascii?Q?9yAlJlV6iXo8ltY8IH7GkK3sqwbeM/br+bFQ+ahaJmh/95qdUhYL47dfVdqS?= =?us-ascii?Q?WuqbDHtUiq/C3uMpnKtrk4HcMVgHSghXnR7vxTTRLeaUho/ZTSNCvTy4rDOv?= =?us-ascii?Q?48MK1qF+V2xlrCjL2oRV9r6xHr5uBP0otbP1yEDbyiOgGifQ+L6pkgEBbLEk?= =?us-ascii?Q?tMdQP7W1C+g+cWdu2Mj2Y/Uzgu23vp3TcjHu0qt04w8DebW18B3uTUIyM5J5?= =?us-ascii?Q?7o66XSylXgcCoikHOHQ8oxXTVUREAyz7ktsfyomVNEJqeA1dUqFuUOW/fVE5?= =?us-ascii?Q?O/xRPdB8lRHdUo+93PK1xYVIZ5Hq5I1DAuQVs1V0Ma9LZC1liGJV80UUXTmG?= =?us-ascii?Q?4uDiqdWXndqenAU1iMj5EOPKMCymsaNE97Np9OqWlNTtACdDtO7e/4eVRXha?= =?us-ascii?Q?W+llq9Q+WstAIFLtBNhUOVFpuDE3TfI9OTeO/qFC3Kcycc8TtVrL8ZLIGqeI?= =?us-ascii?Q?5XBB+sjDhkpXuUEtYDuYgK6KiuHhcB+EgJYElZTHPX6O2uMXm7Vq8T4yMtMP?= =?us-ascii?Q?Aps7gcc+4T6aCFVzjDB2Hzvv8ErZYz1HDeMfPg4K1QsYLog5cZAcMsqHVj7Y?= =?us-ascii?Q?MbcmtzTcJBDfz4VDAOWHJWhW+vC0+FRHNEDcwb9k9CMt9aKsyFGxtTswngTH?= =?us-ascii?Q?6mfW2UouuS6dTl6g7XiBZWNu/OrnMKU0PB0H8JXpTpAxX8xhajkW4cMlArN8?= =?us-ascii?Q?2USywgV9R/FOua/tOjHcGI9x3dU0qGM0l8ttYlEZIAxkWIolEzSgR6go0HKD?= =?us-ascii?Q?Nycb/pQXfCJxLT6kJf51Hx4T7wf4EXR97g6K6bN+zrWSwSq6MzNTKjsCCHc/?= =?us-ascii?Q?FMLTL4PdXX8fgbf8kY1HQmvMPdG/dE5vWT8d+Xlfa9jpX+oSElLHAcVa5GJF?= =?us-ascii?Q?D3KxjQm3FZUamVp7HL9sm9yf1f4qd1f5HWRtZBl38u5Nw8rmwrKUsTLhMmz0?= =?us-ascii?Q?yoLYZzlDdpWby/wYdLi/LCzYfrHQ1p9g4e40Dha1svQkP3p0KDVXurg0UcoP?= =?us-ascii?Q?/ReQYVTGKSByFkMMRCjP9CvjhzcbH2sddidWPlr8i+/yVAgzBVi+cq+oHRRI?= =?us-ascii?Q?BFKH6D0qYv1DhPJ/Vjbr/SQMLWzjcYtJ1ul0jjMgYxM9F5HiQ4WPDWd2AcGS?= =?us-ascii?Q?k2NNeXMsmq1WICas37BdJ1fSuAiO7AMCRRz2Vts+u0auvzadgvGwXMaAflgj?= =?us-ascii?Q?2iml73LhZJ+E08dE1gU0QoS1CtlStajCjR6jHovrB/nNbG8PCJMp0bhChCNx?= =?us-ascii?Q?GM4jEzA/wVMb30rIgeBYauRq0WQCu5VLo/hdvSuMW2whYvpMEU5YkK8Yfnko?= =?us-ascii?Q?8vUt08+tn0Nx1yhf5d3aRA2aTPgHsNRXAvRgUOZ7vg75T4/KljTzf/x4/1kB?= =?us-ascii?Q?nM9vZBfBo3iJ2RfyZa2V90VCX+pxUKGqIj3AhU5o4/7J/nJRee7wxEozQBEv?= =?us-ascii?Q?HIBl3uNnniwClY4d1VYJKdX4XV2HSoHqfjQIBPoFPUaw9AkDB9PtiCuUAC5l?= =?us-ascii?Q?uRhxCqLd3qzn9VNGGcQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AZ7xGWiLsD3L1POC9+vN3cvvm/O6VhAGzrLyb5Ir6EKjBeIn9Vgn1yVj8tJy?= =?us-ascii?Q?yn5oYcB8j8V474AA1saz0KJC6PIoFJeYDxg/GiyOMyjXB1aIb7hwxXQHsudI?= =?us-ascii?Q?+JhZEwCxySpQK4Ge9J0qTtWUzigVmvbW6cLcRBmv75eJ5eQ/Lbppva8VziGi?= =?us-ascii?Q?IV5qD0dfin4I9lGEAIbDkYNqIUmm7C9Jt6XcG4GpybR9N6g27a99U9xsrXN0?= =?us-ascii?Q?xEjNTuV0qbt/XTupGChuWpWX8uhMftDxtbxsBy69dMQAorVrns/jCv0HtDhC?= =?us-ascii?Q?tL98WBfsV3M+ne5wms91TNxsrNzNH19Md6mXGPhX8O2/rXQsbKsx+duwHPSf?= =?us-ascii?Q?7cwWCnFdIDlAg2Rg2U/hTezS0Jqq4YJtmoBZnvBJU8m/1Z5hJNj6DbdyvIzT?= =?us-ascii?Q?47uiV03J90Miwq8ezCM79jjI1siglSb86usjEXUoIUCjgjBC3cK9g+ZqMRyY?= =?us-ascii?Q?sHeHhJzE0LyvtEO6/earKpFQ0ETN8dL4uUutulQPt/P/SkrF0y5WGnB+nKR+?= =?us-ascii?Q?FJJf62mpzJUcp/s8rZRp9/RVMOIibYgLjVuc32I6stG3bwo2ZnVB7IlCj6FQ?= =?us-ascii?Q?sC4H50T+pw9ZH6AH+eMpkOKAm7cgkutSvAqQiALdI1d9PZJ5wFzV8tEI3PHr?= =?us-ascii?Q?r9JhjuyOl8V1JVM9cKUGLGeXvjIEw0DyZ9Bs7OSy248a+9P22YgU35uoQqC+?= =?us-ascii?Q?v5GEECGIkOTPdUICPnSUNXp3I/iDyIDWw4+EIkxznswpmMGlJNbPK2HEY1v9?= =?us-ascii?Q?50KTm3+zN1WX7432n3lGqo81Sqika+tTVnSR5Gysh5uM1ffY/+ZexDXDqlwX?= =?us-ascii?Q?nbWfanWGyCZIw8an1vQYv1b4KuP7onmRKx/k4M2SRbBefzFCY4a2p8Ys3Smi?= =?us-ascii?Q?XYb+wYtGhuZNio5YCbZJZu2ke2KqkimpVcXz1Rbg5yKYoj5MHCaYXAoOoeSb?= =?us-ascii?Q?UvWm7aKLWZglAyy0uJvPe62ZSLoylY72H5NyMupRlhTI93BqEQnyop//QQtI?= =?us-ascii?Q?eietT51pEbb+2WAzRB2XoAzuQaJsB56htSVxng4VcvtslVq4tuqKFDGq2Kcy?= =?us-ascii?Q?eLtEQm1Tpi+jkVKAOY6Jr5qDIHFk5TJSU+Ud6d+Eh5T+VQRGwilJZk851TkF?= =?us-ascii?Q?5qghFecFoI55S/I3JZksYA5hYtgSa8Fnz2Iml4tnJKpk9aCw6KWYfmzLAV0C?= =?us-ascii?Q?Kl3RbFM176ahC/hXAa9OKiNblTgpNaBBDFXvPAEdEm0Y6tqHMevc3zK4nSsE?= =?us-ascii?Q?lAoToR1lBzpnrfk5kRNWz3WRzgLARuOjPjN45eDjrIlh/dgihmqw7QMZ6t1n?= =?us-ascii?Q?xjvQvUhRVzCwrpLh9dNPDfUKSDURku6lw9kXx2z4FFs9gyQ7/YXpcBRW5WlO?= =?us-ascii?Q?2mx1MHV7QgHi9rlYmz3eFVUg7pZy914CURfq6J4rSVeSdkKsmeaWwfLTHGlR?= =?us-ascii?Q?+rKWK4o1YUVgoJfWwoJXIkkEV7YneYj6w+A1cCh7iN/GLHwae3GlA+q0meVa?= =?us-ascii?Q?hG3LpciIZCSnGoyppqx+MdotXizZHyLjrlkT9iE0FON0POi4SYZj9hUUlfXa?= =?us-ascii?Q?ysn1TeaeEWurZkOCyQaK8jo8XaiqKn0Atb9IRd27+CpBUv4twpBRzpGvhZmD?= =?us-ascii?Q?kaRJevfM+YXBs8t9icyHLpbXge7nYbZXUs5zBFzJAYHGIgwgeOuq8Ei8/mV6?= =?us-ascii?Q?Ygfc9MmMWP++zIWI14mm9smgWW7QG9DflX0k3u1twLzrbjJJVza7stwYY5+t?= =?us-ascii?Q?AMjTd1/rwg=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16cec9c0-9e1b-4ee7-aaf7-08de73f79c69 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:54:05.5449 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UXD6fA12qhkbIsTN/XnOnhR/XpXFQclqwZ6gB/2eVQzhUZY0Sk2TpasPlymJrM7kl4xsNjpoJWtcHZF0FlI8uA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add the BAR1 user interface for CPU access to GPU video memory through the BAR1 aperture. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/driver.rs | 1 - drivers/gpu/nova-core/mm.rs | 1 + drivers/gpu/nova-core/mm/bar_user.rs | 156 +++++++++++++++++++++++++++ 3 files changed, 157 insertions(+), 1 deletion(-) create mode 100644 drivers/gpu/nova-core/mm/bar_user.rs diff --git a/drivers/gpu/nova-core/driver.rs b/drivers/gpu/nova-core/driver= .rs index f30ffa45cf13..d8b2e967ba4c 100644 --- a/drivers/gpu/nova-core/driver.rs +++ b/drivers/gpu/nova-core/driver.rs @@ -42,7 +42,6 @@ pub(crate) struct NovaCore { const GPU_DMA_BITS: u32 =3D 47; =20 pub(crate) type Bar0 =3D pci::Bar; -#[expect(dead_code)] pub(crate) type Bar1 =3D pci::Bar; =20 kernel::pci_device_table!( diff --git a/drivers/gpu/nova-core/mm.rs b/drivers/gpu/nova-core/mm.rs index 594ac93497aa..42529e2339a1 100644 --- a/drivers/gpu/nova-core/mm.rs +++ b/drivers/gpu/nova-core/mm.rs @@ -4,6 +4,7 @@ =20 #![expect(dead_code)] =20 +pub(crate) mod bar_user; pub(crate) mod pagetable; pub(crate) mod pramin; pub(crate) mod tlb; diff --git a/drivers/gpu/nova-core/mm/bar_user.rs b/drivers/gpu/nova-core/m= m/bar_user.rs new file mode 100644 index 000000000000..4af56ac628b6 --- /dev/null +++ b/drivers/gpu/nova-core/mm/bar_user.rs @@ -0,0 +1,156 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! BAR1 user interface for CPU access to GPU virtual memory. Used for USE= RD +//! for GPU work submission, and applications to access GPU buffers via mm= ap(). + +use kernel::io::Io; +use kernel::prelude::*; + +use crate::{ + driver::Bar1, + mm::{ + pagetable::MmuVersion, + vmm::{ + MappedRange, + Vmm, // + }, + GpuMm, + Pfn, + Vfn, + VirtualAddress, + VramAddress, + PAGE_SIZE, // + }, + num::{ + IntoSafeCast, // + }, +}; + +/// BAR1 user interface for virtual memory mappings. +/// +/// Owns a VMM instance with virtual address tracking and provides +/// BAR1-specific mapping and cleanup operations. +pub(crate) struct BarUser { + vmm: Vmm, +} + +impl BarUser { + /// Create a new [`BarUser`] with virtual address tracking. + pub(crate) fn new( + pdb_addr: VramAddress, + mmu_version: MmuVersion, + va_size: u64, + ) -> Result { + Ok(Self { + vmm: Vmm::new(pdb_addr, mmu_version, va_size)?, + }) + } + + /// Map physical pages to a contiguous BAR1 virtual range. + pub(crate) fn map<'a>( + &'a mut self, + mm: &'a GpuMm, + bar: &'a Bar1, + pfns: &[Pfn], + writable: bool, + ) -> Result> { + if pfns.is_empty() { + return Err(EINVAL); + } + + let mapped =3D self.vmm.map_pages(mm, pfns, None, writable)?; + + Ok(BarAccess { + vmm: &mut self.vmm, + mm, + bar, + mapped: Some(mapped), + }) + } +} + +/// Access object for a mapped BAR1 region. +/// +/// Wraps a [`MappedRange`] and provides BAR1 access. When dropped, +/// unmaps pages and releases the VA range (by passing the range to +/// [`Vmm::unmap_pages()`], which consumes it). +pub(crate) struct BarAccess<'a> { + vmm: &'a mut Vmm, + mm: &'a GpuMm, + bar: &'a Bar1, + /// Needs to be an `Option` so that we can `take()` it and call `Drop` + /// on it in [`Vmm::unmap_pages()`]. + mapped: Option, +} + +impl<'a> BarAccess<'a> { + /// Returns the active mapping. + fn mapped(&self) -> &MappedRange { + // `mapped` is only `None` after `take()` in `Drop`; accessors are + // never called from within `Drop`, so unwrap() never panics. + self.mapped.as_ref().unwrap() + } + + /// Get the base virtual address of this mapping. + pub(crate) fn base(&self) -> VirtualAddress { + VirtualAddress::from(self.mapped().vfn_start) + } + + /// Get the total size of the mapped region in bytes. + pub(crate) fn size(&self) -> usize { + self.mapped().num_pages * PAGE_SIZE + } + + /// Get the starting virtual frame number. + pub(crate) fn vfn_start(&self) -> Vfn { + self.mapped().vfn_start + } + + /// Get the number of pages in this mapping. + pub(crate) fn num_pages(&self) -> usize { + self.mapped().num_pages + } + + /// Translate an offset within this mapping to a BAR1 aperture offset. + fn bar_offset(&self, offset: usize) -> Result { + if offset >=3D self.size() { + return Err(EINVAL); + } + + let base_vfn: usize =3D self.mapped().vfn_start.raw().into_safe_ca= st(); + let base =3D base_vfn.checked_mul(PAGE_SIZE).ok_or(EOVERFLOW)?; + base.checked_add(offset).ok_or(EOVERFLOW) + } + + // Fallible accessors with runtime bounds checking. + + /// Read a 32-bit value at the given offset. + pub(crate) fn try_read32(&self, offset: usize) -> Result { + self.bar.try_read32(self.bar_offset(offset)?) + } + + /// Write a 32-bit value at the given offset. + pub(crate) fn try_write32(&self, value: u32, offset: usize) -> Result { + self.bar.try_write32(value, self.bar_offset(offset)?) + } + + /// Read a 64-bit value at the given offset. + pub(crate) fn try_read64(&self, offset: usize) -> Result { + self.bar.try_read64(self.bar_offset(offset)?) + } + + /// Write a 64-bit value at the given offset. + pub(crate) fn try_write64(&self, value: u64, offset: usize) -> Result { + self.bar.try_write64(value, self.bar_offset(offset)?) + } +} + +impl Drop for BarAccess<'_> { + fn drop(&mut self) { + if let Some(mapped) =3D self.mapped.take() { + if self.vmm.unmap_pages(self.mm, mapped).is_err() { + kernel::pr_warn_once!("BarAccess: unmap_pages failed.\n"); + } + } + } +} --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010042.outbound.protection.outlook.com [52.101.193.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86BE736E477; Tue, 24 Feb 2026 22:54:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973663; cv=fail; b=i2U/VOQn3GDD7PsNRzOjXOfbtXD9ATmcS5bEoe44jc9kVw9od+RU6VOwp+rkH37c2Cl/pOeZhX/y8EWY31fokiwe2dz4fvmSsIshVthq6/ZTQ1O+/2fIsxmuaVKzg3ghgg+iEciCDZSS/VGWkON65ZunU/Vi/KTadEKR0CFpfkU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973663; c=relaxed/simple; bh=NiaETHwBrIqME9nO7Bo5+6cUK0pJuj4WO0ckGWOgu2k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=mLM54v3c0KLsZx7Pv/P/dEbfLNHND3w2uqFVy29QCiHItor40SwVMmu7BBr+MmFGX2CYeh2Y9RbD2CuIX4oB6oI6e9w73LMAU6hG2HyX4QdYuv8lK2EdZYP1K7ZkMqWPaXvcUF63cWvaNKuygK0sQwckwfy7zQNwGGEyyAPooJU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=pqfVC10J; arc=fail smtp.client-ip=52.101.193.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="pqfVC10J" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KBR2vo5C8t1Y0fcqhGagNEEIP4M4v0sYOJLDR4eQHbiC1dx4DylIg7MEkUPAPVkCBdwInbnIxKeC5hgwKau5DG3Zv2yzDEsgbBGA85yS8LBGN9MLXe428nCauhTHLSpcDQTTYqCRh0Unpa0HBQlAEwdAg+Bbaj9iPhE4cqoxFbnV50sF9hm0YEAQNfQ0aacU3lgWt15xiufQDg0xyhTdpe7Cw173ecCUMKQphwS29bDzwaW59gFXaCfSgjrL8E1RGyjV+PIMJ2EGqEebE1fQsevF/Z9oMJ8ktuPHxvhoFzz9Os1kxcZQg/Y71co8c9wYHARA4imN1Djx4NCUqnOvlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qKGMz3SRy5L7rDqfqpQ9+s2Oh3v5QxzRT8C59uSZ83M=; b=P9jeLu4TgQ9rmTlYz9rzwPJZrLBDauxmRZLt69OBn46yxrOAajxW95HHVC0JdAo7bI1I5DvxkKktfrdPXLf13wunvSaYir7dlBH4cb4WX9FJ4cEEzgYx1fITApYIm5F7L85VzzVe/YKQk0B/DQHl4srWZKVSxphdqgVhmXm1YT/r5KpDUnXUQx4a3sfZgeO3vghTev8bJueFZsDs5JO1ZbjvLzI0kL877UaKR7UVD8TwY6WpPbMY98vZD+hOsqEuBH7TuLIU/+mfi0bAzpI5wuS3F0v2eYcAoYpp+LJyVok+OvM8B18lV2uVkdYJcI7KS5x7VodB6rFDGHOjZY1TZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qKGMz3SRy5L7rDqfqpQ9+s2Oh3v5QxzRT8C59uSZ83M=; b=pqfVC10JvYcK7FpGkORR7Ts9s2MRLEd3RdBirAwfFjOvGETi7RRjF5mn4L9AKIovaxsVKWw4YP67Kn7sq/5K+Dq8pcYflBBymjScyRy+mFn2PeOOwGN11RQqSu1mujIJzzFrw0CuJ8wiQKBpm4MEA0HPjdHtS5o3xOwXASy6zze0aeys+LvhS4EB0blIzHiyONHuU5FhhvHHLafrlHwJluACUhTHNSxfUO8ADWJmNz6BIsDrU8ZzTg405sw9tjgAsrT8R7DgClT9cGlX7re3vVid64w1hBz6r3lPuAySsilCK0u028nske8B9x3lW53Jh+Q1QkW+Z4p7KKFDy1brkA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:54:15 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:54:15 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 23/25] gpu: nova-core: mm: Add BarUser to struct Gpu and create at boot Date: Tue, 24 Feb 2026 17:53:21 -0500 Message-Id: <20260224225323.3312204-24-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1P223CA0040.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:5b6::13) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 5dd57e6c-c481-403f-78f4-08de73f7a276 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?kfzgVyuZLLUXYFfHnthjja4gZ/jKMFLjqGg69SYn6/teNaGc2BP8Yd8ZShnX?= =?us-ascii?Q?aOCpNdlQf94cAjN9rhWZ2TXEgSAebKFsvtpNyoF+6fCjJXVJL2+sVMwWmEkV?= =?us-ascii?Q?L9DLHsSu0okFH0W1SlTy6QZkd7hnmMIkIgl66NPAGwvKdnLybuHJE9MY2Rox?= =?us-ascii?Q?AvyncunXAkEoKWg67R3dabffzzqcdfHCdJ1sehW5epLvd7mDM5JvRn91QLjD?= =?us-ascii?Q?yovQp7iSBmmvQr3qrAln/mfM6TVq/YSIQwfQUIVgYMmP0leeWaUxSORj3p8A?= =?us-ascii?Q?IxQbzNk+OTXM9wKwh1RRk+uRc2aQ5O0VXzEONF88+WDdSOJ5M9VVH6fNo+Xu?= =?us-ascii?Q?IYflajsxPqCBje23mFgYOTBW9OUImcXjlayCYSEL4I+SFb5/mhO/cNmPNmfi?= =?us-ascii?Q?IEci6oq1XuOaqCdNzG+dotPDIyaZW3axyvbnB0cTouRewYgp+EO5gyLtc3kX?= =?us-ascii?Q?C9nApqqvqb/Z/dGD2SXdzhMXLsGk45nepceVa/+uVi2ya+Qku9LgPfqncfom?= =?us-ascii?Q?K55XgxLypAg8Aoq+ZhKZig2oZNkjEHehQtoEpz+LwxMee5Qpo2xbZp+2Oo7f?= =?us-ascii?Q?D+gsi2BWIJbp2HbT3KNIsMJgI+EkKwphDgClkJhvw7NgyXEZqqe/mCrjpfVb?= =?us-ascii?Q?7D1O4HXlpHgRjx1nmD6MfN7QGKyeY0ldrThJ2EozW5eW5bZkeeSsLntFjM5k?= =?us-ascii?Q?c+Hf6EtaLa0ax1ZLqvd3v9pJIN9kRyA1HOm9xIBkcV5JTLLqUDcmFagNYBHw?= =?us-ascii?Q?cEF3SVBgpry/9gEbpU9D40MytjEGarmdRf5z64U/ihVmqKPOCp8TPtWRmF6l?= =?us-ascii?Q?byfYqQlacrzWOz1chXbL8PRnifwe/PH1PokvAnX4+2/h/0sKPHsrsTCGe1qi?= =?us-ascii?Q?/HXA1PYzSPEUP4vwU1D42ZvlyV6D1GwNcdCxnM3EN5P1Q8wYGcEpEQBhiyut?= =?us-ascii?Q?Qd4BtvVuNi8lZYHwO4nmR+3L6K3WRYsFBjUwoQornEPBkaqgufcP8bqVHGvM?= =?us-ascii?Q?eTkbVAktQCTj/VTtjNx18nVY0cx/xq+PVFBKOO2fx+WvylgQkF2KbBC1M6gD?= =?us-ascii?Q?Av0Oe46CUN/AYbAVkJrtPxjO6HsXumuqn6h9AYJFvXnlQAn5InvgEKhtQRGx?= =?us-ascii?Q?NEq6hVPiK/1fYwfSuPUSmHA5JLGvGsBAt98Btp+/o3+F8TFVzVKiCK4KscoZ?= =?us-ascii?Q?+cL+mxNfULBr/OiyZAY3Vdbckg3wQaZl+44mohhz6Bf6dSrsPIOBXY8XxIev?= =?us-ascii?Q?StD/Ml5I6kBDq8dPyLSsnlRMjfmc6Vo4cYpVRRiYdS74KCo2cyZPCUw5s2FE?= =?us-ascii?Q?Ody3zZ7BISMUKTy6HbozB7Loss3c4iM1MGvVJm6KS0Wke1UNbF/oPxLSXkVj?= =?us-ascii?Q?ZmFzkKbdvFfP92kuu2LbyLrSWNk/bs7atCPXeEPJuscnX72++rapfZd2M04w?= =?us-ascii?Q?X6lnMVthA3qPW9RRXa9J2NSfo670/L4ukv5lNu2C9jSj+f9KlRhLWMdYioqP?= =?us-ascii?Q?KNHejunAwtnx/7Hc1J2vSuwBOzxPlBa+/XErVn5Zt6GXLplzmryltnSnmlDd?= =?us-ascii?Q?STeY5DcVMlDKPIG47n4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RiWpZsC2kmT/3/WBW6M+YQAgxlx043sLGUWqQTZ8qha4kG+Utymxihrv/jU+?= =?us-ascii?Q?fB6RcnFD2ZZoW22Fhr4EgTptiEGNXODLL70NPVDSlQVT2FyP1r7BtbmaFcCn?= =?us-ascii?Q?3AmpowkJnnKsW7l96xBqT8sdNN1uxLlxx4CfIxa379kTmMFqn7nD5jkCLwo4?= =?us-ascii?Q?CPO0WOoirz/OsR5vTTg4P7FPr5yIqZ25p+P6L67gHOAXx/mzvq2SpPPo2sFa?= =?us-ascii?Q?fMuyNvVlcqFEkiMsw29sUywlOnwtKiVw+UaQus3W1XjCloWeChohmXT7+lls?= =?us-ascii?Q?3SBi5oTrcD3nkhzLoSX2X1rlq6d3VpjyhbPp6q2vjirZPHRqf+7JfqDJ8aTO?= =?us-ascii?Q?7Qcf5z7H2Eb/NgOXM0sA/Yw0GwB6nf/HXJN87trEIKVJP1fVnc7k1783xpFz?= =?us-ascii?Q?GiX2T+I42MNeONlQkq02I78abMAjanqtHsHp2I33PVMdMEhdOBVWgTJKFs67?= =?us-ascii?Q?rOOsYRgIRnlHClTSWbntBW7AmO0AhLllAm15MfKFRq5Zt7JgJ/kMITAJynuS?= =?us-ascii?Q?QVCgVEM3UAfYk5zxB8UaLMbAYGwY+Lul37UkZRQ/ze2K2bw0NfBnR/1kY0er?= =?us-ascii?Q?xW0Wn9UpsWTA+YHgLovESfHuCdLpoP6XWX003vQSiF8TFSO0g8m7SBWlx4fI?= =?us-ascii?Q?cwE4B5IL4J47snYSyH14YOBCY5DEtlDRBtLJMgeQfzhDzfgc7dRx7K4p+QWV?= =?us-ascii?Q?RWtVhPnJf3VyD6UeCc0VaqyAiBySRpG1C8RmE0bMvWbI8TLxWzbv4uHV4mFx?= =?us-ascii?Q?hjy2VGqEuq8iDzvhdcpz+Dh10zTohUBGq5zfNsfZWsVhwTqcSIbPXZW0oEFd?= =?us-ascii?Q?HvBvQyg+9jxxlid4ualyw+32BTLkuSzjLvQtfZLu9/caDgq104DlRJCGGwNA?= =?us-ascii?Q?It0u/PjiwiWGwk+0fnu3URYlj7NelpKC7a335/RZNKnAROTKEnKFxhowqWkx?= =?us-ascii?Q?JalvISfECLxRy4+47P76eZRWqO6cvssVz2R7Zj6SWm0ZCtEuE/xAn6gOSsE6?= =?us-ascii?Q?AD1ancG12X7n1xvHSslvsCuBGE6MwHy5R/70CDJP2QTqv3xtazgA1RArnEYI?= =?us-ascii?Q?MSnypdHqiIe8MV1XtzjmzC0T59/4asFGWvaamCuJqCOWZKZ+7dyNEvuterDN?= =?us-ascii?Q?X5On6O86O76HBUHlxlmYK2452OfyL+5yMNBLnD7zNEesEotcJOAhVf+dEP+n?= =?us-ascii?Q?/MzhkSYoyztfl7JX1G1J3RWCUDDcmTKokiXGOznuAoYhIAIntOa12jLMv3/4?= =?us-ascii?Q?aw9tn/QA0O3xz13JG8S6ZE3GXyRsD1VZUtlTiA9JCxvNDLG/bpuWuDgOJEX8?= =?us-ascii?Q?ohXmmdPz4N+pseOKNskZqxRVFs7LcJ1mAvKbyKkMFRIGkWmSJYw0y/IFLKup?= =?us-ascii?Q?hTuFjPUG9ZS+WRkq2NVAVL7qxcDHEgkwIzVZENEjo9ZIXDxfQO7AD0qqRjdg?= =?us-ascii?Q?+CPNTG1TlfTGD5otq/GPr9f3OyzhdjCWaqQdcGN4c6OCRw5OZCqxhpH/if7d?= =?us-ascii?Q?bS8oJiCGF6dMSdcth/TkIxefUCCG122KbC2lyuzXBMM9VU3zK3l6thMiUuMW?= =?us-ascii?Q?Lus5J4WmcpQYOE6XK+fIn+vi+3ekNOMbuARfIz+tXEpdxBpLw4vO4g4vbCuP?= =?us-ascii?Q?cQkV/Imf0xjrsNm96sas5fdETHJp2qegC/EU8kmSH0831KqrJ8PRN9Q7yKuZ?= =?us-ascii?Q?D6jtQpaWUMZCuzOOwXCQYJLwgehuZpmkUekrHbzKTzuAXw50Bo0XJHbKawyM?= =?us-ascii?Q?mKKqFRx8pA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5dd57e6c-c481-403f-78f4-08de73f7a276 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:54:15.4732 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u6TsNiPkgg88r4u1j6KOIyUZUbgQoyvxQT/txqFsVKaw/H9P9ogSzut9E24c5J0RPMq9RNv2Xpb8iauiEWhUdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add a BarUser field to struct Gpu and eagerly create it during GPU initialization. The BarUser provides the BAR1 user interface for CPU access to GPU virtual memory through the GPU's MMU. The BarUser is initialized using BAR1 PDE base address from GSP static info, MMU version and BAR1 size obtained from platform device. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/gpu.rs | 22 +++++++++++++++++++++- drivers/gpu/nova-core/gsp/commands.rs | 1 - 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index ba769de2f984..4281487ca52e 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -26,7 +26,12 @@ commands::GetGspStaticInfoReply, Gsp, // }, - mm::GpuMm, + mm::{ + bar_user::BarUser, + pagetable::MmuVersion, + GpuMm, + VramAddress, // + }, num::IntoSafeCast, regs, }; @@ -36,6 +41,7 @@ struct BootParams { usable_vram_start: u64, usable_vram_size: u64, + bar1_pde_base: u64, } =20 macro_rules! define_chipset { @@ -273,6 +279,8 @@ pub(crate) struct Gpu { gsp: Gsp, /// Static GPU information from GSP. gsp_static_info: GetGspStaticInfoReply, + /// BAR1 user interface for CPU access to GPU virtual memory. + bar_user: BarUser, } =20 impl Gpu { @@ -286,6 +294,7 @@ pub(crate) fn new<'a>( let boot_params: Cell =3D Cell::new(BootParams { usable_vram_start: 0, usable_vram_size: 0, + bar1_pde_base: 0, }); =20 try_pin_init!(Self { @@ -330,6 +339,7 @@ pub(crate) fn new<'a>( boot_params.set(BootParams { usable_vram_start: usable_vram.start, usable_vram_size: usable_vram.end - usable_vram.start, + bar1_pde_base: info.bar1_pde_base(), }); =20 info @@ -346,6 +356,16 @@ pub(crate) fn new<'a>( })? }, =20 + // Create BAR1 user interface for CPU access to GPU virtual me= mory. + // Uses the BAR1 PDE base from GSP and full BAR1 size for VA s= pace. + bar_user: { + let params =3D boot_params.get(); + let pdb_addr =3D VramAddress::new(params.bar1_pde_base); + let mmu_version =3D MmuVersion::from(spec.chipset.arch()); + let bar1_size =3D pdev.resource_len(1)?; + BarUser::new(pdb_addr, mmu_version, bar1_size)? + }, + bar: devres_bar, }) } diff --git a/drivers/gpu/nova-core/gsp/commands.rs b/drivers/gpu/nova-core/= gsp/commands.rs index 22bd61e2a67e..8b3fa29c57f1 100644 --- a/drivers/gpu/nova-core/gsp/commands.rs +++ b/drivers/gpu/nova-core/gsp/commands.rs @@ -235,7 +235,6 @@ pub(crate) fn gpu_name(&self) -> core::result::Result<&= str, GpuNameError> { } =20 /// Returns the BAR1 Page Directory Entry base address. - #[expect(dead_code)] pub(crate) fn bar1_pde_base(&self) -> u64 { self.bar1_pde_base } --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010042.outbound.protection.outlook.com [52.101.193.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A87836F407; Tue, 24 Feb 2026 22:54:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973665; cv=fail; b=MYGNfkBd6ZPCjQrl+7/gvUrJc7z2iJiBWodAz7MpbTcPxs7dBiGEEhDFP0Cqx1G2Lh8f65x7hyI+SaWE/a5IjAsm2M+Ui96kIjztTa0s5dX4A2UdqIPnS4dYLn4fYDwkvq7u9EuGPmE6fqcaUxNNlh5JNmmyWR7UwdQ3YdhPPrA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973665; c=relaxed/simple; bh=mJ52e/6eA04bpPi4PaYEJt1hIFeP+xs/RC5D0rx0JpU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=O5RiJyfkeY40N00as+QQc3vvP5E3gi3B37rrpGk6xFz2KEoAsMQgTg4r496NMMn4IpdlK88JM3NDc6gDbOnvmKiLHgt9n27/fOeOaqVhONCrDwm1k5qlLIFaaxtYWQsKbuB8yVLhZrqga972E71L2QrhqnbDSSLr3jET/yQ2COc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=qfDlSIC1; arc=fail smtp.client-ip=52.101.193.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="qfDlSIC1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Rkfi/effUxkAAPmYQ6d1jYc0tfF3SoORCUEXxmJuX3QRzBft3gSDJP8Rw4vaimmhBH+JlTHKrkgZlS5+GY8+tC/mkSul+gybDl+dvAfM4f6RjlBP0EmsK8Yhtx2A2bM1ZuVJP9lPbTszKR94JoM3OSS4xKniUhxGUQncaZpwYOYM75KoGphEEVOltU0bFO/6SUKCSzckMIuyhZTfq6S6N/M8m3PYjLNhxJRjvT5P/X6WCTvFJBSoUmsFFnmupbDcJpC3Retd7vo3HVFM/XVIyLMub+R7fd+8SmPN61Dg9GSXmjutVuMcmdw3pDmEBhYPMoQ4G73qsqvg2xo5M7tqMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R43gNWA3PZxF0NM1SiVo+6rrKdl9coWCgbX5uwPfvbY=; b=loqcVumJeiyvT99ejY8WrMbItAvl41dFtR5YuRdsk6gxn8zeJ4ci7mfbaVFT0GtKaxuBi8+aMboI3ThzVQyAge9RIrdEuIu3X7UsrouF4xnki458z0I6cBMtyyk304TEsLNH80qV9QYQU/KYwm+XSvdayy6qvSOKg+H4FsfNwz6qImlf4W5QCVUTUQyQYrLnJzFyvvKq8Jea2hxO3UkWSYAn/p4tSfslyOxzWrfeDneHs5zWn88mx+AC0+nbqwSKXNDLgU7rbf076sS5tRt83eSstSfPhSBe/7+tEIxvIqUrq0qZaDhAPO+3MCQTvu1RUms0/PjyAibTUtaz0lH1QA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R43gNWA3PZxF0NM1SiVo+6rrKdl9coWCgbX5uwPfvbY=; b=qfDlSIC1oqrwrf1JKEGaogx3AW/oafccy2DV6PF4ie1KAv2RhsMYFQ9cYyowdvrRkCYl9GiOyO6wleEG7Yqyp0KThQ4IIy+V4ONSng+CQGe3jYEvyZoHejEE86tX2zML5f0DHrBSrjoOe1lT2GKZW7mj8imCsy0wSALtIlxbLFlTGY+5Lf+K/t38CGQazrnL2AzYPVY8zBClRorza6sQoutGOZy5ALXA7jjFMA8rDHL4gH93bVHVwRcD6i+62iKTrV0hLe4d4cwjLZZSvCTrNaYjJV0+5wmpUoyG5/IpeOOoH1fDACkabcXLN0w8X1M+eSDGlP0OJ3vQP7EG8/5U4Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:54:18 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:54:18 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 24/25] gpu: nova-core: mm: Add BAR1 memory management self-tests Date: Tue, 24 Feb 2026 17:53:22 -0500 Message-Id: <20260224225323.3312204-25-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BLAPR03CA0026.namprd03.prod.outlook.com (2603:10b6:208:32b::31) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 590d1bb5-6e38-4bc5-74c6-08de73f7a3ef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ejA2SjBDM2lydWM0Sjc1SGtRekxxM0VSeFQ2S0dsdVlsVGljcEhIVTZWcFBm?= =?utf-8?B?c0tYUWRrRXR0RG9UT04xNG9WTmhOMXlYMDg5b3JjeDEzOE0vYmhRNjVLcDli?= =?utf-8?B?ZkZ2T3ZmTmFnenNIaW1HK2tKOFNvaUZqM1Ria1BSMzBZM3RPNXMzQmQzVU9W?= =?utf-8?B?bGplTjllQkJyYTR1bDdrUFczbkFVS3Z5S05aTytDWWhmYWRkWWExOXFyN2Vv?= =?utf-8?B?RGVueUhtNklNUC81MHBLMEw4aGhuaDJ3alRZM1VMb1l2WkkyRzJQUTgrbmt3?= =?utf-8?B?UlhoVEJ1bDhHazdIV2JLOG1tSGw0N3lVOUhvb0p1M3NLbzRrWERCOTR0YkE5?= =?utf-8?B?YzVGanFUdzlZdjRLeHZ5MHhRSFdUU0JybDJSQmVaNy9XTzFpQU1NUzJSd3Ez?= =?utf-8?B?RTNRV2pzOC94SWxhM0lZenRMVEpuaWgyU3lJQmtzZEJJaEduSDJrTWhubDNX?= =?utf-8?B?ZWF6b2YxWlBpeklUcUhGR2NwSVpvUzJxTzhTcnZhS2VNUWprUG1uMnQ4SFhj?= =?utf-8?B?ZnRkbUdJUTlwQ3ZqS1J2VEM5QzFDYXFlK2R5RmVOd0VNdDdvV3F3c2p3LzVB?= =?utf-8?B?NHkyZXRUdEU1WU5vTHllcUx4aFR4K1ZRVms5djlSaTBUSm45ODNNd05PUnRG?= =?utf-8?B?WGhiVW55WS9UaC9McktCQ3AxRDBzWkpVR0tmcVVwaXFtS3hVZ0U5VjZlOXVk?= =?utf-8?B?Rm8xQkNMSmRTSFUxTGJjZjJIZWsxWHRJQWtEOHRKamloV2EzL29FUTJpeHpE?= =?utf-8?B?UHdTV0huK1hlaFozZHdyZUZaNjM2RGE4RFJJNmNFRUZLV1lBbmFGbEw4WjhI?= =?utf-8?B?SGltcDlxK2grdWRJRFVkaVJYdnBYR24wSDVoSmFkTFVGdDdNclNxeHJyRmFp?= =?utf-8?B?MGpUVkdJbndCMDdGaVIzazVORzRGdHFMRmFLS1ZhNG1OTVhIOFR0THFnQzhj?= =?utf-8?B?cWF5NFhSb3hmM0lZRW5hRWIvT2ZjUVFQaERkTy9aYkk4TWtpeTRCSDFJVHRI?= =?utf-8?B?dDNNT0FxQVVLdm1qM2dtbEFTVU5ab0FHWGhOR0xMU3JnQml1aDQ3V2VzdFNC?= =?utf-8?B?RFdPYUVkb3o4dkNncUhFRXM2Q05EUEhrNWxmNStSVHowRmlRY29EMXE4Y1RR?= =?utf-8?B?VUdvUUNSNnRESlJCWkgrQWx5WHlFYU5iWlRrejA0a0NiY0lLbHFyTW00VWN3?= =?utf-8?B?WVBHYjNMNTZhbTh4V3drS1I2My9RQnNJQXZRWGVQZWcxZjN0SmJobDJsMGFL?= =?utf-8?B?MVd2dmQ5eGdTbVpydDVjVEVQY2F3TXVEZnhGaVBSS1FoT0l3ckxNZGJNRHpn?= =?utf-8?B?dmFVdHFRbzBabVNPaEhDWEZ1ZnVkeVdic2krajdKTW5xNkRoaWJoYVR2Yk5X?= =?utf-8?B?cEp6MmphQWgrK0VaRjRDc3ZoV3Q3QlhUNERTWlU3WnY2QzZENHUvcGgyVC9Y?= =?utf-8?B?eUlvRXR6TmI3WDAyU3ZSYzF0aGxmZUQwMFhLeEg5dmd5aDJyYjU5NDg3Mm9a?= =?utf-8?B?bDMxdlhZQkcwTTdjbTdSYXpOaldNblJFS2N5endqU2ZxRUxBcUh4amtVUjlo?= =?utf-8?B?WG51dEhvMWxrYlRscUxPMU9yWUtOY3VKQ0I0cVpQM205R0JWWU1nUXJuQ3RG?= =?utf-8?B?bFN0UHVxRnpjMElNOUM1RWZjQWpLYytpOVg1T0xqVklGb1JrY2JybFNhZ1BL?= =?utf-8?B?TjNnbm1Ea1ZRNlZGYSsyQnpLbmwxd3JDMndNblMyS0lQUjc4d0tBK1N6OEJO?= =?utf-8?B?dTB0bXk5V2pSRjN1eGpjRUVvWkhVTzlvS2d4aU1NM3JpWFY3MlEwMVp2blJw?= =?utf-8?B?Ym5WNnV0RTA1U2E4bXI5bTVxYzgzb0VVbmFXRG5JbVFaTStyME5HektOWHRm?= =?utf-8?B?RkRNMFc5Rld5QVE4WjE5VmFjOFBUSkY1V1p4WnFJZGszaTlRcWdrZ25zWUtv?= =?utf-8?B?RU5xZGJSUEdsZXBrYURmTUNJdTVJcndlQWZHYmsvanN6WE1Gb1RWTGcvNlNQ?= =?utf-8?B?NzF6YXE5U2g1SEs4NFlvUEdtZCtPMnVjRTNJb1JocGQ3V2VGeDBYWDFYckZn?= =?utf-8?B?dDFzbnMxeWhrMjJVYlhZZlpndEVORFNHcWFrUGwya1lxbG5hZjh2eE9PbUhu?= =?utf-8?Q?x90M=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2VvOXh4MUtoZ3Fhakplcng3aWNjYWxXaGlzMGIwT3pnRXZRMDJQRjBxSW9v?= =?utf-8?B?MUNCWFI2NW1jWXJxaGl6WXdnbnVCa1hiZmVwbjVWZlY4SnYrWGVzZFdtRGdt?= =?utf-8?B?ZGRuYWEzNElSL1REalNURXF6TmlYV3ZEMnVtYTZ4RWNMVERoOGxHNHRnV0x4?= =?utf-8?B?Q2N5NUlERFY0RTlrMXVuWC9VZXgvVlB4S2llaXZ4TkpMcDdqa0QvbjN2aU1T?= =?utf-8?B?SlFNS2pBTVpsMU41djBaOHFvbmg0OXlxTk9QaDQ4YXE3cGY5SUMwM2w5WURC?= =?utf-8?B?WkozVnkxcjJKcndyNnJYQzdCK0gvakxQSklGOC9yYnltMjRDeHdZOEtLN2FG?= =?utf-8?B?T29wenNaV2NYeHZxK3k1ZllJcmZjMVUzRzM5aEpLWk5CMlhPZmdnWXlzUE4r?= =?utf-8?B?VGNRdW8zenBKeG9YeEVEZWRuNVpsNFBuVi9XNWF2VjJqYWJVcWVIZEt3aFdP?= =?utf-8?B?YVlIZ0ZFcTdjeENjYi9TaE00NldwVkYwYnE5YmpkNWxrNDFxVnJsYndqeHZ5?= =?utf-8?B?M0ZFTHc0M3FSQmxGdFQ4VGZvYkJaV2x5a0kxUWJuYlNtZEdPN3doRlgwQ0VV?= =?utf-8?B?RUEwS3R6ZEoxczlWcWhWVVc3bGkxUThvMkp2RGpCSTdlVTR6bFpneXphU3p1?= =?utf-8?B?bUxZSUV0RXlMcldOdjRocjFRaWRGTGRDVVZEZ2JIRFhEQVJ4ajNXU0tsTmVG?= =?utf-8?B?ckdHZWg3bU1MR1UxcXhoSEFmeTBxejFYb1NoQUkzQW10OTNRcmFoOEZSQlVl?= =?utf-8?B?Rlp6aldQaUFveDNQeWdUQ2NyS0lyeXFhN3lsOWNQY3dtcjNmQlNBcTNXL0tw?= =?utf-8?B?RnN5czgycWVZL3hhcW4vL0FLRjhjU2cvaHhKU3hhMVovZWpXc2FGTVJvNWZ4?= =?utf-8?B?VkdIekYwSzFZcVc2R01PbEoyZ3BGeEhJMEdCQ2V2b2UxNjJSc0NnaGFOVWUv?= =?utf-8?B?dVRURXRvZUZSTDdkVmxVVCtVYUV3MU9yZXZmZ0h3VW9vRUdES1plcHNJQUlB?= =?utf-8?B?NVFweFZKVEJsY3JCZEJOTmg4ZHdqdnlwcE9xVmZpVHFOcHFXMTVBOVhmcTc1?= =?utf-8?B?VElvMFlSNnhYN0ZLRkJqcHBhK2hzY2pYSFl4S2pKbHQ5Z1NibC9MMjJNZFYz?= =?utf-8?B?VFA3ektzQmRBNlRTWTc0Z1pMZ2RuVXVCeVRYUXVNRlhJaE1WYUJvV1NuVzhH?= =?utf-8?B?SnBneDByaUczaEVSWXY2bjlDUTR3Qk85c2cyTWcyaVRUQVlGYXVyODR4ZnFP?= =?utf-8?B?N014eDlhR2EyUjk0WWxveGhaMHhHY3ZoWFJzVnI5eXQ4U3h3Z1htV0cyZncx?= =?utf-8?B?d2xDaGxPU3lFaC9xdURBRUdLMnVrclI1OVBIZk9RbWtPcEJ2b1doN3M4ZkNR?= =?utf-8?B?QkYyd2IvNU0rRkpiZ2RJVTRWY2orbzZ1STBsY0hZQ1lFZWYwZFI4Vk84cWkv?= =?utf-8?B?OEpLM1VVc3dxeE84bGJ3Mzd6VWdYOFlMRWRTZDNHZTJiajlzZGs1MUI5S0g5?= =?utf-8?B?aVg1bFFXeW1EbXluNStQY0RNbEU5ZG02VkN4R1M0RFlSc2xmWCtNbkp2Rk8x?= =?utf-8?B?aFlsMmRLVGNuK2JFMENlWVRSaWZ0OEJ2RWpiRXNUWjR4QkNGeFQ3S1pVbjlu?= =?utf-8?B?NllMVnExUldPeXNidC9pZGg3MnZzMHBDRk5NRThaellKT3JyUkp3czFPcHB0?= =?utf-8?B?Zk1MY3I3T00raVlIN3lRb284TTFReHJ4Tmtxc04rTHYrUXBPc2V0R0dmL2pN?= =?utf-8?B?RjNQSmNIamZvMEpHY2RuQ2VlRDAxbGs2dzZrU3Z6NnlQRkFyclhiS1RCZFhV?= =?utf-8?B?YkhXTC93a1VqbjdabTNnRE9kREtzeHJkbjE5REMzMS9BM2w3OW9rQUV6S3ox?= =?utf-8?B?NVdhN0paQzVUZ1RRYnZsTGhCRW1wZE5WUDNBQ0J1SnJacVhudTRtbkUxZllX?= =?utf-8?B?dlhPQytvME9uaXNXZVY3bVBTdTlsWjIzU0p2ZURjRjJHcVA3NTdMT3FZQWxs?= =?utf-8?B?MWQ4YTNYbnphNTNZSVpzMjdFS1M4WnY3dkFwR1ExbTc1a01pcldXQ1IwRVkr?= =?utf-8?B?VGtXUCt5Y25WeENJWXJsUTNGRmZVMXU2TFU5M092eDJrVTZTZ3JINENOclNC?= =?utf-8?B?d3A4UXM5bDU5WklsN3lxYmxyYnYvVEF2SU1objQ5Q3U5Y0ZJK0d2ZWhoekxM?= =?utf-8?B?TmZlYjhpc2VGZjVURzRsZithVm1JOGwwanVLMW9kUW1Pb2QyUDdCVEFVQlFl?= =?utf-8?B?bXpiaXFBY2Z4OTcydFYzMEJwVlZCZkpnakg3cENFTTZETTN3ZW5ld3YxL0dZ?= =?utf-8?B?cVNXMlZUYk5RUHlReWUyTGFBNnRnM1VEK3dLRVY3VjE1WXVyS2hxQT09?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 590d1bb5-6e38-4bc5-74c6-08de73f7a3ef X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:54:17.8853 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dm8Qyzaweu/B3AXD+k0BeQnidF7IwOvdin8G+s2ZyMfj6fX+qUYnkeo15UL2vOG0bULy72L7BM+8ATwvA/82mA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Add self-tests for BAR1 access during driver probe when CONFIG_NOVA_MM_SELFTESTS is enabled (default disabled). This results in testing the Vmm, GPU buddy allocator and BAR1 region all of which should function correctly for the tests to pass. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/Kconfig | 10 ++ drivers/gpu/nova-core/driver.rs | 2 + drivers/gpu/nova-core/gpu.rs | 42 +++++ drivers/gpu/nova-core/mm/bar_user.rs | 250 +++++++++++++++++++++++++++ 4 files changed, 304 insertions(+) diff --git a/drivers/gpu/nova-core/Kconfig b/drivers/gpu/nova-core/Kconfig index 6513007bf66f..35de55aabcfc 100644 --- a/drivers/gpu/nova-core/Kconfig +++ b/drivers/gpu/nova-core/Kconfig @@ -15,3 +15,13 @@ config NOVA_CORE This driver is work in progress and may not be functional. =20 If M is selected, the module will be called nova_core. + +config NOVA_MM_SELFTESTS + bool "Memory management self-tests" + depends on NOVA_CORE + help + Enable self-tests for the memory management subsystem. When enabled, + tests are run during GPU probe to verify PRAMIN aperture access, + page table walking, and BAR1 virtual memory mapping functionality. + + This is a testing option and is default-disabled. diff --git a/drivers/gpu/nova-core/driver.rs b/drivers/gpu/nova-core/driver= .rs index d8b2e967ba4c..7d0d09939835 100644 --- a/drivers/gpu/nova-core/driver.rs +++ b/drivers/gpu/nova-core/driver.rs @@ -92,6 +92,8 @@ fn probe(pdev: &pci::Device, _info: &Self::IdInfo) = -> impl PinInit) { .inspect(|bar| self.sysmem_flush.unregister(bar)) .is_err()); } + + /// Run selftests on the constructed [`Gpu`]. + pub(crate) fn run_selftests( + mut self: Pin<&mut Self>, + pdev: &pci::Device, + ) -> Result { + self.as_mut().run_mm_selftests(pdev)?; + Ok(()) + } + + #[cfg(CONFIG_NOVA_MM_SELFTESTS)] + fn run_mm_selftests(mut self: Pin<&mut Self>, pdev: &pci::Device) -> Result { + use crate::driver::BAR1_SIZE; + + let mmu_version =3D MmuVersion::from(self.spec.chipset.arch()); + + // BAR1 self-tests. + let bar1 =3D Arc::pin_init( + pdev.iomap_region_sized::(1, c"nova-core/bar1"), + GFP_KERNEL, + )?; + let bar1_access =3D bar1.access(pdev.as_ref())?; + + let proj =3D self.as_mut().project(); + let bar1_pde_base =3D proj.gsp_static_info.bar1_pde_base(); + let mm =3D proj.mm.as_ref().get_ref(); + + crate::mm::bar_user::run_self_test( + pdev.as_ref(), + mm, + bar1_access, + bar1_pde_base, + mmu_version, + )?; + + Ok(()) + } + + #[cfg(not(CONFIG_NOVA_MM_SELFTESTS))] + fn run_mm_selftests(self: Pin<&mut Self>, _pdev: &pci::Device) -> Result { + Ok(()) + } } diff --git a/drivers/gpu/nova-core/mm/bar_user.rs b/drivers/gpu/nova-core/m= m/bar_user.rs index 4af56ac628b6..28dfb10e7cea 100644 --- a/drivers/gpu/nova-core/mm/bar_user.rs +++ b/drivers/gpu/nova-core/mm/bar_user.rs @@ -154,3 +154,253 @@ fn drop(&mut self) { } } } + +/// Check if the PDB has valid, VRAM-backed page tables. +/// +/// Returns `Err(ENOENT)` if page tables are missing or not in VRAM. +#[cfg(CONFIG_NOVA_MM_SELFTESTS)] +fn check_valid_page_tables(mm: &GpuMm, pdb_addr: VramAddress) -> Result { + use crate::mm::pagetable::{ + ver2::Pde, + AperturePde, // + }; + + let mut window =3D mm.pramin().window()?; + let pdb_entry_raw =3D window.try_read64(pdb_addr.raw())?; + let pdb_entry =3D Pde::new(pdb_entry_raw); + + if !pdb_entry.is_valid() { + return Err(ENOENT); + } + + if pdb_entry.aperture() !=3D AperturePde::VideoMemory { + return Err(ENOENT); + } + + Ok(()) +} + +/// Run MM subsystem self-tests during probe. +/// +/// Tests page table infrastructure and `BAR1` MMIO access using the `BAR1` +/// address space. Uses the `GpuMm`'s buddy allocator to allocate page tab= les +/// and test pages as needed. +#[cfg(CONFIG_NOVA_MM_SELFTESTS)] +pub(crate) fn run_self_test( + dev: &kernel::device::Device, + mm: &GpuMm, + bar1: &crate::driver::Bar1, + bar1_pdb: u64, + mmu_version: MmuVersion, +) -> Result { + use crate::mm::{ + vmm::Vmm, + PAGE_SIZE, // + }; + use kernel::gpu::buddy::{ + BuddyFlags, + GpuBuddyAllocParams, // + }; + use kernel::sizes::{ + SZ_4K, + SZ_16K, + SZ_32K, + SZ_64K, // + }; + + // Self-tests only support MMU v2 for now. + if mmu_version !=3D MmuVersion::V2 { + dev_info!( + dev, + "MM: Skipping self-tests for MMU {:?} (only V2 supported)\n", + mmu_version + ); + return Ok(()); + } + + // Test patterns. + const PATTERN_PRAMIN: u32 =3D 0xDEAD_BEEF; + const PATTERN_BAR1: u32 =3D 0xCAFE_BABE; + + dev_info!(dev, "MM: Starting self-test...\n"); + + let pdb_addr =3D VramAddress::new(bar1_pdb); + + // Check if initial page tables are in VRAM. + if check_valid_page_tables(mm, pdb_addr).is_err() { + dev_info!(dev, "MM: Self-test SKIPPED - no valid VRAM page tables\= n"); + return Ok(()); + } + + // Set up a test page from the buddy allocator. + let alloc_params =3D GpuBuddyAllocParams { + start_range_address: 0, + end_range_address: 0, + size_bytes: SZ_4K.into_safe_cast(), + min_block_size_bytes: SZ_4K.into_safe_cast(), + buddy_flags: BuddyFlags::try_new(0)?, + }; + + let test_page_blocks =3D KBox::pin_init(mm.buddy().alloc_blocks(&alloc= _params), GFP_KERNEL)?; + let test_vram_offset =3D test_page_blocks.iter().next().ok_or(ENOMEM)?= .offset(); + let test_vram =3D VramAddress::new(test_vram_offset); + let test_pfn =3D Pfn::from(test_vram); + + // Create a VMM of size 64K to track virtual memory mappings. + let mut vmm =3D Vmm::new(pdb_addr, MmuVersion::V2, SZ_64K.into_safe_ca= st())?; + + // Create a test mapping. + let mapped =3D vmm.map_pages(mm, &[test_pfn], None, true)?; + let test_vfn =3D mapped.vfn_start; + + // Pre-compute test addresses for the PRAMIN to BAR1 read test. + let vfn_offset: usize =3D test_vfn.raw().into_safe_cast(); + let bar1_base_offset =3D vfn_offset.checked_mul(PAGE_SIZE).ok_or(EOVER= FLOW)?; + let bar1_read_offset: usize =3D bar1_base_offset + 0x100; + let vram_read_addr: usize =3D test_vram.raw() + 0x100; + + // Test 1: Write via PRAMIN, read via BAR1. + { + let mut window =3D mm.pramin().window()?; + window.try_write32(vram_read_addr, PATTERN_PRAMIN)?; + } + + // Read back via BAR1 aperture. + let bar1_value =3D bar1.try_read32(bar1_read_offset)?; + + let test1_passed =3D if bar1_value =3D=3D PATTERN_PRAMIN { + true + } else { + dev_err!( + dev, + "MM: Test 1 FAILED - Expected {:#010x}, got {:#010x}\n", + PATTERN_PRAMIN, + bar1_value + ); + false + }; + + // Cleanup - invalidate PTE. + vmm.unmap_pages(mm, mapped)?; + + // Test 2: Two-phase prepare/execute API. + let prepared =3D vmm.prepare_map(mm, 1, None)?; + let mapped2 =3D vmm.execute_map(mm, prepared, &[test_pfn], true)?; + let readback =3D vmm.read_mapping(mm, mapped2.vfn_start)?; + let test2_passed =3D if readback =3D=3D Some(test_pfn) { + true + } else { + dev_err!(dev, "MM: Test 2 FAILED - Two-phase map readback mismatch= \n"); + false + }; + vmm.unmap_pages(mm, mapped2)?; + + // Test 3: Range-constrained allocation with a hole =E2=80=94 exercise= s block.size()-driven + // BAR1 mapping. A 4K hole is punched at base+16K, then a single 32K a= llocation + // is requested within [base, base+36K). The buddy allocator must spli= t around the + // hole, returning multiple blocks (expected: {16K, 4K, 8K, 4K} =3D 32= K total). + // Each block is mapped into BAR1 and verified via PRAMIN read-back. + // + // Address layout (base =3D 0x10000): + // [ 16K ] [HOLE 4K] [4K] [ 8K ] [4K] + // 0x10000 0x14000 0x15000 0x16000 0x18000 0x19000 + let range_base: u64 =3D SZ_64K.into_safe_cast(); + let range_flag =3D BuddyFlags::try_new(BuddyFlags::RANGE_ALLOCATION)?; + let sz_4k: u64 =3D SZ_4K.into_safe_cast(); + let sz_16k: u64 =3D SZ_16K.into_safe_cast(); + let sz_32k_4k: u64 =3D (SZ_32K + SZ_4K).into_safe_cast(); + + // Punch a 4K hole at base+16K so the subsequent 32K allocation must s= plit. + let _hole =3D KBox::pin_init(mm.buddy().alloc_blocks(&GpuBuddyAllocPar= ams { + start_range_address: range_base + sz_16k, + end_range_address: range_base + sz_16k + sz_4k, + size_bytes: SZ_4K.into_safe_cast(), + min_block_size_bytes: SZ_4K.into_safe_cast(), + buddy_flags: range_flag, + }), GFP_KERNEL)?; + + // Allocate 32K within [base, base+36K). The hole forces the allocator= to return + // split blocks whose sizes are determined by buddy alignment. + let blocks =3D KBox::pin_init(mm.buddy().alloc_blocks(&GpuBuddyAllocPa= rams { + start_range_address: range_base, + end_range_address: range_base + sz_32k_4k, + size_bytes: SZ_32K.into_safe_cast(), + min_block_size_bytes: SZ_4K.into_safe_cast(), + buddy_flags: range_flag, + }), GFP_KERNEL)?; + + let mut test3_passed =3D true; + let mut total_size =3D 0u64; + + for block in blocks.iter() { + total_size +=3D block.size(); + + // Map all pages of this block. + let page_size: u64 =3D PAGE_SIZE.into_safe_cast(); + let num_pages: usize =3D (block.size() / page_size).into_safe_cast= (); + + let mut pfns =3D KVec::new(); + for j in 0..num_pages { + let j_u64: u64 =3D j.into_safe_cast(); + pfns.push( + Pfn::from(VramAddress::new( + block.offset() + + j_u64.checked_mul(page_size) + .ok_or(EOVERFLOW)?, + )), + GFP_KERNEL, + )?; + } + + let mapped =3D vmm.map_pages(mm, &pfns, None, true)?; + let bar1_base_vfn: usize =3D mapped.vfn_start.raw().into_safe_cast= (); + let bar1_base =3D bar1_base_vfn.checked_mul(PAGE_SIZE).ok_or(EOVER= FLOW)?; + + for j in 0..num_pages { + let page_bar1_off =3D bar1_base + j * PAGE_SIZE; + let j_u64: u64 =3D j.into_safe_cast(); + let page_phys =3D block.offset() + + j_u64.checked_mul(PAGE_SIZE.into_safe_cast()) + .ok_or(EOVERFLOW)?; + + bar1.try_write32(PATTERN_BAR1, page_bar1_off)?; + + let pramin_val =3D { + let mut window =3D mm.pramin().window()?; + window.try_read32(page_phys.into_safe_cast())? + }; + + if pramin_val !=3D PATTERN_BAR1 { + dev_err!( + dev, + "MM: Test 3 FAILED block offset {:#x} page {} (val=3D{= :#x})\n", + block.offset(), + j, + pramin_val + ); + test3_passed =3D false; + } + } + + vmm.unmap_pages(mm, mapped)?; + } + + // Verify aggregate: all returned block sizes must sum to allocation s= ize. + if total_size !=3D SZ_32K.into_safe_cast() { + dev_err!( + dev, + "MM: Test 3 FAILED - total size {} !=3D expected {}\n", + total_size, + SZ_32K + ); + test3_passed =3D false; + } + + if test1_passed && test2_passed && test3_passed { + dev_info!(dev, "MM: All self-tests PASSED\n"); + Ok(()) + } else { + dev_err!(dev, "MM: Self-tests FAILED\n"); + Err(EIO) + } +} --=20 2.34.1 From nobody Fri Apr 17 00:23:51 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010042.outbound.protection.outlook.com [52.101.193.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 412103612E4; Tue, 24 Feb 2026 22:54:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973666; cv=fail; b=OtBAkYYf+CeQ6BpO5gcZijbBFFGuT3N9NIpbZ94wnL4x3p+PdpaD8Yt2SySgJCfaSx5BhnJh3dz4G2y/qwl08IQLhQeIEwbOcKcuRtP4sQAH+kWrxAciGXXZZ4c3R9Bz3hvXY1N3re4W4JF2g/PghC3h1WaOUHHGX8D1nbx1uoU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973666; c=relaxed/simple; bh=OBfMMakcLLMgRM6lXSM5JPCoJpCJNyA2ey6WHsORzv4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=JwAkwv2jyIT4V3tMB3SJq+ce2mEIFhMtzbaiqLR9kWBitelI4FRmoZmV/RrTY76J1hICHdbHtZfcFCrVR78BgGFEAuvKigDEuPfgByr6fiBW0PcLMemc1YCoauTlaFlYhRaLiJDP6tci2wltHeglvNo8+BOo4WEh3MkNwNDaBMU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=IIkjH8Xt; arc=fail smtp.client-ip=52.101.193.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="IIkjH8Xt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e8PcMRPKpQhQik5lQe0+6f1Qhr8oPnlu5QK/txN5UcQD+0UPNzol7PrcYgBO6ThQUyxWebmV8TFKDc1BB/FIfmWuXNG326FDzp2+ldpuw5XZefDFrKnCFSOV5iqLmfTYPV7Tcla+tb7vSy2nfI7NGQCv8zOLlMr0GQ4Dm+52DGuRf0JiByHqagmUikvswt5QpVCej5faZ+4TNmd0cahYwGVFGB17ItqVZYrN/r8avYVEPBknB/YYD13jUsoOa/az+K/r2CctmN6AwjZEBQFm7zSl1melhFw7ENylxDOKZKX189VJ4TIvmO8o34vQcKEDedsC0EpjKjWRhKzvvXBqXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M9APCXBK2CiR2XMzfWD5aY5NmYIj7orB++57uXHt5TQ=; b=ODjL9ddAXk8gdmTKeo+hLygB8BQNOCJtjX0hZGo/HdQPWUVtwogBjKdFy00fd3k/g5zuTNAZTy3MFCb8VKNl5ctUkjKcgvcORpvA38Jwd2y02TF2gUVHtJH20nnX3XnfzNjzsYOlWWV3KxLLQ8kBSQeGDTwDemA+q5mZO2lOpul29yngPZ4zEpRn8vTIqYbVK0rRYjr6g31Ooz4/Ax9pDEnDLivlpbPiweb+vTNgpo3t202/ZxhH2OnOqQFZ8qhY0Sx+4xwxRmwpmawpCAroI7j0BsEfBeWt/zMrNyyn/XALQT1ziTYy1IXUh0T+GlPwr9LSUqVpBhIhdu7VeLK52g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M9APCXBK2CiR2XMzfWD5aY5NmYIj7orB++57uXHt5TQ=; b=IIkjH8XtiZKkrhq1Fmn0FRLMUvPclYu66JpQuikV2CSJk3zEYukv8NfkS1XuWFCg9J7snyIqNU+AN4ypZwdDCml1NxV04C+E3jonu+8RekKaKmA8eR8ijMjWdY8NP68n8hLU37pT696larGrw4YJAmIozO6eQAMbG5pcTVB+PuhS++G6SEAvDO6lOS+7IxYdNEi/7fpM6pnF6KO82gDJsrcpQQsRch4wEVkf2UCB4hdCQLmc8FdOJA+p8E1mscJXCQr4tg4jAtTOY+vUK7Af3rU9pmsEkiwWx9ChoJ6Ic5Mzt5hDwv2L0PjgnsEt4ICmvUckbhvx1B9bPHKNNpt+BA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB6885.namprd12.prod.outlook.com (2603:10b6:806:263::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 22:54:19 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%4]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 22:54:19 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Dave Airlie , Daniel Almeida , Koen Koning , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Nikola Djukic , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Helge Deller , Alex Gaynor , Boqun Feng , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , alexeyi@nvidia.com, Eliot Courtney , joel@joelfernandes.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Joel Fernandes Subject: [PATCH v8 25/25] gpu: nova-core: mm: Add PRAMIN aperture self-tests Date: Tue, 24 Feb 2026 17:53:23 -0500 Message-Id: <20260224225323.3312204-26-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224225323.3312204-1-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL0PR02CA0008.namprd02.prod.outlook.com (2603:10b6:207:3c::21) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB6885:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b0def32-68bc-4b98-af40-08de73f7a4cf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?F/ygQZ33q5lBIT1kDoWl1xMWIGE2znAyt5Y1f9eL9ppFFQy5BP1xJEW5QCFr?= =?us-ascii?Q?NtDfCd3JcWK1o5TlP2v1R4Q0f1R/lS0bhK/nzQe6NYw43djdog2J5hGAHYgo?= =?us-ascii?Q?zclJU3WBlVppbWBBGoz5caqwVSsD91TjLjtQKDNYNq0ApBsnRTfesg7/7YQ3?= =?us-ascii?Q?8Ie++JtaSJ1hffbbfXyJZmV6xdZ2TOzp2vZp9PkoQxoeThYnGJptiZsiqUfR?= =?us-ascii?Q?Jns3gNULPCL/WCohxkf0uhqL1cl3MfTFOUiFy0Dt4ik0nyheqEBmKzmD0eY3?= =?us-ascii?Q?sKVmC/CatU+yKRLFB3gLhoZb+s4bgsli+jgC9XvhkHG0X/ypOWf82HXAS+Db?= =?us-ascii?Q?tWMF4so89LoFVwhU0aPNoRAHi6LTelT4wv/PIqv2ye6pSeJn3IHTvmIyH2HA?= =?us-ascii?Q?c7fwELqxq1kwWj6YHvtVRRMgxH8UDv9KYi+vlN4+c8tJVeFSOuLjALapJhM4?= =?us-ascii?Q?jsI3j5wBoEWyVEep1vTaHWhS1erEilz+d9HuVJyBydMwtQxLtKTqJ5sagcX+?= =?us-ascii?Q?Nqy4yaykzBcIJL3Ihe7rM85UU0LIuXTiNDZUc8Digk2wdj5z7ieQV/PC5uQL?= =?us-ascii?Q?4aK/axeC0q3uVNZied0bxRqAhA2o/fWkf/bpMOcl47XfPu1GVEU4gVbBqPFd?= =?us-ascii?Q?wLh9s5493tHhFjJ/k5fN3A4RNrYGbmndfRUBlsLFdcnHxISgbdIl7c3yhxte?= =?us-ascii?Q?rw9IQtub8mTtXZccv3CbWUSX3w8fLd6JxcxJOolaq/n3q4ncsKwcaRWT9BY7?= =?us-ascii?Q?CyZnnjsda9eE2JrB9VdtxerKhADdChXrrmeRivt8MAZlqUbZs2Wharbm2x8k?= =?us-ascii?Q?OPoZxdFnBOy2Qom1K+9yFpX8mZGI3EvcgJ2kdN6ArjMvvQPP1zFUwd33NfEV?= =?us-ascii?Q?qsnycFbrzqHGGQMDn8dodlTdWheqxD4PcVmzgdc/V30VQgQp7RrgvCIOPKqv?= =?us-ascii?Q?MV4br75+9rdqr2m2srDbY4tOgo63XpxlfzSRbYAP2LCbF5BwF+Hx1dMo4yck?= =?us-ascii?Q?8+9bGD7gZ+SyOvSF80FyHCoerA6eSRdqCFYyXn2gxbaMx0K+F/F0MchLezYT?= =?us-ascii?Q?a/kCJXZjTVrTj4jUt6NYouNhJrezfs4uEAWNM6dMHI1anzLDN24Tm7iEDeQE?= =?us-ascii?Q?/pzYYctPNvPlCQcs+zTjYuQdkyL5x6ln7nyZ4NjrMUuoGwRUglZVNX71ewsx?= =?us-ascii?Q?khSKGoVXUfNJGxqyMxiQzsGFyfgHa4Po4FpOBIH7yjd1i/CexAJ8Ei3XV+g6?= =?us-ascii?Q?GntyX67bexG80V6z1P4VjP5g5j+cKu/+wgXs7RPTdRkw63w0BidIL1yE403d?= =?us-ascii?Q?Etzi9DbwMuarS56qLP2FVEp3mVu9fSJMaOnCaTyhHily511S9/xhLPy64VXA?= =?us-ascii?Q?BMyieGlWGpF+ysLMBv/5p50u+q4/bXGb7trGXqXOyQnOiW0f/fnxm127vEPq?= =?us-ascii?Q?v1wecDKIU3ZEoAgv44sv21aFrhWvJjbDqPn7gxi+e0ZCn2ZBELmMlNAByv6U?= =?us-ascii?Q?rcXqsXgI0TwYuTpvNxLY2TjBdaoDAl0STWMgFgQfVORpA8oSrfI5msvN8wc7?= =?us-ascii?Q?HfhUlNxiiIgSpy697hQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gD0PDlssN+kR8LOKa3Y4v3Su3J6UtRsAbUFbCLaQVZQOaYcNi20jTOohUl4u?= =?us-ascii?Q?Jo2hpXtkSmMy34CmRHLr9JgycXsXBsToXCXaVIvA3eWDWQ+20BSYf+DN5FVY?= =?us-ascii?Q?fjZ72td+RVCYbZiOWuX9pbnzpB5WeQSjESsyOddmTZdv9yuAb+lqmAioPQ6R?= =?us-ascii?Q?hf+ctWkxGxD4JDu3vwJJMz+y7/sGb4z3+UASKZz8DUZjsLAfh8N8G5OlMPcM?= =?us-ascii?Q?e9AOeRjZodyVVeM1BhiSw67BMeUo6JvvY8m/bkaGwPPj53Ye1rd8aCjM0jTK?= =?us-ascii?Q?sOpgHnKK9CtJyPNbtd+1PS7CpZs9wJzfGnWWnuaHiIb+gyDUh+hZHlRS3F7k?= =?us-ascii?Q?Qhn5NzDAL0xzYqr6Lsgmpago4HqtfSoVM1AflAauMmLrvdnVIEUuGx93xCmT?= =?us-ascii?Q?KPbOUmlAff371DpH4JFXuhi4bWjiMjag4V0Xhp9JHLVIknE/HJe3oBJaEJV+?= =?us-ascii?Q?t45iXEcooJB3w8hdwL0JEHJzu1kEoIIiskzzfwEwCnyD4ZBA7b8BNkz7LC7T?= =?us-ascii?Q?UVmj1e9BFTw7ATvCCj2A5y2L4oB0ToC0jjWrLDE/2dg6DQchqz3PAOTszlN5?= =?us-ascii?Q?4vcez1EvRuA2nlc6le/R0UOp/uxB3yB8a5yADMqCgDxhaTEWzsERfi1/xTW/?= =?us-ascii?Q?v1x/nkX05fLhh3xJ2q2xKKc9uofB44sdeZ/08ZO0F2hSA5/zu/mA09MdO5x4?= =?us-ascii?Q?SMq54oa1gaRVgX68V5DOS3JfoMpMpyQD6/LFyd93mems+ewREkvzm/IDP6GP?= =?us-ascii?Q?y0fqFotiCaj6noIQJxJ91MPPO3U2l29XlVdNURd3t9dxElIv/QZNTFecb6qQ?= =?us-ascii?Q?GI7hesGvxD3EI3OS1blz7uzE9S6889Lrb1TE+dxnreI90/9C/rFHPag265v/?= =?us-ascii?Q?lGli+KYnXoLRzCcpxlowVL2kl0C9ZvZvgIP37tioeImUp/89CsQA7YFDC+VA?= =?us-ascii?Q?t89DrLzOtEWy78/NbcDeCAEfCFxC4pQwKqHT2EfIM/AGPCbLmeYGwZuLo2MX?= =?us-ascii?Q?//pz0OWHtWG6zMfltg5gibdrCLB7sgsv1kHkXWW3TUlJ4/4aOU3yrnIgwc5y?= =?us-ascii?Q?s1iEzabinIdjZku5xc5DOirn1H0Y8Ueq4E3yyRKHPNnAtf4hKpSIwDHhq9/u?= =?us-ascii?Q?gq7oTJJW2A/GMuzxyrJcT+1k+CPuB50iCIoBW3ba9leRe5jV/SCq49tnwemq?= =?us-ascii?Q?n6oUYky3NVuld410Q0xe4jDazmhuO+QPjbMI6cO/uVwUPIqoREP8CO07kjs+?= =?us-ascii?Q?Wwqgh8KgE0ynmKEzlRzGueugOvHZZlTIwZ2X+Ibxeup8Wcpsz/3seotitbTi?= =?us-ascii?Q?Is1p2RsGhcC59P/a0vWdW5nxYBT099ar1c0lkF236QkA14zMrsz4KB83zH+2?= =?us-ascii?Q?cVF34z+Eny0WKBNVDqVsSIkCuWqwmYPL1k10qmYbVIDvVwL7q/YvMxvbmCBi?= =?us-ascii?Q?JxZCgx/MWKXL7nxrPtiVgF+vopTrTMeQLT6fVH3Gy7GgB+U1mg6i1JVkOS4p?= =?us-ascii?Q?BzeEsvwT2wfANDWGdhCbzH6Z9NxaE7jnnHy5kOCCpHefD1zswvk+/5ruKDzV?= =?us-ascii?Q?YfZR9mdTPNiouEXcQ5IwpBmNCISW6kQiKQUNKOvb6XHrH3NwsZX4dlv3EOBs?= =?us-ascii?Q?PfC/nLKsWDAhZMGqcZQ40OEY01JU0wcu9NtJxHhIn6kKD4EcpoS1GwUa9k17?= =?us-ascii?Q?gq/JnkdxnNVhmgTAOV3EoAsvK9KwJgHm160RFn28sBEMYDJH1T5IZyxBrdB+?= =?us-ascii?Q?dz78nFuO6Q=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b0def32-68bc-4b98-af40-08de73f7a4cf X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 22:54:19.3800 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hkOcuYRL2owFvJDaQGIoO7d+RHBrjq0xp1GfEjAXzKZ1tLk+QNUvk6HkJDtgJEbx/dIyeQJN84UILUklnmy/YQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6885 Content-Type: text/plain; charset="utf-8" Add self-tests for the PRAMIN aperture mechanism to verify correct operation during GPU probe. The tests validate various alignment requirements and corner cases. The tests are default disabled and behind CONFIG_NOVA_MM_SELFTESTS. When enabled, tests run after GSP boot during probe. Cc: Nikola Djukic Signed-off-by: Joel Fernandes --- drivers/gpu/nova-core/gpu.rs | 3 + drivers/gpu/nova-core/mm/pramin.rs | 161 +++++++++++++++++++++++++++++ 2 files changed, 164 insertions(+) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index fba6ddba6a3f..34827dc2afff 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -396,6 +396,9 @@ fn run_mm_selftests(mut self: Pin<&mut Self>, pdev: &pc= i::Device) =20 let mmu_version =3D MmuVersion::from(self.spec.chipset.arch()); =20 + // PRAMIN aperture self-tests. + crate::mm::pramin::run_self_test(pdev.as_ref(), self.bar.clone(), = mmu_version)?; + // BAR1 self-tests. let bar1 =3D Arc::pin_init( pdev.iomap_region_sized::(1, c"nova-core/bar1"), diff --git a/drivers/gpu/nova-core/mm/pramin.rs b/drivers/gpu/nova-core/mm/= pramin.rs index 04b652d3ee4f..30b1dba0c305 100644 --- a/drivers/gpu/nova-core/mm/pramin.rs +++ b/drivers/gpu/nova-core/mm/pramin.rs @@ -290,3 +290,164 @@ fn drop(&mut self) { // MutexGuard drops automatically, releasing the lock. } } + +/// Run PRAMIN self-tests during boot if self-tests are enabled. +#[cfg(CONFIG_NOVA_MM_SELFTESTS)] +pub(crate) fn run_self_test( + dev: &kernel::device::Device, + bar: Arc>, + mmu_version: super::pagetable::MmuVersion, +) -> Result { + use super::pagetable::MmuVersion; + + // PRAMIN support is only for MMU v2 for now (Turing/Ampere/Ada). + if mmu_version !=3D MmuVersion::V2 { + dev_info!( + dev, + "PRAMIN: Skipping self-tests for MMU {:?} (only V2 supported)\= n", + mmu_version + ); + return Ok(()); + } + + dev_info!(dev, "PRAMIN: Starting self-test...\n"); + + let pramin =3D Arc::pin_init(Pramin::new(bar)?, GFP_KERNEL)?; + let mut win =3D pramin.window()?; + + // Use offset 0x1000 as test area. + let base: usize =3D 0x1000; + + // Test 1: Read/write at byte-aligned locations. + for i in 0u8..4 { + let offset =3D base + 1 + usize::from(i); // Offsets 0x1001, 0x100= 2, 0x1003, 0x1004 + let val =3D 0xA0 + i; + win.try_write8(offset, val)?; + let read_val =3D win.try_read8(offset)?; + if read_val !=3D val { + dev_err!( + dev, + "PRAMIN: FAIL - offset {:#x}: wrote {:#x}, read {:#x}\n", + offset, + val, + read_val + ); + return Err(EIO); + } + } + + // Test 2: Write `u32` and read back as `u8`s. + let test2_offset =3D base + 0x10; + let test2_val: u32 =3D 0xDEADBEEF; + win.try_write32(test2_offset, test2_val)?; + + // Read back as individual bytes (little-endian: EF BE AD DE). + let expected_bytes: [u8; 4] =3D [0xEF, 0xBE, 0xAD, 0xDE]; + for (i, &expected) in expected_bytes.iter().enumerate() { + let read_val =3D win.try_read8(test2_offset + i)?; + if read_val !=3D expected { + dev_err!( + dev, + "PRAMIN: FAIL - offset {:#x}: expected {:#x}, read {:#x}\n= ", + test2_offset + i, + expected, + read_val + ); + return Err(EIO); + } + } + + // Test 3: Window repositioning across 1MB boundaries. + // Write to offset > 1MB to trigger window slide, then verify. + let test3_offset_a: usize =3D base; // First 1MB region. + let test3_offset_b: usize =3D 0x200000 + base; // 2MB + base (differen= t 1MB region). + let val_a: u32 =3D 0x11111111; + let val_b: u32 =3D 0x22222222; + + // Write to first region. + win.try_write32(test3_offset_a, val_a)?; + + // Write to second region (triggers window reposition). + win.try_write32(test3_offset_b, val_b)?; + + // Read back from second region. + let read_b =3D win.try_read32(test3_offset_b)?; + if read_b !=3D val_b { + dev_err!( + dev, + "PRAMIN: FAIL - offset {:#x}: expected {:#x}, read {:#x}\n", + test3_offset_b, + val_b, + read_b + ); + return Err(EIO); + } + + // Read back from first region (triggers window reposition again). + let read_a =3D win.try_read32(test3_offset_a)?; + if read_a !=3D val_a { + dev_err!( + dev, + "PRAMIN: FAIL - offset {:#x}: expected {:#x}, read {:#x}\n", + test3_offset_a, + val_a, + read_a + ); + return Err(EIO); + } + + // Test 4: Invalid offset rejection (beyond 40-bit address space). + { + // 40-bit address space limit check. + let invalid_offset: usize =3D MAX_VRAM_OFFSET + 1; + let result =3D win.try_read32(invalid_offset); + if result.is_ok() { + dev_err!( + dev, + "PRAMIN: FAIL - read at invalid offset {:#x} should have f= ailed\n", + invalid_offset + ); + return Err(EIO); + } + } + + // Test 5: Misaligned multi-byte access rejection. + // Verify that misaligned `u16`/`u32`/`u64` accesses are properly reje= cted. + { + // `u16` at odd offset (not 2-byte aligned). + let offset_u16 =3D base + 0x21; + if win.try_write16(offset_u16, 0xABCD).is_ok() { + dev_err!( + dev, + "PRAMIN: FAIL - misaligned u16 write at {:#x} should have = failed\n", + offset_u16 + ); + return Err(EIO); + } + + // `u32` at 2-byte-aligned (not 4-byte-aligned) offset. + let offset_u32 =3D base + 0x32; + if win.try_write32(offset_u32, 0x12345678).is_ok() { + dev_err!( + dev, + "PRAMIN: FAIL - misaligned u32 write at {:#x} should have = failed\n", + offset_u32 + ); + return Err(EIO); + } + + // `u64` read at 4-byte-aligned (not 8-byte-aligned) offset. + let offset_u64 =3D base + 0x44; + if win.try_read64(offset_u64).is_ok() { + dev_err!( + dev, + "PRAMIN: FAIL - misaligned u64 read at {:#x} should have f= ailed\n", + offset_u64 + ); + return Err(EIO); + } + } + + dev_info!(dev, "PRAMIN: All self-tests PASSED\n"); + Ok(()) +} --=20 2.34.1