From nobody Fri Apr 17 00:18:00 2026 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBAF434B1A3 for ; Tue, 24 Feb 2026 22:48:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973328; cv=none; b=o2dtNLxx1tg2QYmvtnGu0txCJfKTfcKBUzcCfY3hZn7MC0MxbUO/LkCZT2/mgzZvc967MaKU8vm/ZNeGhqY9M3mRXOJlah7ttJiyp/C34Y5QO6E510UIvEl/K3v8d0+PW8JzJzxVI8A1USdTi7/iYygyh8ag+c9GFI1mkKBlHwc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973328; c=relaxed/simple; bh=GbI77GrkEw+EdAP5e947pwAORDnExo9gpvU3Fgjb6y0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bZAkdFmEBbx5IABDPQbV7BK8ypNDS3+3gYPG719tF83mzHV9TiH+qMbkN1vvGGWM73ZbrDU+28Xh+cuB4mFPv+3QPINxThYpPUtY8FxeVJuiVfsS9/v2PojMLV6zPrSpZNSCMKAcU3VtPN4vzUtutGgB57QU/qHKf2NP4V7nxbk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HfjDzgwS; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HfjDzgwS" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-64ad019bbd4so5700661d50.0 for ; Tue, 24 Feb 2026 14:48:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771973327; x=1772578127; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y1hKEjBb/F+XiIzl3891wABD4RiRkcRdoBk1qKL/7/U=; b=HfjDzgwSCkCExfI+2MAa1BwGdy3w03d8SFy4sYEBt2kbWZ/8ZVajv1AFJCQppr8teN 0AElERvyhxhasBP4po4jacDZ3KMA92Dskn2V7rFjbBbUfMIHi6EUjVudalBV/0mhX608 OiM5YhrY7gvpPgzwhmzV0Jk/i8m1DFXbzqQzAZww5LI+h0pQBPsrjhsr1IRonb5lKUrS vBTP2RK7/6JN+lB0iMYLVZ4dTK2pmkebiavuHq3hu5YZXjQYKeLH0Lqb16KQFxl2xzET o4j5HNaIugCqbEkzl+lsx8Cx9cOQT9qrdrZW4jgs5X0rESVSQidDAZ6pmviezJaR67cL kjEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771973327; x=1772578127; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=y1hKEjBb/F+XiIzl3891wABD4RiRkcRdoBk1qKL/7/U=; b=JH2RwkmdoCnqHFGpY9xJUciLvjqpLwOigkEye25i1bcfrz7GNwRxreeXC7bzp7xFrc ptxznOzaQEgxQhBbYg71Ql8KTJXb1kLbMSBf0K4t3GlVD0BoIMX4Gi4VpcdHUls8445K 9Fott5Zy/UoEVf3ITFVHTTnXYT3xSCfnyHHM4wdMuMlYVTMpSOjzYy6japp7cxFAJmHd vwyd3qNPsfCV9Y9NhRc/xRtZTD3fSQXPuPXaYzAYWNnLVxcEDjsiqwli1mLSpVehNjgk V2V363/ddETTXsqQ0B3uVlk6lVEkgMBomb1/UD6vI8EL3v41JxbIzxOGHwkTtGLsMTJ3 Kxug== X-Forwarded-Encrypted: i=1; AJvYcCXXEvNXs8bNEAS6jk/3nXtK0wudO9zr97fE+kB76AE8aFkH5q1vsmeudzIwPK7nAyEMg2BuLvcMWHni9Qk=@vger.kernel.org X-Gm-Message-State: AOJu0YxHrb1tOfEKots3LHtoz+4sFKREX/703Jq85gqkMpFjJD1hZKVe K21XhCYGuOWbeHiGemVihsd3yn5JBedV1JQ964BUkUOXxzkwiSQO65Eb7p/Krp47TIY= X-Gm-Gg: ATEYQzwXJNMcCYDov411ptXuBDCV0CTM/5HR3ETABatx2eTbjsAWcReozjgFwFNXPLx saVVmHVEFNUWKfMi0c14rxWQjZny2csex03nDG8es6z2GXooQ7s4JRrjWOWiNKa2hxD40wX7yfi iHs8QGgPTpsTCkXwGE+2BNuLwDDA6VdCDoCbqD02UsNwo9ybEYOSr4opAx5sR2WUlCOW6TEbfNL pnWQux3u/rMJ/ks92Fr3bA9vGZxgph8s4aACCEnJ4dROgsf7x2uzXz/cbZvfByMpQKECPiKgn/o b+j7AHau3uRQFjoFOa6dvfxrqIhxs8agpAv2aRF03rNL3tVPPhjmbufKrw2sqyMWJlUDVtVB8m/ wP9xk2Ov8D2bqE1IH1gqL2IMTIQm/b7PaIOpOAR0gFC0bgDKJtfKCjXOye3UO1slqPTn4HQCqkC 4p5dJvx+tPXKnaerpfWdjZEawZLqEclHcI9w3k5zuzCD+C3lkOeSGd7OTCsTq6qwb3eWuHb/8TN rq7/UhIYyFf5iJo9SXUyWl8 X-Received: by 2002:a05:690c:67c4:b0:794:a165:1c3b with SMTP id 00721157ae682-798681fa0a2mr3013407b3.30.1771973326770; Tue, 24 Feb 2026 14:48:46 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7982dd88efcsm48838757b3.24.2026.02.24.14.48.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 14:48:46 -0800 (PST) From: Ethan Tidmore To: linusw@kernel.org, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v3 1/4] iio: gyro: mpu3050: Fix incorrect free_irq() variable Date: Tue, 24 Feb 2026 16:48:15 -0600 Message-ID: <20260224224818.2452675-2-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260224224818.2452675-1-ethantidmore06@gmail.com> References: <20260224224818.2452675-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The handler for the IRQ part of this driver is mpu3050->trig but, in the teardown free_irq() is called with handler mpu3050. Use correct IRQ handler when calling free_irq(). Fixes: 3904b28efb2c7 ("iio: gyro: Add driver for the MPU-3050 gyroscope") Reviewed-by: Linus Walleij Signed-off-by: Ethan Tidmore Reviewed-by: Andy Shevchenko --- v3:=20 - Remove unneeded code snippet. v2: - Patch added to series. drivers/iio/gyro/mpu3050-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-cor= e.c index ee2fcd20545d..06162d886b59 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -1261,7 +1261,7 @@ void mpu3050_common_remove(struct device *dev) pm_runtime_disable(dev); iio_triggered_buffer_cleanup(indio_dev); if (mpu3050->irq) - free_irq(mpu3050->irq, mpu3050); + free_irq(mpu3050->irq, mpu3050->trig); iio_device_unregister(indio_dev); mpu3050_power_down(mpu3050); } --=20 2.53.0 From nobody Fri Apr 17 00:18:00 2026 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DCA334D391 for ; Tue, 24 Feb 2026 22:48:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973330; cv=none; b=JzX7iQ22E7Ht+jGX/q1xHAAk89Bop6qNyRHCYVsXcVg3GGrE+rtoa9taNMRaPpghbgLy3PISZIk3NEs0ow6zCvBK+nLPLiVvjZeVR6Py8Ugk5Mwocob8V/5vh2Rd879GWiSOZZDCiFMs7VA8Urzv9o+tmgEFiJ2UKemw447sqzU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973330; c=relaxed/simple; bh=nmugurTC3LquwwQ3c1ikZQil6rC8xY1wLp3DAB/gqsA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MkorOliMle7jzywBO8b6I+h0gdl98JrlD2OuJA7+0iVPpce+gvlKrVYouT+fNcMujOf+1IEqFUCc86/1Ua1ALhASLruKhJ2FCLyTHKKDzRH/WSwh83yR32Et06SAOM8WA6vlTH3R1haS1yMVKI4ziFn2KgRhHw5QOcZrHy6fPAk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gC1JKzm+; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gC1JKzm+" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-7964fb9ae3dso54530087b3.0 for ; Tue, 24 Feb 2026 14:48:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771973327; x=1772578127; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iRmBa3MakDv6vabRp84EIeQ9FVfS2U/MlXhf84RaaaU=; b=gC1JKzm+1up+NQ/0qjJQc0FUsas4V5RVB1iOafT+trxakAs5GWRYEG09jzWtDRHLtE sxXdfR17+1p77bnMA5EUJRkdE+xDa3yfiN684yVi/bsVXg/hf4XLUUrMGVRvDSRZ6pES wxgDsfn1MaeilaiwVyvJJakXFaC7KB0M4vNqIan0Jv8vw9o/kSZNF8lnDo1btZWPWO97 vYFAJWZyMK8X26LYQop9teEndToNKGZnkDTHp15RMqBDrPPBGmF8h5LZQcZ7W9zVpCTK UOBZRcrDc91kBqlqm8UeFysDQplC/2peTqpJrnUUlgGNmIjNCdFhzBwM0naq2oDYQzS/ jNcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771973327; x=1772578127; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iRmBa3MakDv6vabRp84EIeQ9FVfS2U/MlXhf84RaaaU=; b=OvB76WkI83Qbcop300avshc4kAPXAYQBwaYmpR0sgjgs/UE/GKM3YkzvvyTYUbAOiF Z/BdwLEolSRDEgfKoPni9UWbvm5WJrL2fnFv0GzbpCOf1p4PmlNAwnSyfZwtqF0FCeoi 2+suMb/jKD/nZM7WB1OcP2B5m6k5dsxdKOqp5b1AcS5mxgK5LaWVC/zV/Qe4d0ODDlU0 awVVsPv4hxrANOZO2aXWdJYxzBdcwPu2DZePGJ8ZdakSIidOhBqosOIvlVpYgr+aq9iJ /YSn2ZxI619tCC8pDHPIDi88/8LuOqBaJOanjK/7Fl98KuNjB9u+on3V1VdFFMbjvjFQ JzAQ== X-Forwarded-Encrypted: i=1; AJvYcCVbXGVbOSMd4pqnx3l7bnWPbO32RKSJ1fpPvjkJELOgeBKPmDVHz16ljSlc5UGqKL0EFEarCby8wt+8kmk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7Z7DRAWibIJ4KLs/cGGbMPGkS3bRpC6TwscxaN5GwQv/i6Ycj 2p4XnJWjfx+Va8PSpM/jPKCNOHxzPyud41V9LjvRg/iA6F1BaQ+rShY4 X-Gm-Gg: ATEYQzxyPUupe4yEhvaSqRY8TNV8fFNfw5SI+XPUqDKXeK3zOwm/zdYC0RFFZijzYvv VoTHEd2HcGltZwq4CHzOjub3+rAglohjd1u991dt9fVljYyCQYYlsDb15NBqQjJkXTVn7yejibX DJgBML07BFkPSYF5pO4B8mJb7d9jQcvgsOC4u/5eMM1vvHicz2mOmyrdAhW2R5t3kxGwXOOM8WX NPohEgZmvJHqfKsAz5y3QsJ6POT4L35yl4ibF9Tn31jJ2y56BUsNEfMxRbXs5ggrSnASEhMB4E1 HkiWsWtg4hnDKJpvBSGDNxpKvQxlvjBsmYGsFEhICnLchIgdfDawi6a5dlYq4GXTaBTuL1NfbBP /Wb/42CIw+pEK8/pLdqmQ8+kMApPzsYqaKYXPAEid4gfYBsQxgP2r88kmCAkKKxBNZGYkDbs4E0 X1I6Ly9nuHR2JMSlbmcVbZ5XOFUJajfX/AX7ZeznNq3cVyLcC8OjWgXVQEmZDDhJigzghnO1ose 0wRJarhScBXoBvqp9EG5ucEpYQ7+ey6xqI= X-Received: by 2002:a05:690c:101:b0:798:5951:f42b with SMTP id 00721157ae682-7985951fb32mr45275177b3.42.1771973327471; Tue, 24 Feb 2026 14:48:47 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7982dd88efcsm48838757b3.24.2026.02.24.14.48.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 14:48:47 -0800 (PST) From: Ethan Tidmore To: linusw@kernel.org, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v3 2/4] iio: gyro: mpu3050: Fix irq resource leak Date: Tue, 24 Feb 2026 16:48:16 -0600 Message-ID: <20260224224818.2452675-3-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260224224818.2452675-1-ethantidmore06@gmail.com> References: <20260224224818.2452675-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The interrupt handler is setup but only a few lines down if iio_trigger_register() fails the function returns without properly releasing the handler. Add cleanup goto to resolve resource leak. Detected by Smatch: drivers/iio/gyro/mpu3050-core.c:1128 mpu3050_trigger_probe() warn: 'irq' from request_threaded_irq() not released on lines: 1124. Fixes: 3904b28efb2c7 ("iio: gyro: Add driver for the MPU-3050 gyroscope") Reviewed-by: Linus Walleij Signed-off-by: Ethan Tidmore Reviewed-by: Andy Shevchenko --- v3:=20 - Remove unneeded code snippet. v2: - Use manual cleanup instead of devm_. drivers/iio/gyro/mpu3050-core.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-cor= e.c index 06162d886b59..b6e05afbe512 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -1121,11 +1121,16 @@ static int mpu3050_trigger_probe(struct iio_dev *in= dio_dev, int irq) =20 ret =3D iio_trigger_register(mpu3050->trig); if (ret) - return ret; + goto err_iio_trigger; =20 indio_dev->trig =3D iio_trigger_get(mpu3050->trig); =20 return 0; + +err_iio_trigger: + free_irq(mpu3050->irq, mpu3050->trig); + + return ret; } =20 int mpu3050_common_probe(struct device *dev, --=20 2.53.0 From nobody Fri Apr 17 00:18:00 2026 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32AAF34EEFC for ; Tue, 24 Feb 2026 22:48:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973330; cv=none; b=IUNhKwdPfguqrZ494ZBIEOaIA8rwawHYKNvXnCI/JBiYeIf1Bye7YaqxnYTFMrqQcLc0rYRgzXVQ9owrQcIFP0VM5uC3SZohPzc62EqRIMWg3Mpe4k2/TMgOvG1lczrrsnzmN30wgWVBPKgCBCo2PaJNdjhacuI5hMCHgqv9XKY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973330; c=relaxed/simple; bh=xUpdKh43T9YeuaD6xpCMyHtb10I2PeGwdsS/b4sKsE0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Nh4pPuSGBYuiKK4fTQOfA7mEwA+qPAaS18Hs5kg22nGMYg2/RcI3ohn31AzundN0n37IDWFo2+HMo3vMV4ybrgGls+25Cd+uFqKE5jZTxvhIrjdbm3csg34gpFAyKb+wDfq3y4snu1mJ7SSD2F6F5xmWUDtM9GyqLhhA744TCUA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U9JdhUKr; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U9JdhUKr" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-793fdbb8d3aso52301947b3.3 for ; Tue, 24 Feb 2026 14:48:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771973328; x=1772578128; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gzm4Qzg/QoCTFEcZe5nEpMcr/8uPNivp7yd6Bg08geQ=; b=U9JdhUKrb+fwCW1O75ZHlZDmubC9//1SQYLMTEeMJBYjwAhw4UQYq/pSPL4TsjdOEW uGXwM7WvZsbrUdXIcU+UbD9Ov48q3401Sr1UhW1LM5BZ9TinJWpi3YrzC8eD+dco61PN EV56l9zSTSg5WpRAC+HSmdPf2xhqXnCInbYIyxAlAZDc51WDljB/sTJIttvG7tbsvPjQ A4t68CXtzT/5FMBMViYKjmtk0ywoqe8yUL9acn+br0FdG6vS7ub8bJ/maZpxAc4TgE8c ghH61XpNjuIQ4ZCb5ESLafwydq6S+ls1OhxpPHy927D+X7AHagsRwQEXtWEEJqo3SrFm o3KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771973328; x=1772578128; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gzm4Qzg/QoCTFEcZe5nEpMcr/8uPNivp7yd6Bg08geQ=; b=s4Q1B7MZCS7TcWXtxtsJwKrLP5KQ5y54Z37mFjRt1a7LKpUnP/WAy5TaiCKqOdeP/h sgP1lWxfC5BAuziEHMVxNBxQKQCYa9QKFQIgxPJtOSmLv/iAQiPP1Ujq4sOS1x6g+B0j pz8e7uijvNZPHLuhSuqN8lvgA3Sr2CWTS58CRwRqjMYor6+by7W4sLsxNMkSJbXxkAJV 4ymZLSovutZcBBr4fcl+SS8DVxp01JSHUxMgR9nSM3x4jctyC/QUbL+MwK7I2456a318 +m7FedmxTALCIFKvayNquObLyfq8RcqHabtLIHMH7f9PlPrwLy8h1WZ3h/OZxXn8pqx3 56lQ== X-Forwarded-Encrypted: i=1; AJvYcCVl8CWBwM/ZiKwFOzGqLfGpBIt712j8gxcg6J0Z1im92RLbxuisS0RqRzsBtCP0uyC3KDJNGEYFnU8LWfU=@vger.kernel.org X-Gm-Message-State: AOJu0YyiL0ww5O8twAAfMiGIIPzHnuGqVEBiJ9PxZI0jn89PAeW3GAq8 HmKNkdqwIyCm4oRmAlMEzZrcOvLL3Gp9dQGxiXelFdgyI7+QzSv47VjW X-Gm-Gg: ATEYQzx5jK+Ikn1LmKxu6OLmRM3J98FR69zKWlLvKnLjcHXhB2oQ5+OjSsIX4Nejn1R hFpBksrDKHScx0dtJrFK1JA+Hkyoj7Z8f2QyrWUJbAfuxmHG5mAfqDm666QxKoTWN0kxRFJ6wgI QjFWH2/8zsUN8jNF3rq9XF1YxuY49bdbLqaeW/SyzG8VWqpyCoz0XU8bParDQSea2sQdULO9QS+ frziplolQXpOuK2IJ47pZknmTu6CEmChTKC6gqGHkOPtRXREDgmvgp0zn3l65Hbz+x9E80+sRZJ cgOrYGx3RVZpd4hNKKl3OanE0A9D6KUESVamn5fUDobwpr09w/l5Kfzt+BhmA7aFMvXp53iqasK AdvG6ZtCW9MdnS7PeqpQGH6SkqrDTg8EPTY0jvxPz7n1V39lMEytDBqgFdy1mZyi2pqvOVGyaDs y28HEQepYhYxmOIgZmXxdbCyPmgCa91D3k1QcLVMA0Rp8uIwJ8KRgzrHx5dKD8z+YRBPOT6HnIN cuxlaWP4lODinHK0Zq6sJon4BBT/nfPA/g= X-Received: by 2002:a05:690c:e363:b0:794:ff4d:91f5 with SMTP id 00721157ae682-79828ef4ab3mr119620267b3.11.1771973328177; Tue, 24 Feb 2026 14:48:48 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7982dd88efcsm48838757b3.24.2026.02.24.14.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 14:48:47 -0800 (PST) From: Ethan Tidmore To: linusw@kernel.org, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v3 3/4] iio: gyro: mpu3050: Move iio_device_register() to correct location Date: Tue, 24 Feb 2026 16:48:17 -0600 Message-ID: <20260224224818.2452675-4-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260224224818.2452675-1-ethantidmore06@gmail.com> References: <20260224224818.2452675-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" iio_device_register() should be at the end of the probe function to prevent race conditions. Place iio_device_register() at the end of the probe function and place iio_device_unregister() accordingly. Fixes: 3904b28efb2c7 ("iio: gyro: Add driver for the MPU-3050 gyroscope") Suggested-by: Jonathan Cameron Reviewed-by: Linus Walleij Signed-off-by: Ethan Tidmore Reviewed-by: Andy Shevchenko --- v3:=20 - Remove stray change. - Fix grammar with "the". v2: - Patch added to series. drivers/iio/gyro/mpu3050-core.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-cor= e.c index b6e05afbe512..b590cf6709b4 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -1218,12 +1218,6 @@ int mpu3050_common_probe(struct device *dev, goto err_power_down; } =20 - ret =3D iio_device_register(indio_dev); - if (ret) { - dev_err(dev, "device register failed\n"); - goto err_cleanup_buffer; - } - dev_set_drvdata(dev, indio_dev); =20 /* Check if we have an assigned IRQ to use as trigger */ @@ -1246,9 +1240,20 @@ int mpu3050_common_probe(struct device *dev, pm_runtime_use_autosuspend(dev); pm_runtime_put(dev); =20 + ret =3D iio_device_register(indio_dev); + if (ret) { + dev_err(dev, "device register failed\n"); + goto err_iio_device_register; + } + return 0; =20 -err_cleanup_buffer: +err_iio_device_register: + pm_runtime_get_sync(dev); + pm_runtime_put_noidle(dev); + pm_runtime_disable(dev); + if (irq) + free_irq(mpu3050->irq, mpu3050->trig); iio_triggered_buffer_cleanup(indio_dev); err_power_down: mpu3050_power_down(mpu3050); @@ -1261,13 +1266,13 @@ void mpu3050_common_remove(struct device *dev) struct iio_dev *indio_dev =3D dev_get_drvdata(dev); struct mpu3050 *mpu3050 =3D iio_priv(indio_dev); =20 + iio_device_unregister(indio_dev); pm_runtime_get_sync(dev); pm_runtime_put_noidle(dev); pm_runtime_disable(dev); iio_triggered_buffer_cleanup(indio_dev); if (mpu3050->irq) free_irq(mpu3050->irq, mpu3050->trig); - iio_device_unregister(indio_dev); mpu3050_power_down(mpu3050); } =20 --=20 2.53.0 From nobody Fri Apr 17 00:18:00 2026 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0904834D392 for ; Tue, 24 Feb 2026 22:48:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973331; cv=none; b=ndIIwqc++VLM5XG1b9+BSOpfVdcjIyoYbgIaiVzatOKhUDgghptzFXfT7M4hg0Z6EuCA/o1XqyQtHbOTBidTsSyD4ZnSdl+tIOo+dDU4OIMRJq3K+pS2U/U1Tc86SMdga641EA33fBHA68TzsVYRCkfjh7citWXjHArleDQuY4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973331; c=relaxed/simple; bh=87sS0UYgorWoX8zJjAzH+m8FHvNWIjW0Sr46L/Z9XdU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IeQhK9TCwIY9KTeNG45pZ9VR/Ffihvf/dOP0LMsfHwR2BocXT2GvyOrrPXjVsZxU7QQdO9fSto2tMag1goxGXC0OznaKUjhAUPD871ptEl+3l9BwvH+uW1ttXH2TbdNWdybr+AJ8NcVP+Zs0HwWMzZ8fob8WWMxSUm6+Phb/GYs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bIC+aRbe; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bIC+aRbe" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-794719afcd4so63163117b3.1 for ; Tue, 24 Feb 2026 14:48:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771973329; x=1772578129; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PjFCc9fUHwXOM0/lOlNHausj+/UuScSKHK981LKSloc=; b=bIC+aRbery+ZhDmzE7VKvnRCzlDUry+tvKnWWLEdqj1SyGYW6k8J5eVlsQ2jqIakAI T7+Y5mjr0kFtPCNv3UB/ew4xV6nID1svf7Oewl914m43EZ0BCmrxLi/X7LO+T87kuurl eqMO6+enL3gfU9H39IJ8OWHRc29Pi29A/a36AZ5ts7bd9zWqq7cLK8yJDeDKQwQYLCxc ziy4WDhVeI6yuMWWZ8xZGzLI1FfvBdLmqWQagpEBrx4TH3ACGnExjpnhPte9kTE96/6o n7lcHzL7AQwz74BWIU9Tribdq6u5SrvvpD9+WqPUWdvbeDHok9K8uQpr80RK5AYss8gj 8clA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771973329; x=1772578129; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PjFCc9fUHwXOM0/lOlNHausj+/UuScSKHK981LKSloc=; b=VUcFEwQ1YdXY/teac1aj8QiHd8zyfQOdDUG410HCdgaVdn+BcNJib5bL7uFwBBv2HW HGKliPoo9rxp2nJeL+LsFpOM+xUkQZ5fMe5m1zcetwBs6hKGpgRJ0renxNvhdo2bb4/w s5WWL9KL6uj76Wfr5zuG1TtU/ZVREq6pL1TMUdO08Iy/o8DMlbxcTVs2XoNfafhUrxPG FvirRzBlow/g7UaDpm3xj3hyGbBEqi6XNmPjEWvJ1N7FgP1PzIgSg1P1/H8lgNsjbIl6 G3IhR/i8+qFIIvzYJai+i3FwiJVLvdcLN8Ef4xrrRoqfBzUCkwDA5652ejcK/UumFkNt HruA== X-Forwarded-Encrypted: i=1; AJvYcCUmxeePw/a2pid18vQF4UvZk61OD5Yk7O+Iosf4epoRFMAwBAL7YpNBcTvRHUrQarUpnzGANRR3rBEFHU8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6qxyoLj3pCNeeDHeKK7RhWXkDEF2nv+UW1szD8yDjKxzLcxCV rVR/xKDnS4xRjyotMmJ98+DuLVDlcJz8zMCOmX778N5OxSe2nBy3A9f0P/jTxrDZTdg= X-Gm-Gg: ATEYQzwHoRrzE19ZONq/ciUKhvCHU7A2nOi+wL8ZkBQ0rEkdJtWYsBZ9Ga/lWSoCfVu 9P+RpOnGuEWaYvezvCYRlS5qs9Lcm2CSnh0Zqt+Nb43KzCM7FrT+lLF/O0qLpKMBBUztxKhA8/Q EGkbR7rHDk/k083TEk7/fwJ9EzAHoaQR5UyrTgnkNvVnS7uzt3IHiG/gMDVNCXJk5o0IBoN9r6Q YXsPpK4c04Go8Quf0a/kwEXurVqTDNQZPKPhlXz7QuTb9Z71iWSJ3y9JXRuT42mMS1yDWjn8o3a 7wS99GWXNBAsqMHOZursvguBedC4kLXXySgCKhZRXJvrvn2D7CE4b8vVDQ2TGABSX5yeq5p9AmK 85jqnyDpoyKPzTDESNV/dXPT9+XGIdd7eb2POBPAd6SsaaAFogsutIfiEtGALnRlWv7rPA8VU8S RJWsz7HPtMGvF8LQC3+6JQfUYwC4UIiXUp3cN3Eptacbas7o5khf5i3KVS4XZjGJ7fz2CkgyuAh qKiEkVxjj3todu9OUOptYCT X-Received: by 2002:a05:690c:102:b0:798:6042:12d6 with SMTP id 00721157ae682-798604218f9mr25224017b3.60.1771973329118; Tue, 24 Feb 2026 14:48:49 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7982dd88efcsm48838757b3.24.2026.02.24.14.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 14:48:48 -0800 (PST) From: Ethan Tidmore To: linusw@kernel.org, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v3 4/4] iio: gyro: mpu3050: Fix out-of-sequence free_irq() Date: Tue, 24 Feb 2026 16:48:18 -0600 Message-ID: <20260224224818.2452675-5-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260224224818.2452675-1-ethantidmore06@gmail.com> References: <20260224224818.2452675-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The triggered buffer is initialized before the IRQ is requested. The removal path currently calls iio_triggered_buffer_cleanup() before=20 free_irq(). This violates the expected LIFO.=20 Place free_irq() in correct location. Fixes: 3904b28efb2c7 ("iio: gyro: Add driver for the MPU-3050 gyroscope") Suggested-by: Jonathan Cameron Reviewed-by: Linus Walleij Signed-off-by: Ethan Tidmore Reviewed-by: Andy Shevchenko --- v3:=20 - Clarify patch purpose v2: - Patch added to series. drivers/iio/gyro/mpu3050-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-cor= e.c index b590cf6709b4..f29c9ce63029 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -1270,9 +1270,9 @@ void mpu3050_common_remove(struct device *dev) pm_runtime_get_sync(dev); pm_runtime_put_noidle(dev); pm_runtime_disable(dev); - iio_triggered_buffer_cleanup(indio_dev); if (mpu3050->irq) free_irq(mpu3050->irq, mpu3050->trig); + iio_triggered_buffer_cleanup(indio_dev); mpu3050_power_down(mpu3050); } =20 --=20 2.53.0