From nobody Thu Apr 2 06:32:00 2026 Received: from flow-a2-smtp.messagingengine.com (flow-a2-smtp.messagingengine.com [103.168.172.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 580D233C1B7; Tue, 24 Feb 2026 22:26:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.137 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771971977; cv=none; b=DvzhyJkhBG/mX6utGdtL0AS6Y0uait3d9nSlrolq7SYAeSEqyxkSfvf8TOx5I8Tv4fqriazrzySFlFsvyYjwxtCq4sMSktXx+feedE2jyWh3DGleurZ8QsrnSWt632pa46eu2IdRHUMPgd+yg+/PZKTnCKn/WpqgxQPSPbB3nuI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771971977; c=relaxed/simple; bh=EWcvGbpStxBrKNDwCaNU/qsj2uNCtRG9uAAL8HCuTAg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bip3gv8WQem5c3lvMEn/40MftJVq/IcO5M2sIAOl4A8VUztDelGxXr56GppFtQhgizhUT/3BxwGGdyFrL7D4mzjg3mDI5PAn9r/kk1rkVrFyw/rHC+Vddr4EIQD2WXq3bndUmxsgMZGsldT0CPElxkOnAdq90s+/rihuvnh2Zdw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ownmail.net; spf=pass smtp.mailfrom=ownmail.net; dkim=pass (2048-bit key) header.d=ownmail.net header.i=@ownmail.net header.b=GBOmuITS; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=ji6BHf6a; arc=none smtp.client-ip=103.168.172.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ownmail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ownmail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ownmail.net header.i=@ownmail.net header.b="GBOmuITS"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ji6BHf6a" Received: from phl-compute-12.internal (phl-compute-12.internal [10.202.2.52]) by mailflow.phl.internal (Postfix) with ESMTP id C491D13802AD; Tue, 24 Feb 2026 17:26:15 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Tue, 24 Feb 2026 17:26:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ownmail.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:subject:subject:to:to; s=fm3; t=1771971975; x=1771979175; bh=tPobfa0i3jHvv1Dk9y6zx4amsTjnJAZYw4PN6GvcHrM=; b= GBOmuITSxnJ0zBVJ+LVfhDX24n3oxRgOKWRz0aHEofjwaEv0YNuaedYRJ95TGwAd RYQ0aT8EVoXoOYakO8/SJ2QWzdzf7u9RtKyGUxl9eJcw7D1Y2mJuqRqvS+mDs3IE vFCaoptFxzMkHzPCRyvfBEDVLWYUU23dnKMYBiynw02k0CtWISG3guFyIgnirdm0 zddj8N+H7cLy+O0p+kmddNH+zBTC2lLY5rEDBYikyqtFC96vM36VCq75W4DxP1Na 55A99XpQYaomtAKsptlrssepaxWJir8G86kpidVKKJwfkmhmcSLYFBu2puzqK/aC C77yncxWTkVZ0GDj+n9gzA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1771971975; x=1771979175; bh=t Pobfa0i3jHvv1Dk9y6zx4amsTjnJAZYw4PN6GvcHrM=; b=ji6BHf6ag+iUvrc9d ti0YI3wi2DWW8jNzZyWp7fqtOBGrwcJIgaBqidIciiHfIEtCOFaH6DJYCy4IIZif 74JGqmMn+bl+bBLM0vZr0XYO2dIqdD6k76nSM+4861sB7clcrLOB5cqT0lOFTj0c hYFXQ1gWl3xdh0Z6fqItxNV6dXbtZ3qR1RqGoocQwZK6rfGYeHQvIs3yqZOELygu N3Z6eOT4BQUyyRkiTd0Y9m30UQz2N5PHzcm8YHhem1ZpTe0BAevq5afIN0Vdk2PU P7paQ1+yfyfGySjhJP/M0Jq2s20yQpxEC1+FfJTkEOVBnj3g7zTNX3UE8em8QAv+ X5vWA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvgedufeekucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefufffkofgjfhhrggfgsedtkeertdertddtnecuhfhrohhmpefpvghilheu rhhofihnuceonhgvihhlsgesohifnhhmrghilhdrnhgvtheqnecuggftrfgrthhtvghrnh epveevkeffudeuvefhieeghffgudektdelkeejiedtjedugfeukedvkeffvdefvddunecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepnhgvihhlsg esohifnhhmrghilhdrnhgvthdpnhgspghrtghpthhtohepvddvpdhmohguvgepshhmthhp ohhuthdprhgtphhtthhopehvihhrohesiigvnhhivhdrlhhinhhugidrohhrghdruhhkpd hrtghpthhtohepshgvlhhinhhugiesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphht thhopehlihhnuhigqdhunhhiohhnfhhssehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtg hpthhtoheplhhinhhugidqshgvtghurhhithihqdhmohguuhhlvgesvhhgvghrrdhkvghr nhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhnfhhssehvghgvrhdrkhgvrhhnvg hlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhn vghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqfhhsuggvvhgvlhesvhhgvghrrdhkvg hrnhgvlhdrohhrghdprhgtphhtthhopehmihhklhhoshesshiivghrvgguihdrhhhupdhr tghpthhtohepjhgrtghksehsuhhsvgdrtgii X-ME-Proxy: Feedback-ID: i9d664b8f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 Feb 2026 17:26:09 -0500 (EST) From: NeilBrown To: Christian Brauner , Alexander Viro , David Howells , Jan Kara , Chuck Lever , Jeff Layton , Miklos Szeredi , Amir Goldstein , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , "Darrick J. Wong" Cc: linux-kernel@vger.kernel.org, netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Subject: [PATCH v3 02/15] fs/proc: Don't lock root inode when creating "self" and "thread-self" Date: Wed, 25 Feb 2026 09:16:47 +1100 Message-ID: <20260224222542.3458677-3-neilb@ownmail.net> X-Mailer: git-send-email 2.50.0.107.gf914562f5916.dirty In-Reply-To: <20260224222542.3458677-1-neilb@ownmail.net> References: <20260224222542.3458677-1-neilb@ownmail.net> Reply-To: NeilBrown Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: NeilBrown proc_setup_self() and proc_setup_thread_self() are only called from proc_fill_super() which is before the filesystem is "live". So there is no need to lock the root directory when adding "self" and "thread-self". This is clear from simple_fill_super() which provides similar functionality for other filesystems and does not lock anything. The locking is not harmful, except that it may be confusing to a reader. As part of an effort to centralise all locking for directories for name-based operations (prior to changing some locking rules), it is simplest to remove the locking here. Reviewed-by: Jeff Layton Signed-off-by: NeilBrown --- fs/proc/self.c | 3 --- fs/proc/thread_self.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/fs/proc/self.c b/fs/proc/self.c index 62d2c0cfe35c..56adf1c68f7a 100644 --- a/fs/proc/self.c +++ b/fs/proc/self.c @@ -35,11 +35,9 @@ unsigned self_inum __ro_after_init; =20 int proc_setup_self(struct super_block *s) { - struct inode *root_inode =3D d_inode(s->s_root); struct dentry *self; int ret =3D -ENOMEM; =20 - inode_lock(root_inode); self =3D d_alloc_name(s->s_root, "self"); if (self) { struct inode *inode =3D new_inode(s); @@ -55,7 +53,6 @@ int proc_setup_self(struct super_block *s) } dput(self); } - inode_unlock(root_inode); =20 if (ret) pr_err("proc_fill_super: can't allocate /proc/self\n"); diff --git a/fs/proc/thread_self.c b/fs/proc/thread_self.c index d6113dbe58e0..61ac62c3fd9f 100644 --- a/fs/proc/thread_self.c +++ b/fs/proc/thread_self.c @@ -35,11 +35,9 @@ unsigned thread_self_inum __ro_after_init; =20 int proc_setup_thread_self(struct super_block *s) { - struct inode *root_inode =3D d_inode(s->s_root); struct dentry *thread_self; int ret =3D -ENOMEM; =20 - inode_lock(root_inode); thread_self =3D d_alloc_name(s->s_root, "thread-self"); if (thread_self) { struct inode *inode =3D new_inode(s); @@ -55,7 +53,6 @@ int proc_setup_thread_self(struct super_block *s) } dput(thread_self); } - inode_unlock(root_inode); =20 if (ret) pr_err("proc_fill_super: can't allocate /proc/thread-self\n"); --=20 2.50.0.107.gf914562f5916.dirty