From nobody Fri Apr 17 00:17:54 2026 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9CCF39E6CD for ; Tue, 24 Feb 2026 19:26:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771961184; cv=none; b=QZ9UhSFi1Hsy8qnr9u20NU/ODQ3c0AmHA5gOT2zW3l+ePsgHNj/9/wxtE1ofzotnJnix5IQNTYqj6dWJZ/OmbKePMOkpDDi1jCEkdH9R+gtPGIssL5/D7L6v4ZwqUTYA/m+Epo99WVtirBo2H4bxIsW2osIZ98aZ5hYrxtUMVZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771961184; c=relaxed/simple; bh=+NIoaXNqhh+QliITi8c4WI3MgTvUajoxiCbgjlhg90Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Y4uUC17ivO+5t9YrTru1N6GWKrkFGojz1B50Ba4j/dotTJElhsL/zBQijlNZFRv78SbejmGHMXXOQzO9S+Gpe9s0i+iUalqBEiuivbTlzU+Tjhw6IugL8UYjp/6K7+cVbu+SoNDcBu2JXp62gtX35+EUmSxou9O8hywyo1Y/ngk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CibMNNtJ; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CibMNNtJ" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-79863ab8478so5449357b3.3 for ; Tue, 24 Feb 2026 11:26:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771961182; x=1772565982; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=V0Y/rmePv3yFMUN4F3W1Ur6uXEINhlgG2tZ1RiTQJ9o=; b=CibMNNtJplBJAqJACgiQFOlx/ZYoWtMOZ/paRx3qNnMENMf+sIlN+hgw7xFNF53uDY 7foPXnpfy2ZOgLRu9p27wcXpjJ+3f5x43MAQ8v1oTcmLdzrIFZCqhlZpG1ninXrMvANB e67BFCrCdPKIUTkvkJec/64VOLeQyr0+tfkrvexfyAxEvQtXzNoVhqnhlpXdYbd07hXF VFB7eHWg/lzdGVhizCo09zAw4vHF6NEfNNjJCOMjGikrNDjAExlv+NC+0C8YdcvtA47u wAiImSEOVFPoNBeVrum/GFewUlhOyqoeGX5CvqCGbaEJ5SCi4UN5QJBB1vtmioHwE8qz QoZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771961182; x=1772565982; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V0Y/rmePv3yFMUN4F3W1Ur6uXEINhlgG2tZ1RiTQJ9o=; b=UnUsxIxpzcfOixmA5fqvfU0SBKvvBqVF03peqNN6UbaeJk2vzTtp9JGa7f53La+Ctc nLM1+yv9s1kYqSMxfMmw6Meg4VxiT4zuzt9xf82sdYwshMu/zH4gHAt2q8Gcrb/EhSz7 gqkiNZ2tagpESu3s2zDdPkmDgoOLQhQAQLVyVqnXYtmPfV8ETF3zzpSRK+or0JwP+6T5 IN4ROYUhY7nv+EkkCS7/f0z84rDUQcW78cDnt56MBmfoo6+4Wvt8l7LO9RGa5Nvm10Vw 3HadQFiixiC/duPAoFaTSKk9IY6DZ5oOVNU1cE/msirbW5DdB4AdpfxYuL8oiJRA4AqI kc1Q== X-Forwarded-Encrypted: i=1; AJvYcCULMjekqPItJurvTo1SnMwogAfTc1Mf473SvIk2xrug3jG9MiwG3Dsk0KyU7PgZKiPm/ecvhEkLQ8pmc7Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzHz2mm5BpIVzF9xvp2o54pEdMYQlNWD1OrsHiPhriBnOKZj+zL nAf3yxUXEK26CC/ZydjDBSuDTxIc0+8EiOe00gr6NUW93pzwF1SEDLZ2 X-Gm-Gg: ATEYQzzoiMJWxr7eZkX222fwfMOwFoWKI/8cAeZAknS9+npjwqu55xnUSvHILC2L3o9 LGfFcFebQkmeWoMTq2Fb4CNtIz6VBDCVsubwc/MvJE6NCs7Fw8rkUouP4QSvzHziwqLhh3dpz/S DTF2t1TIirdCJ74/UQAmAb/LLUGvYp7cd8C5YaOYhmnO9nV2u/AUwkyKPBBlPPaHJkwqLPQWZAB 7i20dnCEl2Fw4rrCpvtOvs5D8u7AJDqSqHEWyHgkVD6Xaav/1e9W1WCUDoSRsZ8Zz+6knIPMeW5 AYjElto/HrqVdOKAS4tXX1YrAOJreohXs8xgOC47prtOcvId9/GdtQj3uKLasdy4jHQ0/Xf2WWd n6lWRgP1/LtOlcwYUlXBr5UX31i+1nzUXJCH12rEDBoI+XBKkh0zHpXCJSs4UoS8PULwafqoBig RHF32RxKq7cbaIe+ik9FbFbCBbLNAI76xOBRai3CXRZOsTgKq/7yXbkQRXRIDwxKz+gAguJM/ph dGZwrcc7L24C9hLL8sO17Mt X-Received: by 2002:a05:690c:2010:b0:796:5b5e:f4fd with SMTP id 00721157ae682-79828f4d958mr98404927b3.29.1771961181820; Tue, 24 Feb 2026 11:26:21 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7985e72cfb4sm5949577b3.42.2026.02.24.11.26.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 11:26:21 -0800 (PST) From: Ethan Tidmore To: Christian Brauner , Hugh Dickins , Andrew Morton Cc: Baolin Wang , "Darrick J. Wong" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] shmem: Replace IS_ERR() with IS_ERR_OR_NULL Date: Tue, 24 Feb 2026 13:25:59 -0600 Message-ID: <20260224192559.2429005-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The CLASS(simple_xattr) macro can return an error pointer or null. The variable new_xattr is only checked for error pointer. Add check for null. Detected by Smatch: mm/shmem.c:4284 shmem_initxattrs() warn: 'new_xattr' can also be NULL Fixes: 200a524407b8d ("shmem: adapt to rhashtable-based simple_xattrs with = lazy allocation") Signed-off-by: Ethan Tidmore --- mm/shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/shmem.c b/mm/shmem.c index 805402e8c841..c97e5ff34d03 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -4277,7 +4277,7 @@ static int shmem_initxattrs(struct inode *inode, =20 for (xattr =3D xattr_array; xattr->name !=3D NULL; xattr++) { CLASS(simple_xattr, new_xattr)(xattr->value, xattr->value_len); - if (IS_ERR(new_xattr)) + if (IS_ERR_OR_NULL(new_xattr)) break; =20 len =3D strlen(xattr->name) + 1; --=20 2.53.0