From nobody Sun Apr 5 21:14:44 2026 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7594D1E9B3D for ; Tue, 24 Feb 2026 18:08:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771956497; cv=none; b=HPMMlwCn2adjtw72mGfho5TvYkOvFN/TouiBqB7FpCvOpl1xNOrV/CNI/5EYqQ9jNBFetlgYKMFSsy8iQbR5nbcwsLyhy0gCWuOqbBa28vnkcv/ETy2O/iEBIPZIx9FUriTYI5yYAOKegtTyRDRe354ieOTw6492HSeVxKVeSWI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771956497; c=relaxed/simple; bh=lYSFLw0xah4h/+68xrRS+X6hzYryo1L2cUiMAzxuTP8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oRT+pJLXZKndw9aDbvqbSUkM7WtospFn5fkWKo9co8zZDL/qdxi5YXTWT6h5GNpCM06uDt/32Hfqp6KrvrHlol1Nx+xrhd0/N1sZBF9pWMaYWkezUtkVLpLecyF99Fsnx+oy0NxacExlSSYOZ4ITBol9zvK/MRkPUlTbtoQD1zE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c4a5+QDa; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c4a5+QDa" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-59e60b3ccdfso7577562e87.0 for ; Tue, 24 Feb 2026 10:08:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771956495; x=1772561295; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GgYaJHOEUtfkRSeV4/ucyw2w3tzEF0ffgSH0n+B20gI=; b=c4a5+QDa9Qt2gtvLCuvTDkxODPN58Zz3brNyYxQqoRfeeCL3oM4Py++7DLHKfTygtF Qq/uA6RsXngk+Xa4UdE8obMxUp82moCWe9WZTlYXuBGkJPPQ0khrySFm7N4fLGdkROmM 5v0BYt3JofM95tadqZa+Iftabp/eT/zqI3fD1lqc7ScqBkdvsCTE6Ts1WvUGrXaZ5fme loCfyzuJbxLzW5tAvjT6uCkacn1y6HyoqXX+kC2A/BUfWACoaGcn8aPEyblIJTUKAsAI /X+TtQYn9zper+epEZ7r+JQ6Rq0TCsH9cRJKC+4rsLh3m+xm5yDi6uwnFKwyQC7KQTvM C7dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771956495; x=1772561295; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GgYaJHOEUtfkRSeV4/ucyw2w3tzEF0ffgSH0n+B20gI=; b=c5a/fvSH4Vxk5L723M9dVERD3/FJXpW5r1XBRx/u5amde5yAMW7/w67y+GbJfD2SFv Ol5DAHFC+FPoTNjQlAghDA+uP3n3FkKqlVpWNavN6XjjgLSLrXNPZ0BVo0DCkki1UMaw CVZyrBwYqAJvXxTGncmMZzSVlSX/Sw/ozngVp9wVDfl6wCehpIyOpGUaCi2Ga7yjve8F Xs5qwxoI7uJJNMeV89Aj8NMtmEA5Kxz7ajeRqkEmIOMon7LTfGOgkMG6o6WJVwhMLtZo 56rg7GEaRrgkmiZHSGpRCe6+vhEawdzHefkBLNYi4rdsAJKbstMfa44VMfIKnHdsUQwG LkWA== X-Forwarded-Encrypted: i=1; AJvYcCUKiBPosPBM1TiNkcpR5Kn/JsDIgcJ36GqMsqR0mddLpGCfdUeQrGr2m7K58NB19g5o5AKHO+hCPKql1Ew=@vger.kernel.org X-Gm-Message-State: AOJu0Yzpc8E72a5AazY7iYTWWf99gR5zzN2g6lUMfQd6aL1W6WbYs/B1 LepyEFfGlLLEWmUT/IQZi+rm/PrzQfy2fLVP3jUYflmBlYU0YnkvjHy6 X-Gm-Gg: ATEYQzzigtwGQ5/PHRPBny+ZGSqJhmID2VEIGi/Du0NwkU071GftZ+6Lg7uU3J8bSbM oatu3tbn7jxNkguUuAE5IKv09W6hIUUN7PdGAMmrLl5f5Diuz4jPuP4MXLcpV0zKwlGYOCYEX19 vgkFA1C0YF8WV6fQLSzhRev/KyDZSsrTTqbJ5gB9tx8WlB8ZxHKKec1F7yd2oqPWGZ0tB9WGQfv Kmq9PHDrHXfjOUtK+fzNrrvfaJwIUG3xyIO0Aout5MPdwaPpVUm1Qq8QEKaQsiHjdv0+6/rMY11 uSMF90ibAfToGE2fAcw9i4qLUaFxx+lzotKFQ6NwOKp4ECFydW0KDG7RG+hRDfhN4/chp1KhyvK 9QAswrgOxRsYOx7DGAMfAkXxvmhdLXKN5I1LfXFQv0kyp9Zkt6OhvwAfCawBCWYDVd+feRvttj9 yPvAZRQ3223NbxwENFtm/3iyELNorOxX+RPZvQhtSYu3MDmOaVtdMauDwvDZRd7fFb3pSy0npYE RH6lnYed5acRU7lHA== X-Received: by 2002:a05:6512:b1a:b0:5a0:f330:2c6b with SMTP id 2adb3069b0e04-5a0f3302c97mr2866539e87.37.1771956494602; Tue, 24 Feb 2026 10:08:14 -0800 (PST) Received: from localhost.localdomain (46-138-191-69.dynamic.spd-mgts.ru. [46.138.191.69]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a0eeb45ba7sm2394810e87.70.2026.02.24.10.08.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 10:08:14 -0800 (PST) From: Artem Lytkin To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Artem Lytkin Subject: [PATCH v3 2/3] staging: most: dim2: use dev_err_probe and proper error codes for clock Date: Tue, 24 Feb 2026 21:07:49 +0300 Message-ID: <20260224180750.28468-3-iprintercanon@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260224180750.28468-1-iprintercanon@gmail.com> References: <20260224180750.28468-1-iprintercanon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace hardcoded -EFAULT returns with dev_err_probe() and PTR_ERR() when devm_clk_get() fails in fsl_mx6_enable(). This ensures the correct error code is propagated (e.g. -EPROBE_DEFER for deferred probing) and avoids log noise during probe deferral. Signed-off-by: Artem Lytkin --- drivers/staging/most/dim2/dim2.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index cea1ba99caf7..e4c8b4995c61 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -921,10 +921,9 @@ static int fsl_mx6_enable(struct platform_device *pdev) int ret; =20 dev->clk =3D devm_clk_get(&pdev->dev, "mlb"); - if (IS_ERR(dev->clk)) { - dev_err(&pdev->dev, "unable to get mlb clock\n"); - return -EFAULT; - } + if (IS_ERR(dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk), + "unable to get mlb clock\n"); =20 ret =3D clk_prepare_enable(dev->clk); if (ret) { @@ -936,9 +935,9 @@ static int fsl_mx6_enable(struct platform_device *pdev) /* enable pll */ dev->clk_pll =3D devm_clk_get(&pdev->dev, "pll8_mlb"); if (IS_ERR(dev->clk_pll)) { - dev_err(&pdev->dev, "unable to get mlb pll clock\n"); clk_disable_unprepare(dev->clk); - return -EFAULT; + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk_pll), + "unable to get mlb pll clock\n"); } =20 writel(0x888, dev->io_base + 0x38); --=20 2.43.0