From nobody Fri Apr 17 00:17:21 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C94163A9DA7 for ; Tue, 24 Feb 2026 16:55:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771952106; cv=none; b=W45MNSIzNWegAwEyEYtWLUkxpC9kCvp6+FNa4lyEvMP8IFkob/e+z6HUBsY1EJ9uElkTcyNPFbNXCBRfBOjiiD+uWounxrvHgHOuQwRK74s00twS5OTNpPF2wWP+nLTLdKv3l3Pvx6dbsBa5RF7jxBSG+M0KQZXs50upbHbKCFM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771952106; c=relaxed/simple; bh=YQW0EfAeLICvyMNg/tfBC2TK594tWmLxtymR/cKwzGI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DNRa96KOMlxdwRsUajW84V5YKKJszrSnfB84m1ypD0Z9yIdZxg7WK7SdmW2UYjGcozB/QXAdot9aYBWLshg9jlR92CpstY4QypLhMaF4SNKen/ENq5S+X/fBCURnV+bbKjot4Ee3yYHL/WMzfYRTSlSbIHHkDexhQtFnR50MmKY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mwYJIlxL; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mwYJIlxL" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-82491fbf02cso3206585b3a.1 for ; Tue, 24 Feb 2026 08:55:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771952104; x=1772556904; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+qm9aAVKRhdXbmvZ9eNzRctppVAHInh8i2MIXKl/+Wg=; b=mwYJIlxLKjYKko/wvpn5zNTqn2jXpvmo24X3KL/Sly2GOmvJgmanjwa6FRfv8AmIxA GobsqqCl1Uca57eQb2CS74RpHbkc51PYcdApnoLaSgo/nJnFEmn19oWv9o4ndS6b1FuZ BDQqQ5wBiRfNnFSAHnJ5/dqNJWRWR76YUdn7nXRdcz3035bktqpMAcd3kdsDNqX18O2Z 7npt+V0pXaHV5Aa5Tbyqwxs37WYK8zUeKj9jSbTyKD6hYdmc92WjEDNGe9E9tgok0H0z HZEjlyQetw0rlq+L/aEsKdLeBVnrfamPuPhGVkB2MjDPA6gbPWORuWkhyYFyhkmL/Ynp mgXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771952104; x=1772556904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+qm9aAVKRhdXbmvZ9eNzRctppVAHInh8i2MIXKl/+Wg=; b=oML4L8hHOdOc369vwnhw01lNTDl4wqIs4c3fraFC8oQXIoUIYSfN9YSt3KLPr6kAMw Yf/45e/sF589lCdV7RfzKpCL3YMOWDNmLouISjR4/9nJjaE9Fx4pgJwcJj94ZQf5PmLW KcXSQnSk+BZYEYTL0nLtaj4gIFAW6XnYL927EmId5Mkaxbs+4D3mP62PxqvWDxeOzQSU 5Imdc1ve5yq06HdTAhmU5kbiLrN043s0NhlBWV6M912IU4Y29g/1KNYYK5tV3EnsQzRC /R4kic8QY4F+znBCVSUp48p7TiR8a5OYQMxkZhsw2aG0/l0dTtOujgbQxUw8K5v3Hoqt nVJQ== X-Forwarded-Encrypted: i=1; AJvYcCXZL+f5v+/zBbLhEObH24ArRRLnQZBoQZZVCAnNEhZSpzGGXr9VLY9KVzMF2QZL7QxS/xu7lSxmthNt6BE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyj/kuRGWQTc/ePxDemUzXUHmz/8L+BtxfIq5q/nkRO5I1BOyTf W1YanJsmZH8hz+mJuobhGg2vBzPlN3bWMJ5ktKalIO4F/B+sEhkaSDvX X-Gm-Gg: AZuq6aIQi5QZOmikOX+MKzzebsrB77b1x65D10LL1ARR0uYXZ0xDxltSXRCe06fU7ia 53+nsTWl/im3Q6Z9E2aqMyCYIiNco9rJ41dIKlaYRfhqWB3l9dwGouaGuBq3PRjjXWM3seYR9Gv jIWxNePpxx0pv5x33+AJmqQOW7DIc9jlZE+Fe/A1xnXYgOlSO1m9la6NynP+PokeU3C9kS1Y1Xq aka5vx9103kO1stVtf5+KcAeA3/gYBp9dgL9+12ctZK0ZzcLfFfRlANuE91jgN+MEVBnOzNjjRA uDsF4BAxCCbdLtWbAeTJ7vL/caSFumbRkvTDQFvY7wqrOOa0nWV7Dc//GxelefxOuU3oG36bgSy kL4YKKC7mOMqbl34tTMkBRe9W8r01ngTm+VnYyCXNh0+3Yx36OJN2j7+XZ5D/J5JjqIkwKfsYHP LcCGXyfYdQy3UAEBejwBYxXBLNcXRvHdKg0qeo/3lUbr/Paz0xWKeLHiyL5ne9fRims5SXQqnco g== X-Received: by 2002:a05:6a21:6d9a:b0:35f:b96d:af11 with SMTP id adf61e73a8af0-39545e3c7a7mr11945453637.5.1771952103875; Tue, 24 Feb 2026 08:55:03 -0800 (PST) Received: from sean-All-Series.. (59-115-199-112.dynamic-ip.hinet.net. [59.115.199.112]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70b7256f32sm12364083a12.27.2026.02.24.08.55.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 08:55:03 -0800 (PST) From: Sean Chang To: Andrew Lunn , nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev, trond.myklebust@hammerspace.com, anna@kernel.org Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v3 1/2] nfs: fix unused variable warning when CONFIG_SUNRPC_DEBUG is disabled Date: Wed, 25 Feb 2026 00:54:34 +0800 Message-Id: <20260224165435.17648-2-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224165435.17648-1-seanwascoding@gmail.com> References: <20260224165435.17648-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When CONFIG_SUNRPC_DEBUG is disabled, the dprintk() macro expands to an empty do-while loop. This causes variables used solely within dprintk() calls to appear unused to the compiler, triggering -Wunused-variable warnings. Fix this by adding __maybe_unused to the affected variables. This ensures the code builds cleanly across different configurations, including RISC-V, ARM, and ARM64 allmodconfig, as verified in the mailing list discussion. Signed-off-by: Sean Chang --- fs/nfs/flexfilelayout/flexfilelayout.c | 2 +- fs/nfs/flexfilelayout/flexfilelayoutdev.c | 3 ++- fs/nfs/nfs4proc.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/nfs/flexfilelayout/flexfilelayout.c b/fs/nfs/flexfilelayout= /flexfilelayout.c index 9056f05a67dc..de9e8bad6af2 100644 --- a/fs/nfs/flexfilelayout/flexfilelayout.c +++ b/fs/nfs/flexfilelayout/flexfilelayout.c @@ -1502,7 +1502,7 @@ static void ff_layout_io_track_ds_error(struct pnfs_l= ayout_segment *lseg, { struct nfs4_ff_layout_mirror *mirror; u32 status =3D *op_status; - int err; + int err __maybe_unused; =20 if (status =3D=3D 0) { switch (error) { diff --git a/fs/nfs/flexfilelayout/flexfilelayoutdev.c b/fs/nfs/flexfilelay= out/flexfilelayoutdev.c index c2d8a13a9dbd..3fb8dba0abf5 100644 --- a/fs/nfs/flexfilelayout/flexfilelayoutdev.c +++ b/fs/nfs/flexfilelayout/flexfilelayoutdev.c @@ -53,7 +53,8 @@ nfs4_ff_alloc_deviceid_node(struct nfs_server *server, st= ruct pnfs_device *pdev, u32 mp_count; u32 version_count; __be32 *p; - int i, ret =3D -ENOMEM; + int i; + int ret __maybe_unused =3D -ENOMEM; =20 /* set up xdr stream */ scratch =3D folio_alloc(gfp_flags, 0); diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 180229320731..f76c23cdc888 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -9241,7 +9241,7 @@ static int _nfs4_proc_create_session(struct nfs_clien= t *clp, int nfs4_proc_create_session(struct nfs_client *clp, const struct cred *cr= ed) { int status; - unsigned *ptr; + unsigned *ptr __maybe_unused; struct nfs4_session *session =3D clp->cl_session; struct nfs4_add_xprt_data xprtdata =3D { .clp =3D clp, --=20 2.34.1 From nobody Fri Apr 17 00:17:21 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18FCF3A9DAF for ; Tue, 24 Feb 2026 16:55:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771952109; cv=none; b=p8HFXlBYrpYHrQnGVL8sBE/1I3hGoridxitZxg6m56UR72q5CJYTlKSACmZie4qH3+2rELGdBxwvej6YKwp9sCOiZFdP+s3mq21avOW8jv5miOEVJtC8dG7/NFDi17FbXlfebqNT07gdXGozHKws1N54xWtI6ZhIOpzikna55Ss= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771952109; c=relaxed/simple; bh=6D2xm2u7a0Ard8UD5jhMoGvejwPvgyeFwzrZ6ep9k/s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ry7jNC8LNu8fbWmT3t4+XTyD4TizvLvVGa687Nj43EadNYaRs66oUp6kiacS5IkcvfFYp++2pgtaefsQjpGjhPziBSM222yDCjGrhNI8LCNqrwa0DPzdhBHFCDmTCJhBMkUF0DpOuNOMI8onGcEu7FlsNfjrClTaRIqT/p0L6oQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b5lf/U2e; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b5lf/U2e" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2aae4816912so39891925ad.2 for ; Tue, 24 Feb 2026 08:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771952107; x=1772556907; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/dk99oPBkOKQC4NJdNNbbUKUujZV8OZzxFj2+2UXmSY=; b=b5lf/U2e+Fzcg26x6XgKDfQlnHZEW4cshIEkFjtlRi33fVqo5AS8ha4h8ABOtZaB/U xy3UjcOwnWvjtcqFAtYbVsdOSgn/SClA3t5l1GSkiwGooJgqJj13kPmriGJdwpAAMPU0 ipfXes1XdEzintpKmD+dZ1jBjI1Ccek1GDWOmFy8nFJIsA3TN2EKzryC52qYNvvm0iQJ ADF33DVBdCTyGSSmS0GtWDIBtNv2PO5i1yeDJcTsQi1YEZ5vOJIJOk7BFQrfd3Rgm8Vm yW40PBck7HXrZmRw+QFJdhc9aD9nKm8kETdQg8BN4rEvo/dwlm2Sl0tot9aJnhrpakmZ n3yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771952107; x=1772556907; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/dk99oPBkOKQC4NJdNNbbUKUujZV8OZzxFj2+2UXmSY=; b=FczkP+q26oVfEpu3VZNPRqVoqVB4jhutgW/FWCAhEJduFM1dZu1s7CKuUBoSNjZfmL 6hR8iTvzZASgIEWbK3AKeCzGxXFXME3pGpuHv0Q9BvfgX2uLWBnsrzeJdx0k+bQiXZMp Wdbbo02Mii3IyZzoSV6sqbZxqOgowt2bm4flEeq6Fe1tCrR79MyBeR+A+dqrmj7rwuoy T8RpTfEXqmy/Kud1bDrBKuBM0+XPiqW2PjlFoV4/wjafH9vt9+omshYc98qE4UDLo3se Lo41QnrFx4s2VGtT3cHd6Q6LeZn0ovCXjksruHz/SW4vDDOYUm0mxWitIYofqfCPLzXI mETw== X-Forwarded-Encrypted: i=1; AJvYcCWOOvkve6bX9gI2/NnfM1sq/uoX1uPQ19ljVi6f8gKXfiQm1LXkoupCnc0NkT++Xggq+TxPgMgs8Eoaa+E=@vger.kernel.org X-Gm-Message-State: AOJu0YzwiBk0P7ddiUFyCyvL5pmfZFaUsN2oBa0O2cFOW8ClUUyp3gr2 x5t0UhoyCsoM76PDSsmnlIxNXwXYNLuyijUklypPn9z3tx4fh2QFVc7s X-Gm-Gg: ATEYQzzkkvg/3wJq+T5N09xpadkyamuoxzlSDcm1ZwcQVNG2HHLuMCqraItylrOHN// MA2BPrIw3T8rv+5cHhlrJi98pSGwTaA9y4JLTLDiidTSYsh1mmtCSDktT+ZUlECsZaO3O4dK6IS M8GKj6UujbGuunSiaPwbiQ4d2VvBIL6vDMJTmTi/sMvSqLZta7BNmoRDQ6tS2Vq1w9WQUMFJ2IO RorllGc3MOvXSYKjyoMVc046Kf0m3PlwI/apaVzEk1HOrCAKKUDmjZXkshRn/+CzngMd+opJMrK EB7ZXFK0GrWF6/XFV3w9u/0u697HFFuHmQbXJmuC/WY1zsNbw/BbAiGkAaiEg7TprEc+J29d6ES N5T3l9ZIgS+2wmFhyHp1rtzM3uKx+5m9+7MrSlQkkkmbW6gcWJ9zCr/IxgsJ+JHxJ9HF0Z8RExF jllpaBn6IhDaWbYMQD1y7y1ZkzJmrl/5nZH8l3XxMXfSqJqOff8obkc6K3mgttYhQz9nQNkKPX1 Q== X-Received: by 2002:a17:903:285:b0:2ab:2bc5:4365 with SMTP id d9443c01a7336-2ad74464438mr87550565ad.19.1771952107313; Tue, 24 Feb 2026 08:55:07 -0800 (PST) Received: from sean-All-Series.. (59-115-199-112.dynamic-ip.hinet.net. [59.115.199.112]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70b7256f32sm12364083a12.27.2026.02.24.08.55.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 08:55:06 -0800 (PST) From: Sean Chang To: Andrew Lunn , nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev, trond.myklebust@hammerspace.com, anna@kernel.org Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v3 2/2] net: macb: use ethtool_sprintf to fill ethtool stats strings Date: Wed, 25 Feb 2026 00:54:35 +0800 Message-Id: <20260224165435.17648-3-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224165435.17648-1-seanwascoding@gmail.com> References: <20260224165435.17648-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The RISC-V toolchain triggers a stringop-truncation warning when using snprintf() with a fixed ETH_GSTRING_LEN (32 bytes) buffer. Convert the driver to use the modern ethtool_sprintf() API from linux/ethtool.h. This removes the need for manual snprintf() and memcpy() calls, handles the 32-byte padding automatically, and simplifies the logic by removing manual pointer arithmetic. Signed-off-by: Sean Chang Reviewed-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb_main.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/etherne= t/cadence/macb_main.c index 43cd013bb70e..616823e9fc5b 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -3145,7 +3145,6 @@ static int gem_get_sset_count(struct net_device *dev,= int sset) =20 static void gem_get_ethtool_strings(struct net_device *dev, u32 sset, u8 *= p) { - char stat_string[ETH_GSTRING_LEN]; struct macb *bp =3D netdev_priv(dev); struct macb_queue *queue; unsigned int i; @@ -3158,10 +3157,8 @@ static void gem_get_ethtool_strings(struct net_devic= e *dev, u32 sset, u8 *p) ETH_GSTRING_LEN); =20 for (q =3D 0, queue =3D bp->queues; q < bp->num_queues; ++q, ++queue) { - for (i =3D 0; i < QUEUE_STATS_LEN; i++, p +=3D ETH_GSTRING_LEN) { - snprintf(stat_string, ETH_GSTRING_LEN, "q%d_%s", - q, queue_statistics[i].stat_string); - memcpy(p, stat_string, ETH_GSTRING_LEN); + for (i =3D 0; i < QUEUE_STATS_LEN; i++) { + ethtool_sprintf(&p, "q%u_%s", q, queue_statistics[i].stat_string); } } break; --=20 2.34.1