From nobody Fri Apr 17 01:44:06 2026 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013042.outbound.protection.outlook.com [40.93.201.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 241F53803CF; Tue, 24 Feb 2026 11:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771933658; cv=fail; b=MYbyB6FCcrY4it/HmuSYVlfx67/1rQdYtm4u86Nja3UC9FpxvN3oq9DWzcH0Qbz8rYdg31cL3X5I2B67XtCxRj7WkwbtZ9qqBArFixPzR6U++7OZmBnifr0Lv1/KBKc9F1FIOGOOdMN41XMR8Wk0Aw5Ew7UKh/H/oqYF5oy3TA8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771933658; c=relaxed/simple; bh=1ZBdiV7NN106jLNjJmk40WAH1ZrqjMg0pVNOsuhPv/8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=f/l2f74RlgNmxiU06qJo8Xil4QCGb8UWuGjn+t2EH7KXyWCgsbRmSB3Z21h43Oj5SLzxzDxruR1Po73+wpbamuFkMgQDZgJpgX4akAFQd+E9m/Ddp+ZUJcKM1EdiSe0xJz5cET9iC0Vpgfb6fNpwHV0PBPvKFzpk5YYcAXbLWtg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=XyY3hJW1; arc=fail smtp.client-ip=40.93.201.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="XyY3hJW1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xbWtvZdbfQ6YC9oCRgWfDXfMlhAb4i/JFJCPfxYXg01ke8UQbhWnN/0mfnrEt4WA/ZdUBxEcOIQStduNi6lBQUabvq92VjAI8FrBsGzNg+MW460jO9YQqHKR2OiMBj4+wWRZ17zQSchw/zEV/Q3+D+yix8GNvv0HEuR4USGNIJecWlMfO1xLkHTlDv/9UIBamgDI9fMmpOQYwxoqDmflDd48SRm+aCXSPru3TtHQJe+iOJHe96Rg99vo5L2jKg6QTWXPx48J+tMEVAGQOg9sNCMOxtJtUneLujEZzWHA/dbdxPBwVjlTppikgmqct88sNa4kZ2W9o8YBLWvASTn3OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RYdApdyHuC1pU4T6cfs4TftWkH/ghgRsI/nus93GAcs=; b=yx8VaVpSxYebTctJpYfjIEknT9bK+Pgrwiv+SyqVyhQkFSt9ME0Cx28sSBpo9LRsTq9db7tcSxGDhpofGewhW+jPTw/zyMHHEFF/0yhmHhJI9K6y1maf5f63uVCCiVTHKezFNYxtZLsL2je9o9iZBQnOBcQ8y7wOLn/AI+bOCQvgnlGvQPyq4kL9NDyCmO6CKno2d+yJ6NsDC1U0sdxISmm672V0/VDl6PocOyFpAKnpbexERCxW8HYOANuE9hFWGREspqiyQpI7WtHhCHoqeGi5O9vKxqGkA0q9jGmy6ht6dD+vP2tEHvtKg5CDGHQ6kce7AwGK4X4jTCOdIwfjPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RYdApdyHuC1pU4T6cfs4TftWkH/ghgRsI/nus93GAcs=; b=XyY3hJW1jEXjSDOEk5VaYBdOVLG/Zn5sgfaLCL6/2o199OgraKLkk5yvLoVc/1Jf4HQb0ay46SNAJMrXDXOBXui5WaUyfjnRsAxDtJCzv8YHbf18Wnig9Hk/mNfvc5cocmIOpuG3gYxIXLeziN6gLOrQw7PoT0n8OUjMtX/737WPEBUhR5fvPRwfwh5oXe757NM5sFnwV0vB4J4ANwNnWzyH7gkz45/XOyr+KqGCl4EhxsN5FjV+8bI7b58Angf7M6wMM07DTBXkoC7v8f3CfcksnBle8TzSe9nht/CDBez+o53soysC79Htx4Cvug+25yMBisN10Q7cfhAW3h+GTA== Received: from BN0PR04CA0193.namprd04.prod.outlook.com (2603:10b6:408:e9::18) by BL4PR12MB9536.namprd12.prod.outlook.com (2603:10b6:208:590::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.22; Tue, 24 Feb 2026 11:47:32 +0000 Received: from BN2PEPF0000449D.namprd02.prod.outlook.com (2603:10b6:408:e9:cafe::2e) by BN0PR04CA0193.outlook.office365.com (2603:10b6:408:e9::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.22 via Frontend Transport; Tue, 24 Feb 2026 11:47:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF0000449D.mail.protection.outlook.com (10.167.243.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Tue, 24 Feb 2026 11:47:32 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 24 Feb 2026 03:47:18 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 24 Feb 2026 03:47:17 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Tue, 24 Feb 2026 03:47:13 -0800 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , , , , Gal Pressman , Dragos Tatulea , Shay Drory , Yevgeny Kliteynik , Alex Vesker Subject: [PATCH net 1/5] net/mlx5: DR, Fix circular locking dependency in dump Date: Tue, 24 Feb 2026 13:46:48 +0200 Message-ID: <20260224114652.1787431-2-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260224114652.1787431-1-tariqt@nvidia.com> References: <20260224114652.1787431-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF0000449D:EE_|BL4PR12MB9536:EE_ X-MS-Office365-Filtering-Correlation-Id: 54ae5f96-2618-4edd-3665-08de739a7f13 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?yb10Y7sAlfi+9wo8FiFV39fJrZogFl1zhyeHCDg3UpFzBMrUGEUiyfX10ug+?= =?us-ascii?Q?IuDgvm3UVtz8IYiqJggCGQa6beEyAk/VZQiIGMWL8LS/x9uE4Z9NPsLwmfyE?= =?us-ascii?Q?JZFUJ62OaPjroMnB/JAqY/DbrXaJOab/HeLwULUlL//ePpg9q46oqk471bV4?= =?us-ascii?Q?YTFUOKeoj/lJ5f+6DtOSoDzEoYIZp/23wTpqMqvi1DFsLPYr6qQtzfUJtd0x?= =?us-ascii?Q?B1gumYvk72Hjh3lPRYEcPPSWpyrWKH28e+k6MYJxUflxA+PGxXSiCcrDobN5?= =?us-ascii?Q?xvRv7Dbolin/13XD/3nY9NuV9q/PgdgswOHXcJaFUtVTePItL/+qJNR3i+VZ?= =?us-ascii?Q?lokquEyBYCnkn2ZrfVo0QhT9o1cQUOsWJ2TlNITekqYXWP1K/UF+5Dv6mEw+?= =?us-ascii?Q?OP/8sG3eNFUkoiue5Y9f6WeeD+gDoks1WI2YpHQLgh9SoGUSDyiKPqmi3Hlr?= =?us-ascii?Q?3fBHxn+Eu9SMOZ9XHsPGViqB/Er1FvJZeIw3rd4iMyIP/dWOmC/FXmYy8OZL?= =?us-ascii?Q?U8a77IxrAweldyjzgmkYmmuwDLKUvsz80WvsSnBw0fkcwlajI4LVZDwqsx/E?= =?us-ascii?Q?82ooXwJHPGlGPjTQf82XrOYZKqYQlMmZ9fN20OBk1FoWS+cxq7yop5vU80Qb?= =?us-ascii?Q?SjLWYntxOGF4M5CoFCQUg/eJ0jQMqbO+E1gfL/yeCxYMhkUcBJCSOaVpI9jH?= =?us-ascii?Q?JpNwVZOIkkKwAkSE3DQF5EXSN107REuVIE1sCxmSQhe7ZCQnoY/HMx4y0N3t?= =?us-ascii?Q?05XYtGy/KBYWFCnTd7t/VKzqkFEfSo7DvmFrJchBXFWetO3QGfR+mIrkzAIx?= =?us-ascii?Q?eH9b/xktbdCv51UqV1Iqq9vsQzPBQm8OWpsavNUBw043oME12KoC1KrMZgbm?= =?us-ascii?Q?x9xd2+2GpYDthwssIR5jZLvxV53SAbHZl4YUmev7drVjsKNcdclIv8/tBUbL?= =?us-ascii?Q?n6WEywGEXim1CNU4qhYUPEY8j7o3P50ud/XSQ6Yc0mDJ0CalLe76qtjvXJpj?= =?us-ascii?Q?PcHEuqCHQNuncSUC8OyAkzEzqyYuTy8WWakqh4gKtnqMtMExi1k04aPXiPRg?= =?us-ascii?Q?RCPhaKb3pBDF9RoPms1f79RXlifDUfL1qzHoBE07WIKDfbnpjHF2WjHfHfrg?= =?us-ascii?Q?+q3M8R4G2RyZwlOEt/1CuKkEa3H0ikzEqzoD0HLZ6iqxxRVb9gUb+oGuEzRH?= =?us-ascii?Q?wkn0/NFVXjjy4yzGWZlUq/q/ScGDwE2/lCcu5c7MNyNy8iTsSjhgxMJ/vVG8?= =?us-ascii?Q?rIz4GJHaRzClmJB73cJ1O11lRW+mlBM4Ky0BpJ8fTCf4QPdD768XjFLA7er5?= =?us-ascii?Q?UbWEuNVsJgtDJCX5nDK2wHYjw9Ep81iymsA5d8syAcnJpOX9Wknyndc5aywq?= =?us-ascii?Q?7wfSN6+GuSX0fI0Ir7Y4DFQGniVtm5Kb/QFgi5CHsKbrdG45mTk2xxlh7wz3?= =?us-ascii?Q?Ax/U7jtvYE4SS9bT3/b/ho5V0POap+tvPrAq3HYOwgRmWhk235IdoFq5fP+Y?= =?us-ascii?Q?i25LNlPuNpbFfgvvVpmMC6a51j2Du9hs13Fkbr06Kw+odA9HV7RNaewoFmTm?= =?us-ascii?Q?8pWUGF/HCcST5E+4oUewWXQg0CzLjw7UbKN5CYoqDlI6QrpZs48dhHFU1uwX?= =?us-ascii?Q?o9VF1Q5ssusd6iIY5BCUrWuIk8PNaCGwooqUjC007opQxnEoxz6piOiPW5oG?= =?us-ascii?Q?XZfeaQ=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 64zS06XuQfkW9KbdJO9w0jcuU2KvLRXllU+xCQQqKWLrJnl12xBgrZR0IgRO/NCJSYXILlpdeTaZupoezq0UOXQ5sNsscstTGPiM1IO6bpJlptCiSUq6TTx7TzdMbcdP8zgPf9S/86nIfB5yJ+XTH4LNHlICQI/5ldqka6n/0mL+3ErUxYhAoO0jSYhuzmJzgGvehdgcA3ybT4+nZcN+8aTJQEkt2dJ8cpzJ4UKWZ18MrKxJtt9Q4goCMd14YhTlZbqCZFa1NUfhsq1Mw6DC/T6KzW/bBU09c6yzIOAk/Ec2ggYF9Jwc+I+VY9cb/6/7O4BZoMgve9ZHpo49cbunx79QmgJenomodMSVhNCqehQiIj/dgcZA/QFSJyy2jP3x1NGh2wkM3kQnNq2y9nfderiCqVMKNZVVBM629dq4xjFOykUoJwmi43DyX6rVx1i5 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 11:47:32.5345 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54ae5f96-2618-4edd-3665-08de739a7f13 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF0000449D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL4PR12MB9536 Content-Type: text/plain; charset="utf-8" From: Shay Drory Fix a circular locking dependency between dbg_mutex and the domain rx/tx mutexes that could lead to a deadlock. The dump path in dr_dump_domain_all() was acquiring locks in the order: dbg_mutex -> rx.mutex -> tx.mutex While the table/matcher creation paths acquire locks in the order: rx.mutex -> tx.mutex -> dbg_mutex This inverted lock ordering creates a circular dependency. Fix this by changing dr_dump_domain_all() to acquire the domain lock before dbg_mutex, matching the order used in mlx5dr_table_create() and mlx5dr_matcher_create(). Lockdep splat: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D WARNING: possible circular locking dependency detected 6.19.0-rc6net_next_e817c4e #1 Not tainted ------------------------------------------------------ sos/30721 is trying to acquire lock: ffff888102df5900 (&dmn->info.rx.mutex){+.+.}-{4:4}, at: dr_dump_start+0x131/0x450 [mlx5_core] but task is already holding lock: ffff888102df5bc0 (&dmn->dump_info.dbg_mutex){+.+.}-{4:4}, at: dr_dump_start+0x10b/0x450 [mlx5_core] which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&dmn->dump_info.dbg_mutex){+.+.}-{4:4}: __mutex_lock+0x91/0x1060 mlx5dr_matcher_create+0x377/0x5e0 [mlx5_core] mlx5_cmd_dr_create_flow_group+0x62/0xd0 [mlx5_core] mlx5_create_flow_group+0x113/0x1c0 [mlx5_core] mlx5_chains_create_prio+0x453/0x2290 [mlx5_core] mlx5_chains_get_table+0x2e2/0x980 [mlx5_core] esw_chains_create+0x1e6/0x3b0 [mlx5_core] esw_create_offloads_fdb_tables.cold+0x62/0x63f [mlx5_core] esw_offloads_enable+0x76f/0xd20 [mlx5_core] mlx5_eswitch_enable_locked+0x35a/0x500 [mlx5_core] mlx5_devlink_eswitch_mode_set+0x561/0x950 [mlx5_core] devlink_nl_eswitch_set_doit+0x67/0xe0 genl_family_rcv_msg_doit+0xe0/0x130 genl_rcv_msg+0x188/0x290 netlink_rcv_skb+0x4b/0xf0 genl_rcv+0x24/0x40 netlink_unicast+0x1ed/0x2c0 netlink_sendmsg+0x210/0x450 __sock_sendmsg+0x38/0x60 __sys_sendto+0x119/0x180 __x64_sys_sendto+0x20/0x30 do_syscall_64+0x70/0xd00 entry_SYSCALL_64_after_hwframe+0x4b/0x53 -> #1 (&dmn->info.tx.mutex){+.+.}-{4:4}: __mutex_lock+0x91/0x1060 mlx5dr_table_create+0x11d/0x530 [mlx5_core] mlx5_cmd_dr_create_flow_table+0x62/0x140 [mlx5_core] __mlx5_create_flow_table+0x46f/0x960 [mlx5_core] mlx5_create_flow_table+0x16/0x20 [mlx5_core] esw_create_offloads_fdb_tables+0x136/0x240 [mlx5_core] esw_offloads_enable+0x76f/0xd20 [mlx5_core] mlx5_eswitch_enable_locked+0x35a/0x500 [mlx5_core] mlx5_devlink_eswitch_mode_set+0x561/0x950 [mlx5_core] devlink_nl_eswitch_set_doit+0x67/0xe0 genl_family_rcv_msg_doit+0xe0/0x130 genl_rcv_msg+0x188/0x290 netlink_rcv_skb+0x4b/0xf0 genl_rcv+0x24/0x40 netlink_unicast+0x1ed/0x2c0 netlink_sendmsg+0x210/0x450 __sock_sendmsg+0x38/0x60 __sys_sendto+0x119/0x180 __x64_sys_sendto+0x20/0x30 do_syscall_64+0x70/0xd00 entry_SYSCALL_64_after_hwframe+0x4b/0x53 -> #0 (&dmn->info.rx.mutex){+.+.}-{4:4}: __lock_acquire+0x18b6/0x2eb0 lock_acquire+0xd3/0x2c0 __mutex_lock+0x91/0x1060 dr_dump_start+0x131/0x450 [mlx5_core] seq_read_iter+0xe3/0x410 seq_read+0xfb/0x130 full_proxy_read+0x53/0x80 vfs_read+0xba/0x330 ksys_read+0x65/0xe0 do_syscall_64+0x70/0xd00 entry_SYSCALL_64_after_hwframe+0x4b/0x53 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&dmn->dump_info.dbg_mutex); lock(&dmn->info.tx.mutex); lock(&dmn->dump_info.dbg_mutex); lock(&dmn->info.rx.mutex); *** DEADLOCK *** Fixes: 9222f0b27da2 ("net/mlx5: DR, Add support for dumping steering info") Signed-off-by: Shay Drory Reviewed-by: Yevgeny Kliteynik Reviewed-by: Alex Vesker Signed-off-by: Tariq Toukan Reviewed-by: Simon Horman --- drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_dbg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_dbg.c = b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_dbg.c index 8803fa071c50..18362e9c3314 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_dbg.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_dbg.c @@ -1051,8 +1051,8 @@ static int dr_dump_domain_all(struct seq_file *file, = struct mlx5dr_domain *dmn) struct mlx5dr_table *tbl; int ret; =20 - mutex_lock(&dmn->dump_info.dbg_mutex); mlx5dr_domain_lock(dmn); + mutex_lock(&dmn->dump_info.dbg_mutex); =20 ret =3D dr_dump_domain(file, dmn); if (ret < 0) @@ -1065,8 +1065,8 @@ static int dr_dump_domain_all(struct seq_file *file, = struct mlx5dr_domain *dmn) } =20 unlock_mutex: - mlx5dr_domain_unlock(dmn); mutex_unlock(&dmn->dump_info.dbg_mutex); + mlx5dr_domain_unlock(dmn); return ret; } =20 --=20 2.44.0 From nobody Fri Apr 17 01:44:06 2026 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012065.outbound.protection.outlook.com [40.93.195.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D98453803E8; Tue, 24 Feb 2026 11:47:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771933662; cv=fail; b=frmMTTUdt3fwo3+XoZA+W59cSN2oc8e1OalZ1gBjXKj2ECH/FOt31i6BqAvtYHF//FBlGPdqMqgTfaz+aqe1pVYaqdrzNlQhE5O8SKYXWusvlh7hJhaExnbQeecqtcvSzFjpANL5DGsg5rdCbrz/HubNXveWVwWbT17Vo++zYQ4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771933662; c=relaxed/simple; bh=9Tbef+IJ/tg/SwvMj+OldmMOeO4McJ63O39rEcyBOZU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=idSKN2BMG5Piy60LbR3NeDQWGMdek5uufp4NXmiWSd7M9AaWs2Ou/vf7KibY5YmEXqvgfu/oYigPYnZYmj/abi2DF19wH6fajPf64LTwe1q+iVJHrU5UWqiyMKtwE97VWo7PH1hr+oDXuccxhPYwvUqp+Y/J5hwdoGxxVCussfo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=cX7+vRcH; arc=fail smtp.client-ip=40.93.195.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="cX7+vRcH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D8fmMlL/fLl5LC/DKdJjGVOl6xD+p8O+N7TcSjy6L7EwL5p7nytY5YA/nDi6elgoEWMZ1Oz25Hb6RKLBokaVYDt4za0xKgsQGFUFRlVhYnpzC75ItSU7LShh4MRR6Z6WyebqfY9HIbKuynbXZ13w8w8SQ26xcZ03WzEGvcNJFq34oSgilyTv2Z62JKU6Dlc5Cq9TzTErg2uiVP93+pTcZ9yviUd20Rd0t5Ua18SMfV9E6kqpsgNO69jAn/yDXuTSpqMkVZwcGpOu4tCsqPjKQ4Q1dSgcuacrBgwZRHoU+DJ9cQ1PMdIkQZB/eM5HH4MyFuDnBdo4L08w6I+EHPTHYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=phJAB2MEy4Fdf/2mj0OoaE9zNONJrsk5K9sIszh3sMo=; b=j+ZKBX7oUiExHHsUAOS+b82dIqzfsyYxSbbInVCq3bFjY3mr8NU6fdCJeAemfZvtGwanGxnhZZKdA8p+O2O2vNaJZ4NzaLpCUfLAQqFcSsnvtGsV++D97SWQ1WDHOQqdZlfjX018evoOIFWvIJJm7NccpBhZ2ws8Y8oLSazh4c6ZvC3FJbzwuaG0uKeuveevNwwYyC7xCKzwk/8OCD5wwpneBKVWFj6LpWwsRG4c2lHLq/31rp4kioA3ek20HO+xFjrHKgTMK9cAiL1MgZUp0MUxsBZ/MZVMQq/coW2nbi7faAUUw4afpO5RdMKJ6Uuz8VVy7hH7ACAhaz5B41I1wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=phJAB2MEy4Fdf/2mj0OoaE9zNONJrsk5K9sIszh3sMo=; b=cX7+vRcHlQKmUdLyn9V4FsnccRMDzeFcKTT1QXeVH2gq5z6mAYbzZ/cyDQ0i3CrSqMC03ehcbiPbp2bx7E9pN1RLlBwQ0E4t8h4OSMWUMTC91NRM1HfL6zgEGQvdd+bopdPWECwLb3hezhRzvNgm6rqJDeCwnGM5UaxqxT2wo9uu0J1g86kRFNEstVcoaMiA6RPM2uhbE9x1nrlFxLvWZnl7k1o4QBRSkUjv7nHM4nkX72+s5ygFl6ml+Eq2EbqKrY5TJL/7DJM27nUXFwEWOvVKtV/e0VAFSmiDGbo0UJT2FiG4kv6kQXuVIbvtzsB+J83jt3BcXPcZNfFSYOn0NQ== Received: from BN0PR07CA0017.namprd07.prod.outlook.com (2603:10b6:408:141::31) by SAWPR12MB999142.namprd12.prod.outlook.com (2603:10b6:806:4e1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.22; Tue, 24 Feb 2026 11:47:37 +0000 Received: from BN2PEPF000044A2.namprd02.prod.outlook.com (2603:10b6:408:141:cafe::22) by BN0PR07CA0017.outlook.office365.com (2603:10b6:408:141::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.22 via Frontend Transport; Tue, 24 Feb 2026 11:47:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF000044A2.mail.protection.outlook.com (10.167.243.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Tue, 24 Feb 2026 11:47:36 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 24 Feb 2026 03:47:22 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 24 Feb 2026 03:47:22 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Tue, 24 Feb 2026 03:47:18 -0800 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , , , , Gal Pressman , Dragos Tatulea , Shay Drory Subject: [PATCH net 2/5] net/mlx5: LAG, disable MPESW in lag_disable_change() Date: Tue, 24 Feb 2026 13:46:49 +0200 Message-ID: <20260224114652.1787431-3-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260224114652.1787431-1-tariqt@nvidia.com> References: <20260224114652.1787431-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000044A2:EE_|SAWPR12MB999142:EE_ X-MS-Office365-Filtering-Correlation-Id: 251ef89d-8fd3-47dd-846e-08de739a819e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?40hGQ/4ZA9aSJS57n+hRaiVIfzlNPDiVSzeJJpQM7/yAPXskjhue3evOBnG8?= =?us-ascii?Q?DECwLwGqVWZeCVR74kNe0HKKepNFo1reSIJzdM+8+066h6sXu9q14ACVCni4?= =?us-ascii?Q?S3Mmec1R9ygYUgcrhAREXU4Lx4uFAd59MxjoHNpLnfvg5duV8/lsv6Rsq3lD?= =?us-ascii?Q?Wy9u5DCqbEY9QyZ8c/daogv2vpoKzlmDM3DIBaA6rXx7QxRboBO9ZDk7o1GW?= =?us-ascii?Q?zfn/iY+0S6OJF1JIjaFYAusCUI4NO5RTCC4bAdF2eDe3Q2ixHUAXeXbaUWUZ?= =?us-ascii?Q?bONsFLTgrBpyxpZJ6SAkNwqwBYFuRS3iNjbKLQ9HXjcU58J5XB5ZRRASr35g?= =?us-ascii?Q?6+e1ouyddVQTTUtbZ4xhdGIA1Psenxp/j2KSQB8+E3TT8CQnOhEnL3MAeaTb?= =?us-ascii?Q?oQhXJJ7DxNuCfPURZMUiyxG6Q62z7Pp8sn0jgQzFF7SCGh6K7C2UG46eCPlq?= =?us-ascii?Q?sMtTmMcPg7Vvltiy6CCErrwY1/HINHlZr5pnlri6UIsWNg99uCDthtbdi9k3?= =?us-ascii?Q?gESL51c0S22bJdOaZt96lR2cytYWICZO0iqKJAZWuMLRU6XHnlYYbmXu77xh?= =?us-ascii?Q?7wRHZ0W0uMdkk/wnEawkTshbMMBndz/YfqQDKmXl/egBghi3MNdC3KN5U05d?= =?us-ascii?Q?lbjemsdXmbbiLO8Lav73pq1HN6p4TwrULMDo17dEbsGb4Ct8WTj7ul4kXGrn?= =?us-ascii?Q?Bdx6/RS53iZ5C6RcNzMaCkHRBcD4gKidJhNlAkLx6NUMmYz0E9/wI3Vt85h4?= =?us-ascii?Q?Atc8yO+/NtblThKlHp35Ao/nU29q6ZLzGqX03n+TyDuCbwX2l5Cf9jQmu8Hm?= =?us-ascii?Q?KyONwooI07ch4tXP6uF35U2I+0VwA07G9Bz212opExYloBQjnCgb398GaJ5u?= =?us-ascii?Q?aDlqb4RmSK1uI2Rlo6Vzd5pp/15U2o0HkeskgiyJVu4FYUSgCHJ33/+Nc19q?= =?us-ascii?Q?ksS88TzRtnCIZ7HlLEs0blvegE6zxfhDuSvfUeLHxHwJKHBAwHwmkjmSfaRj?= =?us-ascii?Q?GA05Y44hT2x9Ze0dEmuawRc6PnXus3+R3UmnU3zHVNEwqykvQ0043ZUl17Fl?= =?us-ascii?Q?Jqee85PMOVLcvNiTJLtMZV2Ufvq6qRCayKYEGOqkKj+4setjEXU/Q9Nwec3J?= =?us-ascii?Q?YD5OaNSRr9CC6F4yDNOE2EV5IPqIpfSWYuXKKCjO/9mgX8jIzNgIry1Uer/4?= =?us-ascii?Q?7Bhc11lpx8ZyjzXpe/46oNC8F1bk53YCtdyGSw02b665uLkPKQNea7gfP+YN?= =?us-ascii?Q?qTH13P9byT8+ao1v7+K5JalEeRUu176RT8hkWnCDtrlC+S0DrZb4Wn6QQ+nu?= =?us-ascii?Q?gQhzJ8vMxNryATFKm/652PCmO5S4TLhqoDg8T4yLRx0UclpAvXFUTC/q0J5h?= =?us-ascii?Q?p5iDuPPJ8vOWL8Yed2/WogSGdGDmDJBha341hBHgK8D7nEp5M7aCbxe8Sqoq?= =?us-ascii?Q?ILkh+7K5OWtRO2sZAUuBlkJcvkr0yN1i7Upspw/0098O0y7vrdOaQlQkjyAW?= =?us-ascii?Q?COL/uhpsZGltvMaZHLTy1ISi/+whaNaRjYa7/Rx6NTicBy+sfDrx2FtYJ0QF?= =?us-ascii?Q?smy5dtwAce1DIsYJM93UbGZ+kGHp8tid6oFoZ051Adnjft6a8JYJtSF6stBx?= =?us-ascii?Q?/ihvKhEVTr3RLBCqJ1VJxDIWEpIvEurioxKPDnMZSeFE9hqVTi1YyV4ePoj7?= =?us-ascii?Q?hB9r3w=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: goUapB0HooW7Gm0ZONMsC79QzNA5aRL8vtyDNqxLQedBJWSsAGP0oIWSWbDm52D0NdNNUD2NGd40JnTbbuvlwQ5svGvfvN7NC+yc487purIb7BhmOfQQFbiHToUdTX+8XqHiTvrnI1j4XFaZM5dfgFK8wP8PloSwjc+2ICRJPSkyOo6irDs7hU6EFPMUcWwP7UbPKlosuEy5SAluzoLiZGILXiIBA66XwuQgF0iHKOCaXfKN6ra80ZQEjXRJxMfEtwW+Ngi+onDHM406RDrSBFDWiCw04Se30BxbUGZLYkGF3FOBrxlrayB8/OdIK93x+dKoHpjH9PGWEX7IUlyieYOl9BWizqhsIkZiswD8bvjfW6trGXk29izGjHJmihw8NCF7WeoXU97Dktty+nnX4yvArIRbHRHtYk8K6ijDZNlIAh5w5kC9iekqXj34jCBu X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 11:47:36.8070 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 251ef89d-8fd3-47dd-846e-08de739a819e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000044A2.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SAWPR12MB999142 Content-Type: text/plain; charset="utf-8" From: Shay Drory mlx5_lag_disable_change() unconditionally called mlx5_disable_lag() when LAG was active, which is incorrect for MLX5_LAG_MODE_MPESW. Hnece, call mlx5_disable_mpesw() when running in MPESW mode. Fixes: a32327a3a02c ("net/mlx5: Lag, Control MultiPort E-Switch single FDB = mode") Signed-off-by: Shay Drory Reviewed-by: Mark Bloch Signed-off-by: Tariq Toukan Reviewed-by: Simon Horman --- drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 8 ++++++-- drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.c | 8 ++++---- drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.h | 5 +++++ 3 files changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/lag/lag.c index 9fe47c836ebd..859f042caf79 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c @@ -1869,8 +1869,12 @@ void mlx5_lag_disable_change(struct mlx5_core_dev *d= ev) mutex_lock(&ldev->lock); =20 ldev->mode_changes_in_progress++; - if (__mlx5_lag_is_active(ldev)) - mlx5_disable_lag(ldev); + if (__mlx5_lag_is_active(ldev)) { + if (ldev->mode =3D=3D MLX5_LAG_MODE_MPESW) + mlx5_lag_disable_mpesw(ldev); + else + mlx5_disable_lag(ldev); + } =20 mutex_unlock(&ldev->lock); mlx5_devcom_comp_unlock(dev->priv.hca_devcom_comp); diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.c b/drivers/= net/ethernet/mellanox/mlx5/core/lag/mpesw.c index 04762562d7d9..a63d48d18878 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.c @@ -65,7 +65,7 @@ static int mlx5_mpesw_metadata_set(struct mlx5_lag *ldev) return err; } =20 -static int enable_mpesw(struct mlx5_lag *ldev) +static int mlx5_lag_enable_mpesw(struct mlx5_lag *ldev) { struct mlx5_core_dev *dev0; int err; @@ -126,7 +126,7 @@ static int enable_mpesw(struct mlx5_lag *ldev) return err; } =20 -static void disable_mpesw(struct mlx5_lag *ldev) +void mlx5_lag_disable_mpesw(struct mlx5_lag *ldev) { if (ldev->mode =3D=3D MLX5_LAG_MODE_MPESW) { mlx5_mpesw_metadata_cleanup(ldev); @@ -152,9 +152,9 @@ static void mlx5_mpesw_work(struct work_struct *work) } =20 if (mpesww->op =3D=3D MLX5_MPESW_OP_ENABLE) - mpesww->result =3D enable_mpesw(ldev); + mpesww->result =3D mlx5_lag_enable_mpesw(ldev); else if (mpesww->op =3D=3D MLX5_MPESW_OP_DISABLE) - disable_mpesw(ldev); + mlx5_lag_disable_mpesw(ldev); unlock: mutex_unlock(&ldev->lock); mlx5_devcom_comp_unlock(devcom); diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.h b/drivers/= net/ethernet/mellanox/mlx5/core/lag/mpesw.h index f5d9b5c97b0d..b767dbb4f457 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.h @@ -31,6 +31,11 @@ int mlx5_lag_mpesw_do_mirred(struct mlx5_core_dev *mdev, bool mlx5_lag_is_mpesw(struct mlx5_core_dev *dev); void mlx5_lag_mpesw_disable(struct mlx5_core_dev *dev); int mlx5_lag_mpesw_enable(struct mlx5_core_dev *dev); +#ifdef CONFIG_MLX5_ESWITCH +void mlx5_lag_disable_mpesw(struct mlx5_lag *ldev); +#else +static inline void mlx5_lag_disable_mpesw(struct mlx5_lag *ldev) {} +#endif /* CONFIG_MLX5_ESWITCH */ =20 #ifdef CONFIG_MLX5_ESWITCH void mlx5_mpesw_speed_update_work(struct work_struct *work); --=20 2.44.0 From nobody Fri Apr 17 01:44:06 2026 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011033.outbound.protection.outlook.com [52.101.52.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55EC7229B32; Tue, 24 Feb 2026 11:47:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.33 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771933667; cv=fail; b=XQXnElco9fwvROl1kgSwmST+clVA0qKRosqjbXST7IniZyyTqSg0fZME+MyHo3IJPBC5zG7auh11+j2ewfcs2Lb0D3LpJkKH19TLA305O3F8T6M6nSpZU1kFKBfUuHzEYpH1nYgQj7p/M306zSolqWX2XhkP6W4gGxcv1P8XW8w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771933667; c=relaxed/simple; bh=0E8yYmIbJ1hL0/KDNvYgCdKClm7FW4ojClN9hKm5xkw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JkzTJCcF93fXxkBZdKYcF/wWe8LsQl+taBoF4yPnPIcme5vbqVsBF/nuf/kT8ahlkTytAPUnMaUbPARf3WTnfLUJmzWUI4ZJfD+agObYOVBbOJaHLQENKzC6Kv0vYcIxFyb9JEKuomx6YEma/OLh7TmQMUwgu+rbg1ymSPlkQHM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=FwF1lWYJ; arc=fail smtp.client-ip=52.101.52.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="FwF1lWYJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uVogVlatbVArmKudddJGPel7bubIyaIxhDfWEQClCfAuSl913KbVVKAXYYHwKLSaoeJLQV6md+7cituQxFNIbzacUENdRJtZ9LEKjnl2qmtCThO2vpUCpTs4QY1xYIpcJjhprmUEfNvUoQh7sREk1/B69j9o1ibQi11ySekPiYqKB9F27Y1jFevC7wP/bpa/EruHFkOqOZYBJNQg5CnMZ9mW7CIRiMXhtQDT3T1bnrcu2kXVzldTZ6fkLG5xpe/Wk1h3uidj9+NGFsz9QjO5+L1mZ053fjljgZGP/gdJAQ/hAAhMko/1WWErPI5K/vqmdOaphKidCZJlNPTo+40SRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SdGYsUpL2MA7WoR/N4wlsTApMGnhwf/tIBHR9YwIGGU=; b=n53QFzSAJPvQVPrCCUY+MlF3Q4zIgkcNu2byo7KAifaEPGoc4vBz06VYQxH/Ngrb+KyAzN5zmUxRzkzJ8beCalC9PfC8OYGpWyvu0TITWF8rbde5HaQp6KnwLtnBDozwzth8Am9KWt2Ncw6U847BnyFfyoVPu0Xj0TVpV1PoUOfKU7JRrz+5FlWWfIElKSjGZt+axbsVflDFAw/+WSqxCcM44/4YUMBWxlZDQ8m14bMOTNaDZT7aLdZzo1zBkxShVdd9glmoxfM5Dk9v3CC77gNbR+DsTRJUuATM7gIReBQKn80627gUm/eEHLalgAprZRHB3kqOv0T4Fs6GLb3QSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SdGYsUpL2MA7WoR/N4wlsTApMGnhwf/tIBHR9YwIGGU=; b=FwF1lWYJyjZp9W5hZTb8LNETU1TcfsGhVnjcGHJiJsINiS6o+AZubbpYcjYt9cwzN/CenamhEp5pUHZEhXe+npnGOsGwCtV56lP4cwJwzp4smFhfgjABw7zUlXXxKtipdD6HyzB0HeSGN2gUO8Xa02Hp2flGs8EMHj42JhKHq36jNH2FCoCKkNvkJsnek9sg0iX7Ejv27WHrPjCFMJPG5FV2ycfDdM8seEvrjzXx5YMaG9eh9Cq7/Nf0KUD/cMI0r9EdsKKW7zuvBNqTm18tbnMA3vPS6QIoR+M3urXqqif0clBoXprsBZ4u9RjTrQwla0yvSC5fLg6VH+dDJ6jT6g== Received: from CH0P220CA0011.NAMP220.PROD.OUTLOOK.COM (2603:10b6:610:ef::13) by SJ2PR12MB9190.namprd12.prod.outlook.com (2603:10b6:a03:554::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 11:47:41 +0000 Received: from CH3PEPF0000000C.namprd04.prod.outlook.com (2603:10b6:610:ef:cafe::7a) by CH0P220CA0011.outlook.office365.com (2603:10b6:610:ef::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.22 via Frontend Transport; Tue, 24 Feb 2026 11:47:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CH3PEPF0000000C.mail.protection.outlook.com (10.167.244.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Tue, 24 Feb 2026 11:47:41 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 24 Feb 2026 03:47:27 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 24 Feb 2026 03:47:26 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Tue, 24 Feb 2026 03:47:22 -0800 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , , , , Gal Pressman , Dragos Tatulea , Shay Drory Subject: [PATCH net 3/5] net/mlx5: E-switch, Clear legacy flag when moving to switchdev Date: Tue, 24 Feb 2026 13:46:50 +0200 Message-ID: <20260224114652.1787431-4-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260224114652.1787431-1-tariqt@nvidia.com> References: <20260224114652.1787431-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000C:EE_|SJ2PR12MB9190:EE_ X-MS-Office365-Filtering-Correlation-Id: 004ec1be-8c9c-4966-f3d7-08de739a841b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?t7N/c/A7ickYsFyY81l9A13jYVnbTCo9cwvSmynvQqcIHL71Z7AXUl2HMwTK?= =?us-ascii?Q?w4P2/wug996XA3FxR3SPX4UUpijG9bDCwqxPv+SHhy32vGcV9TLgd2dyaDkc?= =?us-ascii?Q?kYU9wwnzOw0yto2WvD7NTemFakSAOKY/FfTyQncptK3JkJY3GG8jPcCBQcEU?= =?us-ascii?Q?aZJ18FJVqmYJWuKMT3w3ILbWhnRqIcWuQbbswZQAaCeGmn95exOl6H06rOls?= =?us-ascii?Q?IIGpjrTFBSSLoU9ywqco+hJv3yMhDy1K74rqFUDQ+r9VF4t1dTyCrXIgu39G?= =?us-ascii?Q?IzEKtTfMgvXYzCbKk6J/Vjm0Ba15DanCtbIQK9mBd3y+Cwg8mI9JfC+6Mk9M?= =?us-ascii?Q?FRLDaHvoREo7FeN0Qo5ri6TR9oEq/8XGwE/HWRqAmQfEykzJ6Hp1V+xUwitY?= =?us-ascii?Q?NPY/t7i4tqBXR8Kojc1PEOy9qujQIHR0hX8OObDakpKKR794AAFN3Gl88rWW?= =?us-ascii?Q?9jTDM4En3EFyLG77+1F5TxXA6e34KH7ZEkJa7pli4u/Ps8QfL0SNu86W48Cx?= =?us-ascii?Q?PpzA7CGtmVR86mtwjTRWYBpjbh1SNqBFXfvR4qPOtW0Q6+jDDuml/zuLaBP2?= =?us-ascii?Q?RHii9b7xIQ/Am+PPeDjcZg/ANstlxIjsOlnIsAiqxqgpe6QImj8+2Q/nyb9n?= =?us-ascii?Q?QFx4NJFvvNH6EmyL/yi/N+Ps6VdMHu8lc7LxN/N7pnTKrQ2rro15LPxi+JmC?= =?us-ascii?Q?466nmOwPDAKeJUPQGV2wrVp+gTT4e2IAoMeJtyC4g+ycWPUAPV8WiADvvtUY?= =?us-ascii?Q?2CV+aYJWau4iXSVnVNHn2QIwQ6gsqhjWw4cJFw/nMK+VDR0USjatv+0wGLsi?= =?us-ascii?Q?49Qx9cD/1fov4B2j/WUE1K02u81vP2ApwdopXPmAWDqDynmZKhJxR2T/Eajl?= =?us-ascii?Q?rIxgztuLJ65b5tTSMrJFB9h2Fbl8/q6cBEvo7+3C/TvqETyE4vjpWra4sMIR?= =?us-ascii?Q?rXVysoBBeAbmtxGQd+Taxehl8WJdCtrNY1JMvQk6Q7W2PIi2vKWeZ2ga5GqM?= =?us-ascii?Q?1fOdk/Fbv3jRYcMEsMn8y69vk3W7l7N34/U2phhikh0cpCShSf5VPEnkslRF?= =?us-ascii?Q?qGtT23Q7JxrauOKQtsQFkfAJXk0gOpjSHvAGo2sX++Q/WQ6+qo89q1R+6SGM?= =?us-ascii?Q?efkQhyYwUkNMss3DI+MyW9XazLUOe0VZCdE2t31w8ChjowV2fkV+rU9Wb/g6?= =?us-ascii?Q?xst4wgtHyuay+qZZILYGR8QB9kIUNvhh6Jb0ZH2ySrbMQ6PH4xopSY0M+a94?= =?us-ascii?Q?fiyvMRuGxMjlFdK4mf/Fki0HufhWIi4AsjFg+LjhWj0WFE8X0+Ipy+NblVJg?= =?us-ascii?Q?wXE+u77jpOFCgHHylGM1/hdCc6JBri8JHDBfdWeYvKUocK7Uo9BjuyhIFy2h?= =?us-ascii?Q?LhAYxXL7nlyTRFVtrDO0N80Gb9qDV6XjwjU5E5a/aTol8Ba00tZMli1rhbMC?= =?us-ascii?Q?szwsU4EoG3+cvefOkJfBBR1RtpkPDnd41eNf/uxLpHQi5Hz7/+s/SwUKUcnO?= =?us-ascii?Q?8j7UTmeTpvvqxcmNZZn0Q1bUiPsT9nGMQbpeLK8Mx7+uZBZAytBtMSuUj8mW?= =?us-ascii?Q?o/ZLZ6dKlW5mjH56Wqea3T3NypX/h9W+jsheK31JOMuviAHGaus4s8vZrILI?= =?us-ascii?Q?5xATJRCcykhfzTYXk/w6y0L/YVsSy1bOf0LnjQRJ2hOUOT+IkGtDV+7OLjUA?= =?us-ascii?Q?F3n/oA=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: olhUa4z02LC3QWatuMWqW8+FWDKepAu2z70wcK9GhG3k/rMmgeZjyBd5BQ9l88M+FOsKboFCqtSTfZPSZaXKfvoULC99zpWQ+0cC70frfPNEVX72b9qwEAqPeGcHCz9OJoVRg+AOQqaDxQtIuZRi6rNiaSjEvyRTyZS8OsEc1y4668kryEcPtJHtStuJ/W9+KXNTQdlIxDebVgD6TdroqkQPN3n+C112BgddizUAbm0ePWW0ROxiA2M3cXURVEQYTepZGqF8SGzMi4nQgbs/DYP2j95Cg7BDU4jwqiblJ5yzsJCGeV6q8XcN9ER96p+7kxKuys5ekqfC6012wVCw4ShRE+02Ck2J9iAcX8CqlcUppmO5YorqsmxjLAI6hQ/QrEhAIT796SiSMhU4IO7GipbTWFb8JptRmYLPb4VX4rKamhxYxKl2DRcfIKznL5db X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 11:47:41.0037 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 004ec1be-8c9c-4966-f3d7-08de739a841b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000C.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9190 Content-Type: text/plain; charset="utf-8" From: Shay Drory The cited commit introduced MLX5_PRIV_FLAGS_SWITCH_LEGACY to identify when a transition to legacy mode is requested via devlink. However, the logic failed to clear this flag if the mode was subsequently changed back to MLX5_ESWITCH_OFFLOADS (switchdev). Consequently, if a user toggled from legacy to switchdev, the flag remained set, leaving the driver with wrong state indicating Fix this by explicitly clearing the MLX5_PRIV_FLAGS_SWITCH_LEGACY bit when the requested mode is MLX5_ESWITCH_OFFLOADS. Fixes: 2a4f56fbcc47 ("net/mlx5e: Keep netdev when leave switchdev for devli= nk set legacy only") Signed-off-by: Shay Drory Reviewed-by: Mark Bloch Signed-off-by: Tariq Toukan Reviewed-by: Simon Horman --- drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/d= rivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c index 1b439cef3719..9d51d030596c 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c @@ -4068,6 +4068,8 @@ int mlx5_devlink_eswitch_mode_set(struct devlink *dev= link, u16 mode, =20 if (mlx5_mode =3D=3D MLX5_ESWITCH_LEGACY) esw->dev->priv.flags |=3D MLX5_PRIV_FLAGS_SWITCH_LEGACY; + if (mlx5_mode =3D=3D MLX5_ESWITCH_OFFLOADS) + esw->dev->priv.flags &=3D ~MLX5_PRIV_FLAGS_SWITCH_LEGACY; mlx5_eswitch_disable_locked(esw); if (mlx5_mode =3D=3D MLX5_ESWITCH_OFFLOADS) { if (mlx5_devlink_trap_get_num_active(esw->dev)) { --=20 2.44.0 From nobody Fri Apr 17 01:44:06 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012049.outbound.protection.outlook.com [40.107.209.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5BB13803F4; Tue, 24 Feb 2026 11:47:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771933668; cv=fail; b=RRKYCQbZCges6h/WUfvO8UUCuP7Iydjyxgu8g3XeCw7MQIs21Q4YC3hmOPEyBWewOJIDAvfE6PrrgmlsgPOB2p/YnxliV9FOrJ/RbF565wKfz1EpoNsubF+fdSqBWtIy5U+Ca9hDeqHzouKXa3l3of0kOIm80kq4PDlZU47NbT4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771933668; c=relaxed/simple; bh=WpUOQUXkGYzBC+GkcBB5y0VK2uJEGasAsvmOBDxpiM4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Nxj9WqSerUdR98KRWDvw9Mwq5FCHck/Zx0pEw4xO+6R/vQNCWByyroU2uc16VrbhG1734DJEN+W57MUp/Bxlqm13yMBl8YOuvJxNX7N+ELW0E0rumgLTyLLRO+h7UZKRSHw4lZAmVBrQHixjNtfc/DM2K+xMmMdgExCcqJVuuac= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=FXdBwbaV; arc=fail smtp.client-ip=40.107.209.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="FXdBwbaV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eHxHGGOUayEQtFUr9VriQ4hS6/UHrzWASnc0tiAuRyvJnQu0vUMrvB9SjLq02IeUGYSiBx2MmuCLkeg50G7iz7c4+Pa39w/cHtvhJZ41eHc79aM+33EZImIQgIas72ZL52fVWUcn1AIY2mhzsPdIRAbe+V6reaNtin9tXhqzCYRR7nw7Je8Z5lvPOhk/xmmKlXArg/8gXekdlKCOj8HI06xDL7YBxZ+vAl8tyqvmCqxTms1mK5X3/mHno6qrvz4cHyVWVmAaDXocAI28ewpSsxnlh84Hh2qSFVglEYxnaqg3q1j5hUahMM/+MgX+BgasG+zueLKXesrGiOhNZxZQEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NhdYikAD8yHnHJqoVDD+BnO9YCSk4dZ7ARilacq3J4s=; b=oZcH58Lc6DjODRn+1l3jEssa1P2MqDobgUW9jd4VlDz4Vev5lDnW5Mzz4besglW9xVeZuhankFbGxhflEVJcuq/Yt95UCr6d5djWn8F4QZoYIeXrbrhvMa0n8PCxFQbux3wmR4liREl8lihXbJT/moB8E04hAF8c3E2fxqBf54L00QeGIb17/hch6tOYFYZfWyxpqVv2bB+NX+30gzaYvzgCRmMOjjaDvK62EceZmCcEUqTdi8IrcV4nrirerp1a4HMT05rJN8YbhK8hXr4aUotAMv/1POaU1ZWVGpvm3LJkTMRGLWaT/FxB+N5OdDeD1WveTLLDX/v5RtJI6+6+Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NhdYikAD8yHnHJqoVDD+BnO9YCSk4dZ7ARilacq3J4s=; b=FXdBwbaVBqAtZPbWnSF0WTuScarmZutg/6H4vFb/6gWOL+a/H/Eyw1Ar0FHvh9+7HA4hUFyizC0RRrTKG1z8AqS8tyWjtAxUtGIC4/+degFxvG7OvykOpx3rRAiTFlkbDhk4kZ4fj9yh9TWr3PMmauvj+Sn7b4BYP0RRBj7/vibKzMUkthkEw6mfbIvL3ePDDCN3aBAv6NJdSHRB7b7v8EtZVEH9c3Gsi7IKzHMCRpvxOvMPj8ENRjN/vN/OBmLmzAs5MaQkZFfj3vBhh/YQOg3M1h6sV+iBRfFvPGZSTU9rzpmd6O62N+1B2q9K0DUMkQYe0J28CVzKcXg9rPCnMQ== Received: from BN0PR04CA0168.namprd04.prod.outlook.com (2603:10b6:408:eb::23) by PH8PR12MB6700.namprd12.prod.outlook.com (2603:10b6:510:1cf::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.21; Tue, 24 Feb 2026 11:47:43 +0000 Received: from BN2PEPF0000449F.namprd02.prod.outlook.com (2603:10b6:408:eb:cafe::d6) by BN0PR04CA0168.outlook.office365.com (2603:10b6:408:eb::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.22 via Frontend Transport; Tue, 24 Feb 2026 11:47:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF0000449F.mail.protection.outlook.com (10.167.243.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Tue, 24 Feb 2026 11:47:42 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 24 Feb 2026 03:47:31 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 24 Feb 2026 03:47:31 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Tue, 24 Feb 2026 03:47:27 -0800 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , , , , Gal Pressman , Dragos Tatulea , Shay Drory Subject: [PATCH net 4/5] net/mlx5: Fix missing devlink lock in SRIOV enable error path Date: Tue, 24 Feb 2026 13:46:51 +0200 Message-ID: <20260224114652.1787431-5-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260224114652.1787431-1-tariqt@nvidia.com> References: <20260224114652.1787431-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF0000449F:EE_|PH8PR12MB6700:EE_ X-MS-Office365-Filtering-Correlation-Id: fb99599e-e402-41b5-fc26-08de739a8527 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DjNxUrVgOUQWislu+vUf9DEN6DIqwnuJmBZFD4VZ3fnbLoB756qvWj7YopVR?= =?us-ascii?Q?vNdDCE/tVxKs4WkufUty6UXBeY5tYaARqS/2va/HO/zL4/12AB9k/E/lVpfR?= =?us-ascii?Q?1V0V3AgZbtHrOwQB3YiFwe0c22FrpkIRzQm+HDIvnqBDU6AXSQH8f3G0TTWK?= =?us-ascii?Q?EivPThL7SbkYJp5v9d1RGXTTNYVAWkia0nPLRcdh4ApyyOrih59sLHagcwUO?= =?us-ascii?Q?YJ53Vu1aHD//x2lrFQpdoi4nmPB6drhvNXlNkFaRLqPCpJWwI6YuCK2+KumW?= =?us-ascii?Q?d1vj2/GKg+DS8KxYT8LdFDr0VJxBFNz3k3MO0duiUCSvMJZv7QUU5MmyhwIV?= =?us-ascii?Q?pTu0HKTzRTU8c/wGeHYO8bLxayvvaWEnTiA7bRvzTguRpnG+sUjzaashV6Bc?= =?us-ascii?Q?1yxcRj0EOpySJ7IOj1bbQ9NWFxVtp7qDqcqeexNaPaIG9XkDHhZQhFMzx5gA?= =?us-ascii?Q?2jvjPIbRNlRoil72eISV77gY1Q7moIZWQKaTOEiKUGetlPAFUHaoqPuORPrh?= =?us-ascii?Q?BZlH/hYQktaxHuXMpkNS6aeLD1hIxeTgksssOoD3hnnXp0lRsiNKFlHC5vhw?= =?us-ascii?Q?DzRLHHxU3BYvrCZekpTkr8LznNT/1ZOYK3T5VREOBPRh4ZQHE2a+uZo/v2Cq?= =?us-ascii?Q?J8lpK/IGaD50/s797qOed9r8/xHArDObNEoWzpQVOxarZyXVgL9Ty3O1LtF5?= =?us-ascii?Q?xVDMyxxNa3Baze2/FDVYOvquB/9UKUMvZU2WtXEjKcIZZNPa5Qj/EurT+dJr?= =?us-ascii?Q?e0P7ThBwJHK0FwtY3xmsu2w/7fNpRYKndvhGdE/oZgkH/hHoVH1VB04wLErI?= =?us-ascii?Q?8HsIOBLR7HzzzyICN6S3ahX4YfI1pRP+bYWNb6bbWdbXEfmKzESWruDcQcTF?= =?us-ascii?Q?toPLg3+x/cUXE86++bG58BDCa7d7wVTX4EzEfGbb7MVBDgHoimKEeVFZVm0V?= =?us-ascii?Q?98kWSBysZdOfrTKQvSkWCmoja8EV//icpYi7n78y4M3Nll+/ecQMtklL9V6W?= =?us-ascii?Q?EsEzQSJrwxEwcRGgZ2ZnphVGOwcgTUpKCbdyNRyOPAS2yY9fUcVT9e+H84JI?= =?us-ascii?Q?G8bg7yZ1AgywsDnp7RJZpSuEbJy/L7IcgV4lqdoMhDFuQOZvsq9jP0N8t0n6?= =?us-ascii?Q?F6nvUKhorHItZVdyZO+qC7CTJUiODWXA0hNyoM/zrk2XqitUl2zlrDXfOBGh?= =?us-ascii?Q?NMNPaS+/I1weOuhVkFjykIMHpS/05CeuCNZQGO0/HA2KJK885f3L7hbVOK+l?= =?us-ascii?Q?bfUmO9ix2Nq88g+6ZC7MXUXdQTqo5QebRMA6jDP3RtLi/+KkpGaozj7B97Yk?= =?us-ascii?Q?/Dmq5c5589FndsXaukf2P1AouM4IB6NoQn31majEG56MCqxdaZTvTnV4eSD5?= =?us-ascii?Q?37EJVdB2rEMCId9VCFIQ8PA+bJnhZsurx0Y8CZNtnYEjlUmP/XEeiJzGAOqB?= =?us-ascii?Q?Dk6hhGjL/fcznUz6epZXOOY3PokRUrlkgtqFpHFcKHVYW/LJdWGP+aoxvujm?= =?us-ascii?Q?y63jkYcZSuCxzm9eUOYDvr3rrT6m/ztPoyKVPuyVx1w71LwVFoiP3PFNOT7x?= =?us-ascii?Q?N8FEpolAjH5gX+RIcX+iqgtbZKCIfVVYUZzBsNGXn6i2cf49W0HjtqvjYjCQ?= =?us-ascii?Q?dnT3fDjfaAeodQRxVAYeblAr4Mvxf0bpB3pqhV3j86YjCecRfR4qE88x8xrW?= =?us-ascii?Q?N28aJg=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: R9Utdc0rPfT0Wmq5NMEzJjgYQ1hkP22apSL7X1jEuBDbEAL1fubFTk5P+QW8vgGtavn0FelUJtX9eor9LhxmS1ouUoAqL4pOO/+SAvNAD3rp/hE0YQ4K4T89/gHNlzGUCNafAc3EObK4YW+Bgh9ckCsz9VdLTMqvjhfmg6St2zT5thC7FWJg9CwCFrDI2euBK08Z61htRl3wGYO53fMKm2ZZ9/1ac+O2VPD2e/5Dk0CAGoj9gbS67/6RoIPipFb1pRSCU0DMo02ga3J76GDUZcQnURaGoKq8UgaPJP+sWCvCBam0Wa6qMH97306msXG5jpbh4eQEr/ZfjQKxZE6Uvo9oNl0GBdJWfXe2FGV2XIGTynmz9f9Y5pOw8trhVr8BS/+sUXiS0FV803IVGYxnIYvz21LwZhDm510vj9tdmMkOe7/O+jfb0eeT4KYo7jzB X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 11:47:42.7419 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fb99599e-e402-41b5-fc26-08de739a8527 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF0000449F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6700 Content-Type: text/plain; charset="utf-8" From: Shay Drory The cited commit miss to add locking in the error path of mlx5_sriov_enable(). When pci_enable_sriov() fails, mlx5_device_disable_sriov() is called to clean up. This cleanup function now expects to be called with the devlink instance lock held. Add the missing devl_lock(devlink) and devl_unlock(devlink) Fixes: 84a433a40d0e ("net/mlx5: Lock mlx5 devlink reload callbacks") Signed-off-by: Shay Drory Reviewed-by: Mark Bloch Signed-off-by: Tariq Toukan Reviewed-by: Simon Horman --- drivers/net/ethernet/mellanox/mlx5/core/sriov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c b/drivers/net/= ethernet/mellanox/mlx5/core/sriov.c index a2fc937d5461..172862a70c70 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c @@ -193,7 +193,9 @@ static int mlx5_sriov_enable(struct pci_dev *pdev, int = num_vfs) err =3D pci_enable_sriov(pdev, num_vfs); if (err) { mlx5_core_warn(dev, "pci_enable_sriov failed : %d\n", err); + devl_lock(devlink); mlx5_device_disable_sriov(dev, num_vfs, true, true); + devl_unlock(devlink); } return err; } --=20 2.44.0 From nobody Fri Apr 17 01:44:06 2026 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012031.outbound.protection.outlook.com [52.101.48.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BC7C3806B2; Tue, 24 Feb 2026 11:47:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.31 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771933674; cv=fail; b=piM3upX08x3yX8pLTZR5vnlJRMorKoow2qlL4bSgI1jyeHHSckQy9/1uuy4eJx7C85UUnqA1ma2XG/sGX/1uXx+RWaWJs8WkbXekLssPCKQsy5MM3EVjYX2lEO1/EYcNOGweftUS+PfhdkvDesro5pTldYVkR7Ros2hUrCfiMBY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771933674; c=relaxed/simple; bh=WwT41rjyhlEKUkWpqupu6i7GxiCsPprxfWRv0fSioyI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DgKfZhcuGwrDGkHJ4xCHlkdiLNs77yKF/GrvxCHsOTV8I9Mz3VMkr/udDFJhn+jtcz17crIG1wW8Cd3GxK3aZu3IxeXjnrvabP6gMPh+AJ9ylh40SWMVIrD76e2b8OXJVbyryoHYmAOViNzoIEhMRpxu8woUzsD3kVVsiyYrcfE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ZU5czGvb; arc=fail smtp.client-ip=52.101.48.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ZU5czGvb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OG1aSpbM3m6LjPSpO3bRGmiKZhBkMu07bNk+fxEXZSfbXPfruA2QBc/KUmdlyUfuCWHVVLRjJoXpC/zPTCRFYEoQVLsZYvIoVk988NrJLkOAu2l9hZufL19oVW/thE1dXncNLPBzhJqB6Fzyf6TfVuJrTzE+iHah4ocX0eHJyPgkurI7vqvvl0nuNRZ2a0N2sfExMpVaQ60IrFcZlwdep5tdWPiXkGLmY7jn4Zk2X7NdNd0jlJJZCMI+cy08Hiw3toQJcyxkHe8cxrxNBl6MxQ63LxS6S3jhGUc7/UJC53rYPXPFoXq1MVyXwwTJHbiOGs1hRvcUoYQll+wpzkyqwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hKfIlrfpKfW9qzrKg31x78PRNilWLRNmxa9EaYacNqs=; b=LfGQbltdNeB9qzjEMem4GcbQaRpvloVsTOZ5UHa2qfhnoFbaoxLMtIHxlvplaXGztIhcVOzwzLLUf5tagu1v2psDYEpLQ9lhhZb3Oi7mbmlFuumRa84392KyvisSI9iyMyUILlnLQET6gX6ve4xs2pXSmfFR03T3DheTbI8B3i/DlpRnGo0h4p8sMfBzfr95Dpo05alY35a9rJ4sRrizjizK6Dw6aS71BDn0KHqC2LBzDSXH+w8AFZ2PqkPzwz4Mlq0+LtxtFa0savdji12qMUx1VTEmjAB4YbxNKlg56BU9AfFKMCMkEjts3KKtAt/hACu74uh2EdOClilT/y8AFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hKfIlrfpKfW9qzrKg31x78PRNilWLRNmxa9EaYacNqs=; b=ZU5czGvb7FI644Hn+8WFojZpSYHOkYsW7tViThPtAZWfKQHVIGewRaVW+ihi6v1UeuRHVgrJtIMa40qsA7W56OUvPzclFAbuvJ+k9nIUZjVqu/ENaqxFWWQKDI69Gm+QzXkN9Awd0we8Q2yMdvkgUN7t4ovzJpk/wmGUxa9T6xNJJe2Qtu8XrFmytHEtiWJFOeCIZ/gKW4nZWsyRuFMYDnCCO61NWyLshTzZUNCyuPA1HBISOXi6ZrAUWMxAzmUjtqQMM2s0rQ1J84aQDhku8mCnIxOxS5WW31aJoQE2g6PJL+SzBPsMpxnXGOoG/ngneZ76ZJaqg9XG7jaYHUg4vw== Received: from BN9PR03CA0899.namprd03.prod.outlook.com (2603:10b6:408:13c::34) by DM6PR12MB4076.namprd12.prod.outlook.com (2603:10b6:5:213::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.22; Tue, 24 Feb 2026 11:47:48 +0000 Received: from BN2PEPF000044A4.namprd02.prod.outlook.com (2603:10b6:408:13c:cafe::98) by BN9PR03CA0899.outlook.office365.com (2603:10b6:408:13c::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.22 via Frontend Transport; Tue, 24 Feb 2026 11:47:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF000044A4.mail.protection.outlook.com (10.167.243.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Tue, 24 Feb 2026 11:47:48 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 24 Feb 2026 03:47:36 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 24 Feb 2026 03:47:36 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Tue, 24 Feb 2026 03:47:32 -0800 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , , , , Gal Pressman , Dragos Tatulea , Shay Drory , Jianbo Liu , Leon Romanovsky Subject: [PATCH net 5/5] net/mlx5e: Fix "scheduling while atomic" in IPsec MAC address query Date: Tue, 24 Feb 2026 13:46:52 +0200 Message-ID: <20260224114652.1787431-6-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260224114652.1787431-1-tariqt@nvidia.com> References: <20260224114652.1787431-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000044A4:EE_|DM6PR12MB4076:EE_ X-MS-Office365-Filtering-Correlation-Id: f71e05b9-fdc8-46b4-14ad-08de739a8884 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?A656nYpGQc0ql+7wfyH1reuT3hbgKBolQKF25wS/GKyjXKej0vyNXn/KHoUT?= =?us-ascii?Q?wpefwHJ9AvIf+CJgyo0C/f/ZrJAj/KROK2K5Xfur35RVl52mkrOPvCYqwLRX?= =?us-ascii?Q?owsTB4C3y2UmFU4mfba2nrCx34rLw+lUYbMVxj03g2vf3CPEpMOixVWaIKTt?= =?us-ascii?Q?ObFbhnH/PeeyG2UEt4BQ42cxGQotUEJQFJsp5rXhoDO5BhdPYPk0CZsgBMhb?= =?us-ascii?Q?SzKSO4xo2KfXTCr4toiuhnXZ4BTZ9/8ib8fgIHvV3dP6hknXPufimIw7xkna?= =?us-ascii?Q?RM7lAPk2lBuaeCZ/UeBXMyl1HRaYG8yKt8nCqAM0Hw4DDnuqwynFDKj6Z9dt?= =?us-ascii?Q?kOFUnJV1EUDqG1NRusvCtiDe+s8qMwsWdSSgy1vYJd0gYPh31NKvckENbKe+?= =?us-ascii?Q?F3KwlB+jZe/jLUcer745ZvtstdBJZflOhPYzih1cbmoIv3uQKcy1OKb1XxnA?= =?us-ascii?Q?xh6DTAg55fWu9n/CCa3+yWsxAJ0P3oPjyV8LLbBQdL/MurrnnN/E3U6pmpn2?= =?us-ascii?Q?7EOM1D76beLn6qJw8AKsyj8OSOuASKKOQM7/5sHXGttI2FBeKV1yoPZ3NddG?= =?us-ascii?Q?yMikC0rcWcZgZbJmLLdF/eXLYACSG1OtBDUPubQqJC9TwIUlBCPMvi2e2RUt?= =?us-ascii?Q?HHmkur+wkb/YRcfITq7592iKQ6K4hO+mFQHY+VreO+qUA70Xpm92SffqjHlI?= =?us-ascii?Q?4uasVbI2WMGqiXh478FOg5a3N1nKFsyY4+6Hdi3Xq1n/SrXryEMMaqYuXUHr?= =?us-ascii?Q?DzyJB+1NyC/MYL9SQXXouk4MYiYcg9Z+/+p+81YyGvCd1ZFSa+y94/l/wT2J?= =?us-ascii?Q?YXEjnIcMVT9Jsu14Uo/8BvF7Q4ifzrRt3x36JM5GFAKaEovPReVVdJYqG0nI?= =?us-ascii?Q?1Ohzos+iSk47p4ygMMiVH6R+PwYmDGH4IQaPBM++Z5gi3c/PzapX74+s69uH?= =?us-ascii?Q?KEzXNxec/RTXKhW8ZezARWByNfAPQ4XFzwHFHKx0meeXgkO6i3qZ5+sQnqau?= =?us-ascii?Q?2qGL+GzIJdjle7OOEm4DPg67B3t9FqhpfJCIovd2vuP4NmA7JBwT6BKpcTgO?= =?us-ascii?Q?hdURiZPo4R8jHJufGMcULlNIZOo7lWlJXShlyMgYrW8PLEd43CV9AzkV1dI5?= =?us-ascii?Q?tWGMtDJCnSAGHxxtwWFJbBtFWrYdxNEtRhIflcuRHvzte67tDrbL8uE0dzjK?= =?us-ascii?Q?yYnNp1J82kgAm6GrTes8pOrLLUWjTuwvGkZxWnUgrn/D6xeSg+q+zg4ikuJO?= =?us-ascii?Q?dzA7N9vLQyqoBL+Z9AItko3mgn4lgKHyFC7vDgec1/PsyWvy7jPD7y2Qy/Ab?= =?us-ascii?Q?tQLaCyCl3lJOqfoY91pT4QelCi0gvjBBh8wnGx+Nn4B7YahP1GkePQ4zmji7?= =?us-ascii?Q?JLp/yaJoIUj4JxGp8bJltYQBqi7Ng1TcDL6d9PPxIuj3fwZQ8cvQatf6l9wQ?= =?us-ascii?Q?n2vTCTAWk2yQCsYkJfv/c2zdGwZBf2LMQRdKSDUmbD6g7037nLuM6A1+OsyI?= =?us-ascii?Q?h2EYTpbS9E4L8BKt1vUlnY2Dbw3X4+87Bu8JVsQq/eFlrkyOAdNgywfJAV95?= =?us-ascii?Q?2O1nqXd6S+IwIf2lnHXefTVLjSaVoGqarnslu71liYzLn2ie6ywoOAaT7zJx?= =?us-ascii?Q?IFqnHxMbCCRJMm/RisD/VjriVcTlM6UE5AHsEaphGyIdtXT5i4/l4YrzojmV?= =?us-ascii?Q?Jy2zWw=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Hk73TrtXRD0og9SBUF3xyLmUescJl5rvV+T5Vz1Sr+uzoNrjObz1+KTI5DuCvmvKnaXPM3M/yvmu2wC6mGz2DjdodP69a7mnyMzoWVaIK0kMRyLSfNYNUUnwjFJ61mRQyf6HRoKT7Ei8Rn9e4+tvxyZUelG6Pzy9uoYlt/sSDlFSEgSDaLGAF7tHvmjFGpTNQbaAxmtFHAQYd8U5ZAB57VA8uWaNdVyOrSMX5RQ1dVNdpzRqPkcb+E52j2a6bHxkT6y662DZVWvoFB47Ho1QJ5kKjxpPbZu6XhrVd77I4Ma23NWbAgueIIg6mIOuGDWmQdGYw/B6UlUuBBPzaJuiwgTAFWW7BIkouL/Hj6FEsdrT1o2QMaejUb50dQq7cNfdu+3n7++1wvpqgJPiwW1Zh3z/4d7qcMRQCLDUxwHsmt3JVyEq/6nWLDdZVVtRGmiR X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 11:47:48.3938 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f71e05b9-fdc8-46b4-14ad-08de739a8884 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000044A4.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4076 Content-Type: text/plain; charset="utf-8" From: Jianbo Liu Fix a "scheduling while atomic" bug in mlx5e_ipsec_init_macs() by replacing mlx5_query_mac_address() with ether_addr_copy() to get the local MAC address directly from netdev->dev_addr. The issue occurs because mlx5_query_mac_address() queries the hardware which involves mlx5_cmd_exec() that can sleep, but it is called from the mlx5e_ipsec_handle_event workqueue which runs in atomic context. The MAC address is already available in netdev->dev_addr, so no need to query hardware. This avoids the sleeping call and resolves the bug. Call trace: BUG: scheduling while atomic: kworker/u112:2/69344/0x00000200 __schedule+0x7ab/0xa20 schedule+0x1c/0xb0 schedule_timeout+0x6e/0xf0 __wait_for_common+0x91/0x1b0 cmd_exec+0xa85/0xff0 [mlx5_core] mlx5_cmd_exec+0x1f/0x50 [mlx5_core] mlx5_query_nic_vport_mac_address+0x7b/0xd0 [mlx5_core] mlx5_query_mac_address+0x19/0x30 [mlx5_core] mlx5e_ipsec_init_macs+0xc1/0x720 [mlx5_core] mlx5e_ipsec_build_accel_xfrm_attrs+0x422/0x670 [mlx5_core] mlx5e_ipsec_handle_event+0x2b9/0x460 [mlx5_core] process_one_work+0x178/0x2e0 worker_thread+0x2ea/0x430 Fixes: cee137a63431 ("net/mlx5e: Handle ESN update events") Signed-off-by: Jianbo Liu Reviewed-by: Leon Romanovsky Signed-off-by: Tariq Toukan Reviewed-by: Simon Horman --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c b/dri= vers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c index 9c7064187ed0..f03507a522b4 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c @@ -259,7 +259,6 @@ static void mlx5e_ipsec_init_limits(struct mlx5e_ipsec_= sa_entry *sa_entry, static void mlx5e_ipsec_init_macs(struct mlx5e_ipsec_sa_entry *sa_entry, struct mlx5_accel_esp_xfrm_attrs *attrs) { - struct mlx5_core_dev *mdev =3D mlx5e_ipsec_sa2dev(sa_entry); struct mlx5e_ipsec_addr *addrs =3D &attrs->addrs; struct net_device *netdev =3D sa_entry->dev; struct xfrm_state *x =3D sa_entry->x; @@ -276,7 +275,7 @@ static void mlx5e_ipsec_init_macs(struct mlx5e_ipsec_sa= _entry *sa_entry, attrs->type !=3D XFRM_DEV_OFFLOAD_PACKET) return; =20 - mlx5_query_mac_address(mdev, addr); + ether_addr_copy(addr, netdev->dev_addr); switch (attrs->dir) { case XFRM_DEV_OFFLOAD_IN: src =3D attrs->dmac; --=20 2.44.0