From nobody Fri Apr 17 01:47:01 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013005.outbound.protection.outlook.com [52.101.72.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E894337E30E for ; Tue, 24 Feb 2026 11:36:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.5 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771932984; cv=fail; b=RwJbVDoCytLgMB0itZnTEs5+fjKILObyeLReyX7vkpukE6PNqY9NSaJIY9pZduwMG6nXiKTZQ7b3uf/7+jvNoy/v+ss2ySOCOVnhlEFb9nbEbTtsPu/gdIZ1WJPkwt1vHWkziqsdHF6PGyPuCMJvNUOuiPa33V6qujqZyNLKROw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771932984; c=relaxed/simple; bh=+29wZWGAnwY2HzJUeL7zKnPk8vB2SOLxb/Ek/sKANFY=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=BbZgzAc8srf/43KdKzBsv/gmfjMwU4TZ9CK002kI9gb8jqp3g8zRN/LfCEhGwhCyS/NH1tPH6dYA33bAno+Pd2uJ8v3Y8V53ZDdyIAD9fUPF6rSjPZnFLi2gyoHdOx1KBxqg4JQMPgGx0M55NAs+8Ki648stJ4m9XTNUIextK/0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=JdlMf9Ih; arc=fail smtp.client-ip=52.101.72.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="JdlMf9Ih" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DiKLBg73XxG2Jr0Gn09ipw5u1UTGP5aOYyy3Q95PAfG47mCIP7EO9sHWAnPFVRPyhy1czN1JWc7hR0xFULyt6THKfqyMy5hdKgWsYvCuxVAIhj8kW8Rz8+Zlf/aumXu+nIU/ePXnlibNf6JVc11zqbWQ3XR3nEhJm1/WYprdPqAbBSxMf22TMrqlZVWU55LD2IwjfdJuMvmqqyCnna/8l/Ic64vghlUeUE69uKjU+utN9XIfnq6uVhZe4etuI2kPqPjVZkNWkm4Uxo1qurHA2pqALnxNcpXtWgeBM8MZgEm4P77RLq4hBfJPcFyQajkD0cVDi5hSzpny3YlTER7oag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gqxu/nH8WtfHN4B/GjvB8doMD2c/Npd6x7EnPoza72Y=; b=QbXocysBtanHoFoN0W2PyQakDWRVLdztrRuHhIBC9VvtJnn+CdBZiaKuFJTE1+lsfcvTq2XDihhAsUpgLfQ2OPCVEfKsSRoBU6XlOsVvXC9NzUblcO3tb6SwbXjf9l20wjzp18Yw67BJeHjpmfKavnWk0VAKd0koRZAInAaOOLCQ2MRbA7AO5uTyquvV0sO2V4k4JRut2TODHYWV4CeqW9VhUwaKPxHfb6HcsoVy+x1fSRpLJZJtfY0NcqwJrAycOYgoge8fq1f6FlF/azcflWoSSLeM/Na6o9Bs33QG7jeJOg2M5I3a1sVGMl6wjHJeKhmX9m+VqOXwPK9lmu4d+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gqxu/nH8WtfHN4B/GjvB8doMD2c/Npd6x7EnPoza72Y=; b=JdlMf9Ih12rKuNHYR8uEY+DDV1smjE6N0tmYKazPBDgShvjJihHSrIICBogDIoJedyeVWMeRNa/dgwmO9IKxd+Ue2e+Hq/pw8gtwvUSnr98Wa/SzVrPviOzPdXrnpJWyluNq/2LZcm6ZnIAa3KnQoNYBTpTSScKiga1TAgTmUx4AYznaWXLiasbZ+LJTY+6NWJX95F8FkZgodivhlB4RQAjzxMtb1L/llIyCUbsGYM0D3XGaI0MazT+PbuJQteXtdmdCenotaqqUwqaVRKDcEWplzXwB0Psv8ko34wLsthSa/FykVKuS3jn63C9bvmLMKYQ4Yeps6io1sOhflLmB/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8253.eurprd04.prod.outlook.com (2603:10a6:102:1bf::7) by PA1PR04MB10324.eurprd04.prod.outlook.com (2603:10a6:102:448::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.22; Tue, 24 Feb 2026 11:36:17 +0000 Received: from PAXPR04MB8253.eurprd04.prod.outlook.com ([fe80::2b4e:8130:4419:d633]) by PAXPR04MB8253.eurprd04.prod.outlook.com ([fe80::2b4e:8130:4419:d633%3]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 11:36:17 +0000 From: Ioana Ciornei To: Thomas Gleixner , Linus Walleij , Geert Uytterhoeven , herve.codina@bootlin.com, Alexander Stein , linux-kernel@vger.kernel.org Subject: [PATCH 1/2] Revert "irqchip/ls-extirq: Use for_each_of_imap_item iterator" Date: Tue, 24 Feb 2026 13:36:09 +0200 Message-Id: <20260224113610.1129022-2-ioana.ciornei@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224113610.1129022-1-ioana.ciornei@nxp.com> References: <20260224113610.1129022-1-ioana.ciornei@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::8) To PAXPR04MB8253.eurprd04.prod.outlook.com (2603:10a6:102:1bf::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8253:EE_|PA1PR04MB10324:EE_ X-MS-Office365-Filtering-Correlation-Id: f927fb3b-5379-413c-1520-08de7398ec4b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?mmCBFBKK2X/HIHXtVlV8dQjB6slBxYrHWCSzeP0QR5rpx7K8i+YHQ3loRD4a?= =?us-ascii?Q?BhC82qUCHHn8QeGMaMqt2I7tuAhkAVxd7ZjI+LV8D7iGdC/IwdSBEEfWU1d0?= =?us-ascii?Q?VpxhDN5m4AtwY5nsISGqQY4/4HG0N0syyHsWxAW+GC7q2jlnMdz9PJ7obvNR?= =?us-ascii?Q?b9lngGsKbfvtGORRYtHp8aimaPy6EzmNwYrAPQgyZsQSwPpD3SbeJrJ1hqFg?= =?us-ascii?Q?V0IGkMmjZKaRgQPJNbtPdfFUQfUXhYya2Fh9T7EBSdL3qH326KHTNwY22ETT?= =?us-ascii?Q?wV7Au653j8LiwF0yMwj4/xGwQQkEpVqPw0adJ4BQyAEpvb29XiLp3g+UhzQI?= =?us-ascii?Q?24/L9IL1EKmxY9B+Uel/ByC+QNdDGNNRCJxs1Lty673Kd8Ai3BYGlQPvt5Bw?= =?us-ascii?Q?FzVCHbPJR0BnRLKb8Qz517qP7KIWJ/Lq7XVmWXxbmL/8wt50voMBBl7zJZ1c?= =?us-ascii?Q?BQn2bzryx6IqP4GGlj9DzIzF6oDRSpXWf1NxZqLUiAdbpRBI76U7B+BOvzup?= =?us-ascii?Q?GGLc57Qc1UFMJ5EZzoCo36yvyzHGZfiPJeTz0B6QF9Snl8kYQ4o9AXd1dl/T?= =?us-ascii?Q?hU/wqhk0nFVE716c+SBZD6CYRWfU14I6eGOMHEYb66W/e6CsNvEzu1qgdeFD?= =?us-ascii?Q?7l9yDTsgxLkN4zmUDhgSYr2b4nzYd50YtOLqFW5YPUPqLmPB1b7njHnl2ja5?= =?us-ascii?Q?4rz+hYZlo//eRcMj7ixj1uKV7fqFrdCXdtm5YdLQo6UIGL2IbfD4aV3X3j4O?= =?us-ascii?Q?+3Ym3OGWGxjUapAb5AyjJ5JDOGw27EvbnHDKGlUXX8/U1C5fm7B/zeu1T5wp?= =?us-ascii?Q?Uo0eepbURnBtHNMbpqHpC0caEA1M6W0BQSCB3wFy+/jRaBysab6jDt/i73M/?= =?us-ascii?Q?mMwzQxoE7cDiOMnN32MgBgh0Kv2u/YUqSlQeg+GTI6Uq0Ge2onYC4iotC5wc?= =?us-ascii?Q?Lf7H4UUPZszECzU3rwo0Ag5G2tDVxjH9O538++AXRHiZR/bgNCYreSpj/yfX?= =?us-ascii?Q?d7RzFo9F4yrYbK4v3DN+CefW8KMB3aTsYs37/On2FL/xHECIuQO5qOHkyCrY?= =?us-ascii?Q?nb45VnohMn9+fK3GRv81XzXbEahStXKOQTHDMipHqMZ81FgnLroKDKMFPxne?= =?us-ascii?Q?i2CtT/E5vNdE2PujJZtbzmXnO9h67earXwEhvoBVxebP9Zm0T+BeR3HYkHgH?= =?us-ascii?Q?rWP7QpPGvS1odgLEZ8IsM3kqKXvAMwLLZmd6Dc0zjHiGE2/WrOwIzYr0TwiZ?= =?us-ascii?Q?2lzRnYOi4pmy5ZpryWuwEZHuOG3PLnEU9VN6CHiFRcNdmcSD1p1LzDbEqbMG?= =?us-ascii?Q?o4Zmxvczu5vh57ToW44QR/uSGZ+XpOPK24cI7TvmNjYAWc+SGUASPp2XXwcR?= =?us-ascii?Q?UMOiu3lny9V8Hv5Po+MsujcQYtq8Pbwj+lMjVsKimEfxu6w0JqVe9dMj2/mC?= =?us-ascii?Q?/obWGYeu7ZTMDCIw0R7HLbHRG5mEQQzgiIVfDnFWOkvjNLcs5VOhwX3FFgAF?= =?us-ascii?Q?dnrvG/34S/nEcY1LVIYKrukAPrnAbvbzXJsZzKwU7OjaK4CD3D/eh99XhAo7?= =?us-ascii?Q?zqKRzIiBdoAxMFO2mIs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8253.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rxj0skkomiidr2bHgtsDJ1XHd9rWVgaXBPEzSEr0olqFwo/jo7WCQ9QNf6d4?= =?us-ascii?Q?8Xfm/kCrXrAOO7Od0jijpKMz0IbS8yyL0k4oGSPD/IxPHHidi/DxWuJ03+gN?= =?us-ascii?Q?eGHdbzZmy9oH8nZPQDVTsHjPTIhZFzgaT7+hPAlTS45XTBKaLcesPleTH8Al?= =?us-ascii?Q?gcHUCbqmyK46L/gMtewFAKzaBFikO+6q4LocxgWA2jQxZsb8IdHmAj8UmolC?= =?us-ascii?Q?G9fHLi8D4H3j9j44KXPGpsddxUBBnOvzI7GC3O1E5z1N61juO4BaBhNV3NA5?= =?us-ascii?Q?YkGGQ/01Y7PzIh5En3tS/s57Rc4uuDwdgYBGvV9XFVmIfwU0wsWPZpYesZcV?= =?us-ascii?Q?9UuEj8pDP3EaQMKuXjM2HPydNMxwOlrkoFUNyO8xouUnGsq9WtkgqgNANWW4?= =?us-ascii?Q?M8XKMc2hsDz+8AWS7z4oaouRRY/FcF6wJ7irVfrH/20LFFC0yDJJcShRS4+O?= =?us-ascii?Q?Pgh9kQcIOBob2C/3uM8bFqXhvaO21wMxNEvNEZDhKGZskUs87Kn5tYFPS942?= =?us-ascii?Q?PXU4mMplHWUt8vx1uqGmdEZeDVTsX38+n6r6wFGNXznGiZ6PZJBeGUwE3Wxd?= =?us-ascii?Q?r73+qEYSVWrA95gYxte7ZY35qJSJU1R6ZbwMu25XkDUMO/unnlzsZn4bzfK6?= =?us-ascii?Q?2tv5vPBRVURXc/muye5wA+KWTG1FBPGtTsmsinm96L0QrK/FUdkQU83214r0?= =?us-ascii?Q?NBfwEQ4NRjaW3CaEPtW8Z0Cj6d/7I4TO6aRPY1Wgn/5U6KrqNLOu2VXyx1yb?= =?us-ascii?Q?E891L3Ec9l/XfPV991Rvis4KqUG2PeldjAFc15F76YVxhEMgoHO9uGqett4o?= =?us-ascii?Q?5VCSBXYLRKRU0AhwR5vO+gX0bd1JXM91XlqE7bPuMvj9TLIMTrCMt2TydRwL?= =?us-ascii?Q?1rwSOajdH2DUdRoAmPtZqXmNX/Hlndizuyf2ETDlxMrxMkffs7tiddFVqyrl?= =?us-ascii?Q?gwxDV0WcAHi5+e7689SCdZjZcoKNR9svDE3TC0XcrmlMCVMc78G+4lTaVag6?= =?us-ascii?Q?7ZkMFN8KnyK/KQ2vCa39nFbaWfxBkBuhd1JwlV4kkN8OWrU4Z2NPQ9YDtsNf?= =?us-ascii?Q?FLTbdw+DE5eYQcd4U6RT7N0hDxXDxtFiv+hmA4YL0rCjasdQi3i8QgeUedBN?= =?us-ascii?Q?x5V9kgLTdqvGR9xAKwUt/UFCVgNzKmQ9qms9NsC9ScoFpjMsSod7+PbvEde0?= =?us-ascii?Q?Xk9NWOQvqxsYFzXdpj24AWk+EIM65q0t1ze4mDJCq0RQTr2npemf14gpUpZs?= =?us-ascii?Q?qTKYa2YT0NsYexFMQAe4qT8udYvEN7iS2uOffBRd24wLvuff79EZwQip7+wl?= =?us-ascii?Q?dlzpB8N+CHk3g0c8HkeNoUNaVB8dzkjhzRExGOQT87KDEwGBlT2BRNSEuPyK?= =?us-ascii?Q?t4/6SlyUMk3XyYo2boO3D8GipEOh4v8slcLo/wNCic8EHfwmvpuIRWWbLnx4?= =?us-ascii?Q?CbvC52BnLLRulUSnRxVRRvSl9fKGVuUpPOTvc5sqPHTgmPUqO6cAysJId0c1?= =?us-ascii?Q?3/SxsRm3ALF1sBJOuFKOhjncc/7pj0hTOtSmim5cDxvyfohTGdo6UJ5GwuGq?= =?us-ascii?Q?j+uQmZPGonCyD+FFvQT17zbEZlbYw6DlX7YUGUV2ah3DwUuBWYoikk8OpyI1?= =?us-ascii?Q?L43X9moZb/KVsuEdtXbYzjqqcVrhm0bhE20mPjhqpI1UmLTdtf6KZMfeGExX?= =?us-ascii?Q?FbguzuP9ub9Gl4jtpEh6cAlFNrv4doU0qVaxea8SfpzRucahtUqEHhVU1zyX?= =?us-ascii?Q?bMLjjsfORQ=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f927fb3b-5379-413c-1520-08de7398ec4b X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8253.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 11:36:17.1442 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UJwbXNxipWxRb8G8mMgKVwLqN1hFmiU2bX/4o3p3Efvz03wbzNBfkzafe2Jw7NV2GGvKolg7ItHw+9ALM0phmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10324 Content-Type: text/plain; charset="utf-8" This reverts commit 3ac6dfe3d7a2396602b67667249b146504dfbd2a. The ls-extirq uses interrupt-map but it's a non-standard use documented in fsl,ls-extirq.yaml: # The driver(drivers/irqchip/irq-ls-extirq.c) have not use standard= DT # function to parser interrupt-map. So it doesn't consider '#addres= s-size' # in parent interrupt controller, such as GIC. # # When dt-binding verify interrupt-map, item data matrix is spitted= at # incorrect position. Remove interrupt-map restriction because it a= lways # wrong. This means that by using for_each_of_imap_item and the underlying of_irq_parse_imap_parent() on its interrupt-map property will effectively break its functionality Revert the patch making use of for_each_of_imap_item() in ls-extirq. Fixes: 3ac6dfe3d7a2 ("irqchip/ls-extirq: Use for_each_of_imap_item iterator= ") Signed-off-by: Ioana Ciornei Acked-by: Herve Codina --- drivers/irqchip/irq-ls-extirq.c | 47 +++++++++++++++++++++------------ 1 file changed, 30 insertions(+), 17 deletions(-) diff --git a/drivers/irqchip/irq-ls-extirq.c b/drivers/irqchip/irq-ls-extir= q.c index a7e9c3885b09..96f9c20621cf 100644 --- a/drivers/irqchip/irq-ls-extirq.c +++ b/drivers/irqchip/irq-ls-extirq.c @@ -125,32 +125,45 @@ static const struct irq_domain_ops extirq_domain_ops = =3D { static int ls_extirq_parse_map(struct ls_extirq_data *priv, struct device_node *node) { - struct of_imap_parser imap_parser; - struct of_imap_item imap_item; + const __be32 *map; + u32 mapsize; int ret; =20 - ret =3D of_imap_parser_init(&imap_parser, node, &imap_item); - if (ret) - return ret; + map =3D of_get_property(node, "interrupt-map", &mapsize); + if (!map) + return -ENOENT; + if (mapsize % sizeof(*map)) + return -EINVAL; + mapsize /=3D sizeof(*map); =20 - for_each_of_imap_item(&imap_parser, &imap_item) { + while (mapsize) { struct device_node *ipar; - u32 hwirq; - int i; + u32 hwirq, intsize, j; =20 - hwirq =3D imap_item.child_imap[0]; - if (hwirq >=3D MAXIRQ) { - of_node_put(imap_item.parent_args.np); + if (mapsize < 3) + return -EINVAL; + hwirq =3D be32_to_cpup(map); + if (hwirq >=3D MAXIRQ) return -EINVAL; - } priv->nirq =3D max(priv->nirq, hwirq + 1); =20 - ipar =3D of_node_get(imap_item.parent_args.np); - priv->map[hwirq].fwnode =3D of_fwnode_handle(ipar); + ipar =3D of_find_node_by_phandle(be32_to_cpup(map + 2)); + map +=3D 3; + mapsize -=3D 3; + if (!ipar) + return -EINVAL; + priv->map[hwirq].fwnode =3D &ipar->fwnode; + ret =3D of_property_read_u32(ipar, "#interrupt-cells", &intsize); + if (ret) + return ret; + + if (intsize > mapsize) + return -EINVAL; =20 - priv->map[hwirq].param_count =3D imap_item.parent_args.args_count; - for (i =3D 0; i < priv->map[hwirq].param_count; i++) - priv->map[hwirq].param[i] =3D imap_item.parent_args.args[i]; + priv->map[hwirq].param_count =3D intsize; + for (j =3D 0; j < intsize; ++j) + priv->map[hwirq].param[j] =3D be32_to_cpup(map++); + mapsize -=3D intsize; } return 0; } --=20 2.25.1 From nobody Fri Apr 17 01:47:01 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013005.outbound.protection.outlook.com [52.101.72.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A79E237FF6A for ; Tue, 24 Feb 2026 11:36:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.5 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771932987; cv=fail; b=V/0X3Ef0EwBGZqsgbrNg0TfQv9Be9S8ecvTxFbny7CWFMtqJCQdogDSWkcsxJcnEZ3460com/0E4kT0eOr7p/wlRRUtl5gHpzOtpFfoVw6wbDt65ZXV6RFyG0xlGxHycD2FDRsJsYJqfAqhDAThkva+LSm6GDkqLpF5H4GGYyMQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771932987; c=relaxed/simple; bh=9KxfbCizruSUDNyOs0SfFf8wPxv738QYK6o3xpy4TOA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=phajxXtoxIra3VQKxHDlpIZDsM4Opj/WJJjBwwL13VHlhnAHDv0wGXwf2PR0oYJYDynoBu9QIm8laCRfQmu2x8h6tUAjsxEAOilGCIMlVKGdRNUkQmpUVHsIlDeVEZzdOuRT6xBRsxEW5Qxyfm5bLtpMIbPg8nVWvkK42Wer00k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=OKmjJL+6; arc=fail smtp.client-ip=52.101.72.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="OKmjJL+6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xyQot9jiWq4eM8yanJ8kSVZYgZ1Q+n7ZLagF2QWxOHq4JbIOAKPV6gf1rqh8eGoRj0ULPSjBNjfRS6325wQm530IyxZOk5DTvszJmxo/X9J63+sGUJVOxuXi4SYU8WOApuZnzOiJDNX94vIPNyNbaDH1pMy4+EweARp6XCkqDc04AheWU5zaoikX+QG8DbQChBDLdXwijekE0BC6ux5zx6usbpoMm9VEBneroyLE8ifZKuWp/GpyUOkT0zXHgnnaDbWP6oSMACk+bff58iNnnROjmwiuME7yk+GYTpVNgyyzTdeJ5q5VuyMZzxZnoT4DnQ8M7o7houd4cOacWyy2wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sZiHXtEhT2+HM9t5+v/2uEXpH58lRZS/8Acle0/eXg8=; b=skL+qDgtmAzRbA6RmDAcH9xZmmtwg9md1PR95JSOobwpi1Z2L95d/DE8WkdbQBdEZtSRrdviI6iAdRKKd6Wcnd0LG9c4pGxNytsy0k8sLt2Wnzc55V3focPHFmuEUGTLr7nfUvCq2H4/urSSB8lvw9Ch9WWlAgiBd+0l4vfxyM9PXFqZr5LccuLUcrehrr+FLeuj9gulj8nJ5N6joNK5SR7WiCoxrGdma84U8I056nDVIr7mU480wLzECU4uhyeWT5YwXwCWNaMTvsNw3ZVQ09707Fwm/6fkDZw0t0X4vPXIuKKNexTfhq4JmE01BfCQyqe9CnDwtRoDFFBd9Wno/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sZiHXtEhT2+HM9t5+v/2uEXpH58lRZS/8Acle0/eXg8=; b=OKmjJL+6hgNiU9i+SV2/xp8p2DChCA3QK24y6Lq987ijViFZ4LfnW2dBil5m5Mpc7Nh7QrscRsHFdBUkAcosBw6xDPcM6QbgFNupD+T1QRFonOfxeSWR+pk6VgxudFJfocsfJAOLGaeH1WdsnqUFaSkQTTp5vh7Oh+WUk9kL5dRwLiF+c7pZ7lpvJTm8CjWH1goYOf0w48Z1el3twj4zZl15lctEtOP9LKnJWOi7Z/1ZGMSWLJKFe0H5vkrpVyAwbdKRefu+FK9HlYgKWrYFx/MsVC/yubkE95e/pa1r7QQhlfTl7l5NGYF2Cww4+Ec2pG1FVBLTfDdwwtb6ppIPow== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8253.eurprd04.prod.outlook.com (2603:10a6:102:1bf::7) by PA1PR04MB10324.eurprd04.prod.outlook.com (2603:10a6:102:448::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.22; Tue, 24 Feb 2026 11:36:19 +0000 Received: from PAXPR04MB8253.eurprd04.prod.outlook.com ([fe80::2b4e:8130:4419:d633]) by PAXPR04MB8253.eurprd04.prod.outlook.com ([fe80::2b4e:8130:4419:d633%3]) with mapi id 15.20.9632.017; Tue, 24 Feb 2026 11:36:19 +0000 From: Ioana Ciornei To: Thomas Gleixner , Linus Walleij , Geert Uytterhoeven , herve.codina@bootlin.com, Alexander Stein , linux-kernel@vger.kernel.org Cc: Dan Carpenter Subject: [PATCH 2/2] irqchip/ls-extirq: fix devm_of_iomap() error check Date: Tue, 24 Feb 2026 13:36:10 +0200 Message-Id: <20260224113610.1129022-3-ioana.ciornei@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224113610.1129022-1-ioana.ciornei@nxp.com> References: <20260224113610.1129022-1-ioana.ciornei@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0060.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::16) To PAXPR04MB8253.eurprd04.prod.outlook.com (2603:10a6:102:1bf::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8253:EE_|PA1PR04MB10324:EE_ X-MS-Office365-Filtering-Correlation-Id: 3cd65c8c-1b00-4c6d-56a4-08de7398eddc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?b+vyuK4dXT5iECtxtsnwDa9pu3ptZ0aJ8VB4T4oRH9a1GoEU6ht5HHdYwWja?= =?us-ascii?Q?LE/rnzYQoN3HBq1okLRZya1wZiha/1RNezWzW+35rHUY//S+5uOPIlSfJWPv?= =?us-ascii?Q?I+2oMAv0RXNmYdbuSwwXGiU0nJtKtjJ5hB6GleqxCB1GY2dd+TzRrakPvj9W?= =?us-ascii?Q?TC75F0LbFN1pH9Vpp5lwurhZ9JdH1WppqVn/lV3QW2nI3g5f9V6BAwVYF3gQ?= =?us-ascii?Q?pawCAXVHs59HYQZ9uGh3MRkpw2AlDqf/TWox2rFxhApmeQp2/J8xJfmj65Sz?= =?us-ascii?Q?PFta8xWaCqVT1eFCHXki2BXAK8cRuXynyl57mIjOmiaezgwbDgXChNg7K4Ri?= =?us-ascii?Q?pOShu9jDJcFEvq5Zo9Obh4gQGqODmvl+nQwTNM0k3NOxGmTPfyLomICKH7kj?= =?us-ascii?Q?HnaI/TeRnRN7q9X/VOtOmG2A2dys7XqiOHcRM7jbp1pDjwxXLti08WiiVX2f?= =?us-ascii?Q?Hc3ZURwJFdUrC2LqC0cshogfXtbQm6gKmtKf/pD7RSkY99ANvQqf4FURTQ6r?= =?us-ascii?Q?erTk3M6IPlmmX+tpIOKCETrATqCKatfRyOK3JQZD24Dhv96AuqzQYngyJW+a?= =?us-ascii?Q?SJK5xLGwFsVeHTbyfqBbrR4U7aEi98iZYo1Vhd2H+xCoSyMSnd5bYcZxuJr5?= =?us-ascii?Q?7FBg+GSnRltBuM5O8/zmCqnU5gbWsiXRCgYf18hUf4dhgrOJnkmEVa+S1eKU?= =?us-ascii?Q?3WxZIhCMDH4RE7yqo+JFWTt6WMUythjZFf6Ml8B6jkgJJErkmP1OfvcOMVXK?= =?us-ascii?Q?753/OrXyDAPI4wFPKPBdlko+atUmFHL+ZTemes9PN8/VZ5KmL2TJckfukGVI?= =?us-ascii?Q?qqRTbU+9J+TlGB4kIre9ZepjX34vKBhADIJlw8Wz4I0ljEbh07QUTWHy8FcR?= =?us-ascii?Q?2RFRZ6WpcniaZpEDvKpaoEzCUJJnQrvaUViptGfyNqG4983roeLA1RMSFI8b?= =?us-ascii?Q?G/p2mmfypnTX5ziD8ZMBHLgd1dM4Pvw3Nhd0350z//HGg6d3AVDOtG1qKUC9?= =?us-ascii?Q?KIX33bpa8/KlDT28qJGaCNeErRBQrrp76gOpB1IR36UpDAxLJzMdY5FRDsHp?= =?us-ascii?Q?ixgEjL0AJ5uA071EhGB7vI9jhhcJMq5x5FKxRMIWukj8lxf7oiXuEUswMsOw?= =?us-ascii?Q?BmMt+nPhq+6QLcpX///+IwrlkovoDc6/8J4h279dI+HzMux/rfckppShmqXC?= =?us-ascii?Q?Eljqcy7H7GdI0GIeEWeW6jHkLsxo/HVGapJXDGgXFml4u4A0Ek/nrnwDx0ma?= =?us-ascii?Q?sNQZHyo+ZD5T5N+J13uk3j+BbX8PbJaN8iDtdVK582HyyIykUdIO/pDuyz0H?= =?us-ascii?Q?cAOrmCmlJVxCEVudSbxK6hnuOojDGWh8ifyWDbXEGCdghOW7/O+iIHISCX75?= =?us-ascii?Q?JbFYQujBvMmCliwnC1oPYYNpMdVN1ksL3PupmPYyek0oLa6HH4e7Tb5aLrwi?= =?us-ascii?Q?QLzw/IJJ5eBhH7sOvEXqn6vBU05MWkWqaEePoJf9xm1bFH5DMfrRxcV7NQ7o?= =?us-ascii?Q?jmQEfUK5KcvtG7YyBf7gCRH8K0H4fD2LbDZx2tuvja3NVdkAigxrJtxyqJFg?= =?us-ascii?Q?/8OefiZvaBlhlobFuhE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8253.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZGN4I5peAp0s//4d4ZEBGTwOpWGxxT7a5BqEQnsiACPSeO8P7T1A5PZFqrHO?= =?us-ascii?Q?CjW/4G4Truoz+2Kfddut30bfSRbNAjFYvAx+/qB8dEQOW4d5rvl/h53m+UzL?= =?us-ascii?Q?9REUmkEs5uK7YTCyXSlgUNwZ1Rz6YqQtvv3oOdEZtAxWvnkuL41FQzX0eJJK?= =?us-ascii?Q?PjlkFSC5KRi2Gj/8ZOPBiRB7wAX0pbxnB0BHPyyF1Q4f2j0ViVDqA/eJv5PE?= =?us-ascii?Q?qRkQiaH3tUJX3IneG5weSgZ/HOhAGNpSDgKw0JLa+ianxGFIWBwgbYUCdva6?= =?us-ascii?Q?OdYUagucQ+nUM/OXBE6Zi+ZK3VzxjAGUfZS1UueFbc+grID8wxRZtFGbkaY+?= =?us-ascii?Q?SBy9BukZ99OqXiqZU06q/AII0pftf03XGoOVu0WIY8/GQkX/JTyngKcgGSYE?= =?us-ascii?Q?LP0Qbgmiot/wzUKnBxxo31iJSWzPKCHCJa4pN4VkvWqtbkeCwXJRde7P8xVL?= =?us-ascii?Q?5dfk+uCv8eC3EDcD394w3IHTpCVwotbkhj+hGvCig1EEWEyT3evklq4ZlVb1?= =?us-ascii?Q?KWWitOyLzlHvw1NC8ZnV23LUVxiEFJ2wACLxmaLWKKwfsksmNtBVsh8hDSy4?= =?us-ascii?Q?BAuH6CL0peoUDRMD0XHrHwh98bXkspMr8i6Ks/Bp9EI/0MJkll/76ULNKWGC?= =?us-ascii?Q?zfZ3AcOXkuC4R1A/u2pjKthpwwi2VsvqH5ctjnLnvwmCAhKLzxNnpL+wFA4L?= =?us-ascii?Q?AyMPdxL4WH8ZCUcqrcXgQVzHZeRkiOzIUz8G9YGaOjMlUTKb3jsheDqSEUIb?= =?us-ascii?Q?v7e/9mwKBtQKK+YcFX0Td4xm/BrMJdvi5ejZ6ojv2LSm4brm6AwaJ2bj7Obz?= =?us-ascii?Q?bY3eJ3JUe3AxdxQ+vTAlbe5OP2v6QNcgr5EJ9578NnZipwanKrVmLkefGQNI?= =?us-ascii?Q?5x/tvkzUo8rYk5SkTmDn+purepMOIncK7r0QOZHiwPqDrmAeV9XhK8TKijPN?= =?us-ascii?Q?PiYWwJfRRmBCGCo8qhTVJrYYfYZZR70lS6tU1BmgvGuEMpKnDSQQD8DJWxhw?= =?us-ascii?Q?aloqvbJi9xF/njqAXR886sDbGz4n3Ou2ggzemOH+Cnl9APAV07Z0h/JH+Kcv?= =?us-ascii?Q?NBx4EEmYzQR07QoCHKDh+1o7zKN8GkyZmmD2qHYJ3HIdodZdBiG78RKRY8Cz?= =?us-ascii?Q?XBu6qGPigVvw6CxOHN9LO84DsPCkXxKQHmzegMAhoyL4fcGECqack88soFjz?= =?us-ascii?Q?fg8cOvPCaarMlM8nErKg/dU8nA4x1HE5bS8xhqVZ/7R/jVBmHaPb3FKp4btf?= =?us-ascii?Q?k0JxZ7qmnHSlmQdSywIAL1khumKIW5BJmlYmsTjecbab/5OiLcc9/qZbUW6o?= =?us-ascii?Q?mMfl0f4nSxDw0anE2husKmLblxZTIEZa8vaqt92siA33ToHlS4x5kW1KInvM?= =?us-ascii?Q?6l8V7fg6V+0DcFdHotZ/Q5Fr9jjP+XPQaKXSHQ1rdia9qOcsJde4jCk9sNtK?= =?us-ascii?Q?3lM9X+wKl8fa6vPOE7wxkc/IrlvDrVVQ/m6OOEwNgpD1vdTJCwQmB6wD2a5j?= =?us-ascii?Q?+3axsTUxZtFZd3/nlfXs+oe2ZxcOjv+kHADTnrnqicjAfkxvFnVgo7qvT09Y?= =?us-ascii?Q?aXD+/Wlziq8ErGpMTnqmK05OWLqjVc4xLDvBzBo3xR81tMMY5Y+clYxWs5oM?= =?us-ascii?Q?x9N8nUic7lRE/1kH/ADxCPuApDz+FwmxWuYsB7CD3YUf7ZKKqXuYn/e8wz+h?= =?us-ascii?Q?X+wgqVzXgcd963yVDi5Y+qX0uTzIFTe6/jZsTIVJklJgF8b4e++s1C3rCv40?= =?us-ascii?Q?ltEhuVjY/A=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3cd65c8c-1b00-4c6d-56a4-08de7398eddc X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8253.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2026 11:36:19.6916 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 45G1S5n0yhy098isx96sQpQpYjfCn7kbbG7F47z49LyVbhKBN9XyO9qJNdb4INObnbP0/K1EGQWE1T/e+rueVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10324 Content-Type: text/plain; charset="utf-8" The devm_of_iomap() function returns an ERR_PTR() encoded error code on failure. Replace the incorrect check against NULL with IS_ERR(). Fixes: 05cd654829dd ("irqchip/ls-extirq: Convert to a platform driver to ma= ke it work again") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/aYXvfbfT6w0TMsXS@stanley.mountain/ Signed-off-by: Ioana Ciornei Reviewed-by: Herve Codina --- drivers/irqchip/irq-ls-extirq.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-ls-extirq.c b/drivers/irqchip/irq-ls-extir= q.c index 96f9c20621cf..519a9d89f7f6 100644 --- a/drivers/irqchip/irq-ls-extirq.c +++ b/drivers/irqchip/irq-ls-extirq.c @@ -190,8 +190,9 @@ static int ls_extirq_probe(struct platform_device *pdev) return dev_err_probe(dev, -ENOMEM, "Failed to allocate memory\n"); =20 priv->intpcr =3D devm_of_iomap(dev, node, 0, NULL); - if (!priv->intpcr) - return dev_err_probe(dev, -ENOMEM, "Cannot ioremap OF node %pOF\n", node= ); + if (IS_ERR(priv->intpcr)) + return dev_err_probe(dev, PTR_ERR(priv->intpcr), + "Cannot ioremap OF node %pOF\n", node); =20 ret =3D ls_extirq_parse_map(priv, node); if (ret) --=20 2.25.1