From nobody Fri Apr 17 02:18:06 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30ED9374185 for ; Tue, 24 Feb 2026 10:22:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771928576; cv=none; b=P8dxEefpizMNghyn956SWL+qSdvANbSNbvlY5zPoi5nUUKMzJezLTBOl7xcMAxVbmgKykF5HzSWMMsoXR1OPTACYLNhvVLJ+kaJpfotnK/6xtM0MHLBjW2jZXjHjpUXAdTPQbftVaO9FTlKVRTnjj9qewXdtarZ0BDAWaBtO8ak= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771928576; c=relaxed/simple; bh=nwAnhkxrVyOUSg2Z1riTC4kP5jFWpVmE+FFtCTrRPSg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SdMp1AJJsQJh1F8P81EYOs6BrIrzMA2z8WSer26HWvzxfvaWf03BCYmrsiQespeoDfXIIxShlyBd34+Qv8rXtLmEsB6I9t4Pg8mg18PcychRa3gOaLFBXiOoOWaSCkW4vfepHpypzeM9B4uqgT0mGCrBzAVJMQdKlTZUAYoNbgU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PAa4g0di; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PAa4g0di" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-4398913af88so255285f8f.2 for ; Tue, 24 Feb 2026 02:22:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771928573; x=1772533373; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t6WCNZtCDECV+3CSB6BCtAb2y4F78JMbRKKqCpKxwOY=; b=PAa4g0dig4yedw0iEHmKfqoPl04A6KkeUIqpB2g4SH2RX5tguwlX3fpluaNnGP28h/ /aN8KQjQeOD+fb5GrtsppYOsCl+rBVI4puKNfh62NiJgx7cIt3P+oakx/14L6SsdkEMo Zk+4/eYsOoJk3BhdBxIAT1B3edYLkKRmDApMWtilwEkAReEzOHQfyuHt/TzPaZ5c7XVy 2UL6mW9nWkJQ8wLbTI6H60zNs+GllcsZCDpp0nwBOVG/m2WmqFH/aCrEP7Uep08NY0dc K9V0pgBuwyHmkuNnz3OAlskfV7UIfk+ju3JQaAxIel1u+OWSG2CdUAlAK3hlOanfuAIC 2jgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771928574; x=1772533374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=t6WCNZtCDECV+3CSB6BCtAb2y4F78JMbRKKqCpKxwOY=; b=YG7AqI7/dbgmI8gz+ztifn7Z60i5ph5R02m4qugKt6NX9kJAQ7TnEPSi55m0VRdt6u PBpTYvsb3ySITruCcNFqceD9sKbfXKOrlUlJk5TIfoxTjXC88nOUMzXFYkmIONPLxEIU OaYEmL63c3X3I/plTSUZwiTVvsNSDk5zLWc6K4dpTbMRscvGVj49dHzuh6WH+qhS7pEh gli6o3IA7vdNxxdn5HMFDJgyGz/op3bz+GyE58ZY+XTAP3wkohD3NXo2RqQAeT/ThiL1 QeMJVeXm5iTweGQPOFcqvzzogpU1IfeseJHv+s7ZRfiwo6bkTrBt6I4Wj69mQ+Q27QoF 79BA== X-Forwarded-Encrypted: i=1; AJvYcCVaw9HxTts+dIjCm/AQbqx3El9ARffRDLjc9YHrJ9O5JUvRy5zYRe3Bjjg4LrD+CP+SooUn0CvtxNN4mnU=@vger.kernel.org X-Gm-Message-State: AOJu0YzIZYOq5HT6lBR7wtCinweX/ncQE5sPhiByYws/RpCCHr8HyViH z/+gKNLzkeRvjwbE2zJ6oM3h1m10TwKS64B09/ov0kTGf4jWLmiW3yFs X-Gm-Gg: ATEYQzwKrLZQCl/FJ3CvneBiYR1uL2cKeFf2bFmeahLSPH1x2HFk7IgPXHzpKI2vHVA A+Kd2CrttBHHEwH3QZn3GlJiSC6zem+GznDQWO+KaVsMAPNW+5R7+rlcMarmzMd4WtRkZ/klSlG motzdshVZHFLHTngWwy6gP29Ejf9DfYEpWY4iAOCeNpxMy02hDqW77sBxPMeaNWpowrjr4nFRAJ M2dfzPnaFmRbKnXR3a+rmQlPCwnDZs5B5fpuG2eTy1lTBz9lPDjl6J4OG7nnFL4sfj+/IKZuRAP WzumVq3fo0+fW7Ppy3gaFCWDAxdPfmk21KCPgs394eE87Ogtlit8B7L3RgY54OqU6tm7sNKbaz7 x1aAF7xroK5CdhNEjJW2GUb7ww0DSR9ELpNmotIUMoRZj3ALEEVKj3RzHj1vRlTVJx3xedvjM/L VLvsKRj1pN83hLPVPFOJdCVVfxqp11 X-Received: by 2002:a05:6000:a90:b0:439:881a:656c with SMTP id ffacd0b85a97d-439881a6686mr1398838f8f.6.1771928573385; Tue, 24 Feb 2026 02:22:53 -0800 (PST) Received: from fedora ([101.57.210.72]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d3ff6dsm27211843f8f.25.2026.02.24.02.22.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 02:22:53 -0800 (PST) From: =?UTF-8?q?Filippo=20Muscher=C3=A0?= To: jdelvare@suse.com, andi.shyti@kernel.org Cc: andriy.shevchenko@intel.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Filippo=20Muscher=C3=A0?= Subject: [PATCH] i2c: amd8111: Switch to pcim_enable_device() and pcim_request_region() Date: Tue, 24 Feb 2026 11:22:16 +0100 Message-ID: <20260224102216.17606-1-filippo.muschera@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Following the conversion to managed devm_* APIs, update the driver to use the PCI-specific managed APIs. Use pcim_enable_device() to properly enable the PCI device and pcim_request_region() to manage the I/O port region. Switching to pcim_enable_device() also addresses the fact that pci_disable_device() was missing in the driver lifecycle, as the managed API now automatically handles the disablement when the driver unbinds. Suggested-by: Andy Shevchenko Signed-off-by: Filippo Muscher=C3=A0 Acked-by: Andy Shevchenko --- drivers/i2c/busses/i2c-amd8111.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-amd8111.c b/drivers/i2c/busses/i2c-amd8= 111.c index dd9ac4bb6704..3e8f7a59df51 100644 --- a/drivers/i2c/busses/i2c-amd8111.c +++ b/drivers/i2c/busses/i2c-amd8111.c @@ -427,6 +427,10 @@ static int amd8111_probe(struct pci_dev *dev, const st= ruct pci_device_id *id) if (!(pci_resource_flags(dev, 0) & IORESOURCE_IO)) return -ENODEV; =20 + error =3D pcim_enable_device(dev); + if (error) + return error; + smbus =3D devm_kzalloc(&dev->dev, sizeof(struct amd_smbus), GFP_KERNEL); if (!smbus) return -ENOMEM; @@ -439,8 +443,9 @@ static int amd8111_probe(struct pci_dev *dev, const str= uct pci_device_id *id) if (error) return -ENODEV; =20 - if (!devm_request_region(&dev->dev, smbus->base, smbus->size, amd8111_dri= ver.name)) - return -EBUSY; + error =3D pcim_request_region(dev, 0, amd8111_driver.name); + if (error) + return error; =20 smbus->adapter.owner =3D THIS_MODULE; snprintf(smbus->adapter.name, sizeof(smbus->adapter.name), --=20 2.52.0