From nobody Thu Apr 2 23:56:58 2026 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8C892E1746 for ; Tue, 24 Feb 2026 06:25:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771914341; cv=none; b=bdPLCvzbufihTVUqSbYD1LvYKHyPv8bhXjOn+yx5rUEvNWc1xgaBJJmr+ro3i6nctxX7FTys/Oa7AkknWIEk5G9dnjscEGC/J/c1MhnrEx4MZ4ULXx64rCLYQSOZQ5TAPcGdwkHfTPZXv8GYnnaqi2tdVjVLIOVPc+64cn4q4JY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771914341; c=relaxed/simple; bh=gO5XKTbGTCNX9F2kGpffpU86Ne6W69soNa7yYuB8rEs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZLEiIKoeEt8jUBEzRCy1kN9XMs/nWffxXX1FuM2Hbmud9pkWTHQQHxCbK0XkQBjJgwfswFQPtRgND+AqYvDV+1O/FF6RQOozSYb2fHLPcLA3uW5ua9nIKAhskY+bV4kV3546sptsq+LAxhDdeaj+r8sYDFUuzfQvjE2HLY8XZ1E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hW5oWOGs; arc=none smtp.client-ip=209.85.210.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hW5oWOGs" Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-824adc96ad2so5163009b3a.3 for ; Mon, 23 Feb 2026 22:25:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771914340; x=1772519140; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HQ3C3N6ai9LWpoELJlhPWsjarYjJZBYa3nbCsM7NzMU=; b=hW5oWOGsq2okxAznLXCvFIpoCVRrsSOZ+nD0dMRX05M8hgXLvGDWK2hcgCD5+fcDLT QRYV1n2frM1S8q2QL8g66AQK7tHDM847/+FLdF0clRchsjqNEtxC+TXqaavLzejzxc3f cfXXht27EGtm9xj7Ce8dWXz4OHNfBRHZt3YoOzYA1ZmtpZwkV1okHMGYbdazGh6JxUli LS4wzxZvH8Idr/pcEcoZ7fuBueFPKeKz6qlKOP78xLHgwiaj+ald4xrhkIuBWauGrRm1 wmmJqRVN7qb5NoZZcrdAX8xPUVLiXHHpqeH70EWVcQoYjEmCEkCWcnfZbIK19FsWG+h/ 9wew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771914340; x=1772519140; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HQ3C3N6ai9LWpoELJlhPWsjarYjJZBYa3nbCsM7NzMU=; b=gfx5wBcgTUOqceWZinjOFpCVy7+h/RgBcA2DQUW2yN659wXMMxQ+3eowJRgKhPFhtX oL64sKx7ZCkTxLu7TsTbBz5bZsRaAdy6geDJ5xlcUCTEHfx4VpcLAF3C1wC9i6Z12Ul+ tw3oRkVG8zJucrinb00GwuGKROjIma8GXB3Ho9hqefWlF1bnpk7CQ+JDBCjnkCu6rjKq CEWf0pIdSuYZOE5hZlH6B0ZNmnUN4+JNV7sXI8n+34WucI/6vMaw0Ntbjv/v+IuGdwav vIkA43d51sNNRUBrBW2+N/lUIJWVzrtBQzAdYF5x30It5I6uG4TI+spSefRwHtK5k4ke itnA== X-Forwarded-Encrypted: i=1; AJvYcCV4IRH/pB6IykBCa5M8olTfn32nR0mQBpSQzVKX6KCzYOsdBj+2nS9q9NbsFtLj0wKRm/wyt90j4ORau6Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyWpGgah5/xnhM7dSes5nlRxai6LsN10S8mkmrPsD8HpTGvPmKf S/x8DmlN9AA3FuQwtGxfa6ktvupYukjWbsSqvEKdeq8KTTtr8PWbShRA X-Gm-Gg: ATEYQzyzkXqv4CYB6TlqmkwHMWByz6T6Uzc52D0VDpbzJ4e+mM6x/iCGWf5B6ORod97 TdB4UvOTsbBTU6oK9RHRWjhl64+VwP4w9WX0ebUjmBpfrr9CunYccnadsWrt/Nolkex1yH0AqO+ zoqpK2iY/f+6pP4pi4WaQJCZgp9XCPm1WtcLXMu3Fb0D0BthjI3WiI/oGl1LUVbtznlvCP6zZKs iPcP5ucKXUX4/gEhIzhmUjepku7mGbFnL8cN802xfiQjlgLXazKwJkSGGdeMWET63qaRaLOtYcg obnTmWDEv48lirlRx3wnzm0l5vMqdoKuHMd7bW2j3Ukkr054TyOD9CiQUu8fmvbHExY0VxFdiAC /D0+ksCR4TnX4dwG0WxTOFRXFAhCr9YMrHG4AuTBxQqyDKlCla6hyK7vCVlJDwsYwzr71ZlF58a LB7PGdrVpqDa9hJ2NofJMqvCYAiQLbiAcW2mSEfDpzY2rbpQ== X-Received: by 2002:a05:6a00:4b13:b0:823:c4dc:d20 with SMTP id d2e1a72fcca58-826daa1ffa8mr10623797b3a.53.1771914340145; Mon, 23 Feb 2026 22:25:40 -0800 (PST) Received: from localhost.localdomain ([202.161.55.15]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-826dd901b59sm8365244b3a.65.2026.02.23.22.25.36 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 23 Feb 2026 22:25:39 -0800 (PST) From: Yunbo Lyu X-Google-Original-From: Yunbo Lyu To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, richard.henderson@linaro.org, mattst88@gmail.com Cc: mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, julia.lawall@inria.fr, ratnadiraw@smu.edu.sg, xutong.ma@inria.fr, kexinsun@smail.nju.edu.cn, Yunbo Lyu Subject: [PATCH] alpha/perf: Clean up stale comments referencing old hw_perf_* APIs Date: Tue, 24 Feb 2026 14:25:31 +0800 Message-ID: <20260224062531.96304-1-yunbolyu@smu.edu.sg> X-Mailer: git-send-email 2.43.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Two outdated comments in arch/alpha/kernel/perf_event.c referred to functions from the deprecated hw_perf_* APIs that were removed more than a decade ago: 1. hw_perf_disable(): This was superseded by per-PMU disable APIs such as alpha_pmu_disable(), after commit 33696fc0d141 ("perf: Per PMU disable"). The comment has been updated to reflect the correct function name. 2. hw_perf_group_sched_in(): This function was removed in commit a13c3afd9b62 ("perf, sparc: Implement group scheduling transactional APIs"). The corresponding comment mentioning it has been removed. The if (n_ev =3D=3D 0) check in alpha_check_constraints() has also been removed, as this condition is never true. The alpha_check_constraints() function is only called from two places: - alpha_pmu_add(), which calls alpha_check_constraints() with n0 + 1, where n0 is the number of existing events (>=3D 0). - __hw_perf_event_init(), which calls it with n + 1, where n is the number of events in the group (>=3D 0). In both cases, the n_ev argument is guaranteed to be at least 1. Therefore, the check is redundant. No functional changes; comments and dead code cleanup. Fixes: 33696fc0d141 ("perf: Per PMU disable") Fixes: a13c3afd9b62 ("perf, sparc: Implement group scheduling transactional= APIs") Signed-off-by: Yunbo Lyu --- arch/alpha/kernel/perf_event.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/alpha/kernel/perf_event.c b/arch/alpha/kernel/perf_event.c index a3eaab094ece..2f57626ffcfb 100644 --- a/arch/alpha/kernel/perf_event.c +++ b/arch/alpha/kernel/perf_event.c @@ -35,7 +35,7 @@ struct cpu_hw_events { int enabled; /* Number of events scheduled; also number entries valid in arrays below.= */ int n_events; - /* Number events added since last hw_perf_disable(). */ + /* Number of events added since last alpha_pmu_disable(). */ int n_added; /* Events currently scheduled. */ struct perf_event *event[MAX_HWEVENTS]; @@ -372,10 +372,6 @@ static int alpha_check_constraints(struct perf_event *= *events, unsigned long *evtypes, int n_ev) { =20 - /* No HW events is possible from hw_perf_group_sched_in(). */ - if (n_ev =3D=3D 0) - return 0; - if (n_ev > alpha_pmu->num_pmcs) return -1; =20 --=20 2.25.1