From nobody Sun Apr 5 21:17:48 2026 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEB5D26A1B9 for ; Tue, 24 Feb 2026 04:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771907848; cv=none; b=uJ8iuT83dR9WQA24dR8KZXD4pIcctkLJb+bjkTgQoDWiejG+MjoQc+TNLA3F0x3talmntR2/ximpxYlluAKA3W71AAMdNjxLaroARYNLDyM8EKHay4eKXNc3n9L5lPk/OhgxVn/dlZONamkHsIr/fzs/T9NKfTf7XDz7dKe5Sg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771907848; c=relaxed/simple; bh=lYSFLw0xah4h/+68xrRS+X6hzYryo1L2cUiMAzxuTP8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MrPIlkxgamuyzr8eH3REZdALstTunUDaQINSORw/3idQaLKtTaErL635u5V1xI0mZmCplIUP0kgMNdS7qlsjcV1zzZV7Osamls5RFkBK3XboOLggBoCMupSER8VnGSM+Wl9uWdFKaB30rd0wuRMr5EiYfd+cfUZEiRcWr49TvzY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GycPR9M9; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GycPR9M9" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-65a40f3f048so9398966a12.3 for ; Mon, 23 Feb 2026 20:37:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771907845; x=1772512645; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GgYaJHOEUtfkRSeV4/ucyw2w3tzEF0ffgSH0n+B20gI=; b=GycPR9M9LZpTXgXP79xCyC/Ey5KNfI1Ymiy2obTJD7Up0W3qVEXZkvfxw17aI4T0p/ wBtr0H7IEdciMzvzjYXvvtaWaOw/Es2UKNfYWn05JwwYkPCoSrPs/CJHhRnaBwwLYBrG Z/nUkXOqlGweCHVq/d7bcPD49q6Y5P10jST3kWr+idrerr9ZPuzYFstBOAsqWW9xpVZB c15A5FQbjQUmfMHU3RALfytWaCpH+LS/gKsTVC95LMwNDiGnhQ+SynUH0386qNKRqMIh 5O8CEChp6bQP2Tt8fcpe4+HZO8KhNw+N/wP7GlkRYGXd0qtLdfwMEi3ZiyUltqjekbfm AoaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771907845; x=1772512645; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GgYaJHOEUtfkRSeV4/ucyw2w3tzEF0ffgSH0n+B20gI=; b=owOYTZ+c/H9wFiMTJi4urwm8nveUWALQieFAG7beIXGxg4OOrKc+wlN/SCaKp3FN/b 0jG2DLfDAy315xK0cjhH5CAePaHMM+DE1igHjzG0l3CCZt4sRfMdpsV7IyNOsBySJjnk lysojf6ikHFhRqEnbikYK/XDi3PIAyq12xTeZflRSpNc0sc2aNPCGsnBlJHxdcQjN+PO daiQqEAbkS3N6Td7WUxpE+sGsYlLnrOQB/IfKcW9cxRYcbX1lqz7HXSJXNuL/W3Aw+Gi 1tcZJa+UiPF0Wt2vQgR3GnIfagL6zCijVzqbX78gkrllHIkqkl36IMC3myEYBWZXk9yU M8Fw== X-Forwarded-Encrypted: i=1; AJvYcCUe7gU49LTM461q+qTxSOPTPH6LK5+/sIAHsxFyQef2TUcg0miKSTbtBVGFJZgusxo6Jh9a+SVNjPTBHmo=@vger.kernel.org X-Gm-Message-State: AOJu0YwvP0nZ+P0JPeBK9X36PJMStZOQ+R+t8sssR06h0CqIV1PR00i3 B/ZfF2ljYpviTm1shmM2ki1B06h1v+2GjbOI5+Wkdxdaj/Ywuge1AfJR X-Gm-Gg: ATEYQzz2W3z4LP8du07VDss3f0zF7aFzPfCXq9ax9IN/x9frbUXn2ZQrzWhL2ilH2+U 1FCRNdFT1/ZS2KP/ThWB5CMPWsny2apNDMUyU8T41IGFvSVKmj/QHq5KvYlxLNs0QXC6Q7wBD0T cY2xigXxushtJVCZSoiD00CHmGb3hRongGl/D1S+xUF2VNfDDzm013NJ5oQoC3IlB7rIa6lFypv KNo54/lnz7RoemoL0EYmKDVU8i4ttFfZhCEHylf8WKa6GqrXX9fRNiDo3Kin3w09NWOuXFQOK1U Xbylequ80lLERphMDnlo0xbsT1QegSJlTUKiefEkWlz9DpTlFyyqy/QLrloHbL9gOZcqO2jj0WR k9zC687BcbXsaxc+ujTGLuQu1BlwKREI2fN6KGjNfy8vwpQLbVLuP53XIomLKUx7fxSf2Oek7+Z UytnLoAT6hTW/YJFO5nUjVrW0Em2PDimE6SYf1wcIUvzsxRnA75En4w6H3AJhbI6UD2/4WBMe9y KZcpTrl62T+cCNfulY6S2rbHSG1AlPFMsuQezephyslLGaGguedNJgMTwQYFvdWGbhIuLYHTg== X-Received: by 2002:a05:6402:270a:b0:659:329a:bc12 with SMTP id 4fb4d7f45d1cf-65ea4f09947mr6418457a12.29.1771907845192; Mon, 23 Feb 2026 20:37:25 -0800 (PST) Received: from cs-874966990260-default.europe-west4-b.c.i2f7e30109524dc12-tp.internal (206.242.32.34.bc.googleusercontent.com. [34.32.242.206]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65eab9aae0csm3104205a12.10.2026.02.23.20.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 20:37:24 -0800 (PST) From: Artem Lytkin To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Artem Lytkin Subject: [PATCH v2 2/3] staging: most: dim2: use dev_err_probe and proper error codes for clock Date: Tue, 24 Feb 2026 04:37:22 +0000 Message-ID: <20260224043723.1828-3-iprintercanon@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260224043723.1828-1-iprintercanon@gmail.com> References: <20260216201921.1788-1-iprintercanon@gmail.com> <20260224043723.1828-1-iprintercanon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace hardcoded -EFAULT returns with dev_err_probe() and PTR_ERR() when devm_clk_get() fails in fsl_mx6_enable(). This ensures the correct error code is propagated (e.g. -EPROBE_DEFER for deferred probing) and avoids log noise during probe deferral. Signed-off-by: Artem Lytkin --- drivers/staging/most/dim2/dim2.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index cea1ba99caf7..e4c8b4995c61 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -921,10 +921,9 @@ static int fsl_mx6_enable(struct platform_device *pdev) int ret; =20 dev->clk =3D devm_clk_get(&pdev->dev, "mlb"); - if (IS_ERR(dev->clk)) { - dev_err(&pdev->dev, "unable to get mlb clock\n"); - return -EFAULT; - } + if (IS_ERR(dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk), + "unable to get mlb clock\n"); =20 ret =3D clk_prepare_enable(dev->clk); if (ret) { @@ -936,9 +935,9 @@ static int fsl_mx6_enable(struct platform_device *pdev) /* enable pll */ dev->clk_pll =3D devm_clk_get(&pdev->dev, "pll8_mlb"); if (IS_ERR(dev->clk_pll)) { - dev_err(&pdev->dev, "unable to get mlb pll clock\n"); clk_disable_unprepare(dev->clk); - return -EFAULT; + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk_pll), + "unable to get mlb pll clock\n"); } =20 writel(0x888, dev->io_base + 0x38); --=20 2.43.0