From nobody Fri Apr 3 10:24:46 2026 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EB5B261388 for ; Tue, 24 Feb 2026 02:42:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771900976; cv=none; b=KFBMbGtVJN+aKg6GCssjweTUdkMEKv//Xd9944JPkeNbM5EgY0n1c7HxsLmFQKORAbgPL6xjXaaiU8PVKtkXUK12aCgJA5ehPnQxBo9DVduHXa/4HO4R/qrwtCB+hB/QQzKZs/ZCM9VUUvbYXU86q/59ctFDCz+hcGlsOdsJzeQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771900976; c=relaxed/simple; bh=EYhiGLtvTzp511A5Pa5GOYQCk1w8ZLXU5f42CdA8dUI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QuYFIpN1uJkrCaq2+0i/PT2PuQZ3jENAw1gbuJSf8QxZ/T4dU2AgD/vrg4ZxTuyNxmEthxI5rTgDE3x6mh4vYel4Eao/kZOAazEJ6yQolKLEaFUkhy+sxwgJ0Knj82t0X8qlba8bM11Sd6G4VcLdWInfF6pAHTDt8J7oWW2R9S0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XG5jlPbd; arc=none smtp.client-ip=209.85.214.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XG5jlPbd" Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-2ad9f316d68so1159335ad.2 for ; Mon, 23 Feb 2026 18:42:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771900975; x=1772505775; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:reply-to:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=OZCYqHiGj9UPORqGQe3Ztw7akfpEtR2WEqhM5FGnZqY=; b=XG5jlPbdCEKgQBggWTEWbBXkhq9xJIeW7mDEM3tq3YTeHeBzVSiCNZz4W+rltV8uz8 g1xWRnXb9pKEVaWX8dIKq1U3ka/QdAMn5/NpRgqksIPKiikPyC9KFtDAtKnuPslEk6hG pzM4lNktf4kWHmxU7QaLXkrhB8NbIyJyF2q+nw0YCfjJ8mJtR2FYc6hD4pyq2pyPlEzc Wwi3ZK2n0bAwm+sc8h+rvjy1ryVNLQNIpcZTrldh4n2t9JUB7x+Wq9RgzTf2WOhSEygh 4L69490SaOkMCSeo1Su/Uu0GgFizhJrTeY+MGO+QsTcCv/L6mfbbkVl1d4KbCCnFwHSa DL4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771900975; x=1772505775; h=content-transfer-encoding:mime-version:reply-to:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=OZCYqHiGj9UPORqGQe3Ztw7akfpEtR2WEqhM5FGnZqY=; b=ht5gICT+Sr4tFpA0c8NOndTWI8uYr9vIViDO2G08/CnwYsN27XXzwDltP6NyZiO7qE 5OQMTc5OX5ocf1pvv+MV2cvV7AuxELVEwpK5oYUx4JIl9Trr7jaiCQ184LVF+RSADrec ZfSSnkRB42TehXKU6hpXGf40LgrMmKmeVK4AncdO3DGg6IBVwRhSmeYsmXqCimUz3EzN tAClOuUTn3+FFMj+Q8uWiMcv0u8BsGSmqYmoTxWuk6aKfULumpDOAX1oR/M+NJUV83qG rAOYfVBVe5j0jLSZyKdVCLLQmhjNMhxxdnkU8/NzP+49yCbADqIx70NWFI9JeWLI6HLj mMVw== X-Gm-Message-State: AOJu0YycbWZv3+Kop/qwdiWEnRz3ECeTmnw79YcBAX5bVXAk0JGjBl7l d8CJKZ1HqtbT+3Hw/aJ2eTC4mzzCNVEjyA/fK3xnxsGadiQVsa7b2XcHiCoSJRFw X-Gm-Gg: ATEYQzyvHO8kypl+W5tyrzcMxipk1PoaQipgDizqJ4lV9kQB+CnQ8ZN6iQa3jlDiV2+ nmK5o0kmCHrwp5l94UDyzhwh5cNN4V7uBtsIGG5YeCkzTPYFlzEYjG4w5397btD997MV9MBrit3 Wa5ezFMDJfkzt8xljKwGLdUiNRuju7BRMTcxZULulpQXz/OPYPcofz4ofcKcOR44esr/ENn8jt9 h12utUup9NrX4UduS9F6wDGf6RVSVPWUeUo0XjXsdlRAf0j9+UacQaoQ0XZEDlv27BGN3IQxI9S 1VgQo5FH2uJQbLsh4VU67QZylf6YQEAq01QeH1lTZ+qbT8LIrWVlfEs0XnQkzkZmcGpurfb9W9v YXQIp2gzL1y75XnyLg6SaOIW0GBKXAicfNwjhSYF1sAObZuJH2NTaCUo6+afWYIgxBVctNPr6q3 TuoSPrn2lnQWt4Kv2Cj2MYlwbyQGatluXmstzDsOzs9Kq4+t0= X-Received: by 2002:a17:903:1212:b0:295:99f0:6c66 with SMTP id d9443c01a7336-2ad744edbf3mr114852895ad.36.1771900974767; Mon, 23 Feb 2026 18:42:54 -0800 (PST) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.240]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad74f5e0f2sm88114295ad.31.2026.02.23.18.42.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 18:42:54 -0800 (PST) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: Frederic Weisbecker Cc: linux-kernel@vger.kernel.org, Zhan Xusheng Subject: [PATCH v4] timers/migration: Ensure proper resource cleanup on error in tmigr_init Date: Tue, 24 Feb 2026 10:42:41 +0800 Message-ID: <20260224024241.1995-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Free resources allocated by zalloc_cpumask_var and kcalloc on failure. Signed-off-by: Zhan Xusheng Reviewed-by: Frederic Weisbecker --- kernel/time/timer_migration.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.c index c1ed0d5e8de6..b6010790368c 100644 --- a/kernel/time/timer_migration.c +++ b/kernel/time/timer_migration.c @@ -2004,7 +2004,7 @@ static int __init tmigr_init(void) tmigr_level_list =3D kzalloc_objs(struct list_head, tmigr_hierarchy_levels); if (!tmigr_level_list) - goto err; + goto err_free_cpumask; =20 for (i =3D 0; i < tmigr_hierarchy_levels; i++) INIT_LIST_HEAD(&tmigr_level_list[i]); @@ -2017,15 +2017,24 @@ static int __init tmigr_init(void) ret =3D cpuhp_setup_state(CPUHP_TMIGR_PREPARE, "tmigr:prepare", tmigr_cpu_prepare, NULL); if (ret) - goto err; + goto err_free_level_list; =20 ret =3D cpuhp_setup_state(CPUHP_AP_TMIGR_ONLINE, "tmigr:online", tmigr_set_cpu_available, tmigr_clear_cpu_available); if (ret) - goto err; + goto err_remove_prepare_state; =20 return 0; =20 +err_remove_prepare_state: + cpuhp_remove_state(CPUHP_TMIGR_PREPARE); + +err_free_level_list: + kfree(tmigr_level_list); + +err_free_cpumask: + free_cpumask_var(tmigr_available_cpumask); + err: pr_err("Timer migration setup failed\n"); return ret; --=20 2.43.0