From nobody Sun Apr 5 21:27:07 2026 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C0802749DF for ; Tue, 24 Feb 2026 02:35:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771900536; cv=none; b=fDKpTeZxfFIg5gRyaivOY5C38ZgnuO5Ne9qW9gy/T5SSBmuSPl5ofbJvBb/p0oNLULDT7FusKZ9yv34Dk1miEbg2n+ey48qGj5rP3STgWE9Wd65tx1D0KMF490faLiKToJj0ET1ourvtrwJnkKHom7BTEVM8AcPeCqVmYyuYbBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771900536; c=relaxed/simple; bh=KUnaoDdsl8scQ/d6Iox00XXk6u382zdfvElDYxnQ6FQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=THUft9l+2muD9okbBblMskMe1pMPEGu5RXzUFo3XbKB8K+cOYnZFMBQYSSNQkmZiIfKGSOm5F2stZng4W7DFLEHP1JSGAHwHqYBFMtSt92pNiy6cXQci1SwlxuQseTtgq7qedl7YRv5ppe8b9i0IDTQKPJHZBTMlwQ0jwCspj3Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nmEA4bJe; arc=none smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nmEA4bJe" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-798527f822cso11698067b3.3 for ; Mon, 23 Feb 2026 18:35:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771900534; x=1772505334; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=syQrnKdSaSXvjiSlw6u25fzSgvyUrjxfjMVEd7QS078=; b=nmEA4bJeJ/arfUSzBIEiEwvTlUvp7TSzVQYzHrvvPolNeDy6WrGH3Xmqpd9viIwZTX 1zjMPPfv/9alOSisj0IDL2ZTNDh5blK6cXh44MzvbP5B1BGyAMFTt1C21OUKktBE0w1n ws3rkIDrpeVtXA579vcaPtFEYFPrd5MElp+JdncyeSn1PGZt3EO4UW379tD8047DtxGr rGudQJthsNCimdIZcFT/9jSW9gR32aThi7yFWvdBbCpNVLM5ME+R1/Xh0Hu4JvDD4YIk eC4KtGsdx4m9H5H9vh05g7xmjg3negfw/FvgwcaadWFpRAzIDW56bayC3Jr9eFKJD76n WakQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771900534; x=1772505334; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=syQrnKdSaSXvjiSlw6u25fzSgvyUrjxfjMVEd7QS078=; b=DPYTr+0Eslcpou5Ojo4lwU6c0zgpE1FUfX5Nd8eEs24gyzYvCmWU1i10ZGPPh33oWI 9CptLKHe/xFCX7qfzFyXzaIctZUoiQ2F9ueIMlcNmK4W6N08MsIrYGT5ucEXV9rm8etv 8pPPx2JeQliGbxrE3llJWeDPk4wynGdNBC6gPGJHkCp4ennPRRparOqpB5+Ys6P6sFMA TnNO63sRu/bYP0bASrs1q+8SIw5gBUY4KLINGVo87S/Lh9ooqd0JBkSXKZLoleFuPmnd qZ+uSZJVs1PUanWeNlInntsMMaXdhc0PZMOQIpNeM3a0bk05DDvF+bFvpm1bXiYA5GLv Ybmw== X-Forwarded-Encrypted: i=1; AJvYcCUNqiEKDP9iCFnowF6yPh9FGq+JXV19kuWimBH94L5gnqSzdmMs6tlIuMF1D3DZ3f3EMne0Q4beQ4Mpo1g=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3rYfawY5jtchHvRHJ5ITJLDWN3u9+KdH8G/XS4uFIG8Wqcw1o Pk+00hqBEgb8oyKrEPzOJERKTSqIprplsngEXh28RotIvYHbzC5A7Rlh X-Gm-Gg: ATEYQzycSXsLVj6oPD4yLBqrIIpy/uJWJHGCr9C+4AXj5kpPLkjo7GjsbeAspjDqaz+ vBQTKALkTQICpk2hAf9tuM6G43Pfk2SdVgzGxu1aDh8ox9N4hyEAtTACHHrJxHjGrDIOBHJQifA ngIw+HQX/3HGzvwmewBYq64bN6pRVdl7SHvZsZLZQYuWDot2e/HoMdecLra+0/VoOQx05MsPZhX 84yQStfpKM0263plkbfCtZSYIYKafIW1pG75Fd48Ud3Xpq/jKJT9n6+HW5wkjTvK8ILRR4Z2k5H k14VLKcPdTLKpr6GRRIonXwkPcMVHklyC6Ob4OlGYvH1AWtl0l/COpV+WXDllZXtCXbk3iZKeO/ ckHjGT6NIIu4dh4EOlmsPbankkh5yNrgdRMZ8+zEQvPYpnXIkB2fY57jcapG9AlplZHVyY2Ft2s eaecyjVix9CTuaGEKU1ab4aLrNDVIJZlrDHN7vm055Qvy+3TpLZE7bl8xrIcXF8fvDqf0EUlgbM JqNhBbz2c+iKocpNXRPSYM2iA8ab8LHM7Y= X-Received: by 2002:a05:690c:46c6:b0:794:7e1e:7f8d with SMTP id 00721157ae682-79828f18314mr88008657b3.18.1771900534476; Mon, 23 Feb 2026 18:35:34 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7982d985074sm39585407b3.0.2026.02.23.18.35.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 18:35:34 -0800 (PST) From: Ethan Tidmore To: Linus Walleij , Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 4/4] iio: gyro: mpu3050: Fix out-of-sequence free_irq() Date: Mon, 23 Feb 2026 20:35:11 -0600 Message-ID: <20260224023511.274038-5-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260224023511.274038-1-ethantidmore06@gmail.com> References: <20260224023511.274038-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function free_irq() is placed after iio_triggered_buffer_cleanup() which breaks LIFO because the IRQ was setup after iio_triggered_buffer_setup(). Place free_irq() in correct location. Fixes: 3904b28efb2c7 ("iio: gyro: Add driver for the MPU-3050 gyroscope") Suggested-by: Jonathan Cameron Signed-off-by: Ethan Tidmore Reviewed-by: Linus Walleij --- drivers/iio/gyro/mpu3050-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-cor= e.c index 73dc7ea1f075..3517522e3a51 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -1271,9 +1271,9 @@ void mpu3050_common_remove(struct device *dev) pm_runtime_get_sync(dev); pm_runtime_put_noidle(dev); pm_runtime_disable(dev); - iio_triggered_buffer_cleanup(indio_dev); if (mpu3050->irq) free_irq(mpu3050->irq, mpu3050->trig); + iio_triggered_buffer_cleanup(indio_dev); mpu3050_power_down(mpu3050); } =20 --=20 2.53.0