From nobody Sun Apr 5 21:14:43 2026 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB8011DDA24 for ; Tue, 24 Feb 2026 02:35:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771900533; cv=none; b=p8I9iNz049dU5mVzCYAyExr/1ctqMdDTajqh3bBbTuHdZih/b/jRNNseyo0LV+aTbNm20fH41IcDMG8h+W7zKj5nH/DI+i1wWwtQ1KWjtHs4bqp2nSVnF2YPhunVZRU9Zs49tjF0GMNvInleY+oFStPC8HO+gCOFerv3MnCQvdA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771900533; c=relaxed/simple; bh=sUUTc4p7Q7MAk0TuxPkh3WHIjMo9QRDZGHXqzu1O01c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=f+fsykWhPyu24hkCHCDXiPOycK8El/7olYoWqOYaaW9hMz6pM2IZVV2BafSYdiuFC28FblOo42eDPWO06te81Pj14xVsw0igvfBwMIyUf+whdtGvh+Pg0B70LGZH2DSbqcXQC7eO6uiJW7A0HneLSteZVqxmRjriKtB+uDAcxR0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AAJGrccW; arc=none smtp.client-ip=209.85.128.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AAJGrccW" Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-793fdbb8d3aso42162017b3.3 for ; Mon, 23 Feb 2026 18:35:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771900532; x=1772505332; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iusn9u4xQvFJzEMelWbMLj7LoP4DkYbFjiqTDekST5o=; b=AAJGrccW6VcC//BwO6jckPpRLhhcDVA96MghbutJxCNLfI4fOtLuIVSMCOUT9udrH3 KC2C7NP9SK15ol5ugtyTuxczDkn0G5OxPCIvrzn4BfV/EBN0mYlCMaZqOjiHEOQxuPJh ot0Qj/CwezWQLycDzUyWoNtqFeQMTZ72MB6WrNnPrZB+liW2ATU6yzGthBWTlSaxmddV I3t1KaZ942XDURuSU7+QSaiyWk0EufEe3+ahdLPAG7EJf7vnIOgtAwVK2gTlZNYHAw2s ja5C1pYiDi4EIH9b+BAr804z3Z7oF2hM0PzRWLekl2aCXTtYnz2NfizXxub/hYCcfPf5 SQVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771900532; x=1772505332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iusn9u4xQvFJzEMelWbMLj7LoP4DkYbFjiqTDekST5o=; b=L8ZB9gD/EktExMIY+GC1XJArbqQORvFTikxZzppvj5hJle9agaU4cQf9SmSx619awW xEP9PEBx/LHN2zICUVfgublyOWkaNCsNRztVXzRpTps8W4oQRxkIKDZmwkrJ+YchIALn yMHTpJv2U/G9g09CtFPl2Up3p9hyxdAGEu7XWbRvCR6/FP7oyTMqMKEDP7zambgfenwc Xi1l5LX80WtvwiJ9WjkAB38rDr+qdx1Y3S+87MyvX1O+FH+ZoV9JgHNmUM40XXd26K1k 0TdNX5lDlLBSreriJkx+LsIHgpKAfjeyu+JV7lPUTgoel3juYzB09YP2TIaAuq8CuXcQ G9kw== X-Forwarded-Encrypted: i=1; AJvYcCWzsctN3IVu+ZjIJ+f6e2+Q4meHR5O0+UhyfaajE4FOav9cqcW2dBGORxlb//i41njKO5UWUYcY4c/oOiw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxl/HnRUcQZXvcohOErSkDV4lAo7GrybI/tv6ZORT+2tux1nHd9 9SxF+blmu6z9rfmh+RM3ml9WdPHTY+NdxK1LwpgOhftKtnIq5JRL3c48 X-Gm-Gg: ATEYQzz/CPNwAd7V2+PMi5DEIEusoKbg2Wuk7NUcDGVhzUxwawrFTYNroVVabWHNkBI KiNas0Zkiq9RgUxIAm4xKJefHwdCu+5txYzsBXeSM4NIgg1Nl71U0PNvs4VXIiIRw1ejHvlf3J5 UUm/pgggP2BDLKS+dMe0xBknWHiN+RZAky51+TmG57bOOC8Xf1jci1GP36M4YjIBQkXpzlu1owK gmxdsamf0ywR2J4uF7URleEW7MH8HxkIPCnEhdiC2idWiyekRqF3PDmEY5b/mbSK3WfIKF26Q+3 usRKPagYLk30AkQQyk9/MB43fVxOKN590gEAcHMOH4bUjoXU8dU3iIj1u3gTCqRu871j5KacY/V 7xIFS3H6vV/QWiWI2lJssX7vc1FbepEbPvGnU5AsgYPO5YxVe/w0aLZqoyOOMElgbgA4D9IHKD+ Fn1e2P/VEUrLXrG1+64z4c8ikIydQI8IZkv1ae8acJxstLfCBkCGsF2nJXKa+OnMgkKANWmYfqI ts4rc7um/yLvOpRyD2h+7BY X-Received: by 2002:a05:690c:e3ee:b0:794:ea75:4856 with SMTP id 00721157ae682-79828f36062mr94265277b3.23.1771900531787; Mon, 23 Feb 2026 18:35:31 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7982d985074sm39585407b3.0.2026.02.23.18.35.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 18:35:31 -0800 (PST) From: Ethan Tidmore To: Linus Walleij , Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 1/4] iio: gyro: mpu3050: Fix incorrect free_irq() variable Date: Mon, 23 Feb 2026 20:35:08 -0600 Message-ID: <20260224023511.274038-2-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260224023511.274038-1-ethantidmore06@gmail.com> References: <20260224023511.274038-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The handler for the IRQ part of this driver is mpu3050->trig but, in the teardown free_irq() is called with handler mpu3050: ret =3D request_threaded_irq(irq, mpu3050_irq_handler, mpu3050_irq_thread, irq_trig, mpu3050->trig->name, mpu3050->trig); ... void mpu3050_common_remove(struct device *dev) { ... if (mpu3050->irq) free_irq(mpu3050->irq, mpu3050); iio_device_unregister(indio_dev); mpu3050_power_down(mpu3050); } Use correct IRQ handler when calling free_irq(). Fixes: 3904b28efb2c7 ("iio: gyro: Add driver for the MPU-3050 gyroscope") Signed-off-by: Ethan Tidmore Reviewed-by: Linus Walleij --- drivers/iio/gyro/mpu3050-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-cor= e.c index ee2fcd20545d..06162d886b59 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -1261,7 +1261,7 @@ void mpu3050_common_remove(struct device *dev) pm_runtime_disable(dev); iio_triggered_buffer_cleanup(indio_dev); if (mpu3050->irq) - free_irq(mpu3050->irq, mpu3050); + free_irq(mpu3050->irq, mpu3050->trig); iio_device_unregister(indio_dev); mpu3050_power_down(mpu3050); } --=20 2.53.0