From nobody Sun Apr 5 21:27:06 2026 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBD16248873 for ; Tue, 24 Feb 2026 01:32:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771896750; cv=none; b=hi88GiSnA/FkSKGwCqoVN/1/IrLJeorxQ8hIEvW6dIr4yydhjBHwfSz7eWeoQ8Hkclc3Wy3W+EMupuc8lFRJdIIvd3B56+nbCwz01VwlVRAq3OH3XciMHjJr7Ozb9cBMwzNg7A1GwzgFOI0IMjLEfFeZbG1mze0cdkA3mx0I/ho= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771896750; c=relaxed/simple; bh=1CNVNi4J+0O83KvSLd7KcKe12vlxAT8zLXasG/sLHsk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eUJVDL8ZmUvx1OKFcmTw69oBmMirPawHIeNwBhJZNIqW0RqbLpS5fvd8Fx07TO4anYj0ZzearJdl+EFgOG7j8LwtgRGEOibcqTFlMGUpP0/CrhkLhlLsHtOijozc8JJC8e0IMhd3Tjfft0Yw/fQykKXLqwOmyRijR1zBnDj1ErI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XXGofoJ6; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XXGofoJ6" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-2baa098ffc6so4439427eec.0 for ; Mon, 23 Feb 2026 17:32:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771896748; x=1772501548; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qInaGkxxpA+nK4JOeZoash6/W7qtdW193EDqbn6n7Jo=; b=XXGofoJ6kBi+al4qFyM8RKKOUu46L0nH87+DzMP9l3O1RuXIxFHzdTn5XOQ6REO0n0 s6yy1AhRd5KwD1Ts6Q1EPUyzbrU7mHjjKWrtz4kgBBjOJf0GN9GuPJ8obD4/4Uz9Vy1u L8V5Ybm3ylGShJgoEMgtatNXd+1w9HZysDISd9rwPz1ontqe9AjF0WoQYF2bMWqchv74 xDjmouVnpeHtbSRgRQsZuVZ3l5/1o0PStninK9kj5l3bwFkVMU3yg279sEfuvJ+uz3tc B0toPcuSBBAcqnuIq/3oYzejR7TWIHCn3IAb1j1ohSB5/rCs8y1t7lY0+NLHOFVidcF5 qTBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771896748; x=1772501548; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qInaGkxxpA+nK4JOeZoash6/W7qtdW193EDqbn6n7Jo=; b=neE1tSMdrISaCsGMXa4+UWljCj4r2VbVR0HBxqfhMlIFQozx/gZxjfZPKJzs4CZzDL Rx5/7gKv3Ie9POyv9STXt+cOQIer7X4AOfHPyJA9bk2RTkXdtBMSrz7xF72uzyfdCKc4 qll0bEuGm4g4y/a5Ft3141KEWXFpHlQ0lsXmbzj0nID+hloJs0bVOXePm+McXsN2ivqZ B7h0pqi67EPfmh6rSQWF0eQ2YCWJChGdzpcGArda3HE7q1HZezstyOZIrAxzv8KKk1Id XZImpXyhhxGUaaY4lFzsqIDlU4YYNBMFLQ8dV2hdSKblLFCxd/MpNQdPVPsEPFHz0iOL QVsA== X-Forwarded-Encrypted: i=1; AJvYcCXKjWRpxL1JuEiX6OrXJO4t6FnbEZwKzDSJmxbn07T1YamtEOkV/nIiMu4LlZZ4O7EC7Un076b1Xdlq1wI=@vger.kernel.org X-Gm-Message-State: AOJu0YzAvjO943nkbq380Q8ipqfTpnoHJBBRV5Vrlm5+cnOIgjHRPAYn YpfdazBhmDTnmKxtxf888IQIboyqv8a/dagbePrxD/jY5W6T0u5T7AnN X-Gm-Gg: ATEYQzz/mVUaiECtN+sqeGzCQrSBw7PKA9zhAPWmZzMPO2MF6WLjD3SUIZUKrVNiUgA /N3Dxru4GVraIgPn3vVXoyCIm94FJrBc/A1z0M23IHcWp4K79oD82OXOUBEfTUPbyGbFqNEgbYm dddBWqnYr/03oh7fBwlWA7Tvv/k2S5GNvpr/Gsf+dQOzN3ukWAK3mDjeQ44AD5IwWNmenZMrpTv iKYb7kDfoWHYxUA3pFWxU9D2ehE+5l3yHZUvCwvZ0xupzNRBoXdM+tcIZw26Qdb48o0lM6MNcWP HxrBcqaTo1zBv49cxdwALhK5ah1O0cEarrIllxRj5yxErtqEC9Y5v/ogQo35dcgQya6CDPt3ELJ uKs9Hb7QPbHB70pxjlAl1Dp+0ObwXxgIx0Qq4E4E+18tMkYeSzOGqtWasXX9CFa4SwFBuhWDiSc 7qGDrTOXZX0GcxyyDaWsXZyvUvSpP9cd7TaER7UoF/sfZbWwbjCzTiGQjiczz0SxchtTnBIVloM V2rok2NSP+SIg== X-Received: by 2002:a05:7300:7491:b0:2b7:b7e7:9025 with SMTP id 5a478bee46e88-2bd7bd53d13mr3994025eec.31.1771896748208; Mon, 23 Feb 2026 17:32:28 -0800 (PST) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bd7daa027fsm6485015eec.9.2026.02.23.17.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 17:32:27 -0800 (PST) From: "Derek J. Clark" To: Jiri Kosina , Benjamin Tissoires Cc: Richard Hughes , Mario Limonciello , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Derek J . Clark" , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 08/16] HID: hid-lenovo-go: Add OS Mode Toggle Date: Tue, 24 Feb 2026 01:32:09 +0000 Message-ID: <20260224013217.1363996-9-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260224013217.1363996-1-derekjohn.clark@gmail.com> References: <20260224013217.1363996-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds OS Mode toggle, who's primary function is to change the built-in functional chords to use the right handle legion button instead of the left handle legion button as the mode shift key. Reviewed-by: Mark Pearson Signed-off-by: Derek J. Clark --- v5: - Remove reset_resume as it doesn't run, the device disconnects are reconnects during suspend. Udev or userspace will reset os_mode after resume. v3: - Fix collision with os_mode_index attribute and os_mode_index enum. --- drivers/hid/hid-lenovo-go.c | 101 ++++++++++++++++++++++++++++++++++++ 1 file changed, 101 insertions(+) diff --git a/drivers/hid/hid-lenovo-go.c b/drivers/hid/hid-lenovo-go.c index cd613d5ca37f7..6972d13802e20 100644 --- a/drivers/hid/hid-lenovo-go.c +++ b/drivers/hid/hid-lenovo-go.c @@ -76,6 +76,7 @@ struct hid_go_cfg { u32 mcu_version_product; u32 mcu_version_protocol; u32 mouse_dpi; + u8 os_mode; u8 rgb_effect; u8 rgb_en; u8 rgb_mode; @@ -166,6 +167,8 @@ enum feature_status_index { FEATURE_GAMEPAD_MODE =3D 0x0e, }; =20 +#define FEATURE_OS_MODE 0x69 + enum fps_switch_status_index { FPS_STATUS_UNKNOWN, GAMEPAD, @@ -311,6 +314,23 @@ enum device_status_index { GET_HOTKEY_TRIGG_STATUS, }; =20 +enum os_mode_cfg_index { + SET_OS_MODE =3D 0x09, + GET_OS_MODE, +}; + +enum os_mode_type_index { + OS_UNKNOWN, + WINDOWS, + LINUX, +}; + +static const char *const os_mode_text[] =3D { + [OS_UNKNOWN] =3D "unknown", + [WINDOWS] =3D "windows", + [LINUX] =3D "linux", +}; + static int hid_go_version_event(struct command_report *cmd_rep) { switch (cmd_rep->sub_cmd) { @@ -593,6 +613,21 @@ static int hid_go_device_status_event(struct command_r= eport *cmd_rep) } } =20 +static int hid_go_os_mode_cfg_event(struct command_report *cmd_rep) +{ + switch (cmd_rep->sub_cmd) { + case SET_OS_MODE: + if (cmd_rep->data[0] !=3D 1) + return -EIO; + return 0; + case GET_OS_MODE: + drvdata.os_mode =3D cmd_rep->data[0]; + return 0; + default: + return -EINVAL; + }; +} + static int hid_go_set_event_return(struct command_report *cmd_rep) { if (cmd_rep->data[0] !=3D 0) @@ -666,6 +701,9 @@ static int hid_go_raw_event(struct hid_device *hdev, st= ruct hid_report *report, break; }; break; + case OS_MODE_DATA: + ret =3D hid_go_os_mode_cfg_event(cmd_rep); + break; default: goto passthrough; }; @@ -1343,6 +1381,64 @@ static ssize_t calibrate_config_options(struct devic= e *dev, return count; } =20 +static ssize_t os_mode_store(struct device *dev, struct device_attribute *= attr, + const char *buf, size_t count) +{ + size_t size =3D 1; + int ret; + u8 val; + + ret =3D sysfs_match_string(os_mode_text, buf); + if (ret <=3D 0) + return ret; + + val =3D ret; + ret =3D mcu_property_out(drvdata.hdev, OS_MODE_DATA, FEATURE_OS_MODE, + SET_OS_MODE, USB_MCU, &val, size); + if (ret < 0) + return ret; + + drvdata.os_mode =3D val; + + return count; +} + +static ssize_t os_mode_show(struct device *dev, struct device_attribute *a= ttr, + char *buf) +{ + ssize_t count =3D 0; + int ret; + u8 i; + + ret =3D mcu_property_out(drvdata.hdev, OS_MODE_DATA, FEATURE_OS_MODE, + GET_OS_MODE, USB_MCU, 0, 0); + if (ret) + return ret; + + i =3D drvdata.os_mode; + if (i >=3D ARRAY_SIZE(os_mode_text)) + return -EINVAL; + + count =3D sysfs_emit(buf, "%s\n", os_mode_text[i]); + + return count; +} + +static ssize_t os_mode_index_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + ssize_t count =3D 0; + unsigned int i; + + for (i =3D 1; i < ARRAY_SIZE(os_mode_text); i++) + count +=3D sysfs_emit_at(buf, count, "%s ", os_mode_text[i]); + + if (count) + buf[count - 1] =3D '\n'; + + return count; +} + static int rgb_cfg_call(struct hid_device *hdev, enum mcu_command_index cm= d, enum rgb_config_index index, u8 *val, size_t size) { @@ -1709,6 +1805,9 @@ static DEVICE_ATTR_RO_NAMED(gamepad_rumble_intensity_= index, static DEVICE_ATTR_RW(fps_mode_dpi); static DEVICE_ATTR_RO(fps_mode_dpi_index); =20 +static DEVICE_ATTR_RW(os_mode); +static DEVICE_ATTR_RO(os_mode_index); + static struct attribute *mcu_attrs[] =3D { &dev_attr_fps_mode_dpi.attr, &dev_attr_fps_mode_dpi_index.attr, @@ -1717,6 +1816,8 @@ static struct attribute *mcu_attrs[] =3D { &dev_attr_gamepad_mode_index.attr, &dev_attr_gamepad_rumble_intensity.attr, &dev_attr_gamepad_rumble_intensity_index.attr, + &dev_attr_os_mode.attr, + &dev_attr_os_mode_index.attr, &dev_attr_reset_mcu.attr, &dev_attr_version_firmware_mcu.attr, &dev_attr_version_gen_mcu.attr, --=20 2.52.0