From nobody Sun Apr 5 21:27:37 2026 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E53823815B for ; Tue, 24 Feb 2026 01:32:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771896749; cv=none; b=jWbdLr4okf0sLpM7oS6t48K6P0nG0/50MqK9WFxuQGj1PrP/c+kKFBx+SyJbIyfFY8GyPSqpmuSpTykRmaXqP7ArzrUIE0AO68dP9NGIFAoLLYqok7AdsO8N4VxIatzRJhOkfBk0jl8UF/58k9qCMimns8WqmAqR5/3xvmahwUI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771896749; c=relaxed/simple; bh=ATNJNmccJYjd+WVFxvznzamAtvzQQivTOk7WMu1MxJU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JFKnqHXs2pkUzQnQ9kD6dN09JGB41JbXVLlbLDKlT7iirM8at+3ZxKSNkrrne05rEBLB7nZ3tR1F1N1zswzUyltFO5zk0e19fzs2MYagpUF/538cbv9NzW1R+9rqv393tq1PPdBkYkJUn/IIqIQRU8ykatA5Zj63DVY8SAYF+FA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lnVAQjEH; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lnVAQjEH" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-2ba9c484e5eso4960569eec.1 for ; Mon, 23 Feb 2026 17:32:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771896746; x=1772501546; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XEDyZkjpzItJcb6qI2X2fLtF0uiCTdOkpgguGZujnlA=; b=lnVAQjEHBYw/NxiWDxbJA9c/wE11bRjMfJArz1BmVc3iROy/GpfUSI40QqZDi3AilE RSkdaa7MiWjYWjUxWL54zpgt+4bGyr0int2tDbdOzfCdhm5XisiC19EaauPAoEAGVKP8 k+H9Y/Uc7BtwqGpkcQdo1xHXFQsanzwHZXqIBsGy9eizbxYOzOFqDA8uic6UFGz4EOCS NVm0IKupTCZAzL3yD7Sw6+Z4MG/vbFOBy/PPdA1YwvnKV2xOtjnAGWwrfXqPxwiHExvO ImZZk0JweXEQftp6Qy8uKoDCbGU4YmJ/fereV9UIma6SmPfuUd9b8Y2x+oDx9aOaeyg6 BXVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771896746; x=1772501546; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XEDyZkjpzItJcb6qI2X2fLtF0uiCTdOkpgguGZujnlA=; b=ehqMoYhOSzb4d5wDSyNIO6Y7WyO/rTDasvy7AR5GqdNvngIS+cAuYyJHA+Ph7lASrW a+2tTDCsHLN0/KBivXosaSwf2WCwcmoCc5kbyc91GS7ER3V0U6PpwmHzkL0DxJ3qkNss cYxl+w2oH9V5K8DTkASD2sdOLqJsbAhIkKrbYYqDf6bZ3j2UdqCTX6d2pr6l33usvYQ4 lwx0rDZmyvTr4m1SCK22T9mfQFd4fG87Pb/oPYmdHsDG8ZQo54m2AN/P40ZtPpp7MuaJ g1d+7QGrrIrwF3JGp1ZjWjcMxvTb0fujG1TwzpzgnJkjtcUHlX/AKNAyCMQmuXoxVkyU oeew== X-Forwarded-Encrypted: i=1; AJvYcCVkpJOqAXZge873AJaygdUgAXMYxU7Wc+kEX72FzEyfqc9iRNrFZkHn0D0x/j9i0SeMuBj4IqIJfTzpF/M=@vger.kernel.org X-Gm-Message-State: AOJu0YypPdsJ+z8J8iDnZdfoxsGRbp2rhbUPCtEn05JGUtP1lXhor11Y apslPR6VDaaJwfC6VvgTTtc1sD9x3hGlH4lzOvO/uu9S6keCScQsk9I7 X-Gm-Gg: ATEYQzzwB6MMLlufVnx3E9tX3f+eY3LjOIlred6sDjPr06Wppq41tMPuUS1qxHsrLpA qFvDIgNRlMTWCsV4NxQGRDqt/ykPsi5hGf7x7P/Rpk4YzHOwL1rvXztVW9mCvAUMfWArlVnpnQv yS9mGmI6Cu2CTW4RYXX0jhGJzsf+Q3WzPQEA07FYdbrvMCgx5OBDShTEqfXO82k2Xu62snnK96W yZdI2/pbdZnHAze2vd+yM0XI82FutLO0/I7G6PR876kO8nnpU/61mPI4F2Qkf/lPTDHFr9zsvLD H/JT4DaRbTOHvEKMtfbZtW3dwh48pC7KW0qVtZ6wGLpQUmxku0X/BZ/KeHl9BRH5ixq3NrH6N51 Fri5h7viFX+ieXSnGEeGuNpXieGW6W6cACITaG2Yv8KYhuiDTdYSDQupfkYkRiW+VnCyNFvLk81 fFgeH7RAKRas2JoYYteQD68nPapyupfYMFC0lgU9+8ugUuPsUa03Xo4hO0WFCwyj0atzDimldrf j/SEnQKJTGPQQ== X-Received: by 2002:a05:693c:3118:b0:2b8:31e5:918 with SMTP id 5a478bee46e88-2bd7bd4c5c3mr3394812eec.37.1771896745702; Mon, 23 Feb 2026 17:32:25 -0800 (PST) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bd7daa027fsm6485015eec.9.2026.02.23.17.32.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 17:32:25 -0800 (PST) From: "Derek J. Clark" To: Jiri Kosina , Benjamin Tissoires Cc: Richard Hughes , Mario Limonciello , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Derek J . Clark" , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 05/16] HID: hid-lenovo-go: Add FPS Mode DPI settings Date: Tue, 24 Feb 2026 01:32:06 +0000 Message-ID: <20260224013217.1363996-6-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260224013217.1363996-1-derekjohn.clark@gmail.com> References: <20260224013217.1363996-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds attribute that enables selection of the DPI of the optical sensor when the right handle toggle is set to FPS mode. Reviewed-by: Mark Pearson Signed-off-by: Derek J. Clark --- drivers/hid/hid-lenovo-go.c | 68 +++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/drivers/hid/hid-lenovo-go.c b/drivers/hid/hid-lenovo-go.c index 4581a1134d1db..4553dfd930c89 100644 --- a/drivers/hid/hid-lenovo-go.c +++ b/drivers/hid/hid-lenovo-go.c @@ -67,6 +67,7 @@ struct hid_go_cfg { u32 mcu_version_hardware; u32 mcu_version_product; u32 mcu_version_protocol; + u32 mouse_dpi; u8 rgb_en; u8 tp_en; u8 tp_vibration_en; @@ -220,6 +221,8 @@ static const char *const rumble_mode_text[] =3D { [RUMBLE_MODE_RPG] =3D "rpg", }; =20 +#define FPS_MODE_DPI 0x02 + static int hid_go_version_event(struct command_report *cmd_rep) { switch (cmd_rep->sub_cmd) { @@ -427,6 +430,16 @@ static int hid_go_motor_event(struct command_report *c= md_rep) return -EINVAL; } =20 +static int hid_go_fps_dpi_event(struct command_report *cmd_rep) +{ + if (cmd_rep->sub_cmd !=3D FPS_MODE_DPI) + return -EINVAL; + + drvdata.mouse_dpi =3D get_unaligned_le32(cmd_rep->data); + + return 0; +} + static int hid_go_set_event_return(struct command_report *cmd_rep) { if (cmd_rep->data[0] !=3D 0) @@ -477,8 +490,12 @@ static int hid_go_raw_event(struct hid_device *hdev, s= truct hid_report *report, case GET_MOTOR_CFG: ret =3D hid_go_motor_event(cmd_rep); break; + case GET_DPI_CFG: + ret =3D hid_go_fps_dpi_event(cmd_rep); + break; case SET_FEATURE_STATUS: case SET_MOTOR_CFG: + case SET_DPI_CFG: ret =3D hid_go_set_event_return(cmd_rep); break; default: @@ -1016,6 +1033,52 @@ static ssize_t motor_config_options(struct device *d= ev, return count; } =20 +static ssize_t fps_mode_dpi_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) + +{ + size_t size =3D 4; + u32 value; + u8 val[4]; + int ret; + + ret =3D kstrtou32(buf, 10, &value); + if (ret) + return ret; + + if (value !=3D 500 && value !=3D 800 && value !=3D 1200 && value !=3D 180= 0) + return -EINVAL; + + put_unaligned_le32(value, val); + + ret =3D mcu_property_out(drvdata.hdev, MCU_CONFIG_DATA, SET_DPI_CFG, + FPS_MODE_DPI, UNSPECIFIED, val, size); + if (ret < 0) + return ret; + + return count; +} + +static ssize_t fps_mode_dpi_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + int ret; + + ret =3D mcu_property_out(drvdata.hdev, MCU_CONFIG_DATA, GET_DPI_CFG, + FPS_MODE_DPI, UNSPECIFIED, 0, 0); + if (ret < 0) + return ret; + + return sysfs_emit(buf, "%u\n", drvdata.mouse_dpi); +} + +static ssize_t fps_mode_dpi_index_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + return sysfs_emit(buf, "500 800 1200 1800\n"); +} + #define LEGO_DEVICE_ATTR_RW(_name, _attrname, _dtype, _rtype, _group) = \ static ssize_t _name##_store(struct device *dev, \ struct device_attribute *attr, \ @@ -1087,7 +1150,12 @@ LEGO_DEVICE_ATTR_RW(gamepad_rumble_intensity, "rumbl= e_intensity", UNSPECIFIED, static DEVICE_ATTR_RO_NAMED(gamepad_rumble_intensity_index, "rumble_intensity_index"); =20 +static DEVICE_ATTR_RW(fps_mode_dpi); +static DEVICE_ATTR_RO(fps_mode_dpi_index); + static struct attribute *mcu_attrs[] =3D { + &dev_attr_fps_mode_dpi.attr, + &dev_attr_fps_mode_dpi_index.attr, &dev_attr_fps_switch_status.attr, &dev_attr_gamepad_mode.attr, &dev_attr_gamepad_mode_index.attr, --=20 2.52.0