From nobody Sun Apr 5 21:27:06 2026 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 951F623817E for ; Tue, 24 Feb 2026 01:32:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771896745; cv=none; b=kM4I3ggokhWxQiUlgvE++tfskLII261wyrTizlGNU2LsqcmBo8GG2wloGAqJxeIWWsxkcru5LIH3kk4tyGJREkowtwpU2D1ghKCeMlHpG1mLcSKhnNyH/JKTBHs0rXzssWAbSzQgdvtgU7PUF9m0A4iC7QS7Dusuo+qmTd5HOo4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771896745; c=relaxed/simple; bh=duKkFzC00NILWdTsFDQ6jxgfrljHThYgPkLQs602iSU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Jg3LkBTcIBTOg4C2MJfGU4o3CRG9jlQXHTe1P9owH7W6vsfJal65tBzH2IyaMnUJTYVlzEFtSiwS0O2TSi62CjkyU/6hIXsfjXgOf9u5+EpLtJ+wO8BFmIuCwUKaQtNaOfXfor+KG0PC181gwZw06hYv4gMrUE2YylI4VfXf0a0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G9fAQVrI; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G9fAQVrI" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-2ba88e53b46so2729042eec.1 for ; Mon, 23 Feb 2026 17:32:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771896743; x=1772501543; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zv5oSk0V/ZX3YgLXFixXf44tV2AKjxOWJjiuXpaRukM=; b=G9fAQVrI7WafhLbX718/eTrsiWwA6quxcUuhsAe+0+To25tvWl1KMojEEZfteZ/zG4 fPBjPNouuorhApgB7fD+dfJRrYIu2+UV6+UE7368EMHaBTnSenQQ1K4EXqLAnJRSwsfc qS/XsKdosYJDrQplCFVYJgiG3vHD7j9BhdeJERl3XjGa5A22bAI4YGPOZRjiS5YB7mql Pc2+1TXlM+mY1ZVCPjmRILNODHkgfl8fDM07eQecRybCgcML8WnpYVLsRbb61ISLbiRw aM4X28XGuR4HSi3/Y+JFogzyxkr0qJOlq7t3OBEJjuU8FzPe9PyCXTxm+RLm9MkQy5zo nfsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771896743; x=1772501543; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Zv5oSk0V/ZX3YgLXFixXf44tV2AKjxOWJjiuXpaRukM=; b=EFjwEtqdKwsfjuJKi89pQVAz4zyS5kRK217mKmFuhT4ycwlSBYs80b/kCefaMSeMEx Gr1pfKxYMMaI1HK8NNiH2en2VYLOsiU9PskwnlDH+p4Tp9DCgUm3qMKM4ZWohxRz/OfY MvFemTJ+yAFgm4OtFZbLOk1nKXcaGq0188xMPMnMMpdmakxwXdgbLwNjlASY4igpdakd Si7FMU/RD/CGStJKbzaYatsezj8fmCNsm1BeTFdknuZ7lcFnWrgY9QVaQuVpB1qOvAoJ XxXJ/fCBfK5m4sme2YD0hv+lP8d4cwOaefzCFwL2uy54J2Pg2uJYUrc+xyi1NyyTCH3H 5QXg== X-Forwarded-Encrypted: i=1; AJvYcCWnAEw9NKrlrk69yxVCJD5EKPv5eYW/ub2yQvEpixbjPUFugtxz+ZpnOUgDUSN+ng8ZzW1dN3jZS7ta70E=@vger.kernel.org X-Gm-Message-State: AOJu0YwwsZixR70+vZ6xDAVSZ7Nnmm5lLLRcVFuOY53y78REG5zELeig ZXqRkOVqx0asvSfd74Qu65CbwlPKxgTfxVJAsFSofJhkJBfm6Guin0P6 X-Gm-Gg: ATEYQzwd3pIOiRfH5/ul7s7LIFNfUM60h2IgJx5XX+Vy8xljOd//JxL0ckP6sv7ygyE CUZ4nzAKaLHn4MeHSwX3qsx7jq65CXiSEcTqbaT9O3gGcupXGqKIUMuvE271SaeZAsnDxwFJ+7x qIMBpTE5bRfAkqQZHus7AA9RWn+5GZxj0yJGuDoIHQl2Ny+8FngbBDbLsc4kECmQXQw1ADPTjG8 qcwiMlK+0LNN+Vf8RjnjrzS4nYeo7xIFgtNyszNQjVOacKZZpwVfSBBSbKBMQErruPTlf2jQWxP AgKFR44FJ05VFHh5WSRvQdB/Yysfj9iVOQeEeKKLK+IVPQ1JXS0teXQRxh1ACkdq/E9YX+j8Mfy QTa+pMAMGWttJ3SOgaAPN0CJA7eZuSwqmhWEDdYkx77kCaIIrZUjD26Za4HzoyNsxv7wxWKSnBU V8UIF/O5Y4SN7VXxpP81MnxdkahGcoTUPDOjKuVrcRMRo96JTIhzHW8L0gwRy6LJIK3x6+GBdX2 I8= X-Received: by 2002:a05:7300:80c7:b0:2ba:a387:92f6 with SMTP id 5a478bee46e88-2bd607e8679mr6380408eec.13.1771896742472; Mon, 23 Feb 2026 17:32:22 -0800 (PST) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bd7daa027fsm6485015eec.9.2026.02.23.17.32.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 17:32:22 -0800 (PST) From: "Derek J. Clark" To: Jiri Kosina , Benjamin Tissoires Cc: Richard Hughes , Mario Limonciello , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Derek J . Clark" , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 01/16] include: device.h: Add named device attributes Date: Tue, 24 Feb 2026 01:32:02 +0000 Message-ID: <20260224013217.1363996-2-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260224013217.1363996-1-derekjohn.clark@gmail.com> References: <20260224013217.1363996-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds DEVICE_ATTR_[RW|RO|WO]_NAMED macros for adding attributes that reuse the same sysfs name in a driver under separate subdirectories. When dealing with some devices it can be useful to be able to reuse the same name for similar attributes under a different subdirectory. For example, a single logical HID endpoint may provide a configuration interface for multiple physical devices. In such a case it is useful to provide symmetrical attribute names under different subdirectories on the configuration device. The Lenovo Legion Go is one such device, providing configuration to a detachable left controller, detachable right controller, the wireless transmission dongle, and the MCU. It is therefore beneficial to treat each of these as individual devices in the driver, providing a subdirectory for each physical device in the sysfs. As some attributes are reused by each physical device, it provides a much cleaner interface if the same driver can reuse the same attribute name in sysfs while uniquely distinguishing the store/show functions in the driver, rather than repeat string portions. Example new WO attrs: ATTRS{left_handle/reset}=3D=3D"(not readable)" ATTRS{right_handle/reset}=3D=3D"(not readable)" ATTRS{tx_dongle/reset}=3D=3D"(not readable)" vs old WO attrs in a subdir: ATTRS{left_handle/left_handle_reset}=3D=3D"(not readable)" ATTRS{right_handle/right_handle_reset}=3D=3D"(not readable)" ATTRS{tx_dongle/tx_dongle_reset}=3D=3D"(not readable)" or old WO attrs with no subdir: ATTRS{left_handle_reset}=3D=3D"(not readable)" ATTRS{right_handle_reset}=3D=3D"(not readable)" ATTRS{tx_dongle_reset}=3D=3D"(not readable)" While the third option is usable, it doesn't logically break up the physical devices and creates a device directory with over 80 attributes once all attrs are defined. Reviewed-by: Mark Pearson Signed-off-by: Derek J. Clark Acked-by: Greg Kroah-Hartman --- v4: - Use dmabuf per request instead of devm allocated static buffer. Resolves bug with side effects during suspend. --- include/linux/device.h | 46 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/include/linux/device.h b/include/linux/device.h index 0be95294b6e61..381463baed6d3 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -189,6 +189,22 @@ ssize_t device_show_string(struct device *dev, struct = device_attribute *attr, #define DEVICE_ATTR_ADMIN_RW(_name) \ struct device_attribute dev_attr_##_name =3D __ATTR_RW_MODE(_name, 0600) =20 +/** + * DEVICE_ATTR_RW_NAMED - Define a read-write device attribute with a sysf= s name + * that differs from the function name. + * @_name: Attribute function preface + * @_attrname: Attribute name as it wil be exposed in the sysfs. + * + * Like DEVICE_ATTR_RW(), but allows for reusing names under separate path= s in + * the same driver. + */ +#define DEVICE_ATTR_RW_NAMED(_name, _attrname) \ + struct device_attribute dev_attr_##_name =3D { \ + .attr =3D { .name =3D _attrname, .mode =3D 0644 }, \ + .show =3D _name##_show, \ + .store =3D _name##_store, \ + } + /** * DEVICE_ATTR_RO - Define a readable device attribute. * @_name: Attribute name. @@ -207,6 +223,21 @@ ssize_t device_show_string(struct device *dev, struct = device_attribute *attr, #define DEVICE_ATTR_ADMIN_RO(_name) \ struct device_attribute dev_attr_##_name =3D __ATTR_RO_MODE(_name, 0400) =20 +/** + * DEVICE_ATTR_RO_NAMED - Define a read-only device attribute with a sysfs= name + * that differs from the function name. + * @_name: Attribute function preface + * @_attrname: Attribute name as it wil be exposed in the sysfs. + * + * Like DEVICE_ATTR_RO(), but allows for reusing names under separate path= s in + * the same driver. + */ +#define DEVICE_ATTR_RO_NAMED(_name, _attrname) \ + struct device_attribute dev_attr_##_name =3D { \ + .attr =3D { .name =3D _attrname, .mode =3D 0444 }, \ + .show =3D _name##_show, \ + } + /** * DEVICE_ATTR_WO - Define an admin-only writable device attribute. * @_name: Attribute name. @@ -216,6 +247,21 @@ ssize_t device_show_string(struct device *dev, struct = device_attribute *attr, #define DEVICE_ATTR_WO(_name) \ struct device_attribute dev_attr_##_name =3D __ATTR_WO(_name) =20 +/** + * DEVICE_ATTR_WO_NAMED - Define a read-only device attribute with a sysfs= name + * that differs from the function name. + * @_name: Attribute function preface + * @_attrname: Attribute name as it wil be exposed in the sysfs. + * + * Like DEVICE_ATTR_WO(), but allows for reusing names under separate path= s in + * the same driver. + */ +#define DEVICE_ATTR_WO_NAMED(_name, _attrname) \ + struct device_attribute dev_attr_##_name =3D { \ + .attr =3D { .name =3D _attrname, .mode =3D 0200 }, \ + .store =3D _name##_store, \ + } + /** * DEVICE_ULONG_ATTR - Define a device attribute backed by an unsigned lon= g. * @_name: Attribute name. --=20 2.52.0