From nobody Sun Apr 5 21:27:31 2026 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5F3B2D592D for ; Tue, 24 Feb 2026 01:32:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771896758; cv=none; b=fLeKDzG561WBBP4NBlWSEahiPedkXD79c1WD/5La5c04B3rwxokysinGPX5Q46Uj/TyqpV/5ArfP4YnsZc4vJN/S2M4OxpYAK3LzikjXH1mmL1Ka1eqqQGWxvDoiWvmDQezDpmagmlpqNXnpeOqIEf9hgd37RVfY1rbijGJo2dQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771896758; c=relaxed/simple; bh=5zmvhCSzVKQWVeJpV+JzldP6eTSHbWR27bfvIBMbw0k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sWigH9miGU8wxrTKiDZsb2lEcWKEUnuPPwc6UZLIsNmTUOJ/JHoyTB/fg1gC/5nhgP2rg1tGEnE+nYavvy+f17W4LdSouCqYj6LRrB0VCkUxGl/XP6hyD6bK/1JYdminYEIMK2fhcgghnlUtGxXERGH6H4edQR630XNFnR6Eylo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qc265SNE; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qc265SNE" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-2b82c605dbdso5044190eec.0 for ; Mon, 23 Feb 2026 17:32:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771896755; x=1772501555; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r3T3rfbgMgRdQYOQhjLjrm8BnZ1KC4f94qtU1Sqe8xM=; b=Qc265SNEeFBsmlKb60u8+lf7Qz4qogoBdURgRExEU7dUplCPIgfpFdv/yzOVpwvdAI 7wqOLf/nTMGWQbrhirsDnxFF19FS+L86w9puwFbSrFh3Eku5Y9HXAKHHT5btESWPJ16v lORh2EuiCFT83rlWVkOm+MzzkvpN4dGfc4dJ0J6HmxLnE8pJWhTFM3HhhQdcKk0ffnnF xRIF/JYaGgmGB19jsKvcmfpQ86LJin5WcnePm7VcJskDqgGFjeD+Hg6ykPQPVPEgyXtD UaN5uOgqWw8PNgYmVe0yC8Elmb644MJv6nuqAjoZKdChOKXYfHsMv2QpTZc213S5MuAG 8NVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771896755; x=1772501555; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=r3T3rfbgMgRdQYOQhjLjrm8BnZ1KC4f94qtU1Sqe8xM=; b=DJ/1UuVOyvlH3nIYs/YOXdJgdSeLqwu21ADhCMbnbc06qqcvsBbuXlfGweObR84KyX 2+plmccOo+J6tGHGqNLwwG83o+RJn+tNFbaUxRJsYMauCoYcJWrW77VqPdSJ/60TISfy bmW4ldqM3Vy6++vrzuAba4TvgAOZkPqahQ9+wOiA1XKeN5TzqC6aCR9tx4WkHnusvi5j 7Cp//VGT61t0uYDB7/zLBdhb1oyUYSXAWH3zo9mcR4PWb019g1D65KGWNF/CRxNOwmAh y9M6koSWEgtuGoUZ7xrz36NUWBYoJd6XL/I+eeckdqel8N/vCTMdUjQBqUQw4nzwUkli Ontg== X-Forwarded-Encrypted: i=1; AJvYcCUJ4Kq1abnVBe1QmfEDtByJE/kO07qHZ+wgH/yghmhYD2SIW9WOTNUaA5nIw4FCEZ84jUj0+OZ1eUHigS8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywv7mPjOgtA8Y8DzhlZWfgsck6seCChyTnskngLPtmnLDix2QPK K+1/9WKtogzPITL0TNT8lGymqwNuDBwE3LLgB/actFYLwSlEb/1wSBT1FI4nvg== X-Gm-Gg: ATEYQzwGq/AJ4JUeOtrIZ0Z4jpDIBz0+bHJHzmSqjcS1Zfh0KGI4rfHuj82bpwnV4Eb iQmo/r1ihJoLxYZFhoxl+AiMfIIJNclPKrFeTWDb/d86MVJz+i4kINHHX78vpofmvNDU3DdvkrJ x1bQRc+sHjM/ZA0HDOuZku8UWBDr6wxF1wc8DWTRnxGbHM3aTMjMkuRbrbePBG7XM1p5WDpdhJK u4nk7y/EKcnO3TyChRKOCrRrjZxXNfFcLC7gsV/vVzDszdLfc1YfKd7ENn1Gm0iu9c7twXLRDG+ tYjd2uzIQCCmwxNdbgY1l5YXF7iWCiLXyYO61SnEMCmX+9xEVaHKIyPUG41emH+0l3/5V89tDNU bBGR5+2NGsNuZQFD4Blv6EjIuHZtJ6cQbSj5Wx4bpfmmndC8izVOLknj8MYugkM+ijdmoAgzJQn fbWheJG5j657Dyc+/vRgiLWmls3U4FlLPogGKSD0UQdVjvKZF8lyGKu1+v1KKSzeFxqFyjRiQL5 /OzMiG9Uwp2GA== X-Received: by 2002:a05:7301:6085:b0:2ba:72b1:40c7 with SMTP id 5a478bee46e88-2bd7b9f0874mr4662027eec.4.1771896754966; Mon, 23 Feb 2026 17:32:34 -0800 (PST) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bd7daa027fsm6485015eec.9.2026.02.23.17.32.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 17:32:34 -0800 (PST) From: "Derek J. Clark" To: Jiri Kosina , Benjamin Tissoires Cc: Richard Hughes , Mario Limonciello , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Derek J . Clark" , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 15/16] HID: hid-lenovo-go-s: Add IMU and Touchpad RO Attributes Date: Tue, 24 Feb 2026 01:32:16 +0000 Message-ID: <20260224013217.1363996-16-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260224013217.1363996-1-derekjohn.clark@gmail.com> References: <20260224013217.1363996-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds attributes for reporting the touchpad manufacturer, version, and IMU manufacturer. Reviewed-by: Mark Pearson Signed-off-by: Derek J. Clark --- v4: - Cache RO values at probe instead of calling them at request. Values don't change and reading the touchpad data is slow. v3: - Fix bug where the touchpad attributes were assigned to the touchpad _show function instead of the test _show function. --- drivers/hid/hid-lenovo-go-s.c | 124 ++++++++++++++++++++++++++++++++++ 1 file changed, 124 insertions(+) diff --git a/drivers/hid/hid-lenovo-go-s.c b/drivers/hid/hid-lenovo-go-s.c index 1a7de95e2a065..cacc5bd5ed2b6 100644 --- a/drivers/hid/hid-lenovo-go-s.c +++ b/drivers/hid/hid-lenovo-go-s.c @@ -43,6 +43,7 @@ struct hid_gos_cfg { u8 gp_mode; u8 gp_poll_rate; u8 imu_bypass_en; + u8 imu_manufacturer; u8 imu_sensor_en; u8 mcu_id[12]; u8 mouse_step; @@ -54,6 +55,8 @@ struct hid_gos_cfg { u8 rgb_speed; u8 tp_en; u8 tp_linux_mode; + u8 tp_manufacturer; + u8 tp_version; u8 tp_windows_mode; } drvdata; =20 @@ -201,6 +204,36 @@ enum rgb_config_index { USR_LIGHT_PROFILE_3, }; =20 +enum test_command_index { + TEST_TP_MFR =3D 0x02, + TEST_IMU_MFR, + TEST_TP_VER, +}; + +enum tp_mfr_index { + TP_NONE, + TP_BETTERLIFE, + TP_SIPO, +}; + +static const char *const touchpad_manufacturer_text[] =3D { + [TP_NONE] =3D "none", + [TP_BETTERLIFE] =3D "BetterLife", + [TP_SIPO] =3D "SIPO", +}; + +enum imu_mfr_index { + IMU_NONE, + IMU_BOSCH, + IMU_ST, +}; + +static const char *const imu_manufacturer_text[] =3D { + [IMU_NONE] =3D "none", + [IMU_BOSCH] =3D "Bosch", + [IMU_ST] =3D "ST", +}; + static int hid_gos_version_event(u8 *data) { struct version_report *ver_rep =3D (struct version_report *)data; @@ -279,6 +312,30 @@ static int hid_gos_touchpad_event(struct command_repor= t *cmd_rep) return ret; } =20 +static int hid_gos_pl_test_event(struct command_report *cmd_rep) +{ + int ret =3D 0; + + switch (cmd_rep->sub_cmd) { + case TEST_TP_MFR: + drvdata.tp_manufacturer =3D cmd_rep->data[0]; + ret =3D 0; + break; + case TEST_IMU_MFR: + drvdata.imu_manufacturer =3D cmd_rep->data[0]; + ret =3D 0; + break; + case TEST_TP_VER: + drvdata.tp_version =3D cmd_rep->data[0]; + ret =3D 0; + break; + default: + ret =3D -EINVAL; + break; + } + return ret; +} + static int hid_gos_light_event(struct command_report *cmd_rep) { struct led_classdev_mc *mc_cdev; @@ -362,6 +419,9 @@ static int hid_gos_raw_event(struct hid_device *hdev, s= truct hid_report *report, case GET_TP_PARAM: ret =3D hid_gos_touchpad_event(cmd_rep); break; + case GET_PL_TEST: + ret =3D hid_gos_pl_test_event(cmd_rep); + break; case GET_RGB_CFG: ret =3D hid_gos_light_event(cmd_rep); break; @@ -738,6 +798,37 @@ static ssize_t touchpad_property_options(struct device= *dev, return count; } =20 +static ssize_t test_property_show(struct device *dev, + struct device_attribute *attr, char *buf, + enum test_command_index index) +{ + size_t count =3D 0; + u8 i; + + switch (index) { + case TEST_TP_MFR: + i =3D drvdata.tp_manufacturer; + if (i >=3D ARRAY_SIZE(touchpad_manufacturer_text)) + return -EINVAL; + count =3D sysfs_emit(buf, "%s\n", touchpad_manufacturer_text[i]); + break; + case TEST_IMU_MFR: + i =3D drvdata.imu_manufacturer; + if (i >=3D ARRAY_SIZE(imu_manufacturer_text)) + return -EINVAL; + count =3D sysfs_emit(buf, "%s\n", imu_manufacturer_text[i]); + break; + case TEST_TP_VER: + count =3D sysfs_emit(buf, "%u\n", drvdata.tp_version); + break; + default: + count =3D -EINVAL; + break; + } + + return count; +} + static ssize_t mcu_id_show(struct device *dev, struct device_attribute *at= tr, char *buf) { @@ -1081,6 +1172,9 @@ struct gos_cfg_attr imu_bypass_enabled =3D { FEATURE_= IMU_BYPASS }; LEGOS_DEVICE_ATTR_RW(imu_bypass_enabled, "bypass_enabled", index, gamepad); static DEVICE_ATTR_RO_NAMED(imu_bypass_enabled_index, "bypass_enabled_inde= x"); =20 +struct gos_cfg_attr imu_manufacturer =3D { TEST_IMU_MFR }; +LEGOS_DEVICE_ATTR_RO(imu_manufacturer, "manufacturer", test); + struct gos_cfg_attr imu_sensor_enabled =3D { FEATURE_IMU_ENABLE }; LEGOS_DEVICE_ATTR_RW(imu_sensor_enabled, "sensor_enabled", index, gamepad); static DEVICE_ATTR_RO_NAMED(imu_sensor_enabled_index, "sensor_enabled_inde= x"); @@ -1088,6 +1182,7 @@ static DEVICE_ATTR_RO_NAMED(imu_sensor_enabled_index,= "sensor_enabled_index"); static struct attribute *legos_imu_attrs[] =3D { &dev_attr_imu_bypass_enabled.attr, &dev_attr_imu_bypass_enabled_index.attr, + &dev_attr_imu_manufacturer.attr, &dev_attr_imu_sensor_enabled.attr, &dev_attr_imu_sensor_enabled_index.attr, NULL, @@ -1141,6 +1236,12 @@ struct gos_cfg_attr touchpad_linux_mode =3D { CFG_LI= NUX_MODE }; LEGOS_DEVICE_ATTR_RW(touchpad_linux_mode, "linux_mode", index, touchpad); static DEVICE_ATTR_RO_NAMED(touchpad_linux_mode_index, "linux_mode_index"); =20 +struct gos_cfg_attr touchpad_manufacturer =3D { TEST_TP_MFR }; +LEGOS_DEVICE_ATTR_RO(touchpad_manufacturer, "manufacturer", test); + +struct gos_cfg_attr touchpad_version =3D { TEST_TP_VER }; +LEGOS_DEVICE_ATTR_RO(touchpad_version, "version", test); + struct gos_cfg_attr touchpad_windows_mode =3D { CFG_WINDOWS_MODE }; LEGOS_DEVICE_ATTR_RW(touchpad_windows_mode, "windows_mode", index, touchpa= d); static DEVICE_ATTR_RO_NAMED(touchpad_windows_mode_index, "windows_mode_ind= ex"); @@ -1150,6 +1251,8 @@ static struct attribute *legos_touchpad_attrs[] =3D { &dev_attr_touchpad_enabled_index.attr, &dev_attr_touchpad_linux_mode.attr, &dev_attr_touchpad_linux_mode_index.attr, + &dev_attr_touchpad_manufacturer.attr, + &dev_attr_touchpad_version.attr, &dev_attr_touchpad_windows_mode.attr, &dev_attr_touchpad_windows_mode_index.attr, NULL, @@ -1250,6 +1353,27 @@ static void cfg_setup(struct work_struct *work) dev_err(&drvdata.hdev->dev, "Failed to retrieve MCU Version: %i\n", ret); return; } + + ret =3D mcu_property_out(drvdata.hdev, GET_PL_TEST, TEST_TP_MFR, 0, 0); + if (ret) { + dev_err(&drvdata.hdev->dev, + "Failed to retrieve Touchpad Manufacturer: %i\n", ret); + return; + } + + ret =3D mcu_property_out(drvdata.hdev, GET_PL_TEST, TEST_TP_VER, 0, 0); + if (ret) { + dev_err(&drvdata.hdev->dev, + "Failed to retrieve Touchpad Firmware Version: %i\n", ret); + return; + } + + ret =3D mcu_property_out(drvdata.hdev, GET_PL_TEST, TEST_IMU_MFR, 0, 0); + if (ret) { + dev_err(&drvdata.hdev->dev, + "Failed to retrieve IMU Manufacturer: %i\n", ret); + return; + } } =20 static int hid_gos_cfg_probe(struct hid_device *hdev, --=20 2.52.0