From nobody Sun Apr 5 21:16:30 2026 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4767280308 for ; Tue, 24 Feb 2026 01:32:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771896754; cv=none; b=pZ1s/Rnwenmj+54/2KKBf0w0nN9efeGzfuH1RGQ3NfyaZI812p2nvoz2KPfVDeBF9WVfJVPiUlffFMmPxpM+4jJXQUjXodGW29AttHoULwrc6i06cNPFiTdJ6K04UIGlDCdwnFj55qPEaCi7+qZrRYWujodDE4EZWc7tnW4xt58= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771896754; c=relaxed/simple; bh=MJEBoLXx6kZaotyArkUmXw4t11kA39rfjHgA906xTGo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nhezVONk7ur0GndGZqcEk4/gwZFNqHX0SzisiokRHgEXvqmTe9UZw+SOgzpGoo1s0YpwwSya6zApOG+5JwyIfTqgHlMbM+c3zBokpNdTAy9Nw29mXpAb3R76GiXbjkSO2qeJhnB1GpLoa3TPqfZkSaW0cOQets5B1S10GAd/5ag= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TMPVpN8l; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TMPVpN8l" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-2ba94dbf739so5433123eec.1 for ; Mon, 23 Feb 2026 17:32:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771896752; x=1772501552; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EQzl3yVDAN1730LcqI2ceRttYFMRQfPPEDz6M2H8l6E=; b=TMPVpN8lcCA97sOYW2SiFDRtxiyHz8xlOz8TKE/XBnJhU3QERUhXGwPQCIONmbxo6u 2G4Wqj4Lj18qB8Mbm81WkZeEi8OMVQAgK6l4P24i6t1KDin8I9ji9isMUnDSY4hP4C32 GxQf2hJnKT9VFqoxOz0cMpwbJAIzdLURGNnZpOucdztcZbvl4eqqfbzoeK6aeJp2XPtN hT45HRYKidGI8rFCHGjjFpOQTnLdAAnHC6QXjghP+LdY6+C58a3AZxeo0V9KKefhcXUv M7uvZvHyk6z3Rk5N2H06XbpGoNhAvI9YQhw373yMbo52HLqw/aj9ZIbtGaqEYJYICkVX 0OqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771896752; x=1772501552; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EQzl3yVDAN1730LcqI2ceRttYFMRQfPPEDz6M2H8l6E=; b=b4TGi8IJRHDcmyQYVbOCdunzr6uvky3QN3qXfEZhZOTqEhYNuZBE7f2yIAtq0eKVV3 On5ncGah1euwPMKKDkO9bUypBPa+BJQ9t0dgIMBfbbnC0YICNnC3R5IP9SZV/sxqQvuz LyeXqSppmwdlicoPCVgP1HydWodYGLreTPhbo3vyrYSKZtKQ/h44C6VW6cPKr+b0ydaa Z+IeJy3h+RzzOkJCeVEVApq4cusYKGlEb6wjSUgPx6ejZHA7g/aTK36rJVIh8wv6duO3 VlFV/9mjM1vJ/A5jTGFq3+do0n3YcDEQETki+d+1NgQE9CXozDil4WKuj/Li94eYYMg6 i2sw== X-Forwarded-Encrypted: i=1; AJvYcCU6pLUsPS0vLoATSc2941QEVQg9tBaNbADoDtHFLVKPc9G//Hl79eNRhHKMFJbkG2M3qajaAs/WXT+qZTs=@vger.kernel.org X-Gm-Message-State: AOJu0YzhyEEjHkIHyvJFvDagiAI5GWS0hkGRLeqcIrwxxaj/8/CLMw2R sc6E5lpyOEIsES91xCkS5BosI5awisG+3FVxGjWtbfZPcwoTAKck1KtA X-Gm-Gg: ATEYQzwJdDIEdr5ddlTxcXdXyxn9TxmT0z83NsezWycHDV++qMJ+25Cmo8bEtFmYAaA MyQ2VgxUWraCmsm0vUcWNEWYB/wEex53nW2Kcej2Iv7SlY6Q41EJQB1FLGvuPzKZ2Ks2ZLzQvHx 6zSfqlArArVDYdesJjOMBpwmN/xO1hGC8uUdynaroA5mycWqqTJW478TD5WXGfUXtxdssrTGnxe yA3w73CxuN+/qmwUF0Z4GVt1HjoUhd3vgzz0nWLjjWbTaNnTskIWpdsd0eTPAh0wSUjwATuMJiI gky/9rAxTzv/bj281MKLikEWVBAOVYliKX0L/lqCzTqv2Or3R5OWsoKufVMk8PNnqpdZZRSbKER 6o0YJldCI57qBa4ERG1vWfSxoOVy5OkVFaQz9e8nkjv5vzlGC5MrDhBkgHGowYQh/1oFaKNuq8I mtIuwjaZiid4vVBDpAPxHfiKiALabe0VQw8c1GUqHmq7FjTaXMjYcUUHyKdnS5eVE2sKR8R6sQM xc= X-Received: by 2002:a05:693c:2c0a:b0:2ab:8ef5:df2 with SMTP id 5a478bee46e88-2bd7bd59af3mr4703596eec.35.1771896752005; Mon, 23 Feb 2026 17:32:32 -0800 (PST) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bd7daa027fsm6485015eec.9.2026.02.23.17.32.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 17:32:31 -0800 (PST) From: "Derek J. Clark" To: Jiri Kosina , Benjamin Tissoires Cc: Richard Hughes , Mario Limonciello , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Derek J . Clark" , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 13/16] HID: hid-lenovo-go-s: Add Touchpad Mode Attributes Date: Tue, 24 Feb 2026 01:32:14 +0000 Message-ID: <20260224013217.1363996-14-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260224013217.1363996-1-derekjohn.clark@gmail.com> References: <20260224013217.1363996-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adds attributes for managing the touchpad operating modes. Reviewed-by: Mark Pearson Signed-off-by: Derek J. Clark --- drivers/hid/hid-lenovo-go-s.c | 142 ++++++++++++++++++++++++++++++++++ 1 file changed, 142 insertions(+) diff --git a/drivers/hid/hid-lenovo-go-s.c b/drivers/hid/hid-lenovo-go-s.c index 423b64cd02902..02d4e6548285e 100644 --- a/drivers/hid/hid-lenovo-go-s.c +++ b/drivers/hid/hid-lenovo-go-s.c @@ -47,6 +47,8 @@ struct hid_gos_cfg { u8 os_mode; u8 rgb_en; u8 tp_en; + u8 tp_linux_mode; + u8 tp_windows_mode; } drvdata; =20 struct gos_cfg_attr { @@ -145,6 +147,22 @@ static const char *const dpad_mode_text[] =3D { [DIR4] =3D "4-way", }; =20 +enum touchpad_mode_index { + TP_REL, + TP_ABS, +}; + +static const char *const touchpad_mode_text[] =3D { + [TP_REL] =3D "relative", + [TP_ABS] =3D "absolute", +}; + +enum touchpad_config_index { + CFG_WINDOWS_MODE =3D 0x03, + CFG_LINUX_MODE, + +}; + static int hid_gos_version_event(u8 *data) { struct version_report *ver_rep =3D (struct version_report *)data; @@ -204,6 +222,25 @@ static int hid_gos_gamepad_cfg_event(struct command_re= port *cmd_rep) return ret; } =20 +static int hid_gos_touchpad_event(struct command_report *cmd_rep) +{ + int ret =3D 0; + + switch (cmd_rep->sub_cmd) { + case CFG_LINUX_MODE: + drvdata.tp_linux_mode =3D cmd_rep->data[0]; + break; + case CFG_WINDOWS_MODE: + drvdata.tp_windows_mode =3D cmd_rep->data[0]; + break; + default: + ret =3D -EINVAL; + break; + } + + return ret; +} + static int hid_gos_set_event_return(struct command_report *cmd_rep) { if (cmd_rep->data[0] !=3D 0) @@ -251,7 +288,11 @@ static int hid_gos_raw_event(struct hid_device *hdev, = struct hid_report *report, case GET_GAMEPAD_CFG: ret =3D hid_gos_gamepad_cfg_event(cmd_rep); break; + case GET_TP_PARAM: + ret =3D hid_gos_touchpad_event(cmd_rep); + break; case SET_GAMEPAD_CFG: + case SET_TP_PARAM: ret =3D hid_gos_set_event_return(cmd_rep); break; default: @@ -533,6 +574,95 @@ static ssize_t gamepad_property_options(struct device = *dev, return count; } =20 +static ssize_t touchpad_property_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count, + enum touchpad_config_index index) +{ + size_t size =3D 1; + u8 val =3D 0; + int ret; + + switch (index) { + case CFG_WINDOWS_MODE: + ret =3D sysfs_match_string(touchpad_mode_text, buf); + if (ret < 0) + return ret; + val =3D ret; + break; + case CFG_LINUX_MODE: + ret =3D sysfs_match_string(touchpad_mode_text, buf); + if (ret < 0) + return ret; + val =3D ret; + break; + default: + return -EINVAL; + } + if (!val) + size =3D 0; + + ret =3D mcu_property_out(drvdata.hdev, SET_TP_PARAM, index, &val, size); + if (ret < 0) + return ret; + + return count; +} + +static ssize_t touchpad_property_show(struct device *dev, + struct device_attribute *attr, char *buf, + enum touchpad_config_index index) +{ + int ret =3D 0; + u8 i; + + ret =3D mcu_property_out(drvdata.hdev, GET_TP_PARAM, index, 0, 0); + if (ret < 0) + return ret; + + switch (index) { + case CFG_WINDOWS_MODE: + i =3D drvdata.tp_windows_mode; + break; + case CFG_LINUX_MODE: + i =3D drvdata.tp_linux_mode; + break; + default: + return -EINVAL; + } + + if (i >=3D ARRAY_SIZE(touchpad_mode_text)) + return -EINVAL; + + return sysfs_emit(buf, "%s\n", touchpad_mode_text[i]); +} + +static ssize_t touchpad_property_options(struct device *dev, + struct device_attribute *attr, + char *buf, + enum touchpad_config_index index) +{ + size_t count =3D 0; + unsigned int i; + + switch (index) { + case CFG_WINDOWS_MODE: + case CFG_LINUX_MODE: + for (i =3D 0; i < ARRAY_SIZE(touchpad_mode_text); i++) { + count +=3D sysfs_emit_at(buf, count, "%s ", + touchpad_mode_text[i]); + } + break; + default: + return count; + } + + if (count) + buf[count - 1] =3D '\n'; + + return count; +} + static ssize_t mcu_id_show(struct device *dev, struct device_attribute *at= tr, char *buf) { @@ -662,9 +792,21 @@ struct gos_cfg_attr touchpad_enabled =3D { FEATURE_TOU= CHPAD_ENABLE }; LEGOS_DEVICE_ATTR_RW(touchpad_enabled, "enabled", index, gamepad); static DEVICE_ATTR_RO_NAMED(touchpad_enabled_index, "enabled_index"); =20 +struct gos_cfg_attr touchpad_linux_mode =3D { CFG_LINUX_MODE }; +LEGOS_DEVICE_ATTR_RW(touchpad_linux_mode, "linux_mode", index, touchpad); +static DEVICE_ATTR_RO_NAMED(touchpad_linux_mode_index, "linux_mode_index"); + +struct gos_cfg_attr touchpad_windows_mode =3D { CFG_WINDOWS_MODE }; +LEGOS_DEVICE_ATTR_RW(touchpad_windows_mode, "windows_mode", index, touchpa= d); +static DEVICE_ATTR_RO_NAMED(touchpad_windows_mode_index, "windows_mode_ind= ex"); + static struct attribute *legos_touchpad_attrs[] =3D { &dev_attr_touchpad_enabled.attr, &dev_attr_touchpad_enabled_index.attr, + &dev_attr_touchpad_linux_mode.attr, + &dev_attr_touchpad_linux_mode_index.attr, + &dev_attr_touchpad_windows_mode.attr, + &dev_attr_touchpad_windows_mode_index.attr, NULL, }; =20 --=20 2.52.0