From nobody Fri Apr 17 01:43:56 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01544376484 for ; Tue, 24 Feb 2026 10:08:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771927685; cv=none; b=u3wqHG84RPn0Fpwgo1QekDs+AZo06k8qEmOqIKu70aFKiMX5DfCvaQSH4Z8fEAZM2O8hxKMet0kf7UA2WWhrnLF8fakbtaceecH7lV1oinRRZipmAgC3f7WOBhhr5TQ2ZRT/7d0OCH6yjLpDt0HOlHWStX9czMAOKXw4lgb2BVg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771927685; c=relaxed/simple; bh=nko1VjBMRCFSDUXBkH6jocf/gIsitXH8EZG0LEIuFRM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=PwXGafK7o/dy4KMOlO+fATBrS34O9yWLZHUPMoBz5euzHLbygGzd5wzr5AU5Ii+fc2TkCrXDNJHcQQLyNvfiS7oQ1MZrgtmaDlG8VHBOl6dYDPEU41T/CqrQuvBIr9VvLc+OCXBS0+TEE4byfhBpw+Os96URhfvMqVHkvbQc2aA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hrxbLCWa; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hrxbLCWa" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-824b5f015bcso5078038b3a.1 for ; Tue, 24 Feb 2026 02:08:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771927683; x=1772532483; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=aE7meEGLl0ss9J59OJ0SeuZehN8AaBR28ECHtJSs4uU=; b=hrxbLCWaZV+9cZFg3U6shgN6qvdhstnAZ+bBJWpZvonslwnj8NXCxxe22XQAf/STHw hBL+wNOYBawu4j+CcgZ1DbA72B6eTJDfz6Tf32CpKc+e+Gyl6kTTX7hyLFTmVKyj9whi DbbDZauTlwtz09ucDQGkk8BPWR48BGOH5UgXj3K1qM/es4APBs/l6m20ujEOErurC3NB M2qG3JmdJ6iRqWYmPySUhG1OLe0zOpAXWe8NX2Z4M2YWw63Ke8m3fuw5+ma2T3Jgoxud fnVt0yWHclXceOmuyr03eBXBEJguIvn226J7WWuu9xyvtsAH1AuAPI0qVe774EzT4etg tt/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771927683; x=1772532483; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aE7meEGLl0ss9J59OJ0SeuZehN8AaBR28ECHtJSs4uU=; b=HILZGwPVtnFkXkpukZX5wD7yn4td8y7hLyH/AMwLRSBhZDlfPBbKRxqx43vLqE02N3 9YfzwxbWBZddl23zZyLMWAQH4Z/i/YTcqlODFB/Pdk9KsCNttzh8FDH4Un4RGHgYXXnZ pSwHf7q7Ro6ZTGTiwgBaOwKnCZLnNg9+GQUkg/yrHy95ELnYQMvs1pbIYrs25D5h7/NH d5DZYP4bbycT+B1FIyxPPAyzxlDlfYXJmJ1EdWqAFoX4h3NbNIT1TCqAcrWEgPYRx7cv bYohQSnhqc1pv87AEIxTcYv/ONH76v7xGQFfoUNa/oMb2PZEUwHabhnDfb3ChP6l4NxE noGA== X-Gm-Message-State: AOJu0YyIgaoNXQ2l9A4yVCX7AgF5SWZ5LxUCnPyr9m1AtGwCHBihfbkC XQm+wwnSauLt1mHfeoFQLHb0vE0f9xlOuouEpaKMnuyYx4tMqDk/4tDB X-Gm-Gg: ATEYQzyiojbux40xvfiyl21VXZ9IDPMN5dG4FBbvXJz+zQnZBQPjcG54BxBo68I6XAo R+kBkSpGZjVugD65kiZOrhZ6aTK0xGzUQqK6jzW8KcmhWRB5NTkbuTjwZMs/hlsbFPdjxXrrI6A dsr6deaNqfZKrLykaKVZD76L/gd24nXapILpUyKWz085mzYYmFNJQKFRRhtBDi4o4XWjlt/sKqV vVl5DjG9qeHtdjpn30JVTyxZU8m6kXitcxh6c1E41ucvBy+tNB6zsgROFIpX+CspzoRvei5QDq9 ALW93V4+6q6x0BfBLrv1A0h6rVPP6RERU93d3X/igLpxA0OnPEg6hKjmfREVnOhw4OVhK0A0uUb AZzniHrNbmW3mF3yDilJRmpwF7N3LCGqRVXroZenHwZrLAqweszbxgp9SWzoL4X15c0av4dTTF3 W/MmbxR+YI7cCWAPEp1Ep7eTVEMHk8mnKg1BlEt20rr0gQYecC X-Received: by 2002:a05:6a00:1828:b0:81f:4e4d:a137 with SMTP id d2e1a72fcca58-826da8c116bmr10462554b3a.10.1771927683327; Tue, 24 Feb 2026 02:08:03 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9008:ba52:a117:e2f3:ee55:ed0d]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-826dd8c7535sm13027086b3a.56.2026.02.24.02.08.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 02:08:03 -0800 (PST) From: Felix Gu Date: Tue, 24 Feb 2026 18:07:59 +0800 Subject: [PATCH] regulator: fp9931: Fix PM runtime reference leak in fp9931_hwmon_read() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260224-fp9931-v1-1-1cf05cabef4a@gmail.com> X-B4-Tracking: v=1; b=H4sIAH54nWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDIyMT3bQCS0tjQ91UE0MTozSjVMPEJEMloOKCotS0zAqwQdGxtbUAJ7Y 0FFgAAAA= X-Change-ID: 20260224-fp9931-e4142f2e1ab1 To: Liam Girdwood , Mark Brown , Andreas Kemnade Cc: linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1771927681; l=1128; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=nko1VjBMRCFSDUXBkH6jocf/gIsitXH8EZG0LEIuFRM=; b=plRhXWqrDsJOJ2S2uR8+XihBCs7IoAkFmOYOmmj865cwASatUjyJC3BfLcYBT/LX6828squGN toCWqS/imWtDATLmH/hW2em7rTJujqCPKTKx6WhYGY1jN+ZKGxSbRrz X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In fp9931_hwmon_read(), if regmap_read() failed, the function returned the error code without calling pm_runtime_put_autosuspend(), causing a PM reference leak. Fixes: 12d821bd13d4 ("regulator: Add FP9931/JD9930 driver") Signed-off-by: Felix Gu Reviewed-by: Andreas Kemnade --- drivers/regulator/fp9931.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/fp9931.c b/drivers/regulator/fp9931.c index 7fbcc6327cc6..abea3b69d8a0 100644 --- a/drivers/regulator/fp9931.c +++ b/drivers/regulator/fp9931.c @@ -144,13 +144,12 @@ static int fp9931_hwmon_read(struct device *dev, enum= hwmon_sensor_types type, return ret; =20 ret =3D regmap_read(data->regmap, FP9931_REG_TMST_VALUE, &val); - if (ret) - return ret; + if (!ret) + *temp =3D (s8)val * 1000; =20 pm_runtime_put_autosuspend(data->dev); - *temp =3D (s8)val * 1000; =20 - return 0; + return ret; } =20 static umode_t fp9931_hwmon_is_visible(const void *data, --- base-commit: 779cae956c8316aebc1946ef86ca001f99658270 change-id: 20260224-fp9931-e4142f2e1ab1 Best regards, --=20 Felix Gu