From nobody Fri Apr 17 01:43:56 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F32DA37B3F1 for ; Tue, 24 Feb 2026 11:04:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771931051; cv=none; b=MjgpX4/ojctJpRQiqUTmHZZFa0VnIwCwNYT7dBpMa7VQ3LNyzBiAE60W8LP3rrWTCZEeRrXkEVWMop3Ow3c0Mv4DaMc1Ux0BgxkfFRhYF3pu5QFRCCW2hdXaMeQRgLf7lYC4/OUZRcK2kPlPSR37hvg60R8gpdt3hb/u+SHDokA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771931051; c=relaxed/simple; bh=YhP3pWD3TXopGx3GMHZR0Qk/xUp7dOSyYuWyrPsIuDs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=mvQFHCXIsr4GzqP1KqanALUkoua33pi4k5Clmybs+4RTk88FdrDHnT1TyqJ/0Fnfm5sDD9vXBcSolxUfd237zgYyFo6jSDwQOlo+FyZ00KKMc6EDO8HR30jiQOwpZ82W83bph3W6O1TEtMWn4+5ND7xm0fGBvDhb9bH7tnV8C/k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MBIi9VFt; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MBIi9VFt" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-8230c2d3128so2260876b3a.0 for ; Tue, 24 Feb 2026 03:04:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771931049; x=1772535849; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=RaCMqhL6lxzpAmD/kp38IfatllhbkDsa2tr+B08/V9c=; b=MBIi9VFtIk+EsaC3MqvD1YxbZixbcBwaoHkSoUhdFQEiG6cxbnGh09aHhMJE4+FnSM Fpp4zzJ2/cejfS8bfFkKaMFhw4GOqelBC7QISFllo2Kdsazh7CSKad/k/3wWS6eqKloL AdA3daICxdyi9O0ZdCk6lO55UAf+dend/4RoY21GriTb07XqkvoIZUqozZ8U8rEUXVBu OH7a5gJKIPJ5vJiPb1kJTQnstNXcmI7kQxOgHUVIOJ1Nyd9HHrN4DbFFe571HXFgc8lU eUNYEufjGVK04T5iCSPI/ss+JJqYRCNYl7a8CkoSP3nVlT2U0lbDr05L9A4y0fEu342o UBhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771931049; x=1772535849; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RaCMqhL6lxzpAmD/kp38IfatllhbkDsa2tr+B08/V9c=; b=m8oDcb8CCaJSHs9dVX60W+rRuYpDK+ijhCavluuYbbkEHYwS1fr1dt1Oawilq/xzvZ 8x/Wv88PG774Ho/qVVf+HMzoPGAwt9KgzAEnTMzj20owZTIfG+8SoyRCS8FWVLAas+Zq g+XbUUO964vj5hvFtP5s39OsriU+Oh8w+U0PXsXBdKjkMu7Qz+xKp8iqbczMmo1e453b tsVMKsDnY4BaYXF6VoiHUAJVL88PLKX+Fj7lcAY0kQfFfWm5PgM94uiQx11FB2IdqXwq UQQ7qZu1ckp7kbvS701erwEBOEZ/07APgutkx65ueR1CdaYnLSdtin13hmjJZgX/krCO rB7g== X-Forwarded-Encrypted: i=1; AJvYcCU7Rz7bBEwNiwAyxEY+rzkbJYIeYFigCiPG9FTY8aVSaRse94UwfB5hOd95fG0Tq99Homadjo94NIl2siU=@vger.kernel.org X-Gm-Message-State: AOJu0YzVwHwzb1SWvtUnr0Aelxl9Uss1wLgLMllJxpuhonobYzoWSb2p XoF1u5RxPDI2L3ugOoGNZdl/Kr57JfYGtFQrqKs5Vje6m9VmWUKkitDD X-Gm-Gg: ATEYQzwmpVCKgC9Sa1luq8QIeKf3aOR/1ZbpnYh6qEw2w+tG75wXn5gMRGmnPkZ8l6o nwNvDYpoB7bidZCmLJrKR5JPV4k+318SA2E2PBdxaVy1AP4/sozUJZiOQOC0GslySqI5D6O8WdS 2ztd1hn3zMjPknj1VjAgwQuKGE6qLeEM4wLN2pi/MVrMWeX/pOd2/7ks9moYJorVLnui8a3yC51 GNacykUyQvTYhFDSdd5r+GojzIBw5i0gVfg+/RHTNE5YyXSo2NRVC/aBY6wV481EW4OT9KYZBw2 /vmNsGgZtEL0QdPKZmkZuyFEcZ63G2vWRZvxcYBE7js920fuGlgLe19IbLSwtx2c4w4DroU0RGw Hx7n36fwq3YvdwO/ypS7hnSySobgFzqeRXt5Uib9mnJPJnfc2Apwv6TvLP7yhFNdO92c/TR7SQ+ qdow/d+yPzmPpKboM/5ovsgfZ0DXhQfs04abvMeg== X-Received: by 2002:a05:6a00:37d0:b0:824:9451:c1ee with SMTP id d2e1a72fcca58-826daa272b3mr7054959b3a.55.1771931049176; Tue, 24 Feb 2026 03:04:09 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9008:ba52:a117:e2f3:ee55:ed0d]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-826dd86c93fsm10770584b3a.38.2026.02.24.03.04.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 03:04:08 -0800 (PST) From: Felix Gu Date: Tue, 24 Feb 2026 19:04:04 +0800 Subject: [PATCH v2] dpll: zl3073x: Remove redundant cleanup in devm_dpll_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260224-dpll-v2-1-d7786414a830@gmail.com> X-B4-Tracking: v=1; b=H4sIAKOFnWkC/13MSwrDIBSF4a2EO65Fr6WYjrqPkIGvJBdMDFqkJ bj32gw7/A+H74DsE/kMj+6A5AtlilsLvHRgF73NnpFrDcjxzhElc3sI7MattMqgNlJBu+7JT/Q +mWFsvVB+xfQ51SJ+6x9QBBPM9f0klBVotH/Oq6ZwtXGFsdb6BSt+oYSYAAAA X-Change-ID: 20260223-dpll-40c3c8b2ab38 To: Ivan Vecera , Prathosh Satish , Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Jakub Kicinski , Przemek Kitszel Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1771931046; l=1330; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=YhP3pWD3TXopGx3GMHZR0Qk/xUp7dOSyYuWyrPsIuDs=; b=5u/X65JHjzcU1mGbmNoIxhPiXThwebGfY+M8acfEzq6+k5R2JlrXoX2auxAlF0pKsgz2zw6DH wJJrhLnQJPZBkEqw8InYgP2GA7qo3IVJUdFgM6+0eGkyIiY4cO2pyr8 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The devm_add_action_or_reset() function already executes the cleanup action on failure before returning an error, so the explicit goto error and subsequent zl3073x_dev_dpll_fini() call causes double cleanup. Fixes: ebb1031c5137 ("dpll: zl3073x: Refactor DPLL initialization") Reviewed-by: Ivan Vecera Signed-off-by: Felix Gu --- Changes in v2: - Fix Ivan's comment - Link to v1: https://lore.kernel.org/r/20260223-dpll-v1-1-d99f18c12bae@gma= il.com --- drivers/dpll/zl3073x/core.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/dpll/zl3073x/core.c b/drivers/dpll/zl3073x/core.c index 63bd97181b9e..569c2cda5a02 100644 --- a/drivers/dpll/zl3073x/core.c +++ b/drivers/dpll/zl3073x/core.c @@ -981,11 +981,7 @@ zl3073x_devm_dpll_init(struct zl3073x_dev *zldev, u8 n= um_dplls) } =20 /* Add devres action to release DPLL related resources */ - rc =3D devm_add_action_or_reset(zldev->dev, zl3073x_dev_dpll_fini, zldev); - if (rc) - goto error; - - return 0; + return devm_add_action_or_reset(zldev->dev, zl3073x_dev_dpll_fini, zldev); =20 error: zl3073x_dev_dpll_fini(zldev); --- base-commit: d4906ae14a5f136ceb671bb14cedbf13fa560da6 change-id: 20260223-dpll-40c3c8b2ab38 Best regards, --=20 Felix Gu