From nobody Fri Apr 17 01:44:07 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16C4C37BE9A for ; Tue, 24 Feb 2026 11:19:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771931949; cv=none; b=Ay0Rc24hCWAhQdxe1IJ1KEbl+FwzJyjReqB+SZuXfGSj3DPMcsNnzm5HgQrhH1Dn/Mx5owatuE2L/LMPeCImyrY3UMCvLQRz1UKqctaPjGrFp+q6EwUV9W0KXz0GAs/7wEQlQYr3bnPE9aip9EQADSKm7066gW7aPN4LbFFmi0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771931949; c=relaxed/simple; bh=Yn8IwalODgMCsIH0YR/kNLh6BjFzx49IzvRMHmDCyHQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=p6Wj5YPGgIfEKU/DOWkG80rlW5Sk00FILeNL1ppDPAn6QLLFKNsd6emuluAqdbC+ONFvnPUFLVvwF04gp3F6ld7WKuOaAzROpbSB1GH4X1/7XLrGqbfZafdCZaK5B9yooJC2sciGxB/vWInX3BnMNqnld1tZHvEaRqoxf3kvfsY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bgEEyQtf; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bgEEyQtf" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-8249cb73792so4791393b3a.3 for ; Tue, 24 Feb 2026 03:19:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771931947; x=1772536747; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=Ya5oMEbcI7961RAxDR66eymFlo7gUSyveCMFurue+gY=; b=bgEEyQtfyTPheMU5cVphkcoPaZyajdOk44zAGv6xKzy6ADaYOjEyin8yBVTD/rH3xz 2BnIu1tTpmA9C1kXI1nm7wst9TL8PCHZwE8qM+Aj8nZ4lStbN2fBEa61aTAqG08RBwit l7wXhHL7rWSPhJikACPwBwf2dAX3tjtcG2tHsGxiHjGmwL4BLp2TvxYB0LkqyZA59aKq 48dGHNFh7WBwDvJKdayTSv3x6RXVNI8iTqcTtRxXW4RTwetvhX0Oyn5/HPeQsPJlLghm KRhFV+oj6ckoKw1fFUAtAoZKpDN3Ed+efIsuyReLYguiiagpmnM9jHTX6CERAl45DeeX +B1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771931947; x=1772536747; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ya5oMEbcI7961RAxDR66eymFlo7gUSyveCMFurue+gY=; b=gJpj4OapuAgDUsoJFrIFc1qX1llqJloBEoXrjmOeIb3Ewc6cuHzm7jyEUdzIXg8aTe WS6ugPLNiJUgZzCNC+rLEwmqlaRGDZM0LFiE++XA3q/6pP0kh99GeaK3SEy9fj7MpENC 1ciP1/XTMZiEjdNAevKwCzvv8rSUnrpNxj/7nvMJgoi/7poJtWRvwP+FQRVpRPeEdcXZ kRSNltRhtgEneO5arVx7vsY6bC5nh2Ont9TopgGm+Ij9RI76D/GMCeK/R/nbZyQwNGTm LidNS3o99mO93eaz/jHmRk7WXLgem73v8F/CrWYVHnxlMamQHe8ZIPrjioi8gjBKrda2 YRiA== X-Gm-Message-State: AOJu0Ywr8k7n+N28ICzeUpIwmrAtApSejiC6nNtNs9acASkK8Y1grCt6 j1oraWdPSTOQIiSv3NTX2r6J8j4RQAKxWCqrhz3gA+RNVK7wz7lFabP1 X-Gm-Gg: ATEYQzwLDv14fU92SJTrD5MWqKbj+ePbjci4TDozc6Klwu+631RAdSe0J5sB0QGJmll QWXroewF5xP8VaJU7/64ElBQ/y081LXqrzUwTBGb8uD9iiGPJMa1VjRptyZBXVuRD5r32VwX8L7 6QZZTqdiXz6RSHJtFpkDYvtqqaGN4TDtFULxryOeaum6kcJGMgukV5ARdr32URvzXfANYi3IBDl +2Ux43UWilkvFW3ExfwK7X3zpPBVWzXegb2Fe1+YMXBpVSdJubREELwHkDBHBve7XtXf0is66tx pdiLrulDEdWgOCZCrf8GS7XEiyqZ7ojRGJeH9jcXk8hhiioGwhpNRbFObk7ubVNis707TREKElp qNozUvWt6RhSEZF6crkqIO9DoM4l/C9hN+jtJla7rZ2RALrF4+LVMKxhSXRL+CqSLjazVXjya2C uo1ULTjBo5YE2taRod2O4CRzKLavcAzVzY8Z6+mA== X-Received: by 2002:a05:6a00:2382:b0:824:3725:1493 with SMTP id d2e1a72fcca58-826da90766dmr9536784b3a.19.1771931947304; Tue, 24 Feb 2026 03:19:07 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9008:ba52:a117:e2f3:ee55:ed0d]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-826dd63f1bfsm10343406b3a.7.2026.02.24.03.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 03:19:07 -0800 (PST) From: Felix Gu Date: Tue, 24 Feb 2026 19:19:03 +0800 Subject: [PATCH] regulator: bq257xx: Fix device node reference leak in bq257xx_reg_dt_parse_gpio() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260224-bq257-v1-1-8ebbc731c1c3@gmail.com> X-B4-Tracking: v=1; b=H4sIACaJnWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDIyMT3aRCI1NzXdNEE6PUtOQUI2MTcyWg2oKi1LTMCrA50bG1tQDW7OM xVwAAAA== X-Change-ID: 20260224-bq257-5a42efcd2347 To: Liam Girdwood , Mark Brown , Lee Jones , Chris Morgan Cc: linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1771931945; l=1134; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=Yn8IwalODgMCsIH0YR/kNLh6BjFzx49IzvRMHmDCyHQ=; b=oSV/vi4xOySjkJ/6tePyMa3+bDF25chZakfnwQPtbrJeYCDNX28K19NEfJyxR+vppPDK/PPYY 6JKWTkG7Wb1DOVt8CjraRfjtoPBnsu1s9H9QEnS/3xqTAszreGj+FPC X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In bq257xx_reg_dt_parse_gpio(), if fails to get subchild, it returns without calling of_node_put(child), causing the device node reference leak. Fixes: 981dd162b635 ("regulator: bq257xx: Add bq257xx boost regulator drive= r") Signed-off-by: Felix Gu --- drivers/regulator/bq257xx-regulator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/regulator/bq257xx-regulator.c b/drivers/regulator/bq25= 7xx-regulator.c index fc1ccede4468..dab8f1ab4450 100644 --- a/drivers/regulator/bq257xx-regulator.c +++ b/drivers/regulator/bq257xx-regulator.c @@ -115,11 +115,10 @@ static void bq257xx_reg_dt_parse_gpio(struct platform= _device *pdev) return; =20 subchild =3D of_get_child_by_name(child, pdata->desc.of_match); + of_node_put(child); if (!subchild) return; =20 - of_node_put(child); - pdata->otg_en_gpio =3D devm_fwnode_gpiod_get_index(&pdev->dev, of_fwnode_handle(subchild), "enable", 0, --- base-commit: 779cae956c8316aebc1946ef86ca001f99658270 change-id: 20260224-bq257-5a42efcd2347 Best regards, --=20 Felix Gu