From nobody Sun Apr 5 18:18:47 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7132F3009C8 for ; Mon, 23 Feb 2026 15:53:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771862038; cv=none; b=CGX28JVd7Uk+Fwjw+Bz9+1e7EcacVDL1uZ12vDdXdoJ6QpDB/wtYGdT2ENkFjXt6m9cRWnZROy5S2QWbuT2RqDkYMLsfXoIrKJkHYxTXIpq5aKmqoJ2k863x/yEWyJz0Uk+42O93YSbYCsrl0W6L+DQsubwrJJxyex6OCA8RgoE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771862038; c=relaxed/simple; bh=qkjqYkFTFuAj/C4t0awBSfitUcWKs4RhCgxg9Y4+yLE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=QXT/BVXiNkHgt36xlSLEtCvqLzxwSUYsaC2WC+uoHANSmseb9ghRnBRJ4H3/scyI4drcy27Yr7qX6z1iyyjEMLGFtDp9M+ejjkloiKSZywCqFshaBigeb4xesmZWrSpOKMlc8mPRY9rM/uGiA4FTjMfeqkp7iYdDGi+LREoXxes= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=kwIx1Izv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kwIx1Izv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0E07C116D0; Mon, 23 Feb 2026 15:53:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1771862038; bh=qkjqYkFTFuAj/C4t0awBSfitUcWKs4RhCgxg9Y4+yLE=; h=From:To:Cc:Subject:Date:From; b=kwIx1IzvWyg55u6HMnx/1N6fq+HqIBwYoFd5rvxnIuUOoXIXbQVuvLGn9SoimVeiY ffVQPd15IX1lL5dMt1cv1Gv6oKSrADkzKFX16aRUvLpdC+Rf7J3vcbgncZ94sQQ/hM 90e7snTy2p8hTfR0hJXHz91Iskb0ik+RUXicW+oQ= From: Greg Kroah-Hartman To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Maxime Ripard , Dave Stevenson , =?UTF-8?q?Ma=C3=ADra=20Canal?= , Raspberry Pi Kernel Maintenance , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , stable Subject: [PATCH] drm/vc4: platform_get_irq_byname() returns an int Date: Mon, 23 Feb 2026 16:53:39 +0100 Message-ID: <2026022339-cornflake-t-shirt-2471@gregkh> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1972; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=qkjqYkFTFuAj/C4t0awBSfitUcWKs4RhCgxg9Y4+yLE=; b=owGbwMvMwCRo6H6F97bub03G02pJDJlzKph5cubsuMIlXxmWUryu6vfZt5/OWU1aklNUpBZ2b v4Gjr3HO2JZGASZGGTFFFm+bOM5ur/ikKKXoe1pmDmsTCBDGLg4BWAiD1wYFrSeMMldvtyPQbgy c0500bn7N9OzYhjmJ83k8+xYvVFzRrn7qqQbZzh4D/J1AgA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: quoted-printable platform_get_irq_byname() will return a negative value if an error happens, so it should be checked and not just passed directly into devm_request_threaded_irq() hoping all will be ok. Cc: Maxime Ripard Cc: Dave Stevenson Cc: "Ma=C3=ADra Canal" Cc: Raspberry Pi Kernel Maintenance Cc: Maarten Lankhorst Cc: Thomas Zimmermann Cc: David Airlie Cc: Simona Vetter Cc: stable Assisted-by: gkh_clanker_2000 Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/vc4/vc4_hdmi.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index fda214b5a466..ac1c484c8a89 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -2449,17 +2449,22 @@ static int vc4_hdmi_hotplug_init(struct vc4_hdmi *v= c4_hdmi) int ret; =20 if (vc4_hdmi->variant->external_irq_controller) { - unsigned int hpd_con =3D platform_get_irq_byname(pdev, "hpd-connected"); - unsigned int hpd_rm =3D platform_get_irq_byname(pdev, "hpd-removed"); + int hpd =3D platform_get_irq_byname(pdev, "hpd-connected"); + if (hpd < 0) + return hpd; =20 - ret =3D devm_request_threaded_irq(&pdev->dev, hpd_con, + ret =3D devm_request_threaded_irq(&pdev->dev, hpd, NULL, vc4_hdmi_hpd_irq_thread, IRQF_ONESHOT, "vc4 hdmi hpd connected", vc4_hdmi); if (ret) return ret; =20 - ret =3D devm_request_threaded_irq(&pdev->dev, hpd_rm, + hpd =3D platform_get_irq_byname(pdev, "hpd-removed"); + if (hpd < 0) + return hpd; + + ret =3D devm_request_threaded_irq(&pdev->dev, hpd, NULL, vc4_hdmi_hpd_irq_thread, IRQF_ONESHOT, "vc4 hdmi hpd disconnected", vc4_hdmi); --=20 2.53.0