From nobody Fri Apr 17 06:14:50 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C51B361DB5; Mon, 23 Feb 2026 11:37:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771846674; cv=none; b=RJboxbv2xdjQfxL7ZnBuV0UYJ5b43GOCqwhnLUeYQ0Jkgh3PiAOWRbHCu7Er3CE6yU/B2VvOATBbww76tTihkuPoOqT09MMW1HTjKomJM/R1SNKkXDobhxklYbNQjd+n4Jx9ZiJJfp7hRONlgrnPIoJoLXyXy4ubmZUAlQfoRiQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771846674; c=relaxed/simple; bh=hwEciQS2IYkIhZYn+0zPOpRikRJ+VByuTWR42VvOyHs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QMraHzl/mpRdzgu7TMvnFCLvAOheFmZlNK4jGNxcHq3KwZWZX9xZ5w2qPkgmqewBuGugboz0UxISfgZazHEme9y/U1m9YSd9VxPV9bdexncWuZPeDjS4bQ6K4vJGCvnlvdkftdBNzBt91G8vbarnPiTSSbu1NRHsfHgcBzk6KqM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=V9ejggRs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="V9ejggRs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5809DC116D0; Mon, 23 Feb 2026 11:37:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1771846673; bh=hwEciQS2IYkIhZYn+0zPOpRikRJ+VByuTWR42VvOyHs=; h=From:To:Cc:Subject:Date:From; b=V9ejggRs59JY1s5q01jRgCDNMk0uYDpAG5dF2YIBwo9AIhRU03CWPRb8DKORWYjwZ 8fEOpSie3pEh1zMrMuiMINAXsc8FVtmHnlxrZru0PnT+uerlJHLZK0MUF3mJjCjsBF 2j63PWAAjF2ym9fwrusDL3HJIxB64j+CkdylEwho= From: Greg Kroah-Hartman To: linux-wireless@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Ping-Ke Shih , stable Subject: [PATCH net] wifi: rtw88: properly drop usb interface reference on error Date: Mon, 23 Feb 2026 12:37:34 +0100 Message-ID: <2026022333-periscope-unusual-f0a0@gregkh> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1179; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=hwEciQS2IYkIhZYn+0zPOpRikRJ+VByuTWR42VvOyHs=; b=owGbwMvMwCRo6H6F97bub03G02pJDJlzrP9Wx9ks2hbvkbCnJeD9xqnOoi1+K594/rDS3uPI+ /pe1Dn1jlgWBkEmBlkxRZYv23iO7q84pOhlaHsaZg4rE8gQBi5OAZhIaTLDTMbvhywD519/63D/ lCKLm5vH7dvuGkBRpW+PHsic6ayazH25dr9p5/STli8B X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If an error happens in the usb probe path, in rtw_usb_intf_init(), the usb interface reference needs to be properly dropped, otherwise is is incorrectly increased when returning to the USB core. Cc: Ping-Ke Shih Cc: stable Assisted-by: gkh_clanker_2000 Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/realtek/rtw88/usb.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireles= s/realtek/rtw88/usb.c index 433b06c8d8a6..36ac20039ce2 100644 --- a/drivers/net/wireless/realtek/rtw88/usb.c +++ b/drivers/net/wireless/realtek/rtw88/usb.c @@ -1046,13 +1046,17 @@ static int rtw_usb_intf_init(struct rtw_dev *rtwdev, =20 rtwusb->udev =3D udev; ret =3D rtw_usb_parse(rtwdev, intf); - if (ret) + if (ret) { + usb_put_dev(udev); return ret; + } =20 rtwusb->usb_data =3D kcalloc(RTW_USB_MAX_RXTX_COUNT, sizeof(u32), GFP_KERNEL); - if (!rtwusb->usb_data) + if (!rtwusb->usb_data) { + usb_put_dev(udev); return -ENOMEM; + } =20 usb_set_intfdata(intf, rtwdev->hw); =20 --=20 2.53.0