From nobody Fri Apr 17 07:13:12 2026 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E205237BE60 for ; Mon, 23 Feb 2026 22:05:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884308; cv=none; b=BK2yrBcgHv9+bDVmNZ+4Rz9bo7QmqJkzx/DmVMd9QWuniFQKmWW4aGUyY7WPJMzHGE9VNMWFww6PCmFSl+nUKJ4RX9vPriGtOxXcxz0NBwKZ1Bhbu9ZBaGVaYklqwzsPKZBBi6LleyAOsBy/c8rZ6saAxUiwnpNTp0DqqpahkFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884308; c=relaxed/simple; bh=hRGB9oVjZrDC5m4XZKHO2WMi1uqtMLbDhKE3faTS22k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EgbGpOrWp/q4+54OBBJFW/vFITLqV3zgjiEH1aTy7a0UZy4T33j26d4w32XJE0xnWqNCQgioOuyRrS4gM6zIgQLaragoehrcRiDTOLlIpsyA0BaCoIyHPB6ZFi2ClS29eMazpAuyixFQwbAvuF/vOrQxUY7ivGI+azqGp3GZQIk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e5pNyYux; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e5pNyYux" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b8f86167d39so615144966b.0 for ; Mon, 23 Feb 2026 14:05:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771884305; x=1772489105; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NJnwuXlwPqYBkjbw57cs4hmL2PjDi3OofAmEvUVEuyo=; b=e5pNyYuxf0xHsF+XHzH0+Bhgh7yFJy58SnPuA5PH4pmpJl3fXe/OEFdVO86cMFyozs FnxMJxgDOKBEgCvNmMMEL8cerEMk91LmtZG3IvxHSOOCJuGTfr6wwePKf54KJ7TWxXc1 3NXARy8GwkUi4TRFnU8VFwXbyHIVRmn+C/jwzBdRCDIOy0B++hxrolCH0gWRf/Wv2ghC SaA7yTUad6y4D8UCoaz8mdR6ITUX2wUZhPvZYEY8V/xTeFhe0pGuXdWMwKseQ8SEJjwA Mj28g7lFdgW9xPAx/67m+IzQxuCFgB5dEb8ytGWfw7+DG2N9QRcM9mVXyMrhzZAVPYCS /tXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771884305; x=1772489105; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NJnwuXlwPqYBkjbw57cs4hmL2PjDi3OofAmEvUVEuyo=; b=HdHMjGyYa45mITmxJiGz+DfJyOBkkG3SHcfdB6wTKZi5OzYsA9TRBki89IlE+azBHo RL6YrcMi42Ixhcz6JEAIlq4XLhyEB5F05TLlZXD0U/6IIZRa4jfYO9QvFRhQhR0WavF7 duKCTgCkCoHLq2Us5zUBtdqKz0UXmhpCMFZi1mpUTqKjkxt18zBOmtosCxmYo965CTzF YU24YAqPC/vzuJ3sOa9ZCKTvnFFjLwv+alKZUFswAnDWWB6Fe8PujaTpS3WUVw3+aLZB JL511WPVacToAhBLyOLFWk19j4bMNcifNnFbml1hKkWfSe759plbMbq8RBilgLCIBJU7 ZvnQ== X-Forwarded-Encrypted: i=1; AJvYcCWUAXAhiXp2P5jyW2aTchYph6yOVwO/e4jjU1tH0B5yyvHFItIcV658gC4RJA1TAyTEvFIp0YJMOGCL/30=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/ND8rnRP973NkXyR9YD51XEcjOnkt5UV5a4Z29xl8CfbNZ7U/ DSOVVi8SfG5l6gP4R9rG2kpnkhr8cgwKv5M9n/+f/5okUtVbSxyMroTj X-Gm-Gg: AZuq6aK26nAt6yb6saAIAl/JdrhrrQNUsoBvEziaNu2fiwpMRcTftJ1wwIrPiBmLMBR rE1MrFVLuFPQQ+EDQ2vzrIT4JeBrFjtWwa5AXwOG2NDZdmIsv8OJ6Wsh4hwUlompZYyUAkae0CS vWEDT7myH1ga7l61ka46rVxr6QaCnnCuchXCNlML3yBxc1BGm6Sj/VyAkWWrHde7nzAFRasrvNg gAYO2XWMVphuz0bbAaBtJaHv6VqQPQdZTb44eDctmpy6x8xNsS8C4GlBlAqvSn438Xpwac1rgmT esvX1qXzmujMey+cuYiXhvHNP+W/FrelUbhCtYuU9PztiMbXAweHSJpBsrvIhOfHk0GZi1l2W4s TkMO+jhmZfPJMY53uRyIvjqB2TEJheT3kKpEJNXAtKF/WHIewks9rK2EowyX28hLDNgZfdORV8O 9QOx1EoqFV0U03RMHbmbNBV8KRFWTbz2nO1c+1ECE+LefqSJ3pvQYoe6b60/pWheBlO9WpIeAj/ SwdF/vBmWS1DxPIaV+tsjvwQvJeghfgcCtEzF5ZSokyDrXWEGDWw3X5kp2CiBE81NmRM/shY/bp bYdeGw== X-Received: by 2002:a17:907:9288:b0:b76:f57f:a2c3 with SMTP id a640c23a62f3a-b90819214c4mr711516866b.12.1771884305230; Mon, 23 Feb 2026 14:05:05 -0800 (PST) Received: from cs-874966990260-default.europe-west4-a.c.i2f7e30109524dc12-tp.internal (230.86.12.34.bc.googleusercontent.com. [34.12.86.230]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9084f191b9sm359394666b.67.2026.02.23.14.05.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 14:05:04 -0800 (PST) From: Artem Lytkin To: FUJITA Tomonori , Andrew Lunn , Heiner Kallweit Cc: Trevor Gross , Russell King , Miguel Ojeda , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Artem Lytkin Subject: [PATCH net-next 1/2] rust: net: phy: expose genphy_config_aneg() Date: Mon, 23 Feb 2026 22:05:00 +0000 Message-ID: <20260223220504.2102-2-iprintercanon@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223220504.2102-1-iprintercanon@gmail.com> References: <20260223220504.2102-1-iprintercanon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add genphy_config_aneg() method to phy::Device, wrapping the C function __genphy_config_aneg(). This is needed by PHY drivers that perform custom BMCR configuration before calling the generic auto-negotiation setup. The wrapper calls __genphy_config_aneg(phydev, false) directly since genphy_config_aneg() is a static inline function not visible to bindgen. Signed-off-by: Artem Lytkin --- rust/kernel/net/phy.rs | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/rust/kernel/net/phy.rs b/rust/kernel/net/phy.rs index 3ca99db5cccf..5ccadc5e2579 100644 --- a/rust/kernel/net/phy.rs +++ b/rust/kernel/net/phy.rs @@ -276,6 +276,15 @@ pub fn genphy_read_abilities(&mut self) -> Result { // So it's just an FFI call. to_result(unsafe { bindings::genphy_read_abilities(phydev) }) } + + /// Configures the advertisement and resets auto-negotiation + /// if auto-negotiation is enabled. + pub fn genphy_config_aneg(&mut self) -> Result { + let phydev =3D self.0.get(); + // SAFETY: `phydev` is pointing to a valid object by the type inva= riant of `Self`. + // So it's just an FFI call. + to_result(unsafe { bindings::__genphy_config_aneg(phydev, false) }) + } } =20 impl AsRef for Device { --=20 2.43.0 From nobody Fri Apr 17 07:13:12 2026 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86FF437BE64 for ; Mon, 23 Feb 2026 22:05:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884308; cv=none; b=fkhJKdcDJlJF2llAOK0V7fX9tajXQWoRJfhyKiXjPDTe5etpY+WtQfIrgE5t/skx+ctZk7gkrBPam9sJfI1T0iAROZ+g9nxiu3W37U20OjgY/ExuOxpQFqyqZLalbfW0CmYpy736mwvcPLcTN1+PBbyoMBm6vjOMKf2hKqQneQ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884308; c=relaxed/simple; bh=6rrKwA7t2xdnfxQdEHWUilDFPRm0gP2abwyKcFsi1z4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hxjWX+1rnUDZLi57ysewanmBW4z++3g4oojTMXwlDUppg5gdFr6bD4g4s0DGLQqr9j4BkRZ050F2xgDdAYWzCgy/bAxus7aSseM3aMup7YaVpxkJzA+k6vsRlCsM1iVGMlsSaUr9GvpSvAxJGlSdeGwBWhgdgvPmKxysFG9XQ4I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fFs7CI6c; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fFs7CI6c" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b8d7f22d405so764660266b.0 for ; Mon, 23 Feb 2026 14:05:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771884306; x=1772489106; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Em4vcQtlpeRbVR/RxCYxW/F57zyFMmk1V0YQNclS9kA=; b=fFs7CI6c4y6EvfLMVIy2PVMDG4ceE5hvJ2vAUJwosNx6Fj0XNY3F9ScvF3QiXFIj+q STUYwq0ALicMOeocRtdt48KFZjO+bWIXx7WGqW3reTu5Zl35Vpj4KkBpGIKVpVtm0LhQ GBRioi8mT2DMEkzJlW6qeBe7bZ4fhT/xk/xb3iRoK1AzVhDXnAf5Nzyt13QABjjfpYFv bwkYZZ6B5OBpXftnWVdy6C6UIVje5iX2daEskUDZg+yMAQ2QBq7hthibmf5C/Kk8DMu7 o+rYg4K5nuR7y+9yCuXANgOntMCfHSqGiRXQxoxwhVNT02gZsqcNEOb+mHCo19HOiO9D u28A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771884306; x=1772489106; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Em4vcQtlpeRbVR/RxCYxW/F57zyFMmk1V0YQNclS9kA=; b=RFpBdM4lQbaNh4VjBPIJiTivf7VoCSB+ZiA2x8WhveaeTAfUywBdGzNW9WJKjZ4BTl cWESygJ9/yvp+H3Ht2+Dero48LFYUIAnc/jdq0aoHRzY3AJvtbddI2X4SnFf6s2aDpRy N5eYPJjscU3Ttin5FVQHdhxhZGzR4W+8822YWU82QnBGT7SF1tDKM3yNmMWGB8mWIuGa Y5QP7d10Mweu8HucIOaI2brDVufevHiiDQW+gK/S1+v+oQ5MtwY0jazc+BAgSz03iXNv xMgD4lE98QWtDBtr1gqAo57uz84BMi1pL54NNxnXZT5ipvcRxDPBwOpKOLoTLr7KFwKa mIXA== X-Forwarded-Encrypted: i=1; AJvYcCWdQoOUzSqtakZG7g9u7eU7wHMAatQzdvjaq0JACMRPMu0IwtbVovm7UmnObe4I1yvlGDg/DCSHIC9n900=@vger.kernel.org X-Gm-Message-State: AOJu0YxN7mDK+Gd+KCMDD6GZLbWs5BqbOLGEcRiQaPhtZM/AryfTHNkM 9jMorGUGU3XvNkrGDFa4uQFyHIoinYRXuj2MZ5cScsvVJ58izzXCigzv X-Gm-Gg: AZuq6aKWv3b3SZ3NvBPlqQF6/+fcpnDMQ9S1iFFZVDhFppIs8HJeJ9DIbiqAKUPY/h8 2uvgZ7N1fGOY1y4COEO8i1WTi/AnzSwoQ5kYBkNPj+GVUENehYT9fzS2y7eqMLxHjZt7cTTMDpz ORPhoo2AUh4Xc7u2j2gIe/CmGSEgZt5OqLWy7VesPzEuUSljocpVNkPyOWYkX8C53K1mHlYx897 sNAPr6lYz4HnDz38sM3F0qIJaesiFmAU/U/2SR4LA/lgSNlb2UIjIFxd0PVOaxPpISRqgrMCxAl lPdGzwJ4GvgyT0dMJRjFsC/PnhtbyG51Sc5/NO2f0SSVnfFOHMyPGbADrz4VPNXXiC17lCl2BpO 67cYcjedHhwAr2Sr+GwPdiuYyvgIKK2Cs/7enffjIZsQmjwrlONWqufVv7sSqmz9iIobOBzptfV 8rHZyYHGyZpf6NRA4lG9M9ysZbTgLfkfWBOQDIU9cwvw6aVNjQ4Q8nZsgxNxgnD+fMd+cmTumio ZDbnNsTxqtzx7dvTdp1FB+eerjYLPFO1XkjtP1GDMaT84Go0IdMO5kA5veeRi3kc6sCFcs= X-Received: by 2002:a17:906:9f85:b0:b8e:36ec:88db with SMTP id a640c23a62f3a-b9081a40e99mr609037966b.22.1771884305881; Mon, 23 Feb 2026 14:05:05 -0800 (PST) Received: from cs-874966990260-default.europe-west4-a.c.i2f7e30109524dc12-tp.internal (230.86.12.34.bc.googleusercontent.com. [34.12.86.230]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9084f191b9sm359394666b.67.2026.02.23.14.05.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 14:05:05 -0800 (PST) From: Artem Lytkin To: FUJITA Tomonori , Andrew Lunn , Heiner Kallweit Cc: Trevor Gross , Russell King , Miguel Ojeda , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Artem Lytkin Subject: [PATCH v2 1/3] staging: most: dim2: replace IS_ERR_OR_NULL with IS_ERR for devm_clk_get Date: Mon, 23 Feb 2026 22:05:01 +0000 Message-ID: <20260223220504.2102-3-iprintercanon@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223220504.2102-1-iprintercanon@gmail.com> References: <20260223220504.2102-1-iprintercanon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() never returns NULL, so IS_ERR_OR_NULL() checks are unnecessary. Replace them with IS_ERR() for both the "mlb" and "pll8_mlb" clock lookups in fsl_mx6_enable(). Signed-off-by: Artem Lytkin --- drivers/staging/most/dim2/dim2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index 92c7a7d8fe7e..cea1ba99caf7 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -921,7 +921,7 @@ static int fsl_mx6_enable(struct platform_device *pdev) int ret; =20 dev->clk =3D devm_clk_get(&pdev->dev, "mlb"); - if (IS_ERR_OR_NULL(dev->clk)) { + if (IS_ERR(dev->clk)) { dev_err(&pdev->dev, "unable to get mlb clock\n"); return -EFAULT; } @@ -935,7 +935,7 @@ static int fsl_mx6_enable(struct platform_device *pdev) if (dev->clk_speed >=3D CLK_2048FS) { /* enable pll */ dev->clk_pll =3D devm_clk_get(&pdev->dev, "pll8_mlb"); - if (IS_ERR_OR_NULL(dev->clk_pll)) { + if (IS_ERR(dev->clk_pll)) { dev_err(&pdev->dev, "unable to get mlb pll clock\n"); clk_disable_unprepare(dev->clk); return -EFAULT; --=20 2.43.0 From nobody Fri Apr 17 07:13:12 2026 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BF5837BE7D for ; Mon, 23 Feb 2026 22:05:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884310; cv=none; b=aRvwdLtS3yhrDQDm11IlJF6x3UdecbR81eR3PUb9OpKcw+s69TOoc0TDh4yn0YTdFojHd+JKpeeCkV2Z8vF6WxDSefi7w+Txs3I6QOCmkG3vusYaUghlgiFo9i7JA+7XxMaJIWigRJ50Qlxt+cSK8pRWOmPYQQqZGEZvBTKK2eM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884310; c=relaxed/simple; bh=lYSFLw0xah4h/+68xrRS+X6hzYryo1L2cUiMAzxuTP8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DeV8alrA4knyfIX7fXazzIzOm4E5OqVInJnorJUHhWhgcYrb6g2YwZk6HLIIjbyQR7LGlA9l7yF60z6HqXDQuvWtKLRT6cZsCv/ULFJuwkPf/PQ9XAxflbWY2taEuMF2WCZ0WH6nLLXGouEHqPgKhFJ9V/NvTQEsgh3G12eo8zI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QowjejyR; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QowjejyR" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-65c0891f4e9so8510764a12.1 for ; Mon, 23 Feb 2026 14:05:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771884307; x=1772489107; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GgYaJHOEUtfkRSeV4/ucyw2w3tzEF0ffgSH0n+B20gI=; b=QowjejyRTTc9BS6FZeN7E9Y5jwGARU7qjwgy28bIrUw0z4c3MdRo77dMOjApo1nD4u PuE+7WdMXXadbLmVAlEskYfZbW5oUTYSbeSzWsF4HPjeZDp9B+Q1DKNBr+cHCZf40CWV H+IcDC8xlwbzHhw2YtsmhWag46ZaSoxKJ6o8wUtV8grqiyBSuT132lVUPnv4aA2aQ9sr +PhidkZOwx/MTQpvNuy4JfUxyeclUnYH4fvVhLLkZqfcadQa1NQHhewdOifecgnRuMYx TFjbTXuyGZDQXx2lEy+F3/IsPHKy6Td2OaHfhAbBLnIpJiq3r651EG3o6T6OuKEX9yM0 LF8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771884307; x=1772489107; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GgYaJHOEUtfkRSeV4/ucyw2w3tzEF0ffgSH0n+B20gI=; b=QEM96vbPPp3nji8sz1dfAc57CJ5AhUzhK4SAoX/dU6vrCZUADj2RZFeyAsiEKep6nH XQzUhl+whnugqlutsHGqwI6o2QLjVJQ6P4lgO+oEqb0QvPpTPiiI5edCFj9LLKjSedxe wKujJmMtVsxzC+xSZ6myNGlaFLqgDDDz5Usg0V9BH8ae1TDI6PXEDjyf1s8aJklidmUX 8EzSwGCTTESFahIc9hizdDnkjgn3wNhfJt1nbyQLrB0GgaS5eV76S7Drqgz5UA/k+n/K OKV7D0BoVGl5kuS4ZHutDsRgBh3oyfF/y2ukwd3MqWoM72LsWc75QXKfAZvT90mfLxea E60g== X-Forwarded-Encrypted: i=1; AJvYcCVYLohwPN0ArdKGTzhcgponJpfMunCP5w8ajIxVLN7wsvZy9cBaZ+rkdWPUOOC5jzMkqfASLrrE5/5JhkU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxo/rwhzCcLY4tSLvtbpsMcx3lxL93QzLGV73ZELP0WnsiHX+9P ufXvzEurSvxPes8kOQuif/egQ2apKoq+EKr2k3CKU4SKl+l4MebLRUVb X-Gm-Gg: AZuq6aLyGKg4hR4p7lbmOpw0WxeIJD/nRpO5MnzJ3eLh/mqdvxwswx8so95QU+33H48 AVb3a9O/+fDQXJP4TqkN6wSKX3ey7Q7L97Ju4JS8Gbx2Nmx3VHCvyw6ydYJ083LUiyQNixsY55T 6y4SjVDh3rYt66QNn/6pwqeQ7CBCAgGrWCPf6SoHvVHLtzZlegAA30cvnLFRD6T+Ku21PLR+hI7 3o0INvq7ccgt7lb6zwClx3/pD5O1leqD5Bv5fh7DsYnspRAPdfu9OV93k9+kbH37LdYvQoJK2qq G2Y/TWJsL8XsPADC4Jwfwq7bpYYbVKL2Ns7csCYVlrmqsG0HlemGA3vtXelk+mLovxGZyrPA4nM jfCaGqOQAV9IrKTztbmXd8+YpejgJnwJLHeVaKDgtZ1sf6PTqpqulYusY7IBFjBQfAqtnyHweEY rwqJFrcMsIEVdJyQpaaqlpsHNKC9gQu/NnlF/JFRru4eBV7VZ0tOfb/1HeLrEdzeGnTEhYxbDYA 4lAXY2AUb6oReor6K7ItOCpPacbfIGeEJcffkUNaLWLLqHR7nD+d4bK5bzQn0id4AyXsGo= X-Received: by 2002:a17:907:a4e:b0:b88:317a:3f40 with SMTP id a640c23a62f3a-b9081aeef7amr610431266b.38.1771884306860; Mon, 23 Feb 2026 14:05:06 -0800 (PST) Received: from cs-874966990260-default.europe-west4-a.c.i2f7e30109524dc12-tp.internal (230.86.12.34.bc.googleusercontent.com. [34.12.86.230]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9084f191b9sm359394666b.67.2026.02.23.14.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 14:05:06 -0800 (PST) From: Artem Lytkin To: FUJITA Tomonori , Andrew Lunn , Heiner Kallweit Cc: Trevor Gross , Russell King , Miguel Ojeda , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Artem Lytkin Subject: [PATCH v2 2/3] staging: most: dim2: use dev_err_probe and proper error codes for clock Date: Mon, 23 Feb 2026 22:05:03 +0000 Message-ID: <20260223220504.2102-5-iprintercanon@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223220504.2102-1-iprintercanon@gmail.com> References: <20260223220504.2102-1-iprintercanon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace hardcoded -EFAULT returns with dev_err_probe() and PTR_ERR() when devm_clk_get() fails in fsl_mx6_enable(). This ensures the correct error code is propagated (e.g. -EPROBE_DEFER for deferred probing) and avoids log noise during probe deferral. Signed-off-by: Artem Lytkin --- drivers/staging/most/dim2/dim2.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index cea1ba99caf7..e4c8b4995c61 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -921,10 +921,9 @@ static int fsl_mx6_enable(struct platform_device *pdev) int ret; =20 dev->clk =3D devm_clk_get(&pdev->dev, "mlb"); - if (IS_ERR(dev->clk)) { - dev_err(&pdev->dev, "unable to get mlb clock\n"); - return -EFAULT; - } + if (IS_ERR(dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk), + "unable to get mlb clock\n"); =20 ret =3D clk_prepare_enable(dev->clk); if (ret) { @@ -936,9 +935,9 @@ static int fsl_mx6_enable(struct platform_device *pdev) /* enable pll */ dev->clk_pll =3D devm_clk_get(&pdev->dev, "pll8_mlb"); if (IS_ERR(dev->clk_pll)) { - dev_err(&pdev->dev, "unable to get mlb pll clock\n"); clk_disable_unprepare(dev->clk); - return -EFAULT; + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk_pll), + "unable to get mlb pll clock\n"); } =20 writel(0x888, dev->io_base + 0x38); --=20 2.43.0 From nobody Fri Apr 17 07:13:12 2026 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4239237BE72 for ; Mon, 23 Feb 2026 22:05:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884310; cv=none; b=e7m05PLNuGaC9SzUO+fteYVy2dg8FzaTYrmVXolEZtXMaEC7Rt1bdHRbI8UqHZRi0S+yrD7jYc9yizw8FWOzk26zAyS9cAF78kNrpgl+vAysGbJpuu0Tz6kjHydK2AudixBHUjv/MRf27Gf0xc5I83h8QdpUltxQCmUpvc9gMZo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884310; c=relaxed/simple; bh=DLo8ybjKAeliYnp5FSPsB19NqPjD3Xu29SYo+c/oWr4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dnoNGu6D3kViKco/t4d1oF6u+Zw8CR9QtuC979/XlN9cH2OMFZOVBrhZolT3XH9HVw3dMlm7Wv6XOF7RcGTYQDqHEJkuQj5HbeX6UzquoR8BLHXIEfDa9RLxL8q3FSJ8QvW7OGSLPnpUdT+MHtR3EWbQr0upGAg6yNq9NSo5zRE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mo4edKX+; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mo4edKX+" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-65c5a778923so7392536a12.2 for ; Mon, 23 Feb 2026 14:05:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771884307; x=1772489107; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yqhn3ZOG/BZpB/hKPwpYI1TGTRMCqv7M1e3G0fpG16Q=; b=mo4edKX+xhX4FCeFSP+BjzVlzepc3vkeBnX3N3XPn65rdfIR0GXu04JMDkiUNe2bp8 H0usNhBDT3fEWTcFz52eWPEOVfbVLGFawiYjPP2spIYvsjXVKdW+HZkkaN46SwC9Xn6x WAYf4QKpHkdaTxGM7eZPmVsrV0N+n6PfhdhDdZgaQH8IOdLso6JPKrfD3Cvy846CEMCg Kknmvlmj6T0GA6a3sr6zu+26lRjKAJ6xRqV2B0swzWq/W8zJPAbiNFdsvW8+fbTL6Vyv ez6LABtN0E7jkBerSaOSPPoNEDD0EFzXMjzpgUyTAd2dbiVYct0AVZM82TT+BAPbdoKH 9Owg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771884307; x=1772489107; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yqhn3ZOG/BZpB/hKPwpYI1TGTRMCqv7M1e3G0fpG16Q=; b=ZNWqhbXcAEkudTVibx+uHOih7GouyUGtyAbsH+BkT7cmMQdFE0J3hJLSOATsAbgvxc g7cz370Le/t6pQy7+vH6UxZX+ZFizhJEJ9E1YX4Y/1OcSbjDTFc8O9w+ffeC2pCz7bve /2GG91i/cYrkbY9OOjDF+zAMn5rZ7Jsqggag56VPkTiIhYXYgeNFwcJ2QW3ngkZGf25O RbfL8gpf4VU+dmr+/+uc0Up+q1lG1wzWjfY4b0dDx3uk/iX+KbFnsTMxEgDPciCb3jii fwLON+/jdFBpQhpK9M3Jge+hQTZ6t84vgApkRCJznLvo9Zg04r3gGgeOafyXPVlQaoIn zd/A== X-Forwarded-Encrypted: i=1; AJvYcCUppIlOX9U7bhN+zY/XO8ElRPdKNzO4SOnANPe72W0LBpDLo8ovSH3NbbBSIQWK14kG1zQw5aZRDmhE2fU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3bq7LrnJffzahqhR3H2p/F/SoZPzxKiCVqopwJRRnaC4abmkC Ws6+48uMFVGerZ02YRJdycFaseqx5pGLnK+AedjMq79L6LSdbiAt3tq+ X-Gm-Gg: AZuq6aI3PrAUmVSDHc2M04TBR3W00+6UnCvhiuf+XA0KLlJExzoEW39K3wx0LBKGwww ooTSjkttUHilO5z0EEPbvQeNnL1YafZJbQ2PWQjQFQi6g+MRUMfHF/f6eTUuyzExYmvzEwOte6B 35O1fsnaPJfXYIgZO6c3wb7hiaD0KJnHAtC9NapG7ly+QJGVQsgTddqRcNQm2VYAxCpFGf86Ldz Hy2x/CagIOcwHGCSVhnzW85lJaQNJ+iDyUk49ln7dbWsPgaDyXayiRArscXtg7NJRWTfhqEqWhN 0WLE22KQ5NvviZm1AX9JcauuztqWf2zbWKZkwxhS2H7mcyGvRF/oqiM3lmPWzKYzbL6CODSWwGV hNkBBuU3iA3E0B4h3BXAMNGbwkfnFgK6Rdw1GY2Oj1ol4Ze+yfEsM3Rfp4bUBu8zIOAmS6ZahHu uVhby9nC9dr8Owt3YO6r2Ownqs5QQ/cYfG27DYUErqb/EdDWZvuxA7MRE/rOTk0uPIiAfg9rx0x vSzyIp+IEJHu11b5Yc+19HtoiUSoPAxRetcXOdV40wYCbhhAHL3Z5AcHOP55neNrSRm+Cs= X-Received: by 2002:a17:906:c153:b0:b90:bc06:2abf with SMTP id a640c23a62f3a-b90bc063f00mr168485366b.4.1771884306385; Mon, 23 Feb 2026 14:05:06 -0800 (PST) Received: from cs-874966990260-default.europe-west4-a.c.i2f7e30109524dc12-tp.internal (230.86.12.34.bc.googleusercontent.com. [34.12.86.230]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9084f191b9sm359394666b.67.2026.02.23.14.05.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 14:05:06 -0800 (PST) From: Artem Lytkin To: FUJITA Tomonori , Andrew Lunn , Heiner Kallweit Cc: Trevor Gross , Russell King , Miguel Ojeda , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Artem Lytkin Subject: [PATCH net-next 2/2] net: phy: add Rust reference driver for ET1011C Date: Mon, 23 Feb 2026 22:05:02 +0000 Message-ID: <20260223220504.2102-4-iprintercanon@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223220504.2102-1-iprintercanon@gmail.com> References: <20260223220504.2102-1-iprintercanon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a Rust implementation of the LSI ET1011C PHY driver, equivalent to the existing C driver in drivers/net/phy/et1011c.c. The driver implements config_aneg and read_status callbacks using the Rust PHY abstraction. The Rust driver can be selected via the ET1011C_RUST_PHY Kconfig option, following the same pattern as AX88796B_RUST_PHY. Signed-off-by: Artem Lytkin --- drivers/net/phy/Kconfig | 9 +++++ drivers/net/phy/Makefile | 6 ++- drivers/net/phy/et1011c_rust.rs | 70 +++++++++++++++++++++++++++++++++ 3 files changed, 84 insertions(+), 1 deletion(-) create mode 100644 drivers/net/phy/et1011c_rust.rs diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 7b73332a13d9..5271898a38f7 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -254,6 +254,15 @@ config LSI_ET1011C_PHY help Supports the LSI ET1011C PHY. =20 +config ET1011C_RUST_PHY + bool "Rust reference driver for LSI ET1011C PHY" + depends on RUST_PHYLIB_ABSTRACTIONS && LSI_ET1011C_PHY + help + Uses the Rust reference driver for LSI ET1011C PHY + (et1011c_rust.ko). The features and behavior are + equivalent to the C driver. Selecting this option builds + the Rust version instead of the C version. + config MARVELL_PHY tristate "Marvell Alaska PHYs" help diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile index 3a34917adea7..491469457a67 100644 --- a/drivers/net/phy/Makefile +++ b/drivers/net/phy/Makefile @@ -62,7 +62,11 @@ obj-$(CONFIG_DP83TG720_PHY) +=3D dp83tg720.o obj-$(CONFIG_FIXED_PHY) +=3D fixed_phy.o obj-$(CONFIG_ICPLUS_PHY) +=3D icplus.o obj-$(CONFIG_INTEL_XWAY_PHY) +=3D intel-xway.o -obj-$(CONFIG_LSI_ET1011C_PHY) +=3D et1011c.o +ifdef CONFIG_ET1011C_RUST_PHY + obj-$(CONFIG_LSI_ET1011C_PHY) +=3D et1011c_rust.o +else + obj-$(CONFIG_LSI_ET1011C_PHY) +=3D et1011c.o +endif obj-$(CONFIG_LXT_PHY) +=3D lxt.o obj-$(CONFIG_MARVELL_10G_PHY) +=3D marvell10g.o obj-$(CONFIG_MARVELL_PHY) +=3D marvell.o diff --git a/drivers/net/phy/et1011c_rust.rs b/drivers/net/phy/et1011c_rust= .rs new file mode 100644 index 000000000000..57aa50caca47 --- /dev/null +++ b/drivers/net/phy/et1011c_rust.rs @@ -0,0 +1,70 @@ +// SPDX-License-Identifier: GPL-2.0+ +// Copyright (C) 2026 Artem Lytkin + +//! Rust LSI ET1011C PHY driver +//! +//! C version of this driver: [`drivers/net/phy/et1011c.c`](./et1011c.c) + +use kernel::{ + net::phy::{self, reg::C22, DeviceId, Driver}, + prelude::*, + uapi, +}; + +kernel::module_phy_driver! { + drivers: [PhyET1011C], + device_table: [ + DeviceId::new_with_driver::() + ], + name: "rust_et1011c_phy", + authors: ["Artem Lytkin "], + description: "Rust LSI ET1011C PHY driver", + license: "GPL", +} + +const ET1011C_STATUS_REG: C22 =3D C22::vendor_specific::<0x1A>(); +const ET1011C_CONFIG_REG: C22 =3D C22::vendor_specific::<0x16>(); + +const ET1011C_SPEED_MASK: u16 =3D 0x0300; +const ET1011C_GIGABIT_SPEED: u16 =3D 0x0200; +const ET1011C_TX_FIFO_MASK: u16 =3D 0x3000; +const ET1011C_TX_FIFO_DEPTH_16: u16 =3D 0x1000; +const ET1011C_GMII_INTERFACE: u16 =3D 0x0002; +const ET1011C_SYS_CLK_EN: u16 =3D 0x0010; + +const BMCR_FULLDPLX: u16 =3D uapi::BMCR_FULLDPLX as u16; +const BMCR_SPEED100: u16 =3D uapi::BMCR_SPEED100 as u16; +const BMCR_SPEED1000: u16 =3D uapi::BMCR_SPEED1000 as u16; +const BMCR_ANENABLE: u16 =3D uapi::BMCR_ANENABLE as u16; +const BMCR_RESET: u16 =3D uapi::BMCR_RESET as u16; + +struct PhyET1011C; + +#[vtable] +impl Driver for PhyET1011C { + const NAME: &'static CStr =3D c"ET1011C"; + const PHY_DEVICE_ID: DeviceId =3D DeviceId::new_with_model_mask(0x0282= f014); + + fn config_aneg(dev: &mut phy::Device) -> Result { + let ctl =3D dev.read(C22::BMCR)?; + let ctl =3D ctl & !(BMCR_FULLDPLX | BMCR_SPEED100 | BMCR_SPEED1000= | BMCR_ANENABLE); + dev.write(C22::BMCR, ctl | BMCR_RESET)?; + dev.genphy_config_aneg() + } + + fn read_status(dev: &mut phy::Device) -> Result { + dev.genphy_read_status::()?; + + let val =3D dev.read(ET1011C_STATUS_REG)?; + if (val & ET1011C_SPEED_MASK) =3D=3D ET1011C_GIGABIT_SPEED { + let cfg =3D dev.read(ET1011C_CONFIG_REG)?; + let cfg =3D cfg & !ET1011C_TX_FIFO_MASK; + dev.write( + ET1011C_CONFIG_REG, + cfg | ET1011C_GMII_INTERFACE | ET1011C_SYS_CLK_EN | ET1011= C_TX_FIFO_DEPTH_16, + )?; + } + + Ok(0) + } +} --=20 2.43.0