From nobody Fri Mar 27 01:29:46 2026 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3480637AA92 for ; Mon, 23 Feb 2026 22:01:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884105; cv=none; b=VvHAiKrutDybLQR+aX+Hrop/kCdE/kvIDJ4DOT2aISCJgmKD9O7PvwatMG6rfFMyXJlGjfDdmNTziAZlGaG+bGFA1qj+ygYCJjGaG4iY3xl1JelasgrtLnxCI6iu7a00sTxzBswUhIsOE/NCoeZztkLFWFfjnebWi3dAk/Q6aBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884105; c=relaxed/simple; bh=wJkHLGHr1vIYneUltjp7DlaJq9UNUc3ArOYWaOR2B88=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HRBl9w8LjeSQEXWU01PASs6G34QdrPa6i9UcHJ0e3L4XrdXEx5a8FYaPmk2mbIvXO4ZKGygJOXWY/sDW8KcPkRH8+YTz/5s84oOHUBCFArubL0Fd19UjojzV6p3kWqCKp/g8xDP7JM1cfw8rhbFv6Iklny7R5klWhf1lfuX3XiE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=E0pmcYlt; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="E0pmcYlt" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771884102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=co5vlG3KCy9QyOL0DkO0DC8hdZge1bfbh9udEqHybS0=; b=E0pmcYltHkiJbsbFQhvmNpCjFZHQRJEOXcg3Cq8SVTZoqCWPM73Ur7SQvqNC3YQmBjKzlS oOangj8R6iluWFgeJZU2SSC3NR8xO2sYxUlN3+zR+Z5Zf3ys6Xa2q8Hh7cW8DjfPvfX/h4 wiy13Ien1bkeZY72UG/7QUsZVllnU+s= From: Bart Van Assche To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , YiPeng Chai , Hawking Zhang , amd-gfx@lists.freedesktop.org Subject: [PATCH 08/62] drm/amdgpu: Fix locking bugs in error paths Date: Mon, 23 Feb 2026 14:00:08 -0800 Message-ID: <20260223220102.2158611-9-bart.vanassche@linux.dev> In-Reply-To: <20260223220102.2158611-1-bart.vanassche@linux.dev> References: <20260223220102.2158611-1-bart.vanassche@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT From: Bart Van Assche Do not unlock psp->ras_context.mutex if it has not been locked. This has been detected by the Clang thread-safety analyzer. Cc: Alex Deucher Cc: Christian K=C3=B6nig Cc: YiPeng Chai Cc: Hawking Zhang Cc: amd-gfx@lists.freedesktop.org Fixes: b3fb79cda568 ("drm/amdgpu: add mutex to protect ras shared memory") Signed-off-by: Bart Van Assche --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c b/drivers/gpu/drm/a= md/amdgpu/amdgpu_psp_ta.c index 6e8aad91bcd3..0d3c18f04ac3 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c @@ -332,13 +332,13 @@ static ssize_t ta_if_invoke_debugfs_write(struct file= *fp, const char *buf, size if (!context || !context->initialized) { dev_err(adev->dev, "TA is not initialized\n"); ret =3D -EINVAL; - goto err_free_shared_buf; + goto free_shared_buf; } =20 if (!psp->ta_funcs || !psp->ta_funcs->fn_ta_invoke) { dev_err(adev->dev, "Unsupported function to invoke TA\n"); ret =3D -EOPNOTSUPP; - goto err_free_shared_buf; + goto free_shared_buf; } =20 context->session_id =3D ta_id; @@ -346,7 +346,7 @@ static ssize_t ta_if_invoke_debugfs_write(struct file *= fp, const char *buf, size mutex_lock(&psp->ras_context.mutex); ret =3D prep_ta_mem_context(&context->mem_context, shared_buf, shared_buf= _len); if (ret) - goto err_free_shared_buf; + goto unlock; =20 ret =3D psp_fn_ta_invoke(psp, cmd_id); if (ret || context->resp_status) { @@ -354,15 +354,17 @@ static ssize_t ta_if_invoke_debugfs_write(struct file= *fp, const char *buf, size ret, context->resp_status); if (!ret) { ret =3D -EINVAL; - goto err_free_shared_buf; + goto unlock; } } =20 if (copy_to_user((char *)&buf[copy_pos], context->mem_context.shared_buf,= shared_buf_len)) ret =3D -EFAULT; =20 -err_free_shared_buf: +unlock: mutex_unlock(&psp->ras_context.mutex); + +free_shared_buf: kfree(shared_buf); =20 return ret;