From nobody Fri Mar 27 01:35:20 2026 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 817F537AA8C for ; Mon, 23 Feb 2026 22:01:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884102; cv=none; b=UDk2FgV1LqIPy2Xs3KEB5QXu4ePcaRTBQTSGYR6tP6b1utgGn8rSwgn+wfdbvMclZ93mB2EV8X1FJsAyIRsa9qkAjkvgCM3m4KSSGi1EhCKlj9mO2of+fZqRnbiBWAcPiWkcVBMg0mnFGq0rOoOc0vAze/n3POPMEOoZXxWnclM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884102; c=relaxed/simple; bh=Czh776m2IVtz7QxSnBC2yRj59s7JD2GjjkfA+/iDMzA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZQaZmajRt0pLdUHoRMXB1zqMhPirsNLjbWyx3+cD62mD80kmXsF/Jf5r/7RAFsOttX68DMSOHn1tAQn/0XCl5CSJE7vhrNf/vIMityiRZc13M8n27Wmdk0MHhIxJvz7fRx8JArAKfp5Cc6P8zxkVAqoqedj4p9F3EEv8V3qc7Uw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=V8UKSFqN; arc=none smtp.client-ip=91.218.175.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="V8UKSFqN" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771884098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QtVMBDRsS7FYSdiF3oCCHrjupc6mT6DbnvZ3xPXN2sk=; b=V8UKSFqNc7EvcBES/LBeYkChJeLt9cXR78KZbn2JUa7rlRWTZ8YTm4011L2yoW+nmaIfCA lG/9HwwDaIUekdjNX01RpBcWs/MiODo/lfg8KdVQ2/N9k66rQJN05WR+rY5n/xM1FG44Cv 90x86ZD58NgDce/UzRA7SGB7o0uznp8= From: Bart Van Assche To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Yang Wang , Hawking Zhang , amd-gfx@lists.freedesktop.org Subject: [PATCH 07/62] drm/amdgpu: Unlock a mutex before destroying it Date: Mon, 23 Feb 2026 14:00:07 -0800 Message-ID: <20260223220102.2158611-8-bart.vanassche@linux.dev> In-Reply-To: <20260223220102.2158611-1-bart.vanassche@linux.dev> References: <20260223220102.2158611-1-bart.vanassche@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT From: Bart Van Assche Mutexes must be unlocked before these are destroyed. This has been detected by the Clang thread-safety analyzer. Cc: Alex Deucher Cc: Christian K=C3=B6nig Cc: Yang Wang Cc: Hawking Zhang Cc: amd-gfx@lists.freedesktop.org Fixes: f5e4cc8461c4 ("drm/amdgpu: implement RAS ACA driver framework") Signed-off-by: Bart Van Assche --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/amd/= amdgpu/amdgpu_aca.c index afe5ca81beec..db7858fe0c3d 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c @@ -641,6 +641,7 @@ static void aca_error_fini(struct aca_error *aerr) aca_bank_error_remove(aerr, bank_error); =20 out_unlock: + mutex_unlock(&aerr->lock); mutex_destroy(&aerr->lock); } =20