From nobody Fri Mar 27 01:35:19 2026 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1955E37F754 for ; Mon, 23 Feb 2026 22:03:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884186; cv=none; b=ulx4HXPj3xKthel7WqOysWVrwpNUvcpjw3swYrhidBiQolVUT0T9eB+eAJzN5dU6TtonfT3IszyEatlF7FXcB+ZWo9LsW1OUc8HmVr8sDbX+aGy5oWh7KT0cSUApFL9vSpJsWyVxMLvy+XII4uUa7xrDvLIU+t5DeZluydG8Eb8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884186; c=relaxed/simple; bh=5oZn9v4v+pnZjL/JNMMpwZvB81UtHjFOl5T7GBwMC1I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SdFbUDQAWqNxxWXu58pGidukHNzLHZN6xqYwk2FjdcDkJRxPY9nfZfhM+E5ntTkz2Ic0JI006tuDJ4K/tlytkClI03OHsfbgkGVaNwrA3/fim9ZS7ghxC2OiANWxq0KKvjIzyW/Sl00ki0BZxzP9moJj1fFffak/z+FNeIYe2Z0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Yv7p8bb/; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Yv7p8bb/" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771884183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3eXqqyPfJ3ki5a2vh3kgDlj7p7Sn8GL5TkG1RJouXdc=; b=Yv7p8bb/eht84EeZ7glks+1cTeCisJhAZJsd2dWjNHXteeksMwV883io9d+MCU1ekmHQay 90qE6VGVtUpqR7OjLiKjH2N3e79UxGU2UPtqIf3lr6kWeQ7PTMwIFm4H4Lag9EfVM38XcB w7g3C3YAaMk3IGq3tgHnr1P4df5E7gg= From: Bart Van Assche To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , Jaroslav Kysela , Adam Belay , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org Subject: [PATCH 28/62] PNP: isapnp: Check the isapnp_cfg_begin() return value Date: Mon, 23 Feb 2026 14:00:28 -0800 Message-ID: <20260223220102.2158611-29-bart.vanassche@linux.dev> In-Reply-To: <20260223220102.2158611-1-bart.vanassche@linux.dev> References: <20260223220102.2158611-1-bart.vanassche@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Bart Van Assche Instead of ignoring isapnp_cfg_begin() failures, propagate the value returned by this function in case of a failure. This patch prepares for enabling thread-safety analysis since isapnp_cfg_begin() only locks a particular mutex if it returns zero. Cc: Jaroslav Kysela Cc: Adam Belay Cc: Rafael J. Wysocki Cc: linux-acpi@vger.kernel.org Fixes: f72e5c5c861c ("[PATCH] PnP Rewrite V0.9 - 2.5.43") Signed-off-by: Bart Van Assche Acked-by: Rafael J. Wysocki (Intel) --- drivers/pnp/isapnp/core.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/pnp/isapnp/core.c b/drivers/pnp/isapnp/core.c index 219f96f2aaaf..3591a2791c1a 100644 --- a/drivers/pnp/isapnp/core.c +++ b/drivers/pnp/isapnp/core.c @@ -853,7 +853,9 @@ static int isapnp_get_resources(struct pnp_dev *dev) =20 pnp_dbg(&dev->dev, "get resources\n"); pnp_init_resources(dev); - isapnp_cfg_begin(dev->card->number, dev->number); + ret =3D isapnp_cfg_begin(dev->card->number, dev->number); + if (ret) + return ret; dev->active =3D isapnp_read_byte(ISAPNP_CFG_ACTIVATE); if (!dev->active) goto __end; @@ -887,10 +889,12 @@ static int isapnp_get_resources(struct pnp_dev *dev) static int isapnp_set_resources(struct pnp_dev *dev) { struct resource *res; - int tmp; + int tmp, ret; =20 pnp_dbg(&dev->dev, "set resources\n"); - isapnp_cfg_begin(dev->card->number, dev->number); + ret =3D isapnp_cfg_begin(dev->card->number, dev->number); + if (ret) + return ret; dev->active =3D 1; for (tmp =3D 0; tmp < ISAPNP_MAX_PORT; tmp++) { res =3D pnp_get_resource(dev, IORESOURCE_IO, tmp); @@ -936,9 +940,13 @@ static int isapnp_set_resources(struct pnp_dev *dev) =20 static int isapnp_disable_resources(struct pnp_dev *dev) { + int ret; + if (!dev->active) return -EINVAL; - isapnp_cfg_begin(dev->card->number, dev->number); + ret =3D isapnp_cfg_begin(dev->card->number, dev->number); + if (ret) + return ret; isapnp_deactivate(dev->number); dev->active =3D 0; isapnp_cfg_end();