From nobody Fri Mar 27 01:30:54 2026 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9B06379974 for ; Mon, 23 Feb 2026 22:02:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884156; cv=none; b=njsukgrLOJ9E52n0We++sBRFkkIboQEoC2tCP0+gh7jYukO/vD+wBpG52e/zVM2Z13BYsSrm7JfKz1XiDUZRiKgvV+cZ99+TLRURJGY/SFV2+pxX/etmgslV24DNO2IrAXD8zLja7I8DRZO5UvVE/LWMLKkN5OLHBgBt6GDY+34= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884156; c=relaxed/simple; bh=nPFa+DaruW2SFnGWq2pXxl9db3bpEKOvPVb2kScJ7j4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=vCprYIn6zhIukMLTiNc1rwhrWPnVx8C995YPWO3tO57HGrdJjvSJpjoilPWqbDSPzyCH+VPO/sF3xsjpVoa+BhTQte035frwKnSg24J4C/hrZcdBrVjvAYvfHwiHCCG19RrKmKfX8j7Gt+h0Iyc50rEIzbVcQfR4sGL6gJZHrnI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=xaTN2/xT; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="xaTN2/xT" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771884150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vsR9dezXZFX0ROhQ/bAFuXWz6GOBnMZu01MKdxvJYXA=; b=xaTN2/xTV8C1Qp0WiEWrZ8PEgCWIeeiVxCJtwA7dO+avBO1TMM/QMrbDBu/oCDNFLlBAWU PCzFmK6Tlc0fPO1XyTZqGH91b1nUTOSompfgQK1V3/hf1n0fa43L22xOuYnsoEOkHDFnf/ 4K1kQDV2h8C6BZ4LaHV3PBpBv3ECUh0= From: Bart Van Assche To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , Naveen Mamindlapalli , Jakub Kicinski , Sunil Goutham , Geetha sowjanya , Subbaraya Sundeep , hariprasad , Bharat Bhushan , netdev@vger.kernel.org Subject: [PATCH 20/62] octeontx2-pf: Fix locking in an error path Date: Mon, 23 Feb 2026 14:00:20 -0800 Message-ID: <20260223220102.2158611-21-bart.vanassche@linux.dev> In-Reply-To: <20260223220102.2158611-1-bart.vanassche@linux.dev> References: <20260223220102.2158611-1-bart.vanassche@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Bart Van Assche Only unlock pf->mbox.lock if it has been locked by otx2_do_set_vf_vlan(). This bug has been detected by the Clang thread-safety analyzer. Cc: Naveen Mamindlapalli Cc: Jakub Kicinski Cc: Sunil Goutham Cc: Geetha sowjanya Cc: Subbaraya Sundeep Cc: hariprasad Cc: Bharat Bhushan Cc: netdev@vger.kernel.org Fixes: f0c2982aaf98 ("octeontx2-pf: Add support for SR-IOV management funct= ions") Signed-off-by: Bart Van Assche --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers= /net/ethernet/marvell/octeontx2/nic/otx2_pf.c index ee623476e5ff..8c9f08ed90fd 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c @@ -2588,7 +2588,7 @@ static int otx2_do_set_vf_vlan(struct otx2_nic *pf, i= nt vf, u16 vlan, u8 qos, config =3D &pf->vf_configs[vf]; =20 if (!vlan && !config->vlan) - goto out; + return err; =20 mutex_lock(&pf->mbox.lock);