From nobody Fri Mar 27 01:33:47 2026 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2FAD37C0E4 for ; Mon, 23 Feb 2026 22:02:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.184 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884132; cv=none; b=fU0UkrIZqBDrc/cFp95KcnvTYkKBENftsB6mJngvrofNgVuN8X/1lZTsxNJUaoahuzu2mj50eXxbRb2FsyHmOEFncEpyIDTrFl8Zta/VoTW5S8VmHB1g4jMvuiAue90gIN/GpUlsS3YX4zjVzIwSgluEsW70Cq/+g0lly69b6hs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884132; c=relaxed/simple; bh=d12I00uU4akC6yUvY14Fa3X7XXV8owh8S53ti4xoP6U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B+C73NnfxQBBSLP1LBAdcKvQP99fnDeh0f2Ozzu+fL8qmcRcnOB4QOFUq9e3c6Hkxps25qSvH0UEFxboO9Vec/3DLTvR7K+MdHY7u/Fvl4cXF84s86nB8QlI6njD5c7Cb5CmytOFypF9WfXnqne7mrWmfio1IjvcW0/q6FSjYU0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=MDZKE01+; arc=none smtp.client-ip=91.218.175.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="MDZKE01+" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771884127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g7HVL8Dd4WhWO+0+vRegYBqMOg4C8vA2aph4C9LjcTc=; b=MDZKE01+Y5oO0nwjrSlV4K+MIvSX37PLb0JbRsxTnvAc161HkZeFeIsp35q2bbbR+BCGSl yF1ihcIJypBN1gPL5F/W9kikLF85R6nFHU9SSDG0Sm7BoMsMk1tDaF01MqEJjQo77wVXxD aBtsnO3B4cjjqxpq6t2HzXn8oIWhOe4= From: Bart Van Assche To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , Frank Crawford , Guenter Roeck , Jean Delvare , linux-hwmon@vger.kernel.org Subject: [PATCH 14/62] hwmon: (it87) Check the it87_lock() return value Date: Mon, 23 Feb 2026 14:00:14 -0800 Message-ID: <20260223220102.2158611-15-bart.vanassche@linux.dev> In-Reply-To: <20260223220102.2158611-1-bart.vanassche@linux.dev> References: <20260223220102.2158611-1-bart.vanassche@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Bart Van Assche Return early in it87_resume() if it87_lock() fails instead of ignoring the return value of that function. This patch suppresses a Clang thread-safety warning. Cc: Frank Crawford Cc: Guenter Roeck Cc: Jean Delvare Cc: linux-hwmon@vger.kernel.org Fixes: 376e1a937b30 ("hwmon: (it87) Add calls to smbus_enable/smbus_disable= as required") Signed-off-by: Bart Van Assche --- drivers/hwmon/it87.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index e233aafa8856..8e3935089fca 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -3593,7 +3593,9 @@ static int it87_resume(struct device *dev) =20 it87_resume_sio(pdev); =20 - it87_lock(data); + int err =3D it87_lock(data); + if (err) + return err; =20 it87_check_pwm(dev); it87_check_limit_regs(data);