From nobody Fri Mar 27 01:33:52 2026 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9229437BE7D for ; Mon, 23 Feb 2026 22:01:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884112; cv=none; b=OsI5bYLz2FEZvrzzkfv9t+nk0a88XwoA7qKC/FFiv3Je9/qvCrolSJVtqL/ju4yBGyjuyRUrm1k+ODOHAytj+ZlCHsB4MDEg0U2sHP6ZeMgGmEYa2Qkfo0BXuSqvQQeap6j0gVfJzrw9zQIVw+V4d6xqpeVOXZrICBJpSqtQWtI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884112; c=relaxed/simple; bh=CFjusbq7InQuaAwxE0GP4uc/P65G+jHLH74cGY5ywLQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Df2x9PsJ5KWPq58Qg76/OEUAwVZ539/3AQixk2/x2BAAutx1thczBAME9JGVuAJwuuRTWi6gheePO4lJ8Wcnl4ILtdHIc6B5/G2PG9YPtTWsRHRGg+VJDVHAV1lcc1KmS+LD0ihRviUW/trOmMmCihDO6kyQqaSxLJKH0KFBsME= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=wsqTi6pY; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="wsqTi6pY" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771884106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pto/ULSLmFdwKpWUDtPxuwiUcbxIggVZShq8LKyF5BY=; b=wsqTi6pY94QAndQfJT49+yXw7mJ7/C2CKKUOh1HCLyGqssxfDhdD1ef3rX8s16Ht9mDk0s irqdqh3+BJKqXejgFl3/Jj5Zq2bkbG+306ZytMrUS1jy8hXU9AvoYFBzmME+qbkiqMoMdv PfAmVft8ucLePT8jpxadUXapQ7yomTI= From: Bart Van Assche To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Swapnil Jakhade , Tomi Valkeinen Subject: [PATCH 09/62] drm: bridge: cdns-mhdp8546: Fix a locking bug in an error path Date: Mon, 23 Feb 2026 14:00:09 -0800 Message-ID: <20260223220102.2158611-10-bart.vanassche@linux.dev> In-Reply-To: <20260223220102.2158611-1-bart.vanassche@linux.dev> References: <20260223220102.2158611-1-bart.vanassche@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Bart Van Assche Do not unlock mhdp->mbox_mutex if it has not been locked. This bug has been detected by the Clang thread-safety analyzer. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: Swapnil Jakhade Cc: Tomi Valkeinen Fixes: fb43aa0acdfd ("drm: bridge: Add support for Cadence MHDP8546 DPI/DP = bridge") Signed-off-by: Bart Van Assche --- drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/= gpu/drm/bridge/cadence/cdns-mhdp8546-core.c index 9392c226ff5b..ce4516de11d8 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c @@ -502,8 +502,7 @@ int cdns_mhdp_adjust_lt(struct cdns_mhdp_device *mhdp, = unsigned int nlanes, =20 if (nlanes !=3D 4 && nlanes !=3D 2 && nlanes !=3D 1) { dev_err(mhdp->dev, "invalid number of lanes: %u\n", nlanes); - ret =3D -EINVAL; - goto out; + return -EINVAL; } =20 payload[0] =3D nlanes;