From nobody Fri Apr 17 04:47:45 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF08533CEB0; Mon, 23 Feb 2026 18:09:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870148; cv=none; b=T1NQZpasG4BSf0uqh3HJCX1ubC6p3ISpGOLrNf0/aoJM6qzqbUKpPaiW5DdUu4Vy1/Txy0rpW5Nfbm42efiIL0SNc6+k6oQavwzxLIGNzHK5S8t4ce2RuwSC65opHQku+aJ+Tv3SVhiya/XMWuZ9zN+nvF9WO8heu5e7Ubyv04E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870148; c=relaxed/simple; bh=mB4UJPu7ft7xeAi6JUJEU3taIkBlM1htlTm1Pte0Vxg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tGThpHZ+n7yk4rlrxzfA+tcO1uh4fRC8uaYjDCz9xHBheekaCplfDwtgvf76GQYQ0lmp1IxssTuZ71s2etC6rg5Y7JNqV1xg1JOa8yB4c4HlFNt9VbmTBs52eHS6Ro8HIeHJv0VwtCeZMGcFxUA7X/o+OdfghlPcYtCNRYlRX7g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=TR9tI9J7; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="TR9tI9J7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771870147; x=1803406147; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mB4UJPu7ft7xeAi6JUJEU3taIkBlM1htlTm1Pte0Vxg=; b=TR9tI9J7gLIGb8Iomc206pXuNjabeZMtd1iBTY4uQ67JjxIrEegOOaY1 wDrTqtc409urDjkhPPW63Ry9SwoYcFfLvKVu8G2aIkwnwrFXh34U0m5bj zv9VMBaRBA5yimg899QHy4pk36PWNODK1VlxPV1LHcTUQbjGW794/grma wYZ9BnEOo2pqxd1ZlDkCZq/4Y39XDcQvAxoGR1KVtlaAwaQe0fuoMP1Qd m43AL0QUbWfjez9iJTDYP9bTJdiyT5oLLfvz37gWdwkXwGa1IVSRdrbxm mlVDyiCzXJwDXkIe8zVoWOWwXbuPyjoKFfRunkwOq1cVvvF4QD5+x9dYA Q==; X-CSE-ConnectionGUID: QZu8s1SOSpGUJDOr7eSfgw== X-CSE-MsgGUID: U5e9eEydROKdKO0EbYVxDQ== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="76737702" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="76737702" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 10:09:04 -0800 X-CSE-ConnectionGUID: OVa1yvTwQLitLtSc3ps9gg== X-CSE-MsgGUID: 76mljHycSjCqLzYVqOTh+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="253369509" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa001.jf.intel.com with ESMTP; 23 Feb 2026 10:09:02 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 266B899; Mon, 23 Feb 2026 19:09:01 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Patrick Rudolph , Linus Walleij , stable@vger.kernel.org Subject: [PATCH v1 1/8] pinctrl: cy8c95x0: Don't miss reading the last bank registers Date: Mon, 23 Feb 2026 19:06:51 +0100 Message-ID: <20260223180859.2845261-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260223180859.2845261-1-andriy.shevchenko@linux.intel.com> References: <20260223180859.2845261-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When code had been changed to use for_each_set_clump8(), it mistakenly switched from chip->nport to chip->tpin since the cy8c9540 and cy8c9560 have a 4-pin gap. This, in particular, led to the missed read of the last bank interrupt status register and hence missing interrupts on those pins. Restore the upper limit in for_each_set_clump8() to take into consideration that gap. Fixes: 83e29a7a1fdf ("pinctrl: cy8c95x0; Switch to use for_each_set_clump8(= )") Cc: stable@vger.kernel.org Signed-off-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-cy8c95x0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-c= y8c95x0.c index a4b04bf6d081..5c055d344ac9 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -627,7 +627,7 @@ static int cy8c95x0_write_regs_mask(struct cy8c95x0_pin= ctrl *chip, int reg, bitmap_scatter(tmask, mask, chip->map, MAX_LINE); bitmap_scatter(tval, val, chip->map, MAX_LINE); =20 - for_each_set_clump8(offset, bits, tmask, chip->tpin) { + for_each_set_clump8(offset, bits, tmask, chip->nport * BANK_SZ) { unsigned int i =3D offset / 8; =20 write_val =3D bitmap_get_value8(tval, offset); @@ -655,7 +655,7 @@ static int cy8c95x0_read_regs_mask(struct cy8c95x0_pinc= trl *chip, int reg, bitmap_scatter(tmask, mask, chip->map, MAX_LINE); bitmap_scatter(tval, val, chip->map, MAX_LINE); =20 - for_each_set_clump8(offset, bits, tmask, chip->tpin) { + for_each_set_clump8(offset, bits, tmask, chip->nport * BANK_SZ) { unsigned int i =3D offset / 8; =20 ret =3D cy8c95x0_regmap_read_bits(chip, reg, i, bits, &read_val); --=20 2.50.1 From nobody Fri Apr 17 04:47:45 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5AB033B955; Mon, 23 Feb 2026 18:09:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870145; cv=none; b=NvrhV2h0xx+kGChQNS24gVPC1EFCdvA7SOaRoKyO+0wwOuv6D3hYEP3YjuMKuNq8A5n2WHaFiassW78GIwaS0GMNTGeRV8nak2c50WLa4ue4I3c7By0r8nNJCM4j6cTdlKhsne63VxKN2G4OVP488rTB3tzk7CvYa7S1Q89cptg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870145; c=relaxed/simple; bh=NjEkuQeRNEe9/XFUfAKHJHpzCenTaA4ThY2KU/aWb5Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K0jem/BB7orM3YZu3XI/xiVpQhb2vSwIOQuJd+7RsnQ+eymnn2pJ/af9Bwyv7X+ePO81msb1USOqK22hOYTrqctMgRMAvuN3cZmVvAN6Js1itEv/agy9SfiLbRtniNtAhZPHhUiUtU29AQVsw5kodDcnmReUyBdKodeQFFRE/VI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VifzeqoF; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VifzeqoF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771870144; x=1803406144; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NjEkuQeRNEe9/XFUfAKHJHpzCenTaA4ThY2KU/aWb5Q=; b=VifzeqoFY4pT6ioVaw9D4MdfTpQr8XFVwfsizvD7qbH4RPSHPDWB8dSd kJfzGbRMV6XC0jAeajmgVTLLdLDFt2lLVo7ZrDCB9MqBRgxfAKHWnBN3g yZVSp0vsog11peXsijRjTuBeY25aM05WtuZDCBWVYCST6QC1xgdrj5rTq i6KcZLP7pH1/rTqElxC7Ioh6IyRNH0JdOAaC4Y4//9lS9ucZbEC7aHA0c DKEq+mkJwduv43+pqEQ4nh/pjEMlIY8zyo6nKg62N1Uf5pl612jJ5zEzD mDHXvSaZK8R0Z0b8d2Yphrf0gZhZRswUJdA6aFVN5E6A9Sai27mksxk7D g==; X-CSE-ConnectionGUID: yWQo5RidSXWaxRck48BTwQ== X-CSE-MsgGUID: ZnsoXfDDSdC+6+bNgK3bOA== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="72082653" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="72082653" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 10:09:03 -0800 X-CSE-ConnectionGUID: nX58BouuRqOmskmcz64fCg== X-CSE-MsgGUID: ymW+8RisSAeyFcb5qcNsfA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="238599650" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa002.fm.intel.com with ESMTP; 23 Feb 2026 10:09:02 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 2A8D29B; Mon, 23 Feb 2026 19:09:01 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Patrick Rudolph , Linus Walleij Subject: [PATCH v1 2/8] pinctrl: cy8c95x0: Use devm_mutex_init() for mutex initialization Date: Mon, 23 Feb 2026 19:06:52 +0100 Message-ID: <20260223180859.2845261-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260223180859.2845261-1-andriy.shevchenko@linux.intel.com> References: <20260223180859.2845261-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use devm_mutex_init() since it brings some benefits when CONFIG_DEBUG_MUTEXES is enabled. Signed-off-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-cy8c95x0.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-c= y8c95x0.c index 5c055d344ac9..0647c7f94162 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -1312,7 +1312,9 @@ static int cy8c95x0_irq_setup(struct cy8c95x0_pinctrl= *chip, int irq) DECLARE_BITMAP(pending_irqs, MAX_LINE); int ret; =20 - mutex_init(&chip->irq_lock); + ret =3D devm_mutex_init(chip->dev, &chip->irq_lock); + if (ret) + return ret; =20 bitmap_zero(pending_irqs, MAX_LINE); =20 @@ -1474,7 +1476,9 @@ static int cy8c95x0_probe(struct i2c_client *client) bitmap_fill(chip->map, MAX_LINE); bitmap_clear(chip->map, 20, 4); =20 - mutex_init(&chip->i2c_lock); + ret =3D devm_mutex_init(dev, &chip->i2c_lock); + if (ret) + return ret; =20 if (dmi_first_match(cy8c95x0_dmi_acpi_irq_info)) { ret =3D cy8c95x0_acpi_get_irq(&client->dev); --=20 2.50.1 From nobody Fri Apr 17 04:47:45 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D7A433B97B; Mon, 23 Feb 2026 18:09:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870146; cv=none; b=Ovqk0tssvpC8zg5G/Zv1ndshcVNqlGbo40X/3bUzG5042C/ePa7latjlJDlw/lFH8QJa5a+63hgoZgvHusu87jBTG6mrvX8QPzzHH6X0dEYS12k4Ai8iTNzdnzjPCNQsjKV/GGasSBJk2y7QTqHdM3l4RpF11EwtwGiqk9vu1J0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870146; c=relaxed/simple; bh=TMzcyH63F4RpXRFGqOO7y7ywEJpoeK8pxIU27Pemdzs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VfrUBGp4M7Bmmaptw8r1WR+yMcdam1adF7Ggee3rAnQav06E9wqtCNMG2lbvBJWzzOsKcPmdE9zqR2dMwTdjULhjyXZLf44fd1lH7yDLGBr/YN+WIQZFUvtG0WB8E9GZ5sOslumycEHll8Dg5BUUU2ctNzmIXg3rgyucPHbuplE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=O95Jhf5N; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="O95Jhf5N" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771870145; x=1803406145; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TMzcyH63F4RpXRFGqOO7y7ywEJpoeK8pxIU27Pemdzs=; b=O95Jhf5N9uKdJAYBFmklYif2gjScUPzNF0pg1TEZpFbPrfYvZ9jR7MO7 3qiAN5UF8UXjnqz7q0hqK3fY7eWHBN6HQ1fyBmA/f6NfZL3F8wc0+qsyZ pa+xaOAnCJVPXTsnuk+pWfRCYUNjeqdxfGXcawsP/EiMMz8cgVrtM29iO +sdeAtjX55+2uhsiznVW4CmkuTRp2kPaeeRHorcNDVMUBP/JFkuv2tkuQ Rz/NbI42lGtIv5rcnAi3XEcyY7Tcrx/jztbdvERHOwjJZkOUmSimkW7en YeqBABK7BCTcJU4txVl/IuXdOEhGK8AmKB0m7p2noMd+tOoT/UorLcvbP A==; X-CSE-ConnectionGUID: Tkal2eaES0i8BQJJM2NpwQ== X-CSE-MsgGUID: VuKpVX/qQVCnpUwt0RVKrA== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="76737696" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="76737696" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 10:09:03 -0800 X-CSE-ConnectionGUID: DuGprlqQRBeElKbELRortQ== X-CSE-MsgGUID: fP0/W1qgSDCMx5qgi6Hc6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="253369508" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa001.jf.intel.com with ESMTP; 23 Feb 2026 10:09:02 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 2ECA39D; Mon, 23 Feb 2026 19:09:01 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Patrick Rudolph , Linus Walleij Subject: [PATCH v1 3/8] pinctrl: cy8c95x0: remove duplicate error message Date: Mon, 23 Feb 2026 19:06:53 +0100 Message-ID: <20260223180859.2845261-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260223180859.2845261-1-andriy.shevchenko@linux.intel.com> References: <20260223180859.2845261-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The pin control core is covered to report any error via message. The devm_request_threaded_irq() already prints an error message. Remove the duplicates. While at it, drop the info message as the same information about an IRQ in use can be retrieved differently. Signed-off-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-cy8c95x0.c | 21 +++++---------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-c= y8c95x0.c index 0647c7f94162..165ccbda035f 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -1310,6 +1310,7 @@ static int cy8c95x0_irq_setup(struct cy8c95x0_pinctrl= *chip, int irq) { struct gpio_irq_chip *girq =3D &chip->gpio_chip.irq; DECLARE_BITMAP(pending_irqs, MAX_LINE); + struct device *dev =3D chip->dev; int ret; =20 ret =3D devm_mutex_init(chip->dev, &chip->irq_lock); @@ -1338,17 +1339,9 @@ static int cy8c95x0_irq_setup(struct cy8c95x0_pinctr= l *chip, int irq) girq->handler =3D handle_simple_irq; girq->threaded =3D true; =20 - ret =3D devm_request_threaded_irq(chip->dev, irq, - NULL, cy8c95x0_irq_handler, - IRQF_ONESHOT | IRQF_SHARED, - dev_name(chip->dev), chip); - if (ret) { - dev_err(chip->dev, "failed to request irq %d\n", irq); - return ret; - } - dev_info(chip->dev, "Registered threaded IRQ\n"); - - return 0; + return devm_request_threaded_irq(dev, irq, NULL, cy8c95x0_irq_handler, + IRQF_ONESHOT | IRQF_SHARED, + dev_name(chip->dev), chip); } =20 static int cy8c95x0_setup_pinctrl(struct cy8c95x0_pinctrl *chip) @@ -1364,11 +1357,7 @@ static int cy8c95x0_setup_pinctrl(struct cy8c95x0_pi= nctrl *chip) pd->owner =3D THIS_MODULE; =20 chip->pctldev =3D devm_pinctrl_register(chip->dev, pd, chip); - if (IS_ERR(chip->pctldev)) - return dev_err_probe(chip->dev, PTR_ERR(chip->pctldev), - "can't register controller\n"); - - return 0; + return PTR_ERR_OR_ZERO(chip->pctldev); } =20 static int cy8c95x0_detect(struct i2c_client *client, --=20 2.50.1 From nobody Fri Apr 17 04:47:45 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBF6D33C522; Mon, 23 Feb 2026 18:09:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870147; cv=none; b=cJl2+JBdutkkAg/KUX+owBNrzrDz+pGdFJpL8Qc0V4fyBNpkxQaew9+Ysbl8F1ORer3+b7EUePfWB6oqY34jmckoY3Yq3H8byUPHW5ImGFWiyj6SidqQcgiePwzd5TII8JE3yW02Nr0Hi0SwPr9UYJgPnNybzIvBsTSGUeUv9G4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870147; c=relaxed/simple; bh=jkuthO0ot5cp48bSHyF5g6iI2H7DlYmMluLOs4PFE2A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FNJTDE5JcL9hI/O/rJCN0ADVPfouBsH7zuinujaLjsT22a3hZEwpsqwn1fbsos2gSCOoyqum6ueQ8jaOMBqaTn8/F5X0mN/W1eykYUnitTN/ndWR041zEbX9sMmQHic0v05aqQ3R1ousV4FxKsPpXfBUW5s3p/5wloBBRq2+hnE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=UllrOkEF; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="UllrOkEF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771870146; x=1803406146; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jkuthO0ot5cp48bSHyF5g6iI2H7DlYmMluLOs4PFE2A=; b=UllrOkEFuxKbum15i/WQ0+Byq6HMh7KM6t9oZnY9m1viIY2sfHLqsI3Q draNbIhoi45vhcqPNLdZqspJS61aWkcgB7FgG2WeVrghVu+SYbONyC6dc +TdWAQViiqAmlrvw+hGHZcoK+isz49TrWm3IhtHa0RFwTK3yYLzCracEK swEMzI0gZC6RB2jG2CotWuAJmbBngSboib0a0vAQpLxtrXezTqQaE2Crq k8+HHR0jH2q4rL5lYyqmrS8myXorVGqrY5Z4Jl5c64FN+w+b/REZG4wz5 9Xx0Snbjc/9cDHF8P36tZZEjDk3FrG/s9hP4bwUy24YToJwrtZhlZk4U4 w==; X-CSE-ConnectionGUID: fUAYk7uDRSO5t9/5XVUMcw== X-CSE-MsgGUID: fKGz0gpOS3+80kYx4IAGDQ== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="76737699" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="76737699" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 10:09:03 -0800 X-CSE-ConnectionGUID: LZsFadAQRQeZchHMf6FDdQ== X-CSE-MsgGUID: l7t8hejoQC2KDpd2ZKYgfw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="253369511" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa001.jf.intel.com with ESMTP; 23 Feb 2026 10:09:02 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 3317A9E; Mon, 23 Feb 2026 19:09:01 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Patrick Rudolph , Linus Walleij Subject: [PATCH v1 4/8] pinctrl: cy8c95x0: Unify messages with help of dev_err_probe() Date: Mon, 23 Feb 2026 19:06:54 +0100 Message-ID: <20260223180859.2845261-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260223180859.2845261-1-andriy.shevchenko@linux.intel.com> References: <20260223180859.2845261-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Unify error messages that might appear during probe phase by switching to use dev_err_probe(). Signed-off-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-cy8c95x0.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-c= y8c95x0.c index 165ccbda035f..94a599486638 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -1321,10 +1321,8 @@ static int cy8c95x0_irq_setup(struct cy8c95x0_pinctr= l *chip, int irq) =20 /* Read IRQ status register to clear all pending interrupts */ ret =3D cy8c95x0_irq_pending(chip, pending_irqs); - if (ret) { - dev_err(chip->dev, "failed to clear irq status register\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to clear irq status register\n"); =20 /* Mask all interrupts */ bitmap_fill(chip->irq_mask, MAX_LINE); --=20 2.50.1 From nobody Fri Apr 17 04:47:45 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28FAE33D4FD; Mon, 23 Feb 2026 18:09:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870148; cv=none; b=RNYLh5hbWgaXzJDKEjd5fi0cH3aEUXctYtWAeWO3nOI5y7+Zwfwsw7vAypvcsWQasu6xJqCGu4Z7tjfkx1JEza8O42/ojxZEMYgKevmkhk17qrjK/hW9+y/xESR2An/cx5g4jzcpHeLub9ybCrtPnzP2A/TiV5TeqsSzExNmTOI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870148; c=relaxed/simple; bh=vvJbnLQjcZA2fKepc4nSEbKGWOO1FgzcHMFdKrvP0x8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HaQDyAIWZkwfDDBokGFGp3mLjTDiKqcEomtA486/V+zrwGga/OmSIm0bHGt0jAByaCJmtFLUcYCZ5dgPYqWomNRnsDSnBOUCywGMqF5iwmxSG5CpIpQBHbYDlqfuOj5nR5cQ5jzZYIv+mySmM98lbOSn8MC5kFNLYO+iNhitlbc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hJr+9SYo; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hJr+9SYo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771870147; x=1803406147; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vvJbnLQjcZA2fKepc4nSEbKGWOO1FgzcHMFdKrvP0x8=; b=hJr+9SYoRbzisAWMmap1USDjdlgBn8n6/7RIMXrWaOm5Z4pkBlvOiW1K v3pbB04pG2jCO61YATR3wYMIZQTmQKzB/xfjEOqtXopU1As9xMo+Mj9F+ AmTMCmlleUKyWAye4T5GoWMz2p2CnBXIl4XzgrZO1229+aAWQWi1Ap7qd XvmtgrXYhfUmUQnjuR3yuWLsImCzwNywWg+MG6r7YVzBpawp+ljKBYoB4 hMpaqylH3a2KLV1RogCpdX+vStWJa1HH3nr+SW9gtKG0u40yrzod22HVA OKoasfVF3NNdViCCvwjzWzNwcFbCVklBYdTi3YPLEwf+GpLXQJGP2Woqy g==; X-CSE-ConnectionGUID: AUs/bhdETj2RjKW4WsvZ8Q== X-CSE-MsgGUID: +X1vbG89QU+dXwt6ppjTVQ== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="76737703" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="76737703" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 10:09:05 -0800 X-CSE-ConnectionGUID: LyG3nj19QH2Pn/ushWXcew== X-CSE-MsgGUID: 2c2C0LgQRbyHJhz8tEBlow== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="253369515" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa001.jf.intel.com with ESMTP; 23 Feb 2026 10:09:04 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 377ADA1; Mon, 23 Feb 2026 19:09:01 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Patrick Rudolph , Linus Walleij Subject: [PATCH v1 5/8] pinctrl: cy8c95x0: Move driver data to the local variable in ->probe() Date: Mon, 23 Feb 2026 19:06:55 +0100 Message-ID: <20260223180859.2845261-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260223180859.2845261-1-andriy.shevchenko@linux.intel.com> References: <20260223180859.2845261-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For all these years of driver existence the driver_data has been used only as a raw material for other fields in the struct cy8c95x0_pinctrl. Move it from the structure to be just a local variable in ->probe(). Later, if ever need arises, we may reconsider that. While at it, drop an unneeded validation and replace uintptr_t with plain unsigned long which is more readable and works in the same way. Signed-off-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-cy8c95x0.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-c= y8c95x0.c index 94a599486638..4f804a9358b7 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -144,7 +144,6 @@ static const struct dmi_system_id cy8c95x0_dmi_acpi_irq= _info[] =3D { * @map: Mask used to compensate for Gport2 width * @nport: Number of Gports in this chip * @gpio_chip: gpiolib chip - * @driver_data: private driver data * @dev: struct device * @pctldev: pin controller device * @pinctrl_desc: pin controller description @@ -165,7 +164,6 @@ struct cy8c95x0_pinctrl { DECLARE_BITMAP(map, MAX_LINE); unsigned int nport; struct gpio_chip gpio_chip; - unsigned long driver_data; struct device *dev; struct pinctrl_dev *pctldev; struct pinctrl_desc pinctrl_desc; @@ -1397,6 +1395,7 @@ static int cy8c95x0_probe(struct i2c_client *client) struct cy8c95x0_pinctrl *chip; struct regmap_config regmap_conf; struct regmap_range_cfg regmap_range_conf; + unsigned long driver_data; int ret; =20 chip =3D devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL); @@ -1406,11 +1405,9 @@ static int cy8c95x0_probe(struct i2c_client *client) chip->dev =3D dev; =20 /* Set the device type */ - chip->driver_data =3D (uintptr_t)i2c_get_match_data(client); - if (!chip->driver_data) - return -ENODEV; + driver_data =3D (unsigned long)i2c_get_match_data(client); =20 - chip->tpin =3D chip->driver_data & CY8C95X0_GPIO_MASK; + chip->tpin =3D driver_data & CY8C95X0_GPIO_MASK; chip->nport =3D DIV_ROUND_UP(CY8C95X0_PIN_TO_OFFSET(chip->tpin), BANK_SZ); =20 memcpy(®map_range_conf, &cy8c95x0_ranges[0], sizeof(regmap_range_conf)= ); --=20 2.50.1 From nobody Fri Apr 17 04:47:45 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44A2733D517; Mon, 23 Feb 2026 18:09:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870148; cv=none; b=ZoKuao+e9uRZsiKolWVJpze2NAh0pSntF2Lo2b3WhjKwEAW2KNAjoH1mpUhvFV1rdUY/uTEu9PZvunv1ctKNBDXUax5Ystd1YOI9I2i9OfqOHAHAeCpJNQl+8wkt3RHh5F0gWfNU34OIxf9L9xS+K4Elk04ugsf2PMqqbC9JrlQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870148; c=relaxed/simple; bh=bYfy7MGbL+AsPQ8NsOQsXW3VwjWAqzP7tT/C4sucMUw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VzlVUoEZHSLmsYwJLf80JzpY+iVfI92xMkGgWNm2pLCbsgBSASKrKyTYnhQi5d5KzcMclfb6TlXfu4pNQQWXa03FnD75adwzGj8/7bXOvAwZ9kEGkzPPmw2r4xCKuR8PJire5gG41zxSpw/m2407nDDZqjZQOT9RJk4mAHlKKfY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=L7Ro6+je; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="L7Ro6+je" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771870147; x=1803406147; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bYfy7MGbL+AsPQ8NsOQsXW3VwjWAqzP7tT/C4sucMUw=; b=L7Ro6+jexZFpOSC+ZZt/kLuiOK+tAN/XL/dbm7XcVu27nb4WwKeSiprd 9QKEKp4hVkTYIBX+hdTHeQXMAEuIevAodn3fdqSqUCHaePr/HrT7m/fSq RecQUTU9ihPVvqZlpENROGgGgeKqTHAmKXPDOgKSMFXrfbga0Mn7+69Nv KIKXlmVJEx00OkmiZwFrEmbjfTTool1JOUYzfIp7F2s8ZMQWpWXNZqBgM Ia5DWadbiOhZonKXK96YIrZrf+yqgTBh8EzlK5p6wKdoo5gpT6ui+h8sd cWTpa12vSmH9/BySbDtK+Us0qDscIp8JHDuwqOy76NjIfHjfmXXGzbkQt A==; X-CSE-ConnectionGUID: BJM9seWhS/i6cC1nNmpxyw== X-CSE-MsgGUID: LIiBp42yR+i4v0SlJapa/A== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="76737708" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="76737708" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 10:09:05 -0800 X-CSE-ConnectionGUID: FKVmGD3lSvuUZ1MjTC8cyg== X-CSE-MsgGUID: RSJDdxcpTGmNt0oHgXJokA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="253369516" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa001.jf.intel.com with ESMTP; 23 Feb 2026 10:09:04 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 3B8C6A2; Mon, 23 Feb 2026 19:09:01 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Patrick Rudolph , Linus Walleij Subject: [PATCH v1 6/8] pinctrl: cy8c95x0: Drop unused 'name' in struct cy8c95x0_pinctrl Date: Mon, 23 Feb 2026 19:06:56 +0100 Message-ID: <20260223180859.2845261-7-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260223180859.2845261-1-andriy.shevchenko@linux.intel.com> References: <20260223180859.2845261-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The 'name' is only assigned and never used. Drop it for good. Signed-off-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-cy8c95x0.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-c= y8c95x0.c index 4f804a9358b7..0bcc9ac19696 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -147,7 +147,6 @@ static const struct dmi_system_id cy8c95x0_dmi_acpi_irq= _info[] =3D { * @dev: struct device * @pctldev: pin controller device * @pinctrl_desc: pin controller description - * @name: Chip controller name * @tpin: Total number of pins * @gpio_reset: GPIO line handler that can reset the IC */ @@ -167,7 +166,6 @@ struct cy8c95x0_pinctrl { struct device *dev; struct pinctrl_dev *pctldev; struct pinctrl_desc pinctrl_desc; - char name[32]; unsigned int tpin; struct gpio_desc *gpio_reset; }; @@ -1414,15 +1412,12 @@ static int cy8c95x0_probe(struct i2c_client *client) =20 switch (chip->tpin) { case 20: - strscpy(chip->name, cy8c95x0_id[0].name); regmap_range_conf.range_max =3D CY8C95X0_VIRTUAL + 3 * MUXED_STRIDE - 1; break; case 40: - strscpy(chip->name, cy8c95x0_id[1].name); regmap_range_conf.range_max =3D CY8C95X0_VIRTUAL + 6 * MUXED_STRIDE - 1; break; case 60: - strscpy(chip->name, cy8c95x0_id[2].name); regmap_range_conf.range_max =3D CY8C95X0_VIRTUAL + 8 * MUXED_STRIDE - 1; break; default: --=20 2.50.1 From nobody Fri Apr 17 04:47:45 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CE2B33F371; Mon, 23 Feb 2026 18:09:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870149; cv=none; b=j9jdCUGMvELeWmgUQmzjIZnwh965Iqh/ECkXXeCuHb+3C37mfk9CKZpRPL13DBt2r0ktWbf8IjDG5GKMc1ggoy2b8JBJOUMrgfDiGziagWUmukOQEwq0XBNVW9b/+ruOD449SJqClCX9x2cyYcr63ljGTpS/w/MNMC7yReuU/Fo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870149; c=relaxed/simple; bh=GnCEAgfXe/6YcH+5eY7mUfjQLT+Zjz/ERVUf0MC9iBI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LnYbn6fwd+fyJqHr+p6G1xuQlZwwKkQnpkmvheQLYnHIzQmWjDF2D7Up4GP3Ur/oL/jzfRbu+m08NfXlZIb/ONDO1W0zU7pkBTL60OibH37lJJOzxX1JWXVSmb6iTW6vA0mXWGos7otZ/ZZS5wqWugScTemnAdUp359Jjj+pTBs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KZxFdR7E; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KZxFdR7E" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771870148; x=1803406148; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GnCEAgfXe/6YcH+5eY7mUfjQLT+Zjz/ERVUf0MC9iBI=; b=KZxFdR7Evb4SAgJgywrywGRXiFTwsHMPfqynsjt+Z5ezosl7650e2Q1n s7oky3o5/i+41zV/Whr9ThY/q8B+JJ+n+b5zft3K1UJt0x3TQk8m5OKXx WT14neiCXJPDfaZaNVBgp47pUF1iWfEZRWYd1z2UmaHF7CsTrnSrjebrt LB39mGjeEDYOcSuu0GFn4tS3poOV4O5aW+EXThhNs6BBNja0y/Z66VGyj PIclEu05HVSZJwLW5YqpvCEUT/I9qguk/1qNJf7M1wLVimjLHMSYKDFGv qa7FaP1JJDkKIhzJcyRyxMzpb7RTwjx48frf1UPTBVxSqtA9FOaC2oU5M A==; X-CSE-ConnectionGUID: S9OWSNzKQxW4/5VvVH4SnQ== X-CSE-MsgGUID: 0W4Uj9icSG2/hysn/asQVw== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="76737710" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="76737710" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 10:09:05 -0800 X-CSE-ConnectionGUID: SCTE6zLYTLKMLSSMCHA7pA== X-CSE-MsgGUID: PNJwIFP9QeehAicR2hWw5Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="253369517" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa001.jf.intel.com with ESMTP; 23 Feb 2026 10:09:04 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 3F503A4; Mon, 23 Feb 2026 19:09:01 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Patrick Rudolph , Linus Walleij Subject: [PATCH v1 7/8] =?UTF-8?q?pinctrl:=20cy8c95x0:=20Eliminate=20fragi?= =?UTF-8?q?le=20use=20of=20I=C2=B2C=20ID=20table?= Date: Mon, 23 Feb 2026 19:06:57 +0100 Message-ID: <20260223180859.2845261-8-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260223180859.2845261-1-andriy.shevchenko@linux.intel.com> References: <20260223180859.2845261-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The I=C2=B2C ID table is a subject to new entries that may potentially break the order of the existing ones. Avoid this by using string literals for the chip naming. Note, linker will deduplicate same string literals and use only a single copy, hence it won't be the change in size in data section. Signed-off-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-cy8c95x0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-c= y8c95x0.c index 0bcc9ac19696..1d3e0617b235 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -1369,13 +1369,13 @@ static int cy8c95x0_detect(struct i2c_client *clien= t, return ret; switch (ret & GENMASK(7, 4)) { case 0x20: - name =3D cy8c95x0_id[0].name; + name =3D "cy8c9520"; break; case 0x40: - name =3D cy8c95x0_id[1].name; + name =3D "cy8c9540"; break; case 0x60: - name =3D cy8c95x0_id[2].name; + name =3D "cy8c9560"; break; default: return -ENODEV; --=20 2.50.1 From nobody Fri Apr 17 04:47:45 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70BE633BBB9; Mon, 23 Feb 2026 18:09:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870146; cv=none; b=CeFYYZxm/f5fzIEO3P4h7rfkTyi60ZA8UT+t/Of6dDF3qNydp2rhQa76GLdSWM745g7vb1qyF9Dkyho9dOPDByITkMti6Yl9rDjzGRQcuPbHQvFF/jH8uPYK1ptDP7lRoE55Ex6Zd8ucrcFcjZvjHDPFCHQhGKUTjxueY1clMq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870146; c=relaxed/simple; bh=kOB+dAnEOO05y6UZt1KP3bLWhO3E4YCvQWjyKGXAT4k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lzA+FA9iwIUdtGcc0WqFOlFoYetkhQ9wuNPW9tpiCg8sXqbs8AX+K9Fcffr+QL3CT1SOdf9Rq/pJkE81l+jFKvEea1oQHam1JrrXWsLPoQSNDeAa7unMEqNrb39iJCcvgOs2Y27LSEaG8autC7XEy3AwynXbSElkWJr1akOlgDM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HEVXFN+7; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HEVXFN+7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771870145; x=1803406145; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kOB+dAnEOO05y6UZt1KP3bLWhO3E4YCvQWjyKGXAT4k=; b=HEVXFN+7YOsceE4+9KEsb6V/1EXeKIHdKbB3s0DWWI1bU+l1i8M9qwQS OjLt0y5CCRsI7+v6JkvqZLaWOZSR30c69f+kpCH9XpUj/AAsuNQi955FI 4Vh3sIzomckiWGhiLa3zA0Mq+R9i8xnNNXK0hJnby5v7G8KUEwKhWbjl1 TjiLn2NhRvQDDI2jLPJ3P7xP7YM0JC03hPwrfdEvRJU84Br4FQt+jWi+V Wu1EC6bV+IkUZldkoAfQK/64qLMwwcNhcRLfYN+JoFqQfAWy36AjfFd9d 7J8CZwys0ShNIH2D+4AbHJFyzy0rvtpxXdIEXIB/FaGbktqZ81n4pl7C8 g==; X-CSE-ConnectionGUID: kqGeYHH+S66YDJ3XohiJDg== X-CSE-MsgGUID: zsx3Ql/rTB+ogbHTEKYBKQ== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="72082657" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="72082657" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 10:09:05 -0800 X-CSE-ConnectionGUID: Sy9SHbzGRAm6jLh2rURfwQ== X-CSE-MsgGUID: 2yUI6CCqTLK8H61+Ix3/Hw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="238599658" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa002.fm.intel.com with ESMTP; 23 Feb 2026 10:09:04 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 435E7A5; Mon, 23 Feb 2026 19:09:01 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Patrick Rudolph , Linus Walleij Subject: [PATCH v1 8/8] pinctrl: cy8c95x0: Gather ID tables in one place Date: Mon, 23 Feb 2026 19:06:58 +0100 Message-ID: <20260223180859.2845261-9-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260223180859.2845261-1-andriy.shevchenko@linux.intel.com> References: <20260223180859.2845261-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We have three ID tables spread over the driver code. Move all of them closer to the end of the file where the first user appears to be. With that done, drop unneeded trailing commas. Signed-off-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-cy8c95x0.c | 38 +++++++++++++++--------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-c= y8c95x0.c index 1d3e0617b235..0d295ebc33d1 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -72,24 +72,6 @@ #define CY8C95X0_MUX_REGMAP_TO_OFFSET(x, p) \ (CY8C95X0_VIRTUAL + (x) - CY8C95X0_PORTSEL + (p) * MUXED_STRIDE) =20 -static const struct i2c_device_id cy8c95x0_id[] =3D { - { "cy8c9520", 20, }, - { "cy8c9540", 40, }, - { "cy8c9560", 60, }, - { } -}; -MODULE_DEVICE_TABLE(i2c, cy8c95x0_id); - -#define OF_CY8C95X(__nrgpio) ((void *)(__nrgpio)) - -static const struct of_device_id cy8c95x0_dt_ids[] =3D { - { .compatible =3D "cypress,cy8c9520", .data =3D OF_CY8C95X(20), }, - { .compatible =3D "cypress,cy8c9540", .data =3D OF_CY8C95X(40), }, - { .compatible =3D "cypress,cy8c9560", .data =3D OF_CY8C95X(60), }, - { } -}; -MODULE_DEVICE_TABLE(of, cy8c95x0_dt_ids); - static const struct acpi_gpio_params cy8c95x0_irq_gpios =3D { 0, 0, true }; =20 static const struct acpi_gpio_mapping cy8c95x0_acpi_irq_gpios[] =3D { @@ -1478,8 +1460,26 @@ static int cy8c95x0_probe(struct i2c_client *client) return cy8c95x0_setup_gpiochip(chip); } =20 +static const struct i2c_device_id cy8c95x0_id[] =3D { + { "cy8c9520", 20 }, + { "cy8c9540", 40 }, + { "cy8c9560", 60 }, + { } +}; +MODULE_DEVICE_TABLE(i2c, cy8c95x0_id); + +#define OF_CY8C95X(__nrgpio) ((void *)(__nrgpio)) + +static const struct of_device_id cy8c95x0_dt_ids[] =3D { + { .compatible =3D "cypress,cy8c9520", .data =3D OF_CY8C95X(20) }, + { .compatible =3D "cypress,cy8c9540", .data =3D OF_CY8C95X(40) }, + { .compatible =3D "cypress,cy8c9560", .data =3D OF_CY8C95X(60) }, + { } +}; +MODULE_DEVICE_TABLE(of, cy8c95x0_dt_ids); + static const struct acpi_device_id cy8c95x0_acpi_ids[] =3D { - { "INT3490", 40, }, + { "INT3490", 40 }, { } }; MODULE_DEVICE_TABLE(acpi, cy8c95x0_acpi_ids); --=20 2.50.1