From nobody Sun Apr 5 20:03:34 2026 Received: from mail-dl1-f98.google.com (mail-dl1-f98.google.com [74.125.82.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E06A3313E29 for ; Mon, 23 Feb 2026 16:38:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.98 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771864682; cv=none; b=NQRC0EYmomFjrfHcjkBtW+IbIm4huoRGElE/rXtvzSuSry54y6KUOJ3/CeZjkwFUOsE5tGsRWVlnutf6jIufIH2KJqroY7UrVKOWauBpJxojwJxwDvgZjyuu2pFAewx2MGyrmCdnDq5RSVAHOEzuUUMewa8jAfC7/A2/8HM8nRc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771864682; c=relaxed/simple; bh=EDNg3P30qp6TpoJ+LaUb8hlMM2SdRTBe0QhS1deiRbE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BMYhSxMMZNh8ZNdzoL8UNbZZE8ugoVLQRWGDYVIOQRY8wWAwQBBXTy1iwpEQZ314hAmBPsTeY033zYM5hIU9h+LDgU0mBK2EZbEkcsqOoX4bt/C0IV8YkytGL3Pph5W2/pS5GMw7Y5QMnWQb2a8yCiAO+j8y6b3epGQWD8b3Vnc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=GaIvDxCf; arc=none smtp.client-ip=74.125.82.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="GaIvDxCf" Received: by mail-dl1-f98.google.com with SMTP id a92af1059eb24-1270ac5d3efso4041937c88.1 for ; Mon, 23 Feb 2026 08:38:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771864680; x=1772469480; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=moTkq8uSx6FpuB82+cTHGTek2ppzwZXDRC3f5Mlpkf4=; b=s83xfrHbeA/g7wFkaw+6FJZG9WWa51kzYYuorPJvIyT4RZi0glBAoeTb7i5xDtiF40 TLOxtNN8HFJpCc0SCyF8US9UGyV3vtd0X9Afa5RB0GmEo4Um2gBpTKUsYos4G9k+UbTm GRb0QjoJ6602ws9JNgduMX4dXJJm4FfJxDfhSwKfCOM3L3rJHEVGl29j3Gjl1fQLXAJB yD3G/ISjn+91/g4E2xwF9N7/Sdg6Z7vB+SBXsmvqw61itHIFpt+bRNw3dey2Icwunvps jS/z/R/13t42obrzRUCt9ECQqlN/TB6EU0QyLKrmrfrA6lPhEhyNOJjzH7M33e41XHm0 hkEQ== X-Forwarded-Encrypted: i=1; AJvYcCW01exG45QIvHWCFxqgRd+Clod6yznXEotAOzhw7i/K5YESoJojOGSmQvD8B6js3cha21soSPyuNvwkgGg=@vger.kernel.org X-Gm-Message-State: AOJu0YxVwo9dZvaTYp+erHHmTqnc+Sezg6OcdqTxLhQpkXlr3Nz2r//6 6P7cE4c5N7PVHkgq7ebWn8EYDISv3gu6elt4+uO+F5UpuioVRf4nNK75Jk4FzhLZGHXa9whdf9q /enSfU9WLTW1XR7hvZVzTt/tgkSsU/JFNT54+aJJZhKj9rSUPHqPCQkqp3IMheFF3KOWou5rQZC txhJwsAcXWrS2hFaLQTLha6eTFBuRd4SuCdmbbH4bgNW6qJZEwFiXj56fRj+lWdUDHRoTreav64 9PIicRjJdilUWqEiaIhWh0BqA== X-Gm-Gg: ATEYQzztcHypp9G3kE/ZzsEh8ezIzkXnQ5cLmzNslORSGlQcvTCOXSdHbPzAnR4e3Z1 5C1MrrFW47JAyvlUDx+FqZ7sdFp/5s+2Y0/QFLsVN0idjBZacUeYzcve04GIi3NpWqjmfHieRIZ lajzFa/QBEuZHCZAK6w31+X36GTjWD5zCwoGtqzAEQJDgsNmQVM/7vx6PQkbQC8nRKlIzWGMbwB AjD0GIGgkuNRibs6jLzTlarUOBGTVGeD8EARh16yVdqg+3Te7D05WYMIdQ5q5rTlysusLJrv9IC v1otTlrmP/v4xGMvJpW5uGdE1dOhN0gN876qDymOF+a+NtZ4OA6j+U7aHnMenCVpocI3G412+kO mkiyt6e4oN0SVeesEjgnMQ46uAZPQ6qfpb5+uZJJSZp1672AGMc0LfOLh6nzxcHe0kRUpzHyxRr +qWqGTsmXdU0DhDq9JrhT0S/9j+ehX53h6Vohf7IImmTTiS5RgJYg41m0CTlLaiCA= X-Received: by 2002:a05:7301:418b:b0:2ba:7f8c:6754 with SMTP id 5a478bee46e88-2bd7bd99977mr3003205eec.37.1771864679730; Mon, 23 Feb 2026 08:37:59 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-25.dlp.protect.broadcom.com. [144.49.247.25]) by smtp-relay.gmail.com with ESMTPS id 5a478bee46e88-2bd7da826fbsm818081eec.3.2026.02.23.08.37.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2026 08:37:59 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2aaf2f3bef6so47362455ad.0 for ; Mon, 23 Feb 2026 08:37:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1771864678; x=1772469478; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=moTkq8uSx6FpuB82+cTHGTek2ppzwZXDRC3f5Mlpkf4=; b=GaIvDxCfKS2/FzTqjq8lsPZwewVI1IAz6wPNlzqvLzCDmnNXcRoTuCJ0FdOHqwNZS7 W9pWLh7NcO0VC30lgIPHEqRFk0vRdp7XUscmjYFcmPljk41g310Q6PS7JhfhRBwPZgH1 3/I0AUgnfyyyFDSNmbjVQT889YmlL+qS9e/Mc= X-Forwarded-Encrypted: i=1; AJvYcCUJUE33CoDFWjaaFsqH09dlSFYyiyNbOMLoOQy2tKTTWeNktpyydEx5B4I8bPeiw/v2ktaIleTADkxpRCo=@vger.kernel.org X-Received: by 2002:a17:903:3bcc:b0:2a9:4369:940c with SMTP id d9443c01a7336-2ad745a8ce1mr89168545ad.53.1771864677965; Mon, 23 Feb 2026 08:37:57 -0800 (PST) X-Received: by 2002:a17:903:3bcc:b0:2a9:4369:940c with SMTP id d9443c01a7336-2ad745a8ce1mr89168325ad.53.1771864677495; Mon, 23 Feb 2026 08:37:57 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad74e3445fsm96763825ad.13.2026.02.23.08.37.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 08:37:57 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Ajit Kumar Khaparde Subject: [PATCH net-next 7/7] bng_en: implement ndo_get_stats64 Date: Mon, 23 Feb 2026 22:06:41 +0530 Message-ID: <20260223163641.755200-8-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260223163641.755200-1-bhargava.marreddy@broadcom.com> References: <20260223163641.755200-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Implement the ndo_get_stats64 callback to report aggregate network statistics. The driver gathers these by accumulating the per-ring counters into the provided rtnl_link_stats64 structure. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 108 ++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 11 +- 2 files changed, 118 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index e2715419b6f..c6079b4c949 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2939,6 +2939,106 @@ static int bnge_shutdown_nic(struct bnge_net *bn) return 0; } =20 +static void bnge_get_ring_stats(struct bnge_dev *bd, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr =3D &bnapi->nq_ring; + u64 *sw =3D nqr->stats.sw_stats; + + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); + + stats->rx_missed_errors +=3D + BNGE_GET_RING_STATS64(sw, rx_discard_pkts); + + stats->multicast +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + + stats->tx_dropped +=3D BNGE_GET_RING_STATS64(sw, tx_error_pkts); + + stats->rx_dropped +=3D + nqr->sw_stats->rx.rx_netpoll_discards + + nqr->sw_stats->rx.rx_oom_discards; + } +} + +static void bnge_add_prev_stats(struct bnge_net *bn, + struct rtnl_link_stats64 *stats) +{ + struct rtnl_link_stats64 *prev_stats =3D &bn->net_stats_prev; + + stats->rx_packets +=3D prev_stats->rx_packets; + stats->tx_packets +=3D prev_stats->tx_packets; + stats->rx_bytes +=3D prev_stats->rx_bytes; + stats->tx_bytes +=3D prev_stats->tx_bytes; + stats->rx_missed_errors +=3D prev_stats->rx_missed_errors; + stats->multicast +=3D prev_stats->multicast; + stats->rx_dropped +=3D prev_stats->rx_dropped; + stats->tx_dropped +=3D prev_stats->tx_dropped; +} + +static void bnge_get_stats64(struct net_device *dev, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_dev *bd =3D bn->bd; + + set_bit(BNGE_STATE_READ_STATS, &bn->state); + /* Make sure bnge_close_core() sees that we are reading stats before + * we check the BNGE_STATE_OPEN flag. + */ + smp_mb__after_atomic(); + if (!test_bit(BNGE_STATE_OPEN, &bd->state)) { + clear_bit(BNGE_STATE_READ_STATS, &bn->state); + *stats =3D bn->net_stats_prev; + return; + } + + bnge_get_ring_stats(bd, stats); + bnge_add_prev_stats(bn, stats); + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + u64 *rx =3D bn->port_stats.sw_stats; + u64 *tx =3D bn->port_stats.sw_stats + + BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + + stats->rx_crc_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_fcs_err_frames); + stats->rx_frame_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_align_err_frames); + stats->rx_length_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_undrsz_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_ovrsz_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_runt_frames); + stats->rx_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_false_carrier_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_jbr_frames); + stats->collisions =3D + BNGE_GET_TX_PORT_STATS64(tx, tx_total_collisions); + stats->tx_fifo_errors =3D + BNGE_GET_TX_PORT_STATS64(tx, tx_fifo_underruns); + stats->tx_errors =3D BNGE_GET_TX_PORT_STATS64(tx, tx_err); + } + clear_bit(BNGE_STATE_READ_STATS, &bn->state); +} + static void bnge_close_core(struct bnge_net *bn) { struct bnge_dev *bd =3D bn->bd; @@ -2954,6 +3054,13 @@ static void bnge_close_core(struct bnge_net *bn) bnge_shutdown_nic(bn); bnge_disable_napi(bn); timer_delete_sync(&bn->timer); + + /* Save ring stats before shutdown */ + if (bn->bnapi) { + bnge_get_ring_stats(bd, &bn->net_stats_prev); + bnge_get_ring_err_stats(bn, &bn->ring_err_stats_prev); + } + bnge_free_all_rings_bufs(bn); bnge_free_irq(bn); bnge_del_napi(bn); @@ -3003,6 +3110,7 @@ static const struct net_device_ops bnge_netdev_ops = =3D { .ndo_open =3D bnge_open, .ndo_stop =3D bnge_close, .ndo_start_xmit =3D bnge_start_xmit, + .ndo_get_stats64 =3D bnge_get_stats64, .ndo_features_check =3D bnge_features_check, }; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 107c8a69c93..4b68a8ed229 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -227,6 +227,12 @@ struct bnge_tpa_info { #define BNGE_GET_RING_STATS64(sw, counter) \ (*((sw) + offsetof(struct ctx_hw_stats, counter) / 8)) =20 +#define BNGE_GET_RX_PORT_STATS64(sw, counter) \ + (*((sw) + offsetof(struct rx_port_stats, counter) / 8)) + +#define BNGE_GET_TX_PORT_STATS64(sw, counter) \ + (*((sw) + offsetof(struct tx_port_stats, counter) / 8)) + #define BNGE_PORT_STATS_SIZE \ (sizeof(struct rx_port_stats) + sizeof(struct tx_port_stats) + 1024) =20 @@ -285,6 +291,7 @@ struct bnge_sw_stats { enum bnge_net_state { BNGE_STATE_NAPI_DISABLED, BNGE_STATE_IN_SP_TASK, + BNGE_STATE_READ_STATS, }; =20 #define BNGE_TIMER_INTERVAL HZ @@ -377,6 +384,7 @@ struct bnge_net { =20 u64 flags; =20 + struct rtnl_link_stats64 net_stats_prev; struct bnge_total_ring_err_stats ring_err_stats_prev; =20 struct bnge_stats_mem port_stats; @@ -650,7 +658,8 @@ struct bnge_l2_filter { =20 static inline bool bnge_drv_busy(struct bnge_net *bn) { - return test_bit(BNGE_STATE_IN_SP_TASK, &bn->state); + return test_bit(BNGE_STATE_IN_SP_TASK, &bn->state) || + test_bit(BNGE_STATE_READ_STATS, &bn->state); } =20 u16 bnge_cp_ring_for_rx(struct bnge_rx_ring_info *rxr); --=20 2.47.3