From nobody Sun Apr 5 19:53:14 2026 Received: from mail-pf1-f227.google.com (mail-pf1-f227.google.com [209.85.210.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C6E93271EA for ; Mon, 23 Feb 2026 16:37:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771864677; cv=none; b=fjXTpVbxaSg1kx36s+SD7TYSPAyUj/eByXYsV4ooR0BhIxcfMSXCRj4SZTNphsL/s/lKdnDAFVqsNv5WhJbAVrYZf/+SEvpHwvbvde4a39RmOf5MJTKytrr9SF0oYFB+wxmF43hvp6yce0GtmfHy69gq0gQ/YBTyCTUEoFQ8U+M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771864677; c=relaxed/simple; bh=AdKt8wrJmv4nluSRJ1kG2mGHhXNw88ryp6gQeexchcs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lKIXVlplY7WJyzs27+xZBMEIuuz+WTSPuNpuPL+w4gDqCA4mkPAdgLJ6gZ9qiBl22GUJGYkN4rrNi8I0KuqeZ36h0ky78nE/VD87NQZw1LQJlKmnFCxhC1Hz3/E9lgO1UyysWQBIfLbHZ3c0qDS8/praaNpStpZAzrm+wHin1Fs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=aCGcL5YH; arc=none smtp.client-ip=209.85.210.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="aCGcL5YH" Received: by mail-pf1-f227.google.com with SMTP id d2e1a72fcca58-824b05d2786so3407333b3a.2 for ; Mon, 23 Feb 2026 08:37:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771864675; x=1772469475; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mi7jWd0C81kE5nB7PeuEALk1pyyWsZNcqCAZ39HdnzE=; b=iFoXnABt3iXyjtLwTkVi4+mVcMFintcgNsRR1/ccl6vEhY4Go4JxFif4JLX8bX1vU6 2Meb9IeVMpZMoRfAPYtgleJpOA0BYtd+GzEzA+qsfAu+L1gNOnYnPXtxsuxYVfp7SfGt qGiAGSfElt8reWDUsb4YFF4PQxcuLDyRO3NqIyCurbcB6y90p7epiM9A28nXwzSv8mkR KOb5ANs/rUIaQlSVHz6f5SIoaWpl8LY5ii26jSH33KOcLR6+XjlNUSUQGJgkR7xdc0jB MbwWQOXSWDtkeQAbuanqkMSCwrp/ui6qHjOP3szFtd6+wPkW3btQWLsrIK0RqzD47KE0 CVYQ== X-Forwarded-Encrypted: i=1; AJvYcCXxLxGzyO19lt7F0c87iDQXcUlzfH0FoVS1TLMIvNDSsII0k5uWwrsuCntyNWfieIf1URs7pggtwJ7J1Kc=@vger.kernel.org X-Gm-Message-State: AOJu0YyN92nNOxUa29s1LUjtOKQ0xCxVP9CQ0ocUEgzIr+pzLjE9wUTk uK7ppCSWVe4/GgaxqN6OgFmQg6Dp9ZnSB3c7pJiDmHKgSTWeFV3bwBDLvGBWeUePZOjPLjfNCFH MCccrGeCp6E7IeEwTlB8VBFJsOBJv9ZvZfxC7a6gkzdbOSC19B/y+K+ltXe1iBsoXl/ExRXWxgK 8WIZ0XvFChEcnYt+vOt1vPdJvl1VcOiUSQ2lBsISUqSVrQ/em8O63lHXmLtoXf1O2lsMQqCGgKw ooEoVGSJHJy6mHHlLbH6T2Atg== X-Gm-Gg: AZuq6aIrF5iLGXgBpVgxaNCT7X5RiprJa9GBEo+eSNDIO3lVDsyOz0kFhKjYukTy3Gn B18nKJu3aPvpZx6rAgOy5N6sfCmYEWKkUvFwe29ujpr4ZjZG9pWvnz66f/+Uwr2j5wWdfmn8ZRb Ix83stt4eM/78l5l04KnJ6zTG7AFNqV7E8iie33KVc7zjellUAT1zcbk0O5gXnKk/xLXzI5ohjO ngiwWsOFm41eEd7sdHsI1ZuNS91JU46JZTSHifE5sqtQdyRNl3oJmTtN4P3M7YTFtek5RuI/3Hf 9DlGZ5e81h5xEOfv6Atcwjt8VdMIk4KoSSvJqsgIqSyVxgeFfmndxc2077CjoLc/ss+nzCZ/6sb j0l75VzHVuqFhy2RrKx6p237EDvw43dADAPn+o6OnM9DUx90unPuWZbvxcGpzcHKbEqIe6pilTR 06xi+yhUKE2AFGeEw026An/FQBK5muHg5/0d8OJA1F+ywAatHi5xZQex4UKINN2P8bDA== X-Received: by 2002:aa7:8892:0:b0:81a:b183:44fc with SMTP id d2e1a72fcca58-826da906ffcmr7576321b3a.23.1771864675342; Mon, 23 Feb 2026 08:37:55 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-103.dlp.protect.broadcom.com. [144.49.247.103]) by smtp-relay.gmail.com with ESMTPS id d2e1a72fcca58-826dd875617sm972341b3a.9.2026.02.23.08.37.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2026 08:37:55 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a7b7f04a11so332879115ad.3 for ; Mon, 23 Feb 2026 08:37:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1771864673; x=1772469473; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mi7jWd0C81kE5nB7PeuEALk1pyyWsZNcqCAZ39HdnzE=; b=aCGcL5YHUPBxa4M3U4+iDHT1t1DcLe3M6J7lN8zZ4Ll906NLg/fyWKwieqlI8Pxdgy 2dynVHEsGRXYe5K3qM9jyFbRWbbhr5AdlF2LshgC3H0y1ctULuIlLZoueAyJURrTew/L 9J4khxRkDSPydWk0vJ0sDDG6XayrTgNsXZERs= X-Forwarded-Encrypted: i=1; AJvYcCWYSbQKaHQEszWbR+PiR9qFrlAT1I0VJ9wzTWXbkKoo0gkaGSIX2dKHP24bPCbkAU26AVo7RYzBsrQY/eo=@vger.kernel.org X-Received: by 2002:a17:903:f87:b0:2a0:8be7:e3d7 with SMTP id d9443c01a7336-2ad7456f999mr66521005ad.57.1771864673457; Mon, 23 Feb 2026 08:37:53 -0800 (PST) X-Received: by 2002:a17:903:f87:b0:2a0:8be7:e3d7 with SMTP id d9443c01a7336-2ad7456f999mr66520845ad.57.1771864673038; Mon, 23 Feb 2026 08:37:53 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad74e3445fsm96763825ad.13.2026.02.23.08.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 08:37:52 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rahul Gupta , Ajit Kumar Khaparde Subject: [PATCH net-next 6/7] bng_en: periodically fetch and accumulate hardware statistics Date: Mon, 23 Feb 2026 22:06:40 +0530 Message-ID: <20260223163641.755200-7-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260223163641.755200-1-bhargava.marreddy@broadcom.com> References: <20260223163641.755200-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Use the timer to schedule periodic stats collection via the workqueue when the link is up. Fetch fresh counters from hardware via DMA and accumulate them into 64-bit software shadows, handling wrap-around for counters narrower than 64 bits. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rahul Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 90 +++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + 2 files changed, 91 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 6589fbdb47f..e2715419b6f 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -325,10 +325,94 @@ static void bnge_timer(struct timer_list *t) } } =20 + if (BNGE_LINK_IS_UP(bd) && bn->stats_coal_ticks) + bnge_queue_sp_work(bn, BNGE_PERIODIC_STATS_SP_EVENT); + bnge_restart_timer: mod_timer(&bn->timer, jiffies + bn->current_interval); } =20 +static void bnge_add_one_ctr(u64 hw, u64 *sw, u64 mask) +{ + u64 sw_tmp, sw_val; + + hw &=3D mask; + sw_val =3D READ_ONCE(*sw); + sw_tmp =3D (sw_val & ~mask) | hw; + if (hw < (sw_val & mask)) + sw_tmp +=3D mask + 1; + WRITE_ONCE(*sw, sw_tmp); +} + +static void __bnge_accumulate_stats(__le64 *hw_stats, u64 *sw_stats, u64 *= masks, + int count) +{ + int i; + + for (i =3D 0; i < count; i++) { + u64 hw =3D le64_to_cpu(READ_ONCE(hw_stats[i])); + + if (masks[i] =3D=3D -1ULL) + sw_stats[i] =3D hw; + else + bnge_add_one_ctr(hw, &sw_stats[i], masks[i]); + } +} + +static void bnge_accumulate_stats(struct bnge_stats_mem *stats) +{ + if (!stats->hw_stats) + return; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + stats->hw_masks, stats->len / 8); +} + +static void bnge_accumulate_all_stats(struct bnge_dev *bd) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + struct bnge_stats_mem *ring0_stats =3D NULL; + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr; + struct bnge_stats_mem *stats; + + nqr =3D &bnapi->nq_ring; + stats =3D &nqr->stats; + + if (!ring0_stats) + ring0_stats =3D &bn->bnapi[0]->nq_ring.stats; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + ring0_stats->hw_masks, + ring0_stats->len / 8); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + struct bnge_stats_mem *stats =3D &bn->port_stats; + __le64 *hw_stats =3D stats->hw_stats; + u64 *sw_stats =3D stats->sw_stats; + u64 *masks =3D stats->hw_masks; + int cnt; + + cnt =3D sizeof(struct rx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + + hw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + sw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + masks +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + cnt =3D sizeof(struct tx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS_EXT) { + bnge_accumulate_stats(&bn->rx_port_stats_ext); + bnge_accumulate_stats(&bn->tx_port_stats_ext); + } +} + static void bnge_sp_task(struct work_struct *work) { struct bnge_net *bn =3D container_of(work, struct bnge_net, sp_task); @@ -342,6 +426,12 @@ static void bnge_sp_task(struct work_struct *work) return; } =20 + if (test_and_clear_bit(BNGE_PERIODIC_STATS_SP_EVENT, &bn->sp_event)) { + bnge_hwrm_port_qstats(bd, 0); + bnge_hwrm_port_qstats_ext(bd, 0); + bnge_accumulate_all_stats(bd); + } + if (test_and_clear_bit(BNGE_UPDATE_PHY_SP_EVENT, &bn->sp_event)) { int rc; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 65cbdcc9d30..107c8a69c93 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -299,6 +299,7 @@ enum bnge_sp_event { BNGE_LINK_SPEED_CHNG_SP_EVENT, BNGE_LINK_CFG_CHANGE_SP_EVENT, BNGE_UPDATE_PHY_SP_EVENT, + BNGE_PERIODIC_STATS_SP_EVENT, }; =20 struct bnge_net { --=20 2.47.3