From nobody Sun Apr 5 19:49:52 2026 Received: from mail-pl1-f225.google.com (mail-pl1-f225.google.com [209.85.214.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E4662F6925 for ; Mon, 23 Feb 2026 16:37:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771864653; cv=none; b=h6EGA1faqa9HZmQ+yDJG1rfm1jOFjswXU78nQjN2YmpnTpZhPBhaq+wOgePqmzUSRbdvgkfSVB5XwGUdl3mr1U2LSspsdGI2lqHo/fcR6uBBmrtOZS9G+WCcYIq1hzI3aohEvd8XYSLEeT/8BPdhW3vi0+G2XuICbX88XZBWBss= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771864653; c=relaxed/simple; bh=1PI8WR/QfyYhgdDskRti90NGiPXxK286+GwVSfvHDnU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FqPfgiMV6jH+cxrq0XaXC2Mn1agAEs5DfjbKFFfx9i6M0gBCTCN/QxpUjt7lKDV5Q+avt1OL4EkOmFPXT8rDxVZmV2NHbtXCJ+fAzT4R5+31cvVQmcy+I9Sfxi2Fpc+2LulZVJtvNfyxxIMrgkvMh7zwXU1ID/dBx1nleh1Kc18= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=LvgS8d72; arc=none smtp.client-ip=209.85.214.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="LvgS8d72" Received: by mail-pl1-f225.google.com with SMTP id d9443c01a7336-2a9296b3926so30965365ad.1 for ; Mon, 23 Feb 2026 08:37:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771864651; x=1772469451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fuYgrfs/Q0g/vVNofvxW+PM6Q1g2Ph6NmJqvydo7chw=; b=Q+fmsfHxIj0crcr4g2nLULNMeHZjA/NdypX7jl/EFELGigMwvhTCfCcSh61lvPgoyc D31Y+funHrhD+6Wg3yERN28Nw1TdFZw2wIJ/gXonGdZFuJOQB+jdaY6BgASxhJAX2vTz xqhSm8cMLlhfACy5uO6MWyONEkXxzBhwol8b+ULEpx1HChObtMOuvrKw4BW+wHVp/d/Q TfTnODqjsOrO/hhWIgkuFOrUqxZ/qZPz8BFbUq20QDnnXrgbeiBcJlVBdPbSXV7RlWyp wFeDcx7SPkrV7E2LDHoSw7qAroMWW6GJgciq/38Eg5F7Hzqvc0o5feqBBo8rVpN8pZQC frWA== X-Forwarded-Encrypted: i=1; AJvYcCVywGOdCkm35YMXqEP7j++kNFuEY0GvUtarIUO/aWeBEXRoeuxEMaX/V2uYeMsJy+elO4RbZAx0TVwpLl4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9lIcquqkJ/1cPL3KfG4qR70+mEmMyM/BHtxZyiwBFrY2km2Fv IzYuQAitfD1MVSGgMW7iNdjrEznxFbhg8kevNUYve14UZqsW0oOrnI8JS0BSJiqTZ3NY81cYgBu 5Mno/1eOOjKIjwX29wMOxUY63dc2weELLognGA7yHHY1624Z3CKk7e+NjEgpd+RkS7iQ8qjs1qK rxPQoGQSUMf9SLvtf639iIRYluXOLu0onuXLmb+PA0wQ6Y1UZhRyJCfABn7L/WEhIGp+ZTlJZy8 kDdclse3EOm7BIoobhY7KCkkg== X-Gm-Gg: ATEYQzyk3LzTQ7kpEvkHTSRY4oF83MSWVZKcUzw2SIAnaqz91i7mgrc0rBnjt4NerSY 8TJHoQDpQAKxDPG9ZP0tXlIUUIOvAimQZYl/BRag4xJ5Fz+kNufLqsD5r/l+1RnNeeX6b797u1B eUAVTYf5nM2jVDTsIItNXJ21F3bm++ZG/9v+rmHp/fYEhB6G3mJnR6RcVkYqRWXw8KXuKCyFxSV MI1W2NRitvE1um6S8ZUcqsOgbl/hGP82izvaZ1h0Yy6gHBiZ3d4iPeTX6D6gNFGXs0JOol6zcRN 6Ms+rp1RUn005zXMQozCD4lRtbUS9sBMxd7zhf4ljn0k5BhkNSEYDQqUyNe9bJQIs2Iha8VaDNF K2yv/XrUes6GdRDwMq3/3XS6R1Zh4/YKlYa8LPdZpZ/XQjsvm8+X24Lm9mDqaPLK7MYBFD3FDXu dn0djVFrljy0efCFNOhdfFfLdDVlWublGdLZnCg7iUYOZwyj28H5R8ddusypf0Cva/tQ== X-Received: by 2002:a17:902:ce0e:b0:299:e031:173 with SMTP id d9443c01a7336-2ad744e0f75mr92614655ad.35.1771864651276; Mon, 23 Feb 2026 08:37:31 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-116.dlp.protect.broadcom.com. [144.49.247.116]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2ad74e1893bsm8752285ad.18.2026.02.23.08.37.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2026 08:37:31 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a92a3f5de9so25208075ad.2 for ; Mon, 23 Feb 2026 08:37:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1771864649; x=1772469449; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fuYgrfs/Q0g/vVNofvxW+PM6Q1g2Ph6NmJqvydo7chw=; b=LvgS8d72Vg05ok04ye/+CMCv3Cz2ZcYPaY2z6RvxtitHH7w833/zOeKebq0G59uqoy v4YTO7uVnqHfsS1Le+Vmv5+vosHU7YOYh1bSGnH+FmMcptNTIC2p9U9aILCtzzuE5NEU HUmeFOo0lHGI67tDr8AiI3gBGWPDuJA0iyBvI= X-Forwarded-Encrypted: i=1; AJvYcCVrwaqc+Ks00F8umQieaFGkPeq0Igi96qa/DAO2rfhUdGrnrpjmxUFo7lUv1M3X2YEKpZ+dGbS6/m4JpyY=@vger.kernel.org X-Received: by 2002:a17:903:3d0e:b0:2aa:f0ec:36f3 with SMTP id d9443c01a7336-2ad7457e700mr74915105ad.57.1771864649396; Mon, 23 Feb 2026 08:37:29 -0800 (PST) X-Received: by 2002:a17:903:3d0e:b0:2aa:f0ec:36f3 with SMTP id d9443c01a7336-2ad7457e700mr74914765ad.57.1771864648921; Mon, 23 Feb 2026 08:37:28 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad74e3445fsm96763825ad.13.2026.02.23.08.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 08:37:28 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Ajit Kumar Khaparde Subject: [PATCH net-next 1/7] bng_en: add per-PF workqueue, timer, and slow-path task Date: Mon, 23 Feb 2026 22:06:35 +0530 Message-ID: <20260223163641.755200-2-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260223163641.755200-1-bhargava.marreddy@broadcom.com> References: <20260223163641.755200-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Add a dedicated single-thread workqueue and a timer for each PF to drive deferred slow-path work such as link event handling and stats collection. An interrupt semaphore guards timer re-entry. The open and close paths now start and drain these resources. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 88 ++++++++++++++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 19 +++- 2 files changed, 105 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index b8e258842c6..a1bb1f01246 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -101,6 +101,44 @@ static int bnge_alloc_ring_stats(struct bnge_net *bn) return rc; } =20 +static void bnge_timer(struct timer_list *t) +{ + struct bnge_net *bn =3D timer_container_of(bn, t, timer); + struct bnge_dev *bd =3D bn->bd; + + if (!netif_running(bn->netdev) || + !test_bit(BNGE_STATE_OPEN, &bd->state)) + return; + + if (atomic_read(&bn->intr_sem) !=3D 0) + goto bnge_restart_timer; + + /* Periodic work added by later patches */ + +bnge_restart_timer: + mod_timer(&bn->timer, jiffies + bn->current_interval); +} + +static void bnge_sp_task(struct work_struct *work) +{ + struct bnge_net *bn =3D container_of(work, struct bnge_net, sp_task); + struct bnge_dev *bd =3D bn->bd; + + set_bit(BNGE_STATE_IN_SP_TASK, &bn->state); + /* Ensure sp_task state is visible before checking BNGE_STATE_OPEN */ + smp_mb__after_atomic(); + if (!test_bit(BNGE_STATE_OPEN, &bd->state)) { + clear_bit(BNGE_STATE_IN_SP_TASK, &bn->state); + return; + } + + /* Event handling work added by later patches */ + + /* Ensure all sp_task work is done before clearing the state */ + smp_mb__before_atomic(); + clear_bit(BNGE_STATE_IN_SP_TASK, &bn->state); +} + static void bnge_free_nq_desc_arr(struct bnge_nq_ring_info *nqr) { struct bnge_ring_struct *ring =3D &nqr->ring_struct; @@ -1960,6 +1998,7 @@ static void bnge_disable_int_sync(struct bnge_net *bn) struct bnge_dev *bd =3D bn->bd; int i; =20 + atomic_inc(&bn->intr_sem); bnge_disable_int(bn); for (i =3D 0; i < bd->nq_nr_rings; i++) { int map_idx =3D bnge_cp_num_to_irq_num(bn, i); @@ -1973,6 +2012,7 @@ static void bnge_enable_int(struct bnge_net *bn) struct bnge_dev *bd =3D bn->bd; int i; =20 + atomic_set(&bn->intr_sem, 0); for (i =3D 0; i < bd->nq_nr_rings; i++) { struct bnge_napi *bnapi =3D bn->bnapi[i]; struct bnge_nq_ring_info *nqr; @@ -2517,6 +2557,9 @@ static int bnge_open_core(struct bnge_net *bn) bnge_enable_int(bn); =20 bnge_tx_enable(bn); + + mod_timer(&bn->timer, jiffies + bn->current_interval); + return 0; =20 err_free_irq: @@ -2552,8 +2595,14 @@ static void bnge_close_core(struct bnge_net *bn) bnge_tx_disable(bn); =20 clear_bit(BNGE_STATE_OPEN, &bd->state); + /* Ensure BNGE_STATE_OPEN is cleared before checking drv_busy */ + smp_mb__after_atomic(); + while (bnge_drv_busy(bn)) + msleep(20); + bnge_shutdown_nic(bn); bnge_disable_napi(bn); + timer_delete_sync(&bn->timer); bnge_free_all_rings_bufs(bn); bnge_free_irq(bn); bnge_del_napi(bn); @@ -2700,6 +2749,23 @@ static void bnge_init_ring_params(struct bnge_net *b= n) bn->netdev->cfg->hds_thresh =3D max(BNGE_DEFAULT_RX_COPYBREAK, rx_size); } =20 +static struct workqueue_struct * +bnge_create_workqueue_thread(struct bnge_dev *bd, const char *thread_name) +{ + struct workqueue_struct *wq; + char *wq_name; + + wq_name =3D kasprintf(GFP_KERNEL, "%s-%s", thread_name, + dev_name(bd->dev)); + if (!wq_name) + return NULL; + + wq =3D create_singlethread_workqueue(wq_name); + kfree(wq_name); + + return wq; +} + int bnge_netdev_alloc(struct bnge_dev *bd, int max_irqs) { struct net_device *netdev; @@ -2784,6 +2850,17 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_i= rqs) if (bd->tso_max_segs) netif_set_tso_max_segs(netdev, bd->tso_max_segs); =20 + INIT_WORK(&bn->sp_task, bnge_sp_task); + timer_setup(&bn->timer, bnge_timer, 0); + bn->current_interval =3D BNGE_TIMER_INTERVAL; + + bn->bnge_pf_wq =3D bnge_create_workqueue_thread(bd, "bnge_pf_wq"); + if (!bn->bnge_pf_wq) { + netdev_err(netdev, "Unable to create workqueue.\n"); + rc =3D -ENOMEM; + goto err_netdev; + } + bn->rx_ring_size =3D BNGE_DEFAULT_RX_RING_SIZE; bn->tx_ring_size =3D BNGE_DEFAULT_TX_RING_SIZE; bn->rx_dir =3D DMA_FROM_DEVICE; @@ -2799,11 +2876,13 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_= irqs) rc =3D register_netdev(netdev); if (rc) { dev_err(bd->dev, "Register netdev failed rc: %d\n", rc); - goto err_netdev; + goto err_free_workq; } =20 return 0; =20 +err_free_workq: + destroy_workqueue(bn->bnge_pf_wq); err_netdev: free_netdev(netdev); return rc; @@ -2812,8 +2891,15 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_i= rqs) void bnge_netdev_free(struct bnge_dev *bd) { struct net_device *netdev =3D bd->netdev; + struct bnge_net *bn; + + bn =3D netdev_priv(netdev); =20 unregister_netdev(netdev); + + cancel_work_sync(&bn->sp_task); + destroy_workqueue(bn->bnge_pf_wq); + free_netdev(netdev); bd->netdev =3D NULL; } diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 70f1a7c2481..f7446b7c4ba 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -224,6 +224,13 @@ struct bnge_tpa_info { #define BNGE_NQ_HDL_TYPE(hdl) (((hdl) & BNGE_NQ_HDL_TYPE_MASK) >> \ BNGE_NQ_HDL_TYPE_SHIFT) =20 +enum bnge_net_state { + BNGE_STATE_NAPI_DISABLED, + BNGE_STATE_IN_SP_TASK, +}; + +#define BNGE_TIMER_INTERVAL HZ + struct bnge_net { struct bnge_dev *bd; struct net_device *netdev; @@ -281,13 +288,18 @@ struct bnge_net { u32 stats_coal_ticks; =20 unsigned long state; -#define BNGE_STATE_NAPI_DISABLED 0 =20 u32 msg_enable; u16 max_tpa; __be16 vxlan_port; __be16 nge_port; __be16 vxlan_gpe_port; + + atomic_t intr_sem; + unsigned int current_interval; + struct timer_list timer; + struct workqueue_struct *bnge_pf_wq; + struct work_struct sp_task; }; =20 #define BNGE_DEFAULT_RX_RING_SIZE 511 @@ -556,6 +568,11 @@ struct bnge_l2_filter { refcount_t refcnt; }; =20 +static inline bool bnge_drv_busy(struct bnge_net *bn) +{ + return test_bit(BNGE_STATE_IN_SP_TASK, &bn->state); +} + u16 bnge_cp_ring_for_rx(struct bnge_rx_ring_info *rxr); u16 bnge_cp_ring_for_tx(struct bnge_tx_ring_info *txr); void bnge_fill_hw_rss_tbl(struct bnge_net *bn, struct bnge_vnic_info *vnic= ); --=20 2.47.3