From nobody Fri Apr 17 04:46:49 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ABA3142E83 for ; Mon, 23 Feb 2026 14:16:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771856210; cv=none; b=P8s55RpwtEcD4GrrGiv22eDK49doWuU+JaiP5ia9kWcE52spEIIgxIXsGBjZlBk7rMuRsNfI3NY/zBlz3z/xFDzNLL3/OvzeM8KaOZhr5YCx0L3dmUodDzDtg6sLh87CDJd32pdU/0ZKTs75heF/HUj/90Fqb/wRBHxIs8+LbbY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771856210; c=relaxed/simple; bh=zimTNkrg0ZyWuT6VPon1wDI4xK8T2vL3qg1I5l/4UrY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gnU+T12SsmvhRaFgcF0SztH2R5m5qy4RGWiU9cfw3UUrGVButR1mkWZsddz/6Vul6rTlBo35d6qBxxtNFpbu8aTFyta0CVVJePFali6w0LhIeOjxvJnr6+8v1z+wl5yWd+D8qcg/tds7sIqPKpiUki2G59WIa+NWEMBFgwiK9RI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VZmVnMPW; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VZmVnMPW" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4836f4cbe0bso33066705e9.3 for ; Mon, 23 Feb 2026 06:16:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771856208; x=1772461008; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HJysTvCTqmpRUuXQbPd6ZdWuCMMviCnnW2mHB9RPSLQ=; b=VZmVnMPWVN+xAtey8aBAT3GDp/rZu3Mg1I3JyNExZzAGkRm4J4tkl6tV8x94utnlxV LebYEBwYlYAoWCSRnrIJrVPPgLWOUzZ6rbqUq0oFehPZDxQWkU9IYrz5E762FeeFL0uU oHLqO9IPzm/7eV8Pyp7XPErbQ2slfK6hceds9Gg1V+o+TU0ZTtKNLByAwQwH0JkHxSJ6 6OMcoYPFjiwQ/4LLb2yoyFnsIjjPedyoMpPopuX8o4zKZejB1ZQUmhS+XjkU8wYIivKU NjyTXZxfv5BjI/AamrMxFPaPZ4+T2MtInwL+Xb7QnVpWJdXoOgKL0iV1GZ20HGIPp1vx 6OMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771856208; x=1772461008; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HJysTvCTqmpRUuXQbPd6ZdWuCMMviCnnW2mHB9RPSLQ=; b=sLB89xHgxPc7dtrCspR9Ri/wo4e5xIkqmi1f1S23vgn48JhBMiqflVTbaY1/ERVB1w rCiTE3JOFYAn3yh0xWL5jp2TCPGumgMex3rF71g6++wyQQ/whL2/LG6qnIqE2P7XgJ80 xDHlu4xSfDqicdMA4NhvPa5HvrFgpuBIBBNryYwPgcZ49wZA2lVRw2zxSvwnXlTZReJf aWda9MtwJ3VGl5yoX3ixIW10NlFO39/X52V0+KMVfn4/c6jdqlkqL3SOLSaafTP6p0Ir 3HYSBbBy0iFmb0cKJnuMs7POSUMP9ELLXW5fmb6ikMqYWbzJlrJXGPJ5hr+hmKjpb71M gskA== X-Forwarded-Encrypted: i=1; AJvYcCUehcmmOdJWsbewnwm1G2LJCfH9wL6M5qjT7RRGmK2iueR/LU76ubqAqpqmKSOfC9itlvIffUp6pdShxsM=@vger.kernel.org X-Gm-Message-State: AOJu0YxsEg+YYgJQrCrI+gpyOzSUxqU6saV6VE9bKiNdK9UfGfi4t+P9 IbC0Z24nOLiKWzkQTL0MiZUoE0D4bGi8U1dp3eKENbdAHYiRWaPRJvA8 X-Gm-Gg: AZuq6aKWAU9UOrbYprARDoCQIAMv97MXM99Zt5gcdYEZmegKAVPhLrcyLSD7ADec5hz aDLhR8RUWx0Pa4fuQKqEm9B+aQXNvXWZyQUd6FoSxowMTIKdS4ccCKbBTVYY9ZXxR6XVMxFLbEb RDKzFRcd7Lyl0ybqj5hTTAAAMDmRg/dPyo+ubX5U5mHDHrPdvTdqAaIhwThWL4DbZ+ZrYQRHoMg OAGnXmwty9FxfdnVNW+ZrKCGS5nNRvT6lfLlzAsGS8290+L8BHg2iyD38tZd3v+yvNlTyBZtxWM utczryMDTRGdwYNPOxcZR18UPfOLHXAYGIehmM0b6rKIto8fz5QrM9a0GRVCM/P+l39bEhMPomq o+yIumU4UvFQGAtapkYsv5gDyCPPElwRTMC85m71k7eeo/8YemSmChAfloy11oBmCiWAiv8LVRS IUYWgOntlTjDkU0xbxgCQ= X-Received: by 2002:a05:600c:6206:b0:46f:d682:3c3d with SMTP id 5b1f17b1804b1-483a95b71b5mr161419085e9.13.1771856207390; Mon, 23 Feb 2026 06:16:47 -0800 (PST) Received: from luca-vm.lan ([154.61.61.58]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a43088fdsm86531165e9.30.2026.02.23.06.16.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 06:16:46 -0800 (PST) From: Luca Leonardo Scorcia To: linux-mediatek@lists.infradead.org Cc: Luca Leonardo Scorcia , AngeloGioacchino Del Regno , Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , CK Hu , Alexandre Mergnat , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] drm/mediatek: dsi: Store driver data before invoking mipi_dsi_host_register Date: Mon, 23 Feb 2026 14:16:34 +0000 Message-ID: <20260223141638.2022490-1-l.scorcia@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The call to mipi_dsi_host_register triggers a callback to mtk_dsi_bind, which uses dev_get_drvdata to retrieve the mtk_dsi struct, so this structure needs to be stored inside the driver data before invoking it. As drvdata is currently uninitialized it leads to a crash when registering the DSI DRM encoder right after acquiring the mode_config.idr_mutex, blocking all subsequent DRM operations. Fixes the following crash during mediatek-drm probe (tested on Xiaomi Smart Clock x04g): Unable to handle kernel NULL pointer dereference at virtual address 0000000000000040 [...] Modules linked in: mediatek_drm(+) drm_display_helper cec drm_client_lib drm_dma_helper drm_kms_helper panel_simple [...] Call trace: drm_mode_object_add+0x58/0x98 (P) __drm_encoder_init+0x48/0x140 drm_encoder_init+0x6c/0xa0 drm_simple_encoder_init+0x20/0x34 [drm_kms_helper] mtk_dsi_bind+0x34/0x13c [mediatek_drm] component_bind_all+0x120/0x280 mtk_drm_bind+0x284/0x67c [mediatek_drm] try_to_bring_up_aggregate_device+0x23c/0x320 __component_add+0xa4/0x198 component_add+0x14/0x20 mtk_dsi_host_attach+0x78/0x100 [mediatek_drm] mipi_dsi_attach+0x2c/0x50 panel_simple_dsi_probe+0x4c/0x9c [panel_simple] mipi_dsi_drv_probe+0x1c/0x28 really_probe+0xc0/0x3dc __driver_probe_device+0x80/0x160 driver_probe_device+0x40/0x120 __device_attach_driver+0xbc/0x17c bus_for_each_drv+0x88/0xf0 __device_attach+0x9c/0x1cc device_initial_probe+0x54/0x60 bus_probe_device+0x34/0xa0 device_add+0x5b0/0x800 mipi_dsi_device_register_full+0xdc/0x16c mipi_dsi_host_register+0xc4/0x17c mtk_dsi_probe+0x10c/0x260 [mediatek_drm] platform_probe+0x5c/0xa4 really_probe+0xc0/0x3dc __driver_probe_device+0x80/0x160 driver_probe_device+0x40/0x120 __driver_attach+0xc8/0x1f8 bus_for_each_dev+0x7c/0xe0 driver_attach+0x24/0x30 bus_add_driver+0x11c/0x240 driver_register+0x68/0x130 __platform_register_drivers+0x64/0x160 mtk_drm_init+0x24/0x1000 [mediatek_drm] do_one_initcall+0x60/0x1d0 do_init_module+0x54/0x240 load_module+0x1838/0x1dc0 init_module_from_file+0xd8/0xf0 __arm64_sys_finit_module+0x1b4/0x428 invoke_syscall.constprop.0+0x48/0xc8 do_el0_svc+0x3c/0xb8 el0_svc+0x34/0xe8 el0t_64_sync_handler+0xa0/0xe4 el0t_64_sync+0x198/0x19c Code: 52800022 941004ab 2a0003f3 37f80040 (29005a80) Reviewed-by: AngeloGioacchino Del Regno ---[ end trace 0000000000000000 ]--- Fixes: e4732b590a77 ("drm/mediatek: dsi: Register DSI host after acquiring = clocks and PHY") Signed-off-by: Luca Leonardo Scorcia Reviewed-by: AngeloGioacchino Del Regno --- v2: Added Fixes tag drivers/gpu/drm/mediatek/mtk_dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/= mtk_dsi.c index d7726091819c..af4871de9e4c 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -1232,6 +1232,8 @@ static int mtk_dsi_probe(struct platform_device *pdev) =20 dsi->host.ops =3D &mtk_dsi_ops; dsi->host.dev =3D dev; + platform_set_drvdata(pdev, dsi); + ret =3D mipi_dsi_host_register(&dsi->host); if (ret < 0) return dev_err_probe(dev, ret, "Failed to register DSI host\n"); @@ -1245,8 +1247,6 @@ static int mtk_dsi_probe(struct platform_device *pdev) =20 init_waitqueue_head(&dsi->irq_wait_queue); =20 - platform_set_drvdata(pdev, dsi); - dsi->bridge.of_node =3D dev->of_node; dsi->bridge.type =3D DRM_MODE_CONNECTOR_DSI; =20 --=20 2.43.0